Code review comment for lp:~akretion-team/partner-contact-management/base-location-geonames-import

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Hello Alexis, many thanks for the module.

What do you think about creating the res.country.state records if they don't exist, before mapping them in the 'states' dictionary?

The current version is supposed to correctly work with states if you first create states data by modules like l10n_fr_state.
But if base_location_geonames_import also imported states data from geonames (creating records if they don't exist yet) we would not need an extra module just to create states data.

« Back to merge proposal