Merge lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:~partner-contact-core-editors/partner-contact-management/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~akretion-team/partner-contact-management/base-location-geonames-import |
Merge into: | lp:~partner-contact-core-editors/partner-contact-management/7.0 |
Diff against target: |
437 lines (+400/-0) 7 files modified
base_location_geonames_import/__init__.py (+23/-0) base_location_geonames_import/__openerp__.py (+47/-0) base_location_geonames_import/i18n/base_location_geonames_import.pot (+68/-0) base_location_geonames_import/i18n/fr.po (+68/-0) base_location_geonames_import/wizard/__init__.py (+23/-0) base_location_geonames_import/wizard/geonames_import.py (+127/-0) base_location_geonames_import/wizard/geonames_import_view.xml (+44/-0) |
To merge this branch: | bzr merge lp:~akretion-team/partner-contact-management/base-location-geonames-import |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lorenzo Battistini (community) | Needs Resubmitting | ||
Nicolas Bessi - Camptocamp (community) | Needs Fixing | ||
Review via email: mp+214564@code.launchpad.net |
Description of the change
Add module base_location_
Nicolas Bessi suggested on twitter that it should be part of the geospacial addons. But, after thinking about it, my opinion is that this module would be better here, because users of the "base_location" module would have a higher chance of finding this module here than in the geospacial addons.
Unmerged revisions
- 44. By Alexis de Lattre
-
[MERGE] merge with trunk revno 40.
- 43. By Alexis de Lattre
-
Remove France-specific code ; moved to new module l10n_fr_
base_location_ geonames_ import on lp:openerp-french-localization - 42. By Alexis de Lattre
-
Add a FOR UPDATE NOWAIT at the beginning of the transaction.
- 41. By Alexis de Lattre
-
Insist on the fact that the wizard deletes current better zip entries in the module description and in the wizard itself.
Better error message when the country code inside the file is wrong. - 40. By Alexis de Lattre
-
Allow to skip entries in the _prepare method.
- 39. By Alexis de Lattre
-
Add support for states (if states are already present in res.country.state).
Add POT file and FR translation. - 38. By Alexis de Lattre
-
Add module base_location_
geonames_ import
Hello thanks for the patch.
Is there a good reason not to merge it here: https:/ /launchpad. net/geospatial- addons ?
Some tests would also be a nice addition.