Code review comment for lp:~akretion-team/partner-contact-management/base-location-geonames-import

Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

Thank for the fixes.
The "UPDATE NO WAIT" will lock the selected rows at postgres database level.
It will avoid a process using the base_location data to alter flushed entries.
It will also avoiding having many concurrent instance of the wizard running on the same rows.
In this case I wonder if we may not want to put a lock on the whole table has we add new entries.

For the test I will see ifI can provide some but I'm in holiday next week, so it have to wait a little.

Regards

Nicolas

« Back to merge proposal