Code review comment for lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> About your second comment, As I merged your branch, the table is locked at the beginning of the _run method, so it should be enought to avoid the problem of creating 2 bindings at the same time no?

No, the table is not locked. The 'magento.res.partner' *record* that is exported is locked. Then, when it creates a 'magento.address', only a unique constraint on 'magento.address' can prevent 2 concurrent jobs to create the same 'magento.address'.

« Back to merge proposal