Merge lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0

[Florian da Costa]

I have completed the magentoerpconnect_export_partner module to fix the export of partners and add the export of addresses.

I have added a method '_after_export' in MagentoExporter so we do not need to manually add the magento bind address for each partner and contact.

I still have to implement some tests.

What do you think?

[Florian da Costa (florian-dacosta)]

here, I have added the tests.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi Florian,

Thanks for your proposal.
I left some comments in the diff.

review: Needs Fixing

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Also, you should take a look at: https://code.launchpad.net/~camptocamp/openerp-connector-magento/7.0-export-dependency+lock/+merge/223508
And use this branch as base, I left some comments in the diff where you should use some of my branch's features.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

What about the password?

[lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address]

1004. By Florian da Costa on 2014-06-23

[MERGE]

1005. By Florian da Costa on 2014-06-23

[FIX]Remove useless code + improve basic stuff to export partner

[Florian da Costa (florian-dacosta)]

Thanks for the fast feedback!

I have re-submited in order to add your branch as a Prerequisite, and I merged it.
I have answered your diff comments in the other merge proposal so it is not lost...

About the password, I have add a field in res_partner. The purpose of this field is to contain an already coded password.

The main point I still have to change is to adapt the behavior of the export of company partner, I will do it as soon as I have your feedback on what I have commented in the diff of the other merge proposal

(https://code.launchpad.net/~akretion-team/openerp-connector-magento/7.0-export-partner-and-address/+merge/222825)

[Florian da Costa (florian-dacosta)]

An other remark, the method "_validate_data(data)" should be used only for creating a record, and not for an update no?
Because it seems the direct mapping is not done on the field which are not modified.

During my tests, when an address is already created in magento, and I modified it on openerp, it will fail because the _validate_data method won't find the field city and postcode.
Unless the 2 corresponding fields are modified in openerp. (then the direct mapping seems to work for theses fields.)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> About the password, I have add a field in res_partner. The purpose of this
> field is to contain an already coded password.

How a user can input an encrypted password? Would we have a mean to encrypt it? It would require the salt so I don't think so...

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> An other remark, the method "_validate_data(data)" should be used only for
> creating a record, and not for an update no?
You are right, I think we should have one validate_create_data and one validate_update_data (maybe useless).

> Because it seems the direct mapping is not done on the field which are not
> modified.
That's right, we do not want to useless data when the values did not change.
In fact, you remark remind me that you should use the @changed_by() decorator on top of the @mapping methods

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks for the changes so far!
I added new comments

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> I have not changed anything about that already. The idea here, would be to simplify the behavior. If we could merge the module Alexis did into the base modules: http://bazaar.launchpad.net/~akretion-team/+junk/70-usability/files/head:/base_partner_always_multi_contacts/ We could just use the field 'is_company' instead of the new field 'consider_as_company' on magento.res.partner, it would be a lot cleaner I think. Then I would adapt the export so it has the same behavior as the import : If the partner is a company (is_company) I will export it has an account in magento, without the address if the partner is not a company, I will export it has an account And an address. (Of course, the contact will always be exported as addresses) What do you think ?

I don't think we can change that now that we have users in production. Also, it would not be really simpler: only a boolean field would change, but the handling of the addresses would still be the same.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> About your second comment, As I merged your branch, the table is locked at the beginning of the _run method, so it should be enought to avoid the problem of creating 2 bindings at the same time no?

No, the table is not locked. The 'magento.res.partner' *record* that is exported is locked. Then, when it creates a 'magento.address', only a unique constraint on 'magento.address' can prevent 2 concurrent jobs to create the same 'magento.address'.

[Florian da Costa (florian-dacosta)]

> I don't think we can change that now that we have users in production. Also,
> it would not be really simpler: only a boolean field would change, but the
> handling of the addresses would still be the same.

It would be cleaner, about the export, to use the existing is_company field instead of asking the user to fill an other new field for the same purpose.
Would it be ok to do so if I propose a migration script?

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

> > I have not changed anything about that already. The idea here, would be to
> simplify the behavior. If we could merge the module Alexis did into the base
> modules: http://bazaar.launchpad.net/~akretion-
> team/+junk/70-usability/files/head:/base_partner_always_multi_contacts/ We
> could just use the field 'is_company' instead of the new field
> 'consider_as_company' on magento.res.partner, it would be a lot cleaner I
> think. Then I would adapt the export so it has the same behavior as the import
> : If the partner is a company (is_company) I will export it has an account in
> magento, without the address if the partner is not a company, I will export it
> has an account And an address. (Of course, the contact will always be exported
> as addresses) What do you think ?
>
> I don't think we can change that now that we have users in production. Also,
> it would not be really simpler: only a boolean field would change, but the
> handling of the addresses would still be the same.

Hi Guewen, indeed having the field 'is_company' or 'consider_as_company' tick when is a company will not simplify the code. The only change is that we "fix" the OpenERP/Odoo mistake that force user to tock "is_company" when it's not a company. Our customer really do not understand why they have to tick that box for B2C customer. I think it can be a good improvement if we merge the base module in OCA and then we add the dependency on MagentoERPconnect for the next release. For sure if we do that we have to do the migration script so user can easily migrate to the new version. What do you think?

[Florian da Costa (florian-dacosta)]

> How a user can input an encrypted password? Would we have a mean to encrypt
> it? It would require the salt so I don't think so...

About that, the idea would be to, later, develop a kind of wizard to allow the user to enter the password and encrypt them.
For the moment, even if the user can't encrypt it yet, it will already help if one already get encrypted passwords and import it into openerp.

If it does not seem reasonable, I will change it so we have to enter none-coded password in openerp.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

>
> Hi Guewen, indeed having the field 'is_company' or 'consider_as_company' tick
> when is a company will not simplify the code. The only change is that we "fix"
> the OpenERP/Odoo mistake that force user to tock "is_company" when it's not a
> company. Our customer really do not understand why they have to tick that box
> for B2C customer. I think it can be a good improvement if we merge the base
> module in OCA and then we add the dependency on MagentoERPconnect for the next
> release. For sure if we do that we have to do the migration script so user can
> easily migrate to the new version. What do you think?

Hi,

So the first step is to have it merged in the OCA.
I don't really figure what are the impacts at the moment. Are you sure this is matter of a view? Are the questions that were raised here https://bugs.launchpad.net/openobject-server/+bug/1151947 addressed?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> > How a user can input an encrypted password? Would we have a mean to encrypt
> > it? It would require the salt so I don't think so...
>
> About that, the idea would be to, later, develop a kind of wizard to allow the
> user to enter the password and encrypt them.
> For the moment, even if the user can't encrypt it yet, it will already help if
> one already get encrypted passwords and import it into openerp.
>
> If it does not seem reasonable, I will change it so we have to enter none-
> coded password in openerp.

I can't convince myself that the use case of someone having already encrypted password is a realistic scenario.

An other approach could be to display a link on partner to open the Magento admin so he can file a password, but this is not so nice since it would need to go on the partner form after the job has been executed.

[lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address]

1006. By Florian da Costa on 2014-06-24

[FIX] add change_by decorator on mapping methods

1007. By Florian da Costa on 2014-06-24

[FIX]change method _validate_data to make 2 different method, one for create a record, one for update + do not export a partner like an address if it is a company

[Florian da Costa (florian-dacosta)]

Ok, so now, the password does not need to be coded on openerp side.
The export has a similar behavior with the import. (if the field consider_as_company is ticked, it won't create magento.address binding on the main partner)
I also export the company name in the addresses and I use the field 'type' of res.partner to tick the is_default_billing and is_default_shipping.

I think I took into account all your comments, it should be quite ok now.

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

@Guewen
For the password we have encrypted one in our case because we import existing password from an existing system. But I agree it's not the main case. Regarding storing the magento_password on OpenERP side I am not sure it's a good idea. Maybe a wizard can change the password from OpenERP but the password should be not store on OpenERP side, what do you think? (By default we can remove the password field and mapping and latter we can add a wizard?)

For the partner/contact issue. I was also really surprise by Alexis work, but looking at it twice and doing a grep on "is_company" in the addons. It seem that it work correctly (OpenERP take the parent_id if the is_company is not tick). So it ok for B2C. I think OpenERP did the correct change to make it working because at the release time of 7, only changing the view was not enough.

Let's propose a merge to OCA ;)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

On 06/24/2014 02:25 PM, Sébastien BEAU - http://www.akretion.com wrote:
> @Guewen
> For the password we have encrypted one in our case because we import existing password from an existing system. But I agree it's not the main case. Regarding storing the magento_password on OpenERP side I am not sure it's a good idea. Maybe a wizard can change the password from OpenERP but the password should be not store on OpenERP side, what do you think? (By default we can remove the password field and mapping and latter we can add a wizard?)
>
Alright. I agree, it should not be stored on OpenERP, a wizard could do it.
> For the partner/contact issue. I was also really surprise by Alexis work, but looking at it twice and doing a grep on "is_company" in the addons. It seem that it work correctly (OpenERP take the parent_id if the is_company is not tick). So it ok for B2C. I think OpenERP did the correct change to make it working because at the release time of 7, only changing the view was not enough.
>
Nice!

[Florian da Costa (florian-dacosta)]

So finally, should I just remove the password feature for now and it would be ready to merge?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

This project is now hosted on https://github.com/OCA/connector-magento. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

review: Needs Resubmitting

[lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address]

1008. By Florian da Costa on 2014-09-10

[FIX] Remove password field, it will be handle by a wizard

Unmerged revisions

1008. By Florian da Costa on 2014-09-10

[FIX] Remove password field, it will be handle by a wizard

1007. By Florian da Costa on 2014-06-24

[FIX]change method _validate_data to make 2 different method, one for create a record, one for update + do not export a partner like an address if it is a company

1006. By Florian da Costa on 2014-06-24

[FIX] add change_by decorator on mapping methods

1005. By Florian da Costa on 2014-06-23

[FIX]Remove useless code + improve basic stuff to export partner

1004. By Florian da Costa on 2014-06-23

[MERGE]

1003. By Florian da Costa on 2014-06-12

[IMP] Add tests

1002. By Florian da Costa on 2014-06-11

[IMP] fix partner export + add address export

=== modified file 'magentoerpconnect/partner.py'
--- magentoerpconnect/partner.py	2014-05-26 09:37:00 +0000
+++ magentoerpconnect/partner.py	2014-09-10 13:43:53 +0000
@@ -78,7 +78,7 @@
     _inherits = {'res.partner': 'openerp_id'}
     _description = 'Magento Partner'
 
-    _rec_name = 'website_id'
+    _rec_name = 'name'
 
     def _get_mag_partner_from_website(self, cr, uid, ids, context=None):
         mag_partner_obj = self.pool['magento.res.partner']
@@ -199,6 +199,8 @@
     _sql_constraints = [
         ('magento_uniq', 'unique(backend_id, magento_id)',
          'A partner address with same ID on Magento already exists.'),
+        ('openerp_uniq', 'unique(backend_id, openerp_id)',
+         'A partner address can only have one binding by backend.'),
     ]
 
 
@@ -568,6 +570,11 @@
                               [filters] if filters else [{}])]
 
 
+    def create(self, data):
+        """ Create a record on the external system """
+        partner_id = data.pop('partner_id')
+        return self._call('%s.create' % self._magento_model, [partner_id, data])
+
 @magento
 class AddressImport(MagentoImportSynchronizer):
     _model_name = ['magento.address']

=== modified file 'magentoerpconnect/partner_view.xml'
--- magentoerpconnect/partner_view.xml	2013-06-20 14:26:32 +0000
+++ magentoerpconnect/partner_view.xml	2014-09-10 13:43:53 +0000
@@ -43,6 +43,7 @@
                         <field name="emailid"/>
                         <field name="taxvat"/>
                         <field name="newsletter"/>
+                        <field name="consider_as_company"/>
                     </group>
                 </form>
             </field>

=== modified file 'magentoerpconnect/unit/export_synchronizer.py'
--- magentoerpconnect/unit/export_synchronizer.py	2014-09-10 13:43:52 +0000
+++ magentoerpconnect/unit/export_synchronizer.py	2014-09-10 13:43:53 +0000
@@ -128,6 +128,7 @@
         # The commit will also release the lock acquired on the binding
         # record
         self.session.commit()
+        self._after_export()
         return result
 
     def _run(self):
@@ -256,7 +257,6 @@
         # 'product.product' record but the binding model is
         # 'magento.product.product'
         wrap = relation._model._name != binding_model
-
         if wrap and hasattr(relation, binding_field):
             domain = [('openerp_id', '=', relation.id),
                       ('backend_id', '=', self.backend_record.id)]
@@ -294,7 +294,6 @@
             # "direct" binding (the binding record is the same record).
             # If wrap is True, relation is already a binding record.
             binding_id = relation.id
-
         if rel_binder.to_backend(binding_id) is None:
             exporter = self.get_connector_unit_for_model(exporter_class,
                                                          binding_model)
@@ -311,7 +310,22 @@
         """
         return self.mapper.map_record(self.binding_record)
 
-    def _validate_data(self, data):
+
+    def _after_export(self):
+        """ Can do several actions after exporting a record on magento """
+        pass
+
+    def _validate_create_data(self, data):
+        """ Check if the values to import are correct
+
+        Pro-actively check before the ``Model.create`` or
+        ``Model.update`` if some fields are missing
+
+        Raise `InvalidDataError`
+        """
+        return
+
+    def _validate_update_data(self, data):
         """ Check if the values to import are correct
 
         Pro-actively check before the ``Model.create`` or
@@ -328,7 +342,7 @@
     def _create(self, data):
         """ Create the Magento record """
         # special check on data before export
-        self._validate_data(data)
+        self._validate_create_data(data)
         return self.backend_adapter.create(data)
 
     def _update_data(self, map_record, fields=None, **kwargs):
@@ -339,7 +353,7 @@
         """ Update an Magento record """
         assert self.magento_id
         # special check on data before export
-        self._validate_data(data)
+        self._validate_update_data(data)
         self.backend_adapter.write(self.magento_id, data)
 
     def _run(self, fields=None):

=== modified file 'magentoerpconnect_export_partner/__init__.py'
--- magentoerpconnect_export_partner/__init__.py	2013-03-19 16:53:26 +0000
+++ magentoerpconnect_export_partner/__init__.py	2014-09-10 13:43:53 +0000
@@ -1,4 +1,4 @@
 # -*- coding: utf-8 -*-
-
-import consumer
-import partner
+from . import connector
+from . import consumer
+from . import partner

=== modified file 'magentoerpconnect_export_partner/consumer.py'
--- magentoerpconnect_export_partner/consumer.py	2013-10-09 19:41:58 +0000
+++ magentoerpconnect_export_partner/consumer.py	2014-09-10 13:43:53 +0000
@@ -28,8 +28,8 @@
 import openerp.addons.magentoerpconnect.consumer as magentoerpconnect
 
 
-@on_record_create(model_names='magento.res.partner')
-@on_record_write(model_names='magento.res.partner')
+@on_record_create(model_names=['magento.address', 'magento.res.partner'])
+@on_record_write(model_names=['magento.address', 'magento.res.partner'])
 def delay_export(session, model_name, record_id, vals):
     magentoerpconnect.delay_export(session, model_name,
                                    record_id, vals)
@@ -41,6 +41,17 @@
                                                 record_id, vals)
 
 
-@on_record_unlink(model_names='magento.res.partner')
+@on_record_write(model_names='res.partner')
+def delay_export_all_bindings_for_address(session, model_name, 
+                                          record_id, vals):
+    if session.context.get('connector_no_export'):
+        return
+    record = session.browse(model_name, record_id)
+    for binding in record.magento_address_bind_ids:
+        magentoerpconnect.delay_export(session, binding._model._name,
+                                       binding.id, vals)
+
+
+@on_record_unlink(model_names=['magento.res.partner', 'magento.address'])
 def delay_unlink(session, model_name, record_id):
     magentoerpconnect.delay_unlink(session, model_name, record_id)

=== modified file 'magentoerpconnect_export_partner/partner.py'
--- magentoerpconnect_export_partner/partner.py	2013-05-01 09:54:36 +0000
+++ magentoerpconnect_export_partner/partner.py	2014-09-10 13:43:53 +0000
@@ -23,48 +23,184 @@
 from openerp.addons.connector.unit.mapper import (mapping,
                                                   changed_by,
                                                   ExportMapper)
+from openerp.addons.connector.exception import InvalidDataError
 from openerp.addons.magentoerpconnect.unit.delete_synchronizer import (
         MagentoDeleteSynchronizer)
 from openerp.addons.magentoerpconnect.unit.export_synchronizer import (
         MagentoExporter)
+from openerp.addons.magentoerpconnect.partner import (
+        AddressAdapter)
 from openerp.addons.magentoerpconnect.backend import magento
 
 
 @magento
 class PartnerDeleteSynchronizer(MagentoDeleteSynchronizer):
     """ Partner deleter for Magento """
-    _model_name = ['magento.res.partner']
+    _model_name = ['magento.res.partner',
+                   'magento.address']
 
 
 @magento
 class PartnerExport(MagentoExporter):
     _model_name = ['magento.res.partner']
 
+    def _after_export(self):
+        data = {
+            'magento_partner_id': self.binding_id,
+        }
+        if not self.binding_record.magento_address_bind_ids \
+        and not self.binding_record.consider_as_company:
+            data['openerp_id'] = self.binding_record.openerp_id.id
+
+            if not self.binding_record.child_ids:
+                data['is_default_billing'] = True
+                data['is_default_shipping'] = True
+
+            with self._retry_unique_violation():
+                self.session.create('magento.address', data)
+
+        for child in self.binding_record.child_ids:
+            if not child.magento_address_bind_ids:
+                if child.type == 'invoice':
+                    data['is_default_billing'] = True
+                else:
+                    data['is_default_billing'] = False
+                if child.type == 'delivery':
+                    data['is_default_shipping'] = True
+                else:
+                    data['is_default_shipping'] = False
+                data['openerp_id'] = child.id
+                with self._retry_unique_violation():
+                    self.session.create('magento.address', data)
+
+    def _validate_create_data(self, data):
+        """ Check if the values to import are correct
+
+        Pro-actively check before the ``Model.create`` or
+        ``Model.update`` if some fields are missing
+
+        Raise `InvalidDataError`
+        """
+        if not data.get('email'):
+            raise InvalidDataError("The partner does not have an email "
+                                   "but it is mandatory for Magento")
+
+
+@magento
+class AddressExport(MagentoExporter):
+    _model_name = ['magento.address']
+
+    def _export_dependencies(self):
+        """ Export the dependencies for the record"""
+        relation = self.binding_record.parent_id or self.binding_record.openerp_id
+        self._export_dependency(relation, 'magento.res.partner',
+                                exporter_class=PartnerExport)
+
+    def _validate_create_data(self, data):
+        """ Check if the values to import are correct
+
+        Pro-actively check before the ``Model.create`` or
+        ``Model.update`` if some fields are missing
+
+        Raise `InvalidDataError`
+        """
+        missing_fields = []
+        for required_key in ('city', 'street', 'postcode', 'country_id', 'telephone'):
+            if not data.get(required_key):
+                missing_fields.append(required_key)
+        if missing_fields:
+            raise InvalidDataError("The address does not contain one or several "
+                                   "mandatory fields for Magento : %s" %
+                                   missing_fields)
+
 
 @magento
 class PartnerExportMapper(ExportMapper):
     _model_name = 'magento.res.partner'
 
     direct = [
-            ('emailid', 'email'),
             ('birthday', 'dob'),
             ('created_at', 'created_at'),
             ('updated_at', 'updated_at'),
-            ('emailid', 'email'),
             ('taxvat', 'taxvat'),
             ('group_id', 'group_id'),
             ('website_id', 'website_id'),
         ]
 
-    @changed_by('name')
-    @mapping
-    def names(self, record):
-        # FIXME base_surname needed
-        if ' ' in record.name:
-            parts = record.name.split()
-            firstname = parts[0]
-            lastname = ' '.join(parts[1:])
-        else:
-            lastname = record.name
-            firstname = '-'
-        return {'firstname': firstname, 'lastname': lastname}
+    @changed_by('email', 'emailid')
+    @mapping
+    def email(self, record):
+        email = record.emailid or record.email
+        return {'email': email}
+
+    @changed_by('name')
+    @mapping
+    def names(self, record):
+        if ' ' in record.name:
+            parts = record.name.split()
+            firstname = parts[0]
+            lastname = ' '.join(parts[1:])
+        else:
+            lastname = record.name
+            firstname = '-'
+        return {'firstname': firstname, 'lastname': lastname}
+
+
+@magento
+class PartnerAddressExportMapper(ExportMapper):
+    _model_name = 'magento.address'
+ 
+    direct = [('zip', 'postcode'),
+              ('city', 'city'),
+              ('is_default_billing', 'is_default_billing'),
+              ('is_default_shipping', 'is_default_shipping'),
+              ('company', 'company'),
+              ]
+
+    @changed_by('parent_id', 'openerp_id')
+    @mapping
+    def partner(self, record):
+        binder = self.get_binder_for_model('magento.res.partner')
+        erp_partner_id = record.parent_id.id if record.parent_id else record.openerp_id.id
+        mag_partner_id = binder.to_backend(erp_partner_id, wrap=True)
+        return {'partner_id': mag_partner_id}
+ 
+    @changed_by('name')
+    @mapping
+    def names(self, record):
+        if ' ' in record.name:
+            parts = record.name.split()
+            firstname = parts[0]
+            lastname = ' '.join(parts[1:])
+        else:
+            lastname = record.name
+            firstname = '-'
+        return {'firstname': firstname, 'lastname': lastname}
+ 
+    @changed_by('phone', 'mobile')
+    @mapping
+    def phone(self, record):
+        return {'telephone': record.phone or record.mobile}
+
+    @changed_by('country_id')
+    @mapping
+    def country(self, record):
+        if record.country_id:
+            return {'country_id': record.country_id.code}
+ 
+    @changed_by('state_id')
+    @mapping
+    def region(self, record):
+        if record.state_id:
+            return {'region': record.state_id.name}
+ 
+    @changed_by('street', 'street2')
+    @mapping
+    def street(self, record):
+        if record.street:
+            street = record.street
+        if record.street2:
+            street = ['\n'.join([street, record.street2])]
+        if street:
+            return {'street': street}
+

=== added directory 'magentoerpconnect_export_partner/tests'
=== added file 'magentoerpconnect_export_partner/tests/__init__.py'
--- magentoerpconnect_export_partner/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ magentoerpconnect_export_partner/tests/__init__.py	2014-09-10 13:43:53 +0000
@@ -0,0 +1,29 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Florian da Costa
+#    Copyright 2014 Akretion
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import test_synchronization
+
+fast_suite = [
+]
+
+checks = [
+    test_synchronization,
+]

=== added file 'magentoerpconnect_export_partner/tests/test_synchronization.py'
--- magentoerpconnect_export_partner/tests/test_synchronization.py	1970-01-01 00:00:00 +0000
+++ magentoerpconnect_export_partner/tests/test_synchronization.py	2014-09-10 13:43:53 +0000
@@ -0,0 +1,130 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Florian da Costa
+#    Copyright 2014 Akretion
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.addons.magentoerpconnect.tests.test_synchronization import (
+    SetUpMagentoSynchronized)
+from openerp.addons.magentoerpconnect.tests.test_data import (
+    magento_base_responses)
+from openerp.addons.magentoerpconnect.tests.common import (
+    mock_api,
+    mock_urlopen_image)
+from openerp.addons.magentoerpconnect.unit.export_synchronizer import (
+    export_record)
+
+
+class SetUpMagentoWithPartner(SetUpMagentoSynchronized):
+
+    def setUp(self):
+        super(SetUpMagentoWithPartner, self).setUp()
+        cr = self.cr
+        uid = self.uid
+        self.website_id = self.registry('magento.website').search(cr, uid, [
+            ('backend_id', '=', self.backend_id)])[0]
+        oe_partner_model = self.registry('res.partner')
+        country_id = self.registry('res.country').search(cr, uid, [
+            ('code', '=', 'BE')])[0]
+        self.partner_id = oe_partner_model.create(
+            cr, uid,
+            {'name': 'Partner Partner2',
+             'is_company': True,
+             'email': '[e-mail]',
+             'street': '15, test street',
+             'phone': '0000000000',
+             'zip': '00000',
+             'country_id': country_id,
+             'city': 'City test'})
+        self.contact_id = oe_partner_model.create(
+            cr, uid,
+            {'name': 'Contact',
+             'parent_id': self.partner_id,
+             'street': '15, contact test street',
+             'phone': '111111111',
+             'zip': '11111',
+             'country_id': country_id,
+             'city': 'City contact test'})
+
+
+class TestMagentoPartnerExport(SetUpMagentoWithPartner):
+    """ Test the export from a Magento Mock.
+    """
+
+    def test_1_export_partner(self):
+        """ Test export of partner"""
+        response = {
+            'customer.create': True,
+        }
+        cr = self.cr
+        uid = self.uid
+        with mock_api(response, key_func=lambda m, a: m) as calls_done:
+            mag_address_model = self.registry('magento.address')
+            mag_partner_model = self.registry('magento.res.partner')
+            mag_partner_id = mag_partner_model.create(cr, uid, {
+                'website_id': self.website_id,
+                'openerp_id': self.partner_id,
+                })
+            export_record(self.session, 'magento.res.partner', mag_partner_id)
+
+            self.assertEqual(len(calls_done), 1)
+            method, [values] = calls_done[0]
+            self.assertEqual(method, 'customer.create')
+            self.assertEqual(values['email'], '[e-mail]')
+            self.assertEqual(values['firstname'], 'Partner')
+            self.assertEqual(values['lastname'], 'Partner2')
+
+            mag_address_ids = mag_address_model.search(cr, uid, [
+            ('magento_partner_id', '=', mag_partner_id)])
+            self.assertEqual(len(mag_address_ids), 2)
+
+
+    def test_2_export_partner_address(self):
+        """ Test export of address"""
+        response = {
+            'customer_address.create': True,
+        }
+        cr = self.cr
+        uid = self.uid
+        with mock_api(response, key_func=lambda m, a: m) as calls_done:
+            mag_address_model = self.registry('magento.address')
+            mag_partner_model = self.registry('magento.res.partner')
+            mag_partner_id = mag_partner_model.create(cr, uid, {
+                'website_id': self.website_id,
+                'openerp_id': self.partner_id,
+                'magento_id': 1,
+                })
+            mag_address_id = mag_address_model.create(cr, uid, {
+                'magento_partner_id': mag_partner_id,
+                'openerp_id': self.partner_id,
+                })
+            export_record(self.session, 'magento.address', mag_address_id)
+
+            self.assertEqual(len(calls_done), 1)
+
+            method, [partner, values] = calls_done[0]
+
+            self.assertEqual(method, 'customer_address.create')
+            self.assertEqual(partner, 1)
+            self.assertEqual(values['postcode'], '00000')
+            self.assertEqual(values['city'], 'City test')
+            self.assertEqual(values['street'], '15, test street')
+            self.assertEqual(values['country_id'], 'BE')
+            self.assertEqual(values['telephone'], '0000000000')
+
+