Code review comment for lp:~akretion-team/openerp-connector-magento/7.0-export-partner-and-address

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> An other remark, the method "_validate_data(data)" should be used only for
> creating a record, and not for an update no?
You are right, I think we should have one validate_create_data and one validate_update_data (maybe useless).

> Because it seems the direct mapping is not done on the field which are not
> modified.
That's right, we do not want to useless data when the values did not change.
In fact, you remark remind me that you should use the @changed_by() decorator on top of the @mapping methods

« Back to merge proposal