Carriers And Deliveries Management

Code review comment for lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl

  1. 7-base-delivery-carrier-dbl
  2. Merge into 7.0
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the changes. I'm thinking that if the method is intended for customizing sender address, you should return a dictionary that it's written on base module, because in this way, you have to do it your way in your custom module and inheritance is not possible in this way.

You can see one of this type of hooks in prepare_inv_line of sale module.

Regards.

review: Needs Fixing (code review)

« Back to merge proposal