Merge lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

[David BEAL (ak)]

add _customize_sender_address method to base_delivery_carrier_label module

Some companies have differents brands, shop or backend and they ship
parcels from each brands without customer knows the real name of the company.

This method does nothing by itself.

It's just a common way to set this info. Python 'super' use allow to override values

Each module carrier module have to implement its own method.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, David, docstring convention says that you have to put one-line doc with three ".

Regards.

review: Needs Fixing (code review)

[lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl]

50. By David BEAL (ak) on 2014-05-28

[FIX] docstring

[David BEAL (ak) (davidbeal)]

Hi Pedro,

Thanks for the review, I fixed it

Here is a use case of sender customization
http://bazaar.launchpad.net/~akretion-team/+junk/sale-multi-shop/view/head:/shop_sender/stock.py

[Pedro Manuel Baeza (pedro.baeza)]

Thanks for the changes. I'm thinking that if the method is intended for customizing sender address, you should return a dictionary that it's written on base module, because in this way, you have to do it your way in your custom module and inheritance is not possible in this way.

You can see one of this type of hooks in prepare_inv_line of sale module.

Regards.

review: Needs Fixing (code review)

[lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl]

51. By David BEAL (ak) on 2014-05-28

[FIX] _customize_sender_address return method

[David BEAL (ak) (davidbeal)]

Hi Pedro,

You're right, it's cleaner to have a real return and set a default behavior.

I changed my code to return a partner.
The code is cleaner in shop_sender module.

Thanks for your advices

Regards

[Pedro Manuel Baeza (pedro.baeza)]

Hi again, David, one thing I don't see is where you use the value returned by this method. Is there something I'm missing?

Regards.

review: Needs Information (code review)

[David BEAL (ak) (davidbeal)]

Pedro,
here is the use case
http://bazaar.launchpad.net/~akretion-team/carriers-deliveries/7-delivery-carrier-coliposte/view/head:/delivery_carrier_colipostefr/stock.py#L119
Regards

[lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl]

52. By David BEAL (ak) on 2014-06-17

[IMP] add comment in _customize_sender_adress()

53. By David BEAL (ak) on 2014-06-17

[FIX] method name to get sender address

54. By David BEAL (ak) on 2014-06-17

[FIX] method comment

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

As itself base_delivery_carrier_label module only provide an interface class, this method here makes sense.

LGTM

review: Approve (code review)

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

LGTM, I agree too. It's only an abstract module that provider a standard API for real implementation

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

OK, I see. Thanks for the clarification.

I approve it and proceed with the merge.

Regards.

review: Approve (code review)

=== modified file 'base_delivery_carrier_label/stock.py'
--- base_delivery_carrier_label/stock.py	2014-03-28 13:19:50 +0000
+++ base_delivery_carrier_label/stock.py	2014-06-17 11:16:57 +0000
@@ -355,6 +355,24 @@
         return picking_obj.action_generate_carrier_label(
             cr, uid, ids, context=context)
 
+    def _get_label_sender_address(self, cr, uid, picking, context=None):
+        """ On each carrier label module you need to define
+            which is the sender of the parcel.
+            The most common case is 'picking.company_id.partner_id'
+            which is suitable for each delivery carrier label module.
+            But your client might want to customize sender address
+            if he has several brands and/or shops in his company.
+            In this case he doesn't want his customer to see
+            the address of his company in his transport label
+            but instead, the address of the partner linked to his shop/brand
+
+            To reach this modularity, call this method to get sender address
+            in your delivery_carrier_label_yourcarrier module, then every developer
+            can manage specific needs by inherit this method in module like :
+            delivery_carrier_label_yourcarrier_yourproject.
+        """
+        return picking.company_id.partner_id
+
     def carrier_id_change(self, cr, uid, ids, carrier_id, context=None):
         """ Inherit this method in your module """
         picking_obj = self.pool.get('stock.picking')