Code review comment for lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Needs Fixing
(code review, no test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi, Alexis, thanks for your work. This module can be very appreciated. We are trying to increase the quality and standarization on community modules, so let me make some suggestions on your code:
- Put "from . import xxx" instead of "import xxx" in __init__.py file.
- Instantiate orm.Model instead osv.Model.
- Be PEP8 compatible. You can use flake8 tool to check this.
I'll do a functional test later.
Thank you again.
Regards.