Merge lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat into lp:~account-core-editors/account-financial-tools/7.0

[Alexis de Lattre]

Add a module "account_fiscal_position_vat_check".

Extracts from the description of the module :

<<
This module adds an option **Customer must have VAT** on fiscal positions. When a user tries to validate a customer invoice or refund with a fiscal position that have this option, OpenERP will check that the customer has a VAT number. If it doesn't, OpenERP will block the validation of the invoice and display an error message.

In the European Union (EU), when an EU company sends an invoice to another EU company in another country, it can invoice without VAT (most of the time) but the VAT number of the customer must be displayed on the invoice.
>>

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Alexis, thanks for your work. This module can be very appreciated. We are trying to increase the quality and standarization on community modules, so let me make some suggestions on your code:

- Put "from . import xxx" instead of "import xxx" in __init__.py file.
- Instantiate orm.Model instead osv.Model.
- Be PEP8 compatible. You can use flake8 tool to check this.

I'll do a functional test later.

Thank you again.

Regards.

review: Needs Fixing (code review, no test)

[Frederic Clementi - Camptocamp (frederic-clementi)]

LGTM

review: Approve (functional - no code review)

[lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat]

2. By Alexis de Lattre on 2013-09-28

Coding style enhancements suggested by the reviewers.

3. By Alexis de Lattre on 2013-10-13

Should be PEP8 compliant now.

[Alexis de Lattre (alexis-via)]

@Pedro

The code style is OK for you now ?

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Alexis, thank you very much for the changes!

I have tested the module and it works correctly.

Please make a last change: rename translation template file to .pot, to get automatically recognised by Launchpad Rosetta.

Regards.

review: Approve (code review and test)

[lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat]

4. By Alexis de Lattre on 2013-10-14

Translation template file is .pot (it's a trap, because OpenERP generate the file with .po extension !)

5. By Alexis de Lattre on 2013-10-19

Add warning when the user sets a fiscal position "must have vat" on a partner and this partner doesn't have a VAT number in openerp yet.
Remove the cut at 80 lines on some messages as it doesn't work with translation files.
Update FR translation.

[Alexis de Lattre (alexis-via)]

About revno 5 : I had recently a new idea for this module : add an on_change on the fiscal position of res.partner : when you switch to a fiscal position that have "must have VAT" and the partner doesn't have a VAT, you get a warning pop-up.

I have checked everything again, including translations.

[Pedro Manuel Baeza (pedro.baeza)]

Thanks, Alexis,

Your changes are working good, but please let changes of this size for another MP instead of doing them in the middle of the MP, because first 'Approve' doesn't count for the second change, confusing anyone that see the overview.

Regards.

review: Approve (code review and test)

[lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat]

6. By Alexis de Lattre on 2013-10-24

Only display a warning when the partner is a customer.
I promise, it's my last commit on this merge proposal :)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi Alexis, I tried to merge your branch in lp:account-financial-tools/7.0 but I get:

    bzr: ERROR: Branches have no common ancestor, and no merge base revision was specified.

Can you check?

review: Needs Resubmitting

[Alexis de Lattre (alexis-via)]

My branch only contains my module, it's not a "full" branch. So a bzr replay should work, but a merge doesn't work. If it's a problem, I will prepare a "full" branch of account-financial-tools with my module inside, but i'm not sure if I will be able to push it in the same branch (if I can't, it would be a new branch and a new MP).

=== added directory 'account_fiscal_position_vat_check'
=== added file 'account_fiscal_position_vat_check/__init__.py'
--- account_fiscal_position_vat_check/__init__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/__init__.py	2013-10-24 16:19:16 +0000
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Account Fiscal Position VAT Check module for OpenERP
+#    Copyright (C) 2013 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import account_invoice
+from . import partner

=== added file 'account_fiscal_position_vat_check/__openerp__.py'
--- account_fiscal_position_vat_check/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/__openerp__.py	2013-10-24 16:19:16 +0000
@@ -0,0 +1,56 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Account Fiscal Position VAT Check module for OpenERP
+#    Copyright (C) 2013 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+
+{
+    'name': 'Account Fiscal Position VAT Check',
+    'version': '0.1',
+    'category': 'Accounting & Finance',
+    'license': 'AGPL-3',
+    'summary': 'Check VAT on invoice validation',
+    'description': """
+Check that the Customer has a VAT number on invoice validation
+==============================================================
+
+This module adds an option **Customer must have VAT** on fiscal positions. When a user tries to validate a customer invoice or refund with a fiscal position that have this option, OpenERP will check that the customer has a VAT number. If it doesn't, OpenERP will block the validation of the invoice and display an error message.
+
+In the European Union (EU), when an EU company sends an invoice to another EU company in another country, it can invoice without VAT (most of the time) but the VAT number of the customer must be displayed on the invoice.
+
+This module also displays a warning when a user sets a fiscal position with the option **Customer must have VAT** on a customer and this customer doesn't have a VAT number in OpenERP yet.
+
+Please contact Alexis de Lattre from Akretion <[e-mail]> for any help or question about this module.
+    """,
+    'author': 'Akretion',
+    'website': 'http://www.akretion.com',
+    'depends': ['account'],
+    'data': [
+        'account_fiscal_position_view.xml',
+        'partner_view.xml',
+        ],
+    'images': [
+        'fiscal_position_form.jpg',
+        'vat_check_invoice_validation.jpg',
+        ],
+    'installable': True,
+    'active': False,
+    'application': True,
+}

=== added file 'account_fiscal_position_vat_check/account_fiscal_position_view.xml'
--- account_fiscal_position_vat_check/account_fiscal_position_view.xml	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/account_fiscal_position_view.xml	2013-10-24 16:19:16 +0000
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!--
+    Copyright (C) 2013 Akretion (http://www.akretion.com/)
+    @author Alexis de Lattre <[e-mail]>
+    The licence is in the file __openerp__.py
+-->
+
+<openerp>
+<data>
+
+
+<record id="view_account_position_form" model="ir.ui.view">
+    <field name="name">customer.must.have.vat.fiscal_position_form</field>
+    <field name="model">account.fiscal.position</field>
+    <field name="inherit_id" ref="account.view_account_position_form" />
+    <field name="arch" type="xml">
+        <field name="active" position="after">
+            <field name="customer_must_have_vat" />
+        </field>
+    </field>
+</record>
+
+
+<record id="view_account_position_tree" model="ir.ui.view">
+    <field name="name">customer.must.have.vat.fiscal_position_tree</field>
+    <field name="model">account.fiscal.position</field>
+    <field name="inherit_id" ref="account.view_account_position_tree" />
+    <field name="arch" type="xml">
+        <field name="name" position="after">
+            <field name="customer_must_have_vat" />
+        </field>
+    </field>
+</record>
+
+</data>
+</openerp>

=== added file 'account_fiscal_position_vat_check/account_invoice.py'
--- account_fiscal_position_vat_check/account_invoice.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/account_invoice.py	2013-10-24 16:19:16 +0000
@@ -0,0 +1,58 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Account Fiscal Position VAT Check module for OpenERP
+#    Copyright (C) 2013 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+from openerp.tools.translate import _
+
+
+class account_fiscal_position(orm.Model):
+    _inherit = 'account.fiscal.position'
+
+    _columns = {
+        'customer_must_have_vat': fields.boolean(
+            'Customer Must Have VAT number',
+            help="If enabled, OpenERP will check that the customer has a VAT number when the user validates a customer invoice/refund."),
+    }
+
+
+class account_invoice(orm.Model):
+    _inherit = 'account.invoice'
+
+    def action_move_create(self, cr, uid, ids, context=None):
+        '''Check that the customer has VAT set
+        if required by the fiscal position'''
+        for invoice in self.browse(cr, uid, ids, context=context):
+            if invoice.type in ('out_invoice', 'out_refund') \
+                    and invoice.fiscal_position \
+                    and invoice.fiscal_position.customer_must_have_vat \
+                    and not invoice.partner_id.vat:
+                if invoice.type == 'out_invoice':
+                    type_label = _('a Customer Invoice')
+                else:
+                    type_label = _('a Customer Refund')
+                raise orm.except_orm(
+                    _('Missing VAT number:'),
+                    _("You are trying to validate %s with the fiscal position '%s' that require the customer to have a VAT number. But the Customer '%s' doesn't have a VAT number in OpenERP. Please add the VAT number of this Customer in OpenERP and try to validate again.")
+                    % (type_label, invoice.fiscal_position.name,
+                        invoice.partner_id.name))
+        return super(account_invoice, self).action_move_create(
+            cr, uid, ids, context=context)

=== added directory 'account_fiscal_position_vat_check/i18n'
=== added file 'account_fiscal_position_vat_check/i18n/account_fiscal_position_vat_check.pot'
--- account_fiscal_position_vat_check/i18n/account_fiscal_position_vat_check.pot	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/i18n/account_fiscal_position_vat_check.pot	2013-10-24 16:19:16 +0000
@@ -0,0 +1,78 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_fiscal_position_vat_check
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-10-19 19:46+0000\n"
+"PO-Revision-Date: 2013-10-19 19:46+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_fiscal_position_vat_check
+#: view:res.partner:0
+msgid "fiscal_position_change(property_account_position, vat)"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:54
+#, python-format
+msgid "You are trying to validate %s with the fiscal position '%s' that require the customer to have a VAT number. But the Customer '%s' doesn't have a VAT number in OpenERP. Please add the VAT number of this Customer in OpenERP and try to validate again."
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:51
+#, python-format
+msgid "a Customer Refund"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: field:account.fiscal.position,customer_must_have_vat:0
+msgid "Customer Must Have VAT number"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: help:account.fiscal.position,customer_must_have_vat:0
+msgid "If enabled, OpenERP will check that the customer has a VAT number when the user validates a customer invoice/refund."
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_account_fiscal_position
+msgid "Fiscal Position"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_account_invoice
+msgid "Invoice"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_res_partner
+msgid "Partner"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:49
+#, python-format
+msgid "a Customer Invoice"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:53
+#: code:addons/account_fiscal_position_vat_check/partner.py:38
+#, python-format
+msgid "Missing VAT number:"
+msgstr ""
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/partner.py:39
+#, python-format
+msgid "You have set the fiscal position '%s' that require the customer to have a VAT number. You should add the VAT number of this customer in OpenERP."
+msgstr ""
+

=== added file 'account_fiscal_position_vat_check/i18n/fr.po'
--- account_fiscal_position_vat_check/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/i18n/fr.po	2013-10-24 16:19:16 +0000
@@ -0,0 +1,78 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_fiscal_position_vat_check
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-10-19 19:47+0000\n"
+"PO-Revision-Date: 2013-10-19 19:47+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_fiscal_position_vat_check
+#: view:res.partner:0
+msgid "fiscal_position_change(property_account_position, vat)"
+msgstr "fiscal_position_change(property_account_position, vat)"
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:54
+#, python-format
+msgid "You are trying to validate %s with the fiscal position '%s' that require the customer to have a VAT number. But the Customer '%s' doesn't have a VAT number in OpenERP. Please add the VAT number of this Customer in OpenERP and try to validate again."
+msgstr "Vous essayez de valider %s avec la position fiscale '%s' qui oblige à connaître le numéro de TVA du client. Mais le client '%s' n'a pas de numéro de TVA dans OpenERP. Veuillez ajouter le numéro de TVA de ce client dans OpenERP et essayer de valider à nouveau."
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:51
+#, python-format
+msgid "a Customer Refund"
+msgstr "un avoir client"
+
+#. module: account_fiscal_position_vat_check
+#: field:account.fiscal.position,customer_must_have_vat:0
+msgid "Customer Must Have VAT number"
+msgstr "Numéro de TVA obligatoire pour le client"
+
+#. module: account_fiscal_position_vat_check
+#: help:account.fiscal.position,customer_must_have_vat:0
+msgid "If enabled, OpenERP will check that the customer has a VAT number when the user validates a customer invoice/refund."
+msgstr "Si activé, OpenERP vérifiera que le client a un numéro de TVA quand l'utilisasteur valide la facture/avoir client."
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_account_fiscal_position
+msgid "Fiscal Position"
+msgstr "Position fiscale"
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_account_invoice
+msgid "Invoice"
+msgstr "Facture"
+
+#. module: account_fiscal_position_vat_check
+#: model:ir.model,name:account_fiscal_position_vat_check.model_res_partner
+msgid "Partner"
+msgstr "Partenaire"
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:49
+#, python-format
+msgid "a Customer Invoice"
+msgstr "une facture client"
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/account_invoice.py:53
+#: code:addons/account_fiscal_position_vat_check/partner.py:38
+#, python-format
+msgid "Missing VAT number:"
+msgstr "Numéro de TVA manquant :"
+
+#. module: account_fiscal_position_vat_check
+#: code:addons/account_fiscal_position_vat_check/partner.py:39
+#, python-format
+msgid "You have set the fiscal position '%s' that require the customer to have a VAT number. You should add the VAT number of this customer in OpenERP."
+msgstr "Vous avez sélectionné la position fiscale '%s' qui exige que le client ait un numéro de TVA. Vous devez ajouter le numéro de TVA de ce client dans OpenERP."
+

=== added directory 'account_fiscal_position_vat_check/images'
=== added file 'account_fiscal_position_vat_check/images/fiscal_position_form.jpg'
Binary files account_fiscal_position_vat_check/images/fiscal_position_form.jpg	1970-01-01 00:00:00 +0000 and account_fiscal_position_vat_check/images/fiscal_position_form.jpg	2013-10-24 16:19:16 +0000 differ
=== added file 'account_fiscal_position_vat_check/images/vat_check_invoice_validation.jpg'
Binary files account_fiscal_position_vat_check/images/vat_check_invoice_validation.jpg	1970-01-01 00:00:00 +0000 and account_fiscal_position_vat_check/images/vat_check_invoice_validation.jpg	2013-10-24 16:19:16 +0000 differ
=== added file 'account_fiscal_position_vat_check/partner.py'
--- account_fiscal_position_vat_check/partner.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/partner.py	2013-10-24 16:19:16 +0000
@@ -0,0 +1,40 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Account Fiscal Position VAT Check module for OpenERP
+#    Copyright (C) 2013 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm
+from openerp.tools.translate import _
+
+
+class res_partner(orm.Model):
+    _inherit = 'res.partner'
+
+    def fiscal_position_change(self, cr, uid, ids, account_position, vat, customer):
+        '''Warning is the fiscal position requires a vat number and the partner
+        doesn't have one yet'''
+        if account_position and customer and not vat:
+            fp = self.pool['account.fiscal.position'].read(
+                cr, uid, account_position, ['customer_must_have_vat', 'name'])
+            if fp['customer_must_have_vat']:
+                return {'warning': {
+                    'title': _('Missing VAT number:'),
+                    'message': _("You have set the fiscal position '%s' that require the customer to have a VAT number. You should add the VAT number of this customer in OpenERP.") % fp['name']}}
+        return True

=== added file 'account_fiscal_position_vat_check/partner_view.xml'
--- account_fiscal_position_vat_check/partner_view.xml	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_vat_check/partner_view.xml	2013-10-24 16:19:16 +0000
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!--
+    Copyright (C) 2013 Akretion (http://www.akretion.com/)
+    @author Alexis de Lattre <[e-mail]>
+    The licence is in the file __openerp__.py
+-->
+
+<openerp>
+<data>
+
+
+<record id="view_partner_property_form" model="ir.ui.view">
+    <field name="name">customer.must.have.vat.fiscal_position_form</field>
+    <field name="model">res.partner</field>
+    <field name="inherit_id" ref="account.view_partner_property_form" />
+    <field name="arch" type="xml">
+        <field name="property_account_position" position="attributes">
+            <attribute name="on_change">fiscal_position_change(property_account_position, vat, customer)</attribute>
+        </field>
+    </field>
+</record>
+
+
+</data>
+</openerp>