Merge lp:~ahayzen/qtubuntu-print/add-readme into lp:qtubuntu-print

Proposed by Andrew Hayzen
Status: Merged
Approved by: Michael Sheldon
Approved revision: 34
Merged at revision: 4
Proposed branch: lp:~ahayzen/qtubuntu-print/add-readme
Merge into: lp:qtubuntu-print
Prerequisite: lp:~ahayzen/qtubuntu-print/add-unit-tests
Diff against target: 58 lines (+54/-0)
1 file modified
README.md (+54/-0)
To merge this branch: bzr merge lp:~ahayzen/qtubuntu-print/add-readme
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
Review via email: mp+317790@code.launchpad.net

Commit message

* Add a readme

Description of the change

* Add a readme

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Couple of small suggestions included as diff comments

30. By Andrew Hayzen

* Change build example to be an out-of-tree build
* Fix comments for grammar errors

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

1) Should this say "sends it over content-hub"?

Yep, fixed it :-)

2) Might be better to give an example of an out of tree build as these are normally preferred

Good idea, fixed.

I also noticed "simple invoke cmake" should have been "simply invoke cmake".

Thanks, please re-review :-)

31. By Andrew Hayzen

* Pull of upstream fix for missing depends

32. By Andrew Hayzen

* Pull of upstream removal of qt5-default and using -qt=qt5

33. By Andrew Hayzen

* Pull of upstream

34. By Andrew Hayzen

* Fix for typo

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good, approved :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'README.md'
--- README.md 1970-01-01 00:00:00 +0000
+++ README.md 2017-02-21 14:38:41 +0000
@@ -0,0 +1,54 @@
1qtubuntu-print is a plugin to the printing system of Qt.
2It generates a PDF document and sends it over content-hub
3to a destination application.
4
5# Building
6
7The build system uses cmake.
8To compile, simply invoke cmake and then make:
9
10```
11mkdir build
12cd build
13cmake ../
14make
15```
16
17# Building a deb
18
19To build a deb package, invoke bzr builddeb:
20
21```
22bzr builddeb
23```
24
25# Installing
26
27To install the plugin on the system, invoke make install:
28
29```
30sudo make install
31```
32
33# Running
34
35qtubuntu-print is a plugin to the printing system of Qt.
36To use qtubuntu-print with an application such as kate invoke the following:
37
38```
39QT_PRINTER_MODULE=qtubuntu-print kate
40```
41
42# Unit tests
43
44To run the unit tests, you can use the commands below:
45
46```
47make test
48```
49
50or
51
52```
53ctest
54```

Subscribers

People subscribed via source and target branches

to all changes: