Code review comment for lp:~ahayzen/qtubuntu-print/add-readme

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

1) Should this say "sends it over content-hub"?

Yep, fixed it :-)

2) Might be better to give an example of an out of tree build as these are normally preferred

Good idea, fixed.

I also noticed "simple invoke cmake" should have been "simply invoke cmake".

Thanks, please re-review :-)

« Back to merge proposal