Code review comment for ~ahasenack/ubuntu/+source/strongswan:cosmic-strongswan-merge-5.6.3-1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

- Deconstruct and Logical is good
- Changelogs are mostly good
- old changes are retained correctly (All 100% identical, you just updated the commit messages)
- as discussed the tests look good as well thanks for doing that two system test that I linked you

I only must ask to fixup the changelog in one place - the mentioning of 1784023.
That is
a) not added on the merge but in 5.6.2-2ubuntu2 (currently in Added changes)
b) please break the LP: #1784023 string so that tools will not try to close the bug again

Please fix this little thing in the changelog, then I think we can upload.

review: Needs Fixing

« Back to merge proposal