Merge ~ahasenack/ubuntu/+source/shadowsocks-libev:focal-dep8-py2-explicit into ~ahasenack/ubuntu/+source/shadowsocks-libev:master
Proposed by
Andreas Hasenack
Status: | Merged |
---|---|
Approved by: | Andreas Hasenack |
Approved revision: | 474d96e7e63ee0327a8f8117c3ab57619cfbd2f2 |
Merge reported by: | Andreas Hasenack |
Merged at revision: | 474d96e7e63ee0327a8f8117c3ab57619cfbd2f2 |
Proposed branch: | ~ahasenack/ubuntu/+source/shadowsocks-libev:focal-dep8-py2-explicit |
Merge into: | ~ahasenack/ubuntu/+source/shadowsocks-libev:master |
Diff against target: |
94 lines (+55/-2) 5 files modified
debian/changelog (+8/-0) debian/control (+2/-1) debian/patches/series (+1/-0) debian/patches/use-py2-for-dep8-tests.patch (+43/-0) debian/tests/control (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server MOTU reviewers | Pending | ||
Review via email: mp+378188@code.launchpad.net |
Description of the change
This package isn't in git-ubuntu, so I'm proposing this MP against my own master branch which represents the current package in focal.
This fixes the dep8 dependency on "python":
E: Package 'python' has no installation candidate
I checked upstream and there is no new release nor recent activity. I also tried running this with py3, but it failed. Porting to py3 doesn't seem to be too hard, but not worth it at the moment I believe.
This package is blocking the bind9 migration.
To post a comment you must log in.
LGTM, +1
Verified python2 is valid package in focal; I didn't realize we could just change deps to require that.
* Changelog:
- [?] old content and logical tag match as expected
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [v] update-maintainer has been run
* Actual changes: /github. com/shadowsocks /shadowsocks- libev/releases
- [√] no upstream changes to consider
+ 3.3.4 is latest upstream release - https:/
- [√] no further upstream version to consider
+ This is a build fix, so kept to just solving the issue at hand
- [√] debian changes look safe
* Old Delta:
- [-] dropped changes are ok to be dropped
- [-] nothing else to drop
- [√] changes forwarded upstream/debian (if appropriate)
* New Delta: patches/ series
- [-] patches match what was proposed upstream
- [√] patches correctly included in debian/
- [√] patches have correct DEP3 metadata
* Build/Test:
- [-] build is ok
- [-] verified PPA package installs/uninstalls
- [-] autopkgtest against the PPA package passes
- [-] sanity checks test fine
I didn't do build testing, I trust if there are any issues they'll become immediately apparent. Presumably this has been locally tested and/or in a PPA already.