Code review comment for ~ahasenack/ubuntu/+source/shadowsocks-libev:focal-dep8-py2-explicit

Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, +1

Verified python2 is valid package in focal; I didn't realize we could just change deps to require that.

* Changelog:
  - [?] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [v] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
    + 3.3.4 is latest upstream release - https://github.com/shadowsocks/shadowsocks-libev/releases
  - [√] no further upstream version to consider
    + This is a build fix, so kept to just solving the issue at hand
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [-] build is ok
  - [-] verified PPA package installs/uninstalls
  - [-] autopkgtest against the PPA package passes
  - [-] sanity checks test fine

I didn't do build testing, I trust if there are any issues they'll become immediately apparent. Presumably this has been locally tested and/or in a PPA already.

« Back to merge proposal