Ubuntu
python-certbot-nginx package

Code review comment for ~ahasenack/ubuntu/+source/python-certbot-nginx:focal-certbot-nginx-1875471

  1. Git
  2. lp:~ahasenack/ubuntu/+source/python-certbot-nginx
  3. focal-certbot-nginx-1875471
  4. Merge into ubuntu/focal
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

After wondering "hey this is a new version" at first this seems ok.
0.39 -> 0.40 is minimal and fixes the issues we see.

Also I agree not going the full >=1.3.x that is in groovy.

The backport of the test-fix LGTM as well.

The SRU Template is great and should resolve all confusion for anyone looking at the case.

Buildlog and changelog look good as well.
+1

review: Approve

« Back to merge proposal