Merge ~ahasenack/ubuntu/+source/python-certbot-nginx:focal-certbot-nginx-1875471 into ubuntu/+source/python-certbot-nginx:ubuntu/focal
Status: | Merged |
---|---|
Approved by: | Andreas Hasenack |
Approved revision: | 723b05582944144e68428246b1d478afa80625cb |
Merge reported by: | Andreas Hasenack |
Merged at revision: | 723b05582944144e68428246b1d478afa80625cb |
Proposed branch: | ~ahasenack/ubuntu/+source/python-certbot-nginx:focal-certbot-nginx-1875471 |
Merge into: | ubuntu/+source/python-certbot-nginx:ubuntu/focal |
Diff against target: |
214 lines (+71/-20) 13 files modified
PKG-INFO (+1/-1) certbot_nginx.egg-info/PKG-INFO (+1/-1) certbot_nginx.egg-info/SOURCES.txt (+1/-2) certbot_nginx/configurator.py (+1/-1) certbot_nginx/http_01.py (+4/-4) certbot_nginx/tests/configurator_test.py (+1/-1) certbot_nginx/tests/http_01_test.py (+3/-3) debian/changelog (+11/-0) debian/patches/fix-tests-with-newer-acme.patch (+45/-0) debian/patches/series (+1/-0) debian/rules (+1/-1) dev/null (+0/-5) setup.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+383529@code.launchpad.net |
This proposal supersedes a proposal from 2020-05-06.
Description of the change
## NOTE
This MP is against ubuntu/focal, not ubuntu/focal-devel, as focal had a python-
The bug has details on what happened, and how it was fixed. The options we had were outlined in https:/
Test PPA: https:/
Running all the tests properly needs a specific setup, which I suggest to leave for the SRU verification. I have done those with my test PPA already prior to submitting this.
What can easily be tested is the python error which originated this:
AttributeError: module 'acme.challenges' has no attribute 'TLSSNI01'
Just run this, on any host/container (no need to replace the fake domain):
sudo apt install python3-
sudo certbot -d example.org --agree-tos --staging --register-
The fixed version won't fail with AttributeError, but will try to fetch a certificate for example.org, and that will of course fail and is fine.
The second check to make is to confirm that the build-time tests were run. Search build logs for "dh_auto_test".
Read all the bug updates - for how much was going on there the MP doesn't look so bad after all :-)