Code review comment for lp:~ahasenack/apport/samba-security-share-bugpattern

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good although it is a little strange that the pattern fails with bug 1634119, looking at the bug I understand this is because the user commented out the "security = share" line. It might have been nice to mention this in the merge request.

Also keep in mind its possible to use search-bugs, in this branch, to search for and consolidate duplicate bug reports if you want e.g.:

 $ ./search-bugs --package samba
LP: #1703604: bug description must contain standard apport format data
LP: #1703253 (Incomplete, Undecided): Matched bug pattern: https://launchpad.net/bugs/1634119 with 0 dupes
LP: #1703061 (Incomplete, Undecided): Matched bug pattern: https://launchpad.net/bugs/1634119 with 0 dupes
LP: #1702529: bug description must contain standard apport format data

review: Approve

« Back to merge proposal