Merge lp:~ahasenack/apport/samba-security-share-bugpattern into lp:~ubuntu-bugcontrol/apport/ubuntu-bugpatterns

[Andreas Hasenack]

Bug pattern for bug #1634119

This has been a very common bug opened against samba via apport. An ancient configuration option in /etc/samba/smb.conf, called "security = share", was finally deprecated by upstream, and is no longer valid.

[Brian Murray (brian-murray)]

This looks good although it is a little strange that the pattern fails with bug 1634119, looking at the bug I understand this is because the user commented out the "security = share" line. It might have been nice to mention this in the merge request.

Also keep in mind its possible to use search-bugs, in this branch, to search for and consolidate duplicate bug reports if you want e.g.:

 $ ./search-bugs --package samba
LP: #1703604: bug description must contain standard apport format data
LP: #1703253 (Incomplete, Undecided): Matched bug pattern: https://launchpad.net/bugs/1634119 with 0 dupes
LP: #1703061 (Incomplete, Undecided): Matched bug pattern: https://launchpad.net/bugs/1634119 with 0 dupes
LP: #1702529: bug description must contain standard apport format data

review: Approve

[Andreas Hasenack (ahasenack)]

Thanks for the review.

I didn't want to use search-bugs with --consolidate before this was merged :)

Regarding why it didn't caught #1634119 itself, yes, it's because we need the option to be actually used in the config file, or else the reason smbd isn't restarting is something else. That user did some debugging on his own and uploaded the smb.conf file after he had fixed it.

Some of the bugs (most actually) I left as incomplete expecting the users to come back after they fixed the config, in which case we would close them as invalid or duplicate. That would have been a nice closure. But it's not happening, and the bugs keep coming in, that's why I decided it's time for a bug pattern :)

=== modified file 'bugpatterns.xml'
--- bugpatterns.xml	2017-03-28 15:41:28 +0000
+++ bugpatterns.xml	2017-07-11 21:06:58 +0000
@@ -1213,6 +1213,11 @@
         <re key="VarLogDistupgradeTermlog">Can't locate File\/Temp.pm in @INC</re>
         <re key="VarLogDistupgradeTermlog">Compilation failed in require at \/usr\/sbin\/update-inetd</re>
     </pattern>
+    <pattern url="https://launchpad.net/bugs/1634119">
+        <re key="SourcePackage">^samba</re>
+        <re key="DpkgTerminalLog">Job for (smbd|nmbd|winbind)\.service failed because the control process exited with error code</re>
+        <re key="SMBConf">\n\s*security\s*=\s*share\s*\n</re>
+    </pattern>
 
 <!-- Applies to samba4 -->