Code review comment for lp:~agateau/unity-2d/keep-launcher-when-menu-is-visible

Revision history for this message
Ugo Riboni (uriboni) wrote :

From a general design point of view, wouldn't it be more consistent with the QML way of doing things to have a bool property visible and then connecting to onVisibleChanged ?

Having it as a property will help for the cases where we don't need to call functions as an effect of the menu visibility change, but we can just bind the property to some other property.

review: Needs Fixing

« Back to merge proposal