Code review comment for lp:~agateau/unity-2d/gettext

On Wednesday 23 February 2011 03:32:58 you wrote:
> Great stuff.
>
>
> make check fails on me, any clue?

Can you check the build generated a file named:
locale/fr/LC_MESSAGES/gettexttest.mo
in the test build dir?

If it is there, do you have the French locale installed? It works here even
with locales set to C, but I still have the French locale installed. Maybe it
is necessary.

> test 1
> Start 1: gettexttest
>
> 1: Test command:
> /home/kaleo/Projects/upicek/unity-2d/libunity-2d-private/tests/gettexttest
> 1: Test timeout computed to be: 9.99988e+06
> 1: ********* Start testing of GettextTest *********
> 1: Config: Using QTest library 4.7.0, Qt 4.7.0
> 1: PASS : GettextTest::initTestCase()
> 1: FAIL! : GettextTest::testTranslate() Compared values are not the same
> 1: Actual (QCoreApplication::translate("", "Hello")): Hello
> 1: Expected (QString("Bonjour")): Bonjour
> 1: Loc:
> [/home/kaleo/Projects/upicek/unity-2d/libunity-2d-private/tests/gettexttes
> t.cpp(46)] 1: FAIL! : GettextTest::testTranslateWithDisambiguation()
> Compared values are not the same 1: Actual
> (QCoreApplication::translate("", "Close", "Closing a door")): Closing a
> door?Close 1: Expected (QString("Fermer")): Fermer
> 1: Loc:
> [/home/kaleo/Projects/upicek/unity-2d/libunity-2d-private/tests/gettexttes
> t.cpp(58)] 1: FAIL! :
> GettextTest::testTranslateWithEmptyNonNullDisambiguation() Compared values
> are not the same 1: Actual (QCoreApplication::translate("", "Hello",
> "")): Hello 1: Expected (QString("Bonjour")): Bonjour
> 1: Loc:
> [/home/kaleo/Projects/upicek/unity-2d/libunity-2d-private/tests/gettexttes
> t.cpp(68)] 1: PASS : GettextTest::cleanupTestCase()
> 1: Totals: 2 passed, 3 failed, 0 skipped
> 1: ********* Finished testing of GettextTest *********
> 1/4 Test #1: gettexttest ......................***Failed 0.01 sec