Code review comment for lp:~aeves-nate/ubuntu/wily/mydumper/fix-for-1402381

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks otherwise fine, but there shouldn't be a "-- fixes lp:1402381" in debian/changelog. Please use "(LP: #1402381)" instead, tacking it at the end of the sentence where you write that changed, along with the other bug number.

Also, have you sent this patch to Debian? It would be good to attach it to the bug report there: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773990

review: Needs Fixing

« Back to merge proposal