Merge lp:~aeves-nate/ubuntu/wily/mydumper/fix-for-1402381 into lp:ubuntu/wily/mydumper
| Status: | Needs review | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Proposed branch: | lp:~aeves-nate/ubuntu/wily/mydumper/fix-for-1402381 | ||||||||
| Merge into: | lp:ubuntu/wily/mydumper | ||||||||
| Diff against target: |
59 lines (+20/-1) 5 files modified
.pc/applied-patches (+1/-0) debian/changelog (+6/-0) debian/patches/0004-manpages-fix-inconsistency.patch (+11/-0) debian/patches/series (+1/-0) docs/mydumper_usage.rst (+1/-1) |
||||||||
| To merge this branch: | bzr merge lp:~aeves-nate/ubuntu/wily/mydumper/fix-for-1402381 | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | 2015-07-04 | Needs Fixing on 2015-09-28 | |
|
Review via email:
|
|||
Description of the Change
Fixed inconsistency in manpages. Copying upstream fix from LP bug #1428608
- 9. By Nate Olander on 2015-07-04
-
Added --fixes lp:1402381 to changelog to mark as associated
- 10. By Nate Olander on 2015-09-29
-
Fixed inconsistency in manpages. Copying upstream fix from LP bug #1428608 (LP: #1402381)
Fixed mistake as reported by mathieu-tl on Launchpad
| Nate Olander (aeves-nate) wrote : | # |
Does that take care of it? I haven't done bug fixes in a while so I may have messed something up.
Unmerged revisions
- 10. By Nate Olander on 2015-09-29
-
Fixed inconsistency in manpages. Copying upstream fix from LP bug #1428608 (LP: #1402381)
Fixed mistake as reported by mathieu-tl on Launchpad
- 9. By Nate Olander on 2015-07-04
-
Added --fixes lp:1402381 to changelog to mark as associated
- 8. By Nate Olander on 2015-07-04
-
Updated changelog with correct email address
- 7. By Nate Olander on 2015-07-04
-
Fixed inconsistency in manpages. Copying upstream fix from LP bug #1428608


Looks otherwise fine, but there shouldn't be a "-- fixes lp:1402381" in debian/changelog. Please use "(LP: #1402381)" instead, tacking it at the end of the sentence where you write that changed, along with the other bug number.
Also, have you sent this patch to Debian? It would be good to attach it to the bug report there: https:/ /bugs.debian. org/cgi- bin/bugreport. cgi?bug= 773990