Merge lp:~adiroiban/pydoctor/1282458-apilinks-anchor into lp:~mwhudson/pydoctor/dev
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~adiroiban/pydoctor/1282458-apilinks-anchor | ||||
Merge into: | lp:~mwhudson/pydoctor/dev | ||||
Diff against target: |
170 lines (+117/-5) 4 files modified
CONTRIBUTING.txt (+5/-0) pydoctor/apilinks_sphinxext.py (+17/-5) pydoctor/test/test_apilinks_sphinxext.py (+91/-0) test-requirements.txt (+4/-0) |
||||
To merge this branch: | bzr merge lp:~adiroiban/pydoctor/1282458-apilinks-anchor | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hudson-Doyle | Pending | ||
Review via email: mp+207392@code.launchpad.net |
Description of the change
This is the branch which add anchor support for apilink Sphinx extension.
I have created CONTRIBUTING.txt file since as a first time contributor it
was not obvious that py.test is required together with 'py' packages.
I have created test-requiremen
for running the tests.
I have also added docutils since the following test was failing
`pydoctor/
Also my new test will fail without docutils.
I have moved apilinks_
easier to test.. but maybe it is a stupid change.
I am not sure how you want to distribute the exentsion. Maybe create a separate package.
bunch was added as a minimal mock tool.
flake8 was added as a minimum tool for keeping code formatting consistent.
I added an initial set of tests for happy case.
Let me know if more tests are required.
Let me know if something needs changes.
Thanks!
Unmerged revisions
- 615. By Adi Roiban
-
Update test requirements and contributing page.
- 614. By Adi Roiban
-
Merge trunk.
- 613. By Adi Roiban
-
Initial code for anchor support and tests.
Hi. Thanks for proposing this branch!
It would probably have been better to do the different things in different branches maybe?
I don't use py.test any more to run the tests, but generally use nose instead. I'm not super happy about either tbh, and would like to convert them all to something more standardly- pyUnitish but well.
I don't know how apilinks_ sphinxext. py is used at all -- if it is still useful when part of the pydoctor package, then it makes sense for it to be there rather than at top level.