Code review comment for lp:~adiroiban/pydoctor/1282458-apilinks-anchor

Michael Hudson-Doyle (mwhudson) wrote :

Adi Roiban <email address hidden> writes:

> I can split this review... but considering that this is the only
> branch in the review queue I don't know what splitting it will make
> things easier.

Well I find it helps to talk about one thing at once but you make a fair
point.

> I use nose and I am happy with it. Much better than standard pyunit.

OK, so...

> I tried to use, but test were failing so I did not dig deeper and just
> went to install py.test, since I saw that tests required 'py' package
> which was talking about pytest.

Can you try again? I think I just deleted the last remnants of the py
imports.

> apilinks_sphinxext.py is used in Twisted, but is not used as part of
> pydoctor package, but instead there is a copy of this file.

Right, I think we should be moving towards only having one copy of the
file but I don't know what's involved in that.

Cheers,
mwh

« Back to merge proposal