Merge lp:~adconrad/launchpad-buildd/speed-fixes into lp:launchpad-buildd

Proposed by Adam Conrad
Status: Merged
Approved by: William Grant
Approved revision: 53
Merged at revision: 52
Proposed branch: lp:~adconrad/launchpad-buildd/speed-fixes
Merge into: lp:launchpad-buildd
Diff against target: 78 lines (+22/-13)
3 files modified
debian/changelog (+9/-0)
sbuild (+12/-12)
umount-chroot (+1/-1)
To merge this branch: bzr merge lp:~adconrad/launchpad-buildd/speed-fixes
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+98808@code.launchpad.net

Description of the change

  * Shut up umount-chroot's verbose output, it served its purpose.
  * Yank out sbuild's dependency removal code, as we never once
    checked the return from this anyway, so it's just wasted time.
  * Stop writing to avg-space and avg-time, which we don't use.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-01-25 18:46:47 +0000
+++ debian/changelog 2012-03-22 10:18:20 +0000
@@ -1,3 +1,12 @@
1launchpad-buildd (113) hardy; urgency=low
2
3 * Shut up umount-chroot's verbose output, it served its purpose.
4 * Yank out sbuild's dependency removal code, as we never once
5 checked the return from this anyway, so it's just wasted time.
6 * Stop writing to avg-space and avg-time, which we don't use.
7
8 -- Adam Conrad <adconrad@ubuntu.com> Thu, 22 Mar 2012 04:01:48 -0600
9
1launchpad-buildd (112) hardy; urgency=low10launchpad-buildd (112) hardy; urgency=low
211
3 [ Jelmer Vernooij ]12 [ Jelmer Vernooij ]
413
=== modified file 'sbuild'
--- sbuild 2011-11-29 06:09:01 +0000
+++ sbuild 2012-03-22 10:18:20 +0000
@@ -750,7 +750,7 @@
750750
751 cleanup_packages:751 cleanup_packages:
752 undo_specials();752 undo_specials();
753 uninstall_deps();753 #uninstall_deps();
754 remove_srcdep_lock_file();754 remove_srcdep_lock_file();
755 cleanup_symlinks:755 cleanup_symlinks:
756 remove_files( @files_to_rm );756 remove_files( @files_to_rm );
@@ -1446,13 +1446,13 @@
1446 check_watches();1446 check_watches();
1447 check_space( @space_files );1447 check_space( @space_files );
14481448
1449 if ($conf::purge_build_directory eq "always" ||1449 #if ($conf::purge_build_directory eq "always" ||
1450 ($conf::purge_build_directory eq "successful" && $rv == 0)) {1450 # ($conf::purge_build_directory eq "successful" && $rv == 0)) {
1451 print PLOG "Purging $dir\n";1451 # print PLOG "Purging $dir\n";
1452 system "$conf::sudo rm -rf $dir";1452 # system "$conf::sudo rm -rf $dir";
1453 }1453 #}
1454 1454 #
1455 print PLOG "-"x78, "\n";1455 #print PLOG "-"x78, "\n";
1456 return $rv == 0 ? 1 : 0;1456 return $rv == 0 ? 1 : 0;
1457}1457}
14581458
@@ -3031,10 +3031,10 @@
3031 3031
3032 $pkg = basename( $pkg );3032 $pkg = basename( $pkg );
3033 $t = 0 if $t < 0;3033 $t = 0 if $t < 0;
3034 if ($main::pkg_status eq "successful") {3034 #if ($main::pkg_status eq "successful") {
3035 add_time_entry( $pkg, $t );3035 # add_time_entry( $pkg, $t );
3036 add_space_entry( $pkg, $main::this_space );3036 # add_space_entry( $pkg, $main::this_space );
3037 }3037 #}
3038 print PLOG "*"x78, "\n";3038 print PLOG "*"x78, "\n";
3039 printf PLOG "Finished at ${date}Build needed %02d:%02d:%02d, %dk disk space\n",3039 printf PLOG "Finished at ${date}Build needed %02d:%02d:%02d, %dk disk space\n",
3040 int($t/3600), int(($t%3600)/60), int($t%60), $main::this_space;3040 int($t/3600), int(($t%3600)/60), int($t%60), $main::this_space;
30413041
=== modified file 'umount-chroot'
--- umount-chroot 2011-11-09 07:50:56 +0000
+++ umount-chroot 2012-03-22 10:18:20 +0000
@@ -26,7 +26,7 @@
26# pass at umounting fails unless we reverse the list. Leave the while26# pass at umounting fails unless we reverse the list. Leave the while
27# loop in just to handle pathological cases, too.27# loop in just to handle pathological cases, too.
28COUNT=028COUNT=0
29while $GREP "$HOME/build-$BUILDID/chroot-autobuild" /proc/mounts; do29while $GREP -q "$HOME/build-$BUILDID/chroot-autobuild" /proc/mounts; do
30 COUNT=$(($COUNT+1))30 COUNT=$(($COUNT+1))
31 if [ $COUNT -ge 20 ]; then31 if [ $COUNT -ge 20 ]; then
32 echo "failed to umount $HOME/build-$BUILDID/chroot-autobuild"32 echo "failed to umount $HOME/build-$BUILDID/chroot-autobuild"

Subscribers

People subscribed via source and target branches