Merge ~adam-collard/maas:no-assert-equals into maas:master

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 607f0374589b4e4253aa2841cfcd18c64433b053
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:no-assert-equals
Merge into: maas:master
Diff against target: 8976 lines (+1304/-1315)
143 files modified
src/maascli/actions/tests/test_sshkeys_import.py (+2/-2)
src/maascli/tests/test_snappy.py (+2/-2)
src/maasserver/api/tests/test_blockdevice.py (+40/-25)
src/maasserver/api/tests/test_commissioning.py (+11/-11)
src/maasserver/api/tests/test_devices.py (+9/-9)
src/maasserver/api/tests/test_dhcpsnippets.py (+5/-5)
src/maasserver/api/tests/test_interfaces.py (+5/-5)
src/maasserver/api/tests/test_machine.py (+1/-1)
src/maasserver/api/tests/test_machines.py (+8/-8)
src/maasserver/api/tests/test_node.py (+16/-16)
src/maasserver/api/tests/test_pods.py (+1/-1)
src/maasserver/api/tests/test_scriptresults.py (+15/-17)
src/maasserver/api/tests/test_scripts.py (+46/-46)
src/maasserver/api/tests/test_ssl_key.py (+1/-1)
src/maasserver/api/tests/test_tag.py (+5/-5)
src/maasserver/api/tests/test_users.py (+4/-4)
src/maasserver/api/tests/test_vmfs_datastores.py (+6/-6)
src/maasserver/api/tests/test_volume_groups.py (+1/-1)
src/maasserver/clusterrpc/tests/test_driver_parameters.py (+1/-1)
src/maasserver/clusterrpc/tests/test_pods.py (+2/-2)
src/maasserver/forms/tests/test_clone.py (+5/-5)
src/maasserver/forms/tests/test_dhcpsnippet.py (+4/-4)
src/maasserver/forms/tests/test_interface.py (+2/-2)
src/maasserver/forms/tests/test_machinewithmacaddresses.py (+2/-2)
src/maasserver/forms/tests/test_packagerepository.py (+1/-1)
src/maasserver/forms/tests/test_parameters.py (+15/-15)
src/maasserver/forms/tests/test_pods.py (+7/-7)
src/maasserver/forms/tests/test_script.py (+78/-78)
src/maasserver/forms/tests/test_sslkey.py (+1/-1)
src/maasserver/forms/tests/test_subnet.py (+3/-3)
src/maasserver/forms/tests/test_vlan.py (+3/-3)
src/maasserver/models/signals/tests/test_interfaces.py (+6/-6)
src/maasserver/models/signals/tests/test_nodes.py (+2/-2)
src/maasserver/models/signals/tests/test_podhints.py (+2/-2)
src/maasserver/models/signals/tests/test_services.py (+4/-6)
src/maasserver/models/signals/tests/test_users.py (+1/-1)
src/maasserver/models/tests/test_bmc.py (+17/-17)
src/maasserver/models/tests/test_bootresource.py (+2/-2)
src/maasserver/models/tests/test_bootsourcecache.py (+2/-2)
src/maasserver/models/tests/test_cleansave.py (+27/-27)
src/maasserver/models/tests/test_config.py (+2/-2)
src/maasserver/models/tests/test_filesystemgroup.py (+3/-3)
src/maasserver/models/tests/test_interface.py (+16/-16)
src/maasserver/models/tests/test_iscsiblockdevice.py (+1/-1)
src/maasserver/models/tests/test_node.py (+50/-50)
src/maasserver/models/tests/test_ownerdata.py (+3/-3)
src/maasserver/models/tests/test_packagerepository.py (+4/-4)
src/maasserver/models/tests/test_partitiontable.py (+3/-3)
src/maasserver/models/tests/test_podstoragepool.py (+2/-2)
src/maasserver/models/tests/test_versionedtextfile.py (+7/-7)
src/maasserver/prometheus/tests/test_stats.py (+3/-3)
src/maasserver/rpc/tests/test_boot.py (+12/-12)
src/maasserver/rpc/tests/test_leases.py (+9/-11)
src/maasserver/rpc/tests/test_nodes.py (+1/-1)
src/maasserver/rpc/tests/test_rackcontrollers.py (+2/-2)
src/maasserver/rpc/tests/test_regionservice.py (+6/-6)
src/maasserver/rpc/tests/test_regionservice_calls.py (+1/-1)
src/maasserver/tests/test_audit.py (+5/-5)
src/maasserver/tests/test_bootresources.py (+8/-8)
src/maasserver/tests/test_bootsources.py (+5/-5)
src/maasserver/tests/test_config_forms.py (+1/-1)
src/maasserver/tests/test_dhcp.py (+27/-27)
src/maasserver/tests/test_eventloop.py (+11/-11)
src/maasserver/tests/test_fields.py (+9/-9)
src/maasserver/tests/test_ipc.py (+10/-10)
src/maasserver/tests/test_listener.py (+3/-3)
src/maasserver/tests/test_node_action.py (+3/-5)
src/maasserver/tests/test_node_constraint_filter_forms.py (+6/-6)
src/maasserver/tests/test_preseed.py (+1/-1)
src/maasserver/tests/test_rack_controller.py (+8/-8)
src/maasserver/tests/test_region_controller.py (+4/-4)
src/maasserver/tests/test_start_up.py (+2/-2)
src/maasserver/tests/test_stats.py (+4/-4)
src/maasserver/tests/test_status_monitor.py (+19/-19)
src/maasserver/tests/test_storage_layouts.py (+13/-13)
src/maasserver/tests/test_workers.py (+9/-9)
src/maasserver/triggers/tests/test_system_listener.py (+2/-2)
src/maasserver/utils/tests/test_osystems.py (+7/-7)
src/maasserver/utils/tests/test_storage.py (+1/-1)
src/maasserver/utils/tests/test_utils.py (+7/-7)
src/maasserver/views/tests/test_account.py (+4/-4)
src/maasserver/websockets/handlers/tests/test_bootresource.py (+9/-9)
src/maasserver/websockets/handlers/tests/test_config.py (+4/-6)
src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py (+2/-2)
src/maasserver/websockets/handlers/tests/test_discovery.py (+2/-2)
src/maasserver/websockets/handlers/tests/test_machine.py (+12/-12)
src/maasserver/websockets/handlers/tests/test_node_result.py (+10/-12)
src/maasserver/websockets/handlers/tests/test_packagerepository.py (+1/-1)
src/maasserver/websockets/handlers/tests/test_subnet.py (+3/-3)
src/maasserver/websockets/handlers/tests/test_zone.py (+3/-3)
src/maasserver/websockets/tests/test_protocol.py (+8/-10)
src/metadataserver/builtin_scripts/commissioning_scripts/tests/test_bmc_config.py (+4/-4)
src/metadataserver/builtin_scripts/testing_scripts/tests/test_badblocks.py (+3/-5)
src/metadataserver/builtin_scripts/testing_scripts/tests/test_seven_z.py (+1/-1)
src/metadataserver/builtin_scripts/testing_scripts/tests/test_smartctl.py (+9/-9)
src/metadataserver/builtin_scripts/tests/test_builtin_scripts.py (+15/-15)
src/metadataserver/builtin_scripts/tests/test_hooks.py (+25/-27)
src/metadataserver/models/tests/test_nodekey.py (+3/-3)
src/metadataserver/models/tests/test_script.py (+11/-11)
src/metadataserver/models/tests/test_scriptresult.py (+60/-62)
src/metadataserver/models/tests/test_scriptset.py (+37/-41)
src/metadataserver/tests/test_api.py (+45/-45)
src/metadataserver/tests/test_api_twisted.py (+16/-16)
src/metadataserver/tests/test_vendor_data.py (+2/-2)
src/metadataserver/user_data/templates/snippets/tests/test_maas_run_remote_scripts.py (+31/-31)
src/metadataserver/user_data/tests/test_generate_user_data.py (+18/-18)
src/provisioningserver/boot/tests/test_pxe.py (+2/-2)
src/provisioningserver/dhcp/tests/test_helper_clean.py (+1/-1)
src/provisioningserver/drivers/osystem/tests/test_bootloader.py (+2/-2)
src/provisioningserver/drivers/osystem/tests/test_ubuntu.py (+1/-1)
src/provisioningserver/drivers/pod/tests/test_base.py (+62/-62)
src/provisioningserver/drivers/pod/tests/test_lxd.py (+22/-22)
src/provisioningserver/drivers/pod/tests/test_rsd.py (+43/-43)
src/provisioningserver/drivers/pod/tests/test_virsh.py (+41/-41)
src/provisioningserver/drivers/power/tests/test_msftocs.py (+1/-1)
src/provisioningserver/drivers/power/tests/test_openbmc.py (+2/-2)
src/provisioningserver/drivers/power/tests/test_recs.py (+4/-4)
src/provisioningserver/drivers/power/tests/test_redfish.py (+11/-11)
src/provisioningserver/proxy/tests/test_config.py (+2/-2)
src/provisioningserver/rackdservices/tests/test_external.py (+6/-6)
src/provisioningserver/rackdservices/tests/test_http.py (+17/-17)
src/provisioningserver/rackdservices/tests/test_lease_socket_service.py (+5/-5)
src/provisioningserver/rackdservices/tests/test_service_monitor_service.py (+2/-2)
src/provisioningserver/rackdservices/tests/test_tftp.py (+16/-16)
src/provisioningserver/refresh/tests/test_maas_api_helper.py (+8/-8)
src/provisioningserver/refresh/tests/test_refresh.py (+2/-2)
src/provisioningserver/rpc/tests/test_clusterservice.py (+8/-8)
src/provisioningserver/rpc/tests/test_dhcp.py (+6/-6)
src/provisioningserver/rpc/tests/test_pods.py (+2/-2)
src/provisioningserver/syslog/tests/test_config.py (+2/-2)
src/provisioningserver/tests/test_maas_certificates.py (+2/-2)
src/provisioningserver/utils/tests/test_avahi.py (+4/-4)
src/provisioningserver/utils/tests/test_dhclient.py (+3/-3)
src/provisioningserver/utils/tests/test_env.py (+5/-5)
src/provisioningserver/utils/tests/test_fs.py (+1/-1)
src/provisioningserver/utils/tests/test_ipaddr.py (+1/-1)
src/provisioningserver/utils/tests/test_iproute.py (+4/-4)
src/provisioningserver/utils/tests/test_lxd.py (+1/-1)
src/provisioningserver/utils/tests/test_network.py (+6/-6)
src/provisioningserver/utils/tests/test_ps.py (+1/-3)
src/provisioningserver/utils/tests/test_service_monitor.py (+10/-10)
src/provisioningserver/utils/tests/test_url.py (+2/-2)
src/provisioningserver/utils/tests/test_utils.py (+3/-3)
Reviewer Review Type Date Requested Status
Dougal Matthews (community) Approve
Alberto Donato (community) Approve
MAAS Lander Approve
Review via email: mp+394459@code.launchpad.net

Commit message

s/assertEquals/assertEqual/g

Replace all assertEquals with preferred spelling of assertEqual.

Simple bowler script of:

query = Query().select_method("assertEquals").rename("assertEqual").write()

To post a comment you must log in.
~adam-collard/maas:no-assert-equals updated
607f037... by Adam Collard

Blacken

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b no-assert-equals lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8756/console
COMMIT: 81aab4f30dacb590efb8cd3b2e300d97c9a685ad

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b no-assert-equals lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 7169f72b1d771b2d4d0bc821dcf4e1c610ff1a32

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

+1.

I think we should also add a script to run as part of `make lint` which checks that we don't reintroduce those (we can later extend it to look for other things that we want to move away from (like dreaded assertThat).
I don't mean to add it to this branch, just a thought.

review: Approve
Revision history for this message
Dougal Matthews (d0ugal) wrote :

> (like dreaded assertThat).

We could remove testtools instead, or overwrite it.

def assertThat(self, *args, **kwargs):
    raise SyntaxError("not a chance")

review: Approve
~adam-collard/maas:no-assert-equals updated
45f24c3... by Adam Collard

Remove the triple quotes that were effectively ignoring tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/maascli/actions/tests/test_sshkeys_import.py b/src/maascli/actions/tests/test_sshkeys_import.py
index 540dc30..d8de2b4 100644
--- a/src/maascli/actions/tests/test_sshkeys_import.py
+++ b/src/maascli/actions/tests/test_sshkeys_import.py
@@ -39,14 +39,14 @@ class TestSSHKeysImportAction(MAASTestCase):
39 )39 )
40 expected_data = ("keysource", ks)40 expected_data = ("keysource", ks)
41 data = action.name_value_pair(ks)41 data = action.name_value_pair(ks)
42 self.assertEquals(data, expected_data)42 self.assertEqual(data, expected_data)
4343
44 def test_name_value_pair_returns_sshkey_creds_tuple_for_no_protocol(self):44 def test_name_value_pair_returns_sshkey_creds_tuple_for_no_protocol(self):
45 action = self.make_sshkeys_import_action()45 action = self.make_sshkeys_import_action()
46 ks = factory.make_name("user-id")46 ks = factory.make_name("user-id")
47 expected_data = ("keysource", ks)47 expected_data = ("keysource", ks)
48 data = action.name_value_pair(ks)48 data = action.name_value_pair(ks)
49 self.assertEquals(data, expected_data)49 self.assertEqual(data, expected_data)
5050
51 def test_name_value_pair_returns_sshkey_creds_tuple_for_no_input(self):51 def test_name_value_pair_returns_sshkey_creds_tuple_for_no_input(self):
52 action = self.make_sshkeys_import_action()52 action = self.make_sshkeys_import_action()
diff --git a/src/maascli/tests/test_snappy.py b/src/maascli/tests/test_snappy.py
index 2014071..95458f7 100644
--- a/src/maascli/tests/test_snappy.py
+++ b/src/maascli/tests/test_snappy.py
@@ -257,7 +257,7 @@ class TestSupervisordHelpers(MAASTestCase):
257 mock_popen.return_value = mock_process257 mock_popen.return_value = mock_process
258 snappy.sighup_supervisord()258 snappy.sighup_supervisord()
259 self.assertThat(mock_kill, MockCalledOnceWith(pid, signal.SIGHUP))259 self.assertThat(mock_kill, MockCalledOnceWith(pid, signal.SIGHUP))
260 self.assertEquals(2, mock_popen.call_count)260 self.assertEqual(2, mock_popen.call_count)
261261
262262
263class TestConfigHelpers(MAASTestCase):263class TestConfigHelpers(MAASTestCase):
@@ -302,7 +302,7 @@ class TestConfigHelpers(MAASTestCase):
302 def test_set_rpc_secret_sets_secret(self):302 def test_set_rpc_secret_sets_secret(self):
303 secret = factory.make_string()303 secret = factory.make_string()
304 snappy.set_rpc_secret(secret)304 snappy.set_rpc_secret(secret)
305 self.assertEquals(secret, snappy.get_rpc_secret())305 self.assertEqual(secret, snappy.get_rpc_secret())
306306
307 def test_set_rpc_secret_clears_secret(self):307 def test_set_rpc_secret_clears_secret(self):
308 secret = factory.make_string()308 secret = factory.make_string()
diff --git a/src/maasserver/api/tests/test_blockdevice.py b/src/maasserver/api/tests/test_blockdevice.py
index 8329df7..e03ecea 100644
--- a/src/maasserver/api/tests/test_blockdevice.py
+++ b/src/maasserver/api/tests/test_blockdevice.py
@@ -1183,51 +1183,66 @@ class TestBlockDeviceAPI(APITestCase.ForUser):
1183 http.client.CONFLICT, response.status_code, response.content1183 http.client.CONFLICT, response.status_code, response.content
1184 )1184 )
11851185
1186 """
1187 def test_set_boot_disk_returns_400_for_virtual_device(self):1186 def test_set_boot_disk_returns_400_for_virtual_device(self):
1188 self.become_admin()1187 self.become_admin()
1189 node = factory.make_Node(owner=self.user)1188 node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user)
1190 block_device = factory.make_VirtualBlockDevice(node=node)1189 block_device = factory.make_VirtualBlockDevice(node=node)
1191 uri = get_blockdevice_uri(block_device)1190 uri = get_blockdevice_uri(block_device)
1192 response = self.client.post(uri, {1191 response = self.client.post(
1193 'op': "set_boot_disk",1192 uri,
1194 })1193 {
1194 "op": "set_boot_disk",
1195 },
1196 )
1197 self.assertEqual(
1198 http.client.BAD_REQUEST, response.status_code, response.content
1199 )
1195 self.assertEqual(1200 self.assertEqual(
1196 httplib.BAD_REQUEST, response.status_code, response.content)1201 b"Cannot set a virtual block device as the boot disk.",
1197 self.assertEquals(1202 response.content,
1198 "Cannot set a virtual block device as the boot disk.",1203 )
1199 response.content)
12001204
1201 def test_set_boot_disk_returns_403_for_normal_user(self):1205 def test_set_boot_disk_returns_403_for_normal_user(self):
1202 node = factory.make_Node(owner=self.user)1206 node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user)
1203 block_device = factory.make_PhysicalBlockDevice(node=node)1207 block_device = factory.make_PhysicalBlockDevice(node=node)
1204 uri = get_blockdevice_uri(block_device)1208 uri = get_blockdevice_uri(block_device)
1205 response = self.client.post(uri, {1209 response = self.client.post(
1206 'op': "set_boot_disk",1210 uri,
1207 })1211 {
1212 "op": "set_boot_disk",
1213 },
1214 )
1208 self.assertEqual(1215 self.assertEqual(
1209 httplib.FORBIDDEN, response.status_code, response.content)1216 http.client.FORBIDDEN, response.status_code, response.content
1217 )
12101218
1211 def test_set_boot_disk_returns_404_for_block_device_not_on_node(self):1219 def test_set_boot_disk_returns_404_for_block_device_not_on_node(self):
1212 node = factory.make_Node(owner=self.user)1220 node = factory.make_Node(owner=self.user)
1213 block_device = factory.make_PhysicalBlockDevice()1221 block_device = factory.make_PhysicalBlockDevice()
1214 uri = get_blockdevice_uri(block_device, node=node)1222 uri = get_blockdevice_uri(block_device, node=node)
1215 response = self.client.post(uri, {1223 response = self.client.post(
1216 'op': "set_boot_disk",1224 uri,
1217 })1225 {
1226 "op": "set_boot_disk",
1227 },
1228 )
1218 self.assertEqual(1229 self.assertEqual(
1219 httplib.NOT_FOUND, response.status_code, response.content)1230 http.client.NOT_FOUND, response.status_code, response.content
1231 )
12201232
1221 def test_set_boot_disk_sets_boot_disk_for_admin(self):1233 def test_set_boot_disk_sets_boot_disk_for_admin(self):
1222 self.become_admin()1234 self.become_admin()
1223 node = factory.make_Node(owner=self.user)1235 node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user)
1224 block_device = factory.make_PhysicalBlockDevice(node=node)1236 block_device = factory.make_PhysicalBlockDevice(node=node)
1225 uri = get_blockdevice_uri(block_device)1237 uri = get_blockdevice_uri(block_device)
1226 response = self.client.post(uri, {1238 response = self.client.post(
1227 'op': "set_boot_disk",1239 uri,
1228 })1240 {
1241 "op": "set_boot_disk",
1242 },
1243 )
1229 self.assertEqual(1244 self.assertEqual(
1230 httplib.OK, response.status_code, response.content)1245 http.client.OK, response.status_code, response.content
1246 )
1231 node = reload_object(node)1247 node = reload_object(node)
1232 self.assertEquals(block_device, node.boot_disk)1248 self.assertEqual(block_device, node.boot_disk)
1233 """
diff --git a/src/maasserver/api/tests/test_commissioning.py b/src/maasserver/api/tests/test_commissioning.py
index 33310c3..671125f 100644
--- a/src/maasserver/api/tests/test_commissioning.py
+++ b/src/maasserver/api/tests/test_commissioning.py
@@ -65,8 +65,8 @@ class AdminCommissioningScriptsAPITest(APITestCase.ForAdmin):
65 self.assertThat(response, HasStatusCode(http.client.OK))65 self.assertThat(response, HasStatusCode(http.client.OK))
6666
67 returned_script = json_load_bytes(response.content)67 returned_script = json_load_bytes(response.content)
68 self.assertEquals(name, returned_script["name"])68 self.assertEqual(name, returned_script["name"])
69 self.assertEquals(69 self.assertEqual(
70 content.encode(), b64decode(returned_script["content"])70 content.encode(), b64decode(returned_script["content"])
71 )71 )
7272
@@ -133,7 +133,7 @@ class AdminCommissioningScriptAPITest(APITestCase.ForAdmin):
133 {"content": factory.make_file_upload(content=new_content)},133 {"content": factory.make_file_upload(content=new_content)},
134 )134 )
135 self.assertThat(response, HasStatusCode(http.client.OK))135 self.assertThat(response, HasStatusCode(http.client.OK))
136 self.assertEquals(rc.ALL_OK.content, response.content)136 self.assertEqual(rc.ALL_OK.content, response.content)
137137
138 self.assertEqual(138 self.assertEqual(
139 new_content.decode("utf-8"), reload_object(script).script.data139 new_content.decode("utf-8"), reload_object(script).script.data
@@ -244,7 +244,7 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser):
244 for parsed_result in parsed_results:244 for parsed_result in parsed_results:
245 if parsed_result["name"] == script_result.name:245 if parsed_result["name"] == script_result.name:
246 break246 break
247 self.assertEquals(247 self.assertEqual(
248 node.current_commissioning_script_set.scriptresult_set.count()248 node.current_commissioning_script_set.scriptresult_set.count()
249 + node.current_testing_script_set.scriptresult_set.count()249 + node.current_testing_script_set.scriptresult_set.count()
250 + node.current_installation_script_set.scriptresult_set.count(),250 + node.current_installation_script_set.scriptresult_set.count(),
@@ -264,16 +264,16 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser):
264 ],264 ],
265 parsed_result.keys(),265 parsed_result.keys(),
266 )266 )
267 self.assertEquals(script_result.id, parsed_result["id"])267 self.assertEqual(script_result.id, parsed_result["id"])
268 self.assertEquals(script_result.name, parsed_result["name"])268 self.assertEqual(script_result.name, parsed_result["name"])
269 self.assertEquals(269 self.assertEqual(
270 script_result.exit_status, parsed_result["script_result"]270 script_result.exit_status, parsed_result["script_result"]
271 )271 )
272 self.assertEquals(script_set.result_type, parsed_result["result_type"])272 self.assertEqual(script_set.result_type, parsed_result["result_type"])
273 self.assertEquals(273 self.assertEqual(
274 {"system_id": script_set.node.system_id}, parsed_result["node"]274 {"system_id": script_set.node.system_id}, parsed_result["node"]
275 )275 )
276 self.assertEquals(276 self.assertEqual(
277 script_result.stdout, b64decode(parsed_result["data"])277 script_result.stdout, b64decode(parsed_result["data"])
278 )278 )
279279
@@ -396,7 +396,7 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser):
396 response = self.client.get(url, {"name": script_result.name})396 response = self.client.get(url, {"name": script_result.name})
397 self.assertThat(response, HasStatusCode(http.client.OK))397 self.assertThat(response, HasStatusCode(http.client.OK))
398 parsed_results = json_load_bytes(response.content)398 parsed_results = json_load_bytes(response.content)
399 self.assertEquals(script_result.id, parsed_results[0]["id"])399 self.assertEqual(script_result.id, parsed_results[0]["id"])
400400
401 def test_list_displays_only_visible_nodes(self):401 def test_list_displays_only_visible_nodes(self):
402 node = factory.make_Node(402 node = factory.make_Node(
diff --git a/src/maasserver/api/tests/test_devices.py b/src/maasserver/api/tests/test_devices.py
index bd5ff70..c305d20 100644
--- a/src/maasserver/api/tests/test_devices.py
+++ b/src/maasserver/api/tests/test_devices.py
@@ -56,9 +56,9 @@ class TestDevicesAPI(APITestCase.ForUser):
56 device = Device.objects.get(system_id=system_id)56 device = Device.objects.get(system_id=system_id)
57 self.assertEqual(hostname, device.hostname)57 self.assertEqual(hostname, device.hostname)
58 self.assertIsNone(device.parent)58 self.assertIsNone(device.parent)
59 self.assertEquals(device.node_type, NODE_TYPE.DEVICE)59 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)
60 self.assertEquals(self.user, device.owner)60 self.assertEqual(self.user, device.owner)
61 self.assertEquals(61 self.assertEqual(
62 macs, {nic.mac_address for nic in device.interface_set.all()}62 macs, {nic.mac_address for nic in device.interface_set.all()}
63 )63 )
6464
@@ -81,8 +81,8 @@ class TestDevicesAPI(APITestCase.ForUser):
81 )81 )
82 system_id = json_load_bytes(response.content)["system_id"]82 system_id = json_load_bytes(response.content)["system_id"]
83 device = Device.objects.get(system_id=system_id)83 device = Device.objects.get(system_id=system_id)
84 self.assertEquals(hostname, device.hostname)84 self.assertEqual(hostname, device.hostname)
85 self.assertEquals(parent, device.parent)85 self.assertEqual(parent, device.parent)
86 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)86 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)
8787
88 def test_POST_creates_device_with_default_domain(self):88 def test_POST_creates_device_with_default_domain(self):
@@ -99,8 +99,8 @@ class TestDevicesAPI(APITestCase.ForUser):
99 )99 )
100 system_id = json_load_bytes(response.content)["system_id"]100 system_id = json_load_bytes(response.content)["system_id"]
101 device = Device.objects.get(system_id=system_id)101 device = Device.objects.get(system_id=system_id)
102 self.assertEquals(hostname, device.hostname)102 self.assertEqual(hostname, device.hostname)
103 self.assertEquals(Domain.objects.get_default_domain(), device.domain)103 self.assertEqual(Domain.objects.get_default_domain(), device.domain)
104 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)104 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)
105105
106 def test_POST_creates_device_with_domain(self):106 def test_POST_creates_device_with_domain(self):
@@ -122,8 +122,8 @@ class TestDevicesAPI(APITestCase.ForUser):
122 )122 )
123 system_id = json_load_bytes(response.content)["system_id"]123 system_id = json_load_bytes(response.content)["system_id"]
124 device = Device.objects.get(system_id=system_id)124 device = Device.objects.get(system_id=system_id)
125 self.assertEquals(hostname, device.hostname)125 self.assertEqual(hostname, device.hostname)
126 self.assertEquals(domain, device.domain)126 self.assertEqual(domain, device.domain)
127 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)127 self.assertEqual(device.node_type, NODE_TYPE.DEVICE)
128128
129 def test_POST_without_macs_raises_appropriate_error(self):129 def test_POST_without_macs_raises_appropriate_error(self):
diff --git a/src/maasserver/api/tests/test_dhcpsnippets.py b/src/maasserver/api/tests/test_dhcpsnippets.py
index 21a0e2e..d844daa 100644
--- a/src/maasserver/api/tests/test_dhcpsnippets.py
+++ b/src/maasserver/api/tests/test_dhcpsnippets.py
@@ -198,7 +198,7 @@ class TestDHCPSnippetAPI(APITestCase.ForUser):
198 http.client.OK, response.status_code, response.content198 http.client.OK, response.status_code, response.content
199 )199 )
200 parsed_dhcp_snippet = json.loads(response.content.decode())200 parsed_dhcp_snippet = json.loads(response.content.decode())
201 self.assertEquals(201 self.assertEqual(
202 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,202 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,
203 parsed_dhcp_snippet["value"],203 parsed_dhcp_snippet["value"],
204 )204 )
@@ -326,10 +326,10 @@ class TestDHCPSnippetsAPI(APITestCase.ForUser):
326 },326 },
327 )327 )
328 parsed_dhcp_snippet = json.loads(response.content.decode())328 parsed_dhcp_snippet = json.loads(response.content.decode())
329 self.assertEquals(name, parsed_dhcp_snippet["name"])329 self.assertEqual(name, parsed_dhcp_snippet["name"])
330 self.assertEquals(value, parsed_dhcp_snippet["value"])330 self.assertEqual(value, parsed_dhcp_snippet["value"])
331 self.assertEquals(description, parsed_dhcp_snippet["description"])331 self.assertEqual(description, parsed_dhcp_snippet["description"])
332 self.assertEquals(enabled, parsed_dhcp_snippet["enabled"])332 self.assertEqual(enabled, parsed_dhcp_snippet["enabled"])
333333
334 def test_create_admin_only(self):334 def test_create_admin_only(self):
335 response = self.client.post(335 response = self.client.post(
diff --git a/src/maasserver/api/tests/test_interfaces.py b/src/maasserver/api/tests/test_interfaces.py
index 396b1bb..890f27d 100644
--- a/src/maasserver/api/tests/test_interfaces.py
+++ b/src/maasserver/api/tests/test_interfaces.py
@@ -1104,8 +1104,8 @@ class TestNodeInterfaceAPI(APITransactionTestCase.ForUser):
1104 http.client.OK, response.status_code, response.content1104 http.client.OK, response.status_code, response.content
1105 )1105 )
1106 parsed_interface = json_load_bytes(response.content)1106 parsed_interface = json_load_bytes(response.content)
1107 self.assertEquals(new_name, parsed_interface["name"])1107 self.assertEqual(new_name, parsed_interface["name"])
1108 self.assertEquals(new_vlan.vid, parsed_interface["vlan"]["vid"])1108 self.assertEqual(new_vlan.vid, parsed_interface["vlan"]["vid"])
11091109
1110 def test_update_bond_interface(self):1110 def test_update_bond_interface(self):
1111 self.become_admin()1111 self.become_admin()
@@ -1979,7 +1979,7 @@ class TestInterfaceAPIForControllers(APITestCase.ForUser):
1979 http.client.OK, response.status_code, response.content1979 http.client.OK, response.status_code, response.content
1980 )1980 )
1981 parsed_interface = json_load_bytes(response.content)1981 parsed_interface = json_load_bytes(response.content)
1982 self.assertEquals(new_vlan.id, parsed_interface["vlan"]["id"])1982 self.assertEqual(new_vlan.id, parsed_interface["vlan"]["id"])
19831983
1984 def test_update_only_works_for_vlan_field(self):1984 def test_update_only_works_for_vlan_field(self):
1985 self.become_admin()1985 self.become_admin()
@@ -1997,8 +1997,8 @@ class TestInterfaceAPIForControllers(APITestCase.ForUser):
1997 http.client.OK, response.status_code, response.content1997 http.client.OK, response.status_code, response.content
1998 )1998 )
1999 parsed_interface = json_load_bytes(response.content)1999 parsed_interface = json_load_bytes(response.content)
2000 self.assertEquals(new_vlan.id, parsed_interface["vlan"]["id"])2000 self.assertEqual(new_vlan.id, parsed_interface["vlan"]["id"])
2001 self.assertEquals(interface.name, parsed_interface["name"])2001 self.assertEqual(interface.name, parsed_interface["name"])
20022002
2003 def test_update_forbidden_for_vlan_interface(self):2003 def test_update_forbidden_for_vlan_interface(self):
2004 self.become_admin()2004 self.become_admin()
diff --git a/src/maasserver/api/tests/test_machine.py b/src/maasserver/api/tests/test_machine.py
index dd6495c..9450e24 100644
--- a/src/maasserver/api/tests/test_machine.py
+++ b/src/maasserver/api/tests/test_machine.py
@@ -854,7 +854,7 @@ class TestMachineAPI(APITestCase.ForUser):
854 http.client.OK, response.status_code, response.content854 http.client.OK, response.status_code, response.content
855 )855 )
856 response_content = json_load_bytes(response.content)856 response_content = json_load_bytes(response.content)
857 self.assertEquals("virsh", response_content["power_type"])857 self.assertEqual("virsh", response_content["power_type"])
858858
859 def test_POST_deploy_allocates_ready_machines(self):859 def test_POST_deploy_allocates_ready_machines(self):
860 self.patch(node_module.Node, "_start")860 self.patch(node_module.Node, "_start")
diff --git a/src/maasserver/api/tests/test_machines.py b/src/maasserver/api/tests/test_machines.py
index 0736ffe..8f43d33 100644
--- a/src/maasserver/api/tests/test_machines.py
+++ b/src/maasserver/api/tests/test_machines.py
@@ -247,7 +247,7 @@ class TestMachinesAPI(APITestCase.ForUser):
247 validation_errors = json.loads(247 validation_errors = json.loads(
248 response.content.decode(settings.DEFAULT_CHARSET)248 response.content.decode(settings.DEFAULT_CHARSET)
249 )["power_type"]249 )["power_type"]
250 self.assertEquals(250 self.assertEqual(
251 "Select a valid choice. %s is not one of the "251 "Select a valid choice. %s is not one of the "
252 "available choices." % power_type,252 "available choices." % power_type,
253 validation_errors[0],253 validation_errors[0],
@@ -269,7 +269,7 @@ class TestMachinesAPI(APITestCase.ForUser):
269 response.content.decode(settings.DEFAULT_CHARSET)269 response.content.decode(settings.DEFAULT_CHARSET)
270 )["system_id"]270 )["system_id"]
271 machine = Machine.objects.get(system_id=system_id)271 machine = Machine.objects.get(system_id=system_id)
272 self.assertEquals("", machine.power_type)272 self.assertEqual("", machine.power_type)
273 self.assertEqual({}, machine.power_parameters)273 self.assertEqual({}, machine.power_parameters)
274274
275 def test_POST_handles_error_when_unable_to_access_bmc(self):275 def test_POST_handles_error_when_unable_to_access_bmc(self):
@@ -319,8 +319,8 @@ class TestMachinesAPI(APITestCase.ForUser):
319 },319 },
320 )320 )
321 parsed_result = json.loads(response.content.decode())321 parsed_result = json.loads(response.content.decode())
322 self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"])322 self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"])
323 self.assertEquals(description, parsed_result["description"])323 self.assertEqual(description, parsed_result["description"])
324324
325 def test_POST_starts_commissioning_with_selected_test_scripts(self):325 def test_POST_starts_commissioning_with_selected_test_scripts(self):
326 # Regression test for LP1707562326 # Regression test for LP1707562
@@ -342,7 +342,7 @@ class TestMachinesAPI(APITestCase.ForUser):
342 },342 },
343 )343 )
344 parsed_result = json.loads(response.content.decode())344 parsed_result = json.loads(response.content.decode())
345 self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"])345 self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"])
346 script_set = ScriptSet.objects.get(346 script_set = ScriptSet.objects.get(
347 id=parsed_result["current_testing_result_id"]347 id=parsed_result["current_testing_result_id"]
348 )348 )
@@ -366,7 +366,7 @@ class TestMachinesAPI(APITestCase.ForUser):
366 },366 },
367 )367 )
368 parsed_result = json.loads(response.content.decode())368 parsed_result = json.loads(response.content.decode())
369 self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"])369 self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"])
370370
371 def test_POST_commission_false(self):371 def test_POST_commission_false(self):
372 # Regression test for LP:1904398372 # Regression test for LP:1904398
@@ -382,7 +382,7 @@ class TestMachinesAPI(APITestCase.ForUser):
382 },382 },
383 )383 )
384 parsed_result = json.loads(response.content.decode())384 parsed_result = json.loads(response.content.decode())
385 self.assertEquals(NODE_STATUS.NEW, parsed_result["status"])385 self.assertEqual(NODE_STATUS.NEW, parsed_result["status"])
386386
387 def test_GET_lists_machines(self):387 def test_GET_lists_machines(self):
388 # The api allows for fetching the list of Machines.388 # The api allows for fetching the list of Machines.
@@ -457,7 +457,7 @@ class TestMachinesAPI(APITestCase.ForUser):
457 parsed_result = json.loads(457 parsed_result = json.loads(
458 response.content.decode(settings.DEFAULT_CHARSET)458 response.content.decode(settings.DEFAULT_CHARSET)
459 )459 )
460 self.assertEquals(460 self.assertEqual(
461 {461 {
462 "id": pod.id,462 "id": pod.id,
463 "name": pod.name,463 "name": pod.name,
diff --git a/src/maasserver/api/tests/test_node.py b/src/maasserver/api/tests/test_node.py
index 295a72f..e8b84f2 100644
--- a/src/maasserver/api/tests/test_node.py
+++ b/src/maasserver/api/tests/test_node.py
@@ -258,59 +258,59 @@ class TestNodeAPI(APITestCase.ForUser):
258 return SCRIPT_STATUS_CHOICES[status(s)][1]258 return SCRIPT_STATUS_CHOICES[status(s)][1]
259259
260 self.assertThat(response, HasStatusCode(http.client.OK))260 self.assertThat(response, HasStatusCode(http.client.OK))
261 self.assertEquals(261 self.assertEqual(
262 status(commissioning_script_result),262 status(commissioning_script_result),
263 parsed_result["commissioning_status"],263 parsed_result["commissioning_status"],
264 )264 )
265 self.assertEquals(265 self.assertEqual(
266 status_name(commissioning_script_result),266 status_name(commissioning_script_result),
267 parsed_result["commissioning_status_name"],267 parsed_result["commissioning_status_name"],
268 )268 )
269 self.assertEquals(testing_status, parsed_result["testing_status"])269 self.assertEqual(testing_status, parsed_result["testing_status"])
270 self.assertEquals(270 self.assertEqual(
271 SCRIPT_STATUS_CHOICES[testing_status][1],271 SCRIPT_STATUS_CHOICES[testing_status][1],
272 parsed_result["testing_status_name"],272 parsed_result["testing_status_name"],
273 )273 )
274 self.assertEquals(274 self.assertEqual(
275 status(cpu_script_result), parsed_result["cpu_test_status"]275 status(cpu_script_result), parsed_result["cpu_test_status"]
276 )276 )
277 self.assertEquals(277 self.assertEqual(
278 status_name(cpu_script_result),278 status_name(cpu_script_result),
279 parsed_result["cpu_test_status_name"],279 parsed_result["cpu_test_status_name"],
280 )280 )
281 self.assertEquals(281 self.assertEqual(
282 status(memory_script_result), parsed_result["memory_test_status"]282 status(memory_script_result), parsed_result["memory_test_status"]
283 )283 )
284 self.assertEquals(284 self.assertEqual(
285 status_name(memory_script_result),285 status_name(memory_script_result),
286 parsed_result["memory_test_status_name"],286 parsed_result["memory_test_status_name"],
287 )287 )
288 self.assertEquals(288 self.assertEqual(
289 status(network_script_result), parsed_result["network_test_status"]289 status(network_script_result), parsed_result["network_test_status"]
290 )290 )
291 self.assertEquals(291 self.assertEqual(
292 status_name(network_script_result),292 status_name(network_script_result),
293 parsed_result["network_test_status_name"],293 parsed_result["network_test_status_name"],
294 )294 )
295 self.assertEquals(295 self.assertEqual(
296 status(storage_script_result), parsed_result["storage_test_status"]296 status(storage_script_result), parsed_result["storage_test_status"]
297 )297 )
298 self.assertEquals(298 self.assertEqual(
299 status_name(storage_script_result),299 status_name(storage_script_result),
300 parsed_result["storage_test_status_name"],300 parsed_result["storage_test_status_name"],
301 )301 )
302 self.assertEquals(302 self.assertEqual(
303 status(node_script_result), parsed_result["other_test_status"]303 status(node_script_result), parsed_result["other_test_status"]
304 )304 )
305 self.assertEquals(305 self.assertEqual(
306 status_name(node_script_result),306 status_name(node_script_result),
307 parsed_result["other_test_status_name"],307 parsed_result["other_test_status_name"],
308 )308 )
309 self.assertEquals(309 self.assertEqual(
310 status(interface_script_result),310 status(interface_script_result),
311 parsed_result["interface_test_status"],311 parsed_result["interface_test_status"],
312 )312 )
313 self.assertEquals(313 self.assertEqual(
314 status_name(interface_script_result),314 status_name(interface_script_result),
315 parsed_result["interface_test_status_name"],315 parsed_result["interface_test_status_name"],
316 )316 )
diff --git a/src/maasserver/api/tests/test_pods.py b/src/maasserver/api/tests/test_pods.py
index 5c840e7..33586b5 100644
--- a/src/maasserver/api/tests/test_pods.py
+++ b/src/maasserver/api/tests/test_pods.py
@@ -491,7 +491,7 @@ class TestPodAPIAdmin(PodAPITestForAdmin, PodMixin):
491 self.assertEqual(491 self.assertEqual(
492 http.client.BAD_REQUEST, response.status_code, response.content492 http.client.BAD_REQUEST, response.status_code, response.content
493 )493 )
494 self.assertEquals(494 self.assertEqual(
495 b"Pod does not support composability.", response.content495 b"Pod does not support composability.", response.content
496 )496 )
497497
diff --git a/src/maasserver/api/tests/test_scriptresults.py b/src/maasserver/api/tests/test_scriptresults.py
index c005848..c775ff8 100644
--- a/src/maasserver/api/tests/test_scriptresults.py
+++ b/src/maasserver/api/tests/test_scriptresults.py
@@ -760,7 +760,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
760 self.assertThat(response, HasStatusCode(http.client.OK))760 self.assertThat(response, HasStatusCode(http.client.OK))
761 script_set = reload_object(script_set)761 script_set = reload_object(script_set)
762 self.assertIsNotNone(script_set)762 self.assertIsNotNone(script_set)
763 self.assertEquals(script_set.id, script_result.script_set.id)763 self.assertEqual(script_set.id, script_result.script_set.id)
764 script_result = reload_object(script_result)764 script_result = reload_object(script_result)
765 self.assertTrue(script_result.suppressed)765 self.assertTrue(script_result.suppressed)
766 for script_result in script_results:766 for script_result in script_results:
@@ -792,7 +792,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
792 self.assertThat(response, HasStatusCode(http.client.OK))792 self.assertThat(response, HasStatusCode(http.client.OK))
793 script_set = reload_object(script_set)793 script_set = reload_object(script_set)
794 self.assertIsNotNone(script_set)794 self.assertIsNotNone(script_set)
795 self.assertEquals(script_set.id, script_result.script_set.id)795 self.assertEqual(script_set.id, script_result.script_set.id)
796 script_result = reload_object(script_result)796 script_result = reload_object(script_result)
797 self.assertTrue(script_result.suppressed)797 self.assertTrue(script_result.suppressed)
798 for script_result in script_results:798 for script_result in script_results:
@@ -829,10 +829,10 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
829 self.assertThat(response, HasStatusCode(http.client.OK))829 self.assertThat(response, HasStatusCode(http.client.OK))
830 script_set = reload_object(script_set)830 script_set = reload_object(script_set)
831 self.assertIsNotNone(script_set)831 self.assertIsNotNone(script_set)
832 self.assertEquals(script_set.id, script_result.script_set.id)832 self.assertEqual(script_set.id, script_result.script_set.id)
833 script_result = reload_object(script_result)833 script_result = reload_object(script_result)
834 self.assertTrue(script_result.suppressed)834 self.assertTrue(script_result.suppressed)
835 self.assertEquals(hardware_type, script_result.script.hardware_type)835 self.assertEqual(hardware_type, script_result.script.hardware_type)
836 for script_result in script_results:836 for script_result in script_results:
837 script_result = reload_object(script_result)837 script_result = reload_object(script_result)
838 self.assertFalse(script_result.suppressed)838 self.assertFalse(script_result.suppressed)
@@ -858,7 +858,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
858 )858 )
859 binary.write(script_result.output)859 binary.write(script_result.output)
860 binary.write(b"\n")860 binary.write(b"\n")
861 self.assertEquals(binary.getvalue(), response.content)861 self.assertEqual(binary.getvalue(), response.content)
862862
863 def test_download_single(self):863 def test_download_single(self):
864 script_set = self.make_scriptset()864 script_set = self.make_scriptset()
@@ -869,7 +869,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
869 {"op": "download", "filter": script_result.id},869 {"op": "download", "filter": script_result.id},
870 )870 )
871 self.assertThat(response, HasStatusCode(http.client.OK))871 self.assertThat(response, HasStatusCode(http.client.OK))
872 self.assertEquals(script_result.output, response.content)872 self.assertEqual(script_result.output, response.content)
873873
874 def test_download_filetype_txt(self):874 def test_download_filetype_txt(self):
875 script_set = self.make_scriptset()875 script_set = self.make_scriptset()
@@ -880,7 +880,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
880 {"op": "download", "filetype": "txt", "filters": script_result.id},880 {"op": "download", "filetype": "txt", "filters": script_result.id},
881 )881 )
882 self.assertThat(response, HasStatusCode(http.client.OK))882 self.assertThat(response, HasStatusCode(http.client.OK))
883 self.assertEquals(script_result.output, response.content)883 self.assertEqual(script_result.output, response.content)
884884
885 def test_download_filetype_tar_xz(self):885 def test_download_filetype_tar_xz(self):
886 script_set = self.make_scriptset()886 script_set = self.make_scriptset()
@@ -935,7 +935,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
935 },935 },
936 )936 )
937 self.assertThat(response, HasStatusCode(http.client.OK))937 self.assertThat(response, HasStatusCode(http.client.OK))
938 self.assertEquals(script_result.output, response.content)938 self.assertEqual(script_result.output, response.content)
939939
940 def test_download_output_stdout(self):940 def test_download_output_stdout(self):
941 script_set = self.make_scriptset()941 script_set = self.make_scriptset()
@@ -946,7 +946,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
946 {"op": "download", "filter": script_result.id, "output": "stdout"},946 {"op": "download", "filter": script_result.id, "output": "stdout"},
947 )947 )
948 self.assertThat(response, HasStatusCode(http.client.OK))948 self.assertThat(response, HasStatusCode(http.client.OK))
949 self.assertEquals(script_result.stdout, response.content)949 self.assertEqual(script_result.stdout, response.content)
950950
951 def test_download_output_stderr(self):951 def test_download_output_stderr(self):
952 script_set = self.make_scriptset()952 script_set = self.make_scriptset()
@@ -957,7 +957,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
957 {"op": "download", "filter": script_result.id, "output": "stderr"},957 {"op": "download", "filter": script_result.id, "output": "stderr"},
958 )958 )
959 self.assertThat(response, HasStatusCode(http.client.OK))959 self.assertThat(response, HasStatusCode(http.client.OK))
960 self.assertEquals(script_result.stderr, response.content)960 self.assertEqual(script_result.stderr, response.content)
961961
962 def test_download_output_result(self):962 def test_download_output_result(self):
963 script_set = self.make_scriptset()963 script_set = self.make_scriptset()
@@ -968,7 +968,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
968 {"op": "download", "filter": script_result.id, "output": "result"},968 {"op": "download", "filter": script_result.id, "output": "result"},
969 )969 )
970 self.assertThat(response, HasStatusCode(http.client.OK))970 self.assertThat(response, HasStatusCode(http.client.OK))
971 self.assertEquals(script_result.result, response.content)971 self.assertEqual(script_result.result, response.content)
972972
973 def test_download_output_all(self):973 def test_download_output_all(self):
974 script_set = self.make_scriptset()974 script_set = self.make_scriptset()
@@ -1002,7 +1002,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
1002 binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode())1002 binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode())
1003 binary.write(script_result.result)1003 binary.write(script_result.result)
1004 binary.write(b"\n")1004 binary.write(b"\n")
1005 self.assertEquals(binary.getvalue(), response.content)1005 self.assertEqual(binary.getvalue(), response.content)
10061006
1007 def test_download_filters(self):1007 def test_download_filters(self):
1008 scripts = [factory.make_Script() for _ in range(10)]1008 scripts = [factory.make_Script() for _ in range(10)]
@@ -1043,9 +1043,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
1043 script_set.id,1043 script_set.id,
1044 )1044 )
1045 with tarfile.open(mode="r", fileobj=BytesIO(response.content)) as tar:1045 with tarfile.open(mode="r", fileobj=BytesIO(response.content)) as tar:
1046 self.assertEquals(1046 self.assertEqual(len(set(filtered_results)), len(tar.getmembers()))
1047 len(set(filtered_results)), len(tar.getmembers())
1048 )
1049 for script_result in filtered_results:1047 for script_result in filtered_results:
1050 path = os.path.join(root_dir, script_result.name)1048 path = os.path.join(root_dir, script_result.name)
1051 member = tar.getmember(path)1049 member = tar.getmember(path)
@@ -1081,7 +1079,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
1081 },1079 },
1082 )1080 )
1083 self.assertThat(response, HasStatusCode(http.client.OK))1081 self.assertThat(response, HasStatusCode(http.client.OK))
1084 self.assertEquals(script_result.output, response.content)1082 self.assertEqual(script_result.output, response.content)
10851083
1086 def test_download_shows_results_from_all_disks(self):1084 def test_download_shows_results_from_all_disks(self):
1087 # Regression test for #LP:17550601085 # Regression test for #LP:1755060
@@ -1192,4 +1190,4 @@ class TestNodeScriptResultAPI(APITestCase.ForUser):
1192 binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode())1190 binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode())
1193 binary.write(other_result.result)1191 binary.write(other_result.result)
1194 binary.write(b"\n")1192 binary.write(b"\n")
1195 self.assertEquals(binary.getvalue(), response.content)1193 self.assertEqual(binary.getvalue(), response.content)
diff --git a/src/maasserver/api/tests/test_scripts.py b/src/maasserver/api/tests/test_scripts.py
index c2a0d21..7718c7a 100644
--- a/src/maasserver/api/tests/test_scripts.py
+++ b/src/maasserver/api/tests/test_scripts.py
@@ -77,18 +77,18 @@ class TestScriptsAPI(APITestCase.ForUser):
77 parsed_result = json_load_bytes(response.content)77 parsed_result = json_load_bytes(response.content)
78 script = Script.objects.get(id=int(parsed_result["id"]))78 script = Script.objects.get(id=int(parsed_result["id"]))
7979
80 self.assertEquals(name, script.name)80 self.assertEqual(name, script.name)
81 self.assertEquals(title, script.title)81 self.assertEqual(title, script.title)
82 self.assertEquals(description, script.description)82 self.assertEqual(description, script.description)
83 self.assertThat(script.tags, ContainsAll(tags))83 self.assertThat(script.tags, ContainsAll(tags))
84 self.assertEquals(script_type, script.script_type)84 self.assertEqual(script_type, script.script_type)
85 self.assertEquals(hardware_type, script.hardware_type)85 self.assertEqual(hardware_type, script.hardware_type)
86 self.assertEquals(parallel, script.parallel)86 self.assertEqual(parallel, script.parallel)
87 self.assertDictEqual(packages, script.packages)87 self.assertDictEqual(packages, script.packages)
88 self.assertEquals(timeout, script.timeout.seconds)88 self.assertEqual(timeout, script.timeout.seconds)
89 self.assertEquals(destructive, script.destructive)89 self.assertEqual(destructive, script.destructive)
90 self.assertEquals(script_content, script.script.data)90 self.assertEqual(script_content, script.script.data)
91 self.assertEquals(comment, script.script.comment)91 self.assertEqual(comment, script.script.comment)
9292
93 def test_POST_gets_name_from_filename(self):93 def test_POST_gets_name_from_filename(self):
94 self.become_admin()94 self.become_admin()
@@ -125,18 +125,18 @@ class TestScriptsAPI(APITestCase.ForUser):
125 parsed_result = json_load_bytes(response.content)125 parsed_result = json_load_bytes(response.content)
126 script = Script.objects.get(id=int(parsed_result["id"]))126 script = Script.objects.get(id=int(parsed_result["id"]))
127127
128 self.assertEquals(name, script.name)128 self.assertEqual(name, script.name)
129 self.assertEquals(title, script.title)129 self.assertEqual(title, script.title)
130 self.assertEquals(description, script.description)130 self.assertEqual(description, script.description)
131 self.assertThat(script.tags, ContainsAll(tags))131 self.assertThat(script.tags, ContainsAll(tags))
132 self.assertEquals(script_type, script.script_type)132 self.assertEqual(script_type, script.script_type)
133 self.assertEquals(hardware_type, script.hardware_type)133 self.assertEqual(hardware_type, script.hardware_type)
134 self.assertEquals(parallel, script.parallel)134 self.assertEqual(parallel, script.parallel)
135 self.assertDictEqual(packages, script.packages)135 self.assertDictEqual(packages, script.packages)
136 self.assertEquals(timeout, script.timeout.seconds)136 self.assertEqual(timeout, script.timeout.seconds)
137 self.assertEquals(destructive, script.destructive)137 self.assertEqual(destructive, script.destructive)
138 self.assertEquals(script_content, script.script.data)138 self.assertEqual(script_content, script.script.data)
139 self.assertEquals(comment, script.script.comment)139 self.assertEqual(comment, script.script.comment)
140140
141 def test_POST_requires_admin(self):141 def test_POST_requires_admin(self):
142 response = self.client.post(self.get_scripts_uri())142 response = self.client.post(self.get_scripts_uri())
@@ -224,7 +224,7 @@ class TestScriptsAPI(APITestCase.ForUser):
224 parsed_results = json_load_bytes(response.content)224 parsed_results = json_load_bytes(response.content)
225225
226 for result in parsed_results:226 for result in parsed_results:
227 self.assertEquals(227 self.assertEqual(
228 scripts[result["name"]].script.data.encode(),228 scripts[result["name"]].script.data.encode(),
229 b64decode(result["history"][0]["data"].encode()),229 b64decode(result["history"][0]["data"].encode()),
230 )230 )
@@ -298,7 +298,7 @@ class TestScriptAPI(APITestCase.ForUser):
298 for result_rev in history:298 for result_rev in history:
299 for rev in script.script.previous_versions():299 for rev in script.script.previous_versions():
300 if rev.id == result_rev["id"]:300 if rev.id == result_rev["id"]:
301 self.assertEquals(301 self.assertEqual(
302 {302 {
303 "id": rev.id,303 "id": rev.id,
304 "comment": rev.comment,304 "comment": rev.comment,
@@ -354,7 +354,7 @@ class TestScriptAPI(APITestCase.ForUser):
354 for result_rev in history:354 for result_rev in history:
355 for rev in script.script.previous_versions():355 for rev in script.script.previous_versions():
356 if rev.id == result_rev["id"]:356 if rev.id == result_rev["id"]:
357 self.assertEquals(357 self.assertEqual(
358 {358 {
359 "id": rev.id,359 "id": rev.id,
360 "comment": rev.comment,360 "comment": rev.comment,
@@ -428,18 +428,18 @@ class TestScriptAPI(APITestCase.ForUser):
428 self.assertThat(response, HasStatusCode(http.client.OK))428 self.assertThat(response, HasStatusCode(http.client.OK))
429 script = reload_object(script)429 script = reload_object(script)
430430
431 self.assertEquals(name, script.name)431 self.assertEqual(name, script.name)
432 self.assertEquals(title, script.title)432 self.assertEqual(title, script.title)
433 self.assertEquals(description, script.description)433 self.assertEqual(description, script.description)
434 self.assertThat(script.tags, ContainsAll(tags))434 self.assertThat(script.tags, ContainsAll(tags))
435 self.assertEquals(script_type, script.script_type)435 self.assertEqual(script_type, script.script_type)
436 self.assertEquals(hardware_type, script.hardware_type)436 self.assertEqual(hardware_type, script.hardware_type)
437 self.assertEquals(parallel, script.parallel)437 self.assertEqual(parallel, script.parallel)
438 self.assertDictEqual(packages, script.packages)438 self.assertDictEqual(packages, script.packages)
439 self.assertEquals(timeout, script.timeout.seconds)439 self.assertEqual(timeout, script.timeout.seconds)
440 self.assertEquals(destructive, script.destructive)440 self.assertEqual(destructive, script.destructive)
441 self.assertEquals(script_content, script.script.data)441 self.assertEqual(script_content, script.script.data)
442 self.assertEquals(comment, script.script.comment)442 self.assertEqual(comment, script.script.comment)
443 self.assertIsNotNone(script.script.previous_version)443 self.assertIsNotNone(script.script.previous_version)
444444
445 def test_PUT_gets_name_from_filename(self):445 def test_PUT_gets_name_from_filename(self):
@@ -477,17 +477,17 @@ class TestScriptAPI(APITestCase.ForUser):
477 self.assertThat(response, HasStatusCode(http.client.OK))477 self.assertThat(response, HasStatusCode(http.client.OK))
478 script = reload_object(script)478 script = reload_object(script)
479479
480 self.assertEquals(name, script.name)480 self.assertEqual(name, script.name)
481 self.assertEquals(description, script.description)481 self.assertEqual(description, script.description)
482 self.assertThat(script.tags, ContainsAll(tags))482 self.assertThat(script.tags, ContainsAll(tags))
483 self.assertEquals(script_type, script.script_type)483 self.assertEqual(script_type, script.script_type)
484 self.assertEquals(hardware_type, script.hardware_type)484 self.assertEqual(hardware_type, script.hardware_type)
485 self.assertEquals(parallel, script.parallel)485 self.assertEqual(parallel, script.parallel)
486 self.assertDictEqual(packages, script.packages)486 self.assertDictEqual(packages, script.packages)
487 self.assertEquals(timeout, script.timeout.seconds)487 self.assertEqual(timeout, script.timeout.seconds)
488 self.assertEquals(destructive, script.destructive)488 self.assertEqual(destructive, script.destructive)
489 self.assertEquals(script_content, script.script.data)489 self.assertEqual(script_content, script.script.data)
490 self.assertEquals(comment, script.script.comment)490 self.assertEqual(comment, script.script.comment)
491 self.assertIsNotNone(script.script.previous_version)491 self.assertIsNotNone(script.script.previous_version)
492492
493 def test_PUT_admin_only(self):493 def test_PUT_admin_only(self):
@@ -503,7 +503,7 @@ class TestScriptAPI(APITestCase.ForUser):
503 self.get_script_uri(script), {"op": "download"}503 self.get_script_uri(script), {"op": "download"}
504 )504 )
505 self.assertThat(response, HasStatusCode(http.client.OK))505 self.assertThat(response, HasStatusCode(http.client.OK))
506 self.assertEquals(script.script.data, response.content.decode())506 self.assertEqual(script.script.data, response.content.decode())
507507
508 def test_download_gets_previous_revision(self):508 def test_download_gets_previous_revision(self):
509 script = factory.make_Script()509 script = factory.make_Script()
@@ -514,7 +514,7 @@ class TestScriptAPI(APITestCase.ForUser):
514 {"op": "download", "revision": script.script.previous_version.id},514 {"op": "download", "revision": script.script.previous_version.id},
515 )515 )
516 self.assertThat(response, HasStatusCode(http.client.OK))516 self.assertThat(response, HasStatusCode(http.client.OK))
517 self.assertEquals(517 self.assertEqual(
518 script.script.previous_version.data, response.content.decode()518 script.script.previous_version.data, response.content.decode()
519 )519 )
520520
@@ -527,7 +527,7 @@ class TestScriptAPI(APITestCase.ForUser):
527 {"op": "download", "rev": script.script.previous_version.id},527 {"op": "download", "rev": script.script.previous_version.id},
528 )528 )
529 self.assertThat(response, HasStatusCode(http.client.OK))529 self.assertThat(response, HasStatusCode(http.client.OK))
530 self.assertEquals(530 self.assertEqual(
531 script.script.previous_version.data, response.content.decode()531 script.script.previous_version.data, response.content.decode()
532 )532 )
533533
@@ -555,7 +555,7 @@ class TestScriptAPI(APITestCase.ForUser):
555 )555 )
556 self.assertThat(response, HasStatusCode(http.client.OK))556 self.assertThat(response, HasStatusCode(http.client.OK))
557 script = reload_object(script)557 script = reload_object(script)
558 self.assertEquals(558 self.assertEqual(
559 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,559 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,
560 script.script.data,560 script.script.data,
561 )561 )
diff --git a/src/maasserver/api/tests/test_ssl_key.py b/src/maasserver/api/tests/test_ssl_key.py
index 0217420..67af5a6 100644
--- a/src/maasserver/api/tests/test_ssl_key.py
+++ b/src/maasserver/api/tests/test_ssl_key.py
@@ -134,7 +134,7 @@ class TestSSLKeyHandlers(APITestCase.ForUser):
134 self.assertEqual(1, len(keys_after))134 self.assertEqual(1, len(keys_after))
135 self.assertEqual(keys[1].id, keys_after[0].id)135 self.assertEqual(keys[1].id, keys_after[0].id)
136 self.assertIsNotNone(event)136 self.assertIsNotNone(event)
137 self.assertEquals(137 self.assertEqual(
138 event.description, "Deleted SSL key id='%s'." % keys[0].id138 event.description, "Deleted SSL key id='%s'." % keys[0].id
139 )139 )
140140
diff --git a/src/maasserver/api/tests/test_tag.py b/src/maasserver/api/tests/test_tag.py
index 018259e..975b443 100644
--- a/src/maasserver/api/tests/test_tag.py
+++ b/src/maasserver/api/tests/test_tag.py
@@ -209,7 +209,7 @@ class TestTagAPI(APITestCase.ForUser):
209 # `default_gateways`, `health_status`, 'special_filesystems' and209 # `default_gateways`, `health_status`, 'special_filesystems' and
210 # 'resource_pool' the number of queries is not the same but it is210 # 'resource_pool' the number of queries is not the same but it is
211 # proportional to the number of machines.211 # proportional to the number of machines.
212 self.assertEquals(num_queries1, num_queries2 - (3 * 7))212 self.assertEqual(num_queries1, num_queries2 - (3 * 7))
213213
214 def test_GET_machines_returns_machines(self):214 def test_GET_machines_returns_machines(self):
215 tag = factory.make_Tag()215 tag = factory.make_Tag()
@@ -282,7 +282,7 @@ class TestTagAPI(APITestCase.ForUser):
282 # `default_gateways`, `health_status` and 'resource_pool', the number282 # `default_gateways`, `health_status` and 'resource_pool', the number
283 # of queries is not the same but it is proportional to the number of283 # of queries is not the same but it is proportional to the number of
284 # machines.284 # machines.
285 self.assertEquals(num_queries1, num_queries2 - (3 * 7))285 self.assertEqual(num_queries1, num_queries2 - (3 * 7))
286286
287 def test_GET_devices_returns_devices(self):287 def test_GET_devices_returns_devices(self):
288 tag = factory.make_Tag()288 tag = factory.make_Tag()
@@ -345,7 +345,7 @@ class TestTagAPI(APITestCase.ForUser):
345 len(extract_system_ids(parsed_result_2)),345 len(extract_system_ids(parsed_result_2)),
346 ],346 ],
347 )347 )
348 self.assertEquals(num_queries1, num_queries2)348 self.assertEqual(num_queries1, num_queries2)
349349
350 def test_GET_rack_controllers_returns_rack_controllers(self):350 def test_GET_rack_controllers_returns_rack_controllers(self):
351 self.become_admin()351 self.become_admin()
@@ -413,7 +413,7 @@ class TestTagAPI(APITestCase.ForUser):
413 len(extract_system_ids(parsed_result_2)),413 len(extract_system_ids(parsed_result_2)),
414 ],414 ],
415 )415 )
416 self.assertEquals(num_queries1, num_queries2 - (3 * 3))416 self.assertEqual(num_queries1, num_queries2 - (3 * 3))
417417
418 def test_GET_rack_controllers_returns_no_rack_controllers_nonadmin(self):418 def test_GET_rack_controllers_returns_no_rack_controllers_nonadmin(self):
419 tag = factory.make_Tag()419 tag = factory.make_Tag()
@@ -506,7 +506,7 @@ class TestTagAPI(APITestCase.ForUser):
506 len(extract_system_ids(parsed_result_2)),506 len(extract_system_ids(parsed_result_2)),
507 ],507 ],
508 )508 )
509 self.assertEquals(num_queries1, num_queries2 - 6)509 self.assertEqual(num_queries1, num_queries2 - 6)
510510
511 def test_GET_region_controllers_returns_no_controllers_nonadmin(self):511 def test_GET_region_controllers_returns_no_controllers_nonadmin(self):
512 tag = factory.make_Tag()512 tag = factory.make_Tag()
diff --git a/src/maasserver/api/tests/test_users.py b/src/maasserver/api/tests/test_users.py
index 9507d2c..7f0e190 100644
--- a/src/maasserver/api/tests/test_users.py
+++ b/src/maasserver/api/tests/test_users.py
@@ -181,7 +181,7 @@ class TestUsers(APITestCase.ForUser):
181 )181 )
182 event = Event.objects.get(type__level=AUDIT)182 event = Event.objects.get(type__level=AUDIT)
183 self.assertIsNotNone(event)183 self.assertIsNotNone(event)
184 self.assertEquals(event.description, "Created user '%s'." % username)184 self.assertEqual(event.description, "Created user '%s'." % username)
185185
186 def test_POST_creates_audit_event_for_admin(self):186 def test_POST_creates_audit_event_for_admin(self):
187 self.become_admin()187 self.become_admin()
@@ -197,7 +197,7 @@ class TestUsers(APITestCase.ForUser):
197 )197 )
198 event = Event.objects.get(type__level=AUDIT)198 event = Event.objects.get(type__level=AUDIT)
199 self.assertIsNotNone(event)199 self.assertIsNotNone(event)
200 self.assertEquals(event.description, "Created admin '%s'." % username)200 self.assertEqual(event.description, "Created admin '%s'." % username)
201201
202 def test_POST_password_required_without_external_auth(self):202 def test_POST_password_required_without_external_auth(self):
203 self.become_admin()203 self.become_admin()
@@ -552,7 +552,7 @@ class TestUser(APITestCase.ForUser):
552 self.client.delete(reverse("user_handler", args=[user.username]))552 self.client.delete(reverse("user_handler", args=[user.username]))
553 event = Event.objects.get(type__level=AUDIT)553 event = Event.objects.get(type__level=AUDIT)
554 self.assertIsNotNone(event)554 self.assertIsNotNone(event)
555 self.assertEquals(555 self.assertEqual(
556 event.description, "Deleted user '%s'." % user.username556 event.description, "Deleted user '%s'." % user.username
557 )557 )
558558
@@ -562,6 +562,6 @@ class TestUser(APITestCase.ForUser):
562 self.client.delete(reverse("user_handler", args=[user.username]))562 self.client.delete(reverse("user_handler", args=[user.username]))
563 event = Event.objects.get(type__level=AUDIT)563 event = Event.objects.get(type__level=AUDIT)
564 self.assertIsNotNone(event)564 self.assertIsNotNone(event)
565 self.assertEquals(565 self.assertEqual(
566 event.description, "Deleted admin '%s'." % user.username566 event.description, "Deleted admin '%s'." % user.username
567 )567 )
diff --git a/src/maasserver/api/tests/test_vmfs_datastores.py b/src/maasserver/api/tests/test_vmfs_datastores.py
index c805b89..2c24dd5 100644
--- a/src/maasserver/api/tests/test_vmfs_datastores.py
+++ b/src/maasserver/api/tests/test_vmfs_datastores.py
@@ -125,9 +125,9 @@ class TestVMFSDatastoresAPI(APITestCase.ForUser):
125 )125 )
126 self.assertThat(response, HasStatusCode(http.client.OK))126 self.assertThat(response, HasStatusCode(http.client.OK))
127 parsed_results = json_load_bytes(response.content)127 parsed_results = json_load_bytes(response.content)
128 self.assertEquals(node.system_id, parsed_results["system_id"])128 self.assertEqual(node.system_id, parsed_results["system_id"])
129 # VMFS should be using the 5 devices we listed above.129 # VMFS should be using the 5 devices we listed above.
130 self.assertEquals(5, len(parsed_results["devices"]))130 self.assertEqual(5, len(parsed_results["devices"]))
131 # VMFS should be using all the block devices we created.131 # VMFS should be using all the block devices we created.
132 self.assertItemsEqual(132 self.assertItemsEqual(
133 [bd.id for bd in block_devices] + [block_device.id],133 [bd.id for bd in block_devices] + [block_device.id],
@@ -147,7 +147,7 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser):
147 def test_handler_path(self):147 def test_handler_path(self):
148 node = factory.make_Machine()148 node = factory.make_Machine()
149 vmfs = factory.make_VMFS(node=node)149 vmfs = factory.make_VMFS(node=node)
150 self.assertEquals(150 self.assertEqual(
151 "/MAAS/api/2.0/nodes/%s/vmfs-datastore/%s/"151 "/MAAS/api/2.0/nodes/%s/vmfs-datastore/%s/"
152 % (node.system_id, vmfs.id),152 % (node.system_id, vmfs.id),
153 self.get_vmfs_uri(vmfs),153 self.get_vmfs_uri(vmfs),
@@ -183,7 +183,7 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser):
183 }183 }
184 ),184 ),
185 )185 )
186 self.assertEquals(186 self.assertEqual(
187 vmfs.filesystems.count(), len(parsed_result["devices"])187 vmfs.filesystems.count(), len(parsed_result["devices"])
188 )188 )
189189
@@ -242,8 +242,8 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser):
242 vmfs = reload_object(vmfs)242 vmfs = reload_object(vmfs)
243 partition_ids.add(new_bd.get_partitiontable().partitions.first().id)243 partition_ids.add(new_bd.get_partitiontable().partitions.first().id)
244244
245 self.assertEquals(new_name, vmfs.name)245 self.assertEqual(new_name, vmfs.name)
246 self.assertEquals(new_uuid, vmfs.uuid)246 self.assertEqual(new_uuid, vmfs.uuid)
247 self.assertItemsEqual(247 self.assertItemsEqual(
248 partition_ids,248 partition_ids,
249 [fs.get_parent().id for fs in vmfs.filesystems.all()],249 [fs.get_parent().id for fs in vmfs.filesystems.all()],
diff --git a/src/maasserver/api/tests/test_volume_groups.py b/src/maasserver/api/tests/test_volume_groups.py
index db13536..df1ddaf 100644
--- a/src/maasserver/api/tests/test_volume_groups.py
+++ b/src/maasserver/api/tests/test_volume_groups.py
@@ -189,7 +189,7 @@ class TestVolumeGroupAPI(APITestCase.ForUser):
189 volume_group = factory.make_FilesystemGroup(189 volume_group = factory.make_FilesystemGroup(
190 node=node, group_type=FILESYSTEM_GROUP_TYPE.LVM_VG190 node=node, group_type=FILESYSTEM_GROUP_TYPE.LVM_VG
191 )191 )
192 self.assertEquals(192 self.assertEqual(
193 "/MAAS/api/2.0/nodes/%s/volume-group/%s/"193 "/MAAS/api/2.0/nodes/%s/volume-group/%s/"
194 % (node.system_id, volume_group.id),194 % (node.system_id, volume_group.id),
195 get_volume_group_uri(volume_group, node, False),195 get_volume_group_uri(volume_group, node, False),
diff --git a/src/maasserver/clusterrpc/tests/test_driver_parameters.py b/src/maasserver/clusterrpc/tests/test_driver_parameters.py
index 950214d..d9c6507 100644
--- a/src/maasserver/clusterrpc/tests/test_driver_parameters.py
+++ b/src/maasserver/clusterrpc/tests/test_driver_parameters.py
@@ -214,7 +214,7 @@ class TestMakeFormField(MAASServerTestCase):
214 "default": "some default",214 "default": "some default",
215 }215 }
216 django_field = make_form_field(json_field)216 django_field = make_form_field(json_field)
217 self.assertEquals(json_field["default"], django_field.initial)217 self.assertEqual(json_field["default"], django_field.initial)
218218
219219
220class TestMakeSettingField(MAASServerTestCase):220class TestMakeSettingField(MAASServerTestCase):
diff --git a/src/maasserver/clusterrpc/tests/test_pods.py b/src/maasserver/clusterrpc/tests/test_pods.py
index 96e8552..bbdff42 100644
--- a/src/maasserver/clusterrpc/tests/test_pods.py
+++ b/src/maasserver/clusterrpc/tests/test_pods.py
@@ -75,7 +75,7 @@ class TestDiscoverPod(MAASTransactionServerTestCase):
7575
76 self.patch(pods_module, "getAllClients").return_value = clients76 self.patch(pods_module, "getAllClients").return_value = clients
77 discovered = yield discover_pod(factory.make_name("pod"), {})77 discovered = yield discover_pod(factory.make_name("pod"), {})
78 self.assertEquals(78 self.assertEqual(
79 ({rack_id: pod for rack_id in rack_ids}, {}), discovered79 ({rack_id: pod for rack_id in rack_ids}, {}), discovered
80 )80 )
8181
@@ -113,7 +113,7 @@ class TestDiscoverPod(MAASTransactionServerTestCase):
113113
114 self.patch(pods_module, "getAllClients").return_value = clients114 self.patch(pods_module, "getAllClients").return_value = clients
115 discovered = yield discover_pod(pod_type, {})115 discovered = yield discover_pod(pod_type, {})
116 self.assertEquals(116 self.assertEqual(
117 ({valid_rack_id: pod}, {error_rack_id: exception}), discovered117 ({valid_rack_id: pod}, {error_rack_id: exception}), discovered
118 )118 )
119119
diff --git a/src/maasserver/forms/tests/test_clone.py b/src/maasserver/forms/tests/test_clone.py
index 7868ea8..8133280 100644
--- a/src/maasserver/forms/tests/test_clone.py
+++ b/src/maasserver/forms/tests/test_clone.py
@@ -17,7 +17,7 @@ class TestCloneForm(MAASServerTestCase):
17 user = factory.make_admin()17 user = factory.make_admin()
18 form = CloneForm(user, data={})18 form = CloneForm(user, data={})
19 self.assertFalse(form.is_valid())19 self.assertFalse(form.is_valid())
20 self.assertEquals(20 self.assertEqual(
21 {21 {
22 "source": ["This field is required."],22 "source": ["This field is required."],
23 "destinations": ["This field is required."],23 "destinations": ["This field is required."],
@@ -42,7 +42,7 @@ class TestCloneForm(MAASServerTestCase):
42 },42 },
43 )43 )
44 self.assertFalse(form.is_valid())44 self.assertFalse(form.is_valid())
45 self.assertEquals(45 self.assertEqual(
46 {46 {
47 "destinations": [47 "destinations": [
48 "Machine 1 in the array did not validate: "48 "Machine 1 in the array did not validate: "
@@ -76,7 +76,7 @@ class TestCloneForm(MAASServerTestCase):
76 },76 },
77 )77 )
78 self.assertFalse(form.is_valid())78 self.assertFalse(form.is_valid())
79 self.assertEquals(79 self.assertEqual(
80 {80 {
81 "destinations": [81 "destinations": [
82 "Machine 1 in the array did not validate: "82 "Machine 1 in the array did not validate: "
@@ -107,7 +107,7 @@ class TestCloneForm(MAASServerTestCase):
107 },107 },
108 )108 )
109 self.assertFalse(form.is_valid())109 self.assertFalse(form.is_valid())
110 self.assertEquals(110 self.assertEqual(
111 {111 {
112 "destinations": [112 "destinations": [
113 "Machine 1 in the array did not validate: "113 "Machine 1 in the array did not validate: "
@@ -145,7 +145,7 @@ class TestCloneForm(MAASServerTestCase):
145 },145 },
146 )146 )
147 self.assertFalse(form.is_valid())147 self.assertFalse(form.is_valid())
148 self.assertEquals(148 self.assertEqual(
149 {149 {
150 "destinations": [150 "destinations": [
151 "Machine 1 in the array did not validate: "151 "Machine 1 in the array did not validate: "
diff --git a/src/maasserver/forms/tests/test_dhcpsnippet.py b/src/maasserver/forms/tests/test_dhcpsnippet.py
index 2736ee9..2000f04 100644
--- a/src/maasserver/forms/tests/test_dhcpsnippet.py
+++ b/src/maasserver/forms/tests/test_dhcpsnippet.py
@@ -251,7 +251,7 @@ class TestDHCPSnippetForm(MAASServerTestCase):
251 request.user = factory.make_User()251 request.user = factory.make_User()
252 dhcp_snippet = form.save(endpoint, request)252 dhcp_snippet = form.save(endpoint, request)
253 self.assertIsNone(dhcp_snippet.subnet)253 self.assertIsNone(dhcp_snippet.subnet)
254 self.assertEquals(node, dhcp_snippet.node)254 self.assertEqual(node, dhcp_snippet.node)
255255
256 def test_updates_subnet(self):256 def test_updates_subnet(self):
257 dhcp_snippet = factory.make_DHCPSnippet()257 dhcp_snippet = factory.make_DHCPSnippet()
@@ -278,7 +278,7 @@ class TestDHCPSnippetForm(MAASServerTestCase):
278 request.user = factory.make_User()278 request.user = factory.make_User()
279 dhcp_snippet = form.save(endpoint, request)279 dhcp_snippet = form.save(endpoint, request)
280 self.assertIsNone(dhcp_snippet.node)280 self.assertIsNone(dhcp_snippet.node)
281 self.assertEquals(subnet, dhcp_snippet.subnet)281 self.assertEqual(subnet, dhcp_snippet.subnet)
282282
283 def test_cannot_update_both_node_and_subnet(self):283 def test_cannot_update_both_node_and_subnet(self):
284 dhcp_snippet = factory.make_DHCPSnippet()284 dhcp_snippet = factory.make_DHCPSnippet()
@@ -302,7 +302,7 @@ class TestDHCPSnippetForm(MAASServerTestCase):
302 },302 },
303 )303 )
304 self.assertFalse(form.is_valid())304 self.assertFalse(form.is_valid())
305 self.assertEquals(value, reload_object(dhcp_snippet).value.data)305 self.assertEqual(value, reload_object(dhcp_snippet).value.data)
306306
307 def test_update_global_snippet_resets_node(self):307 def test_update_global_snippet_resets_node(self):
308 node = factory.make_Node()308 node = factory.make_Node()
@@ -349,6 +349,6 @@ class TestDHCPSnippetForm(MAASServerTestCase):
349 }349 }
350 )350 )
351 self.assertFalse(form.is_valid())351 self.assertFalse(form.is_valid())
352 self.assertEquals({"value": [dhcpd_error["error"]]}, form.errors)352 self.assertEqual({"value": [dhcpd_error["error"]]}, form.errors)
353 self.assertItemsEqual([], VersionedTextFile.objects.all())353 self.assertItemsEqual([], VersionedTextFile.objects.all())
354 self.assertItemsEqual([], DHCPSnippet.objects.all())354 self.assertItemsEqual([], DHCPSnippet.objects.all())
diff --git a/src/maasserver/forms/tests/test_interface.py b/src/maasserver/forms/tests/test_interface.py
index 9d93879..52364a3 100644
--- a/src/maasserver/forms/tests/test_interface.py
+++ b/src/maasserver/forms/tests/test_interface.py
@@ -441,7 +441,7 @@ class TestPhysicalInterfaceForm(MAASServerTestCase):
441 )441 )
442 self.assertTrue(form.is_valid(), dict(form.errors))442 self.assertTrue(form.is_valid(), dict(form.errors))
443 interface = form.save()443 interface = form.save()
444 self.assertEquals(vlan, interface.vlan)444 self.assertEqual(vlan, interface.vlan)
445445
446 def test_rejects_parents(self):446 def test_rejects_parents(self):
447 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)447 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
@@ -1077,7 +1077,7 @@ class BondInterfaceFormTest(MAASServerTestCase):
1077 data={"name": interface_name, "parents": [parent1.id, parent2.id]},1077 data={"name": interface_name, "parents": [parent1.id, parent2.id]},
1078 )1078 )
1079 self.assertFalse(form.is_valid(), dict(form.errors))1079 self.assertFalse(form.is_valid(), dict(form.errors))
1080 self.assertEquals(1080 self.assertEqual(
1081 "All parents must belong to the same VLAN.",1081 "All parents must belong to the same VLAN.",
1082 form.errors["parents"][0],1082 form.errors["parents"][0],
1083 )1083 )
diff --git a/src/maasserver/forms/tests/test_machinewithmacaddresses.py b/src/maasserver/forms/tests/test_machinewithmacaddresses.py
index fe96353..ebc8a16 100644
--- a/src/maasserver/forms/tests/test_machinewithmacaddresses.py
+++ b/src/maasserver/forms/tests/test_machinewithmacaddresses.py
@@ -189,7 +189,7 @@ class MachineWithMACAddressesFormTest(MAASServerTestCase):
189 node = form.save()189 node = form.save()
190190
191 self.assertIsNotNone(node.id) # The node is persisted.191 self.assertIsNotNone(node.id) # The node is persisted.
192 self.assertEquals(NODE_STATUS.NEW, node.status)192 self.assertEqual(NODE_STATUS.NEW, node.status)
193 self.assertItemsEqual(193 self.assertItemsEqual(
194 macs, [nic.mac_address for nic in node.interface_set.all()]194 macs, [nic.mac_address for nic in node.interface_set.all()]
195 )195 )
@@ -226,5 +226,5 @@ class MachineWithMACAddressesFormTest(MAASServerTestCase):
226 )226 )
227 self.assertTrue(form.is_valid(), form.errors)227 self.assertTrue(form.is_valid(), form.errors)
228 machine = form.save()228 machine = form.save()
229 self.assertEquals(NODE_STATUS.COMMISSIONING, machine.status)229 self.assertEqual(NODE_STATUS.COMMISSIONING, machine.status)
230 self.assertIsNotNone(machine.current_commissioning_script_set)230 self.assertIsNotNone(machine.current_commissioning_script_set)
diff --git a/src/maasserver/forms/tests/test_packagerepository.py b/src/maasserver/forms/tests/test_packagerepository.py
index 1898d89..f96d36b 100644
--- a/src/maasserver/forms/tests/test_packagerepository.py
+++ b/src/maasserver/forms/tests/test_packagerepository.py
@@ -174,7 +174,7 @@ class TestPackageRepositoryForm(MAASServerTestCase):
174 data={"url": factory.make_url(scheme="fake")},174 data={"url": factory.make_url(scheme="fake")},
175 )175 )
176 self.assertFalse(form.is_valid())176 self.assertFalse(form.is_valid())
177 self.assertEquals(url, reload_object(package_repository).url)177 self.assertEqual(url, reload_object(package_repository).url)
178178
179 def test_creates_package_repository_defaults_main_arches(self):179 def test_creates_package_repository_defaults_main_arches(self):
180 repo = factory.make_PackageRepository(arches=[])180 repo = factory.make_PackageRepository(arches=[])
diff --git a/src/maasserver/forms/tests/test_parameters.py b/src/maasserver/forms/tests/test_parameters.py
index ac3eed3..4b41ce3 100644
--- a/src/maasserver/forms/tests/test_parameters.py
+++ b/src/maasserver/forms/tests/test_parameters.py
@@ -324,7 +324,7 @@ class TestParametersForm(MAASServerTestCase):
324 data={"runtime": value}, script=script, node=factory.make_Node()324 data={"runtime": value}, script=script, node=factory.make_Node()
325 )325 )
326 self.assertTrue(form.is_valid(), form.errors)326 self.assertTrue(form.is_valid(), form.errors)
327 self.assertEquals(1, len(form.cleaned_data["input"]))327 self.assertEqual(1, len(form.cleaned_data["input"]))
328 self.assertDictEqual(328 self.assertDictEqual(
329 {"runtime": {"type": "runtime", "value": value}},329 {"runtime": {"type": "runtime", "value": value}},
330 form.cleaned_data["input"][0],330 form.cleaned_data["input"][0],
@@ -336,7 +336,7 @@ class TestParametersForm(MAASServerTestCase):
336 )336 )
337 form = ParametersForm(data={}, script=script, node=factory.make_Node())337 form = ParametersForm(data={}, script=script, node=factory.make_Node())
338 self.assertTrue(form.is_valid(), form.errors)338 self.assertTrue(form.is_valid(), form.errors)
339 self.assertEquals(1, len(form.cleaned_data["input"]))339 self.assertEqual(1, len(form.cleaned_data["input"]))
340 self.assertDictEqual(340 self.assertDictEqual(
341 {"runtime": {"type": "runtime", "value": script.timeout.seconds}},341 {"runtime": {"type": "runtime", "value": script.timeout.seconds}},
342 form.cleaned_data["input"][0],342 form.cleaned_data["input"][0],
@@ -423,7 +423,7 @@ class TestParametersForm(MAASServerTestCase):
423 node=factory.make_Node(with_boot_disk=False),423 node=factory.make_Node(with_boot_disk=False),
424 )424 )
425 self.assertTrue(form.is_valid(), form.errors)425 self.assertTrue(form.is_valid(), form.errors)
426 self.assertEquals(1, len(form.cleaned_data["input"]))426 self.assertEqual(1, len(form.cleaned_data["input"]))
427 self.assertDictEqual(427 self.assertDictEqual(
428 {428 {
429 "runtime": {429 "runtime": {
@@ -450,12 +450,12 @@ class TestParametersForm(MAASServerTestCase):
450 )450 )
451 self.assertTrue(form.is_valid(), form.errors)451 self.assertTrue(form.is_valid(), form.errors)
452 input = form.cleaned_data["input"]452 input = form.cleaned_data["input"]
453 self.assertEquals(node.physicalblockdevice_set.count(), len(input))453 self.assertEqual(node.physicalblockdevice_set.count(), len(input))
454 for bd in node.physicalblockdevice_set:454 for bd in node.physicalblockdevice_set:
455 for i in input:455 for i in input:
456 if bd.name == i["storage"]["value"]["name"]:456 if bd.name == i["storage"]["value"]["name"]:
457 break457 break
458 self.assertEquals(script.timeout.seconds, i["runtime"]["value"])458 self.assertEqual(script.timeout.seconds, i["runtime"]["value"])
459 self.assertDictEqual(459 self.assertDictEqual(
460 {460 {
461 "name": bd.name,461 "name": bd.name,
@@ -485,8 +485,8 @@ class TestParametersForm(MAASServerTestCase):
485 )485 )
486 self.assertTrue(form.is_valid(), form.errors)486 self.assertTrue(form.is_valid(), form.errors)
487 input = form.cleaned_data["input"]487 input = form.cleaned_data["input"]
488 self.assertEquals(1, len(input))488 self.assertEqual(1, len(input))
489 self.assertEquals(script.timeout.seconds, input[0]["runtime"]["value"])489 self.assertEqual(script.timeout.seconds, input[0]["runtime"]["value"])
490 self.assertDictEqual(490 self.assertDictEqual(
491 {491 {
492 "name": bd.name,492 "name": bd.name,
@@ -544,12 +544,12 @@ class TestParametersForm(MAASServerTestCase):
544 )544 )
545 self.assertTrue(form.is_valid(), form.errors)545 self.assertTrue(form.is_valid(), form.errors)
546 input = form.cleaned_data["input"]546 input = form.cleaned_data["input"]
547 self.assertEquals(len(selected_scripts), len(input))547 self.assertEqual(len(selected_scripts), len(input))
548 for bd in selected_scripts.keys():548 for bd in selected_scripts.keys():
549 for i in input:549 for i in input:
550 if bd.name == i["storage"]["value"]["name"]:550 if bd.name == i["storage"]["value"]["name"]:
551 break551 break
552 self.assertEquals(script.timeout.seconds, i["runtime"]["value"])552 self.assertEqual(script.timeout.seconds, i["runtime"]["value"])
553 self.assertDictEqual(553 self.assertDictEqual(
554 {554 {
555 "name": bd.name,555 "name": bd.name,
@@ -609,7 +609,7 @@ class TestParametersForm(MAASServerTestCase):
609 data={}, script=script, node=factory.make_Node(interface=False)609 data={}, script=script, node=factory.make_Node(interface=False)
610 )610 )
611 self.assertTrue(form.is_valid(), form.errors)611 self.assertTrue(form.is_valid(), form.errors)
612 self.assertEquals(1, len(form.cleaned_data["input"]))612 self.assertEqual(1, len(form.cleaned_data["input"]))
613 self.assertDictEqual(613 self.assertDictEqual(
614 {"interface": {"type": "interface", "value": "all"}},614 {"interface": {"type": "interface", "value": "all"}},
615 form.cleaned_data["input"][0],615 form.cleaned_data["input"][0],
@@ -624,7 +624,7 @@ class TestParametersForm(MAASServerTestCase):
624 )624 )
625 form = ParametersForm(data={}, script=script, node=node)625 form = ParametersForm(data={}, script=script, node=node)
626 self.assertTrue(form.is_valid(), form.errors)626 self.assertTrue(form.is_valid(), form.errors)
627 self.assertEquals(1, len(form.cleaned_data["input"]))627 self.assertEqual(1, len(form.cleaned_data["input"]))
628 self.assertDictEqual(628 self.assertDictEqual(
629 {629 {
630 "name": node.boot_interface.name,630 "name": node.boot_interface.name,
@@ -657,7 +657,7 @@ class TestParametersForm(MAASServerTestCase):
657 )657 )
658 self.assertTrue(form.is_valid(), form.errors)658 self.assertTrue(form.is_valid(), form.errors)
659 input = form.cleaned_data["input"]659 input = form.cleaned_data["input"]
660 self.assertEquals(len(usable_interfaces), len(input))660 self.assertEqual(len(usable_interfaces), len(input))
661 for interface in usable_interfaces:661 for interface in usable_interfaces:
662 for i in input:662 for i in input:
663 if i["interface"]["value"]["interface"] == interface:663 if i["interface"]["value"]["interface"] == interface:
@@ -690,7 +690,7 @@ class TestParametersForm(MAASServerTestCase):
690 )690 )
691 self.assertTrue(form.is_valid(), form.errors)691 self.assertTrue(form.is_valid(), form.errors)
692 input = form.cleaned_data["input"]692 input = form.cleaned_data["input"]
693 self.assertEquals(1, len(input))693 self.assertEqual(1, len(input))
694 self.assertDictEqual(694 self.assertDictEqual(
695 {695 {
696 "name": bond.name,696 "name": bond.name,
@@ -720,7 +720,7 @@ class TestParametersForm(MAASServerTestCase):
720 )720 )
721 self.assertTrue(form.is_valid(), form.errors)721 self.assertTrue(form.is_valid(), form.errors)
722 input = form.cleaned_data["input"]722 input = form.cleaned_data["input"]
723 self.assertEquals(1, len(input))723 self.assertEqual(1, len(input))
724 self.assertDictEqual(724 self.assertDictEqual(
725 {725 {
726 "name": interface.name,726 "name": interface.name,
@@ -808,7 +808,7 @@ class TestParametersForm(MAASServerTestCase):
808 )808 )
809 self.assertTrue(form.is_valid(), form.errors)809 self.assertTrue(form.is_valid(), form.errors)
810 input = form.cleaned_data["input"]810 input = form.cleaned_data["input"]
811 self.assertEquals(len(selected_scripts), len(input))811 self.assertEqual(len(selected_scripts), len(input))
812 for nic in selected_scripts.keys():812 for nic in selected_scripts.keys():
813 for i in input:813 for i in input:
814 if (814 if (
diff --git a/src/maasserver/forms/tests/test_pods.py b/src/maasserver/forms/tests/test_pods.py
index fe04080..d0cf4f7 100644
--- a/src/maasserver/forms/tests/test_pods.py
+++ b/src/maasserver/forms/tests/test_pods.py
@@ -432,8 +432,8 @@ class TestPodForm(MAASTransactionServerTestCase):
432 form = PodForm(data=pod_info, request=self.request)432 form = PodForm(data=pod_info, request=self.request)
433 self.assertTrue(form.is_valid(), form._errors)433 self.assertTrue(form.is_valid(), form._errors)
434 pod = form.save()434 pod = form.save()
435 self.assertEquals(bmc.id, pod.id)435 self.assertEqual(bmc.id, pod.id)
436 self.assertEquals(BMC_TYPE.POD, reload_object(bmc).bmc_type)436 self.assertEqual(BMC_TYPE.POD, reload_object(bmc).bmc_type)
437 self.assertThat(mock_post_commit_do, MockCalledOnce())437 self.assertThat(mock_post_commit_do, MockCalledOnce())
438438
439 def test_updates_existing_pod_minimal(self):439 def test_updates_existing_pod_minimal(self):
@@ -797,7 +797,7 @@ class TestPodForm(MAASTransactionServerTestCase):
797 form = PodForm(data=pod_info)797 form = PodForm(data=pod_info)
798 self.assertTrue(form.is_valid(), form._errors)798 self.assertTrue(form.is_valid(), form._errors)
799 error = self.assertRaises(PodProblem, form.save)799 error = self.assertRaises(PodProblem, form.save)
800 self.assertEquals(800 self.assertEqual(
801 "Unable to start the pod discovery process. "801 "Unable to start the pod discovery process. "
802 "No rack controllers connected.",802 "No rack controllers connected.",
803 str(error),803 str(error),
@@ -816,7 +816,7 @@ class TestPodForm(MAASTransactionServerTestCase):
816816
817 def validate_error(failure):817 def validate_error(failure):
818 self.assertIsInstance(failure.value, PodProblem)818 self.assertIsInstance(failure.value, PodProblem)
819 self.assertEquals(819 self.assertEqual(
820 "Unable to start the pod discovery process. "820 "Unable to start the pod discovery process. "
821 "No rack controllers connected.",821 "No rack controllers connected.",
822 str(failure.value),822 str(failure.value),
@@ -837,7 +837,7 @@ class TestPodForm(MAASTransactionServerTestCase):
837 form = PodForm(data=pod_info)837 form = PodForm(data=pod_info)
838 self.assertTrue(form.is_valid(), form._errors)838 self.assertTrue(form.is_valid(), form._errors)
839 error = self.assertRaises(PodProblem, form.save)839 error = self.assertRaises(PodProblem, form.save)
840 self.assertEquals(str(exc), str(error))840 self.assertEqual(str(exc), str(error))
841841
842 @wait_for_reactor842 @wait_for_reactor
843 @inlineCallbacks843 @inlineCallbacks
@@ -854,7 +854,7 @@ class TestPodForm(MAASTransactionServerTestCase):
854854
855 def validate_error(failure):855 def validate_error(failure):
856 self.assertIsInstance(failure.value, PodProblem)856 self.assertIsInstance(failure.value, PodProblem)
857 self.assertEquals(str(exc), str(failure.value))857 self.assertEqual(str(exc), str(failure.value))
858858
859 d = form.save()859 d = form.save()
860 d.addErrback(validate_error)860 d.addErrback(validate_error)
@@ -2386,7 +2386,7 @@ class TestComposeMachineForm(MAASTransactionServerTestCase):
2386 form = ComposeMachineForm(data={}, request=request, pod=pod)2386 form = ComposeMachineForm(data={}, request=request, pod=pod)
2387 self.assertTrue(form.is_valid())2387 self.assertTrue(form.is_valid())
2388 error = self.assertRaises(PodProblem, form.compose)2388 error = self.assertRaises(PodProblem, form.compose)
2389 self.assertEquals(2389 self.assertEqual(
2390 "Unable to compose a machine because '%s' driver timed out "2390 "Unable to compose a machine because '%s' driver timed out "
2391 "after 120 seconds." % pod.power_type,2391 "after 120 seconds." % pod.power_type,
2392 str(error),2392 str(error),
diff --git a/src/maasserver/forms/tests/test_script.py b/src/maasserver/forms/tests/test_script.py
index 13df30f..f421660 100644
--- a/src/maasserver/forms/tests/test_script.py
+++ b/src/maasserver/forms/tests/test_script.py
@@ -51,19 +51,19 @@ class TestScriptForm(MAASServerTestCase):
51 self.assertTrue(form.is_valid(), form.errors)51 self.assertTrue(form.is_valid(), form.errors)
52 script = form.save()52 script = form.save()
5353
54 self.assertEquals(name, script.name)54 self.assertEqual(name, script.name)
55 self.assertEquals("", script.title)55 self.assertEqual("", script.title)
56 self.assertEquals("", script.description)56 self.assertEqual("", script.description)
57 self.assertEquals(1, len(script.tags))57 self.assertEqual(1, len(script.tags))
58 self.assertEquals(SCRIPT_TYPE.TESTING, script.script_type)58 self.assertEqual(SCRIPT_TYPE.TESTING, script.script_type)
59 self.assertEquals(HARDWARE_TYPE.NODE, script.hardware_type)59 self.assertEqual(HARDWARE_TYPE.NODE, script.hardware_type)
60 self.assertEquals(SCRIPT_PARALLEL.DISABLED, script.parallel)60 self.assertEqual(SCRIPT_PARALLEL.DISABLED, script.parallel)
61 self.assertDictEqual({}, script.packages)61 self.assertDictEqual({}, script.packages)
62 self.assertDictEqual({}, script.results)62 self.assertDictEqual({}, script.results)
63 self.assertDictEqual({}, script.parameters)63 self.assertDictEqual({}, script.parameters)
64 self.assertEquals(timedelta(0), script.timeout)64 self.assertEqual(timedelta(0), script.timeout)
65 self.assertFalse(script.destructive)65 self.assertFalse(script.destructive)
66 self.assertEquals(script_content, script.script.data)66 self.assertEqual(script_content, script.script.data)
67 self.assertFalse(script.default)67 self.assertFalse(script.default)
68 self.assertItemsEqual([], script.for_hardware)68 self.assertItemsEqual([], script.for_hardware)
69 self.assertFalse(script.may_reboot)69 self.assertFalse(script.may_reboot)
@@ -123,24 +123,24 @@ class TestScriptForm(MAASServerTestCase):
123 self.assertTrue(form.is_valid(), form.errors)123 self.assertTrue(form.is_valid(), form.errors)
124 script = form.save()124 script = form.save()
125125
126 self.assertEquals(name, script.name)126 self.assertEqual(name, script.name)
127 self.assertEquals(title, script.title)127 self.assertEqual(title, script.title)
128 self.assertEquals(description, script.description)128 self.assertEqual(description, script.description)
129 self.assertThat(script.tags, ContainsAll(tags))129 self.assertThat(script.tags, ContainsAll(tags))
130 self.assertEquals(script_type, script.script_type)130 self.assertEqual(script_type, script.script_type)
131 self.assertEquals(hardware_type, script.hardware_type)131 self.assertEqual(hardware_type, script.hardware_type)
132 self.assertEquals(parallel, script.parallel)132 self.assertEqual(parallel, script.parallel)
133 self.assertDictEqual(packages, script.packages)133 self.assertDictEqual(packages, script.packages)
134 self.assertDictEqual({}, script.results)134 self.assertDictEqual({}, script.results)
135 self.assertDictEqual({}, script.parameters)135 self.assertDictEqual({}, script.parameters)
136 self.assertDictEqual(packages, script.packages)136 self.assertDictEqual(packages, script.packages)
137 self.assertEquals(timedelta(0, timeout), script.timeout)137 self.assertEqual(timedelta(0, timeout), script.timeout)
138 self.assertEquals(destructive, script.destructive)138 self.assertEqual(destructive, script.destructive)
139 self.assertEquals(script_content, script.script.data)139 self.assertEqual(script_content, script.script.data)
140 self.assertEquals(comment, script.script.comment)140 self.assertEqual(comment, script.script.comment)
141 self.assertEquals(may_reboot, script.may_reboot)141 self.assertEqual(may_reboot, script.may_reboot)
142 self.assertItemsEqual(for_hardware, script.for_hardware)142 self.assertItemsEqual(for_hardware, script.for_hardware)
143 self.assertEquals(recommission, script.recommission)143 self.assertEqual(recommission, script.recommission)
144 self.assertFalse(script.default)144 self.assertFalse(script.default)
145145
146 def test_create_setting_default_has_no_effect(self):146 def test_create_setting_default_has_no_effect(self):
@@ -214,25 +214,25 @@ class TestScriptForm(MAASServerTestCase):
214 self.assertTrue(form.is_valid(), form.errors)214 self.assertTrue(form.is_valid(), form.errors)
215 script = form.save()215 script = form.save()
216216
217 self.assertEquals(name, script.name)217 self.assertEqual(name, script.name)
218 self.assertEquals(title, script.title)218 self.assertEqual(title, script.title)
219 self.assertEquals(description, script.description)219 self.assertEqual(description, script.description)
220 self.assertThat(script.tags, ContainsAll(tags))220 self.assertThat(script.tags, ContainsAll(tags))
221 self.assertEquals(script_type, script.script_type)221 self.assertEqual(script_type, script.script_type)
222 self.assertEquals(hardware_type, script.hardware_type)222 self.assertEqual(hardware_type, script.hardware_type)
223 self.assertEquals(parallel, script.parallel)223 self.assertEqual(parallel, script.parallel)
224 self.assertDictEqual({}, script.results)224 self.assertDictEqual({}, script.results)
225 self.assertDictEqual({}, script.parameters)225 self.assertDictEqual({}, script.parameters)
226 self.assertDictEqual(packages, script.packages)226 self.assertDictEqual(packages, script.packages)
227 self.assertEquals(timedelta(0, timeout), script.timeout)227 self.assertEqual(timedelta(0, timeout), script.timeout)
228 self.assertEquals(destructive, script.destructive)228 self.assertEqual(destructive, script.destructive)
229 self.assertEquals(script_content, script.script.data)229 self.assertEqual(script_content, script.script.data)
230 self.assertEquals(comment, script.script.comment)230 self.assertEqual(comment, script.script.comment)
231 self.assertEquals(231 self.assertEqual(
232 orig_script_content, script.script.previous_version.data232 orig_script_content, script.script.previous_version.data
233 )233 )
234 self.assertEquals(None, script.script.previous_version.comment)234 self.assertEqual(None, script.script.previous_version.comment)
235 self.assertEquals(235 self.assertEqual(
236 apply_configured_networking, script.apply_configured_networking236 apply_configured_networking, script.apply_configured_networking
237 )237 )
238 self.assertFalse(script.default)238 self.assertFalse(script.default)
@@ -276,7 +276,7 @@ class TestScriptForm(MAASServerTestCase):
276 value = factory.make_string()276 value = factory.make_string()
277 form = ScriptForm(data={name: value}, instance=script)277 form = ScriptForm(data={name: value}, instance=script)
278 self.assertFalse(form.is_valid())278 self.assertFalse(form.is_valid())
279 self.assertEquals(1, VersionedTextFile.objects.all().count())279 self.assertEqual(1, VersionedTextFile.objects.all().count())
280280
281 def test_update_edit_default_allows_update_of_all_fields(self):281 def test_update_edit_default_allows_update_of_all_fields(self):
282 script = factory.make_Script(default=True)282 script = factory.make_Script(default=True)
@@ -321,7 +321,7 @@ class TestScriptForm(MAASServerTestCase):
321 script = form.save()321 script = form.save()
322322
323 self.assertThat(script.tags, ContainsAll(tags))323 self.assertThat(script.tags, ContainsAll(tags))
324 self.assertEquals(timedelta(0, timeout), script.timeout)324 self.assertEqual(timedelta(0, timeout), script.timeout)
325325
326 def test_update_requires_script_with_comment(self):326 def test_update_requires_script_with_comment(self):
327 script = factory.make_Script()327 script = factory.make_Script()
@@ -362,23 +362,23 @@ class TestScriptForm(MAASServerTestCase):
362 self.assertTrue(form.is_valid(), form.errors)362 self.assertTrue(form.is_valid(), form.errors)
363 script = form.save()363 script = form.save()
364364
365 self.assertEquals(name, script.name)365 self.assertEqual(name, script.name)
366 self.assertEquals(title, script.title)366 self.assertEqual(title, script.title)
367 self.assertEquals(description, script.description)367 self.assertEqual(description, script.description)
368 self.assertEquals(tags, script.tags)368 self.assertEqual(tags, script.tags)
369 self.assertEquals(script_type, script.script_type)369 self.assertEqual(script_type, script.script_type)
370 self.assertEquals(hardware_type, script.hardware_type)370 self.assertEqual(hardware_type, script.hardware_type)
371 self.assertDictEqual(packages, script.packages)371 self.assertDictEqual(packages, script.packages)
372 self.assertEquals(parallel, script.parallel)372 self.assertEqual(parallel, script.parallel)
373 self.assertDictEqual(results, script.results)373 self.assertDictEqual(results, script.results)
374 self.assertDictEqual(parameters, script.parameters)374 self.assertDictEqual(parameters, script.parameters)
375 self.assertEquals(timeout, script.timeout)375 self.assertEqual(timeout, script.timeout)
376 self.assertEquals(destructive, script.destructive)376 self.assertEqual(destructive, script.destructive)
377 self.assertFalse(script.default)377 self.assertFalse(script.default)
378 self.assertEquals(script_content, script.script.data)378 self.assertEqual(script_content, script.script.data)
379 self.assertEquals(may_reboot, script.may_reboot)379 self.assertEqual(may_reboot, script.may_reboot)
380 self.assertItemsEqual(for_hardware, script.for_hardware)380 self.assertItemsEqual(for_hardware, script.for_hardware)
381 self.assertEquals(recommission, script.recommission)381 self.assertEqual(recommission, script.recommission)
382382
383 def test_yaml_doesnt_update_tags(self):383 def test_yaml_doesnt_update_tags(self):
384 script = factory.make_Script()384 script = factory.make_Script()
@@ -410,7 +410,7 @@ class TestScriptForm(MAASServerTestCase):
410 )410 )
411 self.assertTrue(form.is_valid(), form.errors)411 self.assertTrue(form.is_valid(), form.errors)
412 script = form.save()412 script = form.save()
413 self.assertEquals(orig_timeout, script.timeout)413 self.assertEqual(orig_timeout, script.timeout)
414414
415 def test_can_use_script_type_name(self):415 def test_can_use_script_type_name(self):
416 script_type = factory.pick_choice(SCRIPT_TYPE_CHOICES)416 script_type = factory.pick_choice(SCRIPT_TYPE_CHOICES)
@@ -424,7 +424,7 @@ class TestScriptForm(MAASServerTestCase):
424 self.assertTrue(form.is_valid(), form.errors)424 self.assertTrue(form.is_valid(), form.errors)
425 script = form.save()425 script = form.save()
426426
427 self.assertEquals(script_type, script.script_type)427 self.assertEqual(script_type, script.script_type)
428428
429 def test_errors_on_invalid_script_type(self):429 def test_errors_on_invalid_script_type(self):
430 form = ScriptForm(430 form = ScriptForm(
@@ -453,7 +453,7 @@ class TestScriptForm(MAASServerTestCase):
453 self.assertTrue(form.is_valid(), form.errors)453 self.assertTrue(form.is_valid(), form.errors)
454 script = form.save()454 script = form.save()
455455
456 self.assertEquals(hardware_type, script.hardware_type)456 self.assertEqual(hardware_type, script.hardware_type)
457457
458 def test_errors_on_invalid_hardware_type(self):458 def test_errors_on_invalid_hardware_type(self):
459 form = ScriptForm(459 form = ScriptForm(
@@ -486,7 +486,7 @@ class TestScriptForm(MAASServerTestCase):
486 self.assertTrue(form.is_valid(), form.errors)486 self.assertTrue(form.is_valid(), form.errors)
487 script = form.save()487 script = form.save()
488488
489 self.assertEquals(script_parallel, script.parallel)489 self.assertEqual(script_parallel, script.parallel)
490490
491 def test_errors_on_invalid_parallel_name(self):491 def test_errors_on_invalid_parallel_name(self):
492 form = ScriptForm(492 form = ScriptForm(
@@ -598,7 +598,7 @@ class TestScriptForm(MAASServerTestCase):
598 )598 )
599 self.assertTrue(form.is_valid(), form.errors)599 self.assertTrue(form.is_valid(), form.errors)
600 script = form.save()600 script = form.save()
601 self.assertEquals(script_type, script.script_type)601 self.assertEqual(script_type, script.script_type)
602602
603 def test_loads_yaml_embedded_attributes(self):603 def test_loads_yaml_embedded_attributes(self):
604 embedded_yaml = {604 embedded_yaml = {
@@ -634,33 +634,33 @@ class TestScriptForm(MAASServerTestCase):
634 form = ScriptForm(data={"script": script_content})634 form = ScriptForm(data={"script": script_content})
635 self.assertTrue(form.is_valid(), form.errors)635 self.assertTrue(form.is_valid(), form.errors)
636 script = form.save()636 script = form.save()
637 self.assertEquals(embedded_yaml["name"], script.name)637 self.assertEqual(embedded_yaml["name"], script.name)
638 self.assertEquals(embedded_yaml["title"], script.title)638 self.assertEqual(embedded_yaml["title"], script.title)
639 self.assertEquals(embedded_yaml["description"], script.description)639 self.assertEqual(embedded_yaml["description"], script.description)
640 self.assertThat(script.tags, ContainsAll(embedded_yaml["tags"]))640 self.assertThat(script.tags, ContainsAll(embedded_yaml["tags"]))
641 self.assertEquals(embedded_yaml["script_type"], script.script_type)641 self.assertEqual(embedded_yaml["script_type"], script.script_type)
642 self.assertEquals(embedded_yaml["hardware_type"], script.hardware_type)642 self.assertEqual(embedded_yaml["hardware_type"], script.hardware_type)
643 self.assertEquals(embedded_yaml["parallel"], script.parallel)643 self.assertEqual(embedded_yaml["parallel"], script.parallel)
644 self.assertItemsEqual(embedded_yaml["results"], script.results)644 self.assertItemsEqual(embedded_yaml["results"], script.results)
645 self.assertItemsEqual(embedded_yaml["parameters"], script.parameters)645 self.assertItemsEqual(embedded_yaml["parameters"], script.parameters)
646 self.assertDictEqual(embedded_yaml["packages"], script.packages)646 self.assertDictEqual(embedded_yaml["packages"], script.packages)
647 self.assertEquals(647 self.assertEqual(
648 timedelta(0, embedded_yaml["timeout"]), script.timeout648 timedelta(0, embedded_yaml["timeout"]), script.timeout
649 )649 )
650 self.assertEquals(embedded_yaml["destructive"], script.destructive)650 self.assertEqual(embedded_yaml["destructive"], script.destructive)
651 self.assertEquals(embedded_yaml["may_reboot"], script.may_reboot)651 self.assertEqual(embedded_yaml["may_reboot"], script.may_reboot)
652 if embedded_yaml["script_type"] == SCRIPT_TYPE.COMMISSIONING:652 if embedded_yaml["script_type"] == SCRIPT_TYPE.COMMISSIONING:
653 self.assertItemsEqual(653 self.assertItemsEqual(
654 embedded_yaml["for_hardware"], script.for_hardware654 embedded_yaml["for_hardware"], script.for_hardware
655 )655 )
656 self.assertEquals(656 self.assertEqual(
657 embedded_yaml["recommission"], script.recommission657 embedded_yaml["recommission"], script.recommission
658 )658 )
659 else:659 else:
660 self.assertItemsEqual([], script.for_hardware)660 self.assertItemsEqual([], script.for_hardware)
661 self.assertFalse(script.recommission)661 self.assertFalse(script.recommission)
662 self.assertFalse(script.default)662 self.assertFalse(script.default)
663 self.assertEquals(script_content, script.script.data)663 self.assertEqual(script_content, script.script.data)
664664
665 def test_only_loads_when_script_updated(self):665 def test_only_loads_when_script_updated(self):
666 script = factory.make_Script(666 script = factory.make_Script(
@@ -672,7 +672,7 @@ class TestScriptForm(MAASServerTestCase):
672 form = ScriptForm(instance=script, data={"name": name})672 form = ScriptForm(instance=script, data={"name": name})
673 self.assertTrue(form.is_valid(), form.errors)673 self.assertTrue(form.is_valid(), form.errors)
674 script = form.save()674 script = form.save()
675 self.assertEquals(name, script.name)675 self.assertEqual(name, script.name)
676676
677 def test_user_option_unable_to_over_yaml_value(self):677 def test_user_option_unable_to_over_yaml_value(self):
678 name = factory.make_name("name")678 name = factory.make_name("name")
@@ -733,7 +733,7 @@ class TestScriptForm(MAASServerTestCase):
733 )733 )
734 self.assertTrue(form.is_valid(), form.errors)734 self.assertTrue(form.is_valid(), form.errors)
735 script = form.save()735 script = form.save()
736 self.assertEquals(name, script.name)736 self.assertEqual(name, script.name)
737737
738 def tests_yaml_tags_can_be_string(self):738 def tests_yaml_tags_can_be_string(self):
739 tags = [factory.make_name("tag") for _ in range(3)]739 tags = [factory.make_name("tag") for _ in range(3)]
@@ -1149,8 +1149,8 @@ class TestCommissioningScriptForm(MAASServerTestCase):
1149 self.assertTrue(form.is_valid(), form._errors)1149 self.assertTrue(form.is_valid(), form._errors)
1150 form.save(request)1150 form.save(request)
1151 new_script = Script.objects.get(name=name)1151 new_script = Script.objects.get(name=name)
1152 self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)1152 self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)
1153 self.assertEquals(content, new_script.script.data)1153 self.assertEqual(content, new_script.script.data)
11541154
1155 def test_creates_commissioning_script_from_filename(self):1155 def test_creates_commissioning_script_from_filename(self):
1156 request = HttpRequest()1156 request = HttpRequest()
@@ -1164,8 +1164,8 @@ class TestCommissioningScriptForm(MAASServerTestCase):
1164 self.assertTrue(form.is_valid(), form._errors)1164 self.assertTrue(form.is_valid(), form._errors)
1165 form.save(request)1165 form.save(request)
1166 new_script = Script.objects.get(name=name)1166 new_script = Script.objects.get(name=name)
1167 self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)1167 self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)
1168 self.assertEquals(content, new_script.script.data)1168 self.assertEqual(content, new_script.script.data)
11691169
1170 def test_updates_commissioning_script(self):1170 def test_updates_commissioning_script(self):
1171 request = HttpRequest()1171 request = HttpRequest()
@@ -1179,8 +1179,8 @@ class TestCommissioningScriptForm(MAASServerTestCase):
1179 self.assertTrue(form.is_valid(), form._errors)1179 self.assertTrue(form.is_valid(), form._errors)
1180 form.save(request)1180 form.save(request)
1181 new_script = Script.objects.get(name=script.name)1181 new_script = Script.objects.get(name=script.name)
1182 self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)1182 self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type)
1183 self.assertEquals(content, new_script.script.data)1183 self.assertEqual(content, new_script.script.data)
11841184
1185 def test_creates_audit_event(self):1185 def test_creates_audit_event(self):
1186 request = HttpRequest()1186 request = HttpRequest()
@@ -1227,8 +1227,8 @@ class TestTestingScriptForm(MAASServerTestCase):
1227 self.assertTrue(form.is_valid(), form._errors)1227 self.assertTrue(form.is_valid(), form._errors)
1228 form.save(request)1228 form.save(request)
1229 new_script = Script.objects.get(name=name)1229 new_script = Script.objects.get(name=name)
1230 self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type)1230 self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type)
1231 self.assertEquals(content, new_script.script.data)1231 self.assertEqual(content, new_script.script.data)
12321232
1233 def test_creates_test_script_from_filename(self):1233 def test_creates_test_script_from_filename(self):
1234 request = HttpRequest()1234 request = HttpRequest()
@@ -1242,8 +1242,8 @@ class TestTestingScriptForm(MAASServerTestCase):
1242 self.assertTrue(form.is_valid(), form._errors)1242 self.assertTrue(form.is_valid(), form._errors)
1243 form.save(request)1243 form.save(request)
1244 new_script = Script.objects.get(name=name)1244 new_script = Script.objects.get(name=name)
1245 self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type)1245 self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type)
1246 self.assertEquals(content, new_script.script.data)1246 self.assertEqual(content, new_script.script.data)
12471247
1248 def test_updates_test_script(self):1248 def test_updates_test_script(self):
1249 request = HttpRequest()1249 request = HttpRequest()
@@ -1257,8 +1257,8 @@ class TestTestingScriptForm(MAASServerTestCase):
1257 self.assertTrue(form.is_valid(), form._errors)1257 self.assertTrue(form.is_valid(), form._errors)
1258 form.save(request)1258 form.save(request)
1259 new_script = Script.objects.get(name=script.name)1259 new_script = Script.objects.get(name=script.name)
1260 self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type)1260 self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type)
1261 self.assertEquals(content, new_script.script.data)1261 self.assertEqual(content, new_script.script.data)
12621262
1263 def test_creates_audit_event(self):1263 def test_creates_audit_event(self):
1264 request = HttpRequest()1264 request = HttpRequest()
diff --git a/src/maasserver/forms/tests/test_sslkey.py b/src/maasserver/forms/tests/test_sslkey.py
index 63113a2..f13a8ed 100644
--- a/src/maasserver/forms/tests/test_sslkey.py
+++ b/src/maasserver/forms/tests/test_sslkey.py
@@ -27,4 +27,4 @@ class TestSSLKeyForm(MAASServerTestCase):
27 form.save(factory.pick_choice(ENDPOINT_CHOICES), request)27 form.save(factory.pick_choice(ENDPOINT_CHOICES), request)
28 event = Event.objects.get(type__level=AUDIT)28 event = Event.objects.get(type__level=AUDIT)
29 self.assertIsNotNone(event)29 self.assertIsNotNone(event)
30 self.assertEquals(event.description, "Created SSL key.")30 self.assertEqual(event.description, "Created SSL key.")
diff --git a/src/maasserver/forms/tests/test_subnet.py b/src/maasserver/forms/tests/test_subnet.py
index e1845a4..0d5228e 100644
--- a/src/maasserver/forms/tests/test_subnet.py
+++ b/src/maasserver/forms/tests/test_subnet.py
@@ -311,7 +311,7 @@ class TestSubnetForm(MAASServerTestCase):
311 self.assertTrue(form.is_valid(), dict(form.errors))311 self.assertTrue(form.is_valid(), dict(form.errors))
312 form.save()312 form.save()
313 subnet = reload_object(subnet)313 subnet = reload_object(subnet)
314 self.assertEquals(dns_servers, subnet.dns_servers)314 self.assertEqual(dns_servers, subnet.dns_servers)
315315
316 def test_doesnt_overwrite_other_fields(self):316 def test_doesnt_overwrite_other_fields(self):
317 new_name = factory.make_name("subnet")317 new_name = factory.make_name("subnet")
@@ -355,7 +355,7 @@ class TestSubnetForm(MAASServerTestCase):
355 self.assertTrue(form.is_valid(), dict(form.errors))355 self.assertTrue(form.is_valid(), dict(form.errors))
356 form.save()356 form.save()
357 subnet = reload_object(subnet)357 subnet = reload_object(subnet)
358 self.assertEquals(dns_servers, subnet.dns_servers)358 self.assertEqual(dns_servers, subnet.dns_servers)
359359
360 def test_clean_dns_servers_accepts_space_separated_list(self):360 def test_clean_dns_servers_accepts_space_separated_list(self):
361 subnet = factory.make_Subnet()361 subnet = factory.make_Subnet()
@@ -368,4 +368,4 @@ class TestSubnetForm(MAASServerTestCase):
368 self.assertTrue(form.is_valid(), dict(form.errors))368 self.assertTrue(form.is_valid(), dict(form.errors))
369 form.save()369 form.save()
370 subnet = reload_object(subnet)370 subnet = reload_object(subnet)
371 self.assertEquals(dns_servers, subnet.dns_servers)371 self.assertEqual(dns_servers, subnet.dns_servers)
diff --git a/src/maasserver/forms/tests/test_vlan.py b/src/maasserver/forms/tests/test_vlan.py
index 1f25e3a..a2b19d9 100644
--- a/src/maasserver/forms/tests/test_vlan.py
+++ b/src/maasserver/forms/tests/test_vlan.py
@@ -272,7 +272,7 @@ class TestVLANForm(MAASServerTestCase):
272 self.assertTrue(form.is_valid(), form.errors)272 self.assertTrue(form.is_valid(), form.errors)
273 form.save()273 form.save()
274 vlan = reload_object(vlan)274 vlan = reload_object(vlan)
275 self.assertEquals(relay_vlan.id, vlan.relay_vlan.id)275 self.assertEqual(relay_vlan.id, vlan.relay_vlan.id)
276276
277 def test_update_clears_relay_vlan_when_None(self):277 def test_update_clears_relay_vlan_when_None(self):
278 relay_vlan = factory.make_VLAN()278 relay_vlan = factory.make_VLAN()
@@ -299,7 +299,7 @@ class TestVLANForm(MAASServerTestCase):
299 self.assertTrue(form.is_valid(), form.errors)299 self.assertTrue(form.is_valid(), form.errors)
300 form.save()300 form.save()
301 vlan = reload_object(vlan)301 vlan = reload_object(vlan)
302 self.assertEquals(space.id, vlan.space.id)302 self.assertEqual(space.id, vlan.space.id)
303303
304 def test_update_sets_space_by_specifier(self):304 def test_update_sets_space_by_specifier(self):
305 vlan = factory.make_VLAN()305 vlan = factory.make_VLAN()
@@ -308,7 +308,7 @@ class TestVLANForm(MAASServerTestCase):
308 self.assertTrue(form.is_valid(), form.errors)308 self.assertTrue(form.is_valid(), form.errors)
309 form.save()309 form.save()
310 vlan = reload_object(vlan)310 vlan = reload_object(vlan)
311 self.assertEquals(space.id, vlan.space.id)311 self.assertEqual(space.id, vlan.space.id)
312312
313 def test_update_clears_space_when_None(self):313 def test_update_clears_space_when_None(self):
314 space = factory.make_Space()314 space = factory.make_Space()
diff --git a/src/maasserver/models/signals/tests/test_interfaces.py b/src/maasserver/models/signals/tests/test_interfaces.py
index 5bd8659..b09b10e 100644
--- a/src/maasserver/models/signals/tests/test_interfaces.py
+++ b/src/maasserver/models/signals/tests/test_interfaces.py
@@ -261,7 +261,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase):
261 new_vlan = new_fabric.get_default_vlan()261 new_vlan = new_fabric.get_default_vlan()
262 interface.vlan = new_vlan262 interface.vlan = new_vlan
263 interface.save()263 interface.save()
264 self.assertEquals(new_vlan, reload_object(subnet).vlan)264 self.assertEqual(new_vlan, reload_object(subnet).vlan)
265265
266 def test_doesnt_move_link_subnets_when_target_vlan_is_None(self):266 def test_doesnt_move_link_subnets_when_target_vlan_is_None(self):
267 node = self.maker()267 node = self.maker()
@@ -271,7 +271,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase):
271 factory.make_StaticIPAddress(subnet=subnet, interface=interface)271 factory.make_StaticIPAddress(subnet=subnet, interface=interface)
272 interface.vlan = None272 interface.vlan = None
273 interface.save()273 interface.save()
274 self.assertEquals(old_vlan, reload_object(subnet).vlan)274 self.assertEqual(old_vlan, reload_object(subnet).vlan)
275275
276 def test_doesnt_move_link_subnets_when_source_vlan_is_None(self):276 def test_doesnt_move_link_subnets_when_source_vlan_is_None(self):
277 node = self.maker()277 node = self.maker()
@@ -283,7 +283,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase):
283 factory.make_StaticIPAddress(subnet=subnet, interface=interface)283 factory.make_StaticIPAddress(subnet=subnet, interface=interface)
284 interface.vlan = factory.make_VLAN()284 interface.vlan = factory.make_VLAN()
285 interface.save()285 interface.save()
286 self.assertEquals(interface.vlan, reload_object(subnet).vlan)286 self.assertEqual(interface.vlan, reload_object(subnet).vlan)
287287
288 def test_moves_children_vlans_to_same_fabric(self):288 def test_moves_children_vlans_to_same_fabric(self):
289 node = self.maker()289 node = self.maker()
@@ -302,14 +302,14 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase):
302 new_vlan = new_fabric.get_default_vlan()302 new_vlan = new_fabric.get_default_vlan()
303 parent.vlan = new_vlan303 parent.vlan = new_vlan
304 parent.save()304 parent.save()
305 self.assertEquals(new_vlan, reload_object(subnet).vlan)305 self.assertEqual(new_vlan, reload_object(subnet).vlan)
306 vlan_interface = reload_object(vlan_interface)306 vlan_interface = reload_object(vlan_interface)
307 self.assertEquals(307 self.assertEqual(
308 (new_fabric.id, old_vlan.vid),308 (new_fabric.id, old_vlan.vid),
309 (vlan_interface.vlan.fabric.id, vlan_interface.vlan.vid),309 (vlan_interface.vlan.fabric.id, vlan_interface.vlan.vid),
310 )310 )
311 vlan_subnet = reload_object(vlan_subnet)311 vlan_subnet = reload_object(vlan_subnet)
312 self.assertEquals(312 self.assertEqual(
313 (new_fabric.id, old_vlan.vid),313 (new_fabric.id, old_vlan.vid),
314 (vlan_subnet.vlan.fabric.id, vlan_subnet.vlan.vid),314 (vlan_subnet.vlan.fabric.id, vlan_subnet.vlan.vid),
315 )315 )
diff --git a/src/maasserver/models/signals/tests/test_nodes.py b/src/maasserver/models/signals/tests/test_nodes.py
index 27888d6..38c4bdc 100644
--- a/src/maasserver/models/signals/tests/test_nodes.py
+++ b/src/maasserver/models/signals/tests/test_nodes.py
@@ -36,7 +36,7 @@ class TestNodeDeletion(MAASServerTestCase):
36 events = [factory.make_Event(node=node) for _ in range(3)]36 events = [factory.make_Event(node=node) for _ in range(3)]
37 node.delete()37 node.delete()
38 for event in events:38 for event in events:
39 self.assertEquals(event.node_hostname, node_hostname)39 self.assertEqual(event.node_hostname, node_hostname)
4040
41 def test_deleting_node_sets_node_to_null(self):41 def test_deleting_node_sets_node_to_null(self):
42 node = factory.make_Node()42 node = factory.make_Node()
@@ -87,7 +87,7 @@ class TestNodePreviousStatus(MAASServerTestCase):
87 )87 )
88 node.status = random.choice(NODE_TRANSITIONS[node.status])88 node.status = random.choice(NODE_TRANSITIONS[node.status])
89 node.save()89 node.save()
90 self.assertEquals(previous_status, node.previous_status)90 self.assertEqual(previous_status, node.previous_status)
9191
9292
93class TestNodeClearsOwnerNEWOrREADYStatus(MAASServerTestCase):93class TestNodeClearsOwnerNEWOrREADYStatus(MAASServerTestCase):
diff --git a/src/maasserver/models/signals/tests/test_podhints.py b/src/maasserver/models/signals/tests/test_podhints.py
index f11a3cb..696e574 100644
--- a/src/maasserver/models/signals/tests/test_podhints.py
+++ b/src/maasserver/models/signals/tests/test_podhints.py
@@ -17,6 +17,6 @@ class TestCreatePodChanged(MAASServerTestCase):
17 node = factory.make_Node(memory=2048)17 node = factory.make_Node(memory=2048)
18 pod.hints.nodes.add(node)18 pod.hints.nodes.add(node)
19 pod.sync_hints_from_nodes()19 pod.sync_hints_from_nodes()
20 self.assertEquals(2048, pod.memory)20 self.assertEqual(2048, pod.memory)
21 pod.hints.nodes.remove(node)21 pod.hints.nodes.remove(node)
22 self.assertEquals(0, reload_object(pod).memory)22 self.assertEqual(0, reload_object(pod).memory)
diff --git a/src/maasserver/models/signals/tests/test_services.py b/src/maasserver/models/signals/tests/test_services.py
index 0c237ef..ce50387 100644
--- a/src/maasserver/models/signals/tests/test_services.py
+++ b/src/maasserver/models/signals/tests/test_services.py
@@ -88,9 +88,7 @@ class TestRegionControllerProcess(MAASServerTestCase):
88 rack_controllers = [factory.make_RackController() for _ in range(3)]88 rack_controllers = [factory.make_RackController() for _ in range(3)]
89 mock_create_for = self.patch(Service.objects, "create_services_for")89 mock_create_for = self.patch(Service.objects, "create_services_for")
90 factory.make_RegionControllerProcess()90 factory.make_RegionControllerProcess()
91 self.assertEquals(91 self.assertEqual(len(rack_controllers) + 1, mock_create_for.call_count)
92 len(rack_controllers) + 1, mock_create_for.call_count
93 )
9492
95 def test_calls_update_rackd_status_on_all_racks_on_create(self):93 def test_calls_update_rackd_status_on_all_racks_on_create(self):
96 rack_controllers = [factory.make_RackController() for _ in range(3)]94 rack_controllers = [factory.make_RackController() for _ in range(3)]
@@ -98,7 +96,7 @@ class TestRegionControllerProcess(MAASServerTestCase):
98 RackController, "update_rackd_status"96 RackController, "update_rackd_status"
99 )97 )
100 factory.make_RegionControllerProcess()98 factory.make_RegionControllerProcess()
101 self.assertEquals(99 self.assertEqual(
102 len(rack_controllers), mock_update_rackd_status.call_count100 len(rack_controllers), mock_update_rackd_status.call_count
103 )101 )
104102
@@ -107,7 +105,7 @@ class TestRegionControllerProcess(MAASServerTestCase):
107 process = factory.make_RegionControllerProcess()105 process = factory.make_RegionControllerProcess()
108 mock_create_for = self.patch(Service.objects, "create_services_for")106 mock_create_for = self.patch(Service.objects, "create_services_for")
109 process.delete()107 process.delete()
110 self.assertEquals(len(rack_controllers), mock_create_for.call_count)108 self.assertEqual(len(rack_controllers), mock_create_for.call_count)
111109
112 def test_calls_update_rackd_status_on_all_racks_on_delete(self):110 def test_calls_update_rackd_status_on_all_racks_on_delete(self):
113 rack_controllers = [factory.make_RackController() for _ in range(3)]111 rack_controllers = [factory.make_RackController() for _ in range(3)]
@@ -116,6 +114,6 @@ class TestRegionControllerProcess(MAASServerTestCase):
116 RackController, "update_rackd_status"114 RackController, "update_rackd_status"
117 )115 )
118 process.delete()116 process.delete()
119 self.assertEquals(117 self.assertEqual(
120 len(rack_controllers), mock_update_rackd_status.call_count118 len(rack_controllers), mock_update_rackd_status.call_count
121 )119 )
diff --git a/src/maasserver/models/signals/tests/test_users.py b/src/maasserver/models/signals/tests/test_users.py
index d581351..0198f65 100644
--- a/src/maasserver/models/signals/tests/test_users.py
+++ b/src/maasserver/models/signals/tests/test_users.py
@@ -18,4 +18,4 @@ class TestUserUsername(MAASServerTestCase):
18 events = [factory.make_Event(user=user) for _ in range(3)]18 events = [factory.make_Event(user=user) for _ in range(3)]
19 user.delete()19 user.delete()
20 for event in events:20 for event in events:
21 self.assertEquals(event.username, username)21 self.assertEqual(event.username, username)
diff --git a/src/maasserver/models/tests/test_bmc.py b/src/maasserver/models/tests/test_bmc.py
index 76216e9..280f6e2 100644
--- a/src/maasserver/models/tests/test_bmc.py
+++ b/src/maasserver/models/tests/test_bmc.py
@@ -2414,7 +2414,7 @@ class TestPod(MAASServerTestCase):
2414 )2414 )
2415 node = reload_object(node)2415 node = reload_object(node)
2416 self.assertItemsEqual([node], pod.hints.nodes.all())2416 self.assertItemsEqual([node], pod.hints.nodes.all())
2417 self.assertEquals(NODE_STATUS.DEPLOYED, node.status)2417 self.assertEqual(NODE_STATUS.DEPLOYED, node.status)
2418 self.assertIsNotNone(node.current_commissioning_script_set)2418 self.assertIsNotNone(node.current_commissioning_script_set)
24192419
2420 def test_sync_converts_existing_device(self):2420 def test_sync_converts_existing_device(self):
@@ -2435,8 +2435,8 @@ class TestPod(MAASServerTestCase):
2435 )2435 )
2436 device = reload_object(device)2436 device = reload_object(device)
2437 self.assertItemsEqual([device], pod.hints.nodes.all())2437 self.assertItemsEqual([device], pod.hints.nodes.all())
2438 self.assertEquals(NODE_STATUS.DEPLOYED, device.status)2438 self.assertEqual(NODE_STATUS.DEPLOYED, device.status)
2439 self.assertEquals(NODE_TYPE.MACHINE, device.node_type)2439 self.assertEqual(NODE_TYPE.MACHINE, device.node_type)
2440 self.assertIsNotNone(device.current_commissioning_script_set)2440 self.assertIsNotNone(device.current_commissioning_script_set)
24412441
2442 def test_sync_creates_machine(self):2442 def test_sync_creates_machine(self):
@@ -2449,11 +2449,11 @@ class TestPod(MAASServerTestCase):
2449 ),2449 ),
2450 factory.make_User(),2450 factory.make_User(),
2451 )2451 )
2452 self.assertEquals(1, pod.hints.nodes.count())2452 self.assertEqual(1, pod.hints.nodes.count())
2453 node = pod.hints.nodes.first()2453 node = pod.hints.nodes.first()
2454 self.assertEquals(pod.name, node.hostname)2454 self.assertEqual(pod.name, node.hostname)
2455 self.assertEquals(NODE_STATUS.DEPLOYED, node.status)2455 self.assertEqual(NODE_STATUS.DEPLOYED, node.status)
2456 self.assertEquals(NODE_TYPE.MACHINE, node.node_type)2456 self.assertEqual(NODE_TYPE.MACHINE, node.node_type)
2457 self.assertItemsEqual(2457 self.assertItemsEqual(
2458 mac_addresses,2458 mac_addresses,
2459 [str(iface.mac_address) for iface in node.interface_set.all()],2459 [str(iface.mac_address) for iface in node.interface_set.all()],
@@ -2491,15 +2491,15 @@ class TestPod(MAASServerTestCase):
2491 elif bd.type == "iscsi":2491 elif bd.type == "iscsi":
2492 iscsi_storage += bd.size2492 iscsi_storage += bd.size
24932493
2494 self.assertEquals(pod.hints.cores, cores)2494 self.assertEqual(pod.hints.cores, cores)
2495 self.assertEquals(2495 self.assertEqual(
2496 pod.hints.cpu_speed,2496 pod.hints.cpu_speed,
2497 int(mean(cpu_speeds)),2497 int(mean(cpu_speeds)),
2498 f"Wrong hint ({pod.hints.cpu_speed}) for CPU speed. CPU speeds of nodes: {cpu_speeds}",2498 f"Wrong hint ({pod.hints.cpu_speed}) for CPU speed. CPU speeds of nodes: {cpu_speeds}",
2499 )2499 )
2500 self.assertEquals(pod.hints.memory, memory)2500 self.assertEqual(pod.hints.memory, memory)
2501 self.assertEquals(pod.hints.local_disks, len(nodes))2501 self.assertEqual(pod.hints.local_disks, len(nodes))
2502 self.assertEquals(pod.hints.iscsi_storage, iscsi_storage)2502 self.assertEqual(pod.hints.iscsi_storage, iscsi_storage)
25032503
2504 def test_get_used_cores(self):2504 def test_get_used_cores(self):
2505 pod = factory.make_Pod()2505 pod = factory.make_Pod()
@@ -2508,7 +2508,7 @@ class TestPod(MAASServerTestCase):
2508 cores = random.randint(1, 4)2508 cores = random.randint(1, 4)
2509 total_cores += cores2509 total_cores += cores
2510 factory.make_Node(bmc=pod, cpu_count=cores)2510 factory.make_Node(bmc=pod, cpu_count=cores)
2511 self.assertEquals(total_cores, pod.get_used_cores())2511 self.assertEqual(total_cores, pod.get_used_cores())
25122512
2513 def test_get_used_memory(self):2513 def test_get_used_memory(self):
2514 pod = factory.make_Pod()2514 pod = factory.make_Pod()
@@ -2517,7 +2517,7 @@ class TestPod(MAASServerTestCase):
2517 memory = random.randint(1, 4)2517 memory = random.randint(1, 4)
2518 total_memory += memory2518 total_memory += memory
2519 factory.make_Node(bmc=pod, memory=memory)2519 factory.make_Node(bmc=pod, memory=memory)
2520 self.assertEquals(total_memory, pod.get_used_memory())2520 self.assertEqual(total_memory, pod.get_used_memory())
25212521
2522 def test_get_used_local_storage(self):2522 def test_get_used_local_storage(self):
2523 pod = factory.make_Pod()2523 pod = factory.make_Pod()
@@ -2527,7 +2527,7 @@ class TestPod(MAASServerTestCase):
2527 total_storage += storage2527 total_storage += storage
2528 node = factory.make_Node(bmc=pod, with_boot_disk=False)2528 node = factory.make_Node(bmc=pod, with_boot_disk=False)
2529 factory.make_PhysicalBlockDevice(node=node, size=storage)2529 factory.make_PhysicalBlockDevice(node=node, size=storage)
2530 self.assertEquals(total_storage, pod.get_used_local_storage())2530 self.assertEqual(total_storage, pod.get_used_local_storage())
25312531
2532 def test_get_used_local_disks(self):2532 def test_get_used_local_disks(self):
2533 pod = factory.make_Pod()2533 pod = factory.make_Pod()
@@ -2535,7 +2535,7 @@ class TestPod(MAASServerTestCase):
2535 node = factory.make_Node(bmc=pod, with_boot_disk=False)2535 node = factory.make_Node(bmc=pod, with_boot_disk=False)
2536 for _ in range(3):2536 for _ in range(3):
2537 factory.make_PhysicalBlockDevice(node=node)2537 factory.make_PhysicalBlockDevice(node=node)
2538 self.assertEquals(9, pod.get_used_local_disks())2538 self.assertEqual(9, pod.get_used_local_disks())
25392539
2540 def test_get_used_iscsi_storage(self):2540 def test_get_used_iscsi_storage(self):
2541 pod = factory.make_Pod()2541 pod = factory.make_Pod()
@@ -2545,7 +2545,7 @@ class TestPod(MAASServerTestCase):
2545 total_storage += storage2545 total_storage += storage
2546 node = factory.make_Node(bmc=pod, with_boot_disk=False)2546 node = factory.make_Node(bmc=pod, with_boot_disk=False)
2547 factory.make_ISCSIBlockDevice(node=node, size=storage)2547 factory.make_ISCSIBlockDevice(node=node, size=storage)
2548 self.assertEquals(total_storage, pod.get_used_iscsi_storage())2548 self.assertEqual(total_storage, pod.get_used_iscsi_storage())
25492549
2550 def test_sync_machine_memory(self):2550 def test_sync_machine_memory(self):
2551 pod = factory.make_Pod(pod_type="lxd")2551 pod = factory.make_Pod(pod_type="lxd")
diff --git a/src/maasserver/models/tests/test_bootresource.py b/src/maasserver/models/tests/test_bootresource.py
index f0e1c9d..0c32b14 100644
--- a/src/maasserver/models/tests/test_bootresource.py
+++ b/src/maasserver/models/tests/test_bootresource.py
@@ -189,7 +189,7 @@ class TestBootResourceManager(MAASServerTestCase):
189 architecture="amd64/hwe-16.04",189 architecture="amd64/hwe-16.04",
190 extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"},190 extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"},
191 )191 )
192 self.assertEquals(192 self.assertEqual(
193 ["hwe-16.04"], BootResource.objects.get_usable_hwe_kernels()193 ["hwe-16.04"], BootResource.objects.get_usable_hwe_kernels()
194 )194 )
195195
@@ -198,7 +198,7 @@ class TestBootResourceManager(MAASServerTestCase):
198 architecture="amd64/hwe-16.04",198 architecture="amd64/hwe-16.04",
199 extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"},199 extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"},
200 )200 )
201 self.assertEquals(201 self.assertEqual(
202 ["hwe-p", "hwe-t", "hwe-16.04", "hwe-16.10"],202 ["hwe-p", "hwe-t", "hwe-16.04", "hwe-16.10"],
203 BootResource.objects.get_supported_hwe_kernels(),203 BootResource.objects.get_supported_hwe_kernels(),
204 )204 )
diff --git a/src/maasserver/models/tests/test_bootsourcecache.py b/src/maasserver/models/tests/test_bootsourcecache.py
index 18ac56f..8a75908 100644
--- a/src/maasserver/models/tests/test_bootsourcecache.py
+++ b/src/maasserver/models/tests/test_bootsourcecache.py
@@ -33,7 +33,7 @@ class TestBootSourceCache(MAASServerTestCase):
33 def test_get_release_title_returns_release_title(self):33 def test_get_release_title_returns_release_title(self):
34 release_title = factory.make_name("release_title")34 release_title = factory.make_name("release_title")
35 cache = factory.make_BootSourceCache(release_title=release_title)35 cache = factory.make_BootSourceCache(release_title=release_title)
36 self.assertEquals(36 self.assertEqual(
37 release_title,37 release_title,
38 BootSourceCache.objects.get_release_title(cache.os, cache.release),38 BootSourceCache.objects.get_release_title(cache.os, cache.release),
39 )39 )
@@ -54,7 +54,7 @@ class TestBootSourceCache(MAASServerTestCase):
54 def test_get_release_codename_returns_release_codename(self):54 def test_get_release_codename_returns_release_codename(self):
55 release_codename = factory.make_name("release_codename")55 release_codename = factory.make_name("release_codename")
56 cache = factory.make_BootSourceCache(release_codename=release_codename)56 cache = factory.make_BootSourceCache(release_codename=release_codename)
57 self.assertEquals(57 self.assertEqual(
58 release_codename,58 release_codename,
59 BootSourceCache.objects.get_release_codename(59 BootSourceCache.objects.get_release_codename(
60 cache.os, cache.release60 cache.os, cache.release
diff --git a/src/maasserver/models/tests/test_cleansave.py b/src/maasserver/models/tests/test_cleansave.py
index fa4437a..bfeaf25 100644
--- a/src/maasserver/models/tests/test_cleansave.py
+++ b/src/maasserver/models/tests/test_cleansave.py
@@ -21,12 +21,12 @@ class TestCleanSave(MAASLegacyServerTestCase):
21 def test_state_is_clean_save_based(self):21 def test_state_is_clean_save_based(self):
22 obj = CleanSaveTestModel.objects.create()22 obj = CleanSaveTestModel.objects.create()
23 self.assertIsInstance(obj._state, CleanSaveModelState)23 self.assertIsInstance(obj._state, CleanSaveModelState)
24 self.assertEquals({}, obj._state._changed_fields)24 self.assertEqual({}, obj._state._changed_fields)
2525
26 def test_setting_property(self):26 def test_setting_property(self):
27 obj = CleanSaveModelState()27 obj = CleanSaveModelState()
28 obj.test_prop = sentinel.value28 obj.test_prop = sentinel.value
29 self.assertEquals(sentinel.value, obj.test_prop)29 self.assertEqual(sentinel.value, obj.test_prop)
3030
31 def test_handling_deferred_field_getting(self):31 def test_handling_deferred_field_getting(self):
32 obj = CleanSaveTestModel.objects.create()32 obj = CleanSaveTestModel.objects.create()
@@ -43,24 +43,24 @@ class TestCleanSave(MAASLegacyServerTestCase):
43 def test_field_marked_changed_for_new_obj(self):43 def test_field_marked_changed_for_new_obj(self):
44 obj = CleanSaveTestModel()44 obj = CleanSaveTestModel()
45 obj.field = "test"45 obj.field = "test"
46 self.assertEquals({"field": None}, obj._state._changed_fields)46 self.assertEqual({"field": None}, obj._state._changed_fields)
4747
48 def test_field_marked_changed_for_new_obj_when_reset(self):48 def test_field_marked_changed_for_new_obj_when_reset(self):
49 obj = CleanSaveTestModel()49 obj = CleanSaveTestModel()
50 obj.field = "test"50 obj.field = "test"
51 obj.field = None51 obj.field = None
52 self.assertEquals({"field": None}, obj._state._changed_fields)52 self.assertEqual({"field": None}, obj._state._changed_fields)
5353
54 def test_field_marked_changed_for_existing_obj(self):54 def test_field_marked_changed_for_existing_obj(self):
55 obj = CleanSaveTestModel.objects.create()55 obj = CleanSaveTestModel.objects.create()
56 obj.field = "test"56 obj.field = "test"
57 self.assertEquals({"field": None}, obj._state._changed_fields)57 self.assertEqual({"field": None}, obj._state._changed_fields)
5858
59 def test_field_not_marked_changed_for_existing_obj_when_reset(self):59 def test_field_not_marked_changed_for_existing_obj_when_reset(self):
60 obj = CleanSaveTestModel.objects.create()60 obj = CleanSaveTestModel.objects.create()
61 obj.field = "test"61 obj.field = "test"
62 obj.field = None62 obj.field = None
63 self.assertEquals({}, obj._state._changed_fields)63 self.assertEqual({}, obj._state._changed_fields)
6464
65 def test_field_not_marked_changed_when_refresh_from_db(self):65 def test_field_not_marked_changed_when_refresh_from_db(self):
66 obj = CleanSaveTestModel.objects.create()66 obj = CleanSaveTestModel.objects.create()
@@ -69,8 +69,8 @@ class TestCleanSave(MAASLegacyServerTestCase):
69 duplicate.save()69 duplicate.save()
7070
71 obj.refresh_from_db()71 obj.refresh_from_db()
72 self.assertEquals("test", obj.field)72 self.assertEqual("test", obj.field)
73 self.assertEquals({}, obj._state._changed_fields)73 self.assertEqual({}, obj._state._changed_fields)
7474
75 def test_field_not_marked_changed_when_refresh_from_db_no_fields(self):75 def test_field_not_marked_changed_when_refresh_from_db_no_fields(self):
76 obj = CleanSaveTestModel.objects.create()76 obj = CleanSaveTestModel.objects.create()
@@ -79,8 +79,8 @@ class TestCleanSave(MAASLegacyServerTestCase):
79 duplicate.save()79 duplicate.save()
8080
81 obj.refresh_from_db(fields=[])81 obj.refresh_from_db(fields=[])
82 self.assertEquals(None, obj.field)82 self.assertEqual(None, obj.field)
83 self.assertEquals({}, obj._state._changed_fields)83 self.assertEqual({}, obj._state._changed_fields)
8484
85 def test_field_not_marked_changed_when_refresh_with_changed_fields(self):85 def test_field_not_marked_changed_when_refresh_with_changed_fields(self):
86 obj = CleanSaveTestModel.objects.create()86 obj = CleanSaveTestModel.objects.create()
@@ -89,15 +89,15 @@ class TestCleanSave(MAASLegacyServerTestCase):
89 duplicate.save()89 duplicate.save()
9090
91 obj.refresh_from_db(fields=["field"])91 obj.refresh_from_db(fields=["field"])
92 self.assertEquals("test", obj.field)92 self.assertEqual("test", obj.field)
93 self.assertEquals({}, obj._state._changed_fields)93 self.assertEqual({}, obj._state._changed_fields)
9494
95 def test_field_not_marked_changed_when_refresh_with_same_fields(self):95 def test_field_not_marked_changed_when_refresh_with_same_fields(self):
96 obj = CleanSaveTestModel.objects.create()96 obj = CleanSaveTestModel.objects.create()
9797
98 obj.refresh_from_db(fields=["field"])98 obj.refresh_from_db(fields=["field"])
99 self.assertEquals(None, obj.field)99 self.assertEqual(None, obj.field)
100 self.assertEquals({}, obj._state._changed_fields)100 self.assertEqual({}, obj._state._changed_fields)
101101
102 def test_field_marked_changed_when_refresh_from_db_with_no_fields(self):102 def test_field_marked_changed_when_refresh_from_db_with_no_fields(self):
103 obj = CleanSaveTestModel.objects.create()103 obj = CleanSaveTestModel.objects.create()
@@ -107,27 +107,27 @@ class TestCleanSave(MAASLegacyServerTestCase):
107107
108 obj.field = "test"108 obj.field = "test"
109 obj.refresh_from_db(fields=[])109 obj.refresh_from_db(fields=[])
110 self.assertEquals("test", obj.field)110 self.assertEqual("test", obj.field)
111 self.assertEquals({"field": None}, obj._state._changed_fields)111 self.assertEqual({"field": None}, obj._state._changed_fields)
112112
113 def test_field_marked_changed_rel_id_for_new_obj(self):113 def test_field_marked_changed_rel_id_for_new_obj(self):
114 related = GenericTestModel.objects.create(field="")114 related = GenericTestModel.objects.create(field="")
115 obj = CleanSaveTestModel()115 obj = CleanSaveTestModel()
116 obj.related_id = related.id116 obj.related_id = related.id
117 self.assertEquals({"related_id": None}, obj._state._changed_fields)117 self.assertEqual({"related_id": None}, obj._state._changed_fields)
118118
119 def test_field_marked_changed_rel_attname_for_new_obj(self):119 def test_field_marked_changed_rel_attname_for_new_obj(self):
120 related = GenericTestModel.objects.create(field="")120 related = GenericTestModel.objects.create(field="")
121 obj = CleanSaveTestModel()121 obj = CleanSaveTestModel()
122 obj.related = related122 obj.related = related
123 self.assertEquals({"related_id": None}, obj._state._changed_fields)123 self.assertEqual({"related_id": None}, obj._state._changed_fields)
124124
125 def test_field_marked_changed_rel_id_for_existing_obj(self):125 def test_field_marked_changed_rel_id_for_existing_obj(self):
126 related = GenericTestModel.objects.create(field="")126 related = GenericTestModel.objects.create(field="")
127 new_related = GenericTestModel.objects.create(field="")127 new_related = GenericTestModel.objects.create(field="")
128 obj = CleanSaveTestModel.objects.create(related=related)128 obj = CleanSaveTestModel.objects.create(related=related)
129 obj.related_id = new_related.id129 obj.related_id = new_related.id
130 self.assertEquals(130 self.assertEqual(
131 {"related_id": related.id}, obj._state._changed_fields131 {"related_id": related.id}, obj._state._changed_fields
132 )132 )
133133
@@ -136,7 +136,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
136 new_related = GenericTestModel.objects.create(field="")136 new_related = GenericTestModel.objects.create(field="")
137 obj = CleanSaveTestModel.objects.create(related=related)137 obj = CleanSaveTestModel.objects.create(related=related)
138 obj.related = new_related138 obj.related = new_related
139 self.assertEquals(139 self.assertEqual(
140 {"related_id": related.id}, obj._state._changed_fields140 {"related_id": related.id}, obj._state._changed_fields
141 )141 )
142142
@@ -146,7 +146,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
146 obj = CleanSaveTestModel.objects.create(related=related)146 obj = CleanSaveTestModel.objects.create(related=related)
147 obj.related_id = new_related.id147 obj.related_id = new_related.id
148 obj.related_id = related.id148 obj.related_id = related.id
149 self.assertEquals({}, obj._state._changed_fields)149 self.assertEqual({}, obj._state._changed_fields)
150150
151 def test_field_not_marked_changed_rel_attname_for_existing_obj(self):151 def test_field_not_marked_changed_rel_attname_for_existing_obj(self):
152 related = GenericTestModel.objects.create(field="")152 related = GenericTestModel.objects.create(field="")
@@ -154,7 +154,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
154 obj = CleanSaveTestModel.objects.create(related=related)154 obj = CleanSaveTestModel.objects.create(related=related)
155 obj.related = new_related155 obj.related = new_related
156 obj.related = related156 obj.related = related
157 self.assertEquals({}, obj._state._changed_fields)157 self.assertEqual({}, obj._state._changed_fields)
158158
159 def test_save_always_calls_save_when_new(self):159 def test_save_always_calls_save_when_new(self):
160 mock_save = self.patch(Model, "save")160 mock_save = self.patch(Model, "save")
@@ -185,7 +185,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
185 obj = CleanSaveTestModel()185 obj = CleanSaveTestModel()
186 obj.field = "test"186 obj.field = "test"
187 obj.save()187 obj.save()
188 self.assertEquals({}, obj._state._changed_fields)188 self.assertEqual({}, obj._state._changed_fields)
189189
190 def test_save_performed_with_force_update(self):190 def test_save_performed_with_force_update(self):
191 obj = CleanSaveTestModel.objects.create()191 obj = CleanSaveTestModel.objects.create()
@@ -237,7 +237,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
237 using="default",237 using="default",
238 ),238 ),
239 )239 )
240 self.assertEquals({}, obj._state._changed_fields)240 self.assertEqual({}, obj._state._changed_fields)
241241
242 def test_save_table_updates_update_fields_with_changed_fields(self):242 def test_save_table_updates_update_fields_with_changed_fields(self):
243 related = GenericTestModel.objects.create(field="")243 related = GenericTestModel.objects.create(field="")
@@ -257,7 +257,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
257 using="default",257 using="default",
258 ),258 ),
259 )259 )
260 self.assertEquals({}, obj._state._changed_fields)260 self.assertEqual({}, obj._state._changed_fields)
261261
262 def test_save_ignores_clean_on_deferred(self):262 def test_save_ignores_clean_on_deferred(self):
263 obj = CleanSaveTestModel.objects.create(field="test")263 obj = CleanSaveTestModel.objects.create(field="test")
@@ -306,7 +306,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
306 def test_utils_get_changed(self):306 def test_utils_get_changed(self):
307 obj = CleanSaveTestModel.objects.create()307 obj = CleanSaveTestModel.objects.create()
308 obj.field = "test"308 obj.field = "test"
309 self.assertEquals({"field"}, obj._state.get_changed())309 self.assertEqual({"field"}, obj._state.get_changed())
310310
311 def test_utils_has_changed_True(self):311 def test_utils_has_changed_True(self):
312 obj = CleanSaveTestModel.objects.create()312 obj = CleanSaveTestModel.objects.create()
@@ -331,7 +331,7 @@ class TestCleanSave(MAASLegacyServerTestCase):
331 new_related = GenericTestModel.objects.create(field="")331 new_related = GenericTestModel.objects.create(field="")
332 obj = CleanSaveTestModel.objects.create(related=related)332 obj = CleanSaveTestModel.objects.create(related=related)
333 obj.related = new_related333 obj.related = new_related
334 self.assertEquals(related.id, obj._state.get_old_value("related_id"))334 self.assertEqual(related.id, obj._state.get_old_value("related_id"))
335335
336 def test_utils_get_old_value_returns_None_when_not_changed(self):336 def test_utils_get_old_value_returns_None_when_not_changed(self):
337 obj = CleanSaveTestModel.objects.create()337 obj = CleanSaveTestModel.objects.create()
diff --git a/src/maasserver/models/tests/test_config.py b/src/maasserver/models/tests/test_config.py
index 08e2e55..1948ed2 100644
--- a/src/maasserver/models/tests/test_config.py
+++ b/src/maasserver/models/tests/test_config.py
@@ -127,7 +127,7 @@ class ConfigTest(MAASServerTestCase):
127 if name != expected_names[0]127 if name != expected_names[0]
128 }128 }
129 )129 )
130 self.assertEquals(expected_dict, observed)130 self.assertEqual(expected_dict, observed)
131131
132 def test_manager_get_configs_returns_passed_defaults(self):132 def test_manager_get_configs_returns_passed_defaults(self):
133 expected = get_default_config()133 expected = get_default_config()
@@ -139,7 +139,7 @@ class ConfigTest(MAASServerTestCase):
139 defaults = [expected_dict[name] for name in expected_names]139 defaults = [expected_dict[name] for name in expected_names]
140 for name, value in expected_dict.items():140 for name, value in expected_dict.items():
141 Config.objects.set_config(name, value)141 Config.objects.set_config(name, value)
142 self.assertEquals(142 self.assertEqual(
143 expected_dict, Config.objects.get_configs(expected_names, defaults)143 expected_dict, Config.objects.get_configs(expected_names, defaults)
144 )144 )
145145
diff --git a/src/maasserver/models/tests/test_filesystemgroup.py b/src/maasserver/models/tests/test_filesystemgroup.py
index 488c747..88b099b 100644
--- a/src/maasserver/models/tests/test_filesystemgroup.py
+++ b/src/maasserver/models/tests/test_filesystemgroup.py
@@ -1025,14 +1025,14 @@ class TestFilesystemGroup(MAASServerTestCase):
10251025
1026 def test_get_size_returns_total_size_with_vmfs(self):1026 def test_get_size_returns_total_size_with_vmfs(self):
1027 vmfs = factory.make_VMFS()1027 vmfs = factory.make_VMFS()
1028 self.assertEquals(vmfs.get_total_size(), vmfs.get_size())1028 self.assertEqual(vmfs.get_total_size(), vmfs.get_size())
10291029
1030 def test_get_total_size(self):1030 def test_get_total_size(self):
1031 vmfs = factory.make_VMFS()1031 vmfs = factory.make_VMFS()
1032 size = 01032 size = 0
1033 for fs in vmfs.filesystems.all():1033 for fs in vmfs.filesystems.all():
1034 size += fs.get_size()1034 size += fs.get_size()
1035 self.assertEquals(size, vmfs.get_total_size())1035 self.assertEqual(size, vmfs.get_total_size())
10361036
1037 def test_is_lvm_returns_true_when_LVM_VG(self):1037 def test_is_lvm_returns_true_when_LVM_VG(self):
1038 fsgroup = FilesystemGroup(group_type=FILESYSTEM_GROUP_TYPE.LVM_VG)1038 fsgroup = FilesystemGroup(group_type=FILESYSTEM_GROUP_TYPE.LVM_VG)
@@ -1083,7 +1083,7 @@ class TestFilesystemGroup(MAASServerTestCase):
1083 part = factory.make_Partition()1083 part = factory.make_Partition()
1084 name = factory.make_name("datastore")1084 name = factory.make_name("datastore")
1085 vmfs = VMFS.objects.create_vmfs(name, [part])1085 vmfs = VMFS.objects.create_vmfs(name, [part])
1086 self.assertEquals(1086 self.assertEqual(
1087 "/vmfs/volumes/%s" % name,1087 "/vmfs/volumes/%s" % name,
1088 vmfs.virtual_device.get_effective_filesystem().mount_point,1088 vmfs.virtual_device.get_effective_filesystem().mount_point,
1089 )1089 )
diff --git a/src/maasserver/models/tests/test_interface.py b/src/maasserver/models/tests/test_interface.py
index 918252e..9652490 100644
--- a/src/maasserver/models/tests/test_interface.py
+++ b/src/maasserver/models/tests/test_interface.py
@@ -163,7 +163,7 @@ class TestInterfaceManager(MAASServerTestCase):
163 node=node, mac_address=mac_address163 node=node, mac_address=mac_address
164 )164 )
165 self.assertFalse(created)165 self.assertFalse(created)
166 self.assertEquals(interface, retrieved_interface)166 self.assertEqual(interface, retrieved_interface)
167167
168 def test_get_or_create_with_parents(self):168 def test_get_or_create_with_parents(self):
169 parent1 = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)169 parent1 = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
@@ -182,7 +182,7 @@ class TestInterfaceManager(MAASServerTestCase):
182 node=parent1.node, parents=[parent1, parent2]182 node=parent1.node, parents=[parent1, parent2]
183 )183 )
184 self.assertFalse(created)184 self.assertFalse(created)
185 self.assertEquals(interface, retrieved_interface)185 self.assertEqual(interface, retrieved_interface)
186186
187 def test_get_interface_dict_for_node(self):187 def test_get_interface_dict_for_node(self):
188 node1 = factory.make_Node()188 node1 = factory.make_Node()
@@ -1341,8 +1341,8 @@ class InterfaceTest(MAASServerTestCase):
1341 interface.interface_speed = 1001341 interface.interface_speed = 100
1342 interface.link_speed = 10001342 interface.link_speed = 1000
1343 interface.save()1343 interface.save()
1344 self.assertEquals(100, interface.interface_speed)1344 self.assertEqual(100, interface.interface_speed)
1345 self.assertEquals(1000, interface.link_speed)1345 self.assertEqual(1000, interface.link_speed)
13461346
1347 def test_save_link_speed_may_exceed_unknown_interface_speed(self):1347 def test_save_link_speed_may_exceed_unknown_interface_speed(self):
1348 interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)1348 interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
@@ -1350,14 +1350,14 @@ class InterfaceTest(MAASServerTestCase):
1350 interface.link_speed = 10001350 interface.link_speed = 1000
1351 interface.save()1351 interface.save()
1352 interface = reload_object(interface)1352 interface = reload_object(interface)
1353 self.assertEquals(0, interface.interface_speed)1353 self.assertEqual(0, interface.interface_speed)
1354 self.assertEquals(1000, interface.link_speed)1354 self.assertEqual(1000, interface.link_speed)
13551355
1356 def test_save_if_link_disconnected_set_link_speed_to_zero(self):1356 def test_save_if_link_disconnected_set_link_speed_to_zero(self):
1357 interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)1357 interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
1358 interface.link_connected = False1358 interface.link_connected = False
1359 interface.save()1359 interface.save()
1360 self.assertEquals(0, interface.link_speed)1360 self.assertEqual(0, interface.link_speed)
13611361
13621362
1363class InterfaceUpdateNeighbourTest(MAASServerTestCase):1363class InterfaceUpdateNeighbourTest(MAASServerTestCase):
@@ -1771,7 +1771,7 @@ class InterfaceMTUTest(MAASServerTestCase):
1771 ),1771 ),
1772 ),1772 ),
1773 )1773 )
1774 self.assertEquals([parent.id], [p.id for p in bridge.parents.all()])1774 self.assertEqual([parent.id], [p.id for p in bridge.parents.all()])
17751775
17761776
1777class VLANInterfaceTest(MAASServerTestCase):1777class VLANInterfaceTest(MAASServerTestCase):
@@ -3649,13 +3649,13 @@ class TestClaimAutoIPs(MAASTransactionServerTestCase):
3649 )3649 )
3650 with transaction.atomic():3650 with transaction.atomic():
3651 observed = interface.claim_auto_ips()3651 observed = interface.claim_auto_ips()
3652 self.assertEquals(3652 self.assertEqual(
3653 1,3653 1,
3654 len(observed),3654 len(observed),
3655 "Should have 1 AUTO IP addresses with an IP address assigned.",3655 "Should have 1 AUTO IP addresses with an IP address assigned.",
3656 )3656 )
3657 self.assertEquals(subnet, observed[0].subnet)3657 self.assertEqual(subnet, observed[0].subnet)
3658 self.assertEquals(3658 self.assertEqual(
3659 IPAddress(network.first + 2), IPAddress(observed[0].ip)3659 IPAddress(network.first + 2), IPAddress(observed[0].ip)
3660 )3660 )
36613661
@@ -3790,7 +3790,7 @@ class TestCreateAcquiredBridge(MAASServerTestCase):
3790 ),3790 ),
3791 ),3791 ),
3792 )3792 )
3793 self.assertEquals([parent.id], [p.id for p in bridge.parents.all()])3793 self.assertEqual([parent.id], [p.id for p in bridge.parents.all()])
37943794
3795 def test_creates_acquired_bridge_with_passed_options(self):3795 def test_creates_acquired_bridge_with_passed_options(self):
3796 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)3796 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
@@ -3818,7 +3818,7 @@ class TestCreateAcquiredBridge(MAASServerTestCase):
3818 ),3818 ),
3819 ),3819 ),
3820 )3820 )
3821 self.assertEquals([parent.id], [p.id for p in bridge.parents.all()])3821 self.assertEqual([parent.id], [p.id for p in bridge.parents.all()])
38223822
3823 def test_creates_acquired_bridge_moves_links_from_parent_to_bridge(self):3823 def test_creates_acquired_bridge_moves_links_from_parent_to_bridge(self):
3824 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)3824 parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL)
@@ -3847,11 +3847,11 @@ class TestCreateAcquiredBridge(MAASServerTestCase):
3847 ),3847 ),
3848 ),3848 ),
3849 )3849 )
3850 self.assertEquals([parent.id], [p.id for p in bridge.parents.all()])3850 self.assertEqual([parent.id], [p.id for p in bridge.parents.all()])
3851 self.assertEquals(3851 self.assertEqual(
3852 [bridge.id], [nic.id for nic in auto_ip.interface_set.all()]3852 [bridge.id], [nic.id for nic in auto_ip.interface_set.all()]
3853 )3853 )
3854 self.assertEquals(3854 self.assertEqual(
3855 [bridge.id], [nic.id for nic in static_ip.interface_set.all()]3855 [bridge.id], [nic.id for nic in static_ip.interface_set.all()]
3856 )3856 )
38573857
diff --git a/src/maasserver/models/tests/test_iscsiblockdevice.py b/src/maasserver/models/tests/test_iscsiblockdevice.py
index 8f6335d..442dace 100644
--- a/src/maasserver/models/tests/test_iscsiblockdevice.py
+++ b/src/maasserver/models/tests/test_iscsiblockdevice.py
@@ -85,4 +85,4 @@ class TestISCSIBlockDevice(MAASServerTestCase):
85 block_size=512,85 block_size=512,
86 target=target,86 target=target,
87 )87 )
88 self.assertEquals("iscsi:%s" % target, block_device.target)88 self.assertEqual("iscsi:%s" % target, block_device.target)
diff --git a/src/maasserver/models/tests/test_node.py b/src/maasserver/models/tests/test_node.py
index 3c21d98..20b5dee 100644
--- a/src/maasserver/models/tests/test_node.py
+++ b/src/maasserver/models/tests/test_node.py
@@ -676,7 +676,7 @@ class TestRackControllerManager(MAASServerTestCase):
676 ip = random.choice(["127.0.0.1", "::1"])676 ip = random.choice(["127.0.0.1", "::1"])
677 mock_getaddr_info.return_value = (("", "", "", "", (ip,)),)677 mock_getaddr_info.return_value = (("", "", "", "", (ip,)),)
678 self.useFixture(MAASIDFixture(rack.system_id))678 self.useFixture(MAASIDFixture(rack.system_id))
679 self.assertEquals(679 self.assertEqual(
680 [rack], RackController.objects.filter_by_url_accessible(ip, False)680 [rack], RackController.objects.filter_by_url_accessible(ip, False)
681 )681 )
682682
@@ -724,7 +724,7 @@ class TestRackControllerManager(MAASServerTestCase):
724 url = factory.pick_ip_in_Subnet(accessible_subnet)724 url = factory.pick_ip_in_Subnet(accessible_subnet)
725 mock_getaddr_info = self.patch(node_module.socket, "getaddrinfo")725 mock_getaddr_info = self.patch(node_module.socket, "getaddrinfo")
726 mock_getaddr_info.return_value = (("", "", "", "", (url,)),)726 mock_getaddr_info.return_value = (("", "", "", "", (url,)),)
727 self.assertEquals(727 self.assertEqual(
728 None, RackController.objects.get_accessible_by_url(url, False)728 None, RackController.objects.get_accessible_by_url(url, False)
729 )729 )
730730
@@ -769,7 +769,7 @@ class TestRegionControllerManager(MAASServerTestCase):
769 config_uuid = Config.objects.get_config("uuid")769 config_uuid = Config.objects.get_config("uuid")
770 self.assertThat(region_running, IsInstance(RegionController))770 self.assertThat(region_running, IsInstance(RegionController))
771 self.assertThat(region_running, Equals(region))771 self.assertThat(region_running, Equals(region))
772 self.assertEquals(created_uuid, config_uuid)772 self.assertEqual(created_uuid, config_uuid)
773773
774 def test_get_or_create_uuid_returns_stored_uuid(self):774 def test_get_or_create_uuid_returns_stored_uuid(self):
775 region = factory.make_RegionController()775 region = factory.make_RegionController()
@@ -783,8 +783,8 @@ class TestRegionControllerManager(MAASServerTestCase):
783 stored_uuid = RegionController.objects.get_or_create_uuid()783 stored_uuid = RegionController.objects.get_or_create_uuid()
784 self.assertThat(region_running, IsInstance(RegionController))784 self.assertThat(region_running, IsInstance(RegionController))
785 self.assertThat(region_running, Equals(region))785 self.assertThat(region_running, Equals(region))
786 self.assertEquals(stored_uuid, config_uuid)786 self.assertEqual(stored_uuid, config_uuid)
787 self.assertEquals(created_uuid, stored_uuid)787 self.assertEqual(created_uuid, stored_uuid)
788788
789789
790class TestRegionControllerManagerGetOrCreateRunningController(790class TestRegionControllerManagerGetOrCreateRunningController(
@@ -930,7 +930,7 @@ class TestRegionControllerManagerGetOrCreateRunningController(
930930
931 def assertControllerCreated(self, region):931 def assertControllerCreated(self, region):
932 # A controller is created and it is always a region controller.932 # A controller is created and it is always a region controller.
933 self.assertEquals(NODE_TYPE.REGION_CONTROLLER, region.node_type)933 self.assertEqual(NODE_TYPE.REGION_CONTROLLER, region.node_type)
934 # It's a fresh controller so the worker user is always owner.934 # It's a fresh controller so the worker user is always owner.
935 self.assertThat(region.owner, Equals(get_worker_user()))935 self.assertThat(region.owner, Equals(get_worker_user()))
936936
@@ -955,7 +955,7 @@ class TestRegionControllerManagerGetOrCreateRunningController(
955955
956 def assertControllerNotDiscovered(self, region, host):956 def assertControllerNotDiscovered(self, region, host):
957 # A controller is created and it is always a region controller.957 # A controller is created and it is always a region controller.
958 self.assertEquals(NODE_TYPE.REGION_CONTROLLER, region.node_type)958 self.assertEqual(NODE_TYPE.REGION_CONTROLLER, region.node_type)
959 # It's new; the primary key differs from the host we planted.959 # It's new; the primary key differs from the host we planted.
960 self.assertThat(region.id, Not(Equals(host.id)))960 self.assertThat(region.id, Not(Equals(host.id)))
961 # It's a fresh controller so the worker user is always owner.961 # It's a fresh controller so the worker user is always owner.
@@ -3570,8 +3570,8 @@ class TestNode(MAASServerTestCase):
3570 user=admin,3570 user=admin,
3571 commissioning_scripts=[script.name],3571 commissioning_scripts=[script.name],
3572 )3572 )
3573 self.assertEquals(0, ScriptSet.objects.count())3573 self.assertEqual(0, ScriptSet.objects.count())
3574 self.assertEquals(0, ScriptResult.objects.count())3574 self.assertEqual(0, ScriptResult.objects.count())
35753575
3576 def test_start_commissioning_fails_on_xenial_with_network_testing_t(self):3576 def test_start_commissioning_fails_on_xenial_with_network_testing_t(self):
3577 Config.objects.set_config("commissioning_distro_series", "xenial")3577 Config.objects.set_config("commissioning_distro_series", "xenial")
@@ -3586,8 +3586,8 @@ class TestNode(MAASServerTestCase):
3586 user=admin,3586 user=admin,
3587 testing_scripts=[script.name],3587 testing_scripts=[script.name],
3588 )3588 )
3589 self.assertEquals(0, ScriptSet.objects.count())3589 self.assertEqual(0, ScriptSet.objects.count())
3590 self.assertEquals(0, ScriptResult.objects.count())3590 self.assertEqual(0, ScriptResult.objects.count())
35913591
3592 def test_abort_commissioning_reverts_to_sane_state_on_error(self):3592 def test_abort_commissioning_reverts_to_sane_state_on_error(self):
3593 # If abort commissioning hits an error when trying to stop the3593 # If abort commissioning hits an error when trying to stop the
@@ -3830,7 +3830,7 @@ class TestNode(MAASServerTestCase):
3830 node.start_testing(admin, testing_scripts=[script.name])3830 node.start_testing(admin, testing_scripts=[script.name])
3831 post_commit_hooks.reset() # Ignore these for now.3831 post_commit_hooks.reset() # Ignore these for now.
3832 node = reload_object(node)3832 node = reload_object(node)
3833 self.assertEquals(NODE_STATUS.TESTING, node.status)3833 self.assertEqual(NODE_STATUS.TESTING, node.status)
3834 self.assertThat(mock_node_start, MockCalledOnce())3834 self.assertThat(mock_node_start, MockCalledOnce())
38353835
3836 def test_start_testing_changes_status_and_starts_new_node(self):3836 def test_start_testing_changes_status_and_starts_new_node(self):
@@ -3850,7 +3850,7 @@ class TestNode(MAASServerTestCase):
3850 node.start_testing(admin, testing_scripts=[script.name])3850 node.start_testing(admin, testing_scripts=[script.name])
3851 post_commit_hooks.reset() # Ignore these for now.3851 post_commit_hooks.reset() # Ignore these for now.
3852 node = reload_object(node)3852 node = reload_object(node)
3853 self.assertEquals(NODE_STATUS.TESTING, node.status)3853 self.assertEqual(NODE_STATUS.TESTING, node.status)
3854 self.assertThat(mock_node_start, MockCalledOnce())3854 self.assertThat(mock_node_start, MockCalledOnce())
38553855
3856 def test_start_testing_sets_options(self):3856 def test_start_testing_sets_options(self):
@@ -3870,7 +3870,7 @@ class TestNode(MAASServerTestCase):
3870 )3870 )
3871 post_commit_hooks.reset() # Ignore these for now.3871 post_commit_hooks.reset() # Ignore these for now.
3872 node = reload_object(node)3872 node = reload_object(node)
3873 self.assertEquals(enable_ssh, node.enable_ssh)3873 self.assertEqual(enable_ssh, node.enable_ssh)
38743874
3875 def test_start_testing_sets_user_data(self):3875 def test_start_testing_sets_user_data(self):
3876 script = factory.make_Script(script_type=SCRIPT_TYPE.TESTING)3876 script = factory.make_Script(script_type=SCRIPT_TYPE.TESTING)
@@ -4065,8 +4065,8 @@ class TestNode(MAASServerTestCase):
4065 admin,4065 admin,
4066 testing_scripts=[script.name],4066 testing_scripts=[script.name],
4067 )4067 )
4068 self.assertEquals(0, ScriptSet.objects.count())4068 self.assertEqual(0, ScriptSet.objects.count())
4069 self.assertEquals(0, ScriptResult.objects.count())4069 self.assertEqual(0, ScriptResult.objects.count())
40704070
4071 def test_save_logs_node_status_transition(self):4071 def test_save_logs_node_status_transition(self):
4072 self.disable_node_query()4072 self.disable_node_query()
@@ -4257,11 +4257,11 @@ class TestNode(MAASServerTestCase):
4257 node.mark_failed(script_result_status=script_result_status)4257 node.mark_failed(script_result_status=script_result_status)
42584258
4259 for script_result in updated_script_results:4259 for script_result in updated_script_results:
4260 self.assertEquals(4260 self.assertEqual(
4261 script_result_status, reload_object(script_result).status4261 script_result_status, reload_object(script_result).status
4262 )4262 )
4263 for script_result in untouched_script_results:4263 for script_result in untouched_script_results:
4264 self.assertEquals(4264 self.assertEqual(
4265 script_result.status, reload_object(script_result).status4265 script_result.status, reload_object(script_result).status
4266 )4266 )
42674267
@@ -8523,7 +8523,7 @@ class TestNode_Start(MAASTransactionServerTestCase):
8523 user, power_type="manual"8523 user, power_type="manual"
8524 )8524 )
8525 node.start(user)8525 node.start(user)
8526 self.assertEquals(NODE_STATUS.DEPLOYING, node.status)8526 self.assertEqual(NODE_STATUS.DEPLOYING, node.status)
85278527
8528 def test_creates_acquired_bridges_for_install_kvm(self):8528 def test_creates_acquired_bridges_for_install_kvm(self):
8529 user = factory.make_User()8529 user = factory.make_User()
@@ -8543,11 +8543,11 @@ class TestNode_Start(MAASTransactionServerTestCase):
8543 node = reload_object(node)8543 node = reload_object(node)
8544 bridge = BridgeInterface.objects.get(node=node)8544 bridge = BridgeInterface.objects.get(node=node)
8545 interface = node.interface_set.first()8545 interface = node.interface_set.first()
8546 self.assertEquals(NODE_STATUS.DEPLOYING, node.status)8546 self.assertEqual(NODE_STATUS.DEPLOYING, node.status)
8547 self.assertEquals(bridge.mac_address, interface.mac_address)8547 self.assertEqual(bridge.mac_address, interface.mac_address)
8548 self.assertEquals(bridge.params["bridge_type"], bridge_type)8548 self.assertEqual(bridge.params["bridge_type"], bridge_type)
8549 self.assertEquals(bridge.params["bridge_stp"], bridge_stp)8549 self.assertEqual(bridge.params["bridge_stp"], bridge_stp)
8550 self.assertEquals(bridge.params["bridge_fd"], bridge_fd)8550 self.assertEqual(bridge.params["bridge_fd"], bridge_fd)
8551 self.assertTrue(node.install_kvm)8551 self.assertTrue(node.install_kvm)
85528552
8553 def test_doesnt_change_broken(self):8553 def test_doesnt_change_broken(self):
@@ -8558,7 +8558,7 @@ class TestNode_Start(MAASTransactionServerTestCase):
8558 node.status = NODE_STATUS.BROKEN8558 node.status = NODE_STATUS.BROKEN
8559 node.save()8559 node.save()
8560 node.start(user)8560 node.start(user)
8561 self.assertEquals(NODE_STATUS.BROKEN, node.status)8561 self.assertEqual(NODE_STATUS.BROKEN, node.status)
85628562
8563 def test_claims_auto_ip_addresses(self):8563 def test_claims_auto_ip_addresses(self):
8564 user = factory.make_User()8564 user = factory.make_User()
@@ -9136,14 +9136,14 @@ class TestNode_Start(MAASTransactionServerTestCase):
9136 name=EVENT_TYPES.NODE_POWER_QUERY_FAILED9136 name=EVENT_TYPES.NODE_POWER_QUERY_FAILED
9137 )9137 )
9138 event = node.event_set.get(type=event_type)9138 event = node.event_set.get(type=event_type)
9139 self.assertEquals(9139 self.assertEqual(
9140 "(%s) - Aborting NEW and reverting to NEW. Unable to power "9140 "(%s) - Aborting NEW and reverting to NEW. Unable to power "
9141 "control the node. Please check power credentials." % user,9141 "control the node. Please check power credentials." % user,
9142 event.description,9142 event.description,
9143 )9143 )
91449144
9145 for script_result in script_results:9145 for script_result in script_results:
9146 self.assertEquals(9146 self.assertEqual(
9147 SCRIPT_STATUS.ABORTED, reload_object(script_result).status9147 SCRIPT_STATUS.ABORTED, reload_object(script_result).status
9148 )9148 )
91499149
@@ -9220,7 +9220,7 @@ class TestGetBMCClientConnectionInfo(MAASServerTestCase):
9220 fallback.system_id = fake_fallback_id9220 fallback.system_id = fake_fallback_id
9221 mock_fallbacks.return_value = [fallback]9221 mock_fallbacks.return_value = [fallback]
92229222
9223 self.assertEquals(9223 self.assertEqual(
9224 ([fake_bmc_id], [fake_fallback_id]),9224 ([fake_bmc_id], [fake_fallback_id]),
9225 node._get_bmc_client_connection_info(),9225 node._get_bmc_client_connection_info(),
9226 )9226 )
@@ -9233,7 +9233,7 @@ class TestGetBMCClientConnectionInfo(MAASServerTestCase):
9233 name=EVENT_TYPES.NODE_POWER_QUERY_FAILED9233 name=EVENT_TYPES.NODE_POWER_QUERY_FAILED
9234 )9234 )
9235 event = node.event_set.get(type=event_type)9235 event = node.event_set.get(type=event_type)
9236 self.assertEquals(9236 self.assertEqual(
9237 (9237 (
9238 "No rack controllers can access the BMC of node %s"9238 "No rack controllers can access the BMC of node %s"
9239 % node.hostname9239 % node.hostname
@@ -13807,7 +13807,7 @@ class TestRackController(MAASTransactionServerTestCase):
13807 )13807 )
13808 system_id = region_and_rack.system_id13808 system_id = region_and_rack.system_id
13809 region_and_rack.as_rack_controller().delete()13809 region_and_rack.as_rack_controller().delete()
13810 self.assertEquals(13810 self.assertEqual(
13811 NODE_TYPE.REGION_CONTROLLER,13811 NODE_TYPE.REGION_CONTROLLER,
13812 Node.objects.get(system_id=system_id).node_type,13812 Node.objects.get(system_id=system_id).node_type,
13813 )13813 )
@@ -13817,7 +13817,7 @@ class TestRackController(MAASTransactionServerTestCase):
13817 rack.bmc = factory.make_BMC()13817 rack.bmc = factory.make_BMC()
13818 rack.save()13818 rack.save()
13819 rack.delete()13819 rack.delete()
13820 self.assertEquals(13820 self.assertEqual(
13821 NODE_TYPE.MACHINE,13821 NODE_TYPE.MACHINE,
13822 Node.objects.get(system_id=rack.system_id).node_type,13822 Node.objects.get(system_id=rack.system_id).node_type,
13823 )13823 )
@@ -13927,16 +13927,16 @@ class TestRackController(MAASTransactionServerTestCase):
13927 images = rack_controller.list_boot_images()13927 images = rack_controller.list_boot_images()
13928 self.assertTrue(images["connected"])13928 self.assertTrue(images["connected"])
13929 self.assertItemsEqual(self.expected_images, images["images"])13929 self.assertItemsEqual(self.expected_images, images["images"])
13930 self.assertEquals("synced", images["status"])13930 self.assertEqual("synced", images["status"])
13931 self.assertEquals("synced", rack_controller.get_image_sync_status())13931 self.assertEqual("synced", rack_controller.get_image_sync_status())
1393213932
13933 def test_list_boot_images_when_disconnected(self):13933 def test_list_boot_images_when_disconnected(self):
13934 rack_controller = factory.make_RackController()13934 rack_controller = factory.make_RackController()
13935 images = rack_controller.list_boot_images()13935 images = rack_controller.list_boot_images()
13936 self.assertEquals(False, images["connected"])13936 self.assertEqual(False, images["connected"])
13937 self.assertItemsEqual([], images["images"])13937 self.assertItemsEqual([], images["images"])
13938 self.assertEquals("unknown", images["status"])13938 self.assertEqual("unknown", images["status"])
13939 self.assertEquals("unknown", rack_controller.get_image_sync_status())13939 self.assertEqual("unknown", rack_controller.get_image_sync_status())
1394013940
13941 def test_list_boot_images_when_connection_closed(self):13941 def test_list_boot_images_when_connection_closed(self):
13942 rack_controller = factory.make_RackController()13942 rack_controller = factory.make_RackController()
@@ -13944,10 +13944,10 @@ class TestRackController(MAASTransactionServerTestCase):
13944 boot_images, "get_boot_images"13944 boot_images, "get_boot_images"
13945 ).side_effect = ConnectionClosed()13945 ).side_effect = ConnectionClosed()
13946 images = rack_controller.list_boot_images()13946 images = rack_controller.list_boot_images()
13947 self.assertEquals(False, images["connected"])13947 self.assertEqual(False, images["connected"])
13948 self.assertItemsEqual([], images["images"])13948 self.assertItemsEqual([], images["images"])
13949 self.assertEquals("unknown", images["status"])13949 self.assertEqual("unknown", images["status"])
13950 self.assertEquals("unknown", rack_controller.get_image_sync_status())13950 self.assertEqual("unknown", rack_controller.get_image_sync_status())
1395113951
13952 def test_list_boot_images_region_importing(self):13952 def test_list_boot_images_region_importing(self):
13953 rack_controller = factory.make_RackController()13953 rack_controller = factory.make_RackController()
@@ -13962,8 +13962,8 @@ class TestRackController(MAASTransactionServerTestCase):
13962 self.assertThat(fake_is_import_resources_running, MockCalledOnce())13962 self.assertThat(fake_is_import_resources_running, MockCalledOnce())
13963 self.assertTrue(images["connected"])13963 self.assertTrue(images["connected"])
13964 self.assertItemsEqual(self.expected_images, images["images"])13964 self.assertItemsEqual(self.expected_images, images["images"])
13965 self.assertEquals("region-importing", images["status"])13965 self.assertEqual("region-importing", images["status"])
13966 self.assertEquals(13966 self.assertEqual(
13967 "region-importing", rack_controller.get_image_sync_status()13967 "region-importing", rack_controller.get_image_sync_status()
13968 )13968 )
1396913969
@@ -13981,8 +13981,8 @@ class TestRackController(MAASTransactionServerTestCase):
13981 images = rack_controller.list_boot_images()13981 images = rack_controller.list_boot_images()
13982 self.assertTrue(images["connected"])13982 self.assertTrue(images["connected"])
13983 self.assertItemsEqual(self.expected_images, images["images"])13983 self.assertItemsEqual(self.expected_images, images["images"])
13984 self.assertEquals("syncing", images["status"])13984 self.assertEqual("syncing", images["status"])
13985 self.assertEquals("syncing", rack_controller.get_image_sync_status())13985 self.assertEqual("syncing", rack_controller.get_image_sync_status())
1398613986
13987 def test_list_boot_images_out_of_sync(self):13987 def test_list_boot_images_out_of_sync(self):
13988 rack_controller = factory.make_RackController()13988 rack_controller = factory.make_RackController()
@@ -13998,8 +13998,8 @@ class TestRackController(MAASTransactionServerTestCase):
13998 images = rack_controller.list_boot_images()13998 images = rack_controller.list_boot_images()
13999 self.assertTrue(images["connected"])13999 self.assertTrue(images["connected"])
14000 self.assertItemsEqual(self.expected_images, images["images"])14000 self.assertItemsEqual(self.expected_images, images["images"])
14001 self.assertEquals("out-of-sync", images["status"])14001 self.assertEqual("out-of-sync", images["status"])
14002 self.assertEquals(14002 self.assertEqual(
14003 "out-of-sync", rack_controller.get_image_sync_status()14003 "out-of-sync", rack_controller.get_image_sync_status()
14004 )14004 )
1400514005
@@ -14015,7 +14015,7 @@ class TestRackController(MAASTransactionServerTestCase):
14015 images = rack_controller.list_boot_images()14015 images = rack_controller.list_boot_images()
14016 self.assertTrue(images["connected"])14016 self.assertTrue(images["connected"])
14017 self.assertItemsEqual([], images["images"])14017 self.assertItemsEqual([], images["images"])
14018 self.assertEquals("syncing", images["status"])14018 self.assertEqual("syncing", images["status"])
1401914019
14020 def test_is_import_images_running(self):14020 def test_is_import_images_running(self):
14021 running = factory.pick_bool()14021 running = factory.pick_bool()
@@ -14029,7 +14029,7 @@ class TestRackController(MAASTransactionServerTestCase):
14029 protocol.IsImportBootImagesRunning.return_value = defer.succeed(14029 protocol.IsImportBootImagesRunning.return_value = defer.succeed(
14030 {"running": running}14030 {"running": running}
14031 )14031 )
14032 self.assertEquals(14032 self.assertEqual(
14033 running, rackcontroller.is_import_boot_images_running()14033 running, rackcontroller.is_import_boot_images_running()
14034 )14034 )
1403514035
@@ -14045,7 +14045,7 @@ class TestRegionController(MAASServerTestCase):
14045 node_type=NODE_TYPE.REGION_AND_RACK_CONTROLLER14045 node_type=NODE_TYPE.REGION_AND_RACK_CONTROLLER
14046 )14046 )
14047 region_and_rack.as_region_controller().delete()14047 region_and_rack.as_region_controller().delete()
14048 self.assertEquals(14048 self.assertEqual(
14049 NODE_TYPE.RACK_CONTROLLER,14049 NODE_TYPE.RACK_CONTROLLER,
14050 Node.objects.get(system_id=region_and_rack.system_id).node_type,14050 Node.objects.get(system_id=region_and_rack.system_id).node_type,
14051 )14051 )
@@ -14055,7 +14055,7 @@ class TestRegionController(MAASServerTestCase):
14055 region.bmc = factory.make_BMC()14055 region.bmc = factory.make_BMC()
14056 region.save()14056 region.save()
14057 region.delete()14057 region.delete()
14058 self.assertEquals(14058 self.assertEqual(
14059 NODE_TYPE.MACHINE,14059 NODE_TYPE.MACHINE,
14060 Node.objects.get(system_id=region.system_id).node_type,14060 Node.objects.get(system_id=region.system_id).node_type,
14061 )14061 )
@@ -15021,7 +15021,7 @@ class TestNodeInterfaceClone__MappingBetweenNodes(MAASServerTestCase):
15021 error = self.assertRaises(15021 error = self.assertRaises(
15022 ValidationError, node2._get_interface_mapping_between_nodes, node115022 ValidationError, node2._get_interface_mapping_between_nodes, node1
15023 )15023 )
15024 self.assertEquals(15024 self.assertEqual(
15025 "destination node physical interfaces do not match the "15025 "destination node physical interfaces do not match the "
15026 "source nodes physical interfaces: other, match",15026 "source nodes physical interfaces: other, match",
15027 error.message,15027 error.message,
diff --git a/src/maasserver/models/tests/test_ownerdata.py b/src/maasserver/models/tests/test_ownerdata.py
index af3087e..0877e8a 100644
--- a/src/maasserver/models/tests/test_ownerdata.py
+++ b/src/maasserver/models/tests/test_ownerdata.py
@@ -23,7 +23,7 @@ class TestOwnerData(MAASServerTestCase):
23 for _ in range(3)23 for _ in range(3)
24 }24 }
25 OwnerData.objects.set_owner_data(node, owner_data)25 OwnerData.objects.set_owner_data(node, owner_data)
26 self.assertEquals(owner_data, self.get_owner_data(node))26 self.assertEqual(owner_data, self.get_owner_data(node))
2727
28 def test_set_owner_data_updates_data(self):28 def test_set_owner_data_updates_data(self):
29 node = factory.make_Node()29 node = factory.make_Node()
@@ -35,7 +35,7 @@ class TestOwnerData(MAASServerTestCase):
35 for key in owner_data.keys():35 for key in owner_data.keys():
36 owner_data[key] = factory.make_name("value")36 owner_data[key] = factory.make_name("value")
37 OwnerData.objects.set_owner_data(node, owner_data)37 OwnerData.objects.set_owner_data(node, owner_data)
38 self.assertEquals(owner_data, self.get_owner_data(node))38 self.assertEqual(owner_data, self.get_owner_data(node))
3939
40 def test_set_owner_data_removes_data(self):40 def test_set_owner_data_removes_data(self):
41 node = factory.make_Node()41 node = factory.make_Node()
@@ -47,4 +47,4 @@ class TestOwnerData(MAASServerTestCase):
47 for key in owner_data.keys():47 for key in owner_data.keys():
48 owner_data[key] = None48 owner_data[key] = None
49 OwnerData.objects.set_owner_data(node, owner_data)49 OwnerData.objects.set_owner_data(node, owner_data)
50 self.assertEquals({}, self.get_owner_data(node))50 self.assertEqual({}, self.get_owner_data(node))
diff --git a/src/maasserver/models/tests/test_packagerepository.py b/src/maasserver/models/tests/test_packagerepository.py
index 3758897..ffed1d1 100644
--- a/src/maasserver/models/tests/test_packagerepository.py
+++ b/src/maasserver/models/tests/test_packagerepository.py
@@ -20,7 +20,7 @@ class TestPackageRepositoryManager(MAASServerTestCase):
20 archive = factory.make_PackageRepository(20 archive = factory.make_PackageRepository(
21 url=main_url, default=True, arches=["i386", "amd64"]21 url=main_url, default=True, arches=["i386", "amd64"]
22 )22 )
23 self.assertEquals(23 self.assertEqual(
24 archive, PackageRepository.objects.get_default_archive(arch)24 archive, PackageRepository.objects.get_default_archive(arch)
25 )25 )
2626
@@ -30,7 +30,7 @@ class TestPackageRepositoryManager(MAASServerTestCase):
30 archive = factory.make_PackageRepository(30 archive = factory.make_PackageRepository(
31 url=main_url, default=False, arches=["i386", "amd64"]31 url=main_url, default=False, arches=["i386", "amd64"]
32 )32 )
33 self.assertEquals(33 self.assertEqual(
34 archive,34 archive,
35 PackageRepository.objects.get_additional_repositories(35 PackageRepository.objects.get_additional_repositories(
36 arch36 arch
@@ -68,13 +68,13 @@ class TestPackageRepositoryManager(MAASServerTestCase):
68 archive = factory.make_PackageRepository(68 archive = factory.make_PackageRepository(
69 url=url, default=False, arches=[arch, factory.make_name()]69 url=url, default=False, arches=[arch, factory.make_name()]
70 )70 )
71 self.assertEquals(71 self.assertEqual(
72 ppa_archive,72 ppa_archive,
73 PackageRepository.objects.get_additional_repositories(73 PackageRepository.objects.get_additional_repositories(
74 ppa_arch74 ppa_arch
75 ).first(),75 ).first(),
76 )76 )
77 self.assertEquals(77 self.assertEqual(
78 archive,78 archive,
79 PackageRepository.objects.get_additional_repositories(79 PackageRepository.objects.get_additional_repositories(
80 arch80 arch
diff --git a/src/maasserver/models/tests/test_partitiontable.py b/src/maasserver/models/tests/test_partitiontable.py
index 9544ed1..ae1b9c7 100644
--- a/src/maasserver/models/tests/test_partitiontable.py
+++ b/src/maasserver/models/tests/test_partitiontable.py
@@ -163,7 +163,7 @@ class TestPartitionTable(MAASServerTestCase):
163 partition_table = factory.make_PartitionTable(163 partition_table = factory.make_PartitionTable(
164 block_device=block_device164 block_device=block_device
165 )165 )
166 self.assertEquals(166 self.assertEqual(
167 PARTITION_TABLE_EXTRA_SPACE, partition_table.get_overhead_size()167 PARTITION_TABLE_EXTRA_SPACE, partition_table.get_overhead_size()
168 )168 )
169169
@@ -173,7 +173,7 @@ class TestPartitionTable(MAASServerTestCase):
173 partition_table = factory.make_PartitionTable(173 partition_table = factory.make_PartitionTable(
174 block_device=block_device174 block_device=block_device
175 )175 )
176 self.assertEquals(176 self.assertEqual(
177 PARTITION_TABLE_EXTRA_SPACE + PREP_PARTITION_SIZE,177 PARTITION_TABLE_EXTRA_SPACE + PREP_PARTITION_SIZE,
178 partition_table.get_overhead_size(),178 partition_table.get_overhead_size(),
179 )179 )
@@ -186,7 +186,7 @@ class TestPartitionTable(MAASServerTestCase):
186 partition_table = factory.make_PartitionTable(186 partition_table = factory.make_PartitionTable(
187 block_device=block_device187 block_device=block_device
188 )188 )
189 self.assertEquals(189 self.assertEqual(
190 PARTITION_TABLE_EXTRA_SPACE + BIOS_GRUB_PARTITION_SIZE,190 PARTITION_TABLE_EXTRA_SPACE + BIOS_GRUB_PARTITION_SIZE,
191 partition_table.get_overhead_size(),191 partition_table.get_overhead_size(),
192 )192 )
diff --git a/src/maasserver/models/tests/test_podstoragepool.py b/src/maasserver/models/tests/test_podstoragepool.py
index 2af4f68..bfc406b 100644
--- a/src/maasserver/models/tests/test_podstoragepool.py
+++ b/src/maasserver/models/tests/test_podstoragepool.py
@@ -15,8 +15,8 @@ class TestPodStoragePool(MAASServerTestCase):
15 for _ in range(3):15 for _ in range(3):
16 bd = factory.make_PhysicalBlockDevice(storage_pool=pool)16 bd = factory.make_PhysicalBlockDevice(storage_pool=pool)
17 size += bd.size17 size += bd.size
18 self.assertEquals(size, pool.get_used_storage())18 self.assertEqual(size, pool.get_used_storage())
1919
20 def test_get_used_storage_returns_zero(self):20 def test_get_used_storage_returns_zero(self):
21 pool = factory.make_PodStoragePool()21 pool = factory.make_PodStoragePool()
22 self.assertEquals(0, pool.get_used_storage())22 self.assertEqual(0, pool.get_used_storage())
diff --git a/src/maasserver/models/tests/test_versionedtextfile.py b/src/maasserver/models/tests/test_versionedtextfile.py
index e74e7ce..2e208ba 100644
--- a/src/maasserver/models/tests/test_versionedtextfile.py
+++ b/src/maasserver/models/tests/test_versionedtextfile.py
@@ -95,7 +95,7 @@ class VersionedTextFileTest(MAASServerTestCase):
95 for _ in range(10):95 for _ in range(10):
96 textfile = textfile.update(factory.make_string())96 textfile = textfile.update(factory.make_string())
97 textfile_ids.append(textfile.id)97 textfile_ids.append(textfile.id)
98 self.assertEquals(textfile, textfile.revert(0))98 self.assertEqual(textfile, textfile.revert(0))
99 self.assertItemsEqual(99 self.assertItemsEqual(
100 textfile_ids, [f.id for f in textfile.previous_versions()]100 textfile_ids, [f.id for f in textfile.previous_versions()]
101 )101 )
@@ -110,7 +110,7 @@ class VersionedTextFileTest(MAASServerTestCase):
110 revert_to = random.randint(-10, -1)110 revert_to = random.randint(-10, -1)
111 reverted_ids = textfile_ids[revert_to:]111 reverted_ids = textfile_ids[revert_to:]
112 remaining_ids = textfile_ids[:revert_to]112 remaining_ids = textfile_ids[:revert_to]
113 self.assertEquals(113 self.assertEqual(
114 textfile_ids[revert_to - 1], textfile.revert(revert_to).id114 textfile_ids[revert_to - 1], textfile.revert(revert_to).id
115 )115 )
116 for i in reverted_ids:116 for i in reverted_ids:
@@ -130,7 +130,7 @@ class VersionedTextFileTest(MAASServerTestCase):
130 textfile = textfile.update(factory.make_string())130 textfile = textfile.update(factory.make_string())
131 textfile_ids.append(textfile.id)131 textfile_ids.append(textfile.id)
132 revert_to = random.randint(-10, -1)132 revert_to = random.randint(-10, -1)
133 self.assertEquals(133 self.assertEqual(
134 textfile_ids[revert_to - 1], textfile.revert(revert_to, False).id134 textfile_ids[revert_to - 1], textfile.revert(revert_to, False).id
135 )135 )
136 for i in textfile_ids:136 for i in textfile_ids:
@@ -160,7 +160,7 @@ class VersionedTextFileTest(MAASServerTestCase):
160 reverted_or_remaining.append(i)160 reverted_or_remaining.append(i)
161 if i == revert_to:161 if i == revert_to:
162 reverted_or_remaining = reverted_ids162 reverted_or_remaining = reverted_ids
163 self.assertEquals(163 self.assertEqual(
164 VersionedTextFile.objects.get(id=revert_to),164 VersionedTextFile.objects.get(id=revert_to),
165 textfile.revert(revert_to),165 textfile.revert(revert_to),
166 )166 )
@@ -181,7 +181,7 @@ class VersionedTextFileTest(MAASServerTestCase):
181 textfile = textfile.update(factory.make_string())181 textfile = textfile.update(factory.make_string())
182 textfile_ids.append(textfile.id)182 textfile_ids.append(textfile.id)
183 revert_to = random.choice(textfile_ids)183 revert_to = random.choice(textfile_ids)
184 self.assertEquals(184 self.assertEqual(
185 VersionedTextFile.objects.get(id=revert_to),185 VersionedTextFile.objects.get(id=revert_to),
186 textfile.revert(revert_to, False),186 textfile.revert(revert_to, False),
187 )187 )
@@ -232,13 +232,13 @@ class VersionedTextFileTest(MAASServerTestCase):
232 textfile = VersionedTextFile.objects.create(232 textfile = VersionedTextFile.objects.create(
233 data='#!/bin/sh\r\necho "Created on Windows!"\r\n'233 data='#!/bin/sh\r\necho "Created on Windows!"\r\n'
234 )234 )
235 self.assertEquals(235 self.assertEqual(
236 '#!/bin/sh\necho "Created on Windows!"\n', textfile.data236 '#!/bin/sh\necho "Created on Windows!"\n', textfile.data
237 )237 )
238 updated_textfile = textfile.update(238 updated_textfile = textfile.update(
239 '#!/bin/sh\r\necho "Updated on Windows!"\r\n'239 '#!/bin/sh\r\necho "Updated on Windows!"\r\n'
240 )240 )
241 self.assertNotEquals(textfile, updated_textfile)241 self.assertNotEquals(textfile, updated_textfile)
242 self.assertEquals(242 self.assertEqual(
243 '#!/bin/sh\necho "Updated on Windows!"\n', updated_textfile.data243 '#!/bin/sh\necho "Updated on Windows!"\n', updated_textfile.data
244 )244 )
diff --git a/src/maasserver/prometheus/tests/test_stats.py b/src/maasserver/prometheus/tests/test_stats.py
index 235fd86..b37a1a5 100644
--- a/src/maasserver/prometheus/tests/test_stats.py
+++ b/src/maasserver/prometheus/tests/test_stats.py
@@ -44,14 +44,14 @@ class TestPrometheusHandler(MAASServerTestCase):
44 self.patch(stats, "PROMETHEUS_SUPPORTED", True)44 self.patch(stats, "PROMETHEUS_SUPPORTED", True)
45 response = self.client.get(reverse("metrics"))45 response = self.client.get(reverse("metrics"))
46 self.assertEqual("text/html; charset=utf-8", response["Content-Type"])46 self.assertEqual("text/html; charset=utf-8", response["Content-Type"])
47 self.assertEquals(response.status_code, http.client.NOT_FOUND)47 self.assertEqual(response.status_code, http.client.NOT_FOUND)
4848
49 def test_prometheus_stats_handler_not_found_not_supported(self):49 def test_prometheus_stats_handler_not_found_not_supported(self):
50 Config.objects.set_config("prometheus_enabled", True)50 Config.objects.set_config("prometheus_enabled", True)
51 self.patch(stats, "PROMETHEUS_SUPPORTED", False)51 self.patch(stats, "PROMETHEUS_SUPPORTED", False)
52 response = self.client.get(reverse("metrics"))52 response = self.client.get(reverse("metrics"))
53 self.assertEqual("text/html; charset=utf-8", response["Content-Type"])53 self.assertEqual("text/html; charset=utf-8", response["Content-Type"])
54 self.assertEquals(response.status_code, http.client.NOT_FOUND)54 self.assertEqual(response.status_code, http.client.NOT_FOUND)
5555
56 def test_prometheus_stats_handler_returns_success(self):56 def test_prometheus_stats_handler_returns_success(self):
57 Config.objects.set_config("prometheus_enabled", True)57 Config.objects.set_config("prometheus_enabled", True)
@@ -59,7 +59,7 @@ class TestPrometheusHandler(MAASServerTestCase):
59 mock_prom_cli.generate_latest.return_value = {}59 mock_prom_cli.generate_latest.return_value = {}
60 response = self.client.get(reverse("metrics"))60 response = self.client.get(reverse("metrics"))
61 self.assertEqual("text/plain", response["Content-Type"])61 self.assertEqual("text/plain", response["Content-Type"])
62 self.assertEquals(response.status_code, http.client.OK)62 self.assertEqual(response.status_code, http.client.OK)
6363
64 def test_prometheus_stats_handler_returns_metrics(self):64 def test_prometheus_stats_handler_returns_metrics(self):
65 Config.objects.set_config("prometheus_enabled", True)65 Config.objects.set_config("prometheus_enabled", True)
diff --git a/src/maasserver/rpc/tests/test_boot.py b/src/maasserver/rpc/tests/test_boot.py
index 1e19ada..1dbb43b 100644
--- a/src/maasserver/rpc/tests/test_boot.py
+++ b/src/maasserver/rpc/tests/test_boot.py
@@ -223,7 +223,7 @@ class TestGetConfig(MAASServerTestCase):
223 mac=mac,223 mac=mac,
224 query_count=9,224 query_count=9,
225 )225 )
226 self.assertEquals(226 self.assertEqual(
227 {227 {
228 "system_id": node.system_id,228 "system_id": node.system_id,
229 "arch": node.split_arch()[0],229 "arch": node.split_arch()[0],
@@ -268,7 +268,7 @@ class TestGetConfig(MAASServerTestCase):
268 mac=mac,268 mac=mac,
269 query_count=9,269 query_count=9,
270 )270 )
271 self.assertEquals(271 self.assertEqual(
272 {272 {
273 "system_id": node.system_id,273 "system_id": node.system_id,
274 "arch": node.split_arch()[0],274 "arch": node.split_arch()[0],
@@ -312,7 +312,7 @@ class TestGetConfig(MAASServerTestCase):
312 mac=mac,312 mac=mac,
313 query_count=8,313 query_count=8,
314 )314 )
315 self.assertEquals(315 self.assertEqual(
316 {316 {
317 "system_id": device.system_id,317 "system_id": device.system_id,
318 "arch": device.split_arch()[0],318 "arch": device.split_arch()[0],
@@ -360,7 +360,7 @@ class TestGetConfig(MAASServerTestCase):
360 config = get_config(360 config = get_config(
361 rack_controller.system_id, local_ip, remote_ip, mac=mac361 rack_controller.system_id, local_ip, remote_ip, mac=mac
362 )362 )
363 self.assertEquals(config["purpose"], "xinstall")363 self.assertEqual(config["purpose"], "xinstall")
364364
365 def test_returns_kparams_for_known_node(self):365 def test_returns_kparams_for_known_node(self):
366 rack_controller = factory.make_RackController()366 rack_controller = factory.make_RackController()
@@ -1403,19 +1403,19 @@ class TestGetBootFilenames(MAASServerTestCase):
1403 arch, subarch, osystem, series1403 arch, subarch, osystem, series
1404 )1404 )
14051405
1406 self.assertEquals(1406 self.assertEqual(
1407 boot_resource_set.files.get(1407 boot_resource_set.files.get(
1408 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL1408 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL
1409 ).filename,1409 ).filename,
1410 kernel,1410 kernel,
1411 )1411 )
1412 self.assertEquals(1412 self.assertEqual(
1413 boot_resource_set.files.get(1413 boot_resource_set.files.get(
1414 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD1414 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD
1415 ).filename,1415 ).filename,
1416 initrd,1416 initrd,
1417 )1417 )
1418 self.assertEquals(1418 self.assertEqual(
1419 boot_resource_set.files.get(1419 boot_resource_set.files.get(
1420 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB1420 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB
1421 ).filename,1421 ).filename,
@@ -1435,19 +1435,19 @@ class TestGetBootFilenames(MAASServerTestCase):
1435 arch, "generic", osystem, series1435 arch, "generic", osystem, series
1436 )1436 )
14371437
1438 self.assertEquals(1438 self.assertEqual(
1439 boot_resource_set.files.get(1439 boot_resource_set.files.get(
1440 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL1440 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL
1441 ).filename,1441 ).filename,
1442 kernel,1442 kernel,
1443 )1443 )
1444 self.assertEquals(1444 self.assertEqual(
1445 boot_resource_set.files.get(1445 boot_resource_set.files.get(
1446 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD1446 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD
1447 ).filename,1447 ).filename,
1448 initrd,1448 initrd,
1449 )1449 )
1450 self.assertEquals(1450 self.assertEqual(
1451 boot_resource_set.files.get(1451 boot_resource_set.files.get(
1452 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB1452 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB
1453 ).filename,1453 ).filename,
@@ -1486,13 +1486,13 @@ class TestGetBootFilenames(MAASServerTestCase):
1486 arch, subarch, osystem, series1486 arch, subarch, osystem, series
1487 )1487 )
14881488
1489 self.assertEquals(1489 self.assertEqual(
1490 boot_resource_set.files.get(1490 boot_resource_set.files.get(
1491 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL1491 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL
1492 ).filename,1492 ).filename,
1493 kernel,1493 kernel,
1494 )1494 )
1495 self.assertEquals(1495 self.assertEqual(
1496 boot_resource_set.files.get(1496 boot_resource_set.files.get(
1497 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD1497 filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD
1498 ).filename,1498 ).filename,
diff --git a/src/maasserver/rpc/tests/test_leases.py b/src/maasserver/rpc/tests/test_leases.py
index cb81a6e..134ecef 100644
--- a/src/maasserver/rpc/tests/test_leases.py
+++ b/src/maasserver/rpc/tests/test_leases.py
@@ -71,14 +71,12 @@ class TestUpdateLease(MAASServerTestCase):
71 action = factory.make_name("action")71 action = factory.make_name("action")
72 kwargs = self.make_kwargs(action=action)72 kwargs = self.make_kwargs(action=action)
73 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)73 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)
74 self.assertEquals("Unknown lease action: %s" % action, str(error))74 self.assertEqual("Unknown lease action: %s" % action, str(error))
7575
76 def test_raises_LeaseUpdateError_for_no_subnet(self):76 def test_raises_LeaseUpdateError_for_no_subnet(self):
77 kwargs = self.make_kwargs()77 kwargs = self.make_kwargs()
78 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)78 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)
79 self.assertEquals(79 self.assertEqual("No subnet exists for: %s" % kwargs["ip"], str(error))
80 "No subnet exists for: %s" % kwargs["ip"], str(error)
81 )
8280
83 def test_raises_LeaseUpdateError_for_ipv4_mismatch(self):81 def test_raises_LeaseUpdateError_for_ipv4_mismatch(self):
84 ipv6_network = factory.make_ipv6_network()82 ipv6_network = factory.make_ipv6_network()
@@ -86,7 +84,7 @@ class TestUpdateLease(MAASServerTestCase):
86 kwargs = self.make_kwargs(subnet=subnet)84 kwargs = self.make_kwargs(subnet=subnet)
87 kwargs["ip_family"] = "ipv4"85 kwargs["ip_family"] = "ipv4"
88 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)86 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)
89 self.assertEquals(87 self.assertEqual(
90 "Family for the subnet does not match. Expected: ipv4", str(error)88 "Family for the subnet does not match. Expected: ipv4", str(error)
91 )89 )
9290
@@ -96,7 +94,7 @@ class TestUpdateLease(MAASServerTestCase):
96 kwargs = self.make_kwargs(subnet=subnet)94 kwargs = self.make_kwargs(subnet=subnet)
97 kwargs["ip_family"] = "ipv6"95 kwargs["ip_family"] = "ipv6"
98 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)96 error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs)
99 self.assertEquals(97 self.assertEqual(
100 "Family for the subnet does not match. Expected: ipv6", str(error)98 "Family for the subnet does not match. Expected: ipv6", str(error)
101 )99 )
102100
@@ -140,7 +138,7 @@ class TestUpdateLease(MAASServerTestCase):
140 mac_address=kwargs["mac"]138 mac_address=kwargs["mac"]
141 ).first()139 ).first()
142 self.assertIsNotNone(unknown_interface)140 self.assertIsNotNone(unknown_interface)
143 self.assertEquals(subnet.vlan, unknown_interface.vlan)141 self.assertEqual(subnet.vlan, unknown_interface.vlan)
144 sip = unknown_interface.ip_addresses.first()142 sip = unknown_interface.ip_addresses.first()
145 self.assertIsNotNone(sip)143 self.assertIsNotNone(sip)
146 self.assertThat(144 self.assertThat(
@@ -168,7 +166,7 @@ class TestUpdateLease(MAASServerTestCase):
168 mac_address=kwargs["mac"]166 mac_address=kwargs["mac"]
169 ).first()167 ).first()
170 self.assertIsNotNone(unknown_interface)168 self.assertIsNotNone(unknown_interface)
171 self.assertEquals(subnet.vlan, unknown_interface.vlan)169 self.assertEqual(subnet.vlan, unknown_interface.vlan)
172 sip = unknown_interface.ip_addresses.first()170 sip = unknown_interface.ip_addresses.first()
173 self.assertIsNotNone(sip)171 self.assertIsNotNone(sip)
174 self.assertThat(172 self.assertThat(
@@ -198,7 +196,7 @@ class TestUpdateLease(MAASServerTestCase):
198 mac_address=kwargs["mac"]196 mac_address=kwargs["mac"]
199 ).first()197 ).first()
200 self.assertIsNotNone(unknown_interface)198 self.assertIsNotNone(unknown_interface)
201 self.assertEquals(subnet.vlan, unknown_interface.vlan)199 self.assertEqual(subnet.vlan, unknown_interface.vlan)
202 sip = unknown_interface.ip_addresses.first()200 sip = unknown_interface.ip_addresses.first()
203 self.assertIsNotNone(sip)201 self.assertIsNotNone(sip)
204 dnsrr = get_one(DNSResource.objects.filter(name=hostname))202 dnsrr = get_one(DNSResource.objects.filter(name=hostname))
@@ -232,7 +230,7 @@ class TestUpdateLease(MAASServerTestCase):
232 mac_address=kwargs["mac"]230 mac_address=kwargs["mac"]
233 ).first()231 ).first()
234 self.assertIsNotNone(unknown_interface)232 self.assertIsNotNone(unknown_interface)
235 self.assertEquals(subnet.vlan, unknown_interface.vlan)233 self.assertEqual(subnet.vlan, unknown_interface.vlan)
236 sip = unknown_interface.ip_addresses.first()234 sip = unknown_interface.ip_addresses.first()
237 self.assertIsNotNone(sip)235 self.assertIsNotNone(sip)
238 self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip)))236 self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip)))
@@ -251,7 +249,7 @@ class TestUpdateLease(MAASServerTestCase):
251 mac_address=kwargs["mac"]249 mac_address=kwargs["mac"]
252 ).first()250 ).first()
253 self.assertIsNotNone(unknown_interface)251 self.assertIsNotNone(unknown_interface)
254 self.assertEquals(subnet.vlan, unknown_interface.vlan)252 self.assertEqual(subnet.vlan, unknown_interface.vlan)
255 sip = unknown_interface.ip_addresses.first()253 sip = unknown_interface.ip_addresses.first()
256 self.assertIsNotNone(sip)254 self.assertIsNotNone(sip)
257 self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip)))255 self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip)))
diff --git a/src/maasserver/rpc/tests/test_nodes.py b/src/maasserver/rpc/tests/test_nodes.py
index 3c5acd8..89cea28 100644
--- a/src/maasserver/rpc/tests/test_nodes.py
+++ b/src/maasserver/rpc/tests/test_nodes.py
@@ -383,7 +383,7 @@ class TestListClusterNodesPowerParameters(MAASServerTestCase):
383383
384 power_parameters = list_cluster_nodes_power_parameters(rack.system_id)384 power_parameters = list_cluster_nodes_power_parameters(rack.system_id)
385 system_ids = [params["system_id"] for params in power_parameters]385 system_ids = [params["system_id"] for params in power_parameters]
386 self.assertEquals(sorted(node_ids), sorted(system_ids))386 self.assertEqual(sorted(node_ids), sorted(system_ids))
387387
388 def test_returns_unchecked_nodes_first(self):388 def test_returns_unchecked_nodes_first(self):
389 rack = factory.make_RackController(power_type="")389 rack = factory.make_RackController(power_type="")
diff --git a/src/maasserver/rpc/tests/test_rackcontrollers.py b/src/maasserver/rpc/tests/test_rackcontrollers.py
index ab90b8d..181ee77 100644
--- a/src/maasserver/rpc/tests/test_rackcontrollers.py
+++ b/src/maasserver/rpc/tests/test_rackcontrollers.py
@@ -313,7 +313,7 @@ class TestRegisterRackController(MAASServerTestCase):
313 version = "1.10.2"313 version = "1.10.2"
314 node = factory.make_Node(node_type=NODE_TYPE.MACHINE)314 node = factory.make_Node(node_type=NODE_TYPE.MACHINE)
315 register(system_id=node.system_id, version=version)315 register(system_id=node.system_id, version=version)
316 self.assertEquals(version, node.as_rack_controller().version)316 self.assertEqual(version, node.as_rack_controller().version)
317317
318 def test_updates_interfaces(self):318 def test_updates_interfaces(self):
319 # Interfaces are set on existing rack controllers.319 # Interfaces are set on existing rack controllers.
@@ -467,7 +467,7 @@ class TestUpdateForeignDHCP(MAASServerTestCase):
467 )467 )
468 dhcp_ip = factory.make_ip_address()468 dhcp_ip = factory.make_ip_address()
469 update_foreign_dhcp(rack_controller.system_id, interface.name, dhcp_ip)469 update_foreign_dhcp(rack_controller.system_id, interface.name, dhcp_ip)
470 self.assertEquals(dhcp_ip, reload_object(interface.vlan).external_dhcp)470 self.assertEqual(dhcp_ip, reload_object(interface.vlan).external_dhcp)
471471
472 def test_logs_warning_for_external_dhcp_on_interface_no_vlan(self):472 def test_logs_warning_for_external_dhcp_on_interface_no_vlan(self):
473 rack_controller = factory.make_RackController(interface=False)473 rack_controller = factory.make_RackController(interface=False)
diff --git a/src/maasserver/rpc/tests/test_regionservice.py b/src/maasserver/rpc/tests/test_regionservice.py
index 05fffaf..832e8da 100644
--- a/src/maasserver/rpc/tests/test_regionservice.py
+++ b/src/maasserver/rpc/tests/test_regionservice.py
@@ -431,7 +431,7 @@ class TestRegionServer(MAASTransactionServerTestCase):
431 "interfaces": {},431 "interfaces": {},
432 },432 },
433 )433 )
434 self.assertEquals(rack_controller.system_id, protocol.ident)434 self.assertEqual(rack_controller.system_id, protocol.ident)
435435
436 @wait_for_reactor436 @wait_for_reactor
437 @inlineCallbacks437 @inlineCallbacks
@@ -474,7 +474,7 @@ class TestRegionServer(MAASTransactionServerTestCase):
474 "interfaces": {},474 "interfaces": {},
475 },475 },
476 )476 )
477 self.assertEquals(sentinel.host, protocol.host)477 self.assertEqual(sentinel.host, protocol.host)
478478
479 @wait_for_reactor479 @wait_for_reactor
480 @inlineCallbacks480 @inlineCallbacks
@@ -538,7 +538,7 @@ class TestRegionServer(MAASTransactionServerTestCase):
538 ),538 ),
539 CannotRegisterRackController,539 CannotRegisterRackController,
540 )540 )
541 self.assertEquals(541 self.assertEqual(
542 (542 (
543 "Failed to register rack controller 'None' with the master. "543 "Failed to register rack controller 'None' with the master. "
544 "Connection will be dropped.",544 "Connection will be dropped.",
@@ -549,7 +549,7 @@ class TestRegionServer(MAASTransactionServerTestCase):
549549
550class TestRackClient(MAASTestCase):550class TestRackClient(MAASTestCase):
551 def test_defined_cache_calls(self):551 def test_defined_cache_calls(self):
552 self.assertEquals(552 self.assertEqual(
553 [cluster.DescribePowerTypes, cluster.DescribeNOSTypes],553 [cluster.DescribePowerTypes, cluster.DescribeNOSTypes],
554 RackClient.cache_calls,554 RackClient.cache_calls,
555 )555 )
@@ -583,7 +583,7 @@ class TestRackClient(MAASTestCase):
583 result = yield client(cluster.DescribePowerTypes)583 result = yield client(cluster.DescribePowerTypes)
584 # The result is a copy. It should equal the result but not be584 # The result is a copy. It should equal the result but not be
585 # the same object.585 # the same object.
586 self.assertEquals(power_types, result)586 self.assertEqual(power_types, result)
587 self.assertIsNot(power_types, result)587 self.assertIsNot(power_types, result)
588588
589 @wait_for_reactor589 @wait_for_reactor
@@ -1093,7 +1093,7 @@ class TestRegionService(MAASTestCase):
1093 self.assertEqual({uuid: set()}, service.waiters)1093 self.assertEqual({uuid: set()}, service.waiters)
10941094
1095 def check(conn_returned):1095 def check(conn_returned):
1096 self.assertEquals(conn, conn_returned)1096 self.assertEqual(conn, conn_returned)
10971097
1098 return d.addCallback(check)1098 return d.addCallback(check)
10991099
diff --git a/src/maasserver/rpc/tests/test_regionservice_calls.py b/src/maasserver/rpc/tests/test_regionservice_calls.py
index a1dfe15..32d3a2f 100644
--- a/src/maasserver/rpc/tests/test_regionservice_calls.py
+++ b/src/maasserver/rpc/tests/test_regionservice_calls.py
@@ -1303,7 +1303,7 @@ class TestRegionProtocol_RequestNodeInforByMACAddress(
1303 copy_response = dict(response)1303 copy_response = dict(response)
1304 del copy_response["boot_type"]1304 del copy_response["boot_type"]
1305 self.assertAttributes(node, copy_response)1305 self.assertAttributes(node, copy_response)
1306 self.assertEquals("fastpath", response["boot_type"])1306 self.assertEqual("fastpath", response["boot_type"])
13071307
1308 @wait_for_reactor1308 @wait_for_reactor
1309 def test_request_node_info_by_mac_address_raises_if_unknown_mac(self):1309 def test_request_node_info_by_mac_address_raises_if_unknown_mac(self):
diff --git a/src/maasserver/tests/test_audit.py b/src/maasserver/tests/test_audit.py
index 42ed53e..2dc79e2 100644
--- a/src/maasserver/tests/test_audit.py
+++ b/src/maasserver/tests/test_audit.py
@@ -25,8 +25,8 @@ class CreateAuditEventTest(MAASServerTestCase):
25 create_audit_event(EVENT_TYPES.NODE_PXE_REQUEST, endpoint, request)25 create_audit_event(EVENT_TYPES.NODE_PXE_REQUEST, endpoint, request)
26 event = Event.objects.get(node=None, type__level=AUDIT)26 event = Event.objects.get(node=None, type__level=AUDIT)
27 self.assertIsNotNone(event)27 self.assertIsNotNone(event)
28 self.assertEquals(endpoint, event.endpoint)28 self.assertEqual(endpoint, event.endpoint)
29 self.assertEquals("", event.user_agent)29 self.assertEqual("", event.user_agent)
3030
31 def test_create_audit_event_creates_audit_event_with_user_agent(self):31 def test_create_audit_event_creates_audit_event_with_user_agent(self):
32 node = factory.make_Node()32 node = factory.make_Node()
@@ -45,7 +45,7 @@ class CreateAuditEventTest(MAASServerTestCase):
45 )45 )
46 event = Event.objects.get(node=node, type__level=AUDIT)46 event = Event.objects.get(node=node, type__level=AUDIT)
47 self.assertIsNotNone(event)47 self.assertIsNotNone(event)
48 self.assertEquals(request.META["HTTP_USER_AGENT"], event.user_agent)48 self.assertEqual(request.META["HTTP_USER_AGENT"], event.user_agent)
4949
50 def test_create_audit_event_creates_audit_event_with_description(self):50 def test_create_audit_event_creates_audit_event_with_description(self):
51 node = factory.make_Node()51 node = factory.make_Node()
@@ -66,8 +66,8 @@ class CreateAuditEventTest(MAASServerTestCase):
66 )66 )
67 event = Event.objects.get(node=node, type__level=AUDIT)67 event = Event.objects.get(node=node, type__level=AUDIT)
68 self.assertIsNotNone(event)68 self.assertIsNotNone(event)
69 self.assertEquals(request.META["HTTP_USER_AGENT"], event.user_agent)69 self.assertEqual(request.META["HTTP_USER_AGENT"], event.user_agent)
70 self.assertEquals(description, event.description)70 self.assertEqual(description, event.description)
7171
72 def test_create_audit_event_creates_audit_event_with_AnonymousUser(self):72 def test_create_audit_event_creates_audit_event_with_AnonymousUser(self):
73 request = HttpRequest()73 request = HttpRequest()
diff --git a/src/maasserver/tests/test_bootresources.py b/src/maasserver/tests/test_bootresources.py
index e89be3c..609d784 100644
--- a/src/maasserver/tests/test_bootresources.py
+++ b/src/maasserver/tests/test_bootresources.py
@@ -335,8 +335,8 @@ class TestSimpleStreamsHandler(MAASServerTestCase):
335 )335 )
336 response = self.get_stream_client("maas:v2:download.json")336 response = self.get_stream_client("maas:v2:download.json")
337 output = json.loads(response.content.decode(settings.DEFAULT_CHARSET))337 output = json.loads(response.content.decode(settings.DEFAULT_CHARSET))
338 self.assertEquals(kflavor, output["products"][product]["kflavor"])338 self.assertEqual(kflavor, output["products"][product]["kflavor"])
339 self.assertEquals(339 self.assertEqual(
340 bootloader_type, output["products"][product]["bootloader-type"]340 bootloader_type, output["products"][product]["bootloader-type"]
341 )341 )
342 self.assertTrue(output["products"][product]["rolling"])342 self.assertTrue(output["products"][product]["rolling"])
@@ -849,11 +849,11 @@ class TestBootResourceStore(MAASServerTestCase):
849 }849 }
850 store = BootResourceStore()850 store = BootResourceStore()
851 resource = store.get_or_create_boot_resource(product)851 resource = store.get_or_create_boot_resource(product)
852 self.assertEquals(BOOT_RESOURCE_TYPE.SYNCED, resource.rtype)852 self.assertEqual(BOOT_RESOURCE_TYPE.SYNCED, resource.rtype)
853 self.assertEquals("ubuntu-core/16-pc", resource.name)853 self.assertEqual("ubuntu-core/16-pc", resource.name)
854 self.assertEquals("amd64/generic", resource.architecture)854 self.assertEqual("amd64/generic", resource.architecture)
855 self.assertIsNone(resource.bootloader_type)855 self.assertIsNone(resource.bootloader_type)
856 self.assertEquals("pc-kernel", resource.kflavor)856 self.assertEqual("pc-kernel", resource.kflavor)
857 self.assertDictEqual({"title": "Ubuntu Core 16 PC"}, resource.extra)857 self.assertDictEqual({"title": "Ubuntu Core 16 PC"}, resource.extra)
858858
859 def test_get_or_create_boot_resource_set_creates_resource_set(self):859 def test_get_or_create_boot_resource_set_creates_resource_set(self):
@@ -935,7 +935,7 @@ class TestBootResourceStore(MAASServerTestCase):
935 rfile.save()935 rfile.save()
936 for rfile in resource_set.files.all():936 for rfile in resource_set.files.all():
937 self.assertIn(rfile.filename, files)937 self.assertIn(rfile.filename, files)
938 self.assertEquals(rfile.filetype, product["ftype"])938 self.assertEqual(rfile.filetype, product["ftype"])
939939
940 def test_get_resource_file_log_identifier_returns_valid_ident(self):940 def test_get_resource_file_log_identifier_returns_valid_ident(self):
941 os = factory.make_name("os")941 os = factory.make_name("os")
@@ -1022,7 +1022,7 @@ class TestBootResourceStore(MAASServerTestCase):
1022 store.delete_content_to_finalize()1022 store.delete_content_to_finalize()
1023 self.assertIsNone(reload_object(rfile_one))1023 self.assertIsNone(reload_object(rfile_one))
1024 self.assertIsNone(reload_object(rfile_two))1024 self.assertIsNone(reload_object(rfile_two))
1025 self.assertEquals({}, store._content_to_finalize)1025 self.assertEqual({}, store._content_to_finalize)
10261026
1027 def test_finalize_does_nothing_if_resources_to_delete_hasnt_changed(self):1027 def test_finalize_does_nothing_if_resources_to_delete_hasnt_changed(self):
1028 self.patch(bootresources.Event.objects, "create_region_event")1028 self.patch(bootresources.Event.objects, "create_region_event")
diff --git a/src/maasserver/tests/test_bootsources.py b/src/maasserver/tests/test_bootsources.py
index 6bcb549..1be1755 100644
--- a/src/maasserver/tests/test_bootsources.py
+++ b/src/maasserver/tests/test_bootsources.py
@@ -220,7 +220,7 @@ class TestHelpers(MAASServerTestCase):
220 os_title = factory.make_name("os_title")220 os_title = factory.make_name("os_title")
221 release_title = factory.make_name("release_title")221 release_title = factory.make_name("release_title")
222 gadget_title = factory.make_name("gadget_title")222 gadget_title = factory.make_name("gadget_title")
223 self.assertEquals(223 self.assertEqual(
224 "%s %s %s" % (os_title, release_title, gadget_title),224 "%s %s %s" % (os_title, release_title, gadget_title),
225 get_product_title(225 get_product_title(
226 {226 {
@@ -234,7 +234,7 @@ class TestHelpers(MAASServerTestCase):
234 def test_get_product_title_with_os_and_release_titles(self):234 def test_get_product_title_with_os_and_release_titles(self):
235 os_title = factory.make_name("os_title")235 os_title = factory.make_name("os_title")
236 release_title = factory.make_name("release_title")236 release_title = factory.make_name("release_title")
237 self.assertEquals(237 self.assertEqual(
238 "%s %s" % (os_title, release_title),238 "%s %s" % (os_title, release_title),
239 get_product_title(239 get_product_title(
240 {"os_title": os_title, "release_title": release_title}240 {"os_title": os_title, "release_title": release_title}
@@ -346,7 +346,7 @@ class TestPrivateUpdateCache(MAASServerTestCase):
346 source.to_dict_without_selections(),346 source.to_dict_without_selections(),
347 image_mapping,347 image_mapping,
348 )348 )
349 self.assertEquals(5, queries)349 self.assertEqual(5, queries)
350350
351 # Now that they all already exist, it should only be 4 queries.351 # Now that they all already exist, it should only be 4 queries.
352 queries, _ = count_queries(352 queries, _ = count_queries(
@@ -354,7 +354,7 @@ class TestPrivateUpdateCache(MAASServerTestCase):
354 source.to_dict_without_selections(),354 source.to_dict_without_selections(),
355 image_mapping,355 image_mapping,
356 )356 )
357 self.assertEquals(4, queries)357 self.assertEqual(4, queries)
358358
359 # Do it again just to be sure.359 # Do it again just to be sure.
360 queries, _ = count_queries(360 queries, _ = count_queries(
@@ -362,7 +362,7 @@ class TestPrivateUpdateCache(MAASServerTestCase):
362 source.to_dict_without_selections(),362 source.to_dict_without_selections(),
363 image_mapping,363 image_mapping,
364 )364 )
365 self.assertEquals(4, queries)365 self.assertEqual(4, queries)
366366
367367
368class TestPrivateCacheBootSources(MAASTransactionServerTestCase):368class TestPrivateCacheBootSources(MAASTransactionServerTestCase):
diff --git a/src/maasserver/tests/test_config_forms.py b/src/maasserver/tests/test_config_forms.py
index 53f2508..4e36435 100644
--- a/src/maasserver/tests/test_config_forms.py
+++ b/src/maasserver/tests/test_config_forms.py
@@ -207,7 +207,7 @@ class TestFormWithDictCharField(MAASServerTestCase):
207 ],207 ],
208 required=False,208 required=False,
209 )209 )
210 self.assertEquals(210 self.assertEqual(
211 default_value, multi_field.clean_sub_fields("")["field_a"]211 default_value, multi_field.clean_sub_fields("")["field_a"]
212 )212 )
213213
diff --git a/src/maasserver/tests/test_dhcp.py b/src/maasserver/tests/test_dhcp.py
index 1ed1e19..ee0aba5 100644
--- a/src/maasserver/tests/test_dhcp.py
+++ b/src/maasserver/tests/test_dhcp.py
@@ -162,7 +162,7 @@ class TestIPIsStickyOrAuto(MAASServerTestCase):
162162
163 def test_returns_correct_result(self):163 def test_returns_correct_result(self):
164 ip_address = factory.make_StaticIPAddress(alloc_type=self.alloc_type)164 ip_address = factory.make_StaticIPAddress(alloc_type=self.alloc_type)
165 self.assertEquals(self.result, dhcp.ip_is_sticky_or_auto(ip_address))165 self.assertEqual(self.result, dhcp.ip_is_sticky_or_auto(ip_address))
166166
167167
168class TestGetBestInterface(MAASServerTestCase):168class TestGetBestInterface(MAASServerTestCase):
@@ -182,7 +182,7 @@ class TestGetBestInterface(MAASServerTestCase):
182 bond = factory.make_Interface(182 bond = factory.make_Interface(
183 INTERFACE_TYPE.BOND, node=rack_controller, parents=[nic0, nic1]183 INTERFACE_TYPE.BOND, node=rack_controller, parents=[nic0, nic1]
184 )184 )
185 self.assertEquals(bond, dhcp.get_best_interface([physical, bond]))185 self.assertEqual(bond, dhcp.get_best_interface([physical, bond]))
186186
187 def test_returns_physical_over_vlan(self):187 def test_returns_physical_over_vlan(self):
188 rack_controller = factory.make_RackController()188 rack_controller = factory.make_RackController()
@@ -192,7 +192,7 @@ class TestGetBestInterface(MAASServerTestCase):
192 vlan = factory.make_Interface(192 vlan = factory.make_Interface(
193 INTERFACE_TYPE.VLAN, node=rack_controller, parents=[physical]193 INTERFACE_TYPE.VLAN, node=rack_controller, parents=[physical]
194 )194 )
195 self.assertEquals(physical, dhcp.get_best_interface([physical, vlan]))195 self.assertEqual(physical, dhcp.get_best_interface([physical, vlan]))
196196
197 def test_returns_first_interface_when_all_physical(self):197 def test_returns_first_interface_when_all_physical(self):
198 rack_controller = factory.make_RackController()198 rack_controller = factory.make_RackController()
@@ -202,7 +202,7 @@ class TestGetBestInterface(MAASServerTestCase):
202 )202 )
203 for _ in range(3)203 for _ in range(3)
204 ]204 ]
205 self.assertEquals(interfaces[0], dhcp.get_best_interface(interfaces))205 self.assertEqual(interfaces[0], dhcp.get_best_interface(interfaces))
206206
207 def test_returns_first_interface_when_all_vlan(self):207 def test_returns_first_interface_when_all_vlan(self):
208 rack_controller = factory.make_RackController()208 rack_controller = factory.make_RackController()
@@ -215,7 +215,7 @@ class TestGetBestInterface(MAASServerTestCase):
215 )215 )
216 for _ in range(3)216 for _ in range(3)
217 ]217 ]
218 self.assertEquals(interfaces[0], dhcp.get_best_interface(interfaces))218 self.assertEqual(interfaces[0], dhcp.get_best_interface(interfaces))
219219
220220
221class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):221class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
@@ -295,7 +295,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
295 factory.make_StaticIPAddress(295 factory.make_StaticIPAddress(
296 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface296 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface
297 )297 )
298 self.assertEquals(298 self.assertEqual(
299 [interface],299 [interface],
300 dhcp.get_interfaces_with_ip_on_vlan(300 dhcp.get_interfaces_with_ip_on_vlan(
301 rack_controller, vlan, subnet.get_ipnetwork().version301 rack_controller, vlan, subnet.get_ipnetwork().version
@@ -353,7 +353,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
353 subnet=subnet_with_dynamic_range,353 subnet=subnet_with_dynamic_range,
354 interface=interface_two,354 interface=interface_two,
355 )355 )
356 self.assertEquals(356 self.assertEqual(
357 [interface_two, interface_one],357 [interface_two, interface_one],
358 dhcp.get_interfaces_with_ip_on_vlan(358 dhcp.get_interfaces_with_ip_on_vlan(
359 rack_controller, vlan, subnet.get_ipnetwork().version359 rack_controller, vlan, subnet.get_ipnetwork().version
@@ -427,7 +427,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
427 subnet=subnet,427 subnet=subnet,
428 interface=interface,428 interface=interface,
429 )429 )
430 self.assertEquals(430 self.assertEqual(
431 [],431 [],
432 dhcp.get_interfaces_with_ip_on_vlan(432 dhcp.get_interfaces_with_ip_on_vlan(
433 rack_controller, vlan, subnet.get_ipnetwork().version433 rack_controller, vlan, subnet.get_ipnetwork().version
@@ -460,7 +460,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
460 subnet=other_subnet,460 subnet=other_subnet,
461 interface=other_interface,461 interface=other_interface,
462 )462 )
463 self.assertEquals(463 self.assertEqual(
464 [interface],464 [interface],
465 dhcp.get_interfaces_with_ip_on_vlan(465 dhcp.get_interfaces_with_ip_on_vlan(
466 rack_controller, vlan, subnet.get_ipnetwork().version466 rack_controller, vlan, subnet.get_ipnetwork().version
@@ -493,7 +493,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
493 subnet=other_subnet,493 subnet=other_subnet,
494 interface=other_interface,494 interface=other_interface,
495 )495 )
496 self.assertEquals(496 self.assertEqual(
497 [interface],497 [interface],
498 dhcp.get_interfaces_with_ip_on_vlan(498 dhcp.get_interfaces_with_ip_on_vlan(
499 rack_controller, vlan, subnet.get_ipnetwork().version499 rack_controller, vlan, subnet.get_ipnetwork().version
@@ -511,7 +511,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase):
511 factory.make_StaticIPAddress(511 factory.make_StaticIPAddress(
512 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface512 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface
513 )513 )
514 self.assertEquals(514 self.assertEqual(
515 [interface],515 [interface],
516 dhcp.get_interfaces_with_ip_on_vlan(516 dhcp.get_interfaces_with_ip_on_vlan(
517 rack_controller,517 rack_controller,
@@ -673,7 +673,7 @@ class TestGenManagedVLANsFor(MAASServerTestCase):
673673
674 # Should only contain the subnets that are managed by the rack674 # Should only contain the subnets that are managed by the rack
675 # controller and the best interface should have been selected.675 # controller and the best interface should have been selected.
676 self.assertEquals(676 self.assertEqual(
677 {vlan_one, vlan_two},677 {vlan_one, vlan_two},
678 set(dhcp.gen_managed_vlans_for(rack_controller)),678 set(dhcp.gen_managed_vlans_for(rack_controller)),
679 )679 )
@@ -702,7 +702,7 @@ class TestGenManagedVLANsFor(MAASServerTestCase):
702702
703 # Should only contain the subnets that are managed by the rack703 # Should only contain the subnets that are managed by the rack
704 # controller and the best interface should have been selected.704 # controller and the best interface should have been selected.
705 self.assertEquals(705 self.assertEqual(
706 relay_vlans.union(set([vlan_one])),706 relay_vlans.union(set([vlan_one])),
707 set(dhcp.gen_managed_vlans_for(rack_controller)),707 set(dhcp.gen_managed_vlans_for(rack_controller)),
708 )708 )
@@ -810,7 +810,7 @@ class TestIPIsOnVLAN(MAASServerTestCase):
810 # make_StaticIPAddress always creates a subnet so set it to None.810 # make_StaticIPAddress always creates a subnet so set it to None.
811 ip_address.subnet = None811 ip_address.subnet = None
812 ip_address.save()812 ip_address.save()
813 self.assertEquals(813 self.assertEqual(
814 self.result, dhcp.ip_is_on_vlan(ip_address, expected_vlan)814 self.result, dhcp.ip_is_on_vlan(ip_address, expected_vlan)
815 )815 )
816816
@@ -825,7 +825,7 @@ class TestGetIPAddressForInterface(MAASServerTestCase):
825 ip_address = factory.make_StaticIPAddress(825 ip_address = factory.make_StaticIPAddress(
826 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface826 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface
827 )827 )
828 self.assertEquals(828 self.assertEqual(
829 ip_address, dhcp.get_ip_address_for_interface(interface, vlan)829 ip_address, dhcp.get_ip_address_for_interface(interface, vlan)
830 )830 )
831831
@@ -854,7 +854,7 @@ class TestGetIPAddressForRackController(MAASServerTestCase):
854 ip_address = factory.make_StaticIPAddress(854 ip_address = factory.make_StaticIPAddress(
855 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface855 alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface
856 )856 )
857 self.assertEquals(857 self.assertEqual(
858 ip_address,858 ip_address,
859 dhcp.get_ip_address_for_rack_controller(rack_controller, vlan),859 dhcp.get_ip_address_for_rack_controller(rack_controller, vlan),
860 )860 )
@@ -883,7 +883,7 @@ class TestGetIPAddressForRackController(MAASServerTestCase):
883 subnet=subnet,883 subnet=subnet,
884 interface=bond_interface,884 interface=bond_interface,
885 )885 )
886 self.assertEquals(886 self.assertEqual(
887 bond_ip_address,887 bond_ip_address,
888 dhcp.get_ip_address_for_rack_controller(rack_controller, vlan),888 dhcp.get_ip_address_for_rack_controller(rack_controller, vlan),
889 )889 )
@@ -1120,7 +1120,7 @@ class TestGetDefaultDNSServers(MAASServerTestCase):
1120 self.assertItemsEqual(1120 self.assertItemsEqual(
1121 servers[0:-1], [IPAddress(r1_address.ip), IPAddress(r2_address.ip)]1121 servers[0:-1], [IPAddress(r1_address.ip), IPAddress(r2_address.ip)]
1122 )1122 )
1123 self.assertEquals(IPAddress("10.0.0.1"), servers[-1])1123 self.assertEqual(IPAddress("10.0.0.1"), servers[-1])
11241124
1125 def test_doesnt_include_remote_region_ip(self):1125 def test_doesnt_include_remote_region_ip(self):
1126 # Regression test for LP:18811331126 # Regression test for LP:1881133
@@ -1584,7 +1584,7 @@ class TestMakeSubnetConfig(MAASServerTestCase):
1584 [factory.make_name("ntp")],1584 [factory.make_name("ntp")],
1585 default_domain,1585 default_domain,
1586 )1586 )
1587 self.assertEquals(1587 self.assertEqual(
1588 [1588 [
1589 {"ip_range_low": "10.9.8.11", "ip_range_high": "10.9.8.20"},1589 {"ip_range_low": "10.9.8.11", "ip_range_high": "10.9.8.20"},
1590 {"ip_range_low": "10.9.8.21", "ip_range_high": "10.9.8.30"},1590 {"ip_range_low": "10.9.8.21", "ip_range_high": "10.9.8.30"},
@@ -1613,7 +1613,7 @@ class TestMakeSubnetConfig(MAASServerTestCase):
1613 default_domain,1613 default_domain,
1614 failover_peer=failover_peer,1614 failover_peer=failover_peer,
1615 )1615 )
1616 self.assertEquals(1616 self.assertEqual(
1617 [1617 [
1618 {1618 {
1619 "ip_range_low": "10.9.8.11",1619 "ip_range_low": "10.9.8.11",
@@ -2016,7 +2016,7 @@ class TestMakeFailoverPeerConfig(MAASServerTestCase):
2016 interface=secondary_interface,2016 interface=secondary_interface,
2017 )2017 )
2018 failover_peer_name = "failover-vlan-%d" % vlan.id2018 failover_peer_name = "failover-vlan-%d" % vlan.id
2019 self.assertEquals(2019 self.assertEqual(
2020 (2020 (
2021 failover_peer_name,2021 failover_peer_name,
2022 {2022 {
@@ -2056,7 +2056,7 @@ class TestMakeFailoverPeerConfig(MAASServerTestCase):
2056 interface=secondary_interface,2056 interface=secondary_interface,
2057 )2057 )
2058 failover_peer_name = "failover-vlan-%d" % vlan.id2058 failover_peer_name = "failover-vlan-%d" % vlan.id
2059 self.assertEquals(2059 self.assertEqual(
2060 (2060 (
2061 failover_peer_name,2061 failover_peer_name,
2062 {2062 {
@@ -2136,7 +2136,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase):
2136 dhcp_snippets=DHCPSnippet.objects.all(),2136 dhcp_snippets=DHCPSnippet.objects.all(),
2137 )2137 )
21382138
2139 self.assertEquals(2139 self.assertEqual(
2140 {2140 {
2141 "name": "failover-vlan-%d" % ha_vlan.id,2141 "name": "failover-vlan-%d" % ha_vlan.id,
2142 "mode": "primary",2142 "mode": "primary",
@@ -2145,7 +2145,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase):
2145 },2145 },
2146 observed_failover,2146 observed_failover,
2147 )2147 )
2148 self.assertEquals(2148 self.assertEqual(
2149 sorted(2149 sorted(
2150 [2150 [
2151 {2151 {
@@ -2297,7 +2297,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase):
2297 for observed_subnet in observed_subnets:2297 for observed_subnet in observed_subnets:
2298 del observed_subnet["dns_servers"]2298 del observed_subnet["dns_servers"]
22992299
2300 self.assertEquals(2300 self.assertEqual(
2301 {2301 {
2302 "name": "failover-vlan-%d" % ha_vlan.id,2302 "name": "failover-vlan-%d" % ha_vlan.id,
2303 "mode": "primary",2303 "mode": "primary",
@@ -2306,7 +2306,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase):
2306 },2306 },
2307 observed_failover,2307 observed_failover,
2308 )2308 )
2309 self.assertEquals(2309 self.assertEqual(
2310 sorted(2310 sorted(
2311 [2311 [
2312 {2312 {
@@ -3195,7 +3195,7 @@ class TestValidateDHCPConfig(MAASTransactionServerTestCase):
3195 rack_controller, config = self.create_rack_controller()3195 rack_controller, config = self.create_rack_controller()
3196 self.prepare_rpc(rack_controller)3196 self.prepare_rpc(rack_controller)
31973197
3198 self.assertEquals([], dhcp.validate_dhcp_config())3198 self.assertEqual([], dhcp.validate_dhcp_config())
31993199
3200 def test_returns_errors_when_invalid(self):3200 def test_returns_errors_when_invalid(self):
3201 rack_controller, config = self.create_rack_controller()3201 rack_controller, config = self.create_rack_controller()
diff --git a/src/maasserver/tests/test_eventloop.py b/src/maasserver/tests/test_eventloop.py
index 1483066..83433eb 100644
--- a/src/maasserver/tests/test_eventloop.py
+++ b/src/maasserver/tests/test_eventloop.py
@@ -356,7 +356,7 @@ class TestFactories(MAASServerTestCase):
356 eventloop.loop.factories["rpc"]["factory"],356 eventloop.loop.factories["rpc"]["factory"],
357 )357 )
358 self.assertFalse(eventloop.loop.factories["rpc"]["only_on_master"])358 self.assertFalse(eventloop.loop.factories["rpc"]["only_on_master"])
359 self.assertEquals(359 self.assertEqual(
360 ["ipc-worker"], eventloop.loop.factories["rpc"]["requires"]360 ["ipc-worker"], eventloop.loop.factories["rpc"]["requires"]
361 )361 )
362362
@@ -458,7 +458,7 @@ class TestFactories(MAASServerTestCase):
458 eventloop.loop.factories["web"]["factory"],458 eventloop.loop.factories["web"]["factory"],
459 )459 )
460 # Has a dependency of postgres-listener.460 # Has a dependency of postgres-listener.
461 self.assertEquals(461 self.assertEqual(
462 ["postgres-listener-worker", "status-worker"],462 ["postgres-listener-worker", "status-worker"],
463 eventloop.loop.factories["web"]["requires"],463 eventloop.loop.factories["web"]["requires"],
464 )464 )
@@ -477,7 +477,7 @@ class TestFactories(MAASServerTestCase):
477 eventloop.loop.factories["rack-controller"]["factory"],477 eventloop.loop.factories["rack-controller"]["factory"],
478 )478 )
479 # Has a dependency of ipc-worker and postgres-listener.479 # Has a dependency of ipc-worker and postgres-listener.
480 self.assertEquals(480 self.assertEqual(
481 ["ipc-worker", "postgres-listener-worker"],481 ["ipc-worker", "postgres-listener-worker"],
482 eventloop.loop.factories["rack-controller"]["requires"],482 eventloop.loop.factories["rack-controller"]["requires"],
483 )483 )
@@ -495,7 +495,7 @@ class TestFactories(MAASServerTestCase):
495 eventloop.make_ServiceMonitorService,495 eventloop.make_ServiceMonitorService,
496 eventloop.loop.factories["service-monitor"]["factory"],496 eventloop.loop.factories["service-monitor"]["factory"],
497 )497 )
498 self.assertEquals(498 self.assertEqual(
499 [], eventloop.loop.factories["service-monitor"]["requires"]499 [], eventloop.loop.factories["service-monitor"]["requires"]
500 )500 )
501 self.assertTrue(501 self.assertTrue(
@@ -511,7 +511,7 @@ class TestFactories(MAASServerTestCase):
511 eventloop.loop.factories["status-worker"]["factory"],511 eventloop.loop.factories["status-worker"]["factory"],
512 )512 )
513 # Has a dependency of database-tasks.513 # Has a dependency of database-tasks.
514 self.assertEquals(514 self.assertEqual(
515 ["database-tasks"],515 ["database-tasks"],
516 eventloop.loop.factories["status-worker"]["requires"],516 eventloop.loop.factories["status-worker"]["requires"],
517 )517 )
@@ -530,7 +530,7 @@ class TestFactories(MAASServerTestCase):
530 eventloop.loop.factories["ntp"]["factory"],530 eventloop.loop.factories["ntp"]["factory"],
531 )531 )
532 # Has a no dependencies.532 # Has a no dependencies.
533 self.assertEquals([], eventloop.loop.factories["ntp"]["requires"])533 self.assertEqual([], eventloop.loop.factories["ntp"]["requires"])
534 self.assertTrue(eventloop.loop.factories["ntp"]["only_on_master"])534 self.assertTrue(eventloop.loop.factories["ntp"]["only_on_master"])
535535
536 def test_make_SyslogService(self):536 def test_make_SyslogService(self):
@@ -542,7 +542,7 @@ class TestFactories(MAASServerTestCase):
542 eventloop.loop.factories["syslog"]["factory"],542 eventloop.loop.factories["syslog"]["factory"],
543 )543 )
544 # Has a no dependencies.544 # Has a no dependencies.
545 self.assertEquals([], eventloop.loop.factories["syslog"]["requires"])545 self.assertEqual([], eventloop.loop.factories["syslog"]["requires"])
546 self.assertTrue(eventloop.loop.factories["syslog"]["only_on_master"])546 self.assertTrue(eventloop.loop.factories["syslog"]["only_on_master"])
547547
548 def test_make_WorkersService(self):548 def test_make_WorkersService(self):
@@ -554,7 +554,7 @@ class TestFactories(MAASServerTestCase):
554 eventloop.loop.factories["workers"]["factory"],554 eventloop.loop.factories["workers"]["factory"],
555 )555 )
556 # Has a no dependencies.556 # Has a no dependencies.
557 self.assertEquals([], eventloop.loop.factories["workers"]["requires"])557 self.assertEqual([], eventloop.loop.factories["workers"]["requires"])
558 self.assertTrue(eventloop.loop.factories["workers"]["only_on_master"])558 self.assertTrue(eventloop.loop.factories["workers"]["only_on_master"])
559 self.assertTrue(eventloop.loop.factories["workers"]["not_all_in_one"])559 self.assertTrue(eventloop.loop.factories["workers"]["not_all_in_one"])
560560
@@ -567,11 +567,11 @@ class TestFactories(MAASServerTestCase):
567 eventloop.loop.factories["ipc-master"]["factory"],567 eventloop.loop.factories["ipc-master"]["factory"],
568 )568 )
569 # Has a no dependencies.569 # Has a no dependencies.
570 self.assertEquals(570 self.assertEqual(
571 [], eventloop.loop.factories["ipc-master"]["requires"]571 [], eventloop.loop.factories["ipc-master"]["requires"]
572 )572 )
573 # Has an optional dependency on workers.573 # Has an optional dependency on workers.
574 self.assertEquals(574 self.assertEqual(
575 ["workers"], eventloop.loop.factories["ipc-master"]["optional"]575 ["workers"], eventloop.loop.factories["ipc-master"]["optional"]
576 )576 )
577 self.assertTrue(577 self.assertTrue(
@@ -587,7 +587,7 @@ class TestFactories(MAASServerTestCase):
587 eventloop.loop.factories["ipc-worker"]["factory"],587 eventloop.loop.factories["ipc-worker"]["factory"],
588 )588 )
589 # Has a no dependencies.589 # Has a no dependencies.
590 self.assertEquals(590 self.assertEqual(
591 [], eventloop.loop.factories["ipc-worker"]["requires"]591 [], eventloop.loop.factories["ipc-worker"]["requires"]
592 )592 )
593 self.assertFalse(593 self.assertFalse(
diff --git a/src/maasserver/tests/test_fields.py b/src/maasserver/tests/test_fields.py
index 7f8e440..926364a 100644
--- a/src/maasserver/tests/test_fields.py
+++ b/src/maasserver/tests/test_fields.py
@@ -835,7 +835,7 @@ class TestVersionedTextFileField(MAASServerTestCase):
835 data = factory.make_string()835 data = factory.make_string()
836 versioned_text_file_field = VersionedTextFileField()836 versioned_text_file_field = VersionedTextFileField()
837 versioned_text_file = versioned_text_file_field.clean(data)837 versioned_text_file = versioned_text_file_field.clean(data)
838 self.assertEquals(data, versioned_text_file.data)838 self.assertEqual(data, versioned_text_file.data)
839 self.assertIsNone(versioned_text_file.previous_version)839 self.assertIsNone(versioned_text_file.previous_version)
840840
841 def test_create_requires_value(self):841 def test_create_requires_value(self):
@@ -851,22 +851,22 @@ class TestVersionedTextFileField(MAASServerTestCase):
851 versioned_text_file = versioned_text_file_field.clean(851 versioned_text_file = versioned_text_file_field.clean(
852 {"data": data, "comment": comment}852 {"data": data, "comment": comment}
853 )853 )
854 self.assertEquals(data, versioned_text_file.data)854 self.assertEqual(data, versioned_text_file.data)
855 self.assertEquals(comment, versioned_text_file.comment)855 self.assertEqual(comment, versioned_text_file.comment)
856 self.assertIsNone(versioned_text_file.previous_version)856 self.assertIsNone(versioned_text_file.previous_version)
857857
858 def test_update_does_nothing_on_none(self):858 def test_update_does_nothing_on_none(self):
859 data = VersionedTextFile.objects.create(data=factory.make_string())859 data = VersionedTextFile.objects.create(data=factory.make_string())
860 versioned_text_file_field = VersionedTextFileField(initial=data)860 versioned_text_file_field = VersionedTextFileField(initial=data)
861 self.assertEquals(data, versioned_text_file_field.clean(None))861 self.assertEqual(data, versioned_text_file_field.clean(None))
862862
863 def test_creates_new_link(self):863 def test_creates_new_link(self):
864 old_ver = VersionedTextFile.objects.create(data=factory.make_string())864 old_ver = VersionedTextFile.objects.create(data=factory.make_string())
865 versioned_text_file_field = VersionedTextFileField(initial=old_ver)865 versioned_text_file_field = VersionedTextFileField(initial=old_ver)
866 data = factory.make_string()866 data = factory.make_string()
867 new_ver = versioned_text_file_field.clean(data)867 new_ver = versioned_text_file_field.clean(data)
868 self.assertEquals(data, new_ver.data)868 self.assertEqual(data, new_ver.data)
869 self.assertEquals(old_ver, new_ver.previous_version)869 self.assertEqual(old_ver, new_ver.previous_version)
870870
871 def test_creates_new_link_accepts_dict(self):871 def test_creates_new_link_accepts_dict(self):
872 old_ver = VersionedTextFile.objects.create(data=factory.make_string())872 old_ver = VersionedTextFile.objects.create(data=factory.make_string())
@@ -876,9 +876,9 @@ class TestVersionedTextFileField(MAASServerTestCase):
876 new_ver = versioned_text_file_field.clean(876 new_ver = versioned_text_file_field.clean(
877 {"new_data": data, "comment": comment}877 {"new_data": data, "comment": comment}
878 )878 )
879 self.assertEquals(data, new_ver.data)879 self.assertEqual(data, new_ver.data)
880 self.assertEquals(comment, new_ver.comment)880 self.assertEqual(comment, new_ver.comment)
881 self.assertEquals(old_ver, new_ver.previous_version)881 self.assertEqual(old_ver, new_ver.previous_version)
882882
883883
884class TestURLOrPPAValidator(MAASServerTestCase):884class TestURLOrPPAValidator(MAASServerTestCase):
diff --git a/src/maasserver/tests/test_ipc.py b/src/maasserver/tests/test_ipc.py
index a67d826..ee0214a 100644
--- a/src/maasserver/tests/test_ipc.py
+++ b/src/maasserver/tests/test_ipc.py
@@ -54,18 +54,18 @@ class TestGetIPCSocketPath(MAASTestCase):
54 self.useFixture(54 self.useFixture(
55 EnvironmentVariableFixture("MAAS_IPC_SOCKET_PATH", path)55 EnvironmentVariableFixture("MAAS_IPC_SOCKET_PATH", path)
56 )56 )
57 self.assertEquals(path, get_ipc_socket_path())57 self.assertEqual(path, get_ipc_socket_path())
5858
59 def test_returns_ipc_from_maas_data(self):59 def test_returns_ipc_from_maas_data(self):
60 path = factory.make_name("path")60 path = factory.make_name("path")
61 self.useFixture(EnvironmentVariableFixture("MAAS_DATA", path))61 self.useFixture(EnvironmentVariableFixture("MAAS_DATA", path))
62 self.assertEquals(62 self.assertEqual(
63 os.path.join(path, "maas-regiond.sock"), get_ipc_socket_path()63 os.path.join(path, "maas-regiond.sock"), get_ipc_socket_path()
64 )64 )
6565
66 def test_returns_ipc_at_default_location(self):66 def test_returns_ipc_at_default_location(self):
67 self.useFixture(EnvironmentVariableFixture("MAAS_DATA", None))67 self.useFixture(EnvironmentVariableFixture("MAAS_DATA", None))
68 self.assertEquals(68 self.assertEqual(
69 "/var/lib/maas/maas-regiond.sock", get_ipc_socket_path()69 "/var/lib/maas/maas-regiond.sock", get_ipc_socket_path()
70 )70 )
7171
@@ -142,15 +142,15 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
142 return RegionControllerProcess.objects.get(region=region, pid=pid)142 return RegionControllerProcess.objects.get(region=region, pid=pid)
143143
144 process = yield deferToDatabase(getProcessFromDB)144 process = yield deferToDatabase(getProcessFromDB)
145 self.assertEquals(process.id, master.connections[pid]["process_id"])145 self.assertEqual(process.id, master.connections[pid]["process_id"])
146146
147 worker_procId = yield worker.processId.get(timeout=2)147 worker_procId = yield worker.processId.get(timeout=2)
148 self.assertEquals(process.id, worker_procId)148 self.assertEqual(process.id, worker_procId)
149149
150 yield worker.stopService()150 yield worker.stopService()
151151
152 yield disconnected.get(timeout=2)152 yield disconnected.get(timeout=2)
153 self.assertEquals({}, master.connections)153 self.assertEqual({}, master.connections)
154154
155 process = yield deferToDatabase(reload_object, process)155 process = yield deferToDatabase(reload_object, process)
156 self.assertIsNone(process)156 self.assertIsNone(process)
@@ -217,7 +217,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
217 )217 )
218218
219 endpoints = yield deferToDatabase(getEndpoints)219 endpoints = yield deferToDatabase(getEndpoints)
220 self.assertEquals(220 self.assertEqual(
221 master._getListenAddresses(master.connections[pid]["rpc"]["port"]),221 master._getListenAddresses(master.connections[pid]["rpc"]["port"]),
222 endpoints,222 endpoints,
223 )223 )
@@ -294,7 +294,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
294294
295 connection = yield deferToDatabase(getConnection)295 connection = yield deferToDatabase(getConnection)
296 self.assertIsNotNone(connection)296 self.assertIsNotNone(connection)
297 self.assertEquals(297 self.assertEqual(
298 {connid: (rackd.system_id, address, port)},298 {connid: (rackd.system_id, address, port)},
299 master.connections[pid]["rpc"]["connections"],299 master.connections[pid]["rpc"]["connections"],
300 )300 )
@@ -331,7 +331,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
331 process = yield deferToDatabase(331 process = yield deferToDatabase(
332 RegionControllerProcess.objects.get, id=data["process_id"]332 RegionControllerProcess.objects.get, id=data["process_id"]
333 )333 )
334 self.assertEquals(pid, process.pid)334 self.assertEqual(pid, process.pid)
335335
336 yield master.stopService()336 yield master.stopService()
337337
@@ -404,7 +404,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
404 yield master.update()404 yield master.update()
405405
406 region_process = yield deferToDatabase(reload_object, region_process)406 region_process = yield deferToDatabase(reload_object, region_process)
407 self.assertEquals(current_time, region_process.updated)407 self.assertEqual(current_time, region_process.updated)
408408
409 yield master.stopService()409 yield master.stopService()
410410
diff --git a/src/maasserver/tests/test_listener.py b/src/maasserver/tests/test_listener.py
index 0e12135..8699b02 100644
--- a/src/maasserver/tests/test_listener.py
+++ b/src/maasserver/tests/test_listener.py
@@ -573,9 +573,9 @@ class TestPostgresListenerService(MAASServerTestCase):
573 listener = PostgresListenerService()573 listener = PostgresListenerService()
574 channel = factory.make_name("channel", sep="_").lower()574 channel = factory.make_name("channel", sep="_").lower()
575 listener.register(channel, sentinel.handler)575 listener.register(channel, sentinel.handler)
576 self.assertEquals({channel: [sentinel.handler]}, listener.listeners)576 self.assertEqual({channel: [sentinel.handler]}, listener.listeners)
577 listener.unregister(channel, sentinel.handler)577 listener.unregister(channel, sentinel.handler)
578 self.assertEquals({}, listener.listeners)578 self.assertEqual({}, listener.listeners)
579579
580 def test_unregister_removes_handler_others(self):580 def test_unregister_removes_handler_others(self):
581 listener = PostgresListenerService()581 listener = PostgresListenerService()
@@ -583,7 +583,7 @@ class TestPostgresListenerService(MAASServerTestCase):
583 listener.register(channel, sentinel.handler1)583 listener.register(channel, sentinel.handler1)
584 listener.register(channel, sentinel.handler2)584 listener.register(channel, sentinel.handler2)
585 listener.unregister(channel, sentinel.handler2)585 listener.unregister(channel, sentinel.handler2)
586 self.assertEquals({channel: [sentinel.handler1]}, listener.listeners)586 self.assertEqual({channel: [sentinel.handler1]}, listener.listeners)
587587
588 @wait_for_reactor588 @wait_for_reactor
589 @inlineCallbacks589 @inlineCallbacks
diff --git a/src/maasserver/tests/test_node_action.py b/src/maasserver/tests/test_node_action.py
index add7166..6ec7c70 100644
--- a/src/maasserver/tests/test_node_action.py
+++ b/src/maasserver/tests/test_node_action.py
@@ -370,13 +370,11 @@ class TestCommissionAction(MAASServerTestCase):
370 )370 )
371 script_sets = ScriptSet.objects.all()371 script_sets = ScriptSet.objects.all()
372 node = reload_object(node)372 node = reload_object(node)
373 self.assertEquals(2, len(script_sets))373 self.assertEqual(2, len(script_sets))
374 self.assertEquals(374 self.assertEqual(
375 node.current_commissioning_script_set_id, script_sets[0].id375 node.current_commissioning_script_set_id, script_sets[0].id
376 )376 )
377 self.assertEquals(377 self.assertEqual(node.current_testing_script_set_id, script_sets[1].id)
378 node.current_testing_script_set_id, script_sets[1].id
379 )
380 self.assertEqual(NODE_STATUS.COMMISSIONING, node.status)378 self.assertEqual(NODE_STATUS.COMMISSIONING, node.status)
381 self.assertThat(379 self.assertThat(
382 node_start,380 node_start,
diff --git a/src/maasserver/tests/test_node_constraint_filter_forms.py b/src/maasserver/tests/test_node_constraint_filter_forms.py
index 96dd0a6..9c0a514 100644
--- a/src/maasserver/tests/test_node_constraint_filter_forms.py
+++ b/src/maasserver/tests/test_node_constraint_filter_forms.py
@@ -872,7 +872,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin):
872 _, storage, _ = self.assertConstrainedNodes(872 _, storage, _ = self.assertConstrainedNodes(
873 [node1], {"storage": "part:0(partition)"}873 [node1], {"storage": "part:0(partition)"}
874 )874 )
875 self.assertEquals(875 self.assertEqual(
876 {node1.id: {"partition:%d" % partition.id: "part"}}, storage876 {node1.id: {"partition:%d" % partition.id: "part"}}, storage
877 )877 )
878878
@@ -928,7 +928,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin):
928 _, storage, _ = self.assertConstrainedNodes(928 _, storage, _ = self.assertConstrainedNodes(
929 [node1], {"storage": "part:0(partition,ssd-part)"}929 [node1], {"storage": "part:0(partition,ssd-part)"}
930 )930 )
931 self.assertEquals(931 self.assertEqual(
932 {node1.id: {"partition:%d" % partition.id: "part"}}, storage932 {node1.id: {"partition:%d" % partition.id: "part"}}, storage
933 )933 )
934934
@@ -1090,7 +1090,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin):
1090 _, storage, _ = self.assertConstrainedNodes(1090 _, storage, _ = self.assertConstrainedNodes(
1091 [node3], {"storage": "0,4,4,4,part:0(partition)"}1091 [node3], {"storage": "0,4,4,4,part:0(partition)"}
1092 )1092 )
1093 self.assertEquals(1093 self.assertEqual(
1094 {node3.id: {"partition:%d" % partition.id: "part"}}, storage1094 {node3.id: {"partition:%d" % partition.id: "part"}}, storage
1095 )1095 )
10961096
@@ -1203,11 +1203,11 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin):
1203 value: key for key, value in constraint_map[node.id].items()1203 value: key for key, value in constraint_map[node.id].items()
1204 }1204 }
1205 disk0 = node.blockdevice_set.get(id=constraints["root"])1205 disk0 = node.blockdevice_set.get(id=constraints["root"])
1206 self.assertEquals(virtual.id, disk0.id)1206 self.assertEqual(virtual.id, disk0.id)
1207 disk1 = node.blockdevice_set.get(id=constraints["physical"])1207 disk1 = node.blockdevice_set.get(id=constraints["physical"])
1208 self.assertEquals(physical.id, disk1.id)1208 self.assertEqual(physical.id, disk1.id)
1209 disk2 = node.blockdevice_set.get(id=constraints["iscsi"])1209 disk2 = node.blockdevice_set.get(id=constraints["iscsi"])
1210 self.assertEquals(iscsi.id, disk2.id)1210 self.assertEqual(iscsi.id, disk2.id)
12111211
1212 def test_fabrics_constraint(self):1212 def test_fabrics_constraint(self):
1213 fabric1 = factory.make_Fabric(name="fabric1")1213 fabric1 = factory.make_Fabric(name="fabric1")
diff --git a/src/maasserver/tests/test_preseed.py b/src/maasserver/tests/test_preseed.py
index dce8a02..8aacc00 100644
--- a/src/maasserver/tests/test_preseed.py
+++ b/src/maasserver/tests/test_preseed.py
@@ -472,7 +472,7 @@ class TestPreseedContext(MAASServerTestCase):
472 remote_syslog = "192.168.1.1:514"472 remote_syslog = "192.168.1.1:514"
473 Config.objects.set_config("remote_syslog", remote_syslog)473 Config.objects.set_config("remote_syslog", remote_syslog)
474 context = get_preseed_context(make_HttpRequest())474 context = get_preseed_context(make_HttpRequest())
475 self.assertEquals(remote_syslog, context["syslog_host_port"])475 self.assertEqual(remote_syslog, context["syslog_host_port"])
476476
477 def test_get_preseed_context_uses_maas_syslog_port(self):477 def test_get_preseed_context_uses_maas_syslog_port(self):
478 syslog_port = factory.pick_port()478 syslog_port = factory.pick_port()
diff --git a/src/maasserver/tests/test_rack_controller.py b/src/maasserver/tests/test_rack_controller.py
index ef255f9..01dda0c 100644
--- a/src/maasserver/tests/test_rack_controller.py
+++ b/src/maasserver/tests/test_rack_controller.py
@@ -212,8 +212,8 @@ class TestRackControllerService(
212 listener.register(f"sys_dhcp_{rack_id}", service.dhcpHandler)212 listener.register(f"sys_dhcp_{rack_id}", service.dhcpHandler)
213 service.coreHandler("sys_core_%d" % processId, "unwatch_%d" % rack_id)213 service.coreHandler("sys_core_%d" % processId, "unwatch_%d" % rack_id)
214 self.assertNotIn(f"sys_dhcp_{rack_id}", listener.listeners)214 self.assertNotIn(f"sys_dhcp_{rack_id}", listener.listeners)
215 self.assertEquals(set(), service.watching)215 self.assertEqual(set(), service.watching)
216 self.assertEquals(set(), service.needsDHCPUpdate)216 self.assertEqual(set(), service.needsDHCPUpdate)
217217
218 def test_coreHandler_unwatch_doesnt_call_unregister(self):218 def test_coreHandler_unwatch_doesnt_call_unregister(self):
219 processId = random.randint(0, 100)219 processId = random.randint(0, 100)
@@ -240,8 +240,8 @@ class TestRackControllerService(
240 dhcp_channel = f"sys_dhcp_{rack_id}"240 dhcp_channel = f"sys_dhcp_{rack_id}"
241 self.assertIn(dhcp_channel, listener.listeners)241 self.assertIn(dhcp_channel, listener.listeners)
242 self.assertIn(service.dhcpHandler, listener.listeners[dhcp_channel])242 self.assertIn(service.dhcpHandler, listener.listeners[dhcp_channel])
243 self.assertEquals(set([rack_id]), service.watching)243 self.assertEqual(set([rack_id]), service.watching)
244 self.assertEquals(set([rack_id]), service.needsDHCPUpdate)244 self.assertEqual(set([rack_id]), service.needsDHCPUpdate)
245 self.assertThat(mock_startProcessing, MockCalledOnceWith())245 self.assertThat(mock_startProcessing, MockCalledOnceWith())
246246
247 def test_coreHandler_watch_doesnt_call_register(self):247 def test_coreHandler_watch_doesnt_call_register(self):
@@ -256,8 +256,8 @@ class TestRackControllerService(
256 service.coreHandler(sys_channel, "watch_%d" % rack_id)256 service.coreHandler(sys_channel, "watch_%d" % rack_id)
257 self.assertNotIn(sys_channel, listener.listeners)257 self.assertNotIn(sys_channel, listener.listeners)
258 self.assertNotIn(sys_channel, listener.registeredChannels)258 self.assertNotIn(sys_channel, listener.registeredChannels)
259 self.assertEquals(set([rack_id]), service.watching)259 self.assertEqual(set([rack_id]), service.watching)
260 self.assertEquals(set([rack_id]), service.needsDHCPUpdate)260 self.assertEqual(set([rack_id]), service.needsDHCPUpdate)
261 self.assertThat(mock_startProcessing, MockCalledOnceWith())261 self.assertThat(mock_startProcessing, MockCalledOnceWith())
262262
263 def test_coreHandler_raises_ValueError_for_unknown_action(self):263 def test_coreHandler_raises_ValueError_for_unknown_action(self):
@@ -278,7 +278,7 @@ class TestRackControllerService(
278 service.watching = set([rack_id])278 service.watching = set([rack_id])
279 mock_startProcessing = self.patch(service, "startProcessing")279 mock_startProcessing = self.patch(service, "startProcessing")
280 service.dhcpHandler("sys_dhcp_%d" % rack_id, "")280 service.dhcpHandler("sys_dhcp_%d" % rack_id, "")
281 self.assertEquals(set([rack_id]), service.needsDHCPUpdate)281 self.assertEqual(set([rack_id]), service.needsDHCPUpdate)
282 self.assertThat(mock_startProcessing, MockCalledOnceWith())282 self.assertThat(mock_startProcessing, MockCalledOnceWith())
283283
284 def test_dhcpHandler_doesnt_add_to_needsDHCPUpdate(self):284 def test_dhcpHandler_doesnt_add_to_needsDHCPUpdate(self):
@@ -287,7 +287,7 @@ class TestRackControllerService(
287 service = RackControllerService(sentinel.ipcWorker, listener)287 service = RackControllerService(sentinel.ipcWorker, listener)
288 mock_startProcessing = self.patch(service, "startProcessing")288 mock_startProcessing = self.patch(service, "startProcessing")
289 service.dhcpHandler("sys_dhcp_%d" % rack_id, "")289 service.dhcpHandler("sys_dhcp_%d" % rack_id, "")
290 self.assertEquals(set(), service.needsDHCPUpdate)290 self.assertEqual(set(), service.needsDHCPUpdate)
291 self.assertThat(mock_startProcessing, MockNotCalled())291 self.assertThat(mock_startProcessing, MockNotCalled())
292292
293 def test_startProcessing_doesnt_call_start_when_looping_call_running(self):293 def test_startProcessing_doesnt_call_start_when_looping_call_running(self):
diff --git a/src/maasserver/tests/test_region_controller.py b/src/maasserver/tests/test_region_controller.py
index 625314f..aad8dc5 100644
--- a/src/maasserver/tests/test_region_controller.py
+++ b/src/maasserver/tests/test_region_controller.py
@@ -554,7 +554,7 @@ class TestRegionControllerService(MAASServerTestCase):
554 action=RBAC_ACTION.REMOVE, resource_id=4, resource_name="r-4"554 action=RBAC_ACTION.REMOVE, resource_id=4, resource_name="r-4"
555 ),555 ),
556 ]556 ]
557 self.assertEquals(557 self.assertEqual(
558 (558 (
559 [559 [
560 Resource(identifier=2, name="r-2"),560 Resource(identifier=2, name="r-2"),
@@ -704,7 +704,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase):
704 service = RegionControllerService(sentinel.listener)704 service = RegionControllerService(sentinel.listener)
705 self.patch(service, "_getRBACClient").return_value = rbac_client705 self.patch(service, "_getRBACClient").return_value = rbac_client
706706
707 self.assertEquals([], service._rbacSync())707 self.assertEqual([], service._rbacSync())
708 self.assertThat(708 self.assertThat(
709 rbac_client.update_resources,709 rbac_client.update_resources,
710 MockCalledOnceWith("resource-pool", updates=resources),710 MockCalledOnceWith("resource-pool", updates=resources),
@@ -730,7 +730,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase):
730 self.patch(service, "_getRBACClient").return_value = rbac_client730 self.patch(service, "_getRBACClient").return_value = rbac_client
731 service.rbacInit = True731 service.rbacInit = True
732732
733 self.assertEquals(reasons, service._rbacSync())733 self.assertEqual(reasons, service._rbacSync())
734 self.assertThat(734 self.assertThat(
735 rbac_client.update_resources,735 rbac_client.update_resources,
736 MockCalledOnceWith(736 MockCalledOnceWith(
@@ -764,7 +764,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase):
764 self.patch(service, "_getRBACClient").return_value = rbac_client764 self.patch(service, "_getRBACClient").return_value = rbac_client
765 service.rbacInit = True765 service.rbacInit = True
766766
767 self.assertEquals(reasons, service._rbacSync())767 self.assertEqual(reasons, service._rbacSync())
768 self.assertThat(768 self.assertThat(
769 rbac_client.update_resources,769 rbac_client.update_resources,
770 MockCallsMatch(770 MockCallsMatch(
diff --git a/src/maasserver/tests/test_start_up.py b/src/maasserver/tests/test_start_up.py
index 0ef1397..30b267c 100644
--- a/src/maasserver/tests/test_start_up.py
+++ b/src/maasserver/tests/test_start_up.py
@@ -127,7 +127,7 @@ class TestInnerStartUp(MAASServerTestCase):
127 with post_commit_hooks:127 with post_commit_hooks:
128 start_up.inner_start_up(master=True)128 start_up.inner_start_up(master=True)
129 ubuntu = UbuntuOS()129 ubuntu = UbuntuOS()
130 self.assertEquals(130 self.assertEqual(
131 Config.objects.get_config("commissioning_distro_series"),131 Config.objects.get_config("commissioning_distro_series"),
132 ubuntu.get_default_commissioning_release(),132 ubuntu.get_default_commissioning_release(),
133 )133 )
@@ -142,7 +142,7 @@ class TestInnerStartUp(MAASServerTestCase):
142 Config.objects.set_config("commissioning_distro_series", release)142 Config.objects.set_config("commissioning_distro_series", release)
143 with post_commit_hooks:143 with post_commit_hooks:
144 start_up.inner_start_up(master=False)144 start_up.inner_start_up(master=False)
145 self.assertEquals(145 self.assertEqual(
146 Config.objects.get_config("commissioning_distro_series"), release146 Config.objects.get_config("commissioning_distro_series"), release
147 )147 )
148 self.assertFalse(148 self.assertFalse(
diff --git a/src/maasserver/tests/test_stats.py b/src/maasserver/tests/test_stats.py
index 3a74a20..7c5f886 100644
--- a/src/maasserver/tests/test_stats.py
+++ b/src/maasserver/tests/test_stats.py
@@ -67,7 +67,7 @@ class TestMAASStats(MAASServerTestCase):
67 factory.make_Machine(architecture=arch)67 factory.make_Machine(architecture=arch)
68 stats = get_machines_by_architecture()68 stats = get_machines_by_architecture()
69 compare = {"amd64": 1, "i386": 1, "arm64": 1, "ppc64el": 1, "s390x": 1}69 compare = {"amd64": 1, "i386": 1, "arm64": 1, "ppc64el": 1, "s390x": 1}
70 self.assertEquals(stats, compare)70 self.assertEqual(stats, compare)
7171
72 def test_get_kvm_pods_stats(self):72 def test_get_kvm_pods_stats(self):
73 pod1 = self.make_pod(73 pod1 = self.make_pod(
@@ -101,7 +101,7 @@ class TestMAASStats(MAASServerTestCase):
101 },101 },
102 "kvm_utilized_resources": {"cores": 0, "memory": 0, "storage": 0},102 "kvm_utilized_resources": {"cores": 0, "memory": 0, "storage": 0},
103 }103 }
104 self.assertEquals(compare, stats)104 self.assertEqual(compare, stats)
105105
106 def test_get_kvm_pods_stats_no_pod(self):106 def test_get_kvm_pods_stats_no_pod(self):
107 self.assertEqual(107 self.assertEqual(
@@ -183,7 +183,7 @@ class TestMAASStats(MAASServerTestCase):
183 "subnets_v6": len(v6),183 "subnets_v6": len(v6),
184 },184 },
185 }185 }
186 self.assertEquals(json.loads(stats), expected)186 self.assertEqual(json.loads(stats), expected)
187187
188 def test_get_maas_stats_no_machines(self):188 def test_get_maas_stats_no_machines(self):
189 expected = {189 expected = {
@@ -224,7 +224,7 @@ class TestMAASStats(MAASServerTestCase):
224 json.dumps(get_maas_stats()).encode()224 json.dumps(get_maas_stats()).encode()
225 ).decode()225 ).decode()
226 }226 }
227 self.assertEquals(params, get_request_params())227 self.assertEqual(params, get_request_params())
228228
229 def test_make_user_agent_request(self):229 def test_make_user_agent_request(self):
230 factory.make_RegionRackController()230 factory.make_RegionRackController()
diff --git a/src/maasserver/tests/test_status_monitor.py b/src/maasserver/tests/test_status_monitor.py
index c89342c..09b3ad5 100644
--- a/src/maasserver/tests/test_status_monitor.py
+++ b/src/maasserver/tests/test_status_monitor.py
@@ -55,7 +55,7 @@ class TestMarkNodesFailedAfterExpiring(MAASServerTestCase):
55 )55 )
56 # MAAS logs in the status_monitor that the timeout was detected. It56 # MAAS logs in the status_monitor that the timeout was detected. It
57 # then logs the transisition in the node signal handler.57 # then logs the transisition in the node signal handler.
58 self.assertEquals(58 self.assertEqual(
59 len(NODE_FAILURE_MONITORED_STATUS_TRANSITIONS),59 len(NODE_FAILURE_MONITORED_STATUS_TRANSITIONS),
60 len(maaslog.call_args_list) / 2,60 len(maaslog.call_args_list) / 2,
61 )61 )
@@ -128,7 +128,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
128 # No exception should be raised.128 # No exception should be raised.
129 mark_nodes_failed_after_missing_script_timeout(now(), 20)129 mark_nodes_failed_after_missing_script_timeout(now(), 20)
130 node = reload_object(node)130 node = reload_object(node)
131 self.assertEquals(self.status, node.status)131 self.assertEqual(self.status, node.status)
132 self.assertThat(self.maaslog, MockNotCalled())132 self.assertThat(self.maaslog, MockNotCalled())
133133
134 def test_mark_nodes_failed_after_missing_timeout_heartbeat(self):134 def test_mark_nodes_failed_after_missing_timeout_heartbeat(self):
@@ -151,8 +151,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
151 )151 )
152 node = reload_object(node)152 node = reload_object(node)
153153
154 self.assertEquals(self.failed_status, node.status)154 self.assertEqual(self.failed_status, node.status)
155 self.assertEquals(155 self.assertEqual(
156 "Node has not been heard from for the last %s minutes"156 "Node has not been heard from for the last %s minutes"
157 % node_timeout,157 % node_timeout,
158 node.error_description,158 node.error_description,
@@ -173,7 +173,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
173 self.maaslog.call_args_list,173 self.maaslog.call_args_list,
174 )174 )
175 for script_result in script_results:175 for script_result in script_results:
176 self.assertEquals(176 self.assertEqual(
177 SCRIPT_STATUS.TIMEDOUT, reload_object(script_result).status177 SCRIPT_STATUS.TIMEDOUT, reload_object(script_result).status
178 )178 )
179179
@@ -194,7 +194,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
194 mark_nodes_failed_after_missing_script_timeout(current_time, 20)194 mark_nodes_failed_after_missing_script_timeout(current_time, 20)
195 node = reload_object(node)195 node = reload_object(node)
196196
197 self.assertEquals(197 self.assertEqual(
198 current_time198 current_time
199 - (current_time - script_set.last_ping)199 - (current_time - script_set.last_ping)
200 + timedelta(minutes=get_node_timeout(self.status, 20)),200 + timedelta(minutes=get_node_timeout(self.status, 20)),
@@ -226,8 +226,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
226 mark_nodes_failed_after_missing_script_timeout(current_time, 20)226 mark_nodes_failed_after_missing_script_timeout(current_time, 20)
227 node = reload_object(node)227 node = reload_object(node)
228228
229 self.assertEquals(self.failed_status, node.status)229 self.assertEqual(self.failed_status, node.status)
230 self.assertEquals(230 self.assertEqual(
231 "%s has run past it's timeout(%s)"231 "%s has run past it's timeout(%s)"
232 % (232 % (
233 running_script_result.name,233 running_script_result.name,
@@ -254,16 +254,16 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
254 call("%s: Stopped because SSH is disabled" % node.hostname),254 call("%s: Stopped because SSH is disabled" % node.hostname),
255 self.maaslog.call_args_list,255 self.maaslog.call_args_list,
256 )256 )
257 self.assertEquals(257 self.assertEqual(
258 SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status258 SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status
259 )259 )
260 self.assertEquals(260 self.assertEqual(
261 SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status261 SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status
262 )262 )
263 self.assertEquals(263 self.assertEqual(
264 SCRIPT_STATUS.ABORTED, reload_object(pending_script_result).status264 SCRIPT_STATUS.ABORTED, reload_object(pending_script_result).status
265 )265 )
266 self.assertEquals(266 self.assertEqual(
267 SCRIPT_STATUS.TIMEDOUT, reload_object(running_script_result).status267 SCRIPT_STATUS.TIMEDOUT, reload_object(running_script_result).status
268 )268 )
269269
@@ -293,18 +293,18 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
293 mark_nodes_failed_after_missing_script_timeout(current_time, 20)293 mark_nodes_failed_after_missing_script_timeout(current_time, 20)
294 node = reload_object(node)294 node = reload_object(node)
295295
296 self.assertEquals(self.status, node.status)296 self.assertEqual(self.status, node.status)
297 self.assertThat(self.mock_stop, MockNotCalled())297 self.assertThat(self.mock_stop, MockNotCalled())
298 self.assertEquals(298 self.assertEqual(
299 SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status299 SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status
300 )300 )
301 self.assertEquals(301 self.assertEqual(
302 SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status302 SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status
303 )303 )
304 self.assertEquals(304 self.assertEqual(
305 SCRIPT_STATUS.PENDING, reload_object(pending_script_result).status305 SCRIPT_STATUS.PENDING, reload_object(pending_script_result).status
306 )306 )
307 self.assertEquals(307 self.assertEqual(
308 SCRIPT_STATUS.RUNNING, reload_object(running_script_result).status308 SCRIPT_STATUS.RUNNING, reload_object(running_script_result).status
309 )309 )
310310
@@ -352,8 +352,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase):
352 # 5. Get all testing ScriptResults352 # 5. Get all testing ScriptResults
353 # 6. Get all commissioning Scripts353 # 6. Get all commissioning Scripts
354 # 7. Get all testing Scripts354 # 7. Get all testing Scripts
355 self.assertEquals(7, counter_one.num_queries)355 self.assertEqual(7, counter_one.num_queries)
356 self.assertEquals(7, counter_many.num_queries)356 self.assertEqual(7, counter_many.num_queries)
357357
358358
359class TestStatusMonitorService(MAASServerTestCase):359class TestStatusMonitorService(MAASServerTestCase):
diff --git a/src/maasserver/tests/test_storage_layouts.py b/src/maasserver/tests/test_storage_layouts.py
index a15d202..29dcffa 100644
--- a/src/maasserver/tests/test_storage_layouts.py
+++ b/src/maasserver/tests/test_storage_layouts.py
@@ -120,13 +120,13 @@ class TestGetAppliedStorageLayoutForNode(MAASServerTestCase):
120 )120 )
121 layout = self.layout_class(node)121 layout = self.layout_class(node)
122 layout.configure()122 layout.configure()
123 self.assertEquals(123 self.assertEqual(
124 (bd, self.layout_name), get_applied_storage_layout_for_node(node)124 (bd, self.layout_name), get_applied_storage_layout_for_node(node)
125 )125 )
126126
127 def test_returns_unknown(self):127 def test_returns_unknown(self):
128 node = factory.make_Node()128 node = factory.make_Node()
129 self.assertEquals(129 self.assertEqual(
130 (None, "unknown"), get_applied_storage_layout_for_node(node)130 (None, "unknown"), get_applied_storage_layout_for_node(node)
131 )131 )
132132
@@ -418,7 +418,7 @@ class TestStorageLayoutBase(MAASServerTestCase):
418 factory.make_PhysicalBlockDevice(node=node, size=LARGE_BLOCK_DEVICE)418 factory.make_PhysicalBlockDevice(node=node, size=LARGE_BLOCK_DEVICE)
419 layout = StorageLayoutBase(node, {})419 layout = StorageLayoutBase(node, {})
420 self.assertTrue(layout.is_valid(), layout.errors)420 self.assertTrue(layout.is_valid(), layout.errors)
421 self.assertEquals(node.get_boot_disk(), layout.get_root_device())421 self.assertEqual(node.get_boot_disk(), layout.get_root_device())
422422
423 def test_get_root_device_returns_root_device_if_set(self):423 def test_get_root_device_returns_root_device_if_set(self):
424 node = make_Node_with_uefi_boot_method()424 node = make_Node_with_uefi_boot_method()
@@ -959,7 +959,7 @@ class TestFlatStorageLayout(MAASServerTestCase, LayoutHelpersMixin):
959 )959 )
960 layout = FlatStorageLayout(node)960 layout = FlatStorageLayout(node)
961 layout.configure()961 layout.configure()
962 self.assertEquals(bd, layout.is_layout())962 self.assertEqual(bd, layout.is_layout())
963963
964 def test_is_layout_without_uefi(self):964 def test_is_layout_without_uefi(self):
965 node = make_arm64_Node_without_uefi_boot_method()965 node = make_arm64_Node_without_uefi_boot_method()
@@ -968,7 +968,7 @@ class TestFlatStorageLayout(MAASServerTestCase, LayoutHelpersMixin):
968 )968 )
969 layout = FlatStorageLayout(node)969 layout = FlatStorageLayout(node)
970 layout.configure()970 layout.configure()
971 self.assertEquals(bd, layout.is_layout())971 self.assertEqual(bd, layout.is_layout())
972972
973 def test_is_layout_returns_none_when_not_found(self):973 def test_is_layout_returns_none_when_not_found(self):
974 node = make_Node_with_uefi_boot_method()974 node = make_Node_with_uefi_boot_method()
@@ -1275,7 +1275,7 @@ class TestLVMStorageLayout(MAASServerTestCase, LayoutHelpersMixin):
1275 )1275 )
1276 layout = LVMStorageLayout(node)1276 layout = LVMStorageLayout(node)
1277 layout.configure()1277 layout.configure()
1278 self.assertEquals(bd, layout.is_layout())1278 self.assertEqual(bd, layout.is_layout())
12791279
1280 def test_is_layout_without_uefi(self):1280 def test_is_layout_without_uefi(self):
1281 node = make_arm64_Node_without_uefi_boot_method()1281 node = make_arm64_Node_without_uefi_boot_method()
@@ -1284,7 +1284,7 @@ class TestLVMStorageLayout(MAASServerTestCase, LayoutHelpersMixin):
1284 )1284 )
1285 layout = LVMStorageLayout(node)1285 layout = LVMStorageLayout(node)
1286 layout.configure()1286 layout.configure()
1287 self.assertEquals(bd, layout.is_layout())1287 self.assertEqual(bd, layout.is_layout())
12881288
1289 def test_is_layout_returns_none_when_not_found(self):1289 def test_is_layout_returns_none_when_not_found(self):
1290 node = make_Node_with_uefi_boot_method()1290 node = make_Node_with_uefi_boot_method()
@@ -1805,7 +1805,7 @@ class TestBcacheStorageLayout(MAASServerTestCase):
1805 )1805 )
1806 layout = BcacheStorageLayout(node)1806 layout = BcacheStorageLayout(node)
1807 layout.configure()1807 layout.configure()
1808 self.assertEquals(bd, layout.is_layout())1808 self.assertEqual(bd, layout.is_layout())
18091809
1810 def test_is_layout_without_uefi(self):1810 def test_is_layout_without_uefi(self):
1811 node = make_arm64_Node_without_uefi_boot_method()1811 node = make_arm64_Node_without_uefi_boot_method()
@@ -1817,7 +1817,7 @@ class TestBcacheStorageLayout(MAASServerTestCase):
1817 )1817 )
1818 layout = BcacheStorageLayout(node, {"cache_no_part": True})1818 layout = BcacheStorageLayout(node, {"cache_no_part": True})
1819 layout.configure()1819 layout.configure()
1820 self.assertEquals(bd, layout.is_layout())1820 self.assertEqual(bd, layout.is_layout())
18211821
1822 def test_is_layout_returns_none_when_not_found(self):1822 def test_is_layout_returns_none_when_not_found(self):
1823 node = make_Node_with_uefi_boot_method()1823 node = make_Node_with_uefi_boot_method()
@@ -1953,7 +1953,7 @@ class TestVMFS6StorageLayout(MAASServerTestCase):
1953 )1953 )
1954 layout = VMFS6StorageLayout(node)1954 layout = VMFS6StorageLayout(node)
1955 layout.configure()1955 layout.configure()
1956 self.assertEquals(bd, layout.is_layout())1956 self.assertEqual(bd, layout.is_layout())
19571957
1958 def test_is_layout_without_datastore(self):1958 def test_is_layout_without_datastore(self):
1959 node = make_Node_with_uefi_boot_method()1959 node = make_Node_with_uefi_boot_method()
@@ -1965,7 +1965,7 @@ class TestVMFS6StorageLayout(MAASServerTestCase):
1965 # A user can delete the VMFS Datastore but the layout should still1965 # A user can delete the VMFS Datastore but the layout should still
1966 # be detected for the UI.1966 # be detected for the UI.
1967 node.virtualblockdevice_set.delete()1967 node.virtualblockdevice_set.delete()
1968 self.assertEquals(bd, layout.is_layout())1968 self.assertEqual(bd, layout.is_layout())
19691969
1970 def test_is_layout_returns_none_when_not_found(self):1970 def test_is_layout_returns_none_when_not_found(self):
1971 node = make_Node_with_uefi_boot_method()1971 node = make_Node_with_uefi_boot_method()
@@ -2007,8 +2007,8 @@ class TestBlankStorageLayout(MAASServerTestCase):
2007 layout = BlankStorageLayout(node)2007 layout = BlankStorageLayout(node)
2008 if self.layout_class != BlankStorageLayout:2008 if self.layout_class != BlankStorageLayout:
2009 self.assertIsNone(layout.is_layout())2009 self.assertIsNone(layout.is_layout())
2010 self.assertEquals("blank", layout.configure())2010 self.assertEqual("blank", layout.configure())
2011 self.assertEquals(bd, layout.is_layout())2011 self.assertEqual(bd, layout.is_layout())
2012 self.assertFalse(node.virtualblockdevice_set.exists())2012 self.assertFalse(node.virtualblockdevice_set.exists())
2013 for bd in node.blockdevice_set.all():2013 for bd in node.blockdevice_set.all():
2014 self.assertFalse(bd.filesystem_set.exists())2014 self.assertFalse(bd.filesystem_set.exists())
diff --git a/src/maasserver/tests/test_workers.py b/src/maasserver/tests/test_workers.py
index d9cfe0c..e0575ff 100644
--- a/src/maasserver/tests/test_workers.py
+++ b/src/maasserver/tests/test_workers.py
@@ -29,14 +29,14 @@ class TestWorkersCount(MAASTestCase):
29 def test_MAX_WORKERS_COUNT_default_cpucount(self):29 def test_MAX_WORKERS_COUNT_default_cpucount(self):
30 from maasserver.workers import MAX_WORKERS_COUNT30 from maasserver.workers import MAX_WORKERS_COUNT
3131
32 self.assertEquals(os.cpu_count(), MAX_WORKERS_COUNT)32 self.assertEqual(os.cpu_count(), MAX_WORKERS_COUNT)
3333
34 def test_set_max_workers_count(self):34 def test_set_max_workers_count(self):
35 worker_count = random.randint(1, 8)35 worker_count = random.randint(1, 8)
36 set_max_workers_count(worker_count)36 set_max_workers_count(worker_count)
37 from maasserver.workers import MAX_WORKERS_COUNT37 from maasserver.workers import MAX_WORKERS_COUNT
3838
39 self.assertEquals(worker_count, MAX_WORKERS_COUNT)39 self.assertEqual(worker_count, MAX_WORKERS_COUNT)
4040
4141
42class TestWorkersService(MAASTestCase):42class TestWorkersService(MAASTestCase):
@@ -47,8 +47,8 @@ class TestWorkersService(MAASTestCase):
4747
48 from maasserver.workers import MAX_WORKERS_COUNT48 from maasserver.workers import MAX_WORKERS_COUNT
4949
50 self.assertEquals(MAX_WORKERS_COUNT, service.worker_count)50 self.assertEqual(MAX_WORKERS_COUNT, service.worker_count)
51 self.assertEquals(sys.argv[0], service.worker_cmd)51 self.assertEqual(sys.argv[0], service.worker_cmd)
5252
53 def test_calls_spawnWorkers_on_start(self):53 def test_calls_spawnWorkers_on_start(self):
54 service = WorkersService(reactor)54 service = WorkersService(reactor)
@@ -87,12 +87,12 @@ class TestWorkersService(MAASTestCase):
87 try:87 try:
88 service.startService()88 service.startService()
8989
90 self.assertEquals(1, len(service.workers))90 self.assertEqual(1, len(service.workers))
91 pid = list(service.workers.keys())[0]91 pid = list(service.workers.keys())[0]
92 service.killWorker(pid)92 service.killWorker(pid)
93 yield dv.get(timeout=2)93 yield dv.get(timeout=2)
94 self.assertNotIn(pid, service.workers)94 self.assertNotIn(pid, service.workers)
95 self.assertEquals(1, len(service.workers))95 self.assertEqual(1, len(service.workers))
96 finally:96 finally:
97 service.stopService()97 service.stopService()
9898
@@ -115,12 +115,12 @@ class TestWorkersService(MAASTestCase):
115 try:115 try:
116 service.startService()116 service.startService()
117117
118 self.assertEquals(1, len(service.workers))118 self.assertEqual(1, len(service.workers))
119 pid = list(service.workers.keys())[0]119 pid = list(service.workers.keys())[0]
120 service.termWorker(pid)120 service.termWorker(pid)
121 yield dv.get(timeout=2)121 yield dv.get(timeout=2)
122 self.assertNotIn(pid, service.workers)122 self.assertNotIn(pid, service.workers)
123 self.assertEquals(1, len(service.workers))123 self.assertEqual(1, len(service.workers))
124 finally:124 finally:
125 service.stopService()125 service.stopService()
126126
@@ -142,7 +142,7 @@ class TestWorkersService(MAASTestCase):
142142
143 try:143 try:
144 service.startService()144 service.startService()
145 self.assertEquals(1, len(service.workers))145 self.assertEqual(1, len(service.workers))
146 finally:146 finally:
147 service.stopService()147 service.stopService()
148148
diff --git a/src/maasserver/triggers/tests/test_system_listener.py b/src/maasserver/triggers/tests/test_system_listener.py
index 1573f02..6189c4c 100644
--- a/src/maasserver/triggers/tests/test_system_listener.py
+++ b/src/maasserver/triggers/tests/test_system_listener.py
@@ -4104,7 +4104,7 @@ class TestDNSDNSResourceListener(
4104 for pub in DNSPublication.objects.order_by("-id")[:2]4104 for pub in DNSPublication.objects.order_by("-id")[:2]
4105 ]4105 ]
4106 )4106 )
4107 self.assertEquals(4107 self.assertEqual(
4108 list(sources),4108 list(sources),
4109 [4109 [
4110 "zone %s removed resource %s"4110 "zone %s removed resource %s"
@@ -4683,7 +4683,7 @@ class TestDNSInterfaceListener(
4683 for pub in DNSPublication.objects.order_by("-id")[:2]4683 for pub in DNSPublication.objects.order_by("-id")[:2]
4684 ]4684 ]
4685 )4685 )
4686 self.assertEquals(4686 self.assertEqual(
4687 list(sources),4687 list(sources),
4688 [4688 [
4689 "node %s removed interface %s" % (old_hostname, nic_name),4689 "node %s removed interface %s" % (old_hostname, nic_name),
diff --git a/src/maasserver/utils/tests/test_osystems.py b/src/maasserver/utils/tests/test_osystems.py
index ef11c9f..541ee16 100644
--- a/src/maasserver/utils/tests/test_osystems.py
+++ b/src/maasserver/utils/tests/test_osystems.py
@@ -590,7 +590,7 @@ class TestGetReleaseVersionFromString(MAASServerTestCase):
590 )590 )
591591
592 def test_get_release_version_from_string(self):592 def test_get_release_version_from_string(self):
593 self.assertEquals(593 self.assertEqual(
594 self.expected, get_release_version_from_string(self.string)594 self.expected, get_release_version_from_string(self.string)
595 )595 )
596596
@@ -786,7 +786,7 @@ class TestValidateHweKernel(MAASServerTestCase):
786 None, "hwe-16.04-edge", "%s/generic" % arch, "ubuntu", "xenial"786 None, "hwe-16.04-edge", "%s/generic" % arch, "ubuntu", "xenial"
787 )787 )
788788
789 self.assertEquals("hwe-16.04-edge", kernel)789 self.assertEqual("hwe-16.04-edge", kernel)
790 self.assertThat(790 self.assertThat(
791 mock_get_usable_hwe_kernels,791 mock_get_usable_hwe_kernels,
792 MockCalledOnceWith("ubuntu/xenial", arch, "generic"),792 MockCalledOnceWith("ubuntu/xenial", arch, "generic"),
@@ -799,10 +799,10 @@ class TestValidateMinHweKernel(MAASServerTestCase):
799 self.patch(799 self.patch(
800 BootResource.objects, "get_supported_hwe_kernels"800 BootResource.objects, "get_supported_hwe_kernels"
801 ).return_value = (kernel,)801 ).return_value = (kernel,)
802 self.assertEquals(kernel, validate_min_hwe_kernel(kernel))802 self.assertEqual(kernel, validate_min_hwe_kernel(kernel))
803803
804 def test_returns_empty_string_when_none(self):804 def test_returns_empty_string_when_none(self):
805 self.assertEquals("", validate_min_hwe_kernel(None))805 self.assertEqual("", validate_min_hwe_kernel(None))
806806
807 def test_raises_exception_when_not_found(self):807 def test_raises_exception_when_not_found(self):
808 self.assertRaises(808 self.assertRaises(
@@ -886,21 +886,21 @@ class TestGetReleaseFromDB(MAASServerTestCase):
886886
887 def test_finds_by_subarch(self):887 def test_finds_by_subarch(self):
888 release = self.make_boot_source_cache()888 release = self.make_boot_source_cache()
889 self.assertEquals(889 self.assertEqual(
890 release["series"],890 release["series"],
891 get_release_from_db(release["version"].split(" ")[0])["series"],891 get_release_from_db(release["version"].split(" ")[0])["series"],
892 )892 )
893893
894 def test_finds_by_release(self):894 def test_finds_by_release(self):
895 release = self.make_boot_source_cache()895 release = self.make_boot_source_cache()
896 self.assertEquals(896 self.assertEqual(
897 release["version"],897 release["version"],
898 get_release_from_db(release["series"])["version"],898 get_release_from_db(release["series"])["version"],
899 )899 )
900900
901 def test_finds_by_release_first_letter(self):901 def test_finds_by_release_first_letter(self):
902 release = self.make_boot_source_cache()902 release = self.make_boot_source_cache()
903 self.assertEquals(903 self.assertEqual(
904 release["version"],904 release["version"],
905 get_release_from_db(release["series"][0])["version"],905 get_release_from_db(release["series"][0])["version"],
906 )906 )
diff --git a/src/maasserver/utils/tests/test_storage.py b/src/maasserver/utils/tests/test_storage.py
index 695aed0..88761c9 100644
--- a/src/maasserver/utils/tests/test_storage.py
+++ b/src/maasserver/utils/tests/test_storage.py
@@ -174,4 +174,4 @@ class TestUsedFor(MAASServerTestCase):
174 def test_vmfs(self):174 def test_vmfs(self):
175 vmfs = factory.make_VMFS()175 vmfs = factory.make_VMFS()
176 part = vmfs.filesystems.first().partition176 part = vmfs.filesystems.first().partition
177 self.assertEquals("VMFS extent for %s" % vmfs.name, used_for(part))177 self.assertEqual("VMFS extent for %s" % vmfs.name, used_for(part))
diff --git a/src/maasserver/utils/tests/test_utils.py b/src/maasserver/utils/tests/test_utils.py
index 34c6311..5fd47f4 100644
--- a/src/maasserver/utils/tests/test_utils.py
+++ b/src/maasserver/utils/tests/test_utils.py
@@ -223,7 +223,7 @@ class TestFindRackController(MAASServerTestCase):
223 subnet.vlan.dhcp_on = True223 subnet.vlan.dhcp_on = True
224 subnet.vlan.primary_rack = rack_controller224 subnet.vlan.primary_rack = rack_controller
225 subnet.vlan.save()225 subnet.vlan.save()
226 self.assertEquals(226 self.assertEqual(
227 rack_controller.system_id,227 rack_controller.system_id,
228 find_rack_controller(228 find_rack_controller(
229 make_request(factory.pick_ip_in_Subnet(subnet))229 make_request(factory.pick_ip_in_Subnet(subnet))
@@ -305,13 +305,13 @@ class GetRemoteIPTest(MAASTestCase):
305 ip_address = factory.make_ipv4_address()305 ip_address = factory.make_ipv4_address()
306 request = HttpRequest()306 request = HttpRequest()
307 request.META = {"HTTP_X_FORWARDED_FOR": ip_address}307 request.META = {"HTTP_X_FORWARDED_FOR": ip_address}
308 self.assertEquals(ip_address, get_remote_ip(request))308 self.assertEqual(ip_address, get_remote_ip(request))
309309
310 def test_gets_client_ipv6_for_HTTP_X_FORWARDED_FOR(self):310 def test_gets_client_ipv6_for_HTTP_X_FORWARDED_FOR(self):
311 ip_address = factory.make_ipv6_address()311 ip_address = factory.make_ipv6_address()
312 request = HttpRequest()312 request = HttpRequest()
313 request.META = {"HTTP_X_FORWARDED_FOR": ip_address}313 request.META = {"HTTP_X_FORWARDED_FOR": ip_address}
314 self.assertEquals(ip_address, get_remote_ip(request))314 self.assertEqual(ip_address, get_remote_ip(request))
315315
316 def test_gets_client_ip_for_X_FORWARDED_FOR_with_proxies(self):316 def test_gets_client_ip_for_X_FORWARDED_FOR_with_proxies(self):
317 ip_address = factory.make_ipv4_address()317 ip_address = factory.make_ipv4_address()
@@ -321,19 +321,19 @@ class GetRemoteIPTest(MAASTestCase):
321 request.META = {321 request.META = {
322 "HTTP_X_FORWARDED_FOR": "%s, %s, %s" % (ip_address, proxy1, proxy2)322 "HTTP_X_FORWARDED_FOR": "%s, %s, %s" % (ip_address, proxy1, proxy2)
323 }323 }
324 self.assertEquals(ip_address, get_remote_ip(request))324 self.assertEqual(ip_address, get_remote_ip(request))
325325
326 def test_gets_client_ipv4_for_REMOTE_ADDR(self):326 def test_gets_client_ipv4_for_REMOTE_ADDR(self):
327 ip_address = factory.make_ipv4_address()327 ip_address = factory.make_ipv4_address()
328 request = HttpRequest()328 request = HttpRequest()
329 request.META = {"REMOTE_ADDR": ip_address}329 request.META = {"REMOTE_ADDR": ip_address}
330 self.assertEquals(ip_address, get_remote_ip(request))330 self.assertEqual(ip_address, get_remote_ip(request))
331331
332 def test_gets_client_ipv6_for_REMOTE_ADDR(self):332 def test_gets_client_ipv6_for_REMOTE_ADDR(self):
333 ip_address = factory.make_ipv6_address()333 ip_address = factory.make_ipv6_address()
334 request = HttpRequest()334 request = HttpRequest()
335 request.META = {"REMOTE_ADDR": ip_address}335 request.META = {"REMOTE_ADDR": ip_address}
336 self.assertEquals(ip_address, get_remote_ip(request))336 self.assertEqual(ip_address, get_remote_ip(request))
337337
338 def test_fallsback_to_REMOTE_ADDR_for_invalid_X_FORWARDED_FOR(self):338 def test_fallsback_to_REMOTE_ADDR_for_invalid_X_FORWARDED_FOR(self):
339 ip_address = factory.make_ipv4_address()339 ip_address = factory.make_ipv4_address()
@@ -342,7 +342,7 @@ class GetRemoteIPTest(MAASTestCase):
342 "HTTP_X_FORWARDED_FOR": factory.make_name("garbage ip"),342 "HTTP_X_FORWARDED_FOR": factory.make_name("garbage ip"),
343 "REMOTE_ADDR": ip_address,343 "REMOTE_ADDR": ip_address,
344 }344 }
345 self.assertEquals(ip_address, get_remote_ip(request))345 self.assertEqual(ip_address, get_remote_ip(request))
346346
347 def test_returns_None_for_invalid_ip(self):347 def test_returns_None_for_invalid_ip(self):
348 ip_address = factory.make_name("garbage ip")348 ip_address = factory.make_name("garbage ip")
diff --git a/src/maasserver/views/tests/test_account.py b/src/maasserver/views/tests/test_account.py
index ce954da..092c23f 100644
--- a/src/maasserver/views/tests/test_account.py
+++ b/src/maasserver/views/tests/test_account.py
@@ -130,7 +130,7 @@ class TestLogin(MAASServerTestCase):
130 )130 )
131 event = Event.objects.get(type__level=AUDIT)131 event = Event.objects.get(type__level=AUDIT)
132 self.assertIsNotNone(event)132 self.assertIsNotNone(event)
133 self.assertEquals(event.description, "Logged in user.")133 self.assertEqual(event.description, "Logged in user.")
134134
135135
136class TestLogout(MAASServerTestCase):136class TestLogout(MAASServerTestCase):
@@ -164,7 +164,7 @@ class TestLogout(MAASServerTestCase):
164 self.client.post(reverse("logout"))164 self.client.post(reverse("logout"))
165 event = Event.objects.get(type__level=AUDIT)165 event = Event.objects.get(type__level=AUDIT)
166 self.assertIsNotNone(event)166 self.assertIsNotNone(event)
167 self.assertEquals(event.description, "Logged out user.")167 self.assertEqual(event.description, "Logged out user.")
168168
169169
170def token_to_dict(token):170def token_to_dict(token):
@@ -329,7 +329,7 @@ class TestAuthenticate(MAASServerTestCase):
329 )329 )
330 event = Event.objects.get(type__level=AUDIT)330 event = Event.objects.get(type__level=AUDIT)
331 self.assertIsNotNone(event)331 self.assertIsNotNone(event)
332 self.assertEquals(event.description, "Retrieved API (OAuth) token.")332 self.assertEqual(event.description, "Retrieved API (OAuth) token.")
333333
334 def test_authenticate_creates_audit_event_without_tokens(self):334 def test_authenticate_creates_audit_event_without_tokens(self):
335 username = factory.make_name("username")335 username = factory.make_name("username")
@@ -347,7 +347,7 @@ class TestAuthenticate(MAASServerTestCase):
347 )347 )
348 event = Event.objects.get(type__level=AUDIT)348 event = Event.objects.get(type__level=AUDIT)
349 self.assertIsNotNone(event)349 self.assertIsNotNone(event)
350 self.assertEquals(event.description, "Created API (OAuth) token.")350 self.assertEqual(event.description, "Created API (OAuth) token.")
351351
352352
353class TestCSRF(MAASServerTestCase):353class TestCSRF(MAASServerTestCase):
diff --git a/src/maasserver/websockets/handlers/tests/test_bootresource.py b/src/maasserver/websockets/handlers/tests/test_bootresource.py
index e8c889f..7b55a11 100644
--- a/src/maasserver/websockets/handlers/tests/test_bootresource.py
+++ b/src/maasserver/websockets/handlers/tests/test_bootresource.py
@@ -284,7 +284,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
284 handler = BootResourceHandler(owner, {}, None)284 handler = BootResourceHandler(owner, {}, None)
285 response = handler.poll({})285 response = handler.poll({})
286 json_obj = json.loads(response)286 json_obj = json.loads(response)
287 self.assertEquals(287 self.assertEqual(
288 commissioning_series.value,288 commissioning_series.value,
289 json_obj["ubuntu"]["commissioning_series"],289 json_obj["ubuntu"]["commissioning_series"],
290 )290 )
@@ -704,7 +704,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
704 response = handler.poll({})704 response = handler.poll({})
705 json_obj = json.loads(response)705 json_obj = json.loads(response)
706 ubuntu_core_images = json_obj["ubuntu_core_images"]706 ubuntu_core_images = json_obj["ubuntu_core_images"]
707 self.assertEquals(707 self.assertEqual(
708 [708 [
709 {709 {
710 "name": "%s/%s/%s/%s"710 "name": "%s/%s/%s/%s"
@@ -730,7 +730,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
730 response = handler.poll({})730 response = handler.poll({})
731 json_obj = json.loads(response)731 json_obj = json.loads(response)
732 ubuntu_core_images = json_obj["ubuntu_core_images"]732 ubuntu_core_images = json_obj["ubuntu_core_images"]
733 self.assertEquals(733 self.assertEqual(
734 [734 [
735 {735 {
736 "name": "%s/%s/%s/%s"736 "name": "%s/%s/%s/%s"
@@ -750,7 +750,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
750 response = handler.poll({})750 response = handler.poll({})
751 json_obj = json.loads(response)751 json_obj = json.loads(response)
752 other_images = json_obj["other_images"]752 other_images = json_obj["other_images"]
753 self.assertEquals(753 self.assertEqual(
754 [754 [
755 {755 {
756 "name": "%s/%s/%s/%s"756 "name": "%s/%s/%s/%s"
@@ -776,7 +776,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
776 response = handler.poll({})776 response = handler.poll({})
777 json_obj = json.loads(response)777 json_obj = json.loads(response)
778 other_images = json_obj["other_images"]778 other_images = json_obj["other_images"]
779 self.assertEquals(779 self.assertEqual(
780 [780 [
781 {781 {
782 "name": "%s/%s/%s/%s"782 "name": "%s/%s/%s/%s"
@@ -796,7 +796,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
796 factory.make_BootSourceCache(os="ubuntu-core")796 factory.make_BootSourceCache(os="ubuntu-core")
797 response = handler.poll({})797 response = handler.poll({})
798 json_obj = json.loads(response)798 json_obj = json.loads(response)
799 self.assertEquals([], json_obj["other_images"])799 self.assertEqual([], json_obj["other_images"])
800800
801 def test_other_images_filters_out_bootloaders(self):801 def test_other_images_filters_out_bootloaders(self):
802 owner = factory.make_admin()802 owner = factory.make_admin()
@@ -806,7 +806,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
806 )806 )
807 response = handler.poll({})807 response = handler.poll({})
808 json_obj = json.loads(response)808 json_obj = json.loads(response)
809 self.assertEquals([], json_obj["other_images"])809 self.assertEqual([], json_obj["other_images"])
810810
811 def test_prefers_title_from_boot_resource_extra(self):811 def test_prefers_title_from_boot_resource_extra(self):
812 owner = factory.make_admin()812 owner = factory.make_admin()
@@ -815,7 +815,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
815 self.make_other_resource(extra={"title": title})815 self.make_other_resource(extra={"title": title})
816 response = handler.poll({})816 response = handler.poll({})
817 json_obj = json.loads(response)817 json_obj = json.loads(response)
818 self.assertEquals(title, json_obj["resources"][0]["title"])818 self.assertEqual(title, json_obj["resources"][0]["title"])
819819
820820
821class TestBootResourceStopImport(MAASTransactionServerTestCase):821class TestBootResourceStopImport(MAASTransactionServerTestCase):
@@ -830,7 +830,7 @@ class TestBootResourceStopImport(MAASTransactionServerTestCase):
830 mock_stop_import = self.patch_stop_import_resources()830 mock_stop_import = self.patch_stop_import_resources()
831 result = handler.stop_import({})831 result = handler.stop_import({})
832 self.assertThat(mock_stop_import, MockCalledOnceWith())832 self.assertThat(mock_stop_import, MockCalledOnceWith())
833 self.assertEquals(handler.poll({}), result)833 self.assertEqual(handler.poll({}), result)
834834
835835
836class TestBootResourceSaveUbuntu(836class TestBootResourceSaveUbuntu(
diff --git a/src/maasserver/websockets/handlers/tests/test_config.py b/src/maasserver/websockets/handlers/tests/test_config.py
index eccae08..2774982 100644
--- a/src/maasserver/websockets/handlers/tests/test_config.py
+++ b/src/maasserver/websockets/handlers/tests/test_config.py
@@ -52,7 +52,7 @@ class TestConfigHandler(MAASServerTestCase):
52 user = factory.make_User()52 user = factory.make_User()
53 handler = ConfigHandler(user, {}, None)53 handler = ConfigHandler(user, {}, None)
54 Config.objects.set_config("curtin_verbose", True)54 Config.objects.set_config("curtin_verbose", True)
55 self.assertEquals(55 self.assertEqual(
56 {"name": "curtin_verbose", "value": True},56 {"name": "curtin_verbose", "value": True},
57 handler.get({"name": "curtin_verbose"}),57 handler.get({"name": "curtin_verbose"}),
58 )58 )
@@ -62,7 +62,7 @@ class TestConfigHandler(MAASServerTestCase):
62 handler = ConfigHandler(user, {}, None)62 handler = ConfigHandler(user, {}, None)
63 Config.objects.set_config("curtin_verbose", True)63 Config.objects.set_config("curtin_verbose", True)
64 handler.get({"name": "curtin_verbose"})64 handler.get({"name": "curtin_verbose"})
65 self.assertEquals({"curtin_verbose"}, handler.cache["loaded_pks"])65 self.assertEqual({"curtin_verbose"}, handler.cache["loaded_pks"])
6666
67 def test_get_requires_name(self):67 def test_get_requires_name(self):
68 user = factory.make_User()68 user = factory.make_User()
@@ -121,7 +121,7 @@ class TestConfigHandler(MAASServerTestCase):
121 user = factory.make_admin()121 user = factory.make_admin()
122 handler = ConfigHandler(user, {}, None)122 handler = ConfigHandler(user, {}, None)
123 updated = handler.update({"name": "curtin_verbose", "value": True})123 updated = handler.update({"name": "curtin_verbose", "value": True})
124 self.assertEquals({"name": "curtin_verbose", "value": True}, updated)124 self.assertEqual({"name": "curtin_verbose", "value": True}, updated)
125 self.assertTrue(Config.objects.get_config("curtin_verbose"))125 self.assertTrue(Config.objects.get_config("curtin_verbose"))
126126
127 def test_update_cannot_update_uuid(self):127 def test_update_cannot_update_uuid(self):
@@ -159,9 +159,7 @@ class TestConfigHandler(MAASServerTestCase):
159 handler.update,159 handler.update,
160 {"name": "http_proxy", "value": factory.make_name("invalid")},160 {"name": "http_proxy", "value": factory.make_name("invalid")},
161 )161 )
162 self.assertEquals(162 self.assertEqual({"value": ["Enter a valid URL."]}, error.message_dict)
163 {"value": ["Enter a valid URL."]}, error.message_dict
164 )
165163
166 def test_on_listen_returns_None_if_excluded(self):164 def test_on_listen_returns_None_if_excluded(self):
167 user = factory.make_User()165 user = factory.make_User()
diff --git a/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py b/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py
index 92a3989..c1f7b34 100644
--- a/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py
+++ b/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py
@@ -124,7 +124,7 @@ class TestDHCPSnippetHandler(MAASServerTestCase):
124 node = factory.make_Node()124 node = factory.make_Node()
125 handler.update({"id": dhcp_snippet.id, "node": node.system_id})125 handler.update({"id": dhcp_snippet.id, "node": node.system_id})
126 dhcp_snippet = reload_object(dhcp_snippet)126 dhcp_snippet = reload_object(dhcp_snippet)
127 self.assertEquals(node, dhcp_snippet.node)127 self.assertEqual(node, dhcp_snippet.node)
128 event = Event.objects.get(type__level=AUDIT)128 event = Event.objects.get(type__level=AUDIT)
129 self.assertIsNotNone(event)129 self.assertIsNotNone(event)
130 self.assertEqual(130 self.assertEqual(
@@ -168,7 +168,7 @@ class TestDHCPSnippetHandler(MAASServerTestCase):
168 remaining_ids = textfile_ids[:revert_to]168 remaining_ids = textfile_ids[:revert_to]
169 handler.revert({"id": dhcp_snippet.id, "to": revert_to})169 handler.revert({"id": dhcp_snippet.id, "to": revert_to})
170 dhcp_snippet = reload_object(dhcp_snippet)170 dhcp_snippet = reload_object(dhcp_snippet)
171 self.assertEquals(171 self.assertEqual(
172 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,172 VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data,
173 dhcp_snippet.value.data,173 dhcp_snippet.value.data,
174 )174 )
diff --git a/src/maasserver/websockets/handlers/tests/test_discovery.py b/src/maasserver/websockets/handlers/tests/test_discovery.py
index 1597dea..de6e98f 100644
--- a/src/maasserver/websockets/handlers/tests/test_discovery.py
+++ b/src/maasserver/websockets/handlers/tests/test_discovery.py
@@ -87,7 +87,7 @@ class TestDiscoveryHandler(MAASServerTestCase):
87 self.dehydrate_discovery(discovery, for_list=True)87 self.dehydrate_discovery(discovery, for_list=True)
88 for discovery in [d0, d1, d2, d3, d4]88 for discovery in [d0, d1, d2, d3, d4]
89 ]89 ]
90 self.assertEquals(expected_discoveries, handler.list({}))90 self.assertEqual(expected_discoveries, handler.list({}))
9191
92 def test_list_starts_after_first_seen(self):92 def test_list_starts_after_first_seen(self):
93 user = factory.make_User()93 user = factory.make_User()
@@ -108,7 +108,7 @@ class TestDiscoveryHandler(MAASServerTestCase):
108 self.dehydrate_discovery(discovery, for_list=True)108 self.dehydrate_discovery(discovery, for_list=True)
109 for discovery in [d3, d4]109 for discovery in [d3, d4]
110 ]110 ]
111 self.assertEquals(111 self.assertEqual(
112 expected_discoveries, handler.list({"start": first_seen})112 expected_discoveries, handler.list({"start": first_seen})
113 )113 )
114114
diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
index 3f700b0..8f46f16 100644
--- a/src/maasserver/websockets/handlers/tests/test_machine.py
+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
@@ -501,7 +501,7 @@ class TestMachineHandler(MAASServerTestCase):
501 handler._script_results[cached_node.id] = cached_content501 handler._script_results[cached_node.id] = cached_content
502 handler._cache_pks([node])502 handler._cache_pks([node])
503503
504 self.assertEquals(504 self.assertEqual(
505 script_result.id,505 script_result.id,
506 handler._script_results[node.id][506 handler._script_results[node.id][
507 script_result.script.hardware_type507 script_result.script.hardware_type
@@ -515,7 +515,7 @@ class TestMachineHandler(MAASServerTestCase):
515 for result in results515 for result in results
516 ],516 ],
517 )517 )
518 self.assertEquals(518 self.assertEqual(
519 cached_content, handler._script_results[cached_node.id]519 cached_content, handler._script_results[cached_node.id]
520 )520 )
521521
@@ -704,8 +704,8 @@ class TestMachineHandler(MAASServerTestCase):
704 _, _, ret = handler.on_listen_for_active_pk(704 _, _, ret = handler.on_listen_for_active_pk(
705 "update", node.system_id, node705 "update", node.system_id, node
706 )706 )
707 self.assertEquals(ret["commissioning_status"]["passed"], 10)707 self.assertEqual(ret["commissioning_status"]["passed"], 10)
708 self.assertEquals(ret["testing_status"]["passed"], 10)708 self.assertEqual(ret["testing_status"]["passed"], 10)
709709
710 def test_cache_clears_on_reload(self):710 def test_cache_clears_on_reload(self):
711 owner = factory.make_User()711 owner = factory.make_User()
@@ -799,11 +799,11 @@ class TestMachineHandler(MAASServerTestCase):
799 if disk["id"] == node.boot_disk.id:799 if disk["id"] == node.boot_disk.id:
800 for partition in disk["partitions"]:800 for partition in disk["partitions"]:
801 if partition["name"].endswith("-part3"):801 if partition["name"].endswith("-part3"):
802 self.assertEquals(802 self.assertEqual(
803 "VMFS extent for datastore1", partition["used_for"]803 "VMFS extent for datastore1", partition["used_for"]
804 )804 )
805 else:805 else:
806 self.assertEquals(806 self.assertEqual(
807 "VMware ESXi OS partition", partition["used_for"]807 "VMware ESXi OS partition", partition["used_for"]
808 )808 )
809 self.assertDictEqual(809 self.assertDictEqual(
@@ -1694,7 +1694,7 @@ class TestMachineHandler(MAASServerTestCase):
1694 node = factory.make_Node(owner=owner)1694 node = factory.make_Node(owner=owner)
1695 handler = MachineHandler(owner, {}, None)1695 handler = MachineHandler(owner, {}, None)
1696 observed = handler.get_summary_xml({"system_id": node.system_id})1696 observed = handler.get_summary_xml({"system_id": node.system_id})
1697 self.assertEquals("", observed)1697 self.assertEqual("", observed)
16981698
1699 def test_dehydrate_summary_xml_returns_data(self):1699 def test_dehydrate_summary_xml_returns_data(self):
1700 owner = factory.make_User()1700 owner = factory.make_User()
@@ -1708,7 +1708,7 @@ class TestMachineHandler(MAASServerTestCase):
1708 script_result.store_result(exit_status=0, stdout=lldp_data)1708 script_result.store_result(exit_status=0, stdout=lldp_data)
1709 observed = handler.get_summary_xml({"system_id": node.system_id})1709 observed = handler.get_summary_xml({"system_id": node.system_id})
1710 probed_details = merge_details_cleanly(get_single_probed_details(node))1710 probed_details = merge_details_cleanly(get_single_probed_details(node))
1711 self.assertEquals(1711 self.assertEqual(
1712 etree.tostring(probed_details, encoding=str, pretty_print=True),1712 etree.tostring(probed_details, encoding=str, pretty_print=True),
1713 observed,1713 observed,
1714 )1714 )
@@ -1718,7 +1718,7 @@ class TestMachineHandler(MAASServerTestCase):
1718 node = factory.make_Node(owner=owner)1718 node = factory.make_Node(owner=owner)
1719 handler = MachineHandler(owner, {}, None)1719 handler = MachineHandler(owner, {}, None)
1720 observed = handler.get_summary_yaml({"system_id": node.system_id})1720 observed = handler.get_summary_yaml({"system_id": node.system_id})
1721 self.assertEquals("", observed)1721 self.assertEqual("", observed)
17221722
1723 def test_dehydrate_summary_yaml_returns_data(self):1723 def test_dehydrate_summary_yaml_returns_data(self):
1724 owner = factory.make_User()1724 owner = factory.make_User()
@@ -4326,7 +4326,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase):
4326 power_state = yield machine_handler.check_power(4326 power_state = yield machine_handler.check_power(
4327 {"system_id": node.system_id}4327 {"system_id": node.system_id}
4328 )4328 )
4329 self.assertEquals(power_state, POWER_STATE.UNKNOWN)4329 self.assertEqual(power_state, POWER_STATE.UNKNOWN)
43304330
4331 @wait_for_reactor4331 @wait_for_reactor
4332 @inlineCallbacks4332 @inlineCallbacks
@@ -4339,7 +4339,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase):
4339 power_state = yield machine_handler.check_power(4339 power_state = yield machine_handler.check_power(
4340 {"system_id": node.system_id}4340 {"system_id": node.system_id}
4341 )4341 )
4342 self.assertEquals(power_state, POWER_STATE.UNKNOWN)4342 self.assertEqual(power_state, POWER_STATE.UNKNOWN)
43434343
4344 @wait_for_reactor4344 @wait_for_reactor
4345 @inlineCallbacks4345 @inlineCallbacks
@@ -4353,7 +4353,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase):
4353 power_state = yield machine_handler.check_power(4353 power_state = yield machine_handler.check_power(
4354 {"system_id": node.system_id}4354 {"system_id": node.system_id}
4355 )4355 )
4356 self.assertEquals(power_state, POWER_STATE.ERROR)4356 self.assertEqual(power_state, POWER_STATE.ERROR)
4357 self.assertThat(4357 self.assertThat(
4358 mock_log_err,4358 mock_log_err,
4359 MockCalledOnceWith(4359 MockCalledOnceWith(
diff --git a/src/maasserver/websockets/handlers/tests/test_node_result.py b/src/maasserver/websockets/handlers/tests/test_node_result.py
index 5f6b35c..3899f83 100644
--- a/src/maasserver/websockets/handlers/tests/test_node_result.py
+++ b/src/maasserver/websockets/handlers/tests/test_node_result.py
@@ -75,9 +75,7 @@ class TestNodeResultHandler(MAASServerTestCase):
75 user = factory.make_User()75 user = factory.make_User()
76 handler = NodeResultHandler(user, {}, None)76 handler = NodeResultHandler(user, {}, None)
77 node = factory.make_Node()77 node = factory.make_Node()
78 self.assertEquals(78 self.assertEqual(node, handler.get_node({"system_id": node.system_id}))
79 node, handler.get_node({"system_id": node.system_id})
80 )
81 self.assertDictEqual(79 self.assertDictEqual(
82 {node.system_id: node}, handler.cache["system_ids"]80 {node.system_id: node}, handler.cache["system_ids"]
83 )81 )
@@ -88,7 +86,7 @@ class TestNodeResultHandler(MAASServerTestCase):
88 fake_system_id = factory.make_name("system_id")86 fake_system_id = factory.make_name("system_id")
89 fake_node = factory.make_name("node")87 fake_node = factory.make_name("node")
90 handler.cache["system_ids"][fake_system_id] = fake_node88 handler.cache["system_ids"][fake_system_id] = fake_node
91 self.assertEquals(89 self.assertEqual(
92 fake_node, handler.get_node({"system_id": fake_system_id})90 fake_node, handler.get_node({"system_id": fake_system_id})
93 )91 )
9492
@@ -294,7 +292,7 @@ class TestNodeResultHandler(MAASServerTestCase):
294 for _ in range(6):292 for _ in range(6):
295 factory.make_ScriptResult(script_set=script_set)293 factory.make_ScriptResult(script_set=script_set)
296 start = random.randint(0, 5)294 start = random.randint(0, 5)
297 self.assertEquals(295 self.assertEqual(
298 6 - start,296 6 - start,
299 len(handler.list({"system_id": node.system_id, "start": start})),297 len(handler.list({"system_id": node.system_id, "start": start})),
300 )298 )
@@ -307,7 +305,7 @@ class TestNodeResultHandler(MAASServerTestCase):
307 for _ in range(6):305 for _ in range(6):
308 factory.make_ScriptResult(script_set=script_set)306 factory.make_ScriptResult(script_set=script_set)
309 limit = random.randint(0, 6)307 limit = random.randint(0, 6)
310 self.assertEquals(308 self.assertEqual(
311 limit,309 limit,
312 len(handler.list({"system_id": node.system_id, "limit": limit})),310 len(handler.list({"system_id": node.system_id, "limit": limit})),
313 )311 )
@@ -382,7 +380,7 @@ class TestNodeResultHandler(MAASServerTestCase):
382 output=combined,380 output=combined,
383 script_set=factory.make_ScriptSet(node=node),381 script_set=factory.make_ScriptSet(node=node),
384 )382 )
385 self.assertEquals(383 self.assertEqual(
386 combined.decode(),384 combined.decode(),
387 handler.get_result_data(385 handler.get_result_data(
388 {"id": script_result.id, "data_type": "combined"}386 {"id": script_result.id, "data_type": "combined"}
@@ -399,7 +397,7 @@ class TestNodeResultHandler(MAASServerTestCase):
399 stdout=stdout,397 stdout=stdout,
400 script_set=factory.make_ScriptSet(node=node),398 script_set=factory.make_ScriptSet(node=node),
401 )399 )
402 self.assertEquals(400 self.assertEqual(
403 stdout.decode(),401 stdout.decode(),
404 handler.get_result_data(402 handler.get_result_data(
405 {"id": script_result.id, "data_type": "stdout"}403 {"id": script_result.id, "data_type": "stdout"}
@@ -416,7 +414,7 @@ class TestNodeResultHandler(MAASServerTestCase):
416 stderr=stderr,414 stderr=stderr,
417 script_set=factory.make_ScriptSet(node=node),415 script_set=factory.make_ScriptSet(node=node),
418 )416 )
419 self.assertEquals(417 self.assertEqual(
420 stderr.decode(),418 stderr.decode(),
421 handler.get_result_data(419 handler.get_result_data(
422 {"id": script_result.id, "data_type": "stderr"}420 {"id": script_result.id, "data_type": "stderr"}
@@ -433,7 +431,7 @@ class TestNodeResultHandler(MAASServerTestCase):
433 result=result,431 result=result,
434 script_set=factory.make_ScriptSet(node=node),432 script_set=factory.make_ScriptSet(node=node),
435 )433 )
436 self.assertEquals(434 self.assertEqual(
437 result.decode(),435 result.decode(),
438 handler.get_result_data(436 handler.get_result_data(
439 {"id": script_result.id, "data_type": "result"}437 {"id": script_result.id, "data_type": "result"}
@@ -444,7 +442,7 @@ class TestNodeResultHandler(MAASServerTestCase):
444 user = factory.make_User()442 user = factory.make_User()
445 handler = NodeResultHandler(user, {}, None)443 handler = NodeResultHandler(user, {}, None)
446 id = random.randint(0, 100)444 id = random.randint(0, 100)
447 self.assertEquals(445 self.assertEqual(
448 "Unknown ScriptResult id %s" % id,446 "Unknown ScriptResult id %s" % id,
449 handler.get_result_data({"id": id}),447 handler.get_result_data({"id": id}),
450 )448 )
@@ -460,7 +458,7 @@ class TestNodeResultHandler(MAASServerTestCase):
460 script_set=factory.make_ScriptSet(node=node),458 script_set=factory.make_ScriptSet(node=node),
461 )459 )
462 unknown_data_type = factory.make_name("data_type")460 unknown_data_type = factory.make_name("data_type")
463 self.assertEquals(461 self.assertEqual(
464 "Unknown data_type %s" % unknown_data_type,462 "Unknown data_type %s" % unknown_data_type,
465 handler.get_result_data(463 handler.get_result_data(
466 {"id": script_result.id, "data_type": unknown_data_type}464 {"id": script_result.id, "data_type": unknown_data_type}
diff --git a/src/maasserver/websockets/handlers/tests/test_packagerepository.py b/src/maasserver/websockets/handlers/tests/test_packagerepository.py
index 35fb13c..e297d88 100644
--- a/src/maasserver/websockets/handlers/tests/test_packagerepository.py
+++ b/src/maasserver/websockets/handlers/tests/test_packagerepository.py
@@ -90,7 +90,7 @@ class TestPackageRepositoryHandler(MAASServerTestCase):
90 url = factory.make_url(scheme="http")90 url = factory.make_url(scheme="http")
91 handler.update({"id": package_repository.id, "url": url})91 handler.update({"id": package_repository.id, "url": url})
92 package_repository = reload_object(package_repository)92 package_repository = reload_object(package_repository)
93 self.assertEquals(url, package_repository.url)93 self.assertEqual(url, package_repository.url)
94 event = Event.objects.get(type__level=AUDIT)94 event = Event.objects.get(type__level=AUDIT)
95 self.assertIsNotNone(event)95 self.assertIsNotNone(event)
96 self.assertEqual(96 self.assertEqual(
diff --git a/src/maasserver/websockets/handlers/tests/test_subnet.py b/src/maasserver/websockets/handlers/tests/test_subnet.py
index b77fd2a..6ea887b 100644
--- a/src/maasserver/websockets/handlers/tests/test_subnet.py
+++ b/src/maasserver/websockets/handlers/tests/test_subnet.py
@@ -84,7 +84,7 @@ class TestSubnetHandler(MAASServerTestCase):
84 subnet = factory.make_Subnet()84 subnet = factory.make_Subnet()
85 self.assertIsNone(handler.cache.get("staticroutes"))85 self.assertIsNone(handler.cache.get("staticroutes"))
86 queries, _ = count_queries(handler.get, {"id": subnet.id})86 queries, _ = count_queries(handler.get, {"id": subnet.id})
87 self.assertEquals(5, queries)87 self.assertEqual(5, queries)
88 self.assertIsNotNone(handler.cache["staticroutes"])88 self.assertIsNotNone(handler.cache["staticroutes"])
8989
90 def test_list(self):90 def test_list(self):
@@ -121,9 +121,9 @@ class TestSubnetHandler(MAASServerTestCase):
The diff has been truncated for viewing.

Subscribers

People subscribed via source and target branches