Merge ~adam-collard/maas:no-assert-equals into maas:master
- Git
- lp:~adam-collard/maas
- no-assert-equals
- Merge into master
Status: | Merged |
---|---|
Approved by: | Adam Collard |
Approved revision: | 607f0374589b4e4253aa2841cfcd18c64433b053 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~adam-collard/maas:no-assert-equals |
Merge into: | maas:master |
Diff against target: |
8976 lines (+1304/-1315) 143 files modified
src/maascli/actions/tests/test_sshkeys_import.py (+2/-2) src/maascli/tests/test_snappy.py (+2/-2) src/maasserver/api/tests/test_blockdevice.py (+40/-25) src/maasserver/api/tests/test_commissioning.py (+11/-11) src/maasserver/api/tests/test_devices.py (+9/-9) src/maasserver/api/tests/test_dhcpsnippets.py (+5/-5) src/maasserver/api/tests/test_interfaces.py (+5/-5) src/maasserver/api/tests/test_machine.py (+1/-1) src/maasserver/api/tests/test_machines.py (+8/-8) src/maasserver/api/tests/test_node.py (+16/-16) src/maasserver/api/tests/test_pods.py (+1/-1) src/maasserver/api/tests/test_scriptresults.py (+15/-17) src/maasserver/api/tests/test_scripts.py (+46/-46) src/maasserver/api/tests/test_ssl_key.py (+1/-1) src/maasserver/api/tests/test_tag.py (+5/-5) src/maasserver/api/tests/test_users.py (+4/-4) src/maasserver/api/tests/test_vmfs_datastores.py (+6/-6) src/maasserver/api/tests/test_volume_groups.py (+1/-1) src/maasserver/clusterrpc/tests/test_driver_parameters.py (+1/-1) src/maasserver/clusterrpc/tests/test_pods.py (+2/-2) src/maasserver/forms/tests/test_clone.py (+5/-5) src/maasserver/forms/tests/test_dhcpsnippet.py (+4/-4) src/maasserver/forms/tests/test_interface.py (+2/-2) src/maasserver/forms/tests/test_machinewithmacaddresses.py (+2/-2) src/maasserver/forms/tests/test_packagerepository.py (+1/-1) src/maasserver/forms/tests/test_parameters.py (+15/-15) src/maasserver/forms/tests/test_pods.py (+7/-7) src/maasserver/forms/tests/test_script.py (+78/-78) src/maasserver/forms/tests/test_sslkey.py (+1/-1) src/maasserver/forms/tests/test_subnet.py (+3/-3) src/maasserver/forms/tests/test_vlan.py (+3/-3) src/maasserver/models/signals/tests/test_interfaces.py (+6/-6) src/maasserver/models/signals/tests/test_nodes.py (+2/-2) src/maasserver/models/signals/tests/test_podhints.py (+2/-2) src/maasserver/models/signals/tests/test_services.py (+4/-6) src/maasserver/models/signals/tests/test_users.py (+1/-1) src/maasserver/models/tests/test_bmc.py (+17/-17) src/maasserver/models/tests/test_bootresource.py (+2/-2) src/maasserver/models/tests/test_bootsourcecache.py (+2/-2) src/maasserver/models/tests/test_cleansave.py (+27/-27) src/maasserver/models/tests/test_config.py (+2/-2) src/maasserver/models/tests/test_filesystemgroup.py (+3/-3) src/maasserver/models/tests/test_interface.py (+16/-16) src/maasserver/models/tests/test_iscsiblockdevice.py (+1/-1) src/maasserver/models/tests/test_node.py (+50/-50) src/maasserver/models/tests/test_ownerdata.py (+3/-3) src/maasserver/models/tests/test_packagerepository.py (+4/-4) src/maasserver/models/tests/test_partitiontable.py (+3/-3) src/maasserver/models/tests/test_podstoragepool.py (+2/-2) src/maasserver/models/tests/test_versionedtextfile.py (+7/-7) src/maasserver/prometheus/tests/test_stats.py (+3/-3) src/maasserver/rpc/tests/test_boot.py (+12/-12) src/maasserver/rpc/tests/test_leases.py (+9/-11) src/maasserver/rpc/tests/test_nodes.py (+1/-1) src/maasserver/rpc/tests/test_rackcontrollers.py (+2/-2) src/maasserver/rpc/tests/test_regionservice.py (+6/-6) src/maasserver/rpc/tests/test_regionservice_calls.py (+1/-1) src/maasserver/tests/test_audit.py (+5/-5) src/maasserver/tests/test_bootresources.py (+8/-8) src/maasserver/tests/test_bootsources.py (+5/-5) src/maasserver/tests/test_config_forms.py (+1/-1) src/maasserver/tests/test_dhcp.py (+27/-27) src/maasserver/tests/test_eventloop.py (+11/-11) src/maasserver/tests/test_fields.py (+9/-9) src/maasserver/tests/test_ipc.py (+10/-10) src/maasserver/tests/test_listener.py (+3/-3) src/maasserver/tests/test_node_action.py (+3/-5) src/maasserver/tests/test_node_constraint_filter_forms.py (+6/-6) src/maasserver/tests/test_preseed.py (+1/-1) src/maasserver/tests/test_rack_controller.py (+8/-8) src/maasserver/tests/test_region_controller.py (+4/-4) src/maasserver/tests/test_start_up.py (+2/-2) src/maasserver/tests/test_stats.py (+4/-4) src/maasserver/tests/test_status_monitor.py (+19/-19) src/maasserver/tests/test_storage_layouts.py (+13/-13) src/maasserver/tests/test_workers.py (+9/-9) src/maasserver/triggers/tests/test_system_listener.py (+2/-2) src/maasserver/utils/tests/test_osystems.py (+7/-7) src/maasserver/utils/tests/test_storage.py (+1/-1) src/maasserver/utils/tests/test_utils.py (+7/-7) src/maasserver/views/tests/test_account.py (+4/-4) src/maasserver/websockets/handlers/tests/test_bootresource.py (+9/-9) src/maasserver/websockets/handlers/tests/test_config.py (+4/-6) src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py (+2/-2) src/maasserver/websockets/handlers/tests/test_discovery.py (+2/-2) src/maasserver/websockets/handlers/tests/test_machine.py (+12/-12) src/maasserver/websockets/handlers/tests/test_node_result.py (+10/-12) src/maasserver/websockets/handlers/tests/test_packagerepository.py (+1/-1) src/maasserver/websockets/handlers/tests/test_subnet.py (+3/-3) src/maasserver/websockets/handlers/tests/test_zone.py (+3/-3) src/maasserver/websockets/tests/test_protocol.py (+8/-10) src/metadataserver/builtin_scripts/commissioning_scripts/tests/test_bmc_config.py (+4/-4) src/metadataserver/builtin_scripts/testing_scripts/tests/test_badblocks.py (+3/-5) src/metadataserver/builtin_scripts/testing_scripts/tests/test_seven_z.py (+1/-1) src/metadataserver/builtin_scripts/testing_scripts/tests/test_smartctl.py (+9/-9) src/metadataserver/builtin_scripts/tests/test_builtin_scripts.py (+15/-15) src/metadataserver/builtin_scripts/tests/test_hooks.py (+25/-27) src/metadataserver/models/tests/test_nodekey.py (+3/-3) src/metadataserver/models/tests/test_script.py (+11/-11) src/metadataserver/models/tests/test_scriptresult.py (+60/-62) src/metadataserver/models/tests/test_scriptset.py (+37/-41) src/metadataserver/tests/test_api.py (+45/-45) src/metadataserver/tests/test_api_twisted.py (+16/-16) src/metadataserver/tests/test_vendor_data.py (+2/-2) src/metadataserver/user_data/templates/snippets/tests/test_maas_run_remote_scripts.py (+31/-31) src/metadataserver/user_data/tests/test_generate_user_data.py (+18/-18) src/provisioningserver/boot/tests/test_pxe.py (+2/-2) src/provisioningserver/dhcp/tests/test_helper_clean.py (+1/-1) src/provisioningserver/drivers/osystem/tests/test_bootloader.py (+2/-2) src/provisioningserver/drivers/osystem/tests/test_ubuntu.py (+1/-1) src/provisioningserver/drivers/pod/tests/test_base.py (+62/-62) src/provisioningserver/drivers/pod/tests/test_lxd.py (+22/-22) src/provisioningserver/drivers/pod/tests/test_rsd.py (+43/-43) src/provisioningserver/drivers/pod/tests/test_virsh.py (+41/-41) src/provisioningserver/drivers/power/tests/test_msftocs.py (+1/-1) src/provisioningserver/drivers/power/tests/test_openbmc.py (+2/-2) src/provisioningserver/drivers/power/tests/test_recs.py (+4/-4) src/provisioningserver/drivers/power/tests/test_redfish.py (+11/-11) src/provisioningserver/proxy/tests/test_config.py (+2/-2) src/provisioningserver/rackdservices/tests/test_external.py (+6/-6) src/provisioningserver/rackdservices/tests/test_http.py (+17/-17) src/provisioningserver/rackdservices/tests/test_lease_socket_service.py (+5/-5) src/provisioningserver/rackdservices/tests/test_service_monitor_service.py (+2/-2) src/provisioningserver/rackdservices/tests/test_tftp.py (+16/-16) src/provisioningserver/refresh/tests/test_maas_api_helper.py (+8/-8) src/provisioningserver/refresh/tests/test_refresh.py (+2/-2) src/provisioningserver/rpc/tests/test_clusterservice.py (+8/-8) src/provisioningserver/rpc/tests/test_dhcp.py (+6/-6) src/provisioningserver/rpc/tests/test_pods.py (+2/-2) src/provisioningserver/syslog/tests/test_config.py (+2/-2) src/provisioningserver/tests/test_maas_certificates.py (+2/-2) src/provisioningserver/utils/tests/test_avahi.py (+4/-4) src/provisioningserver/utils/tests/test_dhclient.py (+3/-3) src/provisioningserver/utils/tests/test_env.py (+5/-5) src/provisioningserver/utils/tests/test_fs.py (+1/-1) src/provisioningserver/utils/tests/test_ipaddr.py (+1/-1) src/provisioningserver/utils/tests/test_iproute.py (+4/-4) src/provisioningserver/utils/tests/test_lxd.py (+1/-1) src/provisioningserver/utils/tests/test_network.py (+6/-6) src/provisioningserver/utils/tests/test_ps.py (+1/-3) src/provisioningserver/utils/tests/test_service_monitor.py (+10/-10) src/provisioningserver/utils/tests/test_url.py (+2/-2) src/provisioningserver/utils/tests/test_utils.py (+3/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dougal Matthews (community) | Approve | ||
Alberto Donato (community) | Approve | ||
MAAS Lander | Approve | ||
Review via email: mp+394459@code.launchpad.net |
Commit message
s/assertEquals/
Replace all assertEquals with preferred spelling of assertEqual.
Simple bowler script of:
query = Query()
Description of the change
- 607f037... by Adam Collard
-
Blacken
MAAS Lander (maas-lander) wrote : | # |
UNIT TESTS
-b no-assert-equals lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 7169f72b1d771b2
Alberto Donato (ack) wrote : | # |
+1.
I think we should also add a script to run as part of `make lint` which checks that we don't reintroduce those (we can later extend it to look for other things that we want to move away from (like dreaded assertThat).
I don't mean to add it to this branch, just a thought.
Dougal Matthews (d0ugal) wrote : | # |
> (like dreaded assertThat).
We could remove testtools instead, or overwrite it.
def assertThat(self, *args, **kwargs):
raise SyntaxError("not a chance")
- 45f24c3... by Adam Collard
-
Remove the triple quotes that were effectively ignoring tests.
Preview Diff
1 | diff --git a/src/maascli/actions/tests/test_sshkeys_import.py b/src/maascli/actions/tests/test_sshkeys_import.py | |||
2 | index 540dc30..d8de2b4 100644 | |||
3 | --- a/src/maascli/actions/tests/test_sshkeys_import.py | |||
4 | +++ b/src/maascli/actions/tests/test_sshkeys_import.py | |||
5 | @@ -39,14 +39,14 @@ class TestSSHKeysImportAction(MAASTestCase): | |||
6 | 39 | ) | 39 | ) |
7 | 40 | expected_data = ("keysource", ks) | 40 | expected_data = ("keysource", ks) |
8 | 41 | data = action.name_value_pair(ks) | 41 | data = action.name_value_pair(ks) |
10 | 42 | self.assertEquals(data, expected_data) | 42 | self.assertEqual(data, expected_data) |
11 | 43 | 43 | ||
12 | 44 | def test_name_value_pair_returns_sshkey_creds_tuple_for_no_protocol(self): | 44 | def test_name_value_pair_returns_sshkey_creds_tuple_for_no_protocol(self): |
13 | 45 | action = self.make_sshkeys_import_action() | 45 | action = self.make_sshkeys_import_action() |
14 | 46 | ks = factory.make_name("user-id") | 46 | ks = factory.make_name("user-id") |
15 | 47 | expected_data = ("keysource", ks) | 47 | expected_data = ("keysource", ks) |
16 | 48 | data = action.name_value_pair(ks) | 48 | data = action.name_value_pair(ks) |
18 | 49 | self.assertEquals(data, expected_data) | 49 | self.assertEqual(data, expected_data) |
19 | 50 | 50 | ||
20 | 51 | def test_name_value_pair_returns_sshkey_creds_tuple_for_no_input(self): | 51 | def test_name_value_pair_returns_sshkey_creds_tuple_for_no_input(self): |
21 | 52 | action = self.make_sshkeys_import_action() | 52 | action = self.make_sshkeys_import_action() |
22 | diff --git a/src/maascli/tests/test_snappy.py b/src/maascli/tests/test_snappy.py | |||
23 | index 2014071..95458f7 100644 | |||
24 | --- a/src/maascli/tests/test_snappy.py | |||
25 | +++ b/src/maascli/tests/test_snappy.py | |||
26 | @@ -257,7 +257,7 @@ class TestSupervisordHelpers(MAASTestCase): | |||
27 | 257 | mock_popen.return_value = mock_process | 257 | mock_popen.return_value = mock_process |
28 | 258 | snappy.sighup_supervisord() | 258 | snappy.sighup_supervisord() |
29 | 259 | self.assertThat(mock_kill, MockCalledOnceWith(pid, signal.SIGHUP)) | 259 | self.assertThat(mock_kill, MockCalledOnceWith(pid, signal.SIGHUP)) |
31 | 260 | self.assertEquals(2, mock_popen.call_count) | 260 | self.assertEqual(2, mock_popen.call_count) |
32 | 261 | 261 | ||
33 | 262 | 262 | ||
34 | 263 | class TestConfigHelpers(MAASTestCase): | 263 | class TestConfigHelpers(MAASTestCase): |
35 | @@ -302,7 +302,7 @@ class TestConfigHelpers(MAASTestCase): | |||
36 | 302 | def test_set_rpc_secret_sets_secret(self): | 302 | def test_set_rpc_secret_sets_secret(self): |
37 | 303 | secret = factory.make_string() | 303 | secret = factory.make_string() |
38 | 304 | snappy.set_rpc_secret(secret) | 304 | snappy.set_rpc_secret(secret) |
40 | 305 | self.assertEquals(secret, snappy.get_rpc_secret()) | 305 | self.assertEqual(secret, snappy.get_rpc_secret()) |
41 | 306 | 306 | ||
42 | 307 | def test_set_rpc_secret_clears_secret(self): | 307 | def test_set_rpc_secret_clears_secret(self): |
43 | 308 | secret = factory.make_string() | 308 | secret = factory.make_string() |
44 | diff --git a/src/maasserver/api/tests/test_blockdevice.py b/src/maasserver/api/tests/test_blockdevice.py | |||
45 | index 8329df7..e03ecea 100644 | |||
46 | --- a/src/maasserver/api/tests/test_blockdevice.py | |||
47 | +++ b/src/maasserver/api/tests/test_blockdevice.py | |||
48 | @@ -1183,51 +1183,66 @@ class TestBlockDeviceAPI(APITestCase.ForUser): | |||
49 | 1183 | http.client.CONFLICT, response.status_code, response.content | 1183 | http.client.CONFLICT, response.status_code, response.content |
50 | 1184 | ) | 1184 | ) |
51 | 1185 | 1185 | ||
52 | 1186 | """ | ||
53 | 1187 | def test_set_boot_disk_returns_400_for_virtual_device(self): | 1186 | def test_set_boot_disk_returns_400_for_virtual_device(self): |
54 | 1188 | self.become_admin() | 1187 | self.become_admin() |
56 | 1189 | node = factory.make_Node(owner=self.user) | 1188 | node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user) |
57 | 1190 | block_device = factory.make_VirtualBlockDevice(node=node) | 1189 | block_device = factory.make_VirtualBlockDevice(node=node) |
58 | 1191 | uri = get_blockdevice_uri(block_device) | 1190 | uri = get_blockdevice_uri(block_device) |
62 | 1192 | response = self.client.post(uri, { | 1191 | response = self.client.post( |
63 | 1193 | 'op': "set_boot_disk", | 1192 | uri, |
64 | 1194 | }) | 1193 | { |
65 | 1194 | "op": "set_boot_disk", | ||
66 | 1195 | }, | ||
67 | 1196 | ) | ||
68 | 1197 | self.assertEqual( | ||
69 | 1198 | http.client.BAD_REQUEST, response.status_code, response.content | ||
70 | 1199 | ) | ||
71 | 1195 | self.assertEqual( | 1200 | self.assertEqual( |
76 | 1196 | httplib.BAD_REQUEST, response.status_code, response.content) | 1201 | b"Cannot set a virtual block device as the boot disk.", |
77 | 1197 | self.assertEquals( | 1202 | response.content, |
78 | 1198 | "Cannot set a virtual block device as the boot disk.", | 1203 | ) |
75 | 1199 | response.content) | ||
79 | 1200 | 1204 | ||
80 | 1201 | def test_set_boot_disk_returns_403_for_normal_user(self): | 1205 | def test_set_boot_disk_returns_403_for_normal_user(self): |
82 | 1202 | node = factory.make_Node(owner=self.user) | 1206 | node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user) |
83 | 1203 | block_device = factory.make_PhysicalBlockDevice(node=node) | 1207 | block_device = factory.make_PhysicalBlockDevice(node=node) |
84 | 1204 | uri = get_blockdevice_uri(block_device) | 1208 | uri = get_blockdevice_uri(block_device) |
88 | 1205 | response = self.client.post(uri, { | 1209 | response = self.client.post( |
89 | 1206 | 'op': "set_boot_disk", | 1210 | uri, |
90 | 1207 | }) | 1211 | { |
91 | 1212 | "op": "set_boot_disk", | ||
92 | 1213 | }, | ||
93 | 1214 | ) | ||
94 | 1208 | self.assertEqual( | 1215 | self.assertEqual( |
96 | 1209 | httplib.FORBIDDEN, response.status_code, response.content) | 1216 | http.client.FORBIDDEN, response.status_code, response.content |
97 | 1217 | ) | ||
98 | 1210 | 1218 | ||
99 | 1211 | def test_set_boot_disk_returns_404_for_block_device_not_on_node(self): | 1219 | def test_set_boot_disk_returns_404_for_block_device_not_on_node(self): |
100 | 1212 | node = factory.make_Node(owner=self.user) | 1220 | node = factory.make_Node(owner=self.user) |
101 | 1213 | block_device = factory.make_PhysicalBlockDevice() | 1221 | block_device = factory.make_PhysicalBlockDevice() |
102 | 1214 | uri = get_blockdevice_uri(block_device, node=node) | 1222 | uri = get_blockdevice_uri(block_device, node=node) |
106 | 1215 | response = self.client.post(uri, { | 1223 | response = self.client.post( |
107 | 1216 | 'op': "set_boot_disk", | 1224 | uri, |
108 | 1217 | }) | 1225 | { |
109 | 1226 | "op": "set_boot_disk", | ||
110 | 1227 | }, | ||
111 | 1228 | ) | ||
112 | 1218 | self.assertEqual( | 1229 | self.assertEqual( |
114 | 1219 | httplib.NOT_FOUND, response.status_code, response.content) | 1230 | http.client.NOT_FOUND, response.status_code, response.content |
115 | 1231 | ) | ||
116 | 1220 | 1232 | ||
117 | 1221 | def test_set_boot_disk_sets_boot_disk_for_admin(self): | 1233 | def test_set_boot_disk_sets_boot_disk_for_admin(self): |
118 | 1222 | self.become_admin() | 1234 | self.become_admin() |
120 | 1223 | node = factory.make_Node(owner=self.user) | 1235 | node = factory.make_Node(status=NODE_STATUS.READY, owner=self.user) |
121 | 1224 | block_device = factory.make_PhysicalBlockDevice(node=node) | 1236 | block_device = factory.make_PhysicalBlockDevice(node=node) |
122 | 1225 | uri = get_blockdevice_uri(block_device) | 1237 | uri = get_blockdevice_uri(block_device) |
126 | 1226 | response = self.client.post(uri, { | 1238 | response = self.client.post( |
127 | 1227 | 'op': "set_boot_disk", | 1239 | uri, |
128 | 1228 | }) | 1240 | { |
129 | 1241 | "op": "set_boot_disk", | ||
130 | 1242 | }, | ||
131 | 1243 | ) | ||
132 | 1229 | self.assertEqual( | 1244 | self.assertEqual( |
134 | 1230 | httplib.OK, response.status_code, response.content) | 1245 | http.client.OK, response.status_code, response.content |
135 | 1246 | ) | ||
136 | 1231 | node = reload_object(node) | 1247 | node = reload_object(node) |
139 | 1232 | self.assertEquals(block_device, node.boot_disk) | 1248 | self.assertEqual(block_device, node.boot_disk) |
138 | 1233 | """ | ||
140 | diff --git a/src/maasserver/api/tests/test_commissioning.py b/src/maasserver/api/tests/test_commissioning.py | |||
141 | index 33310c3..671125f 100644 | |||
142 | --- a/src/maasserver/api/tests/test_commissioning.py | |||
143 | +++ b/src/maasserver/api/tests/test_commissioning.py | |||
144 | @@ -65,8 +65,8 @@ class AdminCommissioningScriptsAPITest(APITestCase.ForAdmin): | |||
145 | 65 | self.assertThat(response, HasStatusCode(http.client.OK)) | 65 | self.assertThat(response, HasStatusCode(http.client.OK)) |
146 | 66 | 66 | ||
147 | 67 | returned_script = json_load_bytes(response.content) | 67 | returned_script = json_load_bytes(response.content) |
150 | 68 | self.assertEquals(name, returned_script["name"]) | 68 | self.assertEqual(name, returned_script["name"]) |
151 | 69 | self.assertEquals( | 69 | self.assertEqual( |
152 | 70 | content.encode(), b64decode(returned_script["content"]) | 70 | content.encode(), b64decode(returned_script["content"]) |
153 | 71 | ) | 71 | ) |
154 | 72 | 72 | ||
155 | @@ -133,7 +133,7 @@ class AdminCommissioningScriptAPITest(APITestCase.ForAdmin): | |||
156 | 133 | {"content": factory.make_file_upload(content=new_content)}, | 133 | {"content": factory.make_file_upload(content=new_content)}, |
157 | 134 | ) | 134 | ) |
158 | 135 | self.assertThat(response, HasStatusCode(http.client.OK)) | 135 | self.assertThat(response, HasStatusCode(http.client.OK)) |
160 | 136 | self.assertEquals(rc.ALL_OK.content, response.content) | 136 | self.assertEqual(rc.ALL_OK.content, response.content) |
161 | 137 | 137 | ||
162 | 138 | self.assertEqual( | 138 | self.assertEqual( |
163 | 139 | new_content.decode("utf-8"), reload_object(script).script.data | 139 | new_content.decode("utf-8"), reload_object(script).script.data |
164 | @@ -244,7 +244,7 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser): | |||
165 | 244 | for parsed_result in parsed_results: | 244 | for parsed_result in parsed_results: |
166 | 245 | if parsed_result["name"] == script_result.name: | 245 | if parsed_result["name"] == script_result.name: |
167 | 246 | break | 246 | break |
169 | 247 | self.assertEquals( | 247 | self.assertEqual( |
170 | 248 | node.current_commissioning_script_set.scriptresult_set.count() | 248 | node.current_commissioning_script_set.scriptresult_set.count() |
171 | 249 | + node.current_testing_script_set.scriptresult_set.count() | 249 | + node.current_testing_script_set.scriptresult_set.count() |
172 | 250 | + node.current_installation_script_set.scriptresult_set.count(), | 250 | + node.current_installation_script_set.scriptresult_set.count(), |
173 | @@ -264,16 +264,16 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser): | |||
174 | 264 | ], | 264 | ], |
175 | 265 | parsed_result.keys(), | 265 | parsed_result.keys(), |
176 | 266 | ) | 266 | ) |
180 | 267 | self.assertEquals(script_result.id, parsed_result["id"]) | 267 | self.assertEqual(script_result.id, parsed_result["id"]) |
181 | 268 | self.assertEquals(script_result.name, parsed_result["name"]) | 268 | self.assertEqual(script_result.name, parsed_result["name"]) |
182 | 269 | self.assertEquals( | 269 | self.assertEqual( |
183 | 270 | script_result.exit_status, parsed_result["script_result"] | 270 | script_result.exit_status, parsed_result["script_result"] |
184 | 271 | ) | 271 | ) |
187 | 272 | self.assertEquals(script_set.result_type, parsed_result["result_type"]) | 272 | self.assertEqual(script_set.result_type, parsed_result["result_type"]) |
188 | 273 | self.assertEquals( | 273 | self.assertEqual( |
189 | 274 | {"system_id": script_set.node.system_id}, parsed_result["node"] | 274 | {"system_id": script_set.node.system_id}, parsed_result["node"] |
190 | 275 | ) | 275 | ) |
192 | 276 | self.assertEquals( | 276 | self.assertEqual( |
193 | 277 | script_result.stdout, b64decode(parsed_result["data"]) | 277 | script_result.stdout, b64decode(parsed_result["data"]) |
194 | 278 | ) | 278 | ) |
195 | 279 | 279 | ||
196 | @@ -396,7 +396,7 @@ class NodeCommissionResultHandlerAPITest(APITestCase.ForUser): | |||
197 | 396 | response = self.client.get(url, {"name": script_result.name}) | 396 | response = self.client.get(url, {"name": script_result.name}) |
198 | 397 | self.assertThat(response, HasStatusCode(http.client.OK)) | 397 | self.assertThat(response, HasStatusCode(http.client.OK)) |
199 | 398 | parsed_results = json_load_bytes(response.content) | 398 | parsed_results = json_load_bytes(response.content) |
201 | 399 | self.assertEquals(script_result.id, parsed_results[0]["id"]) | 399 | self.assertEqual(script_result.id, parsed_results[0]["id"]) |
202 | 400 | 400 | ||
203 | 401 | def test_list_displays_only_visible_nodes(self): | 401 | def test_list_displays_only_visible_nodes(self): |
204 | 402 | node = factory.make_Node( | 402 | node = factory.make_Node( |
205 | diff --git a/src/maasserver/api/tests/test_devices.py b/src/maasserver/api/tests/test_devices.py | |||
206 | index bd5ff70..c305d20 100644 | |||
207 | --- a/src/maasserver/api/tests/test_devices.py | |||
208 | +++ b/src/maasserver/api/tests/test_devices.py | |||
209 | @@ -56,9 +56,9 @@ class TestDevicesAPI(APITestCase.ForUser): | |||
210 | 56 | device = Device.objects.get(system_id=system_id) | 56 | device = Device.objects.get(system_id=system_id) |
211 | 57 | self.assertEqual(hostname, device.hostname) | 57 | self.assertEqual(hostname, device.hostname) |
212 | 58 | self.assertIsNone(device.parent) | 58 | self.assertIsNone(device.parent) |
216 | 59 | self.assertEquals(device.node_type, NODE_TYPE.DEVICE) | 59 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) |
217 | 60 | self.assertEquals(self.user, device.owner) | 60 | self.assertEqual(self.user, device.owner) |
218 | 61 | self.assertEquals( | 61 | self.assertEqual( |
219 | 62 | macs, {nic.mac_address for nic in device.interface_set.all()} | 62 | macs, {nic.mac_address for nic in device.interface_set.all()} |
220 | 63 | ) | 63 | ) |
221 | 64 | 64 | ||
222 | @@ -81,8 +81,8 @@ class TestDevicesAPI(APITestCase.ForUser): | |||
223 | 81 | ) | 81 | ) |
224 | 82 | system_id = json_load_bytes(response.content)["system_id"] | 82 | system_id = json_load_bytes(response.content)["system_id"] |
225 | 83 | device = Device.objects.get(system_id=system_id) | 83 | device = Device.objects.get(system_id=system_id) |
228 | 84 | self.assertEquals(hostname, device.hostname) | 84 | self.assertEqual(hostname, device.hostname) |
229 | 85 | self.assertEquals(parent, device.parent) | 85 | self.assertEqual(parent, device.parent) |
230 | 86 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) | 86 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) |
231 | 87 | 87 | ||
232 | 88 | def test_POST_creates_device_with_default_domain(self): | 88 | def test_POST_creates_device_with_default_domain(self): |
233 | @@ -99,8 +99,8 @@ class TestDevicesAPI(APITestCase.ForUser): | |||
234 | 99 | ) | 99 | ) |
235 | 100 | system_id = json_load_bytes(response.content)["system_id"] | 100 | system_id = json_load_bytes(response.content)["system_id"] |
236 | 101 | device = Device.objects.get(system_id=system_id) | 101 | device = Device.objects.get(system_id=system_id) |
239 | 102 | self.assertEquals(hostname, device.hostname) | 102 | self.assertEqual(hostname, device.hostname) |
240 | 103 | self.assertEquals(Domain.objects.get_default_domain(), device.domain) | 103 | self.assertEqual(Domain.objects.get_default_domain(), device.domain) |
241 | 104 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) | 104 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) |
242 | 105 | 105 | ||
243 | 106 | def test_POST_creates_device_with_domain(self): | 106 | def test_POST_creates_device_with_domain(self): |
244 | @@ -122,8 +122,8 @@ class TestDevicesAPI(APITestCase.ForUser): | |||
245 | 122 | ) | 122 | ) |
246 | 123 | system_id = json_load_bytes(response.content)["system_id"] | 123 | system_id = json_load_bytes(response.content)["system_id"] |
247 | 124 | device = Device.objects.get(system_id=system_id) | 124 | device = Device.objects.get(system_id=system_id) |
250 | 125 | self.assertEquals(hostname, device.hostname) | 125 | self.assertEqual(hostname, device.hostname) |
251 | 126 | self.assertEquals(domain, device.domain) | 126 | self.assertEqual(domain, device.domain) |
252 | 127 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) | 127 | self.assertEqual(device.node_type, NODE_TYPE.DEVICE) |
253 | 128 | 128 | ||
254 | 129 | def test_POST_without_macs_raises_appropriate_error(self): | 129 | def test_POST_without_macs_raises_appropriate_error(self): |
255 | diff --git a/src/maasserver/api/tests/test_dhcpsnippets.py b/src/maasserver/api/tests/test_dhcpsnippets.py | |||
256 | index 21a0e2e..d844daa 100644 | |||
257 | --- a/src/maasserver/api/tests/test_dhcpsnippets.py | |||
258 | +++ b/src/maasserver/api/tests/test_dhcpsnippets.py | |||
259 | @@ -198,7 +198,7 @@ class TestDHCPSnippetAPI(APITestCase.ForUser): | |||
260 | 198 | http.client.OK, response.status_code, response.content | 198 | http.client.OK, response.status_code, response.content |
261 | 199 | ) | 199 | ) |
262 | 200 | parsed_dhcp_snippet = json.loads(response.content.decode()) | 200 | parsed_dhcp_snippet = json.loads(response.content.decode()) |
264 | 201 | self.assertEquals( | 201 | self.assertEqual( |
265 | 202 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, | 202 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, |
266 | 203 | parsed_dhcp_snippet["value"], | 203 | parsed_dhcp_snippet["value"], |
267 | 204 | ) | 204 | ) |
268 | @@ -326,10 +326,10 @@ class TestDHCPSnippetsAPI(APITestCase.ForUser): | |||
269 | 326 | }, | 326 | }, |
270 | 327 | ) | 327 | ) |
271 | 328 | parsed_dhcp_snippet = json.loads(response.content.decode()) | 328 | parsed_dhcp_snippet = json.loads(response.content.decode()) |
276 | 329 | self.assertEquals(name, parsed_dhcp_snippet["name"]) | 329 | self.assertEqual(name, parsed_dhcp_snippet["name"]) |
277 | 330 | self.assertEquals(value, parsed_dhcp_snippet["value"]) | 330 | self.assertEqual(value, parsed_dhcp_snippet["value"]) |
278 | 331 | self.assertEquals(description, parsed_dhcp_snippet["description"]) | 331 | self.assertEqual(description, parsed_dhcp_snippet["description"]) |
279 | 332 | self.assertEquals(enabled, parsed_dhcp_snippet["enabled"]) | 332 | self.assertEqual(enabled, parsed_dhcp_snippet["enabled"]) |
280 | 333 | 333 | ||
281 | 334 | def test_create_admin_only(self): | 334 | def test_create_admin_only(self): |
282 | 335 | response = self.client.post( | 335 | response = self.client.post( |
283 | diff --git a/src/maasserver/api/tests/test_interfaces.py b/src/maasserver/api/tests/test_interfaces.py | |||
284 | index 396b1bb..890f27d 100644 | |||
285 | --- a/src/maasserver/api/tests/test_interfaces.py | |||
286 | +++ b/src/maasserver/api/tests/test_interfaces.py | |||
287 | @@ -1104,8 +1104,8 @@ class TestNodeInterfaceAPI(APITransactionTestCase.ForUser): | |||
288 | 1104 | http.client.OK, response.status_code, response.content | 1104 | http.client.OK, response.status_code, response.content |
289 | 1105 | ) | 1105 | ) |
290 | 1106 | parsed_interface = json_load_bytes(response.content) | 1106 | parsed_interface = json_load_bytes(response.content) |
293 | 1107 | self.assertEquals(new_name, parsed_interface["name"]) | 1107 | self.assertEqual(new_name, parsed_interface["name"]) |
294 | 1108 | self.assertEquals(new_vlan.vid, parsed_interface["vlan"]["vid"]) | 1108 | self.assertEqual(new_vlan.vid, parsed_interface["vlan"]["vid"]) |
295 | 1109 | 1109 | ||
296 | 1110 | def test_update_bond_interface(self): | 1110 | def test_update_bond_interface(self): |
297 | 1111 | self.become_admin() | 1111 | self.become_admin() |
298 | @@ -1979,7 +1979,7 @@ class TestInterfaceAPIForControllers(APITestCase.ForUser): | |||
299 | 1979 | http.client.OK, response.status_code, response.content | 1979 | http.client.OK, response.status_code, response.content |
300 | 1980 | ) | 1980 | ) |
301 | 1981 | parsed_interface = json_load_bytes(response.content) | 1981 | parsed_interface = json_load_bytes(response.content) |
303 | 1982 | self.assertEquals(new_vlan.id, parsed_interface["vlan"]["id"]) | 1982 | self.assertEqual(new_vlan.id, parsed_interface["vlan"]["id"]) |
304 | 1983 | 1983 | ||
305 | 1984 | def test_update_only_works_for_vlan_field(self): | 1984 | def test_update_only_works_for_vlan_field(self): |
306 | 1985 | self.become_admin() | 1985 | self.become_admin() |
307 | @@ -1997,8 +1997,8 @@ class TestInterfaceAPIForControllers(APITestCase.ForUser): | |||
308 | 1997 | http.client.OK, response.status_code, response.content | 1997 | http.client.OK, response.status_code, response.content |
309 | 1998 | ) | 1998 | ) |
310 | 1999 | parsed_interface = json_load_bytes(response.content) | 1999 | parsed_interface = json_load_bytes(response.content) |
313 | 2000 | self.assertEquals(new_vlan.id, parsed_interface["vlan"]["id"]) | 2000 | self.assertEqual(new_vlan.id, parsed_interface["vlan"]["id"]) |
314 | 2001 | self.assertEquals(interface.name, parsed_interface["name"]) | 2001 | self.assertEqual(interface.name, parsed_interface["name"]) |
315 | 2002 | 2002 | ||
316 | 2003 | def test_update_forbidden_for_vlan_interface(self): | 2003 | def test_update_forbidden_for_vlan_interface(self): |
317 | 2004 | self.become_admin() | 2004 | self.become_admin() |
318 | diff --git a/src/maasserver/api/tests/test_machine.py b/src/maasserver/api/tests/test_machine.py | |||
319 | index dd6495c..9450e24 100644 | |||
320 | --- a/src/maasserver/api/tests/test_machine.py | |||
321 | +++ b/src/maasserver/api/tests/test_machine.py | |||
322 | @@ -854,7 +854,7 @@ class TestMachineAPI(APITestCase.ForUser): | |||
323 | 854 | http.client.OK, response.status_code, response.content | 854 | http.client.OK, response.status_code, response.content |
324 | 855 | ) | 855 | ) |
325 | 856 | response_content = json_load_bytes(response.content) | 856 | response_content = json_load_bytes(response.content) |
327 | 857 | self.assertEquals("virsh", response_content["power_type"]) | 857 | self.assertEqual("virsh", response_content["power_type"]) |
328 | 858 | 858 | ||
329 | 859 | def test_POST_deploy_allocates_ready_machines(self): | 859 | def test_POST_deploy_allocates_ready_machines(self): |
330 | 860 | self.patch(node_module.Node, "_start") | 860 | self.patch(node_module.Node, "_start") |
331 | diff --git a/src/maasserver/api/tests/test_machines.py b/src/maasserver/api/tests/test_machines.py | |||
332 | index 0736ffe..8f43d33 100644 | |||
333 | --- a/src/maasserver/api/tests/test_machines.py | |||
334 | +++ b/src/maasserver/api/tests/test_machines.py | |||
335 | @@ -247,7 +247,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
336 | 247 | validation_errors = json.loads( | 247 | validation_errors = json.loads( |
337 | 248 | response.content.decode(settings.DEFAULT_CHARSET) | 248 | response.content.decode(settings.DEFAULT_CHARSET) |
338 | 249 | )["power_type"] | 249 | )["power_type"] |
340 | 250 | self.assertEquals( | 250 | self.assertEqual( |
341 | 251 | "Select a valid choice. %s is not one of the " | 251 | "Select a valid choice. %s is not one of the " |
342 | 252 | "available choices." % power_type, | 252 | "available choices." % power_type, |
343 | 253 | validation_errors[0], | 253 | validation_errors[0], |
344 | @@ -269,7 +269,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
345 | 269 | response.content.decode(settings.DEFAULT_CHARSET) | 269 | response.content.decode(settings.DEFAULT_CHARSET) |
346 | 270 | )["system_id"] | 270 | )["system_id"] |
347 | 271 | machine = Machine.objects.get(system_id=system_id) | 271 | machine = Machine.objects.get(system_id=system_id) |
349 | 272 | self.assertEquals("", machine.power_type) | 272 | self.assertEqual("", machine.power_type) |
350 | 273 | self.assertEqual({}, machine.power_parameters) | 273 | self.assertEqual({}, machine.power_parameters) |
351 | 274 | 274 | ||
352 | 275 | def test_POST_handles_error_when_unable_to_access_bmc(self): | 275 | def test_POST_handles_error_when_unable_to_access_bmc(self): |
353 | @@ -319,8 +319,8 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
354 | 319 | }, | 319 | }, |
355 | 320 | ) | 320 | ) |
356 | 321 | parsed_result = json.loads(response.content.decode()) | 321 | parsed_result = json.loads(response.content.decode()) |
359 | 322 | self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"]) | 322 | self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"]) |
360 | 323 | self.assertEquals(description, parsed_result["description"]) | 323 | self.assertEqual(description, parsed_result["description"]) |
361 | 324 | 324 | ||
362 | 325 | def test_POST_starts_commissioning_with_selected_test_scripts(self): | 325 | def test_POST_starts_commissioning_with_selected_test_scripts(self): |
363 | 326 | # Regression test for LP1707562 | 326 | # Regression test for LP1707562 |
364 | @@ -342,7 +342,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
365 | 342 | }, | 342 | }, |
366 | 343 | ) | 343 | ) |
367 | 344 | parsed_result = json.loads(response.content.decode()) | 344 | parsed_result = json.loads(response.content.decode()) |
369 | 345 | self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"]) | 345 | self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"]) |
370 | 346 | script_set = ScriptSet.objects.get( | 346 | script_set = ScriptSet.objects.get( |
371 | 347 | id=parsed_result["current_testing_result_id"] | 347 | id=parsed_result["current_testing_result_id"] |
372 | 348 | ) | 348 | ) |
373 | @@ -366,7 +366,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
374 | 366 | }, | 366 | }, |
375 | 367 | ) | 367 | ) |
376 | 368 | parsed_result = json.loads(response.content.decode()) | 368 | parsed_result = json.loads(response.content.decode()) |
378 | 369 | self.assertEquals(NODE_STATUS.COMMISSIONING, parsed_result["status"]) | 369 | self.assertEqual(NODE_STATUS.COMMISSIONING, parsed_result["status"]) |
379 | 370 | 370 | ||
380 | 371 | def test_POST_commission_false(self): | 371 | def test_POST_commission_false(self): |
381 | 372 | # Regression test for LP:1904398 | 372 | # Regression test for LP:1904398 |
382 | @@ -382,7 +382,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
383 | 382 | }, | 382 | }, |
384 | 383 | ) | 383 | ) |
385 | 384 | parsed_result = json.loads(response.content.decode()) | 384 | parsed_result = json.loads(response.content.decode()) |
387 | 385 | self.assertEquals(NODE_STATUS.NEW, parsed_result["status"]) | 385 | self.assertEqual(NODE_STATUS.NEW, parsed_result["status"]) |
388 | 386 | 386 | ||
389 | 387 | def test_GET_lists_machines(self): | 387 | def test_GET_lists_machines(self): |
390 | 388 | # The api allows for fetching the list of Machines. | 388 | # The api allows for fetching the list of Machines. |
391 | @@ -457,7 +457,7 @@ class TestMachinesAPI(APITestCase.ForUser): | |||
392 | 457 | parsed_result = json.loads( | 457 | parsed_result = json.loads( |
393 | 458 | response.content.decode(settings.DEFAULT_CHARSET) | 458 | response.content.decode(settings.DEFAULT_CHARSET) |
394 | 459 | ) | 459 | ) |
396 | 460 | self.assertEquals( | 460 | self.assertEqual( |
397 | 461 | { | 461 | { |
398 | 462 | "id": pod.id, | 462 | "id": pod.id, |
399 | 463 | "name": pod.name, | 463 | "name": pod.name, |
400 | diff --git a/src/maasserver/api/tests/test_node.py b/src/maasserver/api/tests/test_node.py | |||
401 | index 295a72f..e8b84f2 100644 | |||
402 | --- a/src/maasserver/api/tests/test_node.py | |||
403 | +++ b/src/maasserver/api/tests/test_node.py | |||
404 | @@ -258,59 +258,59 @@ class TestNodeAPI(APITestCase.ForUser): | |||
405 | 258 | return SCRIPT_STATUS_CHOICES[status(s)][1] | 258 | return SCRIPT_STATUS_CHOICES[status(s)][1] |
406 | 259 | 259 | ||
407 | 260 | self.assertThat(response, HasStatusCode(http.client.OK)) | 260 | self.assertThat(response, HasStatusCode(http.client.OK)) |
409 | 261 | self.assertEquals( | 261 | self.assertEqual( |
410 | 262 | status(commissioning_script_result), | 262 | status(commissioning_script_result), |
411 | 263 | parsed_result["commissioning_status"], | 263 | parsed_result["commissioning_status"], |
412 | 264 | ) | 264 | ) |
414 | 265 | self.assertEquals( | 265 | self.assertEqual( |
415 | 266 | status_name(commissioning_script_result), | 266 | status_name(commissioning_script_result), |
416 | 267 | parsed_result["commissioning_status_name"], | 267 | parsed_result["commissioning_status_name"], |
417 | 268 | ) | 268 | ) |
420 | 269 | self.assertEquals(testing_status, parsed_result["testing_status"]) | 269 | self.assertEqual(testing_status, parsed_result["testing_status"]) |
421 | 270 | self.assertEquals( | 270 | self.assertEqual( |
422 | 271 | SCRIPT_STATUS_CHOICES[testing_status][1], | 271 | SCRIPT_STATUS_CHOICES[testing_status][1], |
423 | 272 | parsed_result["testing_status_name"], | 272 | parsed_result["testing_status_name"], |
424 | 273 | ) | 273 | ) |
426 | 274 | self.assertEquals( | 274 | self.assertEqual( |
427 | 275 | status(cpu_script_result), parsed_result["cpu_test_status"] | 275 | status(cpu_script_result), parsed_result["cpu_test_status"] |
428 | 276 | ) | 276 | ) |
430 | 277 | self.assertEquals( | 277 | self.assertEqual( |
431 | 278 | status_name(cpu_script_result), | 278 | status_name(cpu_script_result), |
432 | 279 | parsed_result["cpu_test_status_name"], | 279 | parsed_result["cpu_test_status_name"], |
433 | 280 | ) | 280 | ) |
435 | 281 | self.assertEquals( | 281 | self.assertEqual( |
436 | 282 | status(memory_script_result), parsed_result["memory_test_status"] | 282 | status(memory_script_result), parsed_result["memory_test_status"] |
437 | 283 | ) | 283 | ) |
439 | 284 | self.assertEquals( | 284 | self.assertEqual( |
440 | 285 | status_name(memory_script_result), | 285 | status_name(memory_script_result), |
441 | 286 | parsed_result["memory_test_status_name"], | 286 | parsed_result["memory_test_status_name"], |
442 | 287 | ) | 287 | ) |
444 | 288 | self.assertEquals( | 288 | self.assertEqual( |
445 | 289 | status(network_script_result), parsed_result["network_test_status"] | 289 | status(network_script_result), parsed_result["network_test_status"] |
446 | 290 | ) | 290 | ) |
448 | 291 | self.assertEquals( | 291 | self.assertEqual( |
449 | 292 | status_name(network_script_result), | 292 | status_name(network_script_result), |
450 | 293 | parsed_result["network_test_status_name"], | 293 | parsed_result["network_test_status_name"], |
451 | 294 | ) | 294 | ) |
453 | 295 | self.assertEquals( | 295 | self.assertEqual( |
454 | 296 | status(storage_script_result), parsed_result["storage_test_status"] | 296 | status(storage_script_result), parsed_result["storage_test_status"] |
455 | 297 | ) | 297 | ) |
457 | 298 | self.assertEquals( | 298 | self.assertEqual( |
458 | 299 | status_name(storage_script_result), | 299 | status_name(storage_script_result), |
459 | 300 | parsed_result["storage_test_status_name"], | 300 | parsed_result["storage_test_status_name"], |
460 | 301 | ) | 301 | ) |
462 | 302 | self.assertEquals( | 302 | self.assertEqual( |
463 | 303 | status(node_script_result), parsed_result["other_test_status"] | 303 | status(node_script_result), parsed_result["other_test_status"] |
464 | 304 | ) | 304 | ) |
466 | 305 | self.assertEquals( | 305 | self.assertEqual( |
467 | 306 | status_name(node_script_result), | 306 | status_name(node_script_result), |
468 | 307 | parsed_result["other_test_status_name"], | 307 | parsed_result["other_test_status_name"], |
469 | 308 | ) | 308 | ) |
471 | 309 | self.assertEquals( | 309 | self.assertEqual( |
472 | 310 | status(interface_script_result), | 310 | status(interface_script_result), |
473 | 311 | parsed_result["interface_test_status"], | 311 | parsed_result["interface_test_status"], |
474 | 312 | ) | 312 | ) |
476 | 313 | self.assertEquals( | 313 | self.assertEqual( |
477 | 314 | status_name(interface_script_result), | 314 | status_name(interface_script_result), |
478 | 315 | parsed_result["interface_test_status_name"], | 315 | parsed_result["interface_test_status_name"], |
479 | 316 | ) | 316 | ) |
480 | diff --git a/src/maasserver/api/tests/test_pods.py b/src/maasserver/api/tests/test_pods.py | |||
481 | index 5c840e7..33586b5 100644 | |||
482 | --- a/src/maasserver/api/tests/test_pods.py | |||
483 | +++ b/src/maasserver/api/tests/test_pods.py | |||
484 | @@ -491,7 +491,7 @@ class TestPodAPIAdmin(PodAPITestForAdmin, PodMixin): | |||
485 | 491 | self.assertEqual( | 491 | self.assertEqual( |
486 | 492 | http.client.BAD_REQUEST, response.status_code, response.content | 492 | http.client.BAD_REQUEST, response.status_code, response.content |
487 | 493 | ) | 493 | ) |
489 | 494 | self.assertEquals( | 494 | self.assertEqual( |
490 | 495 | b"Pod does not support composability.", response.content | 495 | b"Pod does not support composability.", response.content |
491 | 496 | ) | 496 | ) |
492 | 497 | 497 | ||
493 | diff --git a/src/maasserver/api/tests/test_scriptresults.py b/src/maasserver/api/tests/test_scriptresults.py | |||
494 | index c005848..c775ff8 100644 | |||
495 | --- a/src/maasserver/api/tests/test_scriptresults.py | |||
496 | +++ b/src/maasserver/api/tests/test_scriptresults.py | |||
497 | @@ -760,7 +760,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
498 | 760 | self.assertThat(response, HasStatusCode(http.client.OK)) | 760 | self.assertThat(response, HasStatusCode(http.client.OK)) |
499 | 761 | script_set = reload_object(script_set) | 761 | script_set = reload_object(script_set) |
500 | 762 | self.assertIsNotNone(script_set) | 762 | self.assertIsNotNone(script_set) |
502 | 763 | self.assertEquals(script_set.id, script_result.script_set.id) | 763 | self.assertEqual(script_set.id, script_result.script_set.id) |
503 | 764 | script_result = reload_object(script_result) | 764 | script_result = reload_object(script_result) |
504 | 765 | self.assertTrue(script_result.suppressed) | 765 | self.assertTrue(script_result.suppressed) |
505 | 766 | for script_result in script_results: | 766 | for script_result in script_results: |
506 | @@ -792,7 +792,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
507 | 792 | self.assertThat(response, HasStatusCode(http.client.OK)) | 792 | self.assertThat(response, HasStatusCode(http.client.OK)) |
508 | 793 | script_set = reload_object(script_set) | 793 | script_set = reload_object(script_set) |
509 | 794 | self.assertIsNotNone(script_set) | 794 | self.assertIsNotNone(script_set) |
511 | 795 | self.assertEquals(script_set.id, script_result.script_set.id) | 795 | self.assertEqual(script_set.id, script_result.script_set.id) |
512 | 796 | script_result = reload_object(script_result) | 796 | script_result = reload_object(script_result) |
513 | 797 | self.assertTrue(script_result.suppressed) | 797 | self.assertTrue(script_result.suppressed) |
514 | 798 | for script_result in script_results: | 798 | for script_result in script_results: |
515 | @@ -829,10 +829,10 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
516 | 829 | self.assertThat(response, HasStatusCode(http.client.OK)) | 829 | self.assertThat(response, HasStatusCode(http.client.OK)) |
517 | 830 | script_set = reload_object(script_set) | 830 | script_set = reload_object(script_set) |
518 | 831 | self.assertIsNotNone(script_set) | 831 | self.assertIsNotNone(script_set) |
520 | 832 | self.assertEquals(script_set.id, script_result.script_set.id) | 832 | self.assertEqual(script_set.id, script_result.script_set.id) |
521 | 833 | script_result = reload_object(script_result) | 833 | script_result = reload_object(script_result) |
522 | 834 | self.assertTrue(script_result.suppressed) | 834 | self.assertTrue(script_result.suppressed) |
524 | 835 | self.assertEquals(hardware_type, script_result.script.hardware_type) | 835 | self.assertEqual(hardware_type, script_result.script.hardware_type) |
525 | 836 | for script_result in script_results: | 836 | for script_result in script_results: |
526 | 837 | script_result = reload_object(script_result) | 837 | script_result = reload_object(script_result) |
527 | 838 | self.assertFalse(script_result.suppressed) | 838 | self.assertFalse(script_result.suppressed) |
528 | @@ -858,7 +858,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
529 | 858 | ) | 858 | ) |
530 | 859 | binary.write(script_result.output) | 859 | binary.write(script_result.output) |
531 | 860 | binary.write(b"\n") | 860 | binary.write(b"\n") |
533 | 861 | self.assertEquals(binary.getvalue(), response.content) | 861 | self.assertEqual(binary.getvalue(), response.content) |
534 | 862 | 862 | ||
535 | 863 | def test_download_single(self): | 863 | def test_download_single(self): |
536 | 864 | script_set = self.make_scriptset() | 864 | script_set = self.make_scriptset() |
537 | @@ -869,7 +869,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
538 | 869 | {"op": "download", "filter": script_result.id}, | 869 | {"op": "download", "filter": script_result.id}, |
539 | 870 | ) | 870 | ) |
540 | 871 | self.assertThat(response, HasStatusCode(http.client.OK)) | 871 | self.assertThat(response, HasStatusCode(http.client.OK)) |
542 | 872 | self.assertEquals(script_result.output, response.content) | 872 | self.assertEqual(script_result.output, response.content) |
543 | 873 | 873 | ||
544 | 874 | def test_download_filetype_txt(self): | 874 | def test_download_filetype_txt(self): |
545 | 875 | script_set = self.make_scriptset() | 875 | script_set = self.make_scriptset() |
546 | @@ -880,7 +880,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
547 | 880 | {"op": "download", "filetype": "txt", "filters": script_result.id}, | 880 | {"op": "download", "filetype": "txt", "filters": script_result.id}, |
548 | 881 | ) | 881 | ) |
549 | 882 | self.assertThat(response, HasStatusCode(http.client.OK)) | 882 | self.assertThat(response, HasStatusCode(http.client.OK)) |
551 | 883 | self.assertEquals(script_result.output, response.content) | 883 | self.assertEqual(script_result.output, response.content) |
552 | 884 | 884 | ||
553 | 885 | def test_download_filetype_tar_xz(self): | 885 | def test_download_filetype_tar_xz(self): |
554 | 886 | script_set = self.make_scriptset() | 886 | script_set = self.make_scriptset() |
555 | @@ -935,7 +935,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
556 | 935 | }, | 935 | }, |
557 | 936 | ) | 936 | ) |
558 | 937 | self.assertThat(response, HasStatusCode(http.client.OK)) | 937 | self.assertThat(response, HasStatusCode(http.client.OK)) |
560 | 938 | self.assertEquals(script_result.output, response.content) | 938 | self.assertEqual(script_result.output, response.content) |
561 | 939 | 939 | ||
562 | 940 | def test_download_output_stdout(self): | 940 | def test_download_output_stdout(self): |
563 | 941 | script_set = self.make_scriptset() | 941 | script_set = self.make_scriptset() |
564 | @@ -946,7 +946,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
565 | 946 | {"op": "download", "filter": script_result.id, "output": "stdout"}, | 946 | {"op": "download", "filter": script_result.id, "output": "stdout"}, |
566 | 947 | ) | 947 | ) |
567 | 948 | self.assertThat(response, HasStatusCode(http.client.OK)) | 948 | self.assertThat(response, HasStatusCode(http.client.OK)) |
569 | 949 | self.assertEquals(script_result.stdout, response.content) | 949 | self.assertEqual(script_result.stdout, response.content) |
570 | 950 | 950 | ||
571 | 951 | def test_download_output_stderr(self): | 951 | def test_download_output_stderr(self): |
572 | 952 | script_set = self.make_scriptset() | 952 | script_set = self.make_scriptset() |
573 | @@ -957,7 +957,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
574 | 957 | {"op": "download", "filter": script_result.id, "output": "stderr"}, | 957 | {"op": "download", "filter": script_result.id, "output": "stderr"}, |
575 | 958 | ) | 958 | ) |
576 | 959 | self.assertThat(response, HasStatusCode(http.client.OK)) | 959 | self.assertThat(response, HasStatusCode(http.client.OK)) |
578 | 960 | self.assertEquals(script_result.stderr, response.content) | 960 | self.assertEqual(script_result.stderr, response.content) |
579 | 961 | 961 | ||
580 | 962 | def test_download_output_result(self): | 962 | def test_download_output_result(self): |
581 | 963 | script_set = self.make_scriptset() | 963 | script_set = self.make_scriptset() |
582 | @@ -968,7 +968,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
583 | 968 | {"op": "download", "filter": script_result.id, "output": "result"}, | 968 | {"op": "download", "filter": script_result.id, "output": "result"}, |
584 | 969 | ) | 969 | ) |
585 | 970 | self.assertThat(response, HasStatusCode(http.client.OK)) | 970 | self.assertThat(response, HasStatusCode(http.client.OK)) |
587 | 971 | self.assertEquals(script_result.result, response.content) | 971 | self.assertEqual(script_result.result, response.content) |
588 | 972 | 972 | ||
589 | 973 | def test_download_output_all(self): | 973 | def test_download_output_all(self): |
590 | 974 | script_set = self.make_scriptset() | 974 | script_set = self.make_scriptset() |
591 | @@ -1002,7 +1002,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
592 | 1002 | binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode()) | 1002 | binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode()) |
593 | 1003 | binary.write(script_result.result) | 1003 | binary.write(script_result.result) |
594 | 1004 | binary.write(b"\n") | 1004 | binary.write(b"\n") |
596 | 1005 | self.assertEquals(binary.getvalue(), response.content) | 1005 | self.assertEqual(binary.getvalue(), response.content) |
597 | 1006 | 1006 | ||
598 | 1007 | def test_download_filters(self): | 1007 | def test_download_filters(self): |
599 | 1008 | scripts = [factory.make_Script() for _ in range(10)] | 1008 | scripts = [factory.make_Script() for _ in range(10)] |
600 | @@ -1043,9 +1043,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
601 | 1043 | script_set.id, | 1043 | script_set.id, |
602 | 1044 | ) | 1044 | ) |
603 | 1045 | with tarfile.open(mode="r", fileobj=BytesIO(response.content)) as tar: | 1045 | with tarfile.open(mode="r", fileobj=BytesIO(response.content)) as tar: |
607 | 1046 | self.assertEquals( | 1046 | self.assertEqual(len(set(filtered_results)), len(tar.getmembers())) |
605 | 1047 | len(set(filtered_results)), len(tar.getmembers()) | ||
606 | 1048 | ) | ||
608 | 1049 | for script_result in filtered_results: | 1047 | for script_result in filtered_results: |
609 | 1050 | path = os.path.join(root_dir, script_result.name) | 1048 | path = os.path.join(root_dir, script_result.name) |
610 | 1051 | member = tar.getmember(path) | 1049 | member = tar.getmember(path) |
611 | @@ -1081,7 +1079,7 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
612 | 1081 | }, | 1079 | }, |
613 | 1082 | ) | 1080 | ) |
614 | 1083 | self.assertThat(response, HasStatusCode(http.client.OK)) | 1081 | self.assertThat(response, HasStatusCode(http.client.OK)) |
616 | 1084 | self.assertEquals(script_result.output, response.content) | 1082 | self.assertEqual(script_result.output, response.content) |
617 | 1085 | 1083 | ||
618 | 1086 | def test_download_shows_results_from_all_disks(self): | 1084 | def test_download_shows_results_from_all_disks(self): |
619 | 1087 | # Regression test for #LP:1755060 | 1085 | # Regression test for #LP:1755060 |
620 | @@ -1192,4 +1190,4 @@ class TestNodeScriptResultAPI(APITestCase.ForUser): | |||
621 | 1192 | binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode()) | 1190 | binary.write(("%s %s %s\n" % (dashes, filename, dashes)).encode()) |
622 | 1193 | binary.write(other_result.result) | 1191 | binary.write(other_result.result) |
623 | 1194 | binary.write(b"\n") | 1192 | binary.write(b"\n") |
625 | 1195 | self.assertEquals(binary.getvalue(), response.content) | 1193 | self.assertEqual(binary.getvalue(), response.content) |
626 | diff --git a/src/maasserver/api/tests/test_scripts.py b/src/maasserver/api/tests/test_scripts.py | |||
627 | index c2a0d21..7718c7a 100644 | |||
628 | --- a/src/maasserver/api/tests/test_scripts.py | |||
629 | +++ b/src/maasserver/api/tests/test_scripts.py | |||
630 | @@ -77,18 +77,18 @@ class TestScriptsAPI(APITestCase.ForUser): | |||
631 | 77 | parsed_result = json_load_bytes(response.content) | 77 | parsed_result = json_load_bytes(response.content) |
632 | 78 | script = Script.objects.get(id=int(parsed_result["id"])) | 78 | script = Script.objects.get(id=int(parsed_result["id"])) |
633 | 79 | 79 | ||
637 | 80 | self.assertEquals(name, script.name) | 80 | self.assertEqual(name, script.name) |
638 | 81 | self.assertEquals(title, script.title) | 81 | self.assertEqual(title, script.title) |
639 | 82 | self.assertEquals(description, script.description) | 82 | self.assertEqual(description, script.description) |
640 | 83 | self.assertThat(script.tags, ContainsAll(tags)) | 83 | self.assertThat(script.tags, ContainsAll(tags)) |
644 | 84 | self.assertEquals(script_type, script.script_type) | 84 | self.assertEqual(script_type, script.script_type) |
645 | 85 | self.assertEquals(hardware_type, script.hardware_type) | 85 | self.assertEqual(hardware_type, script.hardware_type) |
646 | 86 | self.assertEquals(parallel, script.parallel) | 86 | self.assertEqual(parallel, script.parallel) |
647 | 87 | self.assertDictEqual(packages, script.packages) | 87 | self.assertDictEqual(packages, script.packages) |
652 | 88 | self.assertEquals(timeout, script.timeout.seconds) | 88 | self.assertEqual(timeout, script.timeout.seconds) |
653 | 89 | self.assertEquals(destructive, script.destructive) | 89 | self.assertEqual(destructive, script.destructive) |
654 | 90 | self.assertEquals(script_content, script.script.data) | 90 | self.assertEqual(script_content, script.script.data) |
655 | 91 | self.assertEquals(comment, script.script.comment) | 91 | self.assertEqual(comment, script.script.comment) |
656 | 92 | 92 | ||
657 | 93 | def test_POST_gets_name_from_filename(self): | 93 | def test_POST_gets_name_from_filename(self): |
658 | 94 | self.become_admin() | 94 | self.become_admin() |
659 | @@ -125,18 +125,18 @@ class TestScriptsAPI(APITestCase.ForUser): | |||
660 | 125 | parsed_result = json_load_bytes(response.content) | 125 | parsed_result = json_load_bytes(response.content) |
661 | 126 | script = Script.objects.get(id=int(parsed_result["id"])) | 126 | script = Script.objects.get(id=int(parsed_result["id"])) |
662 | 127 | 127 | ||
666 | 128 | self.assertEquals(name, script.name) | 128 | self.assertEqual(name, script.name) |
667 | 129 | self.assertEquals(title, script.title) | 129 | self.assertEqual(title, script.title) |
668 | 130 | self.assertEquals(description, script.description) | 130 | self.assertEqual(description, script.description) |
669 | 131 | self.assertThat(script.tags, ContainsAll(tags)) | 131 | self.assertThat(script.tags, ContainsAll(tags)) |
673 | 132 | self.assertEquals(script_type, script.script_type) | 132 | self.assertEqual(script_type, script.script_type) |
674 | 133 | self.assertEquals(hardware_type, script.hardware_type) | 133 | self.assertEqual(hardware_type, script.hardware_type) |
675 | 134 | self.assertEquals(parallel, script.parallel) | 134 | self.assertEqual(parallel, script.parallel) |
676 | 135 | self.assertDictEqual(packages, script.packages) | 135 | self.assertDictEqual(packages, script.packages) |
681 | 136 | self.assertEquals(timeout, script.timeout.seconds) | 136 | self.assertEqual(timeout, script.timeout.seconds) |
682 | 137 | self.assertEquals(destructive, script.destructive) | 137 | self.assertEqual(destructive, script.destructive) |
683 | 138 | self.assertEquals(script_content, script.script.data) | 138 | self.assertEqual(script_content, script.script.data) |
684 | 139 | self.assertEquals(comment, script.script.comment) | 139 | self.assertEqual(comment, script.script.comment) |
685 | 140 | 140 | ||
686 | 141 | def test_POST_requires_admin(self): | 141 | def test_POST_requires_admin(self): |
687 | 142 | response = self.client.post(self.get_scripts_uri()) | 142 | response = self.client.post(self.get_scripts_uri()) |
688 | @@ -224,7 +224,7 @@ class TestScriptsAPI(APITestCase.ForUser): | |||
689 | 224 | parsed_results = json_load_bytes(response.content) | 224 | parsed_results = json_load_bytes(response.content) |
690 | 225 | 225 | ||
691 | 226 | for result in parsed_results: | 226 | for result in parsed_results: |
693 | 227 | self.assertEquals( | 227 | self.assertEqual( |
694 | 228 | scripts[result["name"]].script.data.encode(), | 228 | scripts[result["name"]].script.data.encode(), |
695 | 229 | b64decode(result["history"][0]["data"].encode()), | 229 | b64decode(result["history"][0]["data"].encode()), |
696 | 230 | ) | 230 | ) |
697 | @@ -298,7 +298,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
698 | 298 | for result_rev in history: | 298 | for result_rev in history: |
699 | 299 | for rev in script.script.previous_versions(): | 299 | for rev in script.script.previous_versions(): |
700 | 300 | if rev.id == result_rev["id"]: | 300 | if rev.id == result_rev["id"]: |
702 | 301 | self.assertEquals( | 301 | self.assertEqual( |
703 | 302 | { | 302 | { |
704 | 303 | "id": rev.id, | 303 | "id": rev.id, |
705 | 304 | "comment": rev.comment, | 304 | "comment": rev.comment, |
706 | @@ -354,7 +354,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
707 | 354 | for result_rev in history: | 354 | for result_rev in history: |
708 | 355 | for rev in script.script.previous_versions(): | 355 | for rev in script.script.previous_versions(): |
709 | 356 | if rev.id == result_rev["id"]: | 356 | if rev.id == result_rev["id"]: |
711 | 357 | self.assertEquals( | 357 | self.assertEqual( |
712 | 358 | { | 358 | { |
713 | 359 | "id": rev.id, | 359 | "id": rev.id, |
714 | 360 | "comment": rev.comment, | 360 | "comment": rev.comment, |
715 | @@ -428,18 +428,18 @@ class TestScriptAPI(APITestCase.ForUser): | |||
716 | 428 | self.assertThat(response, HasStatusCode(http.client.OK)) | 428 | self.assertThat(response, HasStatusCode(http.client.OK)) |
717 | 429 | script = reload_object(script) | 429 | script = reload_object(script) |
718 | 430 | 430 | ||
722 | 431 | self.assertEquals(name, script.name) | 431 | self.assertEqual(name, script.name) |
723 | 432 | self.assertEquals(title, script.title) | 432 | self.assertEqual(title, script.title) |
724 | 433 | self.assertEquals(description, script.description) | 433 | self.assertEqual(description, script.description) |
725 | 434 | self.assertThat(script.tags, ContainsAll(tags)) | 434 | self.assertThat(script.tags, ContainsAll(tags)) |
729 | 435 | self.assertEquals(script_type, script.script_type) | 435 | self.assertEqual(script_type, script.script_type) |
730 | 436 | self.assertEquals(hardware_type, script.hardware_type) | 436 | self.assertEqual(hardware_type, script.hardware_type) |
731 | 437 | self.assertEquals(parallel, script.parallel) | 437 | self.assertEqual(parallel, script.parallel) |
732 | 438 | self.assertDictEqual(packages, script.packages) | 438 | self.assertDictEqual(packages, script.packages) |
737 | 439 | self.assertEquals(timeout, script.timeout.seconds) | 439 | self.assertEqual(timeout, script.timeout.seconds) |
738 | 440 | self.assertEquals(destructive, script.destructive) | 440 | self.assertEqual(destructive, script.destructive) |
739 | 441 | self.assertEquals(script_content, script.script.data) | 441 | self.assertEqual(script_content, script.script.data) |
740 | 442 | self.assertEquals(comment, script.script.comment) | 442 | self.assertEqual(comment, script.script.comment) |
741 | 443 | self.assertIsNotNone(script.script.previous_version) | 443 | self.assertIsNotNone(script.script.previous_version) |
742 | 444 | 444 | ||
743 | 445 | def test_PUT_gets_name_from_filename(self): | 445 | def test_PUT_gets_name_from_filename(self): |
744 | @@ -477,17 +477,17 @@ class TestScriptAPI(APITestCase.ForUser): | |||
745 | 477 | self.assertThat(response, HasStatusCode(http.client.OK)) | 477 | self.assertThat(response, HasStatusCode(http.client.OK)) |
746 | 478 | script = reload_object(script) | 478 | script = reload_object(script) |
747 | 479 | 479 | ||
750 | 480 | self.assertEquals(name, script.name) | 480 | self.assertEqual(name, script.name) |
751 | 481 | self.assertEquals(description, script.description) | 481 | self.assertEqual(description, script.description) |
752 | 482 | self.assertThat(script.tags, ContainsAll(tags)) | 482 | self.assertThat(script.tags, ContainsAll(tags)) |
756 | 483 | self.assertEquals(script_type, script.script_type) | 483 | self.assertEqual(script_type, script.script_type) |
757 | 484 | self.assertEquals(hardware_type, script.hardware_type) | 484 | self.assertEqual(hardware_type, script.hardware_type) |
758 | 485 | self.assertEquals(parallel, script.parallel) | 485 | self.assertEqual(parallel, script.parallel) |
759 | 486 | self.assertDictEqual(packages, script.packages) | 486 | self.assertDictEqual(packages, script.packages) |
764 | 487 | self.assertEquals(timeout, script.timeout.seconds) | 487 | self.assertEqual(timeout, script.timeout.seconds) |
765 | 488 | self.assertEquals(destructive, script.destructive) | 488 | self.assertEqual(destructive, script.destructive) |
766 | 489 | self.assertEquals(script_content, script.script.data) | 489 | self.assertEqual(script_content, script.script.data) |
767 | 490 | self.assertEquals(comment, script.script.comment) | 490 | self.assertEqual(comment, script.script.comment) |
768 | 491 | self.assertIsNotNone(script.script.previous_version) | 491 | self.assertIsNotNone(script.script.previous_version) |
769 | 492 | 492 | ||
770 | 493 | def test_PUT_admin_only(self): | 493 | def test_PUT_admin_only(self): |
771 | @@ -503,7 +503,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
772 | 503 | self.get_script_uri(script), {"op": "download"} | 503 | self.get_script_uri(script), {"op": "download"} |
773 | 504 | ) | 504 | ) |
774 | 505 | self.assertThat(response, HasStatusCode(http.client.OK)) | 505 | self.assertThat(response, HasStatusCode(http.client.OK)) |
776 | 506 | self.assertEquals(script.script.data, response.content.decode()) | 506 | self.assertEqual(script.script.data, response.content.decode()) |
777 | 507 | 507 | ||
778 | 508 | def test_download_gets_previous_revision(self): | 508 | def test_download_gets_previous_revision(self): |
779 | 509 | script = factory.make_Script() | 509 | script = factory.make_Script() |
780 | @@ -514,7 +514,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
781 | 514 | {"op": "download", "revision": script.script.previous_version.id}, | 514 | {"op": "download", "revision": script.script.previous_version.id}, |
782 | 515 | ) | 515 | ) |
783 | 516 | self.assertThat(response, HasStatusCode(http.client.OK)) | 516 | self.assertThat(response, HasStatusCode(http.client.OK)) |
785 | 517 | self.assertEquals( | 517 | self.assertEqual( |
786 | 518 | script.script.previous_version.data, response.content.decode() | 518 | script.script.previous_version.data, response.content.decode() |
787 | 519 | ) | 519 | ) |
788 | 520 | 520 | ||
789 | @@ -527,7 +527,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
790 | 527 | {"op": "download", "rev": script.script.previous_version.id}, | 527 | {"op": "download", "rev": script.script.previous_version.id}, |
791 | 528 | ) | 528 | ) |
792 | 529 | self.assertThat(response, HasStatusCode(http.client.OK)) | 529 | self.assertThat(response, HasStatusCode(http.client.OK)) |
794 | 530 | self.assertEquals( | 530 | self.assertEqual( |
795 | 531 | script.script.previous_version.data, response.content.decode() | 531 | script.script.previous_version.data, response.content.decode() |
796 | 532 | ) | 532 | ) |
797 | 533 | 533 | ||
798 | @@ -555,7 +555,7 @@ class TestScriptAPI(APITestCase.ForUser): | |||
799 | 555 | ) | 555 | ) |
800 | 556 | self.assertThat(response, HasStatusCode(http.client.OK)) | 556 | self.assertThat(response, HasStatusCode(http.client.OK)) |
801 | 557 | script = reload_object(script) | 557 | script = reload_object(script) |
803 | 558 | self.assertEquals( | 558 | self.assertEqual( |
804 | 559 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, | 559 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, |
805 | 560 | script.script.data, | 560 | script.script.data, |
806 | 561 | ) | 561 | ) |
807 | diff --git a/src/maasserver/api/tests/test_ssl_key.py b/src/maasserver/api/tests/test_ssl_key.py | |||
808 | index 0217420..67af5a6 100644 | |||
809 | --- a/src/maasserver/api/tests/test_ssl_key.py | |||
810 | +++ b/src/maasserver/api/tests/test_ssl_key.py | |||
811 | @@ -134,7 +134,7 @@ class TestSSLKeyHandlers(APITestCase.ForUser): | |||
812 | 134 | self.assertEqual(1, len(keys_after)) | 134 | self.assertEqual(1, len(keys_after)) |
813 | 135 | self.assertEqual(keys[1].id, keys_after[0].id) | 135 | self.assertEqual(keys[1].id, keys_after[0].id) |
814 | 136 | self.assertIsNotNone(event) | 136 | self.assertIsNotNone(event) |
816 | 137 | self.assertEquals( | 137 | self.assertEqual( |
817 | 138 | event.description, "Deleted SSL key id='%s'." % keys[0].id | 138 | event.description, "Deleted SSL key id='%s'." % keys[0].id |
818 | 139 | ) | 139 | ) |
819 | 140 | 140 | ||
820 | diff --git a/src/maasserver/api/tests/test_tag.py b/src/maasserver/api/tests/test_tag.py | |||
821 | index 018259e..975b443 100644 | |||
822 | --- a/src/maasserver/api/tests/test_tag.py | |||
823 | +++ b/src/maasserver/api/tests/test_tag.py | |||
824 | @@ -209,7 +209,7 @@ class TestTagAPI(APITestCase.ForUser): | |||
825 | 209 | # `default_gateways`, `health_status`, 'special_filesystems' and | 209 | # `default_gateways`, `health_status`, 'special_filesystems' and |
826 | 210 | # 'resource_pool' the number of queries is not the same but it is | 210 | # 'resource_pool' the number of queries is not the same but it is |
827 | 211 | # proportional to the number of machines. | 211 | # proportional to the number of machines. |
829 | 212 | self.assertEquals(num_queries1, num_queries2 - (3 * 7)) | 212 | self.assertEqual(num_queries1, num_queries2 - (3 * 7)) |
830 | 213 | 213 | ||
831 | 214 | def test_GET_machines_returns_machines(self): | 214 | def test_GET_machines_returns_machines(self): |
832 | 215 | tag = factory.make_Tag() | 215 | tag = factory.make_Tag() |
833 | @@ -282,7 +282,7 @@ class TestTagAPI(APITestCase.ForUser): | |||
834 | 282 | # `default_gateways`, `health_status` and 'resource_pool', the number | 282 | # `default_gateways`, `health_status` and 'resource_pool', the number |
835 | 283 | # of queries is not the same but it is proportional to the number of | 283 | # of queries is not the same but it is proportional to the number of |
836 | 284 | # machines. | 284 | # machines. |
838 | 285 | self.assertEquals(num_queries1, num_queries2 - (3 * 7)) | 285 | self.assertEqual(num_queries1, num_queries2 - (3 * 7)) |
839 | 286 | 286 | ||
840 | 287 | def test_GET_devices_returns_devices(self): | 287 | def test_GET_devices_returns_devices(self): |
841 | 288 | tag = factory.make_Tag() | 288 | tag = factory.make_Tag() |
842 | @@ -345,7 +345,7 @@ class TestTagAPI(APITestCase.ForUser): | |||
843 | 345 | len(extract_system_ids(parsed_result_2)), | 345 | len(extract_system_ids(parsed_result_2)), |
844 | 346 | ], | 346 | ], |
845 | 347 | ) | 347 | ) |
847 | 348 | self.assertEquals(num_queries1, num_queries2) | 348 | self.assertEqual(num_queries1, num_queries2) |
848 | 349 | 349 | ||
849 | 350 | def test_GET_rack_controllers_returns_rack_controllers(self): | 350 | def test_GET_rack_controllers_returns_rack_controllers(self): |
850 | 351 | self.become_admin() | 351 | self.become_admin() |
851 | @@ -413,7 +413,7 @@ class TestTagAPI(APITestCase.ForUser): | |||
852 | 413 | len(extract_system_ids(parsed_result_2)), | 413 | len(extract_system_ids(parsed_result_2)), |
853 | 414 | ], | 414 | ], |
854 | 415 | ) | 415 | ) |
856 | 416 | self.assertEquals(num_queries1, num_queries2 - (3 * 3)) | 416 | self.assertEqual(num_queries1, num_queries2 - (3 * 3)) |
857 | 417 | 417 | ||
858 | 418 | def test_GET_rack_controllers_returns_no_rack_controllers_nonadmin(self): | 418 | def test_GET_rack_controllers_returns_no_rack_controllers_nonadmin(self): |
859 | 419 | tag = factory.make_Tag() | 419 | tag = factory.make_Tag() |
860 | @@ -506,7 +506,7 @@ class TestTagAPI(APITestCase.ForUser): | |||
861 | 506 | len(extract_system_ids(parsed_result_2)), | 506 | len(extract_system_ids(parsed_result_2)), |
862 | 507 | ], | 507 | ], |
863 | 508 | ) | 508 | ) |
865 | 509 | self.assertEquals(num_queries1, num_queries2 - 6) | 509 | self.assertEqual(num_queries1, num_queries2 - 6) |
866 | 510 | 510 | ||
867 | 511 | def test_GET_region_controllers_returns_no_controllers_nonadmin(self): | 511 | def test_GET_region_controllers_returns_no_controllers_nonadmin(self): |
868 | 512 | tag = factory.make_Tag() | 512 | tag = factory.make_Tag() |
869 | diff --git a/src/maasserver/api/tests/test_users.py b/src/maasserver/api/tests/test_users.py | |||
870 | index 9507d2c..7f0e190 100644 | |||
871 | --- a/src/maasserver/api/tests/test_users.py | |||
872 | +++ b/src/maasserver/api/tests/test_users.py | |||
873 | @@ -181,7 +181,7 @@ class TestUsers(APITestCase.ForUser): | |||
874 | 181 | ) | 181 | ) |
875 | 182 | event = Event.objects.get(type__level=AUDIT) | 182 | event = Event.objects.get(type__level=AUDIT) |
876 | 183 | self.assertIsNotNone(event) | 183 | self.assertIsNotNone(event) |
878 | 184 | self.assertEquals(event.description, "Created user '%s'." % username) | 184 | self.assertEqual(event.description, "Created user '%s'." % username) |
879 | 185 | 185 | ||
880 | 186 | def test_POST_creates_audit_event_for_admin(self): | 186 | def test_POST_creates_audit_event_for_admin(self): |
881 | 187 | self.become_admin() | 187 | self.become_admin() |
882 | @@ -197,7 +197,7 @@ class TestUsers(APITestCase.ForUser): | |||
883 | 197 | ) | 197 | ) |
884 | 198 | event = Event.objects.get(type__level=AUDIT) | 198 | event = Event.objects.get(type__level=AUDIT) |
885 | 199 | self.assertIsNotNone(event) | 199 | self.assertIsNotNone(event) |
887 | 200 | self.assertEquals(event.description, "Created admin '%s'." % username) | 200 | self.assertEqual(event.description, "Created admin '%s'." % username) |
888 | 201 | 201 | ||
889 | 202 | def test_POST_password_required_without_external_auth(self): | 202 | def test_POST_password_required_without_external_auth(self): |
890 | 203 | self.become_admin() | 203 | self.become_admin() |
891 | @@ -552,7 +552,7 @@ class TestUser(APITestCase.ForUser): | |||
892 | 552 | self.client.delete(reverse("user_handler", args=[user.username])) | 552 | self.client.delete(reverse("user_handler", args=[user.username])) |
893 | 553 | event = Event.objects.get(type__level=AUDIT) | 553 | event = Event.objects.get(type__level=AUDIT) |
894 | 554 | self.assertIsNotNone(event) | 554 | self.assertIsNotNone(event) |
896 | 555 | self.assertEquals( | 555 | self.assertEqual( |
897 | 556 | event.description, "Deleted user '%s'." % user.username | 556 | event.description, "Deleted user '%s'." % user.username |
898 | 557 | ) | 557 | ) |
899 | 558 | 558 | ||
900 | @@ -562,6 +562,6 @@ class TestUser(APITestCase.ForUser): | |||
901 | 562 | self.client.delete(reverse("user_handler", args=[user.username])) | 562 | self.client.delete(reverse("user_handler", args=[user.username])) |
902 | 563 | event = Event.objects.get(type__level=AUDIT) | 563 | event = Event.objects.get(type__level=AUDIT) |
903 | 564 | self.assertIsNotNone(event) | 564 | self.assertIsNotNone(event) |
905 | 565 | self.assertEquals( | 565 | self.assertEqual( |
906 | 566 | event.description, "Deleted admin '%s'." % user.username | 566 | event.description, "Deleted admin '%s'." % user.username |
907 | 567 | ) | 567 | ) |
908 | diff --git a/src/maasserver/api/tests/test_vmfs_datastores.py b/src/maasserver/api/tests/test_vmfs_datastores.py | |||
909 | index c805b89..2c24dd5 100644 | |||
910 | --- a/src/maasserver/api/tests/test_vmfs_datastores.py | |||
911 | +++ b/src/maasserver/api/tests/test_vmfs_datastores.py | |||
912 | @@ -125,9 +125,9 @@ class TestVMFSDatastoresAPI(APITestCase.ForUser): | |||
913 | 125 | ) | 125 | ) |
914 | 126 | self.assertThat(response, HasStatusCode(http.client.OK)) | 126 | self.assertThat(response, HasStatusCode(http.client.OK)) |
915 | 127 | parsed_results = json_load_bytes(response.content) | 127 | parsed_results = json_load_bytes(response.content) |
917 | 128 | self.assertEquals(node.system_id, parsed_results["system_id"]) | 128 | self.assertEqual(node.system_id, parsed_results["system_id"]) |
918 | 129 | # VMFS should be using the 5 devices we listed above. | 129 | # VMFS should be using the 5 devices we listed above. |
920 | 130 | self.assertEquals(5, len(parsed_results["devices"])) | 130 | self.assertEqual(5, len(parsed_results["devices"])) |
921 | 131 | # VMFS should be using all the block devices we created. | 131 | # VMFS should be using all the block devices we created. |
922 | 132 | self.assertItemsEqual( | 132 | self.assertItemsEqual( |
923 | 133 | [bd.id for bd in block_devices] + [block_device.id], | 133 | [bd.id for bd in block_devices] + [block_device.id], |
924 | @@ -147,7 +147,7 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser): | |||
925 | 147 | def test_handler_path(self): | 147 | def test_handler_path(self): |
926 | 148 | node = factory.make_Machine() | 148 | node = factory.make_Machine() |
927 | 149 | vmfs = factory.make_VMFS(node=node) | 149 | vmfs = factory.make_VMFS(node=node) |
929 | 150 | self.assertEquals( | 150 | self.assertEqual( |
930 | 151 | "/MAAS/api/2.0/nodes/%s/vmfs-datastore/%s/" | 151 | "/MAAS/api/2.0/nodes/%s/vmfs-datastore/%s/" |
931 | 152 | % (node.system_id, vmfs.id), | 152 | % (node.system_id, vmfs.id), |
932 | 153 | self.get_vmfs_uri(vmfs), | 153 | self.get_vmfs_uri(vmfs), |
933 | @@ -183,7 +183,7 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser): | |||
934 | 183 | } | 183 | } |
935 | 184 | ), | 184 | ), |
936 | 185 | ) | 185 | ) |
938 | 186 | self.assertEquals( | 186 | self.assertEqual( |
939 | 187 | vmfs.filesystems.count(), len(parsed_result["devices"]) | 187 | vmfs.filesystems.count(), len(parsed_result["devices"]) |
940 | 188 | ) | 188 | ) |
941 | 189 | 189 | ||
942 | @@ -242,8 +242,8 @@ class TestVMFSDatastoreAPI(APITestCase.ForUser): | |||
943 | 242 | vmfs = reload_object(vmfs) | 242 | vmfs = reload_object(vmfs) |
944 | 243 | partition_ids.add(new_bd.get_partitiontable().partitions.first().id) | 243 | partition_ids.add(new_bd.get_partitiontable().partitions.first().id) |
945 | 244 | 244 | ||
948 | 245 | self.assertEquals(new_name, vmfs.name) | 245 | self.assertEqual(new_name, vmfs.name) |
949 | 246 | self.assertEquals(new_uuid, vmfs.uuid) | 246 | self.assertEqual(new_uuid, vmfs.uuid) |
950 | 247 | self.assertItemsEqual( | 247 | self.assertItemsEqual( |
951 | 248 | partition_ids, | 248 | partition_ids, |
952 | 249 | [fs.get_parent().id for fs in vmfs.filesystems.all()], | 249 | [fs.get_parent().id for fs in vmfs.filesystems.all()], |
953 | diff --git a/src/maasserver/api/tests/test_volume_groups.py b/src/maasserver/api/tests/test_volume_groups.py | |||
954 | index db13536..df1ddaf 100644 | |||
955 | --- a/src/maasserver/api/tests/test_volume_groups.py | |||
956 | +++ b/src/maasserver/api/tests/test_volume_groups.py | |||
957 | @@ -189,7 +189,7 @@ class TestVolumeGroupAPI(APITestCase.ForUser): | |||
958 | 189 | volume_group = factory.make_FilesystemGroup( | 189 | volume_group = factory.make_FilesystemGroup( |
959 | 190 | node=node, group_type=FILESYSTEM_GROUP_TYPE.LVM_VG | 190 | node=node, group_type=FILESYSTEM_GROUP_TYPE.LVM_VG |
960 | 191 | ) | 191 | ) |
962 | 192 | self.assertEquals( | 192 | self.assertEqual( |
963 | 193 | "/MAAS/api/2.0/nodes/%s/volume-group/%s/" | 193 | "/MAAS/api/2.0/nodes/%s/volume-group/%s/" |
964 | 194 | % (node.system_id, volume_group.id), | 194 | % (node.system_id, volume_group.id), |
965 | 195 | get_volume_group_uri(volume_group, node, False), | 195 | get_volume_group_uri(volume_group, node, False), |
966 | diff --git a/src/maasserver/clusterrpc/tests/test_driver_parameters.py b/src/maasserver/clusterrpc/tests/test_driver_parameters.py | |||
967 | index 950214d..d9c6507 100644 | |||
968 | --- a/src/maasserver/clusterrpc/tests/test_driver_parameters.py | |||
969 | +++ b/src/maasserver/clusterrpc/tests/test_driver_parameters.py | |||
970 | @@ -214,7 +214,7 @@ class TestMakeFormField(MAASServerTestCase): | |||
971 | 214 | "default": "some default", | 214 | "default": "some default", |
972 | 215 | } | 215 | } |
973 | 216 | django_field = make_form_field(json_field) | 216 | django_field = make_form_field(json_field) |
975 | 217 | self.assertEquals(json_field["default"], django_field.initial) | 217 | self.assertEqual(json_field["default"], django_field.initial) |
976 | 218 | 218 | ||
977 | 219 | 219 | ||
978 | 220 | class TestMakeSettingField(MAASServerTestCase): | 220 | class TestMakeSettingField(MAASServerTestCase): |
979 | diff --git a/src/maasserver/clusterrpc/tests/test_pods.py b/src/maasserver/clusterrpc/tests/test_pods.py | |||
980 | index 96e8552..bbdff42 100644 | |||
981 | --- a/src/maasserver/clusterrpc/tests/test_pods.py | |||
982 | +++ b/src/maasserver/clusterrpc/tests/test_pods.py | |||
983 | @@ -75,7 +75,7 @@ class TestDiscoverPod(MAASTransactionServerTestCase): | |||
984 | 75 | 75 | ||
985 | 76 | self.patch(pods_module, "getAllClients").return_value = clients | 76 | self.patch(pods_module, "getAllClients").return_value = clients |
986 | 77 | discovered = yield discover_pod(factory.make_name("pod"), {}) | 77 | discovered = yield discover_pod(factory.make_name("pod"), {}) |
988 | 78 | self.assertEquals( | 78 | self.assertEqual( |
989 | 79 | ({rack_id: pod for rack_id in rack_ids}, {}), discovered | 79 | ({rack_id: pod for rack_id in rack_ids}, {}), discovered |
990 | 80 | ) | 80 | ) |
991 | 81 | 81 | ||
992 | @@ -113,7 +113,7 @@ class TestDiscoverPod(MAASTransactionServerTestCase): | |||
993 | 113 | 113 | ||
994 | 114 | self.patch(pods_module, "getAllClients").return_value = clients | 114 | self.patch(pods_module, "getAllClients").return_value = clients |
995 | 115 | discovered = yield discover_pod(pod_type, {}) | 115 | discovered = yield discover_pod(pod_type, {}) |
997 | 116 | self.assertEquals( | 116 | self.assertEqual( |
998 | 117 | ({valid_rack_id: pod}, {error_rack_id: exception}), discovered | 117 | ({valid_rack_id: pod}, {error_rack_id: exception}), discovered |
999 | 118 | ) | 118 | ) |
1000 | 119 | 119 | ||
1001 | diff --git a/src/maasserver/forms/tests/test_clone.py b/src/maasserver/forms/tests/test_clone.py | |||
1002 | index 7868ea8..8133280 100644 | |||
1003 | --- a/src/maasserver/forms/tests/test_clone.py | |||
1004 | +++ b/src/maasserver/forms/tests/test_clone.py | |||
1005 | @@ -17,7 +17,7 @@ class TestCloneForm(MAASServerTestCase): | |||
1006 | 17 | user = factory.make_admin() | 17 | user = factory.make_admin() |
1007 | 18 | form = CloneForm(user, data={}) | 18 | form = CloneForm(user, data={}) |
1008 | 19 | self.assertFalse(form.is_valid()) | 19 | self.assertFalse(form.is_valid()) |
1010 | 20 | self.assertEquals( | 20 | self.assertEqual( |
1011 | 21 | { | 21 | { |
1012 | 22 | "source": ["This field is required."], | 22 | "source": ["This field is required."], |
1013 | 23 | "destinations": ["This field is required."], | 23 | "destinations": ["This field is required."], |
1014 | @@ -42,7 +42,7 @@ class TestCloneForm(MAASServerTestCase): | |||
1015 | 42 | }, | 42 | }, |
1016 | 43 | ) | 43 | ) |
1017 | 44 | self.assertFalse(form.is_valid()) | 44 | self.assertFalse(form.is_valid()) |
1019 | 45 | self.assertEquals( | 45 | self.assertEqual( |
1020 | 46 | { | 46 | { |
1021 | 47 | "destinations": [ | 47 | "destinations": [ |
1022 | 48 | "Machine 1 in the array did not validate: " | 48 | "Machine 1 in the array did not validate: " |
1023 | @@ -76,7 +76,7 @@ class TestCloneForm(MAASServerTestCase): | |||
1024 | 76 | }, | 76 | }, |
1025 | 77 | ) | 77 | ) |
1026 | 78 | self.assertFalse(form.is_valid()) | 78 | self.assertFalse(form.is_valid()) |
1028 | 79 | self.assertEquals( | 79 | self.assertEqual( |
1029 | 80 | { | 80 | { |
1030 | 81 | "destinations": [ | 81 | "destinations": [ |
1031 | 82 | "Machine 1 in the array did not validate: " | 82 | "Machine 1 in the array did not validate: " |
1032 | @@ -107,7 +107,7 @@ class TestCloneForm(MAASServerTestCase): | |||
1033 | 107 | }, | 107 | }, |
1034 | 108 | ) | 108 | ) |
1035 | 109 | self.assertFalse(form.is_valid()) | 109 | self.assertFalse(form.is_valid()) |
1037 | 110 | self.assertEquals( | 110 | self.assertEqual( |
1038 | 111 | { | 111 | { |
1039 | 112 | "destinations": [ | 112 | "destinations": [ |
1040 | 113 | "Machine 1 in the array did not validate: " | 113 | "Machine 1 in the array did not validate: " |
1041 | @@ -145,7 +145,7 @@ class TestCloneForm(MAASServerTestCase): | |||
1042 | 145 | }, | 145 | }, |
1043 | 146 | ) | 146 | ) |
1044 | 147 | self.assertFalse(form.is_valid()) | 147 | self.assertFalse(form.is_valid()) |
1046 | 148 | self.assertEquals( | 148 | self.assertEqual( |
1047 | 149 | { | 149 | { |
1048 | 150 | "destinations": [ | 150 | "destinations": [ |
1049 | 151 | "Machine 1 in the array did not validate: " | 151 | "Machine 1 in the array did not validate: " |
1050 | diff --git a/src/maasserver/forms/tests/test_dhcpsnippet.py b/src/maasserver/forms/tests/test_dhcpsnippet.py | |||
1051 | index 2736ee9..2000f04 100644 | |||
1052 | --- a/src/maasserver/forms/tests/test_dhcpsnippet.py | |||
1053 | +++ b/src/maasserver/forms/tests/test_dhcpsnippet.py | |||
1054 | @@ -251,7 +251,7 @@ class TestDHCPSnippetForm(MAASServerTestCase): | |||
1055 | 251 | request.user = factory.make_User() | 251 | request.user = factory.make_User() |
1056 | 252 | dhcp_snippet = form.save(endpoint, request) | 252 | dhcp_snippet = form.save(endpoint, request) |
1057 | 253 | self.assertIsNone(dhcp_snippet.subnet) | 253 | self.assertIsNone(dhcp_snippet.subnet) |
1059 | 254 | self.assertEquals(node, dhcp_snippet.node) | 254 | self.assertEqual(node, dhcp_snippet.node) |
1060 | 255 | 255 | ||
1061 | 256 | def test_updates_subnet(self): | 256 | def test_updates_subnet(self): |
1062 | 257 | dhcp_snippet = factory.make_DHCPSnippet() | 257 | dhcp_snippet = factory.make_DHCPSnippet() |
1063 | @@ -278,7 +278,7 @@ class TestDHCPSnippetForm(MAASServerTestCase): | |||
1064 | 278 | request.user = factory.make_User() | 278 | request.user = factory.make_User() |
1065 | 279 | dhcp_snippet = form.save(endpoint, request) | 279 | dhcp_snippet = form.save(endpoint, request) |
1066 | 280 | self.assertIsNone(dhcp_snippet.node) | 280 | self.assertIsNone(dhcp_snippet.node) |
1068 | 281 | self.assertEquals(subnet, dhcp_snippet.subnet) | 281 | self.assertEqual(subnet, dhcp_snippet.subnet) |
1069 | 282 | 282 | ||
1070 | 283 | def test_cannot_update_both_node_and_subnet(self): | 283 | def test_cannot_update_both_node_and_subnet(self): |
1071 | 284 | dhcp_snippet = factory.make_DHCPSnippet() | 284 | dhcp_snippet = factory.make_DHCPSnippet() |
1072 | @@ -302,7 +302,7 @@ class TestDHCPSnippetForm(MAASServerTestCase): | |||
1073 | 302 | }, | 302 | }, |
1074 | 303 | ) | 303 | ) |
1075 | 304 | self.assertFalse(form.is_valid()) | 304 | self.assertFalse(form.is_valid()) |
1077 | 305 | self.assertEquals(value, reload_object(dhcp_snippet).value.data) | 305 | self.assertEqual(value, reload_object(dhcp_snippet).value.data) |
1078 | 306 | 306 | ||
1079 | 307 | def test_update_global_snippet_resets_node(self): | 307 | def test_update_global_snippet_resets_node(self): |
1080 | 308 | node = factory.make_Node() | 308 | node = factory.make_Node() |
1081 | @@ -349,6 +349,6 @@ class TestDHCPSnippetForm(MAASServerTestCase): | |||
1082 | 349 | } | 349 | } |
1083 | 350 | ) | 350 | ) |
1084 | 351 | self.assertFalse(form.is_valid()) | 351 | self.assertFalse(form.is_valid()) |
1086 | 352 | self.assertEquals({"value": [dhcpd_error["error"]]}, form.errors) | 352 | self.assertEqual({"value": [dhcpd_error["error"]]}, form.errors) |
1087 | 353 | self.assertItemsEqual([], VersionedTextFile.objects.all()) | 353 | self.assertItemsEqual([], VersionedTextFile.objects.all()) |
1088 | 354 | self.assertItemsEqual([], DHCPSnippet.objects.all()) | 354 | self.assertItemsEqual([], DHCPSnippet.objects.all()) |
1089 | diff --git a/src/maasserver/forms/tests/test_interface.py b/src/maasserver/forms/tests/test_interface.py | |||
1090 | index 9d93879..52364a3 100644 | |||
1091 | --- a/src/maasserver/forms/tests/test_interface.py | |||
1092 | +++ b/src/maasserver/forms/tests/test_interface.py | |||
1093 | @@ -441,7 +441,7 @@ class TestPhysicalInterfaceForm(MAASServerTestCase): | |||
1094 | 441 | ) | 441 | ) |
1095 | 442 | self.assertTrue(form.is_valid(), dict(form.errors)) | 442 | self.assertTrue(form.is_valid(), dict(form.errors)) |
1096 | 443 | interface = form.save() | 443 | interface = form.save() |
1098 | 444 | self.assertEquals(vlan, interface.vlan) | 444 | self.assertEqual(vlan, interface.vlan) |
1099 | 445 | 445 | ||
1100 | 446 | def test_rejects_parents(self): | 446 | def test_rejects_parents(self): |
1101 | 447 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 447 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
1102 | @@ -1077,7 +1077,7 @@ class BondInterfaceFormTest(MAASServerTestCase): | |||
1103 | 1077 | data={"name": interface_name, "parents": [parent1.id, parent2.id]}, | 1077 | data={"name": interface_name, "parents": [parent1.id, parent2.id]}, |
1104 | 1078 | ) | 1078 | ) |
1105 | 1079 | self.assertFalse(form.is_valid(), dict(form.errors)) | 1079 | self.assertFalse(form.is_valid(), dict(form.errors)) |
1107 | 1080 | self.assertEquals( | 1080 | self.assertEqual( |
1108 | 1081 | "All parents must belong to the same VLAN.", | 1081 | "All parents must belong to the same VLAN.", |
1109 | 1082 | form.errors["parents"][0], | 1082 | form.errors["parents"][0], |
1110 | 1083 | ) | 1083 | ) |
1111 | diff --git a/src/maasserver/forms/tests/test_machinewithmacaddresses.py b/src/maasserver/forms/tests/test_machinewithmacaddresses.py | |||
1112 | index fe96353..ebc8a16 100644 | |||
1113 | --- a/src/maasserver/forms/tests/test_machinewithmacaddresses.py | |||
1114 | +++ b/src/maasserver/forms/tests/test_machinewithmacaddresses.py | |||
1115 | @@ -189,7 +189,7 @@ class MachineWithMACAddressesFormTest(MAASServerTestCase): | |||
1116 | 189 | node = form.save() | 189 | node = form.save() |
1117 | 190 | 190 | ||
1118 | 191 | self.assertIsNotNone(node.id) # The node is persisted. | 191 | self.assertIsNotNone(node.id) # The node is persisted. |
1120 | 192 | self.assertEquals(NODE_STATUS.NEW, node.status) | 192 | self.assertEqual(NODE_STATUS.NEW, node.status) |
1121 | 193 | self.assertItemsEqual( | 193 | self.assertItemsEqual( |
1122 | 194 | macs, [nic.mac_address for nic in node.interface_set.all()] | 194 | macs, [nic.mac_address for nic in node.interface_set.all()] |
1123 | 195 | ) | 195 | ) |
1124 | @@ -226,5 +226,5 @@ class MachineWithMACAddressesFormTest(MAASServerTestCase): | |||
1125 | 226 | ) | 226 | ) |
1126 | 227 | self.assertTrue(form.is_valid(), form.errors) | 227 | self.assertTrue(form.is_valid(), form.errors) |
1127 | 228 | machine = form.save() | 228 | machine = form.save() |
1129 | 229 | self.assertEquals(NODE_STATUS.COMMISSIONING, machine.status) | 229 | self.assertEqual(NODE_STATUS.COMMISSIONING, machine.status) |
1130 | 230 | self.assertIsNotNone(machine.current_commissioning_script_set) | 230 | self.assertIsNotNone(machine.current_commissioning_script_set) |
1131 | diff --git a/src/maasserver/forms/tests/test_packagerepository.py b/src/maasserver/forms/tests/test_packagerepository.py | |||
1132 | index 1898d89..f96d36b 100644 | |||
1133 | --- a/src/maasserver/forms/tests/test_packagerepository.py | |||
1134 | +++ b/src/maasserver/forms/tests/test_packagerepository.py | |||
1135 | @@ -174,7 +174,7 @@ class TestPackageRepositoryForm(MAASServerTestCase): | |||
1136 | 174 | data={"url": factory.make_url(scheme="fake")}, | 174 | data={"url": factory.make_url(scheme="fake")}, |
1137 | 175 | ) | 175 | ) |
1138 | 176 | self.assertFalse(form.is_valid()) | 176 | self.assertFalse(form.is_valid()) |
1140 | 177 | self.assertEquals(url, reload_object(package_repository).url) | 177 | self.assertEqual(url, reload_object(package_repository).url) |
1141 | 178 | 178 | ||
1142 | 179 | def test_creates_package_repository_defaults_main_arches(self): | 179 | def test_creates_package_repository_defaults_main_arches(self): |
1143 | 180 | repo = factory.make_PackageRepository(arches=[]) | 180 | repo = factory.make_PackageRepository(arches=[]) |
1144 | diff --git a/src/maasserver/forms/tests/test_parameters.py b/src/maasserver/forms/tests/test_parameters.py | |||
1145 | index ac3eed3..4b41ce3 100644 | |||
1146 | --- a/src/maasserver/forms/tests/test_parameters.py | |||
1147 | +++ b/src/maasserver/forms/tests/test_parameters.py | |||
1148 | @@ -324,7 +324,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1149 | 324 | data={"runtime": value}, script=script, node=factory.make_Node() | 324 | data={"runtime": value}, script=script, node=factory.make_Node() |
1150 | 325 | ) | 325 | ) |
1151 | 326 | self.assertTrue(form.is_valid(), form.errors) | 326 | self.assertTrue(form.is_valid(), form.errors) |
1153 | 327 | self.assertEquals(1, len(form.cleaned_data["input"])) | 327 | self.assertEqual(1, len(form.cleaned_data["input"])) |
1154 | 328 | self.assertDictEqual( | 328 | self.assertDictEqual( |
1155 | 329 | {"runtime": {"type": "runtime", "value": value}}, | 329 | {"runtime": {"type": "runtime", "value": value}}, |
1156 | 330 | form.cleaned_data["input"][0], | 330 | form.cleaned_data["input"][0], |
1157 | @@ -336,7 +336,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1158 | 336 | ) | 336 | ) |
1159 | 337 | form = ParametersForm(data={}, script=script, node=factory.make_Node()) | 337 | form = ParametersForm(data={}, script=script, node=factory.make_Node()) |
1160 | 338 | self.assertTrue(form.is_valid(), form.errors) | 338 | self.assertTrue(form.is_valid(), form.errors) |
1162 | 339 | self.assertEquals(1, len(form.cleaned_data["input"])) | 339 | self.assertEqual(1, len(form.cleaned_data["input"])) |
1163 | 340 | self.assertDictEqual( | 340 | self.assertDictEqual( |
1164 | 341 | {"runtime": {"type": "runtime", "value": script.timeout.seconds}}, | 341 | {"runtime": {"type": "runtime", "value": script.timeout.seconds}}, |
1165 | 342 | form.cleaned_data["input"][0], | 342 | form.cleaned_data["input"][0], |
1166 | @@ -423,7 +423,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1167 | 423 | node=factory.make_Node(with_boot_disk=False), | 423 | node=factory.make_Node(with_boot_disk=False), |
1168 | 424 | ) | 424 | ) |
1169 | 425 | self.assertTrue(form.is_valid(), form.errors) | 425 | self.assertTrue(form.is_valid(), form.errors) |
1171 | 426 | self.assertEquals(1, len(form.cleaned_data["input"])) | 426 | self.assertEqual(1, len(form.cleaned_data["input"])) |
1172 | 427 | self.assertDictEqual( | 427 | self.assertDictEqual( |
1173 | 428 | { | 428 | { |
1174 | 429 | "runtime": { | 429 | "runtime": { |
1175 | @@ -450,12 +450,12 @@ class TestParametersForm(MAASServerTestCase): | |||
1176 | 450 | ) | 450 | ) |
1177 | 451 | self.assertTrue(form.is_valid(), form.errors) | 451 | self.assertTrue(form.is_valid(), form.errors) |
1178 | 452 | input = form.cleaned_data["input"] | 452 | input = form.cleaned_data["input"] |
1180 | 453 | self.assertEquals(node.physicalblockdevice_set.count(), len(input)) | 453 | self.assertEqual(node.physicalblockdevice_set.count(), len(input)) |
1181 | 454 | for bd in node.physicalblockdevice_set: | 454 | for bd in node.physicalblockdevice_set: |
1182 | 455 | for i in input: | 455 | for i in input: |
1183 | 456 | if bd.name == i["storage"]["value"]["name"]: | 456 | if bd.name == i["storage"]["value"]["name"]: |
1184 | 457 | break | 457 | break |
1186 | 458 | self.assertEquals(script.timeout.seconds, i["runtime"]["value"]) | 458 | self.assertEqual(script.timeout.seconds, i["runtime"]["value"]) |
1187 | 459 | self.assertDictEqual( | 459 | self.assertDictEqual( |
1188 | 460 | { | 460 | { |
1189 | 461 | "name": bd.name, | 461 | "name": bd.name, |
1190 | @@ -485,8 +485,8 @@ class TestParametersForm(MAASServerTestCase): | |||
1191 | 485 | ) | 485 | ) |
1192 | 486 | self.assertTrue(form.is_valid(), form.errors) | 486 | self.assertTrue(form.is_valid(), form.errors) |
1193 | 487 | input = form.cleaned_data["input"] | 487 | input = form.cleaned_data["input"] |
1196 | 488 | self.assertEquals(1, len(input)) | 488 | self.assertEqual(1, len(input)) |
1197 | 489 | self.assertEquals(script.timeout.seconds, input[0]["runtime"]["value"]) | 489 | self.assertEqual(script.timeout.seconds, input[0]["runtime"]["value"]) |
1198 | 490 | self.assertDictEqual( | 490 | self.assertDictEqual( |
1199 | 491 | { | 491 | { |
1200 | 492 | "name": bd.name, | 492 | "name": bd.name, |
1201 | @@ -544,12 +544,12 @@ class TestParametersForm(MAASServerTestCase): | |||
1202 | 544 | ) | 544 | ) |
1203 | 545 | self.assertTrue(form.is_valid(), form.errors) | 545 | self.assertTrue(form.is_valid(), form.errors) |
1204 | 546 | input = form.cleaned_data["input"] | 546 | input = form.cleaned_data["input"] |
1206 | 547 | self.assertEquals(len(selected_scripts), len(input)) | 547 | self.assertEqual(len(selected_scripts), len(input)) |
1207 | 548 | for bd in selected_scripts.keys(): | 548 | for bd in selected_scripts.keys(): |
1208 | 549 | for i in input: | 549 | for i in input: |
1209 | 550 | if bd.name == i["storage"]["value"]["name"]: | 550 | if bd.name == i["storage"]["value"]["name"]: |
1210 | 551 | break | 551 | break |
1212 | 552 | self.assertEquals(script.timeout.seconds, i["runtime"]["value"]) | 552 | self.assertEqual(script.timeout.seconds, i["runtime"]["value"]) |
1213 | 553 | self.assertDictEqual( | 553 | self.assertDictEqual( |
1214 | 554 | { | 554 | { |
1215 | 555 | "name": bd.name, | 555 | "name": bd.name, |
1216 | @@ -609,7 +609,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1217 | 609 | data={}, script=script, node=factory.make_Node(interface=False) | 609 | data={}, script=script, node=factory.make_Node(interface=False) |
1218 | 610 | ) | 610 | ) |
1219 | 611 | self.assertTrue(form.is_valid(), form.errors) | 611 | self.assertTrue(form.is_valid(), form.errors) |
1221 | 612 | self.assertEquals(1, len(form.cleaned_data["input"])) | 612 | self.assertEqual(1, len(form.cleaned_data["input"])) |
1222 | 613 | self.assertDictEqual( | 613 | self.assertDictEqual( |
1223 | 614 | {"interface": {"type": "interface", "value": "all"}}, | 614 | {"interface": {"type": "interface", "value": "all"}}, |
1224 | 615 | form.cleaned_data["input"][0], | 615 | form.cleaned_data["input"][0], |
1225 | @@ -624,7 +624,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1226 | 624 | ) | 624 | ) |
1227 | 625 | form = ParametersForm(data={}, script=script, node=node) | 625 | form = ParametersForm(data={}, script=script, node=node) |
1228 | 626 | self.assertTrue(form.is_valid(), form.errors) | 626 | self.assertTrue(form.is_valid(), form.errors) |
1230 | 627 | self.assertEquals(1, len(form.cleaned_data["input"])) | 627 | self.assertEqual(1, len(form.cleaned_data["input"])) |
1231 | 628 | self.assertDictEqual( | 628 | self.assertDictEqual( |
1232 | 629 | { | 629 | { |
1233 | 630 | "name": node.boot_interface.name, | 630 | "name": node.boot_interface.name, |
1234 | @@ -657,7 +657,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1235 | 657 | ) | 657 | ) |
1236 | 658 | self.assertTrue(form.is_valid(), form.errors) | 658 | self.assertTrue(form.is_valid(), form.errors) |
1237 | 659 | input = form.cleaned_data["input"] | 659 | input = form.cleaned_data["input"] |
1239 | 660 | self.assertEquals(len(usable_interfaces), len(input)) | 660 | self.assertEqual(len(usable_interfaces), len(input)) |
1240 | 661 | for interface in usable_interfaces: | 661 | for interface in usable_interfaces: |
1241 | 662 | for i in input: | 662 | for i in input: |
1242 | 663 | if i["interface"]["value"]["interface"] == interface: | 663 | if i["interface"]["value"]["interface"] == interface: |
1243 | @@ -690,7 +690,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1244 | 690 | ) | 690 | ) |
1245 | 691 | self.assertTrue(form.is_valid(), form.errors) | 691 | self.assertTrue(form.is_valid(), form.errors) |
1246 | 692 | input = form.cleaned_data["input"] | 692 | input = form.cleaned_data["input"] |
1248 | 693 | self.assertEquals(1, len(input)) | 693 | self.assertEqual(1, len(input)) |
1249 | 694 | self.assertDictEqual( | 694 | self.assertDictEqual( |
1250 | 695 | { | 695 | { |
1251 | 696 | "name": bond.name, | 696 | "name": bond.name, |
1252 | @@ -720,7 +720,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1253 | 720 | ) | 720 | ) |
1254 | 721 | self.assertTrue(form.is_valid(), form.errors) | 721 | self.assertTrue(form.is_valid(), form.errors) |
1255 | 722 | input = form.cleaned_data["input"] | 722 | input = form.cleaned_data["input"] |
1257 | 723 | self.assertEquals(1, len(input)) | 723 | self.assertEqual(1, len(input)) |
1258 | 724 | self.assertDictEqual( | 724 | self.assertDictEqual( |
1259 | 725 | { | 725 | { |
1260 | 726 | "name": interface.name, | 726 | "name": interface.name, |
1261 | @@ -808,7 +808,7 @@ class TestParametersForm(MAASServerTestCase): | |||
1262 | 808 | ) | 808 | ) |
1263 | 809 | self.assertTrue(form.is_valid(), form.errors) | 809 | self.assertTrue(form.is_valid(), form.errors) |
1264 | 810 | input = form.cleaned_data["input"] | 810 | input = form.cleaned_data["input"] |
1266 | 811 | self.assertEquals(len(selected_scripts), len(input)) | 811 | self.assertEqual(len(selected_scripts), len(input)) |
1267 | 812 | for nic in selected_scripts.keys(): | 812 | for nic in selected_scripts.keys(): |
1268 | 813 | for i in input: | 813 | for i in input: |
1269 | 814 | if ( | 814 | if ( |
1270 | diff --git a/src/maasserver/forms/tests/test_pods.py b/src/maasserver/forms/tests/test_pods.py | |||
1271 | index fe04080..d0cf4f7 100644 | |||
1272 | --- a/src/maasserver/forms/tests/test_pods.py | |||
1273 | +++ b/src/maasserver/forms/tests/test_pods.py | |||
1274 | @@ -432,8 +432,8 @@ class TestPodForm(MAASTransactionServerTestCase): | |||
1275 | 432 | form = PodForm(data=pod_info, request=self.request) | 432 | form = PodForm(data=pod_info, request=self.request) |
1276 | 433 | self.assertTrue(form.is_valid(), form._errors) | 433 | self.assertTrue(form.is_valid(), form._errors) |
1277 | 434 | pod = form.save() | 434 | pod = form.save() |
1280 | 435 | self.assertEquals(bmc.id, pod.id) | 435 | self.assertEqual(bmc.id, pod.id) |
1281 | 436 | self.assertEquals(BMC_TYPE.POD, reload_object(bmc).bmc_type) | 436 | self.assertEqual(BMC_TYPE.POD, reload_object(bmc).bmc_type) |
1282 | 437 | self.assertThat(mock_post_commit_do, MockCalledOnce()) | 437 | self.assertThat(mock_post_commit_do, MockCalledOnce()) |
1283 | 438 | 438 | ||
1284 | 439 | def test_updates_existing_pod_minimal(self): | 439 | def test_updates_existing_pod_minimal(self): |
1285 | @@ -797,7 +797,7 @@ class TestPodForm(MAASTransactionServerTestCase): | |||
1286 | 797 | form = PodForm(data=pod_info) | 797 | form = PodForm(data=pod_info) |
1287 | 798 | self.assertTrue(form.is_valid(), form._errors) | 798 | self.assertTrue(form.is_valid(), form._errors) |
1288 | 799 | error = self.assertRaises(PodProblem, form.save) | 799 | error = self.assertRaises(PodProblem, form.save) |
1290 | 800 | self.assertEquals( | 800 | self.assertEqual( |
1291 | 801 | "Unable to start the pod discovery process. " | 801 | "Unable to start the pod discovery process. " |
1292 | 802 | "No rack controllers connected.", | 802 | "No rack controllers connected.", |
1293 | 803 | str(error), | 803 | str(error), |
1294 | @@ -816,7 +816,7 @@ class TestPodForm(MAASTransactionServerTestCase): | |||
1295 | 816 | 816 | ||
1296 | 817 | def validate_error(failure): | 817 | def validate_error(failure): |
1297 | 818 | self.assertIsInstance(failure.value, PodProblem) | 818 | self.assertIsInstance(failure.value, PodProblem) |
1299 | 819 | self.assertEquals( | 819 | self.assertEqual( |
1300 | 820 | "Unable to start the pod discovery process. " | 820 | "Unable to start the pod discovery process. " |
1301 | 821 | "No rack controllers connected.", | 821 | "No rack controllers connected.", |
1302 | 822 | str(failure.value), | 822 | str(failure.value), |
1303 | @@ -837,7 +837,7 @@ class TestPodForm(MAASTransactionServerTestCase): | |||
1304 | 837 | form = PodForm(data=pod_info) | 837 | form = PodForm(data=pod_info) |
1305 | 838 | self.assertTrue(form.is_valid(), form._errors) | 838 | self.assertTrue(form.is_valid(), form._errors) |
1306 | 839 | error = self.assertRaises(PodProblem, form.save) | 839 | error = self.assertRaises(PodProblem, form.save) |
1308 | 840 | self.assertEquals(str(exc), str(error)) | 840 | self.assertEqual(str(exc), str(error)) |
1309 | 841 | 841 | ||
1310 | 842 | @wait_for_reactor | 842 | @wait_for_reactor |
1311 | 843 | @inlineCallbacks | 843 | @inlineCallbacks |
1312 | @@ -854,7 +854,7 @@ class TestPodForm(MAASTransactionServerTestCase): | |||
1313 | 854 | 854 | ||
1314 | 855 | def validate_error(failure): | 855 | def validate_error(failure): |
1315 | 856 | self.assertIsInstance(failure.value, PodProblem) | 856 | self.assertIsInstance(failure.value, PodProblem) |
1317 | 857 | self.assertEquals(str(exc), str(failure.value)) | 857 | self.assertEqual(str(exc), str(failure.value)) |
1318 | 858 | 858 | ||
1319 | 859 | d = form.save() | 859 | d = form.save() |
1320 | 860 | d.addErrback(validate_error) | 860 | d.addErrback(validate_error) |
1321 | @@ -2386,7 +2386,7 @@ class TestComposeMachineForm(MAASTransactionServerTestCase): | |||
1322 | 2386 | form = ComposeMachineForm(data={}, request=request, pod=pod) | 2386 | form = ComposeMachineForm(data={}, request=request, pod=pod) |
1323 | 2387 | self.assertTrue(form.is_valid()) | 2387 | self.assertTrue(form.is_valid()) |
1324 | 2388 | error = self.assertRaises(PodProblem, form.compose) | 2388 | error = self.assertRaises(PodProblem, form.compose) |
1326 | 2389 | self.assertEquals( | 2389 | self.assertEqual( |
1327 | 2390 | "Unable to compose a machine because '%s' driver timed out " | 2390 | "Unable to compose a machine because '%s' driver timed out " |
1328 | 2391 | "after 120 seconds." % pod.power_type, | 2391 | "after 120 seconds." % pod.power_type, |
1329 | 2392 | str(error), | 2392 | str(error), |
1330 | diff --git a/src/maasserver/forms/tests/test_script.py b/src/maasserver/forms/tests/test_script.py | |||
1331 | index 13df30f..f421660 100644 | |||
1332 | --- a/src/maasserver/forms/tests/test_script.py | |||
1333 | +++ b/src/maasserver/forms/tests/test_script.py | |||
1334 | @@ -51,19 +51,19 @@ class TestScriptForm(MAASServerTestCase): | |||
1335 | 51 | self.assertTrue(form.is_valid(), form.errors) | 51 | self.assertTrue(form.is_valid(), form.errors) |
1336 | 52 | script = form.save() | 52 | script = form.save() |
1337 | 53 | 53 | ||
1345 | 54 | self.assertEquals(name, script.name) | 54 | self.assertEqual(name, script.name) |
1346 | 55 | self.assertEquals("", script.title) | 55 | self.assertEqual("", script.title) |
1347 | 56 | self.assertEquals("", script.description) | 56 | self.assertEqual("", script.description) |
1348 | 57 | self.assertEquals(1, len(script.tags)) | 57 | self.assertEqual(1, len(script.tags)) |
1349 | 58 | self.assertEquals(SCRIPT_TYPE.TESTING, script.script_type) | 58 | self.assertEqual(SCRIPT_TYPE.TESTING, script.script_type) |
1350 | 59 | self.assertEquals(HARDWARE_TYPE.NODE, script.hardware_type) | 59 | self.assertEqual(HARDWARE_TYPE.NODE, script.hardware_type) |
1351 | 60 | self.assertEquals(SCRIPT_PARALLEL.DISABLED, script.parallel) | 60 | self.assertEqual(SCRIPT_PARALLEL.DISABLED, script.parallel) |
1352 | 61 | self.assertDictEqual({}, script.packages) | 61 | self.assertDictEqual({}, script.packages) |
1353 | 62 | self.assertDictEqual({}, script.results) | 62 | self.assertDictEqual({}, script.results) |
1354 | 63 | self.assertDictEqual({}, script.parameters) | 63 | self.assertDictEqual({}, script.parameters) |
1356 | 64 | self.assertEquals(timedelta(0), script.timeout) | 64 | self.assertEqual(timedelta(0), script.timeout) |
1357 | 65 | self.assertFalse(script.destructive) | 65 | self.assertFalse(script.destructive) |
1359 | 66 | self.assertEquals(script_content, script.script.data) | 66 | self.assertEqual(script_content, script.script.data) |
1360 | 67 | self.assertFalse(script.default) | 67 | self.assertFalse(script.default) |
1361 | 68 | self.assertItemsEqual([], script.for_hardware) | 68 | self.assertItemsEqual([], script.for_hardware) |
1362 | 69 | self.assertFalse(script.may_reboot) | 69 | self.assertFalse(script.may_reboot) |
1363 | @@ -123,24 +123,24 @@ class TestScriptForm(MAASServerTestCase): | |||
1364 | 123 | self.assertTrue(form.is_valid(), form.errors) | 123 | self.assertTrue(form.is_valid(), form.errors) |
1365 | 124 | script = form.save() | 124 | script = form.save() |
1366 | 125 | 125 | ||
1370 | 126 | self.assertEquals(name, script.name) | 126 | self.assertEqual(name, script.name) |
1371 | 127 | self.assertEquals(title, script.title) | 127 | self.assertEqual(title, script.title) |
1372 | 128 | self.assertEquals(description, script.description) | 128 | self.assertEqual(description, script.description) |
1373 | 129 | self.assertThat(script.tags, ContainsAll(tags)) | 129 | self.assertThat(script.tags, ContainsAll(tags)) |
1377 | 130 | self.assertEquals(script_type, script.script_type) | 130 | self.assertEqual(script_type, script.script_type) |
1378 | 131 | self.assertEquals(hardware_type, script.hardware_type) | 131 | self.assertEqual(hardware_type, script.hardware_type) |
1379 | 132 | self.assertEquals(parallel, script.parallel) | 132 | self.assertEqual(parallel, script.parallel) |
1380 | 133 | self.assertDictEqual(packages, script.packages) | 133 | self.assertDictEqual(packages, script.packages) |
1381 | 134 | self.assertDictEqual({}, script.results) | 134 | self.assertDictEqual({}, script.results) |
1382 | 135 | self.assertDictEqual({}, script.parameters) | 135 | self.assertDictEqual({}, script.parameters) |
1383 | 136 | self.assertDictEqual(packages, script.packages) | 136 | self.assertDictEqual(packages, script.packages) |
1389 | 137 | self.assertEquals(timedelta(0, timeout), script.timeout) | 137 | self.assertEqual(timedelta(0, timeout), script.timeout) |
1390 | 138 | self.assertEquals(destructive, script.destructive) | 138 | self.assertEqual(destructive, script.destructive) |
1391 | 139 | self.assertEquals(script_content, script.script.data) | 139 | self.assertEqual(script_content, script.script.data) |
1392 | 140 | self.assertEquals(comment, script.script.comment) | 140 | self.assertEqual(comment, script.script.comment) |
1393 | 141 | self.assertEquals(may_reboot, script.may_reboot) | 141 | self.assertEqual(may_reboot, script.may_reboot) |
1394 | 142 | self.assertItemsEqual(for_hardware, script.for_hardware) | 142 | self.assertItemsEqual(for_hardware, script.for_hardware) |
1396 | 143 | self.assertEquals(recommission, script.recommission) | 143 | self.assertEqual(recommission, script.recommission) |
1397 | 144 | self.assertFalse(script.default) | 144 | self.assertFalse(script.default) |
1398 | 145 | 145 | ||
1399 | 146 | def test_create_setting_default_has_no_effect(self): | 146 | def test_create_setting_default_has_no_effect(self): |
1400 | @@ -214,25 +214,25 @@ class TestScriptForm(MAASServerTestCase): | |||
1401 | 214 | self.assertTrue(form.is_valid(), form.errors) | 214 | self.assertTrue(form.is_valid(), form.errors) |
1402 | 215 | script = form.save() | 215 | script = form.save() |
1403 | 216 | 216 | ||
1407 | 217 | self.assertEquals(name, script.name) | 217 | self.assertEqual(name, script.name) |
1408 | 218 | self.assertEquals(title, script.title) | 218 | self.assertEqual(title, script.title) |
1409 | 219 | self.assertEquals(description, script.description) | 219 | self.assertEqual(description, script.description) |
1410 | 220 | self.assertThat(script.tags, ContainsAll(tags)) | 220 | self.assertThat(script.tags, ContainsAll(tags)) |
1414 | 221 | self.assertEquals(script_type, script.script_type) | 221 | self.assertEqual(script_type, script.script_type) |
1415 | 222 | self.assertEquals(hardware_type, script.hardware_type) | 222 | self.assertEqual(hardware_type, script.hardware_type) |
1416 | 223 | self.assertEquals(parallel, script.parallel) | 223 | self.assertEqual(parallel, script.parallel) |
1417 | 224 | self.assertDictEqual({}, script.results) | 224 | self.assertDictEqual({}, script.results) |
1418 | 225 | self.assertDictEqual({}, script.parameters) | 225 | self.assertDictEqual({}, script.parameters) |
1419 | 226 | self.assertDictEqual(packages, script.packages) | 226 | self.assertDictEqual(packages, script.packages) |
1425 | 227 | self.assertEquals(timedelta(0, timeout), script.timeout) | 227 | self.assertEqual(timedelta(0, timeout), script.timeout) |
1426 | 228 | self.assertEquals(destructive, script.destructive) | 228 | self.assertEqual(destructive, script.destructive) |
1427 | 229 | self.assertEquals(script_content, script.script.data) | 229 | self.assertEqual(script_content, script.script.data) |
1428 | 230 | self.assertEquals(comment, script.script.comment) | 230 | self.assertEqual(comment, script.script.comment) |
1429 | 231 | self.assertEquals( | 231 | self.assertEqual( |
1430 | 232 | orig_script_content, script.script.previous_version.data | 232 | orig_script_content, script.script.previous_version.data |
1431 | 233 | ) | 233 | ) |
1434 | 234 | self.assertEquals(None, script.script.previous_version.comment) | 234 | self.assertEqual(None, script.script.previous_version.comment) |
1435 | 235 | self.assertEquals( | 235 | self.assertEqual( |
1436 | 236 | apply_configured_networking, script.apply_configured_networking | 236 | apply_configured_networking, script.apply_configured_networking |
1437 | 237 | ) | 237 | ) |
1438 | 238 | self.assertFalse(script.default) | 238 | self.assertFalse(script.default) |
1439 | @@ -276,7 +276,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1440 | 276 | value = factory.make_string() | 276 | value = factory.make_string() |
1441 | 277 | form = ScriptForm(data={name: value}, instance=script) | 277 | form = ScriptForm(data={name: value}, instance=script) |
1442 | 278 | self.assertFalse(form.is_valid()) | 278 | self.assertFalse(form.is_valid()) |
1444 | 279 | self.assertEquals(1, VersionedTextFile.objects.all().count()) | 279 | self.assertEqual(1, VersionedTextFile.objects.all().count()) |
1445 | 280 | 280 | ||
1446 | 281 | def test_update_edit_default_allows_update_of_all_fields(self): | 281 | def test_update_edit_default_allows_update_of_all_fields(self): |
1447 | 282 | script = factory.make_Script(default=True) | 282 | script = factory.make_Script(default=True) |
1448 | @@ -321,7 +321,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1449 | 321 | script = form.save() | 321 | script = form.save() |
1450 | 322 | 322 | ||
1451 | 323 | self.assertThat(script.tags, ContainsAll(tags)) | 323 | self.assertThat(script.tags, ContainsAll(tags)) |
1453 | 324 | self.assertEquals(timedelta(0, timeout), script.timeout) | 324 | self.assertEqual(timedelta(0, timeout), script.timeout) |
1454 | 325 | 325 | ||
1455 | 326 | def test_update_requires_script_with_comment(self): | 326 | def test_update_requires_script_with_comment(self): |
1456 | 327 | script = factory.make_Script() | 327 | script = factory.make_Script() |
1457 | @@ -362,23 +362,23 @@ class TestScriptForm(MAASServerTestCase): | |||
1458 | 362 | self.assertTrue(form.is_valid(), form.errors) | 362 | self.assertTrue(form.is_valid(), form.errors) |
1459 | 363 | script = form.save() | 363 | script = form.save() |
1460 | 364 | 364 | ||
1467 | 365 | self.assertEquals(name, script.name) | 365 | self.assertEqual(name, script.name) |
1468 | 366 | self.assertEquals(title, script.title) | 366 | self.assertEqual(title, script.title) |
1469 | 367 | self.assertEquals(description, script.description) | 367 | self.assertEqual(description, script.description) |
1470 | 368 | self.assertEquals(tags, script.tags) | 368 | self.assertEqual(tags, script.tags) |
1471 | 369 | self.assertEquals(script_type, script.script_type) | 369 | self.assertEqual(script_type, script.script_type) |
1472 | 370 | self.assertEquals(hardware_type, script.hardware_type) | 370 | self.assertEqual(hardware_type, script.hardware_type) |
1473 | 371 | self.assertDictEqual(packages, script.packages) | 371 | self.assertDictEqual(packages, script.packages) |
1475 | 372 | self.assertEquals(parallel, script.parallel) | 372 | self.assertEqual(parallel, script.parallel) |
1476 | 373 | self.assertDictEqual(results, script.results) | 373 | self.assertDictEqual(results, script.results) |
1477 | 374 | self.assertDictEqual(parameters, script.parameters) | 374 | self.assertDictEqual(parameters, script.parameters) |
1480 | 375 | self.assertEquals(timeout, script.timeout) | 375 | self.assertEqual(timeout, script.timeout) |
1481 | 376 | self.assertEquals(destructive, script.destructive) | 376 | self.assertEqual(destructive, script.destructive) |
1482 | 377 | self.assertFalse(script.default) | 377 | self.assertFalse(script.default) |
1485 | 378 | self.assertEquals(script_content, script.script.data) | 378 | self.assertEqual(script_content, script.script.data) |
1486 | 379 | self.assertEquals(may_reboot, script.may_reboot) | 379 | self.assertEqual(may_reboot, script.may_reboot) |
1487 | 380 | self.assertItemsEqual(for_hardware, script.for_hardware) | 380 | self.assertItemsEqual(for_hardware, script.for_hardware) |
1489 | 381 | self.assertEquals(recommission, script.recommission) | 381 | self.assertEqual(recommission, script.recommission) |
1490 | 382 | 382 | ||
1491 | 383 | def test_yaml_doesnt_update_tags(self): | 383 | def test_yaml_doesnt_update_tags(self): |
1492 | 384 | script = factory.make_Script() | 384 | script = factory.make_Script() |
1493 | @@ -410,7 +410,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1494 | 410 | ) | 410 | ) |
1495 | 411 | self.assertTrue(form.is_valid(), form.errors) | 411 | self.assertTrue(form.is_valid(), form.errors) |
1496 | 412 | script = form.save() | 412 | script = form.save() |
1498 | 413 | self.assertEquals(orig_timeout, script.timeout) | 413 | self.assertEqual(orig_timeout, script.timeout) |
1499 | 414 | 414 | ||
1500 | 415 | def test_can_use_script_type_name(self): | 415 | def test_can_use_script_type_name(self): |
1501 | 416 | script_type = factory.pick_choice(SCRIPT_TYPE_CHOICES) | 416 | script_type = factory.pick_choice(SCRIPT_TYPE_CHOICES) |
1502 | @@ -424,7 +424,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1503 | 424 | self.assertTrue(form.is_valid(), form.errors) | 424 | self.assertTrue(form.is_valid(), form.errors) |
1504 | 425 | script = form.save() | 425 | script = form.save() |
1505 | 426 | 426 | ||
1507 | 427 | self.assertEquals(script_type, script.script_type) | 427 | self.assertEqual(script_type, script.script_type) |
1508 | 428 | 428 | ||
1509 | 429 | def test_errors_on_invalid_script_type(self): | 429 | def test_errors_on_invalid_script_type(self): |
1510 | 430 | form = ScriptForm( | 430 | form = ScriptForm( |
1511 | @@ -453,7 +453,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1512 | 453 | self.assertTrue(form.is_valid(), form.errors) | 453 | self.assertTrue(form.is_valid(), form.errors) |
1513 | 454 | script = form.save() | 454 | script = form.save() |
1514 | 455 | 455 | ||
1516 | 456 | self.assertEquals(hardware_type, script.hardware_type) | 456 | self.assertEqual(hardware_type, script.hardware_type) |
1517 | 457 | 457 | ||
1518 | 458 | def test_errors_on_invalid_hardware_type(self): | 458 | def test_errors_on_invalid_hardware_type(self): |
1519 | 459 | form = ScriptForm( | 459 | form = ScriptForm( |
1520 | @@ -486,7 +486,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1521 | 486 | self.assertTrue(form.is_valid(), form.errors) | 486 | self.assertTrue(form.is_valid(), form.errors) |
1522 | 487 | script = form.save() | 487 | script = form.save() |
1523 | 488 | 488 | ||
1525 | 489 | self.assertEquals(script_parallel, script.parallel) | 489 | self.assertEqual(script_parallel, script.parallel) |
1526 | 490 | 490 | ||
1527 | 491 | def test_errors_on_invalid_parallel_name(self): | 491 | def test_errors_on_invalid_parallel_name(self): |
1528 | 492 | form = ScriptForm( | 492 | form = ScriptForm( |
1529 | @@ -598,7 +598,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1530 | 598 | ) | 598 | ) |
1531 | 599 | self.assertTrue(form.is_valid(), form.errors) | 599 | self.assertTrue(form.is_valid(), form.errors) |
1532 | 600 | script = form.save() | 600 | script = form.save() |
1534 | 601 | self.assertEquals(script_type, script.script_type) | 601 | self.assertEqual(script_type, script.script_type) |
1535 | 602 | 602 | ||
1536 | 603 | def test_loads_yaml_embedded_attributes(self): | 603 | def test_loads_yaml_embedded_attributes(self): |
1537 | 604 | embedded_yaml = { | 604 | embedded_yaml = { |
1538 | @@ -634,33 +634,33 @@ class TestScriptForm(MAASServerTestCase): | |||
1539 | 634 | form = ScriptForm(data={"script": script_content}) | 634 | form = ScriptForm(data={"script": script_content}) |
1540 | 635 | self.assertTrue(form.is_valid(), form.errors) | 635 | self.assertTrue(form.is_valid(), form.errors) |
1541 | 636 | script = form.save() | 636 | script = form.save() |
1545 | 637 | self.assertEquals(embedded_yaml["name"], script.name) | 637 | self.assertEqual(embedded_yaml["name"], script.name) |
1546 | 638 | self.assertEquals(embedded_yaml["title"], script.title) | 638 | self.assertEqual(embedded_yaml["title"], script.title) |
1547 | 639 | self.assertEquals(embedded_yaml["description"], script.description) | 639 | self.assertEqual(embedded_yaml["description"], script.description) |
1548 | 640 | self.assertThat(script.tags, ContainsAll(embedded_yaml["tags"])) | 640 | self.assertThat(script.tags, ContainsAll(embedded_yaml["tags"])) |
1552 | 641 | self.assertEquals(embedded_yaml["script_type"], script.script_type) | 641 | self.assertEqual(embedded_yaml["script_type"], script.script_type) |
1553 | 642 | self.assertEquals(embedded_yaml["hardware_type"], script.hardware_type) | 642 | self.assertEqual(embedded_yaml["hardware_type"], script.hardware_type) |
1554 | 643 | self.assertEquals(embedded_yaml["parallel"], script.parallel) | 643 | self.assertEqual(embedded_yaml["parallel"], script.parallel) |
1555 | 644 | self.assertItemsEqual(embedded_yaml["results"], script.results) | 644 | self.assertItemsEqual(embedded_yaml["results"], script.results) |
1556 | 645 | self.assertItemsEqual(embedded_yaml["parameters"], script.parameters) | 645 | self.assertItemsEqual(embedded_yaml["parameters"], script.parameters) |
1557 | 646 | self.assertDictEqual(embedded_yaml["packages"], script.packages) | 646 | self.assertDictEqual(embedded_yaml["packages"], script.packages) |
1559 | 647 | self.assertEquals( | 647 | self.assertEqual( |
1560 | 648 | timedelta(0, embedded_yaml["timeout"]), script.timeout | 648 | timedelta(0, embedded_yaml["timeout"]), script.timeout |
1561 | 649 | ) | 649 | ) |
1564 | 650 | self.assertEquals(embedded_yaml["destructive"], script.destructive) | 650 | self.assertEqual(embedded_yaml["destructive"], script.destructive) |
1565 | 651 | self.assertEquals(embedded_yaml["may_reboot"], script.may_reboot) | 651 | self.assertEqual(embedded_yaml["may_reboot"], script.may_reboot) |
1566 | 652 | if embedded_yaml["script_type"] == SCRIPT_TYPE.COMMISSIONING: | 652 | if embedded_yaml["script_type"] == SCRIPT_TYPE.COMMISSIONING: |
1567 | 653 | self.assertItemsEqual( | 653 | self.assertItemsEqual( |
1568 | 654 | embedded_yaml["for_hardware"], script.for_hardware | 654 | embedded_yaml["for_hardware"], script.for_hardware |
1569 | 655 | ) | 655 | ) |
1571 | 656 | self.assertEquals( | 656 | self.assertEqual( |
1572 | 657 | embedded_yaml["recommission"], script.recommission | 657 | embedded_yaml["recommission"], script.recommission |
1573 | 658 | ) | 658 | ) |
1574 | 659 | else: | 659 | else: |
1575 | 660 | self.assertItemsEqual([], script.for_hardware) | 660 | self.assertItemsEqual([], script.for_hardware) |
1576 | 661 | self.assertFalse(script.recommission) | 661 | self.assertFalse(script.recommission) |
1577 | 662 | self.assertFalse(script.default) | 662 | self.assertFalse(script.default) |
1579 | 663 | self.assertEquals(script_content, script.script.data) | 663 | self.assertEqual(script_content, script.script.data) |
1580 | 664 | 664 | ||
1581 | 665 | def test_only_loads_when_script_updated(self): | 665 | def test_only_loads_when_script_updated(self): |
1582 | 666 | script = factory.make_Script( | 666 | script = factory.make_Script( |
1583 | @@ -672,7 +672,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1584 | 672 | form = ScriptForm(instance=script, data={"name": name}) | 672 | form = ScriptForm(instance=script, data={"name": name}) |
1585 | 673 | self.assertTrue(form.is_valid(), form.errors) | 673 | self.assertTrue(form.is_valid(), form.errors) |
1586 | 674 | script = form.save() | 674 | script = form.save() |
1588 | 675 | self.assertEquals(name, script.name) | 675 | self.assertEqual(name, script.name) |
1589 | 676 | 676 | ||
1590 | 677 | def test_user_option_unable_to_over_yaml_value(self): | 677 | def test_user_option_unable_to_over_yaml_value(self): |
1591 | 678 | name = factory.make_name("name") | 678 | name = factory.make_name("name") |
1592 | @@ -733,7 +733,7 @@ class TestScriptForm(MAASServerTestCase): | |||
1593 | 733 | ) | 733 | ) |
1594 | 734 | self.assertTrue(form.is_valid(), form.errors) | 734 | self.assertTrue(form.is_valid(), form.errors) |
1595 | 735 | script = form.save() | 735 | script = form.save() |
1597 | 736 | self.assertEquals(name, script.name) | 736 | self.assertEqual(name, script.name) |
1598 | 737 | 737 | ||
1599 | 738 | def tests_yaml_tags_can_be_string(self): | 738 | def tests_yaml_tags_can_be_string(self): |
1600 | 739 | tags = [factory.make_name("tag") for _ in range(3)] | 739 | tags = [factory.make_name("tag") for _ in range(3)] |
1601 | @@ -1149,8 +1149,8 @@ class TestCommissioningScriptForm(MAASServerTestCase): | |||
1602 | 1149 | self.assertTrue(form.is_valid(), form._errors) | 1149 | self.assertTrue(form.is_valid(), form._errors) |
1603 | 1150 | form.save(request) | 1150 | form.save(request) |
1604 | 1151 | new_script = Script.objects.get(name=name) | 1151 | new_script = Script.objects.get(name=name) |
1607 | 1152 | self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) | 1152 | self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) |
1608 | 1153 | self.assertEquals(content, new_script.script.data) | 1153 | self.assertEqual(content, new_script.script.data) |
1609 | 1154 | 1154 | ||
1610 | 1155 | def test_creates_commissioning_script_from_filename(self): | 1155 | def test_creates_commissioning_script_from_filename(self): |
1611 | 1156 | request = HttpRequest() | 1156 | request = HttpRequest() |
1612 | @@ -1164,8 +1164,8 @@ class TestCommissioningScriptForm(MAASServerTestCase): | |||
1613 | 1164 | self.assertTrue(form.is_valid(), form._errors) | 1164 | self.assertTrue(form.is_valid(), form._errors) |
1614 | 1165 | form.save(request) | 1165 | form.save(request) |
1615 | 1166 | new_script = Script.objects.get(name=name) | 1166 | new_script = Script.objects.get(name=name) |
1618 | 1167 | self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) | 1167 | self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) |
1619 | 1168 | self.assertEquals(content, new_script.script.data) | 1168 | self.assertEqual(content, new_script.script.data) |
1620 | 1169 | 1169 | ||
1621 | 1170 | def test_updates_commissioning_script(self): | 1170 | def test_updates_commissioning_script(self): |
1622 | 1171 | request = HttpRequest() | 1171 | request = HttpRequest() |
1623 | @@ -1179,8 +1179,8 @@ class TestCommissioningScriptForm(MAASServerTestCase): | |||
1624 | 1179 | self.assertTrue(form.is_valid(), form._errors) | 1179 | self.assertTrue(form.is_valid(), form._errors) |
1625 | 1180 | form.save(request) | 1180 | form.save(request) |
1626 | 1181 | new_script = Script.objects.get(name=script.name) | 1181 | new_script = Script.objects.get(name=script.name) |
1629 | 1182 | self.assertEquals(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) | 1182 | self.assertEqual(SCRIPT_TYPE.COMMISSIONING, new_script.script_type) |
1630 | 1183 | self.assertEquals(content, new_script.script.data) | 1183 | self.assertEqual(content, new_script.script.data) |
1631 | 1184 | 1184 | ||
1632 | 1185 | def test_creates_audit_event(self): | 1185 | def test_creates_audit_event(self): |
1633 | 1186 | request = HttpRequest() | 1186 | request = HttpRequest() |
1634 | @@ -1227,8 +1227,8 @@ class TestTestingScriptForm(MAASServerTestCase): | |||
1635 | 1227 | self.assertTrue(form.is_valid(), form._errors) | 1227 | self.assertTrue(form.is_valid(), form._errors) |
1636 | 1228 | form.save(request) | 1228 | form.save(request) |
1637 | 1229 | new_script = Script.objects.get(name=name) | 1229 | new_script = Script.objects.get(name=name) |
1640 | 1230 | self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type) | 1230 | self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type) |
1641 | 1231 | self.assertEquals(content, new_script.script.data) | 1231 | self.assertEqual(content, new_script.script.data) |
1642 | 1232 | 1232 | ||
1643 | 1233 | def test_creates_test_script_from_filename(self): | 1233 | def test_creates_test_script_from_filename(self): |
1644 | 1234 | request = HttpRequest() | 1234 | request = HttpRequest() |
1645 | @@ -1242,8 +1242,8 @@ class TestTestingScriptForm(MAASServerTestCase): | |||
1646 | 1242 | self.assertTrue(form.is_valid(), form._errors) | 1242 | self.assertTrue(form.is_valid(), form._errors) |
1647 | 1243 | form.save(request) | 1243 | form.save(request) |
1648 | 1244 | new_script = Script.objects.get(name=name) | 1244 | new_script = Script.objects.get(name=name) |
1651 | 1245 | self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type) | 1245 | self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type) |
1652 | 1246 | self.assertEquals(content, new_script.script.data) | 1246 | self.assertEqual(content, new_script.script.data) |
1653 | 1247 | 1247 | ||
1654 | 1248 | def test_updates_test_script(self): | 1248 | def test_updates_test_script(self): |
1655 | 1249 | request = HttpRequest() | 1249 | request = HttpRequest() |
1656 | @@ -1257,8 +1257,8 @@ class TestTestingScriptForm(MAASServerTestCase): | |||
1657 | 1257 | self.assertTrue(form.is_valid(), form._errors) | 1257 | self.assertTrue(form.is_valid(), form._errors) |
1658 | 1258 | form.save(request) | 1258 | form.save(request) |
1659 | 1259 | new_script = Script.objects.get(name=script.name) | 1259 | new_script = Script.objects.get(name=script.name) |
1662 | 1260 | self.assertEquals(SCRIPT_TYPE.TESTING, new_script.script_type) | 1260 | self.assertEqual(SCRIPT_TYPE.TESTING, new_script.script_type) |
1663 | 1261 | self.assertEquals(content, new_script.script.data) | 1261 | self.assertEqual(content, new_script.script.data) |
1664 | 1262 | 1262 | ||
1665 | 1263 | def test_creates_audit_event(self): | 1263 | def test_creates_audit_event(self): |
1666 | 1264 | request = HttpRequest() | 1264 | request = HttpRequest() |
1667 | diff --git a/src/maasserver/forms/tests/test_sslkey.py b/src/maasserver/forms/tests/test_sslkey.py | |||
1668 | index 63113a2..f13a8ed 100644 | |||
1669 | --- a/src/maasserver/forms/tests/test_sslkey.py | |||
1670 | +++ b/src/maasserver/forms/tests/test_sslkey.py | |||
1671 | @@ -27,4 +27,4 @@ class TestSSLKeyForm(MAASServerTestCase): | |||
1672 | 27 | form.save(factory.pick_choice(ENDPOINT_CHOICES), request) | 27 | form.save(factory.pick_choice(ENDPOINT_CHOICES), request) |
1673 | 28 | event = Event.objects.get(type__level=AUDIT) | 28 | event = Event.objects.get(type__level=AUDIT) |
1674 | 29 | self.assertIsNotNone(event) | 29 | self.assertIsNotNone(event) |
1676 | 30 | self.assertEquals(event.description, "Created SSL key.") | 30 | self.assertEqual(event.description, "Created SSL key.") |
1677 | diff --git a/src/maasserver/forms/tests/test_subnet.py b/src/maasserver/forms/tests/test_subnet.py | |||
1678 | index e1845a4..0d5228e 100644 | |||
1679 | --- a/src/maasserver/forms/tests/test_subnet.py | |||
1680 | +++ b/src/maasserver/forms/tests/test_subnet.py | |||
1681 | @@ -311,7 +311,7 @@ class TestSubnetForm(MAASServerTestCase): | |||
1682 | 311 | self.assertTrue(form.is_valid(), dict(form.errors)) | 311 | self.assertTrue(form.is_valid(), dict(form.errors)) |
1683 | 312 | form.save() | 312 | form.save() |
1684 | 313 | subnet = reload_object(subnet) | 313 | subnet = reload_object(subnet) |
1686 | 314 | self.assertEquals(dns_servers, subnet.dns_servers) | 314 | self.assertEqual(dns_servers, subnet.dns_servers) |
1687 | 315 | 315 | ||
1688 | 316 | def test_doesnt_overwrite_other_fields(self): | 316 | def test_doesnt_overwrite_other_fields(self): |
1689 | 317 | new_name = factory.make_name("subnet") | 317 | new_name = factory.make_name("subnet") |
1690 | @@ -355,7 +355,7 @@ class TestSubnetForm(MAASServerTestCase): | |||
1691 | 355 | self.assertTrue(form.is_valid(), dict(form.errors)) | 355 | self.assertTrue(form.is_valid(), dict(form.errors)) |
1692 | 356 | form.save() | 356 | form.save() |
1693 | 357 | subnet = reload_object(subnet) | 357 | subnet = reload_object(subnet) |
1695 | 358 | self.assertEquals(dns_servers, subnet.dns_servers) | 358 | self.assertEqual(dns_servers, subnet.dns_servers) |
1696 | 359 | 359 | ||
1697 | 360 | def test_clean_dns_servers_accepts_space_separated_list(self): | 360 | def test_clean_dns_servers_accepts_space_separated_list(self): |
1698 | 361 | subnet = factory.make_Subnet() | 361 | subnet = factory.make_Subnet() |
1699 | @@ -368,4 +368,4 @@ class TestSubnetForm(MAASServerTestCase): | |||
1700 | 368 | self.assertTrue(form.is_valid(), dict(form.errors)) | 368 | self.assertTrue(form.is_valid(), dict(form.errors)) |
1701 | 369 | form.save() | 369 | form.save() |
1702 | 370 | subnet = reload_object(subnet) | 370 | subnet = reload_object(subnet) |
1704 | 371 | self.assertEquals(dns_servers, subnet.dns_servers) | 371 | self.assertEqual(dns_servers, subnet.dns_servers) |
1705 | diff --git a/src/maasserver/forms/tests/test_vlan.py b/src/maasserver/forms/tests/test_vlan.py | |||
1706 | index 1f25e3a..a2b19d9 100644 | |||
1707 | --- a/src/maasserver/forms/tests/test_vlan.py | |||
1708 | +++ b/src/maasserver/forms/tests/test_vlan.py | |||
1709 | @@ -272,7 +272,7 @@ class TestVLANForm(MAASServerTestCase): | |||
1710 | 272 | self.assertTrue(form.is_valid(), form.errors) | 272 | self.assertTrue(form.is_valid(), form.errors) |
1711 | 273 | form.save() | 273 | form.save() |
1712 | 274 | vlan = reload_object(vlan) | 274 | vlan = reload_object(vlan) |
1714 | 275 | self.assertEquals(relay_vlan.id, vlan.relay_vlan.id) | 275 | self.assertEqual(relay_vlan.id, vlan.relay_vlan.id) |
1715 | 276 | 276 | ||
1716 | 277 | def test_update_clears_relay_vlan_when_None(self): | 277 | def test_update_clears_relay_vlan_when_None(self): |
1717 | 278 | relay_vlan = factory.make_VLAN() | 278 | relay_vlan = factory.make_VLAN() |
1718 | @@ -299,7 +299,7 @@ class TestVLANForm(MAASServerTestCase): | |||
1719 | 299 | self.assertTrue(form.is_valid(), form.errors) | 299 | self.assertTrue(form.is_valid(), form.errors) |
1720 | 300 | form.save() | 300 | form.save() |
1721 | 301 | vlan = reload_object(vlan) | 301 | vlan = reload_object(vlan) |
1723 | 302 | self.assertEquals(space.id, vlan.space.id) | 302 | self.assertEqual(space.id, vlan.space.id) |
1724 | 303 | 303 | ||
1725 | 304 | def test_update_sets_space_by_specifier(self): | 304 | def test_update_sets_space_by_specifier(self): |
1726 | 305 | vlan = factory.make_VLAN() | 305 | vlan = factory.make_VLAN() |
1727 | @@ -308,7 +308,7 @@ class TestVLANForm(MAASServerTestCase): | |||
1728 | 308 | self.assertTrue(form.is_valid(), form.errors) | 308 | self.assertTrue(form.is_valid(), form.errors) |
1729 | 309 | form.save() | 309 | form.save() |
1730 | 310 | vlan = reload_object(vlan) | 310 | vlan = reload_object(vlan) |
1732 | 311 | self.assertEquals(space.id, vlan.space.id) | 311 | self.assertEqual(space.id, vlan.space.id) |
1733 | 312 | 312 | ||
1734 | 313 | def test_update_clears_space_when_None(self): | 313 | def test_update_clears_space_when_None(self): |
1735 | 314 | space = factory.make_Space() | 314 | space = factory.make_Space() |
1736 | diff --git a/src/maasserver/models/signals/tests/test_interfaces.py b/src/maasserver/models/signals/tests/test_interfaces.py | |||
1737 | index 5bd8659..b09b10e 100644 | |||
1738 | --- a/src/maasserver/models/signals/tests/test_interfaces.py | |||
1739 | +++ b/src/maasserver/models/signals/tests/test_interfaces.py | |||
1740 | @@ -261,7 +261,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase): | |||
1741 | 261 | new_vlan = new_fabric.get_default_vlan() | 261 | new_vlan = new_fabric.get_default_vlan() |
1742 | 262 | interface.vlan = new_vlan | 262 | interface.vlan = new_vlan |
1743 | 263 | interface.save() | 263 | interface.save() |
1745 | 264 | self.assertEquals(new_vlan, reload_object(subnet).vlan) | 264 | self.assertEqual(new_vlan, reload_object(subnet).vlan) |
1746 | 265 | 265 | ||
1747 | 266 | def test_doesnt_move_link_subnets_when_target_vlan_is_None(self): | 266 | def test_doesnt_move_link_subnets_when_target_vlan_is_None(self): |
1748 | 267 | node = self.maker() | 267 | node = self.maker() |
1749 | @@ -271,7 +271,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase): | |||
1750 | 271 | factory.make_StaticIPAddress(subnet=subnet, interface=interface) | 271 | factory.make_StaticIPAddress(subnet=subnet, interface=interface) |
1751 | 272 | interface.vlan = None | 272 | interface.vlan = None |
1752 | 273 | interface.save() | 273 | interface.save() |
1754 | 274 | self.assertEquals(old_vlan, reload_object(subnet).vlan) | 274 | self.assertEqual(old_vlan, reload_object(subnet).vlan) |
1755 | 275 | 275 | ||
1756 | 276 | def test_doesnt_move_link_subnets_when_source_vlan_is_None(self): | 276 | def test_doesnt_move_link_subnets_when_source_vlan_is_None(self): |
1757 | 277 | node = self.maker() | 277 | node = self.maker() |
1758 | @@ -283,7 +283,7 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase): | |||
1759 | 283 | factory.make_StaticIPAddress(subnet=subnet, interface=interface) | 283 | factory.make_StaticIPAddress(subnet=subnet, interface=interface) |
1760 | 284 | interface.vlan = factory.make_VLAN() | 284 | interface.vlan = factory.make_VLAN() |
1761 | 285 | interface.save() | 285 | interface.save() |
1763 | 286 | self.assertEquals(interface.vlan, reload_object(subnet).vlan) | 286 | self.assertEqual(interface.vlan, reload_object(subnet).vlan) |
1764 | 287 | 287 | ||
1765 | 288 | def test_moves_children_vlans_to_same_fabric(self): | 288 | def test_moves_children_vlans_to_same_fabric(self): |
1766 | 289 | node = self.maker() | 289 | node = self.maker() |
1767 | @@ -302,14 +302,14 @@ class TestInterfaceVLANUpdateController(MAASServerTestCase): | |||
1768 | 302 | new_vlan = new_fabric.get_default_vlan() | 302 | new_vlan = new_fabric.get_default_vlan() |
1769 | 303 | parent.vlan = new_vlan | 303 | parent.vlan = new_vlan |
1770 | 304 | parent.save() | 304 | parent.save() |
1772 | 305 | self.assertEquals(new_vlan, reload_object(subnet).vlan) | 305 | self.assertEqual(new_vlan, reload_object(subnet).vlan) |
1773 | 306 | vlan_interface = reload_object(vlan_interface) | 306 | vlan_interface = reload_object(vlan_interface) |
1775 | 307 | self.assertEquals( | 307 | self.assertEqual( |
1776 | 308 | (new_fabric.id, old_vlan.vid), | 308 | (new_fabric.id, old_vlan.vid), |
1777 | 309 | (vlan_interface.vlan.fabric.id, vlan_interface.vlan.vid), | 309 | (vlan_interface.vlan.fabric.id, vlan_interface.vlan.vid), |
1778 | 310 | ) | 310 | ) |
1779 | 311 | vlan_subnet = reload_object(vlan_subnet) | 311 | vlan_subnet = reload_object(vlan_subnet) |
1781 | 312 | self.assertEquals( | 312 | self.assertEqual( |
1782 | 313 | (new_fabric.id, old_vlan.vid), | 313 | (new_fabric.id, old_vlan.vid), |
1783 | 314 | (vlan_subnet.vlan.fabric.id, vlan_subnet.vlan.vid), | 314 | (vlan_subnet.vlan.fabric.id, vlan_subnet.vlan.vid), |
1784 | 315 | ) | 315 | ) |
1785 | diff --git a/src/maasserver/models/signals/tests/test_nodes.py b/src/maasserver/models/signals/tests/test_nodes.py | |||
1786 | index 27888d6..38c4bdc 100644 | |||
1787 | --- a/src/maasserver/models/signals/tests/test_nodes.py | |||
1788 | +++ b/src/maasserver/models/signals/tests/test_nodes.py | |||
1789 | @@ -36,7 +36,7 @@ class TestNodeDeletion(MAASServerTestCase): | |||
1790 | 36 | events = [factory.make_Event(node=node) for _ in range(3)] | 36 | events = [factory.make_Event(node=node) for _ in range(3)] |
1791 | 37 | node.delete() | 37 | node.delete() |
1792 | 38 | for event in events: | 38 | for event in events: |
1794 | 39 | self.assertEquals(event.node_hostname, node_hostname) | 39 | self.assertEqual(event.node_hostname, node_hostname) |
1795 | 40 | 40 | ||
1796 | 41 | def test_deleting_node_sets_node_to_null(self): | 41 | def test_deleting_node_sets_node_to_null(self): |
1797 | 42 | node = factory.make_Node() | 42 | node = factory.make_Node() |
1798 | @@ -87,7 +87,7 @@ class TestNodePreviousStatus(MAASServerTestCase): | |||
1799 | 87 | ) | 87 | ) |
1800 | 88 | node.status = random.choice(NODE_TRANSITIONS[node.status]) | 88 | node.status = random.choice(NODE_TRANSITIONS[node.status]) |
1801 | 89 | node.save() | 89 | node.save() |
1803 | 90 | self.assertEquals(previous_status, node.previous_status) | 90 | self.assertEqual(previous_status, node.previous_status) |
1804 | 91 | 91 | ||
1805 | 92 | 92 | ||
1806 | 93 | class TestNodeClearsOwnerNEWOrREADYStatus(MAASServerTestCase): | 93 | class TestNodeClearsOwnerNEWOrREADYStatus(MAASServerTestCase): |
1807 | diff --git a/src/maasserver/models/signals/tests/test_podhints.py b/src/maasserver/models/signals/tests/test_podhints.py | |||
1808 | index f11a3cb..696e574 100644 | |||
1809 | --- a/src/maasserver/models/signals/tests/test_podhints.py | |||
1810 | +++ b/src/maasserver/models/signals/tests/test_podhints.py | |||
1811 | @@ -17,6 +17,6 @@ class TestCreatePodChanged(MAASServerTestCase): | |||
1812 | 17 | node = factory.make_Node(memory=2048) | 17 | node = factory.make_Node(memory=2048) |
1813 | 18 | pod.hints.nodes.add(node) | 18 | pod.hints.nodes.add(node) |
1814 | 19 | pod.sync_hints_from_nodes() | 19 | pod.sync_hints_from_nodes() |
1816 | 20 | self.assertEquals(2048, pod.memory) | 20 | self.assertEqual(2048, pod.memory) |
1817 | 21 | pod.hints.nodes.remove(node) | 21 | pod.hints.nodes.remove(node) |
1819 | 22 | self.assertEquals(0, reload_object(pod).memory) | 22 | self.assertEqual(0, reload_object(pod).memory) |
1820 | diff --git a/src/maasserver/models/signals/tests/test_services.py b/src/maasserver/models/signals/tests/test_services.py | |||
1821 | index 0c237ef..ce50387 100644 | |||
1822 | --- a/src/maasserver/models/signals/tests/test_services.py | |||
1823 | +++ b/src/maasserver/models/signals/tests/test_services.py | |||
1824 | @@ -88,9 +88,7 @@ class TestRegionControllerProcess(MAASServerTestCase): | |||
1825 | 88 | rack_controllers = [factory.make_RackController() for _ in range(3)] | 88 | rack_controllers = [factory.make_RackController() for _ in range(3)] |
1826 | 89 | mock_create_for = self.patch(Service.objects, "create_services_for") | 89 | mock_create_for = self.patch(Service.objects, "create_services_for") |
1827 | 90 | factory.make_RegionControllerProcess() | 90 | factory.make_RegionControllerProcess() |
1831 | 91 | self.assertEquals( | 91 | self.assertEqual(len(rack_controllers) + 1, mock_create_for.call_count) |
1829 | 92 | len(rack_controllers) + 1, mock_create_for.call_count | ||
1830 | 93 | ) | ||
1832 | 94 | 92 | ||
1833 | 95 | def test_calls_update_rackd_status_on_all_racks_on_create(self): | 93 | def test_calls_update_rackd_status_on_all_racks_on_create(self): |
1834 | 96 | rack_controllers = [factory.make_RackController() for _ in range(3)] | 94 | rack_controllers = [factory.make_RackController() for _ in range(3)] |
1835 | @@ -98,7 +96,7 @@ class TestRegionControllerProcess(MAASServerTestCase): | |||
1836 | 98 | RackController, "update_rackd_status" | 96 | RackController, "update_rackd_status" |
1837 | 99 | ) | 97 | ) |
1838 | 100 | factory.make_RegionControllerProcess() | 98 | factory.make_RegionControllerProcess() |
1840 | 101 | self.assertEquals( | 99 | self.assertEqual( |
1841 | 102 | len(rack_controllers), mock_update_rackd_status.call_count | 100 | len(rack_controllers), mock_update_rackd_status.call_count |
1842 | 103 | ) | 101 | ) |
1843 | 104 | 102 | ||
1844 | @@ -107,7 +105,7 @@ class TestRegionControllerProcess(MAASServerTestCase): | |||
1845 | 107 | process = factory.make_RegionControllerProcess() | 105 | process = factory.make_RegionControllerProcess() |
1846 | 108 | mock_create_for = self.patch(Service.objects, "create_services_for") | 106 | mock_create_for = self.patch(Service.objects, "create_services_for") |
1847 | 109 | process.delete() | 107 | process.delete() |
1849 | 110 | self.assertEquals(len(rack_controllers), mock_create_for.call_count) | 108 | self.assertEqual(len(rack_controllers), mock_create_for.call_count) |
1850 | 111 | 109 | ||
1851 | 112 | def test_calls_update_rackd_status_on_all_racks_on_delete(self): | 110 | def test_calls_update_rackd_status_on_all_racks_on_delete(self): |
1852 | 113 | rack_controllers = [factory.make_RackController() for _ in range(3)] | 111 | rack_controllers = [factory.make_RackController() for _ in range(3)] |
1853 | @@ -116,6 +114,6 @@ class TestRegionControllerProcess(MAASServerTestCase): | |||
1854 | 116 | RackController, "update_rackd_status" | 114 | RackController, "update_rackd_status" |
1855 | 117 | ) | 115 | ) |
1856 | 118 | process.delete() | 116 | process.delete() |
1858 | 119 | self.assertEquals( | 117 | self.assertEqual( |
1859 | 120 | len(rack_controllers), mock_update_rackd_status.call_count | 118 | len(rack_controllers), mock_update_rackd_status.call_count |
1860 | 121 | ) | 119 | ) |
1861 | diff --git a/src/maasserver/models/signals/tests/test_users.py b/src/maasserver/models/signals/tests/test_users.py | |||
1862 | index d581351..0198f65 100644 | |||
1863 | --- a/src/maasserver/models/signals/tests/test_users.py | |||
1864 | +++ b/src/maasserver/models/signals/tests/test_users.py | |||
1865 | @@ -18,4 +18,4 @@ class TestUserUsername(MAASServerTestCase): | |||
1866 | 18 | events = [factory.make_Event(user=user) for _ in range(3)] | 18 | events = [factory.make_Event(user=user) for _ in range(3)] |
1867 | 19 | user.delete() | 19 | user.delete() |
1868 | 20 | for event in events: | 20 | for event in events: |
1870 | 21 | self.assertEquals(event.username, username) | 21 | self.assertEqual(event.username, username) |
1871 | diff --git a/src/maasserver/models/tests/test_bmc.py b/src/maasserver/models/tests/test_bmc.py | |||
1872 | index 76216e9..280f6e2 100644 | |||
1873 | --- a/src/maasserver/models/tests/test_bmc.py | |||
1874 | +++ b/src/maasserver/models/tests/test_bmc.py | |||
1875 | @@ -2414,7 +2414,7 @@ class TestPod(MAASServerTestCase): | |||
1876 | 2414 | ) | 2414 | ) |
1877 | 2415 | node = reload_object(node) | 2415 | node = reload_object(node) |
1878 | 2416 | self.assertItemsEqual([node], pod.hints.nodes.all()) | 2416 | self.assertItemsEqual([node], pod.hints.nodes.all()) |
1880 | 2417 | self.assertEquals(NODE_STATUS.DEPLOYED, node.status) | 2417 | self.assertEqual(NODE_STATUS.DEPLOYED, node.status) |
1881 | 2418 | self.assertIsNotNone(node.current_commissioning_script_set) | 2418 | self.assertIsNotNone(node.current_commissioning_script_set) |
1882 | 2419 | 2419 | ||
1883 | 2420 | def test_sync_converts_existing_device(self): | 2420 | def test_sync_converts_existing_device(self): |
1884 | @@ -2435,8 +2435,8 @@ class TestPod(MAASServerTestCase): | |||
1885 | 2435 | ) | 2435 | ) |
1886 | 2436 | device = reload_object(device) | 2436 | device = reload_object(device) |
1887 | 2437 | self.assertItemsEqual([device], pod.hints.nodes.all()) | 2437 | self.assertItemsEqual([device], pod.hints.nodes.all()) |
1890 | 2438 | self.assertEquals(NODE_STATUS.DEPLOYED, device.status) | 2438 | self.assertEqual(NODE_STATUS.DEPLOYED, device.status) |
1891 | 2439 | self.assertEquals(NODE_TYPE.MACHINE, device.node_type) | 2439 | self.assertEqual(NODE_TYPE.MACHINE, device.node_type) |
1892 | 2440 | self.assertIsNotNone(device.current_commissioning_script_set) | 2440 | self.assertIsNotNone(device.current_commissioning_script_set) |
1893 | 2441 | 2441 | ||
1894 | 2442 | def test_sync_creates_machine(self): | 2442 | def test_sync_creates_machine(self): |
1895 | @@ -2449,11 +2449,11 @@ class TestPod(MAASServerTestCase): | |||
1896 | 2449 | ), | 2449 | ), |
1897 | 2450 | factory.make_User(), | 2450 | factory.make_User(), |
1898 | 2451 | ) | 2451 | ) |
1900 | 2452 | self.assertEquals(1, pod.hints.nodes.count()) | 2452 | self.assertEqual(1, pod.hints.nodes.count()) |
1901 | 2453 | node = pod.hints.nodes.first() | 2453 | node = pod.hints.nodes.first() |
1905 | 2454 | self.assertEquals(pod.name, node.hostname) | 2454 | self.assertEqual(pod.name, node.hostname) |
1906 | 2455 | self.assertEquals(NODE_STATUS.DEPLOYED, node.status) | 2455 | self.assertEqual(NODE_STATUS.DEPLOYED, node.status) |
1907 | 2456 | self.assertEquals(NODE_TYPE.MACHINE, node.node_type) | 2456 | self.assertEqual(NODE_TYPE.MACHINE, node.node_type) |
1908 | 2457 | self.assertItemsEqual( | 2457 | self.assertItemsEqual( |
1909 | 2458 | mac_addresses, | 2458 | mac_addresses, |
1910 | 2459 | [str(iface.mac_address) for iface in node.interface_set.all()], | 2459 | [str(iface.mac_address) for iface in node.interface_set.all()], |
1911 | @@ -2491,15 +2491,15 @@ class TestPod(MAASServerTestCase): | |||
1912 | 2491 | elif bd.type == "iscsi": | 2491 | elif bd.type == "iscsi": |
1913 | 2492 | iscsi_storage += bd.size | 2492 | iscsi_storage += bd.size |
1914 | 2493 | 2493 | ||
1917 | 2494 | self.assertEquals(pod.hints.cores, cores) | 2494 | self.assertEqual(pod.hints.cores, cores) |
1918 | 2495 | self.assertEquals( | 2495 | self.assertEqual( |
1919 | 2496 | pod.hints.cpu_speed, | 2496 | pod.hints.cpu_speed, |
1920 | 2497 | int(mean(cpu_speeds)), | 2497 | int(mean(cpu_speeds)), |
1921 | 2498 | f"Wrong hint ({pod.hints.cpu_speed}) for CPU speed. CPU speeds of nodes: {cpu_speeds}", | 2498 | f"Wrong hint ({pod.hints.cpu_speed}) for CPU speed. CPU speeds of nodes: {cpu_speeds}", |
1922 | 2499 | ) | 2499 | ) |
1926 | 2500 | self.assertEquals(pod.hints.memory, memory) | 2500 | self.assertEqual(pod.hints.memory, memory) |
1927 | 2501 | self.assertEquals(pod.hints.local_disks, len(nodes)) | 2501 | self.assertEqual(pod.hints.local_disks, len(nodes)) |
1928 | 2502 | self.assertEquals(pod.hints.iscsi_storage, iscsi_storage) | 2502 | self.assertEqual(pod.hints.iscsi_storage, iscsi_storage) |
1929 | 2503 | 2503 | ||
1930 | 2504 | def test_get_used_cores(self): | 2504 | def test_get_used_cores(self): |
1931 | 2505 | pod = factory.make_Pod() | 2505 | pod = factory.make_Pod() |
1932 | @@ -2508,7 +2508,7 @@ class TestPod(MAASServerTestCase): | |||
1933 | 2508 | cores = random.randint(1, 4) | 2508 | cores = random.randint(1, 4) |
1934 | 2509 | total_cores += cores | 2509 | total_cores += cores |
1935 | 2510 | factory.make_Node(bmc=pod, cpu_count=cores) | 2510 | factory.make_Node(bmc=pod, cpu_count=cores) |
1937 | 2511 | self.assertEquals(total_cores, pod.get_used_cores()) | 2511 | self.assertEqual(total_cores, pod.get_used_cores()) |
1938 | 2512 | 2512 | ||
1939 | 2513 | def test_get_used_memory(self): | 2513 | def test_get_used_memory(self): |
1940 | 2514 | pod = factory.make_Pod() | 2514 | pod = factory.make_Pod() |
1941 | @@ -2517,7 +2517,7 @@ class TestPod(MAASServerTestCase): | |||
1942 | 2517 | memory = random.randint(1, 4) | 2517 | memory = random.randint(1, 4) |
1943 | 2518 | total_memory += memory | 2518 | total_memory += memory |
1944 | 2519 | factory.make_Node(bmc=pod, memory=memory) | 2519 | factory.make_Node(bmc=pod, memory=memory) |
1946 | 2520 | self.assertEquals(total_memory, pod.get_used_memory()) | 2520 | self.assertEqual(total_memory, pod.get_used_memory()) |
1947 | 2521 | 2521 | ||
1948 | 2522 | def test_get_used_local_storage(self): | 2522 | def test_get_used_local_storage(self): |
1949 | 2523 | pod = factory.make_Pod() | 2523 | pod = factory.make_Pod() |
1950 | @@ -2527,7 +2527,7 @@ class TestPod(MAASServerTestCase): | |||
1951 | 2527 | total_storage += storage | 2527 | total_storage += storage |
1952 | 2528 | node = factory.make_Node(bmc=pod, with_boot_disk=False) | 2528 | node = factory.make_Node(bmc=pod, with_boot_disk=False) |
1953 | 2529 | factory.make_PhysicalBlockDevice(node=node, size=storage) | 2529 | factory.make_PhysicalBlockDevice(node=node, size=storage) |
1955 | 2530 | self.assertEquals(total_storage, pod.get_used_local_storage()) | 2530 | self.assertEqual(total_storage, pod.get_used_local_storage()) |
1956 | 2531 | 2531 | ||
1957 | 2532 | def test_get_used_local_disks(self): | 2532 | def test_get_used_local_disks(self): |
1958 | 2533 | pod = factory.make_Pod() | 2533 | pod = factory.make_Pod() |
1959 | @@ -2535,7 +2535,7 @@ class TestPod(MAASServerTestCase): | |||
1960 | 2535 | node = factory.make_Node(bmc=pod, with_boot_disk=False) | 2535 | node = factory.make_Node(bmc=pod, with_boot_disk=False) |
1961 | 2536 | for _ in range(3): | 2536 | for _ in range(3): |
1962 | 2537 | factory.make_PhysicalBlockDevice(node=node) | 2537 | factory.make_PhysicalBlockDevice(node=node) |
1964 | 2538 | self.assertEquals(9, pod.get_used_local_disks()) | 2538 | self.assertEqual(9, pod.get_used_local_disks()) |
1965 | 2539 | 2539 | ||
1966 | 2540 | def test_get_used_iscsi_storage(self): | 2540 | def test_get_used_iscsi_storage(self): |
1967 | 2541 | pod = factory.make_Pod() | 2541 | pod = factory.make_Pod() |
1968 | @@ -2545,7 +2545,7 @@ class TestPod(MAASServerTestCase): | |||
1969 | 2545 | total_storage += storage | 2545 | total_storage += storage |
1970 | 2546 | node = factory.make_Node(bmc=pod, with_boot_disk=False) | 2546 | node = factory.make_Node(bmc=pod, with_boot_disk=False) |
1971 | 2547 | factory.make_ISCSIBlockDevice(node=node, size=storage) | 2547 | factory.make_ISCSIBlockDevice(node=node, size=storage) |
1973 | 2548 | self.assertEquals(total_storage, pod.get_used_iscsi_storage()) | 2548 | self.assertEqual(total_storage, pod.get_used_iscsi_storage()) |
1974 | 2549 | 2549 | ||
1975 | 2550 | def test_sync_machine_memory(self): | 2550 | def test_sync_machine_memory(self): |
1976 | 2551 | pod = factory.make_Pod(pod_type="lxd") | 2551 | pod = factory.make_Pod(pod_type="lxd") |
1977 | diff --git a/src/maasserver/models/tests/test_bootresource.py b/src/maasserver/models/tests/test_bootresource.py | |||
1978 | index f0e1c9d..0c32b14 100644 | |||
1979 | --- a/src/maasserver/models/tests/test_bootresource.py | |||
1980 | +++ b/src/maasserver/models/tests/test_bootresource.py | |||
1981 | @@ -189,7 +189,7 @@ class TestBootResourceManager(MAASServerTestCase): | |||
1982 | 189 | architecture="amd64/hwe-16.04", | 189 | architecture="amd64/hwe-16.04", |
1983 | 190 | extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"}, | 190 | extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"}, |
1984 | 191 | ) | 191 | ) |
1986 | 192 | self.assertEquals( | 192 | self.assertEqual( |
1987 | 193 | ["hwe-16.04"], BootResource.objects.get_usable_hwe_kernels() | 193 | ["hwe-16.04"], BootResource.objects.get_usable_hwe_kernels() |
1988 | 194 | ) | 194 | ) |
1989 | 195 | 195 | ||
1990 | @@ -198,7 +198,7 @@ class TestBootResourceManager(MAASServerTestCase): | |||
1991 | 198 | architecture="amd64/hwe-16.04", | 198 | architecture="amd64/hwe-16.04", |
1992 | 199 | extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"}, | 199 | extra={"subarches": "hwe-p,hwe-t,hwe-16.04,hwe-16.10"}, |
1993 | 200 | ) | 200 | ) |
1995 | 201 | self.assertEquals( | 201 | self.assertEqual( |
1996 | 202 | ["hwe-p", "hwe-t", "hwe-16.04", "hwe-16.10"], | 202 | ["hwe-p", "hwe-t", "hwe-16.04", "hwe-16.10"], |
1997 | 203 | BootResource.objects.get_supported_hwe_kernels(), | 203 | BootResource.objects.get_supported_hwe_kernels(), |
1998 | 204 | ) | 204 | ) |
1999 | diff --git a/src/maasserver/models/tests/test_bootsourcecache.py b/src/maasserver/models/tests/test_bootsourcecache.py | |||
2000 | index 18ac56f..8a75908 100644 | |||
2001 | --- a/src/maasserver/models/tests/test_bootsourcecache.py | |||
2002 | +++ b/src/maasserver/models/tests/test_bootsourcecache.py | |||
2003 | @@ -33,7 +33,7 @@ class TestBootSourceCache(MAASServerTestCase): | |||
2004 | 33 | def test_get_release_title_returns_release_title(self): | 33 | def test_get_release_title_returns_release_title(self): |
2005 | 34 | release_title = factory.make_name("release_title") | 34 | release_title = factory.make_name("release_title") |
2006 | 35 | cache = factory.make_BootSourceCache(release_title=release_title) | 35 | cache = factory.make_BootSourceCache(release_title=release_title) |
2008 | 36 | self.assertEquals( | 36 | self.assertEqual( |
2009 | 37 | release_title, | 37 | release_title, |
2010 | 38 | BootSourceCache.objects.get_release_title(cache.os, cache.release), | 38 | BootSourceCache.objects.get_release_title(cache.os, cache.release), |
2011 | 39 | ) | 39 | ) |
2012 | @@ -54,7 +54,7 @@ class TestBootSourceCache(MAASServerTestCase): | |||
2013 | 54 | def test_get_release_codename_returns_release_codename(self): | 54 | def test_get_release_codename_returns_release_codename(self): |
2014 | 55 | release_codename = factory.make_name("release_codename") | 55 | release_codename = factory.make_name("release_codename") |
2015 | 56 | cache = factory.make_BootSourceCache(release_codename=release_codename) | 56 | cache = factory.make_BootSourceCache(release_codename=release_codename) |
2017 | 57 | self.assertEquals( | 57 | self.assertEqual( |
2018 | 58 | release_codename, | 58 | release_codename, |
2019 | 59 | BootSourceCache.objects.get_release_codename( | 59 | BootSourceCache.objects.get_release_codename( |
2020 | 60 | cache.os, cache.release | 60 | cache.os, cache.release |
2021 | diff --git a/src/maasserver/models/tests/test_cleansave.py b/src/maasserver/models/tests/test_cleansave.py | |||
2022 | index fa4437a..bfeaf25 100644 | |||
2023 | --- a/src/maasserver/models/tests/test_cleansave.py | |||
2024 | +++ b/src/maasserver/models/tests/test_cleansave.py | |||
2025 | @@ -21,12 +21,12 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2026 | 21 | def test_state_is_clean_save_based(self): | 21 | def test_state_is_clean_save_based(self): |
2027 | 22 | obj = CleanSaveTestModel.objects.create() | 22 | obj = CleanSaveTestModel.objects.create() |
2028 | 23 | self.assertIsInstance(obj._state, CleanSaveModelState) | 23 | self.assertIsInstance(obj._state, CleanSaveModelState) |
2030 | 24 | self.assertEquals({}, obj._state._changed_fields) | 24 | self.assertEqual({}, obj._state._changed_fields) |
2031 | 25 | 25 | ||
2032 | 26 | def test_setting_property(self): | 26 | def test_setting_property(self): |
2033 | 27 | obj = CleanSaveModelState() | 27 | obj = CleanSaveModelState() |
2034 | 28 | obj.test_prop = sentinel.value | 28 | obj.test_prop = sentinel.value |
2036 | 29 | self.assertEquals(sentinel.value, obj.test_prop) | 29 | self.assertEqual(sentinel.value, obj.test_prop) |
2037 | 30 | 30 | ||
2038 | 31 | def test_handling_deferred_field_getting(self): | 31 | def test_handling_deferred_field_getting(self): |
2039 | 32 | obj = CleanSaveTestModel.objects.create() | 32 | obj = CleanSaveTestModel.objects.create() |
2040 | @@ -43,24 +43,24 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2041 | 43 | def test_field_marked_changed_for_new_obj(self): | 43 | def test_field_marked_changed_for_new_obj(self): |
2042 | 44 | obj = CleanSaveTestModel() | 44 | obj = CleanSaveTestModel() |
2043 | 45 | obj.field = "test" | 45 | obj.field = "test" |
2045 | 46 | self.assertEquals({"field": None}, obj._state._changed_fields) | 46 | self.assertEqual({"field": None}, obj._state._changed_fields) |
2046 | 47 | 47 | ||
2047 | 48 | def test_field_marked_changed_for_new_obj_when_reset(self): | 48 | def test_field_marked_changed_for_new_obj_when_reset(self): |
2048 | 49 | obj = CleanSaveTestModel() | 49 | obj = CleanSaveTestModel() |
2049 | 50 | obj.field = "test" | 50 | obj.field = "test" |
2050 | 51 | obj.field = None | 51 | obj.field = None |
2052 | 52 | self.assertEquals({"field": None}, obj._state._changed_fields) | 52 | self.assertEqual({"field": None}, obj._state._changed_fields) |
2053 | 53 | 53 | ||
2054 | 54 | def test_field_marked_changed_for_existing_obj(self): | 54 | def test_field_marked_changed_for_existing_obj(self): |
2055 | 55 | obj = CleanSaveTestModel.objects.create() | 55 | obj = CleanSaveTestModel.objects.create() |
2056 | 56 | obj.field = "test" | 56 | obj.field = "test" |
2058 | 57 | self.assertEquals({"field": None}, obj._state._changed_fields) | 57 | self.assertEqual({"field": None}, obj._state._changed_fields) |
2059 | 58 | 58 | ||
2060 | 59 | def test_field_not_marked_changed_for_existing_obj_when_reset(self): | 59 | def test_field_not_marked_changed_for_existing_obj_when_reset(self): |
2061 | 60 | obj = CleanSaveTestModel.objects.create() | 60 | obj = CleanSaveTestModel.objects.create() |
2062 | 61 | obj.field = "test" | 61 | obj.field = "test" |
2063 | 62 | obj.field = None | 62 | obj.field = None |
2065 | 63 | self.assertEquals({}, obj._state._changed_fields) | 63 | self.assertEqual({}, obj._state._changed_fields) |
2066 | 64 | 64 | ||
2067 | 65 | def test_field_not_marked_changed_when_refresh_from_db(self): | 65 | def test_field_not_marked_changed_when_refresh_from_db(self): |
2068 | 66 | obj = CleanSaveTestModel.objects.create() | 66 | obj = CleanSaveTestModel.objects.create() |
2069 | @@ -69,8 +69,8 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2070 | 69 | duplicate.save() | 69 | duplicate.save() |
2071 | 70 | 70 | ||
2072 | 71 | obj.refresh_from_db() | 71 | obj.refresh_from_db() |
2075 | 72 | self.assertEquals("test", obj.field) | 72 | self.assertEqual("test", obj.field) |
2076 | 73 | self.assertEquals({}, obj._state._changed_fields) | 73 | self.assertEqual({}, obj._state._changed_fields) |
2077 | 74 | 74 | ||
2078 | 75 | def test_field_not_marked_changed_when_refresh_from_db_no_fields(self): | 75 | def test_field_not_marked_changed_when_refresh_from_db_no_fields(self): |
2079 | 76 | obj = CleanSaveTestModel.objects.create() | 76 | obj = CleanSaveTestModel.objects.create() |
2080 | @@ -79,8 +79,8 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2081 | 79 | duplicate.save() | 79 | duplicate.save() |
2082 | 80 | 80 | ||
2083 | 81 | obj.refresh_from_db(fields=[]) | 81 | obj.refresh_from_db(fields=[]) |
2086 | 82 | self.assertEquals(None, obj.field) | 82 | self.assertEqual(None, obj.field) |
2087 | 83 | self.assertEquals({}, obj._state._changed_fields) | 83 | self.assertEqual({}, obj._state._changed_fields) |
2088 | 84 | 84 | ||
2089 | 85 | def test_field_not_marked_changed_when_refresh_with_changed_fields(self): | 85 | def test_field_not_marked_changed_when_refresh_with_changed_fields(self): |
2090 | 86 | obj = CleanSaveTestModel.objects.create() | 86 | obj = CleanSaveTestModel.objects.create() |
2091 | @@ -89,15 +89,15 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2092 | 89 | duplicate.save() | 89 | duplicate.save() |
2093 | 90 | 90 | ||
2094 | 91 | obj.refresh_from_db(fields=["field"]) | 91 | obj.refresh_from_db(fields=["field"]) |
2097 | 92 | self.assertEquals("test", obj.field) | 92 | self.assertEqual("test", obj.field) |
2098 | 93 | self.assertEquals({}, obj._state._changed_fields) | 93 | self.assertEqual({}, obj._state._changed_fields) |
2099 | 94 | 94 | ||
2100 | 95 | def test_field_not_marked_changed_when_refresh_with_same_fields(self): | 95 | def test_field_not_marked_changed_when_refresh_with_same_fields(self): |
2101 | 96 | obj = CleanSaveTestModel.objects.create() | 96 | obj = CleanSaveTestModel.objects.create() |
2102 | 97 | 97 | ||
2103 | 98 | obj.refresh_from_db(fields=["field"]) | 98 | obj.refresh_from_db(fields=["field"]) |
2106 | 99 | self.assertEquals(None, obj.field) | 99 | self.assertEqual(None, obj.field) |
2107 | 100 | self.assertEquals({}, obj._state._changed_fields) | 100 | self.assertEqual({}, obj._state._changed_fields) |
2108 | 101 | 101 | ||
2109 | 102 | def test_field_marked_changed_when_refresh_from_db_with_no_fields(self): | 102 | def test_field_marked_changed_when_refresh_from_db_with_no_fields(self): |
2110 | 103 | obj = CleanSaveTestModel.objects.create() | 103 | obj = CleanSaveTestModel.objects.create() |
2111 | @@ -107,27 +107,27 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2112 | 107 | 107 | ||
2113 | 108 | obj.field = "test" | 108 | obj.field = "test" |
2114 | 109 | obj.refresh_from_db(fields=[]) | 109 | obj.refresh_from_db(fields=[]) |
2117 | 110 | self.assertEquals("test", obj.field) | 110 | self.assertEqual("test", obj.field) |
2118 | 111 | self.assertEquals({"field": None}, obj._state._changed_fields) | 111 | self.assertEqual({"field": None}, obj._state._changed_fields) |
2119 | 112 | 112 | ||
2120 | 113 | def test_field_marked_changed_rel_id_for_new_obj(self): | 113 | def test_field_marked_changed_rel_id_for_new_obj(self): |
2121 | 114 | related = GenericTestModel.objects.create(field="") | 114 | related = GenericTestModel.objects.create(field="") |
2122 | 115 | obj = CleanSaveTestModel() | 115 | obj = CleanSaveTestModel() |
2123 | 116 | obj.related_id = related.id | 116 | obj.related_id = related.id |
2125 | 117 | self.assertEquals({"related_id": None}, obj._state._changed_fields) | 117 | self.assertEqual({"related_id": None}, obj._state._changed_fields) |
2126 | 118 | 118 | ||
2127 | 119 | def test_field_marked_changed_rel_attname_for_new_obj(self): | 119 | def test_field_marked_changed_rel_attname_for_new_obj(self): |
2128 | 120 | related = GenericTestModel.objects.create(field="") | 120 | related = GenericTestModel.objects.create(field="") |
2129 | 121 | obj = CleanSaveTestModel() | 121 | obj = CleanSaveTestModel() |
2130 | 122 | obj.related = related | 122 | obj.related = related |
2132 | 123 | self.assertEquals({"related_id": None}, obj._state._changed_fields) | 123 | self.assertEqual({"related_id": None}, obj._state._changed_fields) |
2133 | 124 | 124 | ||
2134 | 125 | def test_field_marked_changed_rel_id_for_existing_obj(self): | 125 | def test_field_marked_changed_rel_id_for_existing_obj(self): |
2135 | 126 | related = GenericTestModel.objects.create(field="") | 126 | related = GenericTestModel.objects.create(field="") |
2136 | 127 | new_related = GenericTestModel.objects.create(field="") | 127 | new_related = GenericTestModel.objects.create(field="") |
2137 | 128 | obj = CleanSaveTestModel.objects.create(related=related) | 128 | obj = CleanSaveTestModel.objects.create(related=related) |
2138 | 129 | obj.related_id = new_related.id | 129 | obj.related_id = new_related.id |
2140 | 130 | self.assertEquals( | 130 | self.assertEqual( |
2141 | 131 | {"related_id": related.id}, obj._state._changed_fields | 131 | {"related_id": related.id}, obj._state._changed_fields |
2142 | 132 | ) | 132 | ) |
2143 | 133 | 133 | ||
2144 | @@ -136,7 +136,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2145 | 136 | new_related = GenericTestModel.objects.create(field="") | 136 | new_related = GenericTestModel.objects.create(field="") |
2146 | 137 | obj = CleanSaveTestModel.objects.create(related=related) | 137 | obj = CleanSaveTestModel.objects.create(related=related) |
2147 | 138 | obj.related = new_related | 138 | obj.related = new_related |
2149 | 139 | self.assertEquals( | 139 | self.assertEqual( |
2150 | 140 | {"related_id": related.id}, obj._state._changed_fields | 140 | {"related_id": related.id}, obj._state._changed_fields |
2151 | 141 | ) | 141 | ) |
2152 | 142 | 142 | ||
2153 | @@ -146,7 +146,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2154 | 146 | obj = CleanSaveTestModel.objects.create(related=related) | 146 | obj = CleanSaveTestModel.objects.create(related=related) |
2155 | 147 | obj.related_id = new_related.id | 147 | obj.related_id = new_related.id |
2156 | 148 | obj.related_id = related.id | 148 | obj.related_id = related.id |
2158 | 149 | self.assertEquals({}, obj._state._changed_fields) | 149 | self.assertEqual({}, obj._state._changed_fields) |
2159 | 150 | 150 | ||
2160 | 151 | def test_field_not_marked_changed_rel_attname_for_existing_obj(self): | 151 | def test_field_not_marked_changed_rel_attname_for_existing_obj(self): |
2161 | 152 | related = GenericTestModel.objects.create(field="") | 152 | related = GenericTestModel.objects.create(field="") |
2162 | @@ -154,7 +154,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2163 | 154 | obj = CleanSaveTestModel.objects.create(related=related) | 154 | obj = CleanSaveTestModel.objects.create(related=related) |
2164 | 155 | obj.related = new_related | 155 | obj.related = new_related |
2165 | 156 | obj.related = related | 156 | obj.related = related |
2167 | 157 | self.assertEquals({}, obj._state._changed_fields) | 157 | self.assertEqual({}, obj._state._changed_fields) |
2168 | 158 | 158 | ||
2169 | 159 | def test_save_always_calls_save_when_new(self): | 159 | def test_save_always_calls_save_when_new(self): |
2170 | 160 | mock_save = self.patch(Model, "save") | 160 | mock_save = self.patch(Model, "save") |
2171 | @@ -185,7 +185,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2172 | 185 | obj = CleanSaveTestModel() | 185 | obj = CleanSaveTestModel() |
2173 | 186 | obj.field = "test" | 186 | obj.field = "test" |
2174 | 187 | obj.save() | 187 | obj.save() |
2176 | 188 | self.assertEquals({}, obj._state._changed_fields) | 188 | self.assertEqual({}, obj._state._changed_fields) |
2177 | 189 | 189 | ||
2178 | 190 | def test_save_performed_with_force_update(self): | 190 | def test_save_performed_with_force_update(self): |
2179 | 191 | obj = CleanSaveTestModel.objects.create() | 191 | obj = CleanSaveTestModel.objects.create() |
2180 | @@ -237,7 +237,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2181 | 237 | using="default", | 237 | using="default", |
2182 | 238 | ), | 238 | ), |
2183 | 239 | ) | 239 | ) |
2185 | 240 | self.assertEquals({}, obj._state._changed_fields) | 240 | self.assertEqual({}, obj._state._changed_fields) |
2186 | 241 | 241 | ||
2187 | 242 | def test_save_table_updates_update_fields_with_changed_fields(self): | 242 | def test_save_table_updates_update_fields_with_changed_fields(self): |
2188 | 243 | related = GenericTestModel.objects.create(field="") | 243 | related = GenericTestModel.objects.create(field="") |
2189 | @@ -257,7 +257,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2190 | 257 | using="default", | 257 | using="default", |
2191 | 258 | ), | 258 | ), |
2192 | 259 | ) | 259 | ) |
2194 | 260 | self.assertEquals({}, obj._state._changed_fields) | 260 | self.assertEqual({}, obj._state._changed_fields) |
2195 | 261 | 261 | ||
2196 | 262 | def test_save_ignores_clean_on_deferred(self): | 262 | def test_save_ignores_clean_on_deferred(self): |
2197 | 263 | obj = CleanSaveTestModel.objects.create(field="test") | 263 | obj = CleanSaveTestModel.objects.create(field="test") |
2198 | @@ -306,7 +306,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2199 | 306 | def test_utils_get_changed(self): | 306 | def test_utils_get_changed(self): |
2200 | 307 | obj = CleanSaveTestModel.objects.create() | 307 | obj = CleanSaveTestModel.objects.create() |
2201 | 308 | obj.field = "test" | 308 | obj.field = "test" |
2203 | 309 | self.assertEquals({"field"}, obj._state.get_changed()) | 309 | self.assertEqual({"field"}, obj._state.get_changed()) |
2204 | 310 | 310 | ||
2205 | 311 | def test_utils_has_changed_True(self): | 311 | def test_utils_has_changed_True(self): |
2206 | 312 | obj = CleanSaveTestModel.objects.create() | 312 | obj = CleanSaveTestModel.objects.create() |
2207 | @@ -331,7 +331,7 @@ class TestCleanSave(MAASLegacyServerTestCase): | |||
2208 | 331 | new_related = GenericTestModel.objects.create(field="") | 331 | new_related = GenericTestModel.objects.create(field="") |
2209 | 332 | obj = CleanSaveTestModel.objects.create(related=related) | 332 | obj = CleanSaveTestModel.objects.create(related=related) |
2210 | 333 | obj.related = new_related | 333 | obj.related = new_related |
2212 | 334 | self.assertEquals(related.id, obj._state.get_old_value("related_id")) | 334 | self.assertEqual(related.id, obj._state.get_old_value("related_id")) |
2213 | 335 | 335 | ||
2214 | 336 | def test_utils_get_old_value_returns_None_when_not_changed(self): | 336 | def test_utils_get_old_value_returns_None_when_not_changed(self): |
2215 | 337 | obj = CleanSaveTestModel.objects.create() | 337 | obj = CleanSaveTestModel.objects.create() |
2216 | diff --git a/src/maasserver/models/tests/test_config.py b/src/maasserver/models/tests/test_config.py | |||
2217 | index 08e2e55..1948ed2 100644 | |||
2218 | --- a/src/maasserver/models/tests/test_config.py | |||
2219 | +++ b/src/maasserver/models/tests/test_config.py | |||
2220 | @@ -127,7 +127,7 @@ class ConfigTest(MAASServerTestCase): | |||
2221 | 127 | if name != expected_names[0] | 127 | if name != expected_names[0] |
2222 | 128 | } | 128 | } |
2223 | 129 | ) | 129 | ) |
2225 | 130 | self.assertEquals(expected_dict, observed) | 130 | self.assertEqual(expected_dict, observed) |
2226 | 131 | 131 | ||
2227 | 132 | def test_manager_get_configs_returns_passed_defaults(self): | 132 | def test_manager_get_configs_returns_passed_defaults(self): |
2228 | 133 | expected = get_default_config() | 133 | expected = get_default_config() |
2229 | @@ -139,7 +139,7 @@ class ConfigTest(MAASServerTestCase): | |||
2230 | 139 | defaults = [expected_dict[name] for name in expected_names] | 139 | defaults = [expected_dict[name] for name in expected_names] |
2231 | 140 | for name, value in expected_dict.items(): | 140 | for name, value in expected_dict.items(): |
2232 | 141 | Config.objects.set_config(name, value) | 141 | Config.objects.set_config(name, value) |
2234 | 142 | self.assertEquals( | 142 | self.assertEqual( |
2235 | 143 | expected_dict, Config.objects.get_configs(expected_names, defaults) | 143 | expected_dict, Config.objects.get_configs(expected_names, defaults) |
2236 | 144 | ) | 144 | ) |
2237 | 145 | 145 | ||
2238 | diff --git a/src/maasserver/models/tests/test_filesystemgroup.py b/src/maasserver/models/tests/test_filesystemgroup.py | |||
2239 | index 488c747..88b099b 100644 | |||
2240 | --- a/src/maasserver/models/tests/test_filesystemgroup.py | |||
2241 | +++ b/src/maasserver/models/tests/test_filesystemgroup.py | |||
2242 | @@ -1025,14 +1025,14 @@ class TestFilesystemGroup(MAASServerTestCase): | |||
2243 | 1025 | 1025 | ||
2244 | 1026 | def test_get_size_returns_total_size_with_vmfs(self): | 1026 | def test_get_size_returns_total_size_with_vmfs(self): |
2245 | 1027 | vmfs = factory.make_VMFS() | 1027 | vmfs = factory.make_VMFS() |
2247 | 1028 | self.assertEquals(vmfs.get_total_size(), vmfs.get_size()) | 1028 | self.assertEqual(vmfs.get_total_size(), vmfs.get_size()) |
2248 | 1029 | 1029 | ||
2249 | 1030 | def test_get_total_size(self): | 1030 | def test_get_total_size(self): |
2250 | 1031 | vmfs = factory.make_VMFS() | 1031 | vmfs = factory.make_VMFS() |
2251 | 1032 | size = 0 | 1032 | size = 0 |
2252 | 1033 | for fs in vmfs.filesystems.all(): | 1033 | for fs in vmfs.filesystems.all(): |
2253 | 1034 | size += fs.get_size() | 1034 | size += fs.get_size() |
2255 | 1035 | self.assertEquals(size, vmfs.get_total_size()) | 1035 | self.assertEqual(size, vmfs.get_total_size()) |
2256 | 1036 | 1036 | ||
2257 | 1037 | def test_is_lvm_returns_true_when_LVM_VG(self): | 1037 | def test_is_lvm_returns_true_when_LVM_VG(self): |
2258 | 1038 | fsgroup = FilesystemGroup(group_type=FILESYSTEM_GROUP_TYPE.LVM_VG) | 1038 | fsgroup = FilesystemGroup(group_type=FILESYSTEM_GROUP_TYPE.LVM_VG) |
2259 | @@ -1083,7 +1083,7 @@ class TestFilesystemGroup(MAASServerTestCase): | |||
2260 | 1083 | part = factory.make_Partition() | 1083 | part = factory.make_Partition() |
2261 | 1084 | name = factory.make_name("datastore") | 1084 | name = factory.make_name("datastore") |
2262 | 1085 | vmfs = VMFS.objects.create_vmfs(name, [part]) | 1085 | vmfs = VMFS.objects.create_vmfs(name, [part]) |
2264 | 1086 | self.assertEquals( | 1086 | self.assertEqual( |
2265 | 1087 | "/vmfs/volumes/%s" % name, | 1087 | "/vmfs/volumes/%s" % name, |
2266 | 1088 | vmfs.virtual_device.get_effective_filesystem().mount_point, | 1088 | vmfs.virtual_device.get_effective_filesystem().mount_point, |
2267 | 1089 | ) | 1089 | ) |
2268 | diff --git a/src/maasserver/models/tests/test_interface.py b/src/maasserver/models/tests/test_interface.py | |||
2269 | index 918252e..9652490 100644 | |||
2270 | --- a/src/maasserver/models/tests/test_interface.py | |||
2271 | +++ b/src/maasserver/models/tests/test_interface.py | |||
2272 | @@ -163,7 +163,7 @@ class TestInterfaceManager(MAASServerTestCase): | |||
2273 | 163 | node=node, mac_address=mac_address | 163 | node=node, mac_address=mac_address |
2274 | 164 | ) | 164 | ) |
2275 | 165 | self.assertFalse(created) | 165 | self.assertFalse(created) |
2277 | 166 | self.assertEquals(interface, retrieved_interface) | 166 | self.assertEqual(interface, retrieved_interface) |
2278 | 167 | 167 | ||
2279 | 168 | def test_get_or_create_with_parents(self): | 168 | def test_get_or_create_with_parents(self): |
2280 | 169 | parent1 = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 169 | parent1 = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
2281 | @@ -182,7 +182,7 @@ class TestInterfaceManager(MAASServerTestCase): | |||
2282 | 182 | node=parent1.node, parents=[parent1, parent2] | 182 | node=parent1.node, parents=[parent1, parent2] |
2283 | 183 | ) | 183 | ) |
2284 | 184 | self.assertFalse(created) | 184 | self.assertFalse(created) |
2286 | 185 | self.assertEquals(interface, retrieved_interface) | 185 | self.assertEqual(interface, retrieved_interface) |
2287 | 186 | 186 | ||
2288 | 187 | def test_get_interface_dict_for_node(self): | 187 | def test_get_interface_dict_for_node(self): |
2289 | 188 | node1 = factory.make_Node() | 188 | node1 = factory.make_Node() |
2290 | @@ -1341,8 +1341,8 @@ class InterfaceTest(MAASServerTestCase): | |||
2291 | 1341 | interface.interface_speed = 100 | 1341 | interface.interface_speed = 100 |
2292 | 1342 | interface.link_speed = 1000 | 1342 | interface.link_speed = 1000 |
2293 | 1343 | interface.save() | 1343 | interface.save() |
2296 | 1344 | self.assertEquals(100, interface.interface_speed) | 1344 | self.assertEqual(100, interface.interface_speed) |
2297 | 1345 | self.assertEquals(1000, interface.link_speed) | 1345 | self.assertEqual(1000, interface.link_speed) |
2298 | 1346 | 1346 | ||
2299 | 1347 | def test_save_link_speed_may_exceed_unknown_interface_speed(self): | 1347 | def test_save_link_speed_may_exceed_unknown_interface_speed(self): |
2300 | 1348 | interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 1348 | interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
2301 | @@ -1350,14 +1350,14 @@ class InterfaceTest(MAASServerTestCase): | |||
2302 | 1350 | interface.link_speed = 1000 | 1350 | interface.link_speed = 1000 |
2303 | 1351 | interface.save() | 1351 | interface.save() |
2304 | 1352 | interface = reload_object(interface) | 1352 | interface = reload_object(interface) |
2307 | 1353 | self.assertEquals(0, interface.interface_speed) | 1353 | self.assertEqual(0, interface.interface_speed) |
2308 | 1354 | self.assertEquals(1000, interface.link_speed) | 1354 | self.assertEqual(1000, interface.link_speed) |
2309 | 1355 | 1355 | ||
2310 | 1356 | def test_save_if_link_disconnected_set_link_speed_to_zero(self): | 1356 | def test_save_if_link_disconnected_set_link_speed_to_zero(self): |
2311 | 1357 | interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 1357 | interface = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
2312 | 1358 | interface.link_connected = False | 1358 | interface.link_connected = False |
2313 | 1359 | interface.save() | 1359 | interface.save() |
2315 | 1360 | self.assertEquals(0, interface.link_speed) | 1360 | self.assertEqual(0, interface.link_speed) |
2316 | 1361 | 1361 | ||
2317 | 1362 | 1362 | ||
2318 | 1363 | class InterfaceUpdateNeighbourTest(MAASServerTestCase): | 1363 | class InterfaceUpdateNeighbourTest(MAASServerTestCase): |
2319 | @@ -1771,7 +1771,7 @@ class InterfaceMTUTest(MAASServerTestCase): | |||
2320 | 1771 | ), | 1771 | ), |
2321 | 1772 | ), | 1772 | ), |
2322 | 1773 | ) | 1773 | ) |
2324 | 1774 | self.assertEquals([parent.id], [p.id for p in bridge.parents.all()]) | 1774 | self.assertEqual([parent.id], [p.id for p in bridge.parents.all()]) |
2325 | 1775 | 1775 | ||
2326 | 1776 | 1776 | ||
2327 | 1777 | class VLANInterfaceTest(MAASServerTestCase): | 1777 | class VLANInterfaceTest(MAASServerTestCase): |
2328 | @@ -3649,13 +3649,13 @@ class TestClaimAutoIPs(MAASTransactionServerTestCase): | |||
2329 | 3649 | ) | 3649 | ) |
2330 | 3650 | with transaction.atomic(): | 3650 | with transaction.atomic(): |
2331 | 3651 | observed = interface.claim_auto_ips() | 3651 | observed = interface.claim_auto_ips() |
2333 | 3652 | self.assertEquals( | 3652 | self.assertEqual( |
2334 | 3653 | 1, | 3653 | 1, |
2335 | 3654 | len(observed), | 3654 | len(observed), |
2336 | 3655 | "Should have 1 AUTO IP addresses with an IP address assigned.", | 3655 | "Should have 1 AUTO IP addresses with an IP address assigned.", |
2337 | 3656 | ) | 3656 | ) |
2340 | 3657 | self.assertEquals(subnet, observed[0].subnet) | 3657 | self.assertEqual(subnet, observed[0].subnet) |
2341 | 3658 | self.assertEquals( | 3658 | self.assertEqual( |
2342 | 3659 | IPAddress(network.first + 2), IPAddress(observed[0].ip) | 3659 | IPAddress(network.first + 2), IPAddress(observed[0].ip) |
2343 | 3660 | ) | 3660 | ) |
2344 | 3661 | 3661 | ||
2345 | @@ -3790,7 +3790,7 @@ class TestCreateAcquiredBridge(MAASServerTestCase): | |||
2346 | 3790 | ), | 3790 | ), |
2347 | 3791 | ), | 3791 | ), |
2348 | 3792 | ) | 3792 | ) |
2350 | 3793 | self.assertEquals([parent.id], [p.id for p in bridge.parents.all()]) | 3793 | self.assertEqual([parent.id], [p.id for p in bridge.parents.all()]) |
2351 | 3794 | 3794 | ||
2352 | 3795 | def test_creates_acquired_bridge_with_passed_options(self): | 3795 | def test_creates_acquired_bridge_with_passed_options(self): |
2353 | 3796 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 3796 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
2354 | @@ -3818,7 +3818,7 @@ class TestCreateAcquiredBridge(MAASServerTestCase): | |||
2355 | 3818 | ), | 3818 | ), |
2356 | 3819 | ), | 3819 | ), |
2357 | 3820 | ) | 3820 | ) |
2359 | 3821 | self.assertEquals([parent.id], [p.id for p in bridge.parents.all()]) | 3821 | self.assertEqual([parent.id], [p.id for p in bridge.parents.all()]) |
2360 | 3822 | 3822 | ||
2361 | 3823 | def test_creates_acquired_bridge_moves_links_from_parent_to_bridge(self): | 3823 | def test_creates_acquired_bridge_moves_links_from_parent_to_bridge(self): |
2362 | 3824 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) | 3824 | parent = factory.make_Interface(INTERFACE_TYPE.PHYSICAL) |
2363 | @@ -3847,11 +3847,11 @@ class TestCreateAcquiredBridge(MAASServerTestCase): | |||
2364 | 3847 | ), | 3847 | ), |
2365 | 3848 | ), | 3848 | ), |
2366 | 3849 | ) | 3849 | ) |
2369 | 3850 | self.assertEquals([parent.id], [p.id for p in bridge.parents.all()]) | 3850 | self.assertEqual([parent.id], [p.id for p in bridge.parents.all()]) |
2370 | 3851 | self.assertEquals( | 3851 | self.assertEqual( |
2371 | 3852 | [bridge.id], [nic.id for nic in auto_ip.interface_set.all()] | 3852 | [bridge.id], [nic.id for nic in auto_ip.interface_set.all()] |
2372 | 3853 | ) | 3853 | ) |
2374 | 3854 | self.assertEquals( | 3854 | self.assertEqual( |
2375 | 3855 | [bridge.id], [nic.id for nic in static_ip.interface_set.all()] | 3855 | [bridge.id], [nic.id for nic in static_ip.interface_set.all()] |
2376 | 3856 | ) | 3856 | ) |
2377 | 3857 | 3857 | ||
2378 | diff --git a/src/maasserver/models/tests/test_iscsiblockdevice.py b/src/maasserver/models/tests/test_iscsiblockdevice.py | |||
2379 | index 8f6335d..442dace 100644 | |||
2380 | --- a/src/maasserver/models/tests/test_iscsiblockdevice.py | |||
2381 | +++ b/src/maasserver/models/tests/test_iscsiblockdevice.py | |||
2382 | @@ -85,4 +85,4 @@ class TestISCSIBlockDevice(MAASServerTestCase): | |||
2383 | 85 | block_size=512, | 85 | block_size=512, |
2384 | 86 | target=target, | 86 | target=target, |
2385 | 87 | ) | 87 | ) |
2387 | 88 | self.assertEquals("iscsi:%s" % target, block_device.target) | 88 | self.assertEqual("iscsi:%s" % target, block_device.target) |
2388 | diff --git a/src/maasserver/models/tests/test_node.py b/src/maasserver/models/tests/test_node.py | |||
2389 | index 3c21d98..20b5dee 100644 | |||
2390 | --- a/src/maasserver/models/tests/test_node.py | |||
2391 | +++ b/src/maasserver/models/tests/test_node.py | |||
2392 | @@ -676,7 +676,7 @@ class TestRackControllerManager(MAASServerTestCase): | |||
2393 | 676 | ip = random.choice(["127.0.0.1", "::1"]) | 676 | ip = random.choice(["127.0.0.1", "::1"]) |
2394 | 677 | mock_getaddr_info.return_value = (("", "", "", "", (ip,)),) | 677 | mock_getaddr_info.return_value = (("", "", "", "", (ip,)),) |
2395 | 678 | self.useFixture(MAASIDFixture(rack.system_id)) | 678 | self.useFixture(MAASIDFixture(rack.system_id)) |
2397 | 679 | self.assertEquals( | 679 | self.assertEqual( |
2398 | 680 | [rack], RackController.objects.filter_by_url_accessible(ip, False) | 680 | [rack], RackController.objects.filter_by_url_accessible(ip, False) |
2399 | 681 | ) | 681 | ) |
2400 | 682 | 682 | ||
2401 | @@ -724,7 +724,7 @@ class TestRackControllerManager(MAASServerTestCase): | |||
2402 | 724 | url = factory.pick_ip_in_Subnet(accessible_subnet) | 724 | url = factory.pick_ip_in_Subnet(accessible_subnet) |
2403 | 725 | mock_getaddr_info = self.patch(node_module.socket, "getaddrinfo") | 725 | mock_getaddr_info = self.patch(node_module.socket, "getaddrinfo") |
2404 | 726 | mock_getaddr_info.return_value = (("", "", "", "", (url,)),) | 726 | mock_getaddr_info.return_value = (("", "", "", "", (url,)),) |
2406 | 727 | self.assertEquals( | 727 | self.assertEqual( |
2407 | 728 | None, RackController.objects.get_accessible_by_url(url, False) | 728 | None, RackController.objects.get_accessible_by_url(url, False) |
2408 | 729 | ) | 729 | ) |
2409 | 730 | 730 | ||
2410 | @@ -769,7 +769,7 @@ class TestRegionControllerManager(MAASServerTestCase): | |||
2411 | 769 | config_uuid = Config.objects.get_config("uuid") | 769 | config_uuid = Config.objects.get_config("uuid") |
2412 | 770 | self.assertThat(region_running, IsInstance(RegionController)) | 770 | self.assertThat(region_running, IsInstance(RegionController)) |
2413 | 771 | self.assertThat(region_running, Equals(region)) | 771 | self.assertThat(region_running, Equals(region)) |
2415 | 772 | self.assertEquals(created_uuid, config_uuid) | 772 | self.assertEqual(created_uuid, config_uuid) |
2416 | 773 | 773 | ||
2417 | 774 | def test_get_or_create_uuid_returns_stored_uuid(self): | 774 | def test_get_or_create_uuid_returns_stored_uuid(self): |
2418 | 775 | region = factory.make_RegionController() | 775 | region = factory.make_RegionController() |
2419 | @@ -783,8 +783,8 @@ class TestRegionControllerManager(MAASServerTestCase): | |||
2420 | 783 | stored_uuid = RegionController.objects.get_or_create_uuid() | 783 | stored_uuid = RegionController.objects.get_or_create_uuid() |
2421 | 784 | self.assertThat(region_running, IsInstance(RegionController)) | 784 | self.assertThat(region_running, IsInstance(RegionController)) |
2422 | 785 | self.assertThat(region_running, Equals(region)) | 785 | self.assertThat(region_running, Equals(region)) |
2425 | 786 | self.assertEquals(stored_uuid, config_uuid) | 786 | self.assertEqual(stored_uuid, config_uuid) |
2426 | 787 | self.assertEquals(created_uuid, stored_uuid) | 787 | self.assertEqual(created_uuid, stored_uuid) |
2427 | 788 | 788 | ||
2428 | 789 | 789 | ||
2429 | 790 | class TestRegionControllerManagerGetOrCreateRunningController( | 790 | class TestRegionControllerManagerGetOrCreateRunningController( |
2430 | @@ -930,7 +930,7 @@ class TestRegionControllerManagerGetOrCreateRunningController( | |||
2431 | 930 | 930 | ||
2432 | 931 | def assertControllerCreated(self, region): | 931 | def assertControllerCreated(self, region): |
2433 | 932 | # A controller is created and it is always a region controller. | 932 | # A controller is created and it is always a region controller. |
2435 | 933 | self.assertEquals(NODE_TYPE.REGION_CONTROLLER, region.node_type) | 933 | self.assertEqual(NODE_TYPE.REGION_CONTROLLER, region.node_type) |
2436 | 934 | # It's a fresh controller so the worker user is always owner. | 934 | # It's a fresh controller so the worker user is always owner. |
2437 | 935 | self.assertThat(region.owner, Equals(get_worker_user())) | 935 | self.assertThat(region.owner, Equals(get_worker_user())) |
2438 | 936 | 936 | ||
2439 | @@ -955,7 +955,7 @@ class TestRegionControllerManagerGetOrCreateRunningController( | |||
2440 | 955 | 955 | ||
2441 | 956 | def assertControllerNotDiscovered(self, region, host): | 956 | def assertControllerNotDiscovered(self, region, host): |
2442 | 957 | # A controller is created and it is always a region controller. | 957 | # A controller is created and it is always a region controller. |
2444 | 958 | self.assertEquals(NODE_TYPE.REGION_CONTROLLER, region.node_type) | 958 | self.assertEqual(NODE_TYPE.REGION_CONTROLLER, region.node_type) |
2445 | 959 | # It's new; the primary key differs from the host we planted. | 959 | # It's new; the primary key differs from the host we planted. |
2446 | 960 | self.assertThat(region.id, Not(Equals(host.id))) | 960 | self.assertThat(region.id, Not(Equals(host.id))) |
2447 | 961 | # It's a fresh controller so the worker user is always owner. | 961 | # It's a fresh controller so the worker user is always owner. |
2448 | @@ -3570,8 +3570,8 @@ class TestNode(MAASServerTestCase): | |||
2449 | 3570 | user=admin, | 3570 | user=admin, |
2450 | 3571 | commissioning_scripts=[script.name], | 3571 | commissioning_scripts=[script.name], |
2451 | 3572 | ) | 3572 | ) |
2454 | 3573 | self.assertEquals(0, ScriptSet.objects.count()) | 3573 | self.assertEqual(0, ScriptSet.objects.count()) |
2455 | 3574 | self.assertEquals(0, ScriptResult.objects.count()) | 3574 | self.assertEqual(0, ScriptResult.objects.count()) |
2456 | 3575 | 3575 | ||
2457 | 3576 | def test_start_commissioning_fails_on_xenial_with_network_testing_t(self): | 3576 | def test_start_commissioning_fails_on_xenial_with_network_testing_t(self): |
2458 | 3577 | Config.objects.set_config("commissioning_distro_series", "xenial") | 3577 | Config.objects.set_config("commissioning_distro_series", "xenial") |
2459 | @@ -3586,8 +3586,8 @@ class TestNode(MAASServerTestCase): | |||
2460 | 3586 | user=admin, | 3586 | user=admin, |
2461 | 3587 | testing_scripts=[script.name], | 3587 | testing_scripts=[script.name], |
2462 | 3588 | ) | 3588 | ) |
2465 | 3589 | self.assertEquals(0, ScriptSet.objects.count()) | 3589 | self.assertEqual(0, ScriptSet.objects.count()) |
2466 | 3590 | self.assertEquals(0, ScriptResult.objects.count()) | 3590 | self.assertEqual(0, ScriptResult.objects.count()) |
2467 | 3591 | 3591 | ||
2468 | 3592 | def test_abort_commissioning_reverts_to_sane_state_on_error(self): | 3592 | def test_abort_commissioning_reverts_to_sane_state_on_error(self): |
2469 | 3593 | # If abort commissioning hits an error when trying to stop the | 3593 | # If abort commissioning hits an error when trying to stop the |
2470 | @@ -3830,7 +3830,7 @@ class TestNode(MAASServerTestCase): | |||
2471 | 3830 | node.start_testing(admin, testing_scripts=[script.name]) | 3830 | node.start_testing(admin, testing_scripts=[script.name]) |
2472 | 3831 | post_commit_hooks.reset() # Ignore these for now. | 3831 | post_commit_hooks.reset() # Ignore these for now. |
2473 | 3832 | node = reload_object(node) | 3832 | node = reload_object(node) |
2475 | 3833 | self.assertEquals(NODE_STATUS.TESTING, node.status) | 3833 | self.assertEqual(NODE_STATUS.TESTING, node.status) |
2476 | 3834 | self.assertThat(mock_node_start, MockCalledOnce()) | 3834 | self.assertThat(mock_node_start, MockCalledOnce()) |
2477 | 3835 | 3835 | ||
2478 | 3836 | def test_start_testing_changes_status_and_starts_new_node(self): | 3836 | def test_start_testing_changes_status_and_starts_new_node(self): |
2479 | @@ -3850,7 +3850,7 @@ class TestNode(MAASServerTestCase): | |||
2480 | 3850 | node.start_testing(admin, testing_scripts=[script.name]) | 3850 | node.start_testing(admin, testing_scripts=[script.name]) |
2481 | 3851 | post_commit_hooks.reset() # Ignore these for now. | 3851 | post_commit_hooks.reset() # Ignore these for now. |
2482 | 3852 | node = reload_object(node) | 3852 | node = reload_object(node) |
2484 | 3853 | self.assertEquals(NODE_STATUS.TESTING, node.status) | 3853 | self.assertEqual(NODE_STATUS.TESTING, node.status) |
2485 | 3854 | self.assertThat(mock_node_start, MockCalledOnce()) | 3854 | self.assertThat(mock_node_start, MockCalledOnce()) |
2486 | 3855 | 3855 | ||
2487 | 3856 | def test_start_testing_sets_options(self): | 3856 | def test_start_testing_sets_options(self): |
2488 | @@ -3870,7 +3870,7 @@ class TestNode(MAASServerTestCase): | |||
2489 | 3870 | ) | 3870 | ) |
2490 | 3871 | post_commit_hooks.reset() # Ignore these for now. | 3871 | post_commit_hooks.reset() # Ignore these for now. |
2491 | 3872 | node = reload_object(node) | 3872 | node = reload_object(node) |
2493 | 3873 | self.assertEquals(enable_ssh, node.enable_ssh) | 3873 | self.assertEqual(enable_ssh, node.enable_ssh) |
2494 | 3874 | 3874 | ||
2495 | 3875 | def test_start_testing_sets_user_data(self): | 3875 | def test_start_testing_sets_user_data(self): |
2496 | 3876 | script = factory.make_Script(script_type=SCRIPT_TYPE.TESTING) | 3876 | script = factory.make_Script(script_type=SCRIPT_TYPE.TESTING) |
2497 | @@ -4065,8 +4065,8 @@ class TestNode(MAASServerTestCase): | |||
2498 | 4065 | admin, | 4065 | admin, |
2499 | 4066 | testing_scripts=[script.name], | 4066 | testing_scripts=[script.name], |
2500 | 4067 | ) | 4067 | ) |
2503 | 4068 | self.assertEquals(0, ScriptSet.objects.count()) | 4068 | self.assertEqual(0, ScriptSet.objects.count()) |
2504 | 4069 | self.assertEquals(0, ScriptResult.objects.count()) | 4069 | self.assertEqual(0, ScriptResult.objects.count()) |
2505 | 4070 | 4070 | ||
2506 | 4071 | def test_save_logs_node_status_transition(self): | 4071 | def test_save_logs_node_status_transition(self): |
2507 | 4072 | self.disable_node_query() | 4072 | self.disable_node_query() |
2508 | @@ -4257,11 +4257,11 @@ class TestNode(MAASServerTestCase): | |||
2509 | 4257 | node.mark_failed(script_result_status=script_result_status) | 4257 | node.mark_failed(script_result_status=script_result_status) |
2510 | 4258 | 4258 | ||
2511 | 4259 | for script_result in updated_script_results: | 4259 | for script_result in updated_script_results: |
2513 | 4260 | self.assertEquals( | 4260 | self.assertEqual( |
2514 | 4261 | script_result_status, reload_object(script_result).status | 4261 | script_result_status, reload_object(script_result).status |
2515 | 4262 | ) | 4262 | ) |
2516 | 4263 | for script_result in untouched_script_results: | 4263 | for script_result in untouched_script_results: |
2518 | 4264 | self.assertEquals( | 4264 | self.assertEqual( |
2519 | 4265 | script_result.status, reload_object(script_result).status | 4265 | script_result.status, reload_object(script_result).status |
2520 | 4266 | ) | 4266 | ) |
2521 | 4267 | 4267 | ||
2522 | @@ -8523,7 +8523,7 @@ class TestNode_Start(MAASTransactionServerTestCase): | |||
2523 | 8523 | user, power_type="manual" | 8523 | user, power_type="manual" |
2524 | 8524 | ) | 8524 | ) |
2525 | 8525 | node.start(user) | 8525 | node.start(user) |
2527 | 8526 | self.assertEquals(NODE_STATUS.DEPLOYING, node.status) | 8526 | self.assertEqual(NODE_STATUS.DEPLOYING, node.status) |
2528 | 8527 | 8527 | ||
2529 | 8528 | def test_creates_acquired_bridges_for_install_kvm(self): | 8528 | def test_creates_acquired_bridges_for_install_kvm(self): |
2530 | 8529 | user = factory.make_User() | 8529 | user = factory.make_User() |
2531 | @@ -8543,11 +8543,11 @@ class TestNode_Start(MAASTransactionServerTestCase): | |||
2532 | 8543 | node = reload_object(node) | 8543 | node = reload_object(node) |
2533 | 8544 | bridge = BridgeInterface.objects.get(node=node) | 8544 | bridge = BridgeInterface.objects.get(node=node) |
2534 | 8545 | interface = node.interface_set.first() | 8545 | interface = node.interface_set.first() |
2540 | 8546 | self.assertEquals(NODE_STATUS.DEPLOYING, node.status) | 8546 | self.assertEqual(NODE_STATUS.DEPLOYING, node.status) |
2541 | 8547 | self.assertEquals(bridge.mac_address, interface.mac_address) | 8547 | self.assertEqual(bridge.mac_address, interface.mac_address) |
2542 | 8548 | self.assertEquals(bridge.params["bridge_type"], bridge_type) | 8548 | self.assertEqual(bridge.params["bridge_type"], bridge_type) |
2543 | 8549 | self.assertEquals(bridge.params["bridge_stp"], bridge_stp) | 8549 | self.assertEqual(bridge.params["bridge_stp"], bridge_stp) |
2544 | 8550 | self.assertEquals(bridge.params["bridge_fd"], bridge_fd) | 8550 | self.assertEqual(bridge.params["bridge_fd"], bridge_fd) |
2545 | 8551 | self.assertTrue(node.install_kvm) | 8551 | self.assertTrue(node.install_kvm) |
2546 | 8552 | 8552 | ||
2547 | 8553 | def test_doesnt_change_broken(self): | 8553 | def test_doesnt_change_broken(self): |
2548 | @@ -8558,7 +8558,7 @@ class TestNode_Start(MAASTransactionServerTestCase): | |||
2549 | 8558 | node.status = NODE_STATUS.BROKEN | 8558 | node.status = NODE_STATUS.BROKEN |
2550 | 8559 | node.save() | 8559 | node.save() |
2551 | 8560 | node.start(user) | 8560 | node.start(user) |
2553 | 8561 | self.assertEquals(NODE_STATUS.BROKEN, node.status) | 8561 | self.assertEqual(NODE_STATUS.BROKEN, node.status) |
2554 | 8562 | 8562 | ||
2555 | 8563 | def test_claims_auto_ip_addresses(self): | 8563 | def test_claims_auto_ip_addresses(self): |
2556 | 8564 | user = factory.make_User() | 8564 | user = factory.make_User() |
2557 | @@ -9136,14 +9136,14 @@ class TestNode_Start(MAASTransactionServerTestCase): | |||
2558 | 9136 | name=EVENT_TYPES.NODE_POWER_QUERY_FAILED | 9136 | name=EVENT_TYPES.NODE_POWER_QUERY_FAILED |
2559 | 9137 | ) | 9137 | ) |
2560 | 9138 | event = node.event_set.get(type=event_type) | 9138 | event = node.event_set.get(type=event_type) |
2562 | 9139 | self.assertEquals( | 9139 | self.assertEqual( |
2563 | 9140 | "(%s) - Aborting NEW and reverting to NEW. Unable to power " | 9140 | "(%s) - Aborting NEW and reverting to NEW. Unable to power " |
2564 | 9141 | "control the node. Please check power credentials." % user, | 9141 | "control the node. Please check power credentials." % user, |
2565 | 9142 | event.description, | 9142 | event.description, |
2566 | 9143 | ) | 9143 | ) |
2567 | 9144 | 9144 | ||
2568 | 9145 | for script_result in script_results: | 9145 | for script_result in script_results: |
2570 | 9146 | self.assertEquals( | 9146 | self.assertEqual( |
2571 | 9147 | SCRIPT_STATUS.ABORTED, reload_object(script_result).status | 9147 | SCRIPT_STATUS.ABORTED, reload_object(script_result).status |
2572 | 9148 | ) | 9148 | ) |
2573 | 9149 | 9149 | ||
2574 | @@ -9220,7 +9220,7 @@ class TestGetBMCClientConnectionInfo(MAASServerTestCase): | |||
2575 | 9220 | fallback.system_id = fake_fallback_id | 9220 | fallback.system_id = fake_fallback_id |
2576 | 9221 | mock_fallbacks.return_value = [fallback] | 9221 | mock_fallbacks.return_value = [fallback] |
2577 | 9222 | 9222 | ||
2579 | 9223 | self.assertEquals( | 9223 | self.assertEqual( |
2580 | 9224 | ([fake_bmc_id], [fake_fallback_id]), | 9224 | ([fake_bmc_id], [fake_fallback_id]), |
2581 | 9225 | node._get_bmc_client_connection_info(), | 9225 | node._get_bmc_client_connection_info(), |
2582 | 9226 | ) | 9226 | ) |
2583 | @@ -9233,7 +9233,7 @@ class TestGetBMCClientConnectionInfo(MAASServerTestCase): | |||
2584 | 9233 | name=EVENT_TYPES.NODE_POWER_QUERY_FAILED | 9233 | name=EVENT_TYPES.NODE_POWER_QUERY_FAILED |
2585 | 9234 | ) | 9234 | ) |
2586 | 9235 | event = node.event_set.get(type=event_type) | 9235 | event = node.event_set.get(type=event_type) |
2588 | 9236 | self.assertEquals( | 9236 | self.assertEqual( |
2589 | 9237 | ( | 9237 | ( |
2590 | 9238 | "No rack controllers can access the BMC of node %s" | 9238 | "No rack controllers can access the BMC of node %s" |
2591 | 9239 | % node.hostname | 9239 | % node.hostname |
2592 | @@ -13807,7 +13807,7 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2593 | 13807 | ) | 13807 | ) |
2594 | 13808 | system_id = region_and_rack.system_id | 13808 | system_id = region_and_rack.system_id |
2595 | 13809 | region_and_rack.as_rack_controller().delete() | 13809 | region_and_rack.as_rack_controller().delete() |
2597 | 13810 | self.assertEquals( | 13810 | self.assertEqual( |
2598 | 13811 | NODE_TYPE.REGION_CONTROLLER, | 13811 | NODE_TYPE.REGION_CONTROLLER, |
2599 | 13812 | Node.objects.get(system_id=system_id).node_type, | 13812 | Node.objects.get(system_id=system_id).node_type, |
2600 | 13813 | ) | 13813 | ) |
2601 | @@ -13817,7 +13817,7 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2602 | 13817 | rack.bmc = factory.make_BMC() | 13817 | rack.bmc = factory.make_BMC() |
2603 | 13818 | rack.save() | 13818 | rack.save() |
2604 | 13819 | rack.delete() | 13819 | rack.delete() |
2606 | 13820 | self.assertEquals( | 13820 | self.assertEqual( |
2607 | 13821 | NODE_TYPE.MACHINE, | 13821 | NODE_TYPE.MACHINE, |
2608 | 13822 | Node.objects.get(system_id=rack.system_id).node_type, | 13822 | Node.objects.get(system_id=rack.system_id).node_type, |
2609 | 13823 | ) | 13823 | ) |
2610 | @@ -13927,16 +13927,16 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2611 | 13927 | images = rack_controller.list_boot_images() | 13927 | images = rack_controller.list_boot_images() |
2612 | 13928 | self.assertTrue(images["connected"]) | 13928 | self.assertTrue(images["connected"]) |
2613 | 13929 | self.assertItemsEqual(self.expected_images, images["images"]) | 13929 | self.assertItemsEqual(self.expected_images, images["images"]) |
2616 | 13930 | self.assertEquals("synced", images["status"]) | 13930 | self.assertEqual("synced", images["status"]) |
2617 | 13931 | self.assertEquals("synced", rack_controller.get_image_sync_status()) | 13931 | self.assertEqual("synced", rack_controller.get_image_sync_status()) |
2618 | 13932 | 13932 | ||
2619 | 13933 | def test_list_boot_images_when_disconnected(self): | 13933 | def test_list_boot_images_when_disconnected(self): |
2620 | 13934 | rack_controller = factory.make_RackController() | 13934 | rack_controller = factory.make_RackController() |
2621 | 13935 | images = rack_controller.list_boot_images() | 13935 | images = rack_controller.list_boot_images() |
2623 | 13936 | self.assertEquals(False, images["connected"]) | 13936 | self.assertEqual(False, images["connected"]) |
2624 | 13937 | self.assertItemsEqual([], images["images"]) | 13937 | self.assertItemsEqual([], images["images"]) |
2627 | 13938 | self.assertEquals("unknown", images["status"]) | 13938 | self.assertEqual("unknown", images["status"]) |
2628 | 13939 | self.assertEquals("unknown", rack_controller.get_image_sync_status()) | 13939 | self.assertEqual("unknown", rack_controller.get_image_sync_status()) |
2629 | 13940 | 13940 | ||
2630 | 13941 | def test_list_boot_images_when_connection_closed(self): | 13941 | def test_list_boot_images_when_connection_closed(self): |
2631 | 13942 | rack_controller = factory.make_RackController() | 13942 | rack_controller = factory.make_RackController() |
2632 | @@ -13944,10 +13944,10 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2633 | 13944 | boot_images, "get_boot_images" | 13944 | boot_images, "get_boot_images" |
2634 | 13945 | ).side_effect = ConnectionClosed() | 13945 | ).side_effect = ConnectionClosed() |
2635 | 13946 | images = rack_controller.list_boot_images() | 13946 | images = rack_controller.list_boot_images() |
2637 | 13947 | self.assertEquals(False, images["connected"]) | 13947 | self.assertEqual(False, images["connected"]) |
2638 | 13948 | self.assertItemsEqual([], images["images"]) | 13948 | self.assertItemsEqual([], images["images"]) |
2641 | 13949 | self.assertEquals("unknown", images["status"]) | 13949 | self.assertEqual("unknown", images["status"]) |
2642 | 13950 | self.assertEquals("unknown", rack_controller.get_image_sync_status()) | 13950 | self.assertEqual("unknown", rack_controller.get_image_sync_status()) |
2643 | 13951 | 13951 | ||
2644 | 13952 | def test_list_boot_images_region_importing(self): | 13952 | def test_list_boot_images_region_importing(self): |
2645 | 13953 | rack_controller = factory.make_RackController() | 13953 | rack_controller = factory.make_RackController() |
2646 | @@ -13962,8 +13962,8 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2647 | 13962 | self.assertThat(fake_is_import_resources_running, MockCalledOnce()) | 13962 | self.assertThat(fake_is_import_resources_running, MockCalledOnce()) |
2648 | 13963 | self.assertTrue(images["connected"]) | 13963 | self.assertTrue(images["connected"]) |
2649 | 13964 | self.assertItemsEqual(self.expected_images, images["images"]) | 13964 | self.assertItemsEqual(self.expected_images, images["images"]) |
2652 | 13965 | self.assertEquals("region-importing", images["status"]) | 13965 | self.assertEqual("region-importing", images["status"]) |
2653 | 13966 | self.assertEquals( | 13966 | self.assertEqual( |
2654 | 13967 | "region-importing", rack_controller.get_image_sync_status() | 13967 | "region-importing", rack_controller.get_image_sync_status() |
2655 | 13968 | ) | 13968 | ) |
2656 | 13969 | 13969 | ||
2657 | @@ -13981,8 +13981,8 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2658 | 13981 | images = rack_controller.list_boot_images() | 13981 | images = rack_controller.list_boot_images() |
2659 | 13982 | self.assertTrue(images["connected"]) | 13982 | self.assertTrue(images["connected"]) |
2660 | 13983 | self.assertItemsEqual(self.expected_images, images["images"]) | 13983 | self.assertItemsEqual(self.expected_images, images["images"]) |
2663 | 13984 | self.assertEquals("syncing", images["status"]) | 13984 | self.assertEqual("syncing", images["status"]) |
2664 | 13985 | self.assertEquals("syncing", rack_controller.get_image_sync_status()) | 13985 | self.assertEqual("syncing", rack_controller.get_image_sync_status()) |
2665 | 13986 | 13986 | ||
2666 | 13987 | def test_list_boot_images_out_of_sync(self): | 13987 | def test_list_boot_images_out_of_sync(self): |
2667 | 13988 | rack_controller = factory.make_RackController() | 13988 | rack_controller = factory.make_RackController() |
2668 | @@ -13998,8 +13998,8 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2669 | 13998 | images = rack_controller.list_boot_images() | 13998 | images = rack_controller.list_boot_images() |
2670 | 13999 | self.assertTrue(images["connected"]) | 13999 | self.assertTrue(images["connected"]) |
2671 | 14000 | self.assertItemsEqual(self.expected_images, images["images"]) | 14000 | self.assertItemsEqual(self.expected_images, images["images"]) |
2674 | 14001 | self.assertEquals("out-of-sync", images["status"]) | 14001 | self.assertEqual("out-of-sync", images["status"]) |
2675 | 14002 | self.assertEquals( | 14002 | self.assertEqual( |
2676 | 14003 | "out-of-sync", rack_controller.get_image_sync_status() | 14003 | "out-of-sync", rack_controller.get_image_sync_status() |
2677 | 14004 | ) | 14004 | ) |
2678 | 14005 | 14005 | ||
2679 | @@ -14015,7 +14015,7 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2680 | 14015 | images = rack_controller.list_boot_images() | 14015 | images = rack_controller.list_boot_images() |
2681 | 14016 | self.assertTrue(images["connected"]) | 14016 | self.assertTrue(images["connected"]) |
2682 | 14017 | self.assertItemsEqual([], images["images"]) | 14017 | self.assertItemsEqual([], images["images"]) |
2684 | 14018 | self.assertEquals("syncing", images["status"]) | 14018 | self.assertEqual("syncing", images["status"]) |
2685 | 14019 | 14019 | ||
2686 | 14020 | def test_is_import_images_running(self): | 14020 | def test_is_import_images_running(self): |
2687 | 14021 | running = factory.pick_bool() | 14021 | running = factory.pick_bool() |
2688 | @@ -14029,7 +14029,7 @@ class TestRackController(MAASTransactionServerTestCase): | |||
2689 | 14029 | protocol.IsImportBootImagesRunning.return_value = defer.succeed( | 14029 | protocol.IsImportBootImagesRunning.return_value = defer.succeed( |
2690 | 14030 | {"running": running} | 14030 | {"running": running} |
2691 | 14031 | ) | 14031 | ) |
2693 | 14032 | self.assertEquals( | 14032 | self.assertEqual( |
2694 | 14033 | running, rackcontroller.is_import_boot_images_running() | 14033 | running, rackcontroller.is_import_boot_images_running() |
2695 | 14034 | ) | 14034 | ) |
2696 | 14035 | 14035 | ||
2697 | @@ -14045,7 +14045,7 @@ class TestRegionController(MAASServerTestCase): | |||
2698 | 14045 | node_type=NODE_TYPE.REGION_AND_RACK_CONTROLLER | 14045 | node_type=NODE_TYPE.REGION_AND_RACK_CONTROLLER |
2699 | 14046 | ) | 14046 | ) |
2700 | 14047 | region_and_rack.as_region_controller().delete() | 14047 | region_and_rack.as_region_controller().delete() |
2702 | 14048 | self.assertEquals( | 14048 | self.assertEqual( |
2703 | 14049 | NODE_TYPE.RACK_CONTROLLER, | 14049 | NODE_TYPE.RACK_CONTROLLER, |
2704 | 14050 | Node.objects.get(system_id=region_and_rack.system_id).node_type, | 14050 | Node.objects.get(system_id=region_and_rack.system_id).node_type, |
2705 | 14051 | ) | 14051 | ) |
2706 | @@ -14055,7 +14055,7 @@ class TestRegionController(MAASServerTestCase): | |||
2707 | 14055 | region.bmc = factory.make_BMC() | 14055 | region.bmc = factory.make_BMC() |
2708 | 14056 | region.save() | 14056 | region.save() |
2709 | 14057 | region.delete() | 14057 | region.delete() |
2711 | 14058 | self.assertEquals( | 14058 | self.assertEqual( |
2712 | 14059 | NODE_TYPE.MACHINE, | 14059 | NODE_TYPE.MACHINE, |
2713 | 14060 | Node.objects.get(system_id=region.system_id).node_type, | 14060 | Node.objects.get(system_id=region.system_id).node_type, |
2714 | 14061 | ) | 14061 | ) |
2715 | @@ -15021,7 +15021,7 @@ class TestNodeInterfaceClone__MappingBetweenNodes(MAASServerTestCase): | |||
2716 | 15021 | error = self.assertRaises( | 15021 | error = self.assertRaises( |
2717 | 15022 | ValidationError, node2._get_interface_mapping_between_nodes, node1 | 15022 | ValidationError, node2._get_interface_mapping_between_nodes, node1 |
2718 | 15023 | ) | 15023 | ) |
2720 | 15024 | self.assertEquals( | 15024 | self.assertEqual( |
2721 | 15025 | "destination node physical interfaces do not match the " | 15025 | "destination node physical interfaces do not match the " |
2722 | 15026 | "source nodes physical interfaces: other, match", | 15026 | "source nodes physical interfaces: other, match", |
2723 | 15027 | error.message, | 15027 | error.message, |
2724 | diff --git a/src/maasserver/models/tests/test_ownerdata.py b/src/maasserver/models/tests/test_ownerdata.py | |||
2725 | index af3087e..0877e8a 100644 | |||
2726 | --- a/src/maasserver/models/tests/test_ownerdata.py | |||
2727 | +++ b/src/maasserver/models/tests/test_ownerdata.py | |||
2728 | @@ -23,7 +23,7 @@ class TestOwnerData(MAASServerTestCase): | |||
2729 | 23 | for _ in range(3) | 23 | for _ in range(3) |
2730 | 24 | } | 24 | } |
2731 | 25 | OwnerData.objects.set_owner_data(node, owner_data) | 25 | OwnerData.objects.set_owner_data(node, owner_data) |
2733 | 26 | self.assertEquals(owner_data, self.get_owner_data(node)) | 26 | self.assertEqual(owner_data, self.get_owner_data(node)) |
2734 | 27 | 27 | ||
2735 | 28 | def test_set_owner_data_updates_data(self): | 28 | def test_set_owner_data_updates_data(self): |
2736 | 29 | node = factory.make_Node() | 29 | node = factory.make_Node() |
2737 | @@ -35,7 +35,7 @@ class TestOwnerData(MAASServerTestCase): | |||
2738 | 35 | for key in owner_data.keys(): | 35 | for key in owner_data.keys(): |
2739 | 36 | owner_data[key] = factory.make_name("value") | 36 | owner_data[key] = factory.make_name("value") |
2740 | 37 | OwnerData.objects.set_owner_data(node, owner_data) | 37 | OwnerData.objects.set_owner_data(node, owner_data) |
2742 | 38 | self.assertEquals(owner_data, self.get_owner_data(node)) | 38 | self.assertEqual(owner_data, self.get_owner_data(node)) |
2743 | 39 | 39 | ||
2744 | 40 | def test_set_owner_data_removes_data(self): | 40 | def test_set_owner_data_removes_data(self): |
2745 | 41 | node = factory.make_Node() | 41 | node = factory.make_Node() |
2746 | @@ -47,4 +47,4 @@ class TestOwnerData(MAASServerTestCase): | |||
2747 | 47 | for key in owner_data.keys(): | 47 | for key in owner_data.keys(): |
2748 | 48 | owner_data[key] = None | 48 | owner_data[key] = None |
2749 | 49 | OwnerData.objects.set_owner_data(node, owner_data) | 49 | OwnerData.objects.set_owner_data(node, owner_data) |
2751 | 50 | self.assertEquals({}, self.get_owner_data(node)) | 50 | self.assertEqual({}, self.get_owner_data(node)) |
2752 | diff --git a/src/maasserver/models/tests/test_packagerepository.py b/src/maasserver/models/tests/test_packagerepository.py | |||
2753 | index 3758897..ffed1d1 100644 | |||
2754 | --- a/src/maasserver/models/tests/test_packagerepository.py | |||
2755 | +++ b/src/maasserver/models/tests/test_packagerepository.py | |||
2756 | @@ -20,7 +20,7 @@ class TestPackageRepositoryManager(MAASServerTestCase): | |||
2757 | 20 | archive = factory.make_PackageRepository( | 20 | archive = factory.make_PackageRepository( |
2758 | 21 | url=main_url, default=True, arches=["i386", "amd64"] | 21 | url=main_url, default=True, arches=["i386", "amd64"] |
2759 | 22 | ) | 22 | ) |
2761 | 23 | self.assertEquals( | 23 | self.assertEqual( |
2762 | 24 | archive, PackageRepository.objects.get_default_archive(arch) | 24 | archive, PackageRepository.objects.get_default_archive(arch) |
2763 | 25 | ) | 25 | ) |
2764 | 26 | 26 | ||
2765 | @@ -30,7 +30,7 @@ class TestPackageRepositoryManager(MAASServerTestCase): | |||
2766 | 30 | archive = factory.make_PackageRepository( | 30 | archive = factory.make_PackageRepository( |
2767 | 31 | url=main_url, default=False, arches=["i386", "amd64"] | 31 | url=main_url, default=False, arches=["i386", "amd64"] |
2768 | 32 | ) | 32 | ) |
2770 | 33 | self.assertEquals( | 33 | self.assertEqual( |
2771 | 34 | archive, | 34 | archive, |
2772 | 35 | PackageRepository.objects.get_additional_repositories( | 35 | PackageRepository.objects.get_additional_repositories( |
2773 | 36 | arch | 36 | arch |
2774 | @@ -68,13 +68,13 @@ class TestPackageRepositoryManager(MAASServerTestCase): | |||
2775 | 68 | archive = factory.make_PackageRepository( | 68 | archive = factory.make_PackageRepository( |
2776 | 69 | url=url, default=False, arches=[arch, factory.make_name()] | 69 | url=url, default=False, arches=[arch, factory.make_name()] |
2777 | 70 | ) | 70 | ) |
2779 | 71 | self.assertEquals( | 71 | self.assertEqual( |
2780 | 72 | ppa_archive, | 72 | ppa_archive, |
2781 | 73 | PackageRepository.objects.get_additional_repositories( | 73 | PackageRepository.objects.get_additional_repositories( |
2782 | 74 | ppa_arch | 74 | ppa_arch |
2783 | 75 | ).first(), | 75 | ).first(), |
2784 | 76 | ) | 76 | ) |
2786 | 77 | self.assertEquals( | 77 | self.assertEqual( |
2787 | 78 | archive, | 78 | archive, |
2788 | 79 | PackageRepository.objects.get_additional_repositories( | 79 | PackageRepository.objects.get_additional_repositories( |
2789 | 80 | arch | 80 | arch |
2790 | diff --git a/src/maasserver/models/tests/test_partitiontable.py b/src/maasserver/models/tests/test_partitiontable.py | |||
2791 | index 9544ed1..ae1b9c7 100644 | |||
2792 | --- a/src/maasserver/models/tests/test_partitiontable.py | |||
2793 | +++ b/src/maasserver/models/tests/test_partitiontable.py | |||
2794 | @@ -163,7 +163,7 @@ class TestPartitionTable(MAASServerTestCase): | |||
2795 | 163 | partition_table = factory.make_PartitionTable( | 163 | partition_table = factory.make_PartitionTable( |
2796 | 164 | block_device=block_device | 164 | block_device=block_device |
2797 | 165 | ) | 165 | ) |
2799 | 166 | self.assertEquals( | 166 | self.assertEqual( |
2800 | 167 | PARTITION_TABLE_EXTRA_SPACE, partition_table.get_overhead_size() | 167 | PARTITION_TABLE_EXTRA_SPACE, partition_table.get_overhead_size() |
2801 | 168 | ) | 168 | ) |
2802 | 169 | 169 | ||
2803 | @@ -173,7 +173,7 @@ class TestPartitionTable(MAASServerTestCase): | |||
2804 | 173 | partition_table = factory.make_PartitionTable( | 173 | partition_table = factory.make_PartitionTable( |
2805 | 174 | block_device=block_device | 174 | block_device=block_device |
2806 | 175 | ) | 175 | ) |
2808 | 176 | self.assertEquals( | 176 | self.assertEqual( |
2809 | 177 | PARTITION_TABLE_EXTRA_SPACE + PREP_PARTITION_SIZE, | 177 | PARTITION_TABLE_EXTRA_SPACE + PREP_PARTITION_SIZE, |
2810 | 178 | partition_table.get_overhead_size(), | 178 | partition_table.get_overhead_size(), |
2811 | 179 | ) | 179 | ) |
2812 | @@ -186,7 +186,7 @@ class TestPartitionTable(MAASServerTestCase): | |||
2813 | 186 | partition_table = factory.make_PartitionTable( | 186 | partition_table = factory.make_PartitionTable( |
2814 | 187 | block_device=block_device | 187 | block_device=block_device |
2815 | 188 | ) | 188 | ) |
2817 | 189 | self.assertEquals( | 189 | self.assertEqual( |
2818 | 190 | PARTITION_TABLE_EXTRA_SPACE + BIOS_GRUB_PARTITION_SIZE, | 190 | PARTITION_TABLE_EXTRA_SPACE + BIOS_GRUB_PARTITION_SIZE, |
2819 | 191 | partition_table.get_overhead_size(), | 191 | partition_table.get_overhead_size(), |
2820 | 192 | ) | 192 | ) |
2821 | diff --git a/src/maasserver/models/tests/test_podstoragepool.py b/src/maasserver/models/tests/test_podstoragepool.py | |||
2822 | index 2af4f68..bfc406b 100644 | |||
2823 | --- a/src/maasserver/models/tests/test_podstoragepool.py | |||
2824 | +++ b/src/maasserver/models/tests/test_podstoragepool.py | |||
2825 | @@ -15,8 +15,8 @@ class TestPodStoragePool(MAASServerTestCase): | |||
2826 | 15 | for _ in range(3): | 15 | for _ in range(3): |
2827 | 16 | bd = factory.make_PhysicalBlockDevice(storage_pool=pool) | 16 | bd = factory.make_PhysicalBlockDevice(storage_pool=pool) |
2828 | 17 | size += bd.size | 17 | size += bd.size |
2830 | 18 | self.assertEquals(size, pool.get_used_storage()) | 18 | self.assertEqual(size, pool.get_used_storage()) |
2831 | 19 | 19 | ||
2832 | 20 | def test_get_used_storage_returns_zero(self): | 20 | def test_get_used_storage_returns_zero(self): |
2833 | 21 | pool = factory.make_PodStoragePool() | 21 | pool = factory.make_PodStoragePool() |
2835 | 22 | self.assertEquals(0, pool.get_used_storage()) | 22 | self.assertEqual(0, pool.get_used_storage()) |
2836 | diff --git a/src/maasserver/models/tests/test_versionedtextfile.py b/src/maasserver/models/tests/test_versionedtextfile.py | |||
2837 | index e74e7ce..2e208ba 100644 | |||
2838 | --- a/src/maasserver/models/tests/test_versionedtextfile.py | |||
2839 | +++ b/src/maasserver/models/tests/test_versionedtextfile.py | |||
2840 | @@ -95,7 +95,7 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2841 | 95 | for _ in range(10): | 95 | for _ in range(10): |
2842 | 96 | textfile = textfile.update(factory.make_string()) | 96 | textfile = textfile.update(factory.make_string()) |
2843 | 97 | textfile_ids.append(textfile.id) | 97 | textfile_ids.append(textfile.id) |
2845 | 98 | self.assertEquals(textfile, textfile.revert(0)) | 98 | self.assertEqual(textfile, textfile.revert(0)) |
2846 | 99 | self.assertItemsEqual( | 99 | self.assertItemsEqual( |
2847 | 100 | textfile_ids, [f.id for f in textfile.previous_versions()] | 100 | textfile_ids, [f.id for f in textfile.previous_versions()] |
2848 | 101 | ) | 101 | ) |
2849 | @@ -110,7 +110,7 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2850 | 110 | revert_to = random.randint(-10, -1) | 110 | revert_to = random.randint(-10, -1) |
2851 | 111 | reverted_ids = textfile_ids[revert_to:] | 111 | reverted_ids = textfile_ids[revert_to:] |
2852 | 112 | remaining_ids = textfile_ids[:revert_to] | 112 | remaining_ids = textfile_ids[:revert_to] |
2854 | 113 | self.assertEquals( | 113 | self.assertEqual( |
2855 | 114 | textfile_ids[revert_to - 1], textfile.revert(revert_to).id | 114 | textfile_ids[revert_to - 1], textfile.revert(revert_to).id |
2856 | 115 | ) | 115 | ) |
2857 | 116 | for i in reverted_ids: | 116 | for i in reverted_ids: |
2858 | @@ -130,7 +130,7 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2859 | 130 | textfile = textfile.update(factory.make_string()) | 130 | textfile = textfile.update(factory.make_string()) |
2860 | 131 | textfile_ids.append(textfile.id) | 131 | textfile_ids.append(textfile.id) |
2861 | 132 | revert_to = random.randint(-10, -1) | 132 | revert_to = random.randint(-10, -1) |
2863 | 133 | self.assertEquals( | 133 | self.assertEqual( |
2864 | 134 | textfile_ids[revert_to - 1], textfile.revert(revert_to, False).id | 134 | textfile_ids[revert_to - 1], textfile.revert(revert_to, False).id |
2865 | 135 | ) | 135 | ) |
2866 | 136 | for i in textfile_ids: | 136 | for i in textfile_ids: |
2867 | @@ -160,7 +160,7 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2868 | 160 | reverted_or_remaining.append(i) | 160 | reverted_or_remaining.append(i) |
2869 | 161 | if i == revert_to: | 161 | if i == revert_to: |
2870 | 162 | reverted_or_remaining = reverted_ids | 162 | reverted_or_remaining = reverted_ids |
2872 | 163 | self.assertEquals( | 163 | self.assertEqual( |
2873 | 164 | VersionedTextFile.objects.get(id=revert_to), | 164 | VersionedTextFile.objects.get(id=revert_to), |
2874 | 165 | textfile.revert(revert_to), | 165 | textfile.revert(revert_to), |
2875 | 166 | ) | 166 | ) |
2876 | @@ -181,7 +181,7 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2877 | 181 | textfile = textfile.update(factory.make_string()) | 181 | textfile = textfile.update(factory.make_string()) |
2878 | 182 | textfile_ids.append(textfile.id) | 182 | textfile_ids.append(textfile.id) |
2879 | 183 | revert_to = random.choice(textfile_ids) | 183 | revert_to = random.choice(textfile_ids) |
2881 | 184 | self.assertEquals( | 184 | self.assertEqual( |
2882 | 185 | VersionedTextFile.objects.get(id=revert_to), | 185 | VersionedTextFile.objects.get(id=revert_to), |
2883 | 186 | textfile.revert(revert_to, False), | 186 | textfile.revert(revert_to, False), |
2884 | 187 | ) | 187 | ) |
2885 | @@ -232,13 +232,13 @@ class VersionedTextFileTest(MAASServerTestCase): | |||
2886 | 232 | textfile = VersionedTextFile.objects.create( | 232 | textfile = VersionedTextFile.objects.create( |
2887 | 233 | data='#!/bin/sh\r\necho "Created on Windows!"\r\n' | 233 | data='#!/bin/sh\r\necho "Created on Windows!"\r\n' |
2888 | 234 | ) | 234 | ) |
2890 | 235 | self.assertEquals( | 235 | self.assertEqual( |
2891 | 236 | '#!/bin/sh\necho "Created on Windows!"\n', textfile.data | 236 | '#!/bin/sh\necho "Created on Windows!"\n', textfile.data |
2892 | 237 | ) | 237 | ) |
2893 | 238 | updated_textfile = textfile.update( | 238 | updated_textfile = textfile.update( |
2894 | 239 | '#!/bin/sh\r\necho "Updated on Windows!"\r\n' | 239 | '#!/bin/sh\r\necho "Updated on Windows!"\r\n' |
2895 | 240 | ) | 240 | ) |
2896 | 241 | self.assertNotEquals(textfile, updated_textfile) | 241 | self.assertNotEquals(textfile, updated_textfile) |
2898 | 242 | self.assertEquals( | 242 | self.assertEqual( |
2899 | 243 | '#!/bin/sh\necho "Updated on Windows!"\n', updated_textfile.data | 243 | '#!/bin/sh\necho "Updated on Windows!"\n', updated_textfile.data |
2900 | 244 | ) | 244 | ) |
2901 | diff --git a/src/maasserver/prometheus/tests/test_stats.py b/src/maasserver/prometheus/tests/test_stats.py | |||
2902 | index 235fd86..b37a1a5 100644 | |||
2903 | --- a/src/maasserver/prometheus/tests/test_stats.py | |||
2904 | +++ b/src/maasserver/prometheus/tests/test_stats.py | |||
2905 | @@ -44,14 +44,14 @@ class TestPrometheusHandler(MAASServerTestCase): | |||
2906 | 44 | self.patch(stats, "PROMETHEUS_SUPPORTED", True) | 44 | self.patch(stats, "PROMETHEUS_SUPPORTED", True) |
2907 | 45 | response = self.client.get(reverse("metrics")) | 45 | response = self.client.get(reverse("metrics")) |
2908 | 46 | self.assertEqual("text/html; charset=utf-8", response["Content-Type"]) | 46 | self.assertEqual("text/html; charset=utf-8", response["Content-Type"]) |
2910 | 47 | self.assertEquals(response.status_code, http.client.NOT_FOUND) | 47 | self.assertEqual(response.status_code, http.client.NOT_FOUND) |
2911 | 48 | 48 | ||
2912 | 49 | def test_prometheus_stats_handler_not_found_not_supported(self): | 49 | def test_prometheus_stats_handler_not_found_not_supported(self): |
2913 | 50 | Config.objects.set_config("prometheus_enabled", True) | 50 | Config.objects.set_config("prometheus_enabled", True) |
2914 | 51 | self.patch(stats, "PROMETHEUS_SUPPORTED", False) | 51 | self.patch(stats, "PROMETHEUS_SUPPORTED", False) |
2915 | 52 | response = self.client.get(reverse("metrics")) | 52 | response = self.client.get(reverse("metrics")) |
2916 | 53 | self.assertEqual("text/html; charset=utf-8", response["Content-Type"]) | 53 | self.assertEqual("text/html; charset=utf-8", response["Content-Type"]) |
2918 | 54 | self.assertEquals(response.status_code, http.client.NOT_FOUND) | 54 | self.assertEqual(response.status_code, http.client.NOT_FOUND) |
2919 | 55 | 55 | ||
2920 | 56 | def test_prometheus_stats_handler_returns_success(self): | 56 | def test_prometheus_stats_handler_returns_success(self): |
2921 | 57 | Config.objects.set_config("prometheus_enabled", True) | 57 | Config.objects.set_config("prometheus_enabled", True) |
2922 | @@ -59,7 +59,7 @@ class TestPrometheusHandler(MAASServerTestCase): | |||
2923 | 59 | mock_prom_cli.generate_latest.return_value = {} | 59 | mock_prom_cli.generate_latest.return_value = {} |
2924 | 60 | response = self.client.get(reverse("metrics")) | 60 | response = self.client.get(reverse("metrics")) |
2925 | 61 | self.assertEqual("text/plain", response["Content-Type"]) | 61 | self.assertEqual("text/plain", response["Content-Type"]) |
2927 | 62 | self.assertEquals(response.status_code, http.client.OK) | 62 | self.assertEqual(response.status_code, http.client.OK) |
2928 | 63 | 63 | ||
2929 | 64 | def test_prometheus_stats_handler_returns_metrics(self): | 64 | def test_prometheus_stats_handler_returns_metrics(self): |
2930 | 65 | Config.objects.set_config("prometheus_enabled", True) | 65 | Config.objects.set_config("prometheus_enabled", True) |
2931 | diff --git a/src/maasserver/rpc/tests/test_boot.py b/src/maasserver/rpc/tests/test_boot.py | |||
2932 | index 1e19ada..1dbb43b 100644 | |||
2933 | --- a/src/maasserver/rpc/tests/test_boot.py | |||
2934 | +++ b/src/maasserver/rpc/tests/test_boot.py | |||
2935 | @@ -223,7 +223,7 @@ class TestGetConfig(MAASServerTestCase): | |||
2936 | 223 | mac=mac, | 223 | mac=mac, |
2937 | 224 | query_count=9, | 224 | query_count=9, |
2938 | 225 | ) | 225 | ) |
2940 | 226 | self.assertEquals( | 226 | self.assertEqual( |
2941 | 227 | { | 227 | { |
2942 | 228 | "system_id": node.system_id, | 228 | "system_id": node.system_id, |
2943 | 229 | "arch": node.split_arch()[0], | 229 | "arch": node.split_arch()[0], |
2944 | @@ -268,7 +268,7 @@ class TestGetConfig(MAASServerTestCase): | |||
2945 | 268 | mac=mac, | 268 | mac=mac, |
2946 | 269 | query_count=9, | 269 | query_count=9, |
2947 | 270 | ) | 270 | ) |
2949 | 271 | self.assertEquals( | 271 | self.assertEqual( |
2950 | 272 | { | 272 | { |
2951 | 273 | "system_id": node.system_id, | 273 | "system_id": node.system_id, |
2952 | 274 | "arch": node.split_arch()[0], | 274 | "arch": node.split_arch()[0], |
2953 | @@ -312,7 +312,7 @@ class TestGetConfig(MAASServerTestCase): | |||
2954 | 312 | mac=mac, | 312 | mac=mac, |
2955 | 313 | query_count=8, | 313 | query_count=8, |
2956 | 314 | ) | 314 | ) |
2958 | 315 | self.assertEquals( | 315 | self.assertEqual( |
2959 | 316 | { | 316 | { |
2960 | 317 | "system_id": device.system_id, | 317 | "system_id": device.system_id, |
2961 | 318 | "arch": device.split_arch()[0], | 318 | "arch": device.split_arch()[0], |
2962 | @@ -360,7 +360,7 @@ class TestGetConfig(MAASServerTestCase): | |||
2963 | 360 | config = get_config( | 360 | config = get_config( |
2964 | 361 | rack_controller.system_id, local_ip, remote_ip, mac=mac | 361 | rack_controller.system_id, local_ip, remote_ip, mac=mac |
2965 | 362 | ) | 362 | ) |
2967 | 363 | self.assertEquals(config["purpose"], "xinstall") | 363 | self.assertEqual(config["purpose"], "xinstall") |
2968 | 364 | 364 | ||
2969 | 365 | def test_returns_kparams_for_known_node(self): | 365 | def test_returns_kparams_for_known_node(self): |
2970 | 366 | rack_controller = factory.make_RackController() | 366 | rack_controller = factory.make_RackController() |
2971 | @@ -1403,19 +1403,19 @@ class TestGetBootFilenames(MAASServerTestCase): | |||
2972 | 1403 | arch, subarch, osystem, series | 1403 | arch, subarch, osystem, series |
2973 | 1404 | ) | 1404 | ) |
2974 | 1405 | 1405 | ||
2976 | 1406 | self.assertEquals( | 1406 | self.assertEqual( |
2977 | 1407 | boot_resource_set.files.get( | 1407 | boot_resource_set.files.get( |
2978 | 1408 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL | 1408 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL |
2979 | 1409 | ).filename, | 1409 | ).filename, |
2980 | 1410 | kernel, | 1410 | kernel, |
2981 | 1411 | ) | 1411 | ) |
2983 | 1412 | self.assertEquals( | 1412 | self.assertEqual( |
2984 | 1413 | boot_resource_set.files.get( | 1413 | boot_resource_set.files.get( |
2985 | 1414 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD | 1414 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD |
2986 | 1415 | ).filename, | 1415 | ).filename, |
2987 | 1416 | initrd, | 1416 | initrd, |
2988 | 1417 | ) | 1417 | ) |
2990 | 1418 | self.assertEquals( | 1418 | self.assertEqual( |
2991 | 1419 | boot_resource_set.files.get( | 1419 | boot_resource_set.files.get( |
2992 | 1420 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB | 1420 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB |
2993 | 1421 | ).filename, | 1421 | ).filename, |
2994 | @@ -1435,19 +1435,19 @@ class TestGetBootFilenames(MAASServerTestCase): | |||
2995 | 1435 | arch, "generic", osystem, series | 1435 | arch, "generic", osystem, series |
2996 | 1436 | ) | 1436 | ) |
2997 | 1437 | 1437 | ||
2999 | 1438 | self.assertEquals( | 1438 | self.assertEqual( |
3000 | 1439 | boot_resource_set.files.get( | 1439 | boot_resource_set.files.get( |
3001 | 1440 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL | 1440 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL |
3002 | 1441 | ).filename, | 1441 | ).filename, |
3003 | 1442 | kernel, | 1442 | kernel, |
3004 | 1443 | ) | 1443 | ) |
3006 | 1444 | self.assertEquals( | 1444 | self.assertEqual( |
3007 | 1445 | boot_resource_set.files.get( | 1445 | boot_resource_set.files.get( |
3008 | 1446 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD | 1446 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD |
3009 | 1447 | ).filename, | 1447 | ).filename, |
3010 | 1448 | initrd, | 1448 | initrd, |
3011 | 1449 | ) | 1449 | ) |
3013 | 1450 | self.assertEquals( | 1450 | self.assertEqual( |
3014 | 1451 | boot_resource_set.files.get( | 1451 | boot_resource_set.files.get( |
3015 | 1452 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB | 1452 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_DTB |
3016 | 1453 | ).filename, | 1453 | ).filename, |
3017 | @@ -1486,13 +1486,13 @@ class TestGetBootFilenames(MAASServerTestCase): | |||
3018 | 1486 | arch, subarch, osystem, series | 1486 | arch, subarch, osystem, series |
3019 | 1487 | ) | 1487 | ) |
3020 | 1488 | 1488 | ||
3022 | 1489 | self.assertEquals( | 1489 | self.assertEqual( |
3023 | 1490 | boot_resource_set.files.get( | 1490 | boot_resource_set.files.get( |
3024 | 1491 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL | 1491 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_KERNEL |
3025 | 1492 | ).filename, | 1492 | ).filename, |
3026 | 1493 | kernel, | 1493 | kernel, |
3027 | 1494 | ) | 1494 | ) |
3029 | 1495 | self.assertEquals( | 1495 | self.assertEqual( |
3030 | 1496 | boot_resource_set.files.get( | 1496 | boot_resource_set.files.get( |
3031 | 1497 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD | 1497 | filetype=BOOT_RESOURCE_FILE_TYPE.BOOT_INITRD |
3032 | 1498 | ).filename, | 1498 | ).filename, |
3033 | diff --git a/src/maasserver/rpc/tests/test_leases.py b/src/maasserver/rpc/tests/test_leases.py | |||
3034 | index cb81a6e..134ecef 100644 | |||
3035 | --- a/src/maasserver/rpc/tests/test_leases.py | |||
3036 | +++ b/src/maasserver/rpc/tests/test_leases.py | |||
3037 | @@ -71,14 +71,12 @@ class TestUpdateLease(MAASServerTestCase): | |||
3038 | 71 | action = factory.make_name("action") | 71 | action = factory.make_name("action") |
3039 | 72 | kwargs = self.make_kwargs(action=action) | 72 | kwargs = self.make_kwargs(action=action) |
3040 | 73 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) | 73 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) |
3042 | 74 | self.assertEquals("Unknown lease action: %s" % action, str(error)) | 74 | self.assertEqual("Unknown lease action: %s" % action, str(error)) |
3043 | 75 | 75 | ||
3044 | 76 | def test_raises_LeaseUpdateError_for_no_subnet(self): | 76 | def test_raises_LeaseUpdateError_for_no_subnet(self): |
3045 | 77 | kwargs = self.make_kwargs() | 77 | kwargs = self.make_kwargs() |
3046 | 78 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) | 78 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) |
3050 | 79 | self.assertEquals( | 79 | self.assertEqual("No subnet exists for: %s" % kwargs["ip"], str(error)) |
3048 | 80 | "No subnet exists for: %s" % kwargs["ip"], str(error) | ||
3049 | 81 | ) | ||
3051 | 82 | 80 | ||
3052 | 83 | def test_raises_LeaseUpdateError_for_ipv4_mismatch(self): | 81 | def test_raises_LeaseUpdateError_for_ipv4_mismatch(self): |
3053 | 84 | ipv6_network = factory.make_ipv6_network() | 82 | ipv6_network = factory.make_ipv6_network() |
3054 | @@ -86,7 +84,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3055 | 86 | kwargs = self.make_kwargs(subnet=subnet) | 84 | kwargs = self.make_kwargs(subnet=subnet) |
3056 | 87 | kwargs["ip_family"] = "ipv4" | 85 | kwargs["ip_family"] = "ipv4" |
3057 | 88 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) | 86 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) |
3059 | 89 | self.assertEquals( | 87 | self.assertEqual( |
3060 | 90 | "Family for the subnet does not match. Expected: ipv4", str(error) | 88 | "Family for the subnet does not match. Expected: ipv4", str(error) |
3061 | 91 | ) | 89 | ) |
3062 | 92 | 90 | ||
3063 | @@ -96,7 +94,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3064 | 96 | kwargs = self.make_kwargs(subnet=subnet) | 94 | kwargs = self.make_kwargs(subnet=subnet) |
3065 | 97 | kwargs["ip_family"] = "ipv6" | 95 | kwargs["ip_family"] = "ipv6" |
3066 | 98 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) | 96 | error = self.assertRaises(LeaseUpdateError, update_lease, **kwargs) |
3068 | 99 | self.assertEquals( | 97 | self.assertEqual( |
3069 | 100 | "Family for the subnet does not match. Expected: ipv6", str(error) | 98 | "Family for the subnet does not match. Expected: ipv6", str(error) |
3070 | 101 | ) | 99 | ) |
3071 | 102 | 100 | ||
3072 | @@ -140,7 +138,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3073 | 140 | mac_address=kwargs["mac"] | 138 | mac_address=kwargs["mac"] |
3074 | 141 | ).first() | 139 | ).first() |
3075 | 142 | self.assertIsNotNone(unknown_interface) | 140 | self.assertIsNotNone(unknown_interface) |
3077 | 143 | self.assertEquals(subnet.vlan, unknown_interface.vlan) | 141 | self.assertEqual(subnet.vlan, unknown_interface.vlan) |
3078 | 144 | sip = unknown_interface.ip_addresses.first() | 142 | sip = unknown_interface.ip_addresses.first() |
3079 | 145 | self.assertIsNotNone(sip) | 143 | self.assertIsNotNone(sip) |
3080 | 146 | self.assertThat( | 144 | self.assertThat( |
3081 | @@ -168,7 +166,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3082 | 168 | mac_address=kwargs["mac"] | 166 | mac_address=kwargs["mac"] |
3083 | 169 | ).first() | 167 | ).first() |
3084 | 170 | self.assertIsNotNone(unknown_interface) | 168 | self.assertIsNotNone(unknown_interface) |
3086 | 171 | self.assertEquals(subnet.vlan, unknown_interface.vlan) | 169 | self.assertEqual(subnet.vlan, unknown_interface.vlan) |
3087 | 172 | sip = unknown_interface.ip_addresses.first() | 170 | sip = unknown_interface.ip_addresses.first() |
3088 | 173 | self.assertIsNotNone(sip) | 171 | self.assertIsNotNone(sip) |
3089 | 174 | self.assertThat( | 172 | self.assertThat( |
3090 | @@ -198,7 +196,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3091 | 198 | mac_address=kwargs["mac"] | 196 | mac_address=kwargs["mac"] |
3092 | 199 | ).first() | 197 | ).first() |
3093 | 200 | self.assertIsNotNone(unknown_interface) | 198 | self.assertIsNotNone(unknown_interface) |
3095 | 201 | self.assertEquals(subnet.vlan, unknown_interface.vlan) | 199 | self.assertEqual(subnet.vlan, unknown_interface.vlan) |
3096 | 202 | sip = unknown_interface.ip_addresses.first() | 200 | sip = unknown_interface.ip_addresses.first() |
3097 | 203 | self.assertIsNotNone(sip) | 201 | self.assertIsNotNone(sip) |
3098 | 204 | dnsrr = get_one(DNSResource.objects.filter(name=hostname)) | 202 | dnsrr = get_one(DNSResource.objects.filter(name=hostname)) |
3099 | @@ -232,7 +230,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3100 | 232 | mac_address=kwargs["mac"] | 230 | mac_address=kwargs["mac"] |
3101 | 233 | ).first() | 231 | ).first() |
3102 | 234 | self.assertIsNotNone(unknown_interface) | 232 | self.assertIsNotNone(unknown_interface) |
3104 | 235 | self.assertEquals(subnet.vlan, unknown_interface.vlan) | 233 | self.assertEqual(subnet.vlan, unknown_interface.vlan) |
3105 | 236 | sip = unknown_interface.ip_addresses.first() | 234 | sip = unknown_interface.ip_addresses.first() |
3106 | 237 | self.assertIsNotNone(sip) | 235 | self.assertIsNotNone(sip) |
3107 | 238 | self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip))) | 236 | self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip))) |
3108 | @@ -251,7 +249,7 @@ class TestUpdateLease(MAASServerTestCase): | |||
3109 | 251 | mac_address=kwargs["mac"] | 249 | mac_address=kwargs["mac"] |
3110 | 252 | ).first() | 250 | ).first() |
3111 | 253 | self.assertIsNotNone(unknown_interface) | 251 | self.assertIsNotNone(unknown_interface) |
3113 | 254 | self.assertEquals(subnet.vlan, unknown_interface.vlan) | 252 | self.assertEqual(subnet.vlan, unknown_interface.vlan) |
3114 | 255 | sip = unknown_interface.ip_addresses.first() | 253 | sip = unknown_interface.ip_addresses.first() |
3115 | 256 | self.assertIsNotNone(sip) | 254 | self.assertIsNotNone(sip) |
3116 | 257 | self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip))) | 255 | self.assertThat(sip.dnsresource_set.all(), Not(Contains(sip))) |
3117 | diff --git a/src/maasserver/rpc/tests/test_nodes.py b/src/maasserver/rpc/tests/test_nodes.py | |||
3118 | index 3c5acd8..89cea28 100644 | |||
3119 | --- a/src/maasserver/rpc/tests/test_nodes.py | |||
3120 | +++ b/src/maasserver/rpc/tests/test_nodes.py | |||
3121 | @@ -383,7 +383,7 @@ class TestListClusterNodesPowerParameters(MAASServerTestCase): | |||
3122 | 383 | 383 | ||
3123 | 384 | power_parameters = list_cluster_nodes_power_parameters(rack.system_id) | 384 | power_parameters = list_cluster_nodes_power_parameters(rack.system_id) |
3124 | 385 | system_ids = [params["system_id"] for params in power_parameters] | 385 | system_ids = [params["system_id"] for params in power_parameters] |
3126 | 386 | self.assertEquals(sorted(node_ids), sorted(system_ids)) | 386 | self.assertEqual(sorted(node_ids), sorted(system_ids)) |
3127 | 387 | 387 | ||
3128 | 388 | def test_returns_unchecked_nodes_first(self): | 388 | def test_returns_unchecked_nodes_first(self): |
3129 | 389 | rack = factory.make_RackController(power_type="") | 389 | rack = factory.make_RackController(power_type="") |
3130 | diff --git a/src/maasserver/rpc/tests/test_rackcontrollers.py b/src/maasserver/rpc/tests/test_rackcontrollers.py | |||
3131 | index ab90b8d..181ee77 100644 | |||
3132 | --- a/src/maasserver/rpc/tests/test_rackcontrollers.py | |||
3133 | +++ b/src/maasserver/rpc/tests/test_rackcontrollers.py | |||
3134 | @@ -313,7 +313,7 @@ class TestRegisterRackController(MAASServerTestCase): | |||
3135 | 313 | version = "1.10.2" | 313 | version = "1.10.2" |
3136 | 314 | node = factory.make_Node(node_type=NODE_TYPE.MACHINE) | 314 | node = factory.make_Node(node_type=NODE_TYPE.MACHINE) |
3137 | 315 | register(system_id=node.system_id, version=version) | 315 | register(system_id=node.system_id, version=version) |
3139 | 316 | self.assertEquals(version, node.as_rack_controller().version) | 316 | self.assertEqual(version, node.as_rack_controller().version) |
3140 | 317 | 317 | ||
3141 | 318 | def test_updates_interfaces(self): | 318 | def test_updates_interfaces(self): |
3142 | 319 | # Interfaces are set on existing rack controllers. | 319 | # Interfaces are set on existing rack controllers. |
3143 | @@ -467,7 +467,7 @@ class TestUpdateForeignDHCP(MAASServerTestCase): | |||
3144 | 467 | ) | 467 | ) |
3145 | 468 | dhcp_ip = factory.make_ip_address() | 468 | dhcp_ip = factory.make_ip_address() |
3146 | 469 | update_foreign_dhcp(rack_controller.system_id, interface.name, dhcp_ip) | 469 | update_foreign_dhcp(rack_controller.system_id, interface.name, dhcp_ip) |
3148 | 470 | self.assertEquals(dhcp_ip, reload_object(interface.vlan).external_dhcp) | 470 | self.assertEqual(dhcp_ip, reload_object(interface.vlan).external_dhcp) |
3149 | 471 | 471 | ||
3150 | 472 | def test_logs_warning_for_external_dhcp_on_interface_no_vlan(self): | 472 | def test_logs_warning_for_external_dhcp_on_interface_no_vlan(self): |
3151 | 473 | rack_controller = factory.make_RackController(interface=False) | 473 | rack_controller = factory.make_RackController(interface=False) |
3152 | diff --git a/src/maasserver/rpc/tests/test_regionservice.py b/src/maasserver/rpc/tests/test_regionservice.py | |||
3153 | index 05fffaf..832e8da 100644 | |||
3154 | --- a/src/maasserver/rpc/tests/test_regionservice.py | |||
3155 | +++ b/src/maasserver/rpc/tests/test_regionservice.py | |||
3156 | @@ -431,7 +431,7 @@ class TestRegionServer(MAASTransactionServerTestCase): | |||
3157 | 431 | "interfaces": {}, | 431 | "interfaces": {}, |
3158 | 432 | }, | 432 | }, |
3159 | 433 | ) | 433 | ) |
3161 | 434 | self.assertEquals(rack_controller.system_id, protocol.ident) | 434 | self.assertEqual(rack_controller.system_id, protocol.ident) |
3162 | 435 | 435 | ||
3163 | 436 | @wait_for_reactor | 436 | @wait_for_reactor |
3164 | 437 | @inlineCallbacks | 437 | @inlineCallbacks |
3165 | @@ -474,7 +474,7 @@ class TestRegionServer(MAASTransactionServerTestCase): | |||
3166 | 474 | "interfaces": {}, | 474 | "interfaces": {}, |
3167 | 475 | }, | 475 | }, |
3168 | 476 | ) | 476 | ) |
3170 | 477 | self.assertEquals(sentinel.host, protocol.host) | 477 | self.assertEqual(sentinel.host, protocol.host) |
3171 | 478 | 478 | ||
3172 | 479 | @wait_for_reactor | 479 | @wait_for_reactor |
3173 | 480 | @inlineCallbacks | 480 | @inlineCallbacks |
3174 | @@ -538,7 +538,7 @@ class TestRegionServer(MAASTransactionServerTestCase): | |||
3175 | 538 | ), | 538 | ), |
3176 | 539 | CannotRegisterRackController, | 539 | CannotRegisterRackController, |
3177 | 540 | ) | 540 | ) |
3179 | 541 | self.assertEquals( | 541 | self.assertEqual( |
3180 | 542 | ( | 542 | ( |
3181 | 543 | "Failed to register rack controller 'None' with the master. " | 543 | "Failed to register rack controller 'None' with the master. " |
3182 | 544 | "Connection will be dropped.", | 544 | "Connection will be dropped.", |
3183 | @@ -549,7 +549,7 @@ class TestRegionServer(MAASTransactionServerTestCase): | |||
3184 | 549 | 549 | ||
3185 | 550 | class TestRackClient(MAASTestCase): | 550 | class TestRackClient(MAASTestCase): |
3186 | 551 | def test_defined_cache_calls(self): | 551 | def test_defined_cache_calls(self): |
3188 | 552 | self.assertEquals( | 552 | self.assertEqual( |
3189 | 553 | [cluster.DescribePowerTypes, cluster.DescribeNOSTypes], | 553 | [cluster.DescribePowerTypes, cluster.DescribeNOSTypes], |
3190 | 554 | RackClient.cache_calls, | 554 | RackClient.cache_calls, |
3191 | 555 | ) | 555 | ) |
3192 | @@ -583,7 +583,7 @@ class TestRackClient(MAASTestCase): | |||
3193 | 583 | result = yield client(cluster.DescribePowerTypes) | 583 | result = yield client(cluster.DescribePowerTypes) |
3194 | 584 | # The result is a copy. It should equal the result but not be | 584 | # The result is a copy. It should equal the result but not be |
3195 | 585 | # the same object. | 585 | # the same object. |
3197 | 586 | self.assertEquals(power_types, result) | 586 | self.assertEqual(power_types, result) |
3198 | 587 | self.assertIsNot(power_types, result) | 587 | self.assertIsNot(power_types, result) |
3199 | 588 | 588 | ||
3200 | 589 | @wait_for_reactor | 589 | @wait_for_reactor |
3201 | @@ -1093,7 +1093,7 @@ class TestRegionService(MAASTestCase): | |||
3202 | 1093 | self.assertEqual({uuid: set()}, service.waiters) | 1093 | self.assertEqual({uuid: set()}, service.waiters) |
3203 | 1094 | 1094 | ||
3204 | 1095 | def check(conn_returned): | 1095 | def check(conn_returned): |
3206 | 1096 | self.assertEquals(conn, conn_returned) | 1096 | self.assertEqual(conn, conn_returned) |
3207 | 1097 | 1097 | ||
3208 | 1098 | return d.addCallback(check) | 1098 | return d.addCallback(check) |
3209 | 1099 | 1099 | ||
3210 | diff --git a/src/maasserver/rpc/tests/test_regionservice_calls.py b/src/maasserver/rpc/tests/test_regionservice_calls.py | |||
3211 | index a1dfe15..32d3a2f 100644 | |||
3212 | --- a/src/maasserver/rpc/tests/test_regionservice_calls.py | |||
3213 | +++ b/src/maasserver/rpc/tests/test_regionservice_calls.py | |||
3214 | @@ -1303,7 +1303,7 @@ class TestRegionProtocol_RequestNodeInforByMACAddress( | |||
3215 | 1303 | copy_response = dict(response) | 1303 | copy_response = dict(response) |
3216 | 1304 | del copy_response["boot_type"] | 1304 | del copy_response["boot_type"] |
3217 | 1305 | self.assertAttributes(node, copy_response) | 1305 | self.assertAttributes(node, copy_response) |
3219 | 1306 | self.assertEquals("fastpath", response["boot_type"]) | 1306 | self.assertEqual("fastpath", response["boot_type"]) |
3220 | 1307 | 1307 | ||
3221 | 1308 | @wait_for_reactor | 1308 | @wait_for_reactor |
3222 | 1309 | def test_request_node_info_by_mac_address_raises_if_unknown_mac(self): | 1309 | def test_request_node_info_by_mac_address_raises_if_unknown_mac(self): |
3223 | diff --git a/src/maasserver/tests/test_audit.py b/src/maasserver/tests/test_audit.py | |||
3224 | index 42ed53e..2dc79e2 100644 | |||
3225 | --- a/src/maasserver/tests/test_audit.py | |||
3226 | +++ b/src/maasserver/tests/test_audit.py | |||
3227 | @@ -25,8 +25,8 @@ class CreateAuditEventTest(MAASServerTestCase): | |||
3228 | 25 | create_audit_event(EVENT_TYPES.NODE_PXE_REQUEST, endpoint, request) | 25 | create_audit_event(EVENT_TYPES.NODE_PXE_REQUEST, endpoint, request) |
3229 | 26 | event = Event.objects.get(node=None, type__level=AUDIT) | 26 | event = Event.objects.get(node=None, type__level=AUDIT) |
3230 | 27 | self.assertIsNotNone(event) | 27 | self.assertIsNotNone(event) |
3233 | 28 | self.assertEquals(endpoint, event.endpoint) | 28 | self.assertEqual(endpoint, event.endpoint) |
3234 | 29 | self.assertEquals("", event.user_agent) | 29 | self.assertEqual("", event.user_agent) |
3235 | 30 | 30 | ||
3236 | 31 | def test_create_audit_event_creates_audit_event_with_user_agent(self): | 31 | def test_create_audit_event_creates_audit_event_with_user_agent(self): |
3237 | 32 | node = factory.make_Node() | 32 | node = factory.make_Node() |
3238 | @@ -45,7 +45,7 @@ class CreateAuditEventTest(MAASServerTestCase): | |||
3239 | 45 | ) | 45 | ) |
3240 | 46 | event = Event.objects.get(node=node, type__level=AUDIT) | 46 | event = Event.objects.get(node=node, type__level=AUDIT) |
3241 | 47 | self.assertIsNotNone(event) | 47 | self.assertIsNotNone(event) |
3243 | 48 | self.assertEquals(request.META["HTTP_USER_AGENT"], event.user_agent) | 48 | self.assertEqual(request.META["HTTP_USER_AGENT"], event.user_agent) |
3244 | 49 | 49 | ||
3245 | 50 | def test_create_audit_event_creates_audit_event_with_description(self): | 50 | def test_create_audit_event_creates_audit_event_with_description(self): |
3246 | 51 | node = factory.make_Node() | 51 | node = factory.make_Node() |
3247 | @@ -66,8 +66,8 @@ class CreateAuditEventTest(MAASServerTestCase): | |||
3248 | 66 | ) | 66 | ) |
3249 | 67 | event = Event.objects.get(node=node, type__level=AUDIT) | 67 | event = Event.objects.get(node=node, type__level=AUDIT) |
3250 | 68 | self.assertIsNotNone(event) | 68 | self.assertIsNotNone(event) |
3253 | 69 | self.assertEquals(request.META["HTTP_USER_AGENT"], event.user_agent) | 69 | self.assertEqual(request.META["HTTP_USER_AGENT"], event.user_agent) |
3254 | 70 | self.assertEquals(description, event.description) | 70 | self.assertEqual(description, event.description) |
3255 | 71 | 71 | ||
3256 | 72 | def test_create_audit_event_creates_audit_event_with_AnonymousUser(self): | 72 | def test_create_audit_event_creates_audit_event_with_AnonymousUser(self): |
3257 | 73 | request = HttpRequest() | 73 | request = HttpRequest() |
3258 | diff --git a/src/maasserver/tests/test_bootresources.py b/src/maasserver/tests/test_bootresources.py | |||
3259 | index e89be3c..609d784 100644 | |||
3260 | --- a/src/maasserver/tests/test_bootresources.py | |||
3261 | +++ b/src/maasserver/tests/test_bootresources.py | |||
3262 | @@ -335,8 +335,8 @@ class TestSimpleStreamsHandler(MAASServerTestCase): | |||
3263 | 335 | ) | 335 | ) |
3264 | 336 | response = self.get_stream_client("maas:v2:download.json") | 336 | response = self.get_stream_client("maas:v2:download.json") |
3265 | 337 | output = json.loads(response.content.decode(settings.DEFAULT_CHARSET)) | 337 | output = json.loads(response.content.decode(settings.DEFAULT_CHARSET)) |
3268 | 338 | self.assertEquals(kflavor, output["products"][product]["kflavor"]) | 338 | self.assertEqual(kflavor, output["products"][product]["kflavor"]) |
3269 | 339 | self.assertEquals( | 339 | self.assertEqual( |
3270 | 340 | bootloader_type, output["products"][product]["bootloader-type"] | 340 | bootloader_type, output["products"][product]["bootloader-type"] |
3271 | 341 | ) | 341 | ) |
3272 | 342 | self.assertTrue(output["products"][product]["rolling"]) | 342 | self.assertTrue(output["products"][product]["rolling"]) |
3273 | @@ -849,11 +849,11 @@ class TestBootResourceStore(MAASServerTestCase): | |||
3274 | 849 | } | 849 | } |
3275 | 850 | store = BootResourceStore() | 850 | store = BootResourceStore() |
3276 | 851 | resource = store.get_or_create_boot_resource(product) | 851 | resource = store.get_or_create_boot_resource(product) |
3280 | 852 | self.assertEquals(BOOT_RESOURCE_TYPE.SYNCED, resource.rtype) | 852 | self.assertEqual(BOOT_RESOURCE_TYPE.SYNCED, resource.rtype) |
3281 | 853 | self.assertEquals("ubuntu-core/16-pc", resource.name) | 853 | self.assertEqual("ubuntu-core/16-pc", resource.name) |
3282 | 854 | self.assertEquals("amd64/generic", resource.architecture) | 854 | self.assertEqual("amd64/generic", resource.architecture) |
3283 | 855 | self.assertIsNone(resource.bootloader_type) | 855 | self.assertIsNone(resource.bootloader_type) |
3285 | 856 | self.assertEquals("pc-kernel", resource.kflavor) | 856 | self.assertEqual("pc-kernel", resource.kflavor) |
3286 | 857 | self.assertDictEqual({"title": "Ubuntu Core 16 PC"}, resource.extra) | 857 | self.assertDictEqual({"title": "Ubuntu Core 16 PC"}, resource.extra) |
3287 | 858 | 858 | ||
3288 | 859 | def test_get_or_create_boot_resource_set_creates_resource_set(self): | 859 | def test_get_or_create_boot_resource_set_creates_resource_set(self): |
3289 | @@ -935,7 +935,7 @@ class TestBootResourceStore(MAASServerTestCase): | |||
3290 | 935 | rfile.save() | 935 | rfile.save() |
3291 | 936 | for rfile in resource_set.files.all(): | 936 | for rfile in resource_set.files.all(): |
3292 | 937 | self.assertIn(rfile.filename, files) | 937 | self.assertIn(rfile.filename, files) |
3294 | 938 | self.assertEquals(rfile.filetype, product["ftype"]) | 938 | self.assertEqual(rfile.filetype, product["ftype"]) |
3295 | 939 | 939 | ||
3296 | 940 | def test_get_resource_file_log_identifier_returns_valid_ident(self): | 940 | def test_get_resource_file_log_identifier_returns_valid_ident(self): |
3297 | 941 | os = factory.make_name("os") | 941 | os = factory.make_name("os") |
3298 | @@ -1022,7 +1022,7 @@ class TestBootResourceStore(MAASServerTestCase): | |||
3299 | 1022 | store.delete_content_to_finalize() | 1022 | store.delete_content_to_finalize() |
3300 | 1023 | self.assertIsNone(reload_object(rfile_one)) | 1023 | self.assertIsNone(reload_object(rfile_one)) |
3301 | 1024 | self.assertIsNone(reload_object(rfile_two)) | 1024 | self.assertIsNone(reload_object(rfile_two)) |
3303 | 1025 | self.assertEquals({}, store._content_to_finalize) | 1025 | self.assertEqual({}, store._content_to_finalize) |
3304 | 1026 | 1026 | ||
3305 | 1027 | def test_finalize_does_nothing_if_resources_to_delete_hasnt_changed(self): | 1027 | def test_finalize_does_nothing_if_resources_to_delete_hasnt_changed(self): |
3306 | 1028 | self.patch(bootresources.Event.objects, "create_region_event") | 1028 | self.patch(bootresources.Event.objects, "create_region_event") |
3307 | diff --git a/src/maasserver/tests/test_bootsources.py b/src/maasserver/tests/test_bootsources.py | |||
3308 | index 6bcb549..1be1755 100644 | |||
3309 | --- a/src/maasserver/tests/test_bootsources.py | |||
3310 | +++ b/src/maasserver/tests/test_bootsources.py | |||
3311 | @@ -220,7 +220,7 @@ class TestHelpers(MAASServerTestCase): | |||
3312 | 220 | os_title = factory.make_name("os_title") | 220 | os_title = factory.make_name("os_title") |
3313 | 221 | release_title = factory.make_name("release_title") | 221 | release_title = factory.make_name("release_title") |
3314 | 222 | gadget_title = factory.make_name("gadget_title") | 222 | gadget_title = factory.make_name("gadget_title") |
3316 | 223 | self.assertEquals( | 223 | self.assertEqual( |
3317 | 224 | "%s %s %s" % (os_title, release_title, gadget_title), | 224 | "%s %s %s" % (os_title, release_title, gadget_title), |
3318 | 225 | get_product_title( | 225 | get_product_title( |
3319 | 226 | { | 226 | { |
3320 | @@ -234,7 +234,7 @@ class TestHelpers(MAASServerTestCase): | |||
3321 | 234 | def test_get_product_title_with_os_and_release_titles(self): | 234 | def test_get_product_title_with_os_and_release_titles(self): |
3322 | 235 | os_title = factory.make_name("os_title") | 235 | os_title = factory.make_name("os_title") |
3323 | 236 | release_title = factory.make_name("release_title") | 236 | release_title = factory.make_name("release_title") |
3325 | 237 | self.assertEquals( | 237 | self.assertEqual( |
3326 | 238 | "%s %s" % (os_title, release_title), | 238 | "%s %s" % (os_title, release_title), |
3327 | 239 | get_product_title( | 239 | get_product_title( |
3328 | 240 | {"os_title": os_title, "release_title": release_title} | 240 | {"os_title": os_title, "release_title": release_title} |
3329 | @@ -346,7 +346,7 @@ class TestPrivateUpdateCache(MAASServerTestCase): | |||
3330 | 346 | source.to_dict_without_selections(), | 346 | source.to_dict_without_selections(), |
3331 | 347 | image_mapping, | 347 | image_mapping, |
3332 | 348 | ) | 348 | ) |
3334 | 349 | self.assertEquals(5, queries) | 349 | self.assertEqual(5, queries) |
3335 | 350 | 350 | ||
3336 | 351 | # Now that they all already exist, it should only be 4 queries. | 351 | # Now that they all already exist, it should only be 4 queries. |
3337 | 352 | queries, _ = count_queries( | 352 | queries, _ = count_queries( |
3338 | @@ -354,7 +354,7 @@ class TestPrivateUpdateCache(MAASServerTestCase): | |||
3339 | 354 | source.to_dict_without_selections(), | 354 | source.to_dict_without_selections(), |
3340 | 355 | image_mapping, | 355 | image_mapping, |
3341 | 356 | ) | 356 | ) |
3343 | 357 | self.assertEquals(4, queries) | 357 | self.assertEqual(4, queries) |
3344 | 358 | 358 | ||
3345 | 359 | # Do it again just to be sure. | 359 | # Do it again just to be sure. |
3346 | 360 | queries, _ = count_queries( | 360 | queries, _ = count_queries( |
3347 | @@ -362,7 +362,7 @@ class TestPrivateUpdateCache(MAASServerTestCase): | |||
3348 | 362 | source.to_dict_without_selections(), | 362 | source.to_dict_without_selections(), |
3349 | 363 | image_mapping, | 363 | image_mapping, |
3350 | 364 | ) | 364 | ) |
3352 | 365 | self.assertEquals(4, queries) | 365 | self.assertEqual(4, queries) |
3353 | 366 | 366 | ||
3354 | 367 | 367 | ||
3355 | 368 | class TestPrivateCacheBootSources(MAASTransactionServerTestCase): | 368 | class TestPrivateCacheBootSources(MAASTransactionServerTestCase): |
3356 | diff --git a/src/maasserver/tests/test_config_forms.py b/src/maasserver/tests/test_config_forms.py | |||
3357 | index 53f2508..4e36435 100644 | |||
3358 | --- a/src/maasserver/tests/test_config_forms.py | |||
3359 | +++ b/src/maasserver/tests/test_config_forms.py | |||
3360 | @@ -207,7 +207,7 @@ class TestFormWithDictCharField(MAASServerTestCase): | |||
3361 | 207 | ], | 207 | ], |
3362 | 208 | required=False, | 208 | required=False, |
3363 | 209 | ) | 209 | ) |
3365 | 210 | self.assertEquals( | 210 | self.assertEqual( |
3366 | 211 | default_value, multi_field.clean_sub_fields("")["field_a"] | 211 | default_value, multi_field.clean_sub_fields("")["field_a"] |
3367 | 212 | ) | 212 | ) |
3368 | 213 | 213 | ||
3369 | diff --git a/src/maasserver/tests/test_dhcp.py b/src/maasserver/tests/test_dhcp.py | |||
3370 | index 1ed1e19..ee0aba5 100644 | |||
3371 | --- a/src/maasserver/tests/test_dhcp.py | |||
3372 | +++ b/src/maasserver/tests/test_dhcp.py | |||
3373 | @@ -162,7 +162,7 @@ class TestIPIsStickyOrAuto(MAASServerTestCase): | |||
3374 | 162 | 162 | ||
3375 | 163 | def test_returns_correct_result(self): | 163 | def test_returns_correct_result(self): |
3376 | 164 | ip_address = factory.make_StaticIPAddress(alloc_type=self.alloc_type) | 164 | ip_address = factory.make_StaticIPAddress(alloc_type=self.alloc_type) |
3378 | 165 | self.assertEquals(self.result, dhcp.ip_is_sticky_or_auto(ip_address)) | 165 | self.assertEqual(self.result, dhcp.ip_is_sticky_or_auto(ip_address)) |
3379 | 166 | 166 | ||
3380 | 167 | 167 | ||
3381 | 168 | class TestGetBestInterface(MAASServerTestCase): | 168 | class TestGetBestInterface(MAASServerTestCase): |
3382 | @@ -182,7 +182,7 @@ class TestGetBestInterface(MAASServerTestCase): | |||
3383 | 182 | bond = factory.make_Interface( | 182 | bond = factory.make_Interface( |
3384 | 183 | INTERFACE_TYPE.BOND, node=rack_controller, parents=[nic0, nic1] | 183 | INTERFACE_TYPE.BOND, node=rack_controller, parents=[nic0, nic1] |
3385 | 184 | ) | 184 | ) |
3387 | 185 | self.assertEquals(bond, dhcp.get_best_interface([physical, bond])) | 185 | self.assertEqual(bond, dhcp.get_best_interface([physical, bond])) |
3388 | 186 | 186 | ||
3389 | 187 | def test_returns_physical_over_vlan(self): | 187 | def test_returns_physical_over_vlan(self): |
3390 | 188 | rack_controller = factory.make_RackController() | 188 | rack_controller = factory.make_RackController() |
3391 | @@ -192,7 +192,7 @@ class TestGetBestInterface(MAASServerTestCase): | |||
3392 | 192 | vlan = factory.make_Interface( | 192 | vlan = factory.make_Interface( |
3393 | 193 | INTERFACE_TYPE.VLAN, node=rack_controller, parents=[physical] | 193 | INTERFACE_TYPE.VLAN, node=rack_controller, parents=[physical] |
3394 | 194 | ) | 194 | ) |
3396 | 195 | self.assertEquals(physical, dhcp.get_best_interface([physical, vlan])) | 195 | self.assertEqual(physical, dhcp.get_best_interface([physical, vlan])) |
3397 | 196 | 196 | ||
3398 | 197 | def test_returns_first_interface_when_all_physical(self): | 197 | def test_returns_first_interface_when_all_physical(self): |
3399 | 198 | rack_controller = factory.make_RackController() | 198 | rack_controller = factory.make_RackController() |
3400 | @@ -202,7 +202,7 @@ class TestGetBestInterface(MAASServerTestCase): | |||
3401 | 202 | ) | 202 | ) |
3402 | 203 | for _ in range(3) | 203 | for _ in range(3) |
3403 | 204 | ] | 204 | ] |
3405 | 205 | self.assertEquals(interfaces[0], dhcp.get_best_interface(interfaces)) | 205 | self.assertEqual(interfaces[0], dhcp.get_best_interface(interfaces)) |
3406 | 206 | 206 | ||
3407 | 207 | def test_returns_first_interface_when_all_vlan(self): | 207 | def test_returns_first_interface_when_all_vlan(self): |
3408 | 208 | rack_controller = factory.make_RackController() | 208 | rack_controller = factory.make_RackController() |
3409 | @@ -215,7 +215,7 @@ class TestGetBestInterface(MAASServerTestCase): | |||
3410 | 215 | ) | 215 | ) |
3411 | 216 | for _ in range(3) | 216 | for _ in range(3) |
3412 | 217 | ] | 217 | ] |
3414 | 218 | self.assertEquals(interfaces[0], dhcp.get_best_interface(interfaces)) | 218 | self.assertEqual(interfaces[0], dhcp.get_best_interface(interfaces)) |
3415 | 219 | 219 | ||
3416 | 220 | 220 | ||
3417 | 221 | class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | 221 | class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): |
3418 | @@ -295,7 +295,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3419 | 295 | factory.make_StaticIPAddress( | 295 | factory.make_StaticIPAddress( |
3420 | 296 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface | 296 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface |
3421 | 297 | ) | 297 | ) |
3423 | 298 | self.assertEquals( | 298 | self.assertEqual( |
3424 | 299 | [interface], | 299 | [interface], |
3425 | 300 | dhcp.get_interfaces_with_ip_on_vlan( | 300 | dhcp.get_interfaces_with_ip_on_vlan( |
3426 | 301 | rack_controller, vlan, subnet.get_ipnetwork().version | 301 | rack_controller, vlan, subnet.get_ipnetwork().version |
3427 | @@ -353,7 +353,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3428 | 353 | subnet=subnet_with_dynamic_range, | 353 | subnet=subnet_with_dynamic_range, |
3429 | 354 | interface=interface_two, | 354 | interface=interface_two, |
3430 | 355 | ) | 355 | ) |
3432 | 356 | self.assertEquals( | 356 | self.assertEqual( |
3433 | 357 | [interface_two, interface_one], | 357 | [interface_two, interface_one], |
3434 | 358 | dhcp.get_interfaces_with_ip_on_vlan( | 358 | dhcp.get_interfaces_with_ip_on_vlan( |
3435 | 359 | rack_controller, vlan, subnet.get_ipnetwork().version | 359 | rack_controller, vlan, subnet.get_ipnetwork().version |
3436 | @@ -427,7 +427,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3437 | 427 | subnet=subnet, | 427 | subnet=subnet, |
3438 | 428 | interface=interface, | 428 | interface=interface, |
3439 | 429 | ) | 429 | ) |
3441 | 430 | self.assertEquals( | 430 | self.assertEqual( |
3442 | 431 | [], | 431 | [], |
3443 | 432 | dhcp.get_interfaces_with_ip_on_vlan( | 432 | dhcp.get_interfaces_with_ip_on_vlan( |
3444 | 433 | rack_controller, vlan, subnet.get_ipnetwork().version | 433 | rack_controller, vlan, subnet.get_ipnetwork().version |
3445 | @@ -460,7 +460,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3446 | 460 | subnet=other_subnet, | 460 | subnet=other_subnet, |
3447 | 461 | interface=other_interface, | 461 | interface=other_interface, |
3448 | 462 | ) | 462 | ) |
3450 | 463 | self.assertEquals( | 463 | self.assertEqual( |
3451 | 464 | [interface], | 464 | [interface], |
3452 | 465 | dhcp.get_interfaces_with_ip_on_vlan( | 465 | dhcp.get_interfaces_with_ip_on_vlan( |
3453 | 466 | rack_controller, vlan, subnet.get_ipnetwork().version | 466 | rack_controller, vlan, subnet.get_ipnetwork().version |
3454 | @@ -493,7 +493,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3455 | 493 | subnet=other_subnet, | 493 | subnet=other_subnet, |
3456 | 494 | interface=other_interface, | 494 | interface=other_interface, |
3457 | 495 | ) | 495 | ) |
3459 | 496 | self.assertEquals( | 496 | self.assertEqual( |
3460 | 497 | [interface], | 497 | [interface], |
3461 | 498 | dhcp.get_interfaces_with_ip_on_vlan( | 498 | dhcp.get_interfaces_with_ip_on_vlan( |
3462 | 499 | rack_controller, vlan, subnet.get_ipnetwork().version | 499 | rack_controller, vlan, subnet.get_ipnetwork().version |
3463 | @@ -511,7 +511,7 @@ class TestGetInterfacesWithIPOnVLAN(MAASServerTestCase): | |||
3464 | 511 | factory.make_StaticIPAddress( | 511 | factory.make_StaticIPAddress( |
3465 | 512 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface | 512 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface |
3466 | 513 | ) | 513 | ) |
3468 | 514 | self.assertEquals( | 514 | self.assertEqual( |
3469 | 515 | [interface], | 515 | [interface], |
3470 | 516 | dhcp.get_interfaces_with_ip_on_vlan( | 516 | dhcp.get_interfaces_with_ip_on_vlan( |
3471 | 517 | rack_controller, | 517 | rack_controller, |
3472 | @@ -673,7 +673,7 @@ class TestGenManagedVLANsFor(MAASServerTestCase): | |||
3473 | 673 | 673 | ||
3474 | 674 | # Should only contain the subnets that are managed by the rack | 674 | # Should only contain the subnets that are managed by the rack |
3475 | 675 | # controller and the best interface should have been selected. | 675 | # controller and the best interface should have been selected. |
3477 | 676 | self.assertEquals( | 676 | self.assertEqual( |
3478 | 677 | {vlan_one, vlan_two}, | 677 | {vlan_one, vlan_two}, |
3479 | 678 | set(dhcp.gen_managed_vlans_for(rack_controller)), | 678 | set(dhcp.gen_managed_vlans_for(rack_controller)), |
3480 | 679 | ) | 679 | ) |
3481 | @@ -702,7 +702,7 @@ class TestGenManagedVLANsFor(MAASServerTestCase): | |||
3482 | 702 | 702 | ||
3483 | 703 | # Should only contain the subnets that are managed by the rack | 703 | # Should only contain the subnets that are managed by the rack |
3484 | 704 | # controller and the best interface should have been selected. | 704 | # controller and the best interface should have been selected. |
3486 | 705 | self.assertEquals( | 705 | self.assertEqual( |
3487 | 706 | relay_vlans.union(set([vlan_one])), | 706 | relay_vlans.union(set([vlan_one])), |
3488 | 707 | set(dhcp.gen_managed_vlans_for(rack_controller)), | 707 | set(dhcp.gen_managed_vlans_for(rack_controller)), |
3489 | 708 | ) | 708 | ) |
3490 | @@ -810,7 +810,7 @@ class TestIPIsOnVLAN(MAASServerTestCase): | |||
3491 | 810 | # make_StaticIPAddress always creates a subnet so set it to None. | 810 | # make_StaticIPAddress always creates a subnet so set it to None. |
3492 | 811 | ip_address.subnet = None | 811 | ip_address.subnet = None |
3493 | 812 | ip_address.save() | 812 | ip_address.save() |
3495 | 813 | self.assertEquals( | 813 | self.assertEqual( |
3496 | 814 | self.result, dhcp.ip_is_on_vlan(ip_address, expected_vlan) | 814 | self.result, dhcp.ip_is_on_vlan(ip_address, expected_vlan) |
3497 | 815 | ) | 815 | ) |
3498 | 816 | 816 | ||
3499 | @@ -825,7 +825,7 @@ class TestGetIPAddressForInterface(MAASServerTestCase): | |||
3500 | 825 | ip_address = factory.make_StaticIPAddress( | 825 | ip_address = factory.make_StaticIPAddress( |
3501 | 826 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface | 826 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface |
3502 | 827 | ) | 827 | ) |
3504 | 828 | self.assertEquals( | 828 | self.assertEqual( |
3505 | 829 | ip_address, dhcp.get_ip_address_for_interface(interface, vlan) | 829 | ip_address, dhcp.get_ip_address_for_interface(interface, vlan) |
3506 | 830 | ) | 830 | ) |
3507 | 831 | 831 | ||
3508 | @@ -854,7 +854,7 @@ class TestGetIPAddressForRackController(MAASServerTestCase): | |||
3509 | 854 | ip_address = factory.make_StaticIPAddress( | 854 | ip_address = factory.make_StaticIPAddress( |
3510 | 855 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface | 855 | alloc_type=IPADDRESS_TYPE.AUTO, subnet=subnet, interface=interface |
3511 | 856 | ) | 856 | ) |
3513 | 857 | self.assertEquals( | 857 | self.assertEqual( |
3514 | 858 | ip_address, | 858 | ip_address, |
3515 | 859 | dhcp.get_ip_address_for_rack_controller(rack_controller, vlan), | 859 | dhcp.get_ip_address_for_rack_controller(rack_controller, vlan), |
3516 | 860 | ) | 860 | ) |
3517 | @@ -883,7 +883,7 @@ class TestGetIPAddressForRackController(MAASServerTestCase): | |||
3518 | 883 | subnet=subnet, | 883 | subnet=subnet, |
3519 | 884 | interface=bond_interface, | 884 | interface=bond_interface, |
3520 | 885 | ) | 885 | ) |
3522 | 886 | self.assertEquals( | 886 | self.assertEqual( |
3523 | 887 | bond_ip_address, | 887 | bond_ip_address, |
3524 | 888 | dhcp.get_ip_address_for_rack_controller(rack_controller, vlan), | 888 | dhcp.get_ip_address_for_rack_controller(rack_controller, vlan), |
3525 | 889 | ) | 889 | ) |
3526 | @@ -1120,7 +1120,7 @@ class TestGetDefaultDNSServers(MAASServerTestCase): | |||
3527 | 1120 | self.assertItemsEqual( | 1120 | self.assertItemsEqual( |
3528 | 1121 | servers[0:-1], [IPAddress(r1_address.ip), IPAddress(r2_address.ip)] | 1121 | servers[0:-1], [IPAddress(r1_address.ip), IPAddress(r2_address.ip)] |
3529 | 1122 | ) | 1122 | ) |
3531 | 1123 | self.assertEquals(IPAddress("10.0.0.1"), servers[-1]) | 1123 | self.assertEqual(IPAddress("10.0.0.1"), servers[-1]) |
3532 | 1124 | 1124 | ||
3533 | 1125 | def test_doesnt_include_remote_region_ip(self): | 1125 | def test_doesnt_include_remote_region_ip(self): |
3534 | 1126 | # Regression test for LP:1881133 | 1126 | # Regression test for LP:1881133 |
3535 | @@ -1584,7 +1584,7 @@ class TestMakeSubnetConfig(MAASServerTestCase): | |||
3536 | 1584 | [factory.make_name("ntp")], | 1584 | [factory.make_name("ntp")], |
3537 | 1585 | default_domain, | 1585 | default_domain, |
3538 | 1586 | ) | 1586 | ) |
3540 | 1587 | self.assertEquals( | 1587 | self.assertEqual( |
3541 | 1588 | [ | 1588 | [ |
3542 | 1589 | {"ip_range_low": "10.9.8.11", "ip_range_high": "10.9.8.20"}, | 1589 | {"ip_range_low": "10.9.8.11", "ip_range_high": "10.9.8.20"}, |
3543 | 1590 | {"ip_range_low": "10.9.8.21", "ip_range_high": "10.9.8.30"}, | 1590 | {"ip_range_low": "10.9.8.21", "ip_range_high": "10.9.8.30"}, |
3544 | @@ -1613,7 +1613,7 @@ class TestMakeSubnetConfig(MAASServerTestCase): | |||
3545 | 1613 | default_domain, | 1613 | default_domain, |
3546 | 1614 | failover_peer=failover_peer, | 1614 | failover_peer=failover_peer, |
3547 | 1615 | ) | 1615 | ) |
3549 | 1616 | self.assertEquals( | 1616 | self.assertEqual( |
3550 | 1617 | [ | 1617 | [ |
3551 | 1618 | { | 1618 | { |
3552 | 1619 | "ip_range_low": "10.9.8.11", | 1619 | "ip_range_low": "10.9.8.11", |
3553 | @@ -2016,7 +2016,7 @@ class TestMakeFailoverPeerConfig(MAASServerTestCase): | |||
3554 | 2016 | interface=secondary_interface, | 2016 | interface=secondary_interface, |
3555 | 2017 | ) | 2017 | ) |
3556 | 2018 | failover_peer_name = "failover-vlan-%d" % vlan.id | 2018 | failover_peer_name = "failover-vlan-%d" % vlan.id |
3558 | 2019 | self.assertEquals( | 2019 | self.assertEqual( |
3559 | 2020 | ( | 2020 | ( |
3560 | 2021 | failover_peer_name, | 2021 | failover_peer_name, |
3561 | 2022 | { | 2022 | { |
3562 | @@ -2056,7 +2056,7 @@ class TestMakeFailoverPeerConfig(MAASServerTestCase): | |||
3563 | 2056 | interface=secondary_interface, | 2056 | interface=secondary_interface, |
3564 | 2057 | ) | 2057 | ) |
3565 | 2058 | failover_peer_name = "failover-vlan-%d" % vlan.id | 2058 | failover_peer_name = "failover-vlan-%d" % vlan.id |
3567 | 2059 | self.assertEquals( | 2059 | self.assertEqual( |
3568 | 2060 | ( | 2060 | ( |
3569 | 2061 | failover_peer_name, | 2061 | failover_peer_name, |
3570 | 2062 | { | 2062 | { |
3571 | @@ -2136,7 +2136,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase): | |||
3572 | 2136 | dhcp_snippets=DHCPSnippet.objects.all(), | 2136 | dhcp_snippets=DHCPSnippet.objects.all(), |
3573 | 2137 | ) | 2137 | ) |
3574 | 2138 | 2138 | ||
3576 | 2139 | self.assertEquals( | 2139 | self.assertEqual( |
3577 | 2140 | { | 2140 | { |
3578 | 2141 | "name": "failover-vlan-%d" % ha_vlan.id, | 2141 | "name": "failover-vlan-%d" % ha_vlan.id, |
3579 | 2142 | "mode": "primary", | 2142 | "mode": "primary", |
3580 | @@ -2145,7 +2145,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase): | |||
3581 | 2145 | }, | 2145 | }, |
3582 | 2146 | observed_failover, | 2146 | observed_failover, |
3583 | 2147 | ) | 2147 | ) |
3585 | 2148 | self.assertEquals( | 2148 | self.assertEqual( |
3586 | 2149 | sorted( | 2149 | sorted( |
3587 | 2150 | [ | 2150 | [ |
3588 | 2151 | { | 2151 | { |
3589 | @@ -2297,7 +2297,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase): | |||
3590 | 2297 | for observed_subnet in observed_subnets: | 2297 | for observed_subnet in observed_subnets: |
3591 | 2298 | del observed_subnet["dns_servers"] | 2298 | del observed_subnet["dns_servers"] |
3592 | 2299 | 2299 | ||
3594 | 2300 | self.assertEquals( | 2300 | self.assertEqual( |
3595 | 2301 | { | 2301 | { |
3596 | 2302 | "name": "failover-vlan-%d" % ha_vlan.id, | 2302 | "name": "failover-vlan-%d" % ha_vlan.id, |
3597 | 2303 | "mode": "primary", | 2303 | "mode": "primary", |
3598 | @@ -2306,7 +2306,7 @@ class TestGetDHCPConfigureFor(MAASServerTestCase): | |||
3599 | 2306 | }, | 2306 | }, |
3600 | 2307 | observed_failover, | 2307 | observed_failover, |
3601 | 2308 | ) | 2308 | ) |
3603 | 2309 | self.assertEquals( | 2309 | self.assertEqual( |
3604 | 2310 | sorted( | 2310 | sorted( |
3605 | 2311 | [ | 2311 | [ |
3606 | 2312 | { | 2312 | { |
3607 | @@ -3195,7 +3195,7 @@ class TestValidateDHCPConfig(MAASTransactionServerTestCase): | |||
3608 | 3195 | rack_controller, config = self.create_rack_controller() | 3195 | rack_controller, config = self.create_rack_controller() |
3609 | 3196 | self.prepare_rpc(rack_controller) | 3196 | self.prepare_rpc(rack_controller) |
3610 | 3197 | 3197 | ||
3612 | 3198 | self.assertEquals([], dhcp.validate_dhcp_config()) | 3198 | self.assertEqual([], dhcp.validate_dhcp_config()) |
3613 | 3199 | 3199 | ||
3614 | 3200 | def test_returns_errors_when_invalid(self): | 3200 | def test_returns_errors_when_invalid(self): |
3615 | 3201 | rack_controller, config = self.create_rack_controller() | 3201 | rack_controller, config = self.create_rack_controller() |
3616 | diff --git a/src/maasserver/tests/test_eventloop.py b/src/maasserver/tests/test_eventloop.py | |||
3617 | index 1483066..83433eb 100644 | |||
3618 | --- a/src/maasserver/tests/test_eventloop.py | |||
3619 | +++ b/src/maasserver/tests/test_eventloop.py | |||
3620 | @@ -356,7 +356,7 @@ class TestFactories(MAASServerTestCase): | |||
3621 | 356 | eventloop.loop.factories["rpc"]["factory"], | 356 | eventloop.loop.factories["rpc"]["factory"], |
3622 | 357 | ) | 357 | ) |
3623 | 358 | self.assertFalse(eventloop.loop.factories["rpc"]["only_on_master"]) | 358 | self.assertFalse(eventloop.loop.factories["rpc"]["only_on_master"]) |
3625 | 359 | self.assertEquals( | 359 | self.assertEqual( |
3626 | 360 | ["ipc-worker"], eventloop.loop.factories["rpc"]["requires"] | 360 | ["ipc-worker"], eventloop.loop.factories["rpc"]["requires"] |
3627 | 361 | ) | 361 | ) |
3628 | 362 | 362 | ||
3629 | @@ -458,7 +458,7 @@ class TestFactories(MAASServerTestCase): | |||
3630 | 458 | eventloop.loop.factories["web"]["factory"], | 458 | eventloop.loop.factories["web"]["factory"], |
3631 | 459 | ) | 459 | ) |
3632 | 460 | # Has a dependency of postgres-listener. | 460 | # Has a dependency of postgres-listener. |
3634 | 461 | self.assertEquals( | 461 | self.assertEqual( |
3635 | 462 | ["postgres-listener-worker", "status-worker"], | 462 | ["postgres-listener-worker", "status-worker"], |
3636 | 463 | eventloop.loop.factories["web"]["requires"], | 463 | eventloop.loop.factories["web"]["requires"], |
3637 | 464 | ) | 464 | ) |
3638 | @@ -477,7 +477,7 @@ class TestFactories(MAASServerTestCase): | |||
3639 | 477 | eventloop.loop.factories["rack-controller"]["factory"], | 477 | eventloop.loop.factories["rack-controller"]["factory"], |
3640 | 478 | ) | 478 | ) |
3641 | 479 | # Has a dependency of ipc-worker and postgres-listener. | 479 | # Has a dependency of ipc-worker and postgres-listener. |
3643 | 480 | self.assertEquals( | 480 | self.assertEqual( |
3644 | 481 | ["ipc-worker", "postgres-listener-worker"], | 481 | ["ipc-worker", "postgres-listener-worker"], |
3645 | 482 | eventloop.loop.factories["rack-controller"]["requires"], | 482 | eventloop.loop.factories["rack-controller"]["requires"], |
3646 | 483 | ) | 483 | ) |
3647 | @@ -495,7 +495,7 @@ class TestFactories(MAASServerTestCase): | |||
3648 | 495 | eventloop.make_ServiceMonitorService, | 495 | eventloop.make_ServiceMonitorService, |
3649 | 496 | eventloop.loop.factories["service-monitor"]["factory"], | 496 | eventloop.loop.factories["service-monitor"]["factory"], |
3650 | 497 | ) | 497 | ) |
3652 | 498 | self.assertEquals( | 498 | self.assertEqual( |
3653 | 499 | [], eventloop.loop.factories["service-monitor"]["requires"] | 499 | [], eventloop.loop.factories["service-monitor"]["requires"] |
3654 | 500 | ) | 500 | ) |
3655 | 501 | self.assertTrue( | 501 | self.assertTrue( |
3656 | @@ -511,7 +511,7 @@ class TestFactories(MAASServerTestCase): | |||
3657 | 511 | eventloop.loop.factories["status-worker"]["factory"], | 511 | eventloop.loop.factories["status-worker"]["factory"], |
3658 | 512 | ) | 512 | ) |
3659 | 513 | # Has a dependency of database-tasks. | 513 | # Has a dependency of database-tasks. |
3661 | 514 | self.assertEquals( | 514 | self.assertEqual( |
3662 | 515 | ["database-tasks"], | 515 | ["database-tasks"], |
3663 | 516 | eventloop.loop.factories["status-worker"]["requires"], | 516 | eventloop.loop.factories["status-worker"]["requires"], |
3664 | 517 | ) | 517 | ) |
3665 | @@ -530,7 +530,7 @@ class TestFactories(MAASServerTestCase): | |||
3666 | 530 | eventloop.loop.factories["ntp"]["factory"], | 530 | eventloop.loop.factories["ntp"]["factory"], |
3667 | 531 | ) | 531 | ) |
3668 | 532 | # Has a no dependencies. | 532 | # Has a no dependencies. |
3670 | 533 | self.assertEquals([], eventloop.loop.factories["ntp"]["requires"]) | 533 | self.assertEqual([], eventloop.loop.factories["ntp"]["requires"]) |
3671 | 534 | self.assertTrue(eventloop.loop.factories["ntp"]["only_on_master"]) | 534 | self.assertTrue(eventloop.loop.factories["ntp"]["only_on_master"]) |
3672 | 535 | 535 | ||
3673 | 536 | def test_make_SyslogService(self): | 536 | def test_make_SyslogService(self): |
3674 | @@ -542,7 +542,7 @@ class TestFactories(MAASServerTestCase): | |||
3675 | 542 | eventloop.loop.factories["syslog"]["factory"], | 542 | eventloop.loop.factories["syslog"]["factory"], |
3676 | 543 | ) | 543 | ) |
3677 | 544 | # Has a no dependencies. | 544 | # Has a no dependencies. |
3679 | 545 | self.assertEquals([], eventloop.loop.factories["syslog"]["requires"]) | 545 | self.assertEqual([], eventloop.loop.factories["syslog"]["requires"]) |
3680 | 546 | self.assertTrue(eventloop.loop.factories["syslog"]["only_on_master"]) | 546 | self.assertTrue(eventloop.loop.factories["syslog"]["only_on_master"]) |
3681 | 547 | 547 | ||
3682 | 548 | def test_make_WorkersService(self): | 548 | def test_make_WorkersService(self): |
3683 | @@ -554,7 +554,7 @@ class TestFactories(MAASServerTestCase): | |||
3684 | 554 | eventloop.loop.factories["workers"]["factory"], | 554 | eventloop.loop.factories["workers"]["factory"], |
3685 | 555 | ) | 555 | ) |
3686 | 556 | # Has a no dependencies. | 556 | # Has a no dependencies. |
3688 | 557 | self.assertEquals([], eventloop.loop.factories["workers"]["requires"]) | 557 | self.assertEqual([], eventloop.loop.factories["workers"]["requires"]) |
3689 | 558 | self.assertTrue(eventloop.loop.factories["workers"]["only_on_master"]) | 558 | self.assertTrue(eventloop.loop.factories["workers"]["only_on_master"]) |
3690 | 559 | self.assertTrue(eventloop.loop.factories["workers"]["not_all_in_one"]) | 559 | self.assertTrue(eventloop.loop.factories["workers"]["not_all_in_one"]) |
3691 | 560 | 560 | ||
3692 | @@ -567,11 +567,11 @@ class TestFactories(MAASServerTestCase): | |||
3693 | 567 | eventloop.loop.factories["ipc-master"]["factory"], | 567 | eventloop.loop.factories["ipc-master"]["factory"], |
3694 | 568 | ) | 568 | ) |
3695 | 569 | # Has a no dependencies. | 569 | # Has a no dependencies. |
3697 | 570 | self.assertEquals( | 570 | self.assertEqual( |
3698 | 571 | [], eventloop.loop.factories["ipc-master"]["requires"] | 571 | [], eventloop.loop.factories["ipc-master"]["requires"] |
3699 | 572 | ) | 572 | ) |
3700 | 573 | # Has an optional dependency on workers. | 573 | # Has an optional dependency on workers. |
3702 | 574 | self.assertEquals( | 574 | self.assertEqual( |
3703 | 575 | ["workers"], eventloop.loop.factories["ipc-master"]["optional"] | 575 | ["workers"], eventloop.loop.factories["ipc-master"]["optional"] |
3704 | 576 | ) | 576 | ) |
3705 | 577 | self.assertTrue( | 577 | self.assertTrue( |
3706 | @@ -587,7 +587,7 @@ class TestFactories(MAASServerTestCase): | |||
3707 | 587 | eventloop.loop.factories["ipc-worker"]["factory"], | 587 | eventloop.loop.factories["ipc-worker"]["factory"], |
3708 | 588 | ) | 588 | ) |
3709 | 589 | # Has a no dependencies. | 589 | # Has a no dependencies. |
3711 | 590 | self.assertEquals( | 590 | self.assertEqual( |
3712 | 591 | [], eventloop.loop.factories["ipc-worker"]["requires"] | 591 | [], eventloop.loop.factories["ipc-worker"]["requires"] |
3713 | 592 | ) | 592 | ) |
3714 | 593 | self.assertFalse( | 593 | self.assertFalse( |
3715 | diff --git a/src/maasserver/tests/test_fields.py b/src/maasserver/tests/test_fields.py | |||
3716 | index 7f8e440..926364a 100644 | |||
3717 | --- a/src/maasserver/tests/test_fields.py | |||
3718 | +++ b/src/maasserver/tests/test_fields.py | |||
3719 | @@ -835,7 +835,7 @@ class TestVersionedTextFileField(MAASServerTestCase): | |||
3720 | 835 | data = factory.make_string() | 835 | data = factory.make_string() |
3721 | 836 | versioned_text_file_field = VersionedTextFileField() | 836 | versioned_text_file_field = VersionedTextFileField() |
3722 | 837 | versioned_text_file = versioned_text_file_field.clean(data) | 837 | versioned_text_file = versioned_text_file_field.clean(data) |
3724 | 838 | self.assertEquals(data, versioned_text_file.data) | 838 | self.assertEqual(data, versioned_text_file.data) |
3725 | 839 | self.assertIsNone(versioned_text_file.previous_version) | 839 | self.assertIsNone(versioned_text_file.previous_version) |
3726 | 840 | 840 | ||
3727 | 841 | def test_create_requires_value(self): | 841 | def test_create_requires_value(self): |
3728 | @@ -851,22 +851,22 @@ class TestVersionedTextFileField(MAASServerTestCase): | |||
3729 | 851 | versioned_text_file = versioned_text_file_field.clean( | 851 | versioned_text_file = versioned_text_file_field.clean( |
3730 | 852 | {"data": data, "comment": comment} | 852 | {"data": data, "comment": comment} |
3731 | 853 | ) | 853 | ) |
3734 | 854 | self.assertEquals(data, versioned_text_file.data) | 854 | self.assertEqual(data, versioned_text_file.data) |
3735 | 855 | self.assertEquals(comment, versioned_text_file.comment) | 855 | self.assertEqual(comment, versioned_text_file.comment) |
3736 | 856 | self.assertIsNone(versioned_text_file.previous_version) | 856 | self.assertIsNone(versioned_text_file.previous_version) |
3737 | 857 | 857 | ||
3738 | 858 | def test_update_does_nothing_on_none(self): | 858 | def test_update_does_nothing_on_none(self): |
3739 | 859 | data = VersionedTextFile.objects.create(data=factory.make_string()) | 859 | data = VersionedTextFile.objects.create(data=factory.make_string()) |
3740 | 860 | versioned_text_file_field = VersionedTextFileField(initial=data) | 860 | versioned_text_file_field = VersionedTextFileField(initial=data) |
3742 | 861 | self.assertEquals(data, versioned_text_file_field.clean(None)) | 861 | self.assertEqual(data, versioned_text_file_field.clean(None)) |
3743 | 862 | 862 | ||
3744 | 863 | def test_creates_new_link(self): | 863 | def test_creates_new_link(self): |
3745 | 864 | old_ver = VersionedTextFile.objects.create(data=factory.make_string()) | 864 | old_ver = VersionedTextFile.objects.create(data=factory.make_string()) |
3746 | 865 | versioned_text_file_field = VersionedTextFileField(initial=old_ver) | 865 | versioned_text_file_field = VersionedTextFileField(initial=old_ver) |
3747 | 866 | data = factory.make_string() | 866 | data = factory.make_string() |
3748 | 867 | new_ver = versioned_text_file_field.clean(data) | 867 | new_ver = versioned_text_file_field.clean(data) |
3751 | 868 | self.assertEquals(data, new_ver.data) | 868 | self.assertEqual(data, new_ver.data) |
3752 | 869 | self.assertEquals(old_ver, new_ver.previous_version) | 869 | self.assertEqual(old_ver, new_ver.previous_version) |
3753 | 870 | 870 | ||
3754 | 871 | def test_creates_new_link_accepts_dict(self): | 871 | def test_creates_new_link_accepts_dict(self): |
3755 | 872 | old_ver = VersionedTextFile.objects.create(data=factory.make_string()) | 872 | old_ver = VersionedTextFile.objects.create(data=factory.make_string()) |
3756 | @@ -876,9 +876,9 @@ class TestVersionedTextFileField(MAASServerTestCase): | |||
3757 | 876 | new_ver = versioned_text_file_field.clean( | 876 | new_ver = versioned_text_file_field.clean( |
3758 | 877 | {"new_data": data, "comment": comment} | 877 | {"new_data": data, "comment": comment} |
3759 | 878 | ) | 878 | ) |
3763 | 879 | self.assertEquals(data, new_ver.data) | 879 | self.assertEqual(data, new_ver.data) |
3764 | 880 | self.assertEquals(comment, new_ver.comment) | 880 | self.assertEqual(comment, new_ver.comment) |
3765 | 881 | self.assertEquals(old_ver, new_ver.previous_version) | 881 | self.assertEqual(old_ver, new_ver.previous_version) |
3766 | 882 | 882 | ||
3767 | 883 | 883 | ||
3768 | 884 | class TestURLOrPPAValidator(MAASServerTestCase): | 884 | class TestURLOrPPAValidator(MAASServerTestCase): |
3769 | diff --git a/src/maasserver/tests/test_ipc.py b/src/maasserver/tests/test_ipc.py | |||
3770 | index a67d826..ee0214a 100644 | |||
3771 | --- a/src/maasserver/tests/test_ipc.py | |||
3772 | +++ b/src/maasserver/tests/test_ipc.py | |||
3773 | @@ -54,18 +54,18 @@ class TestGetIPCSocketPath(MAASTestCase): | |||
3774 | 54 | self.useFixture( | 54 | self.useFixture( |
3775 | 55 | EnvironmentVariableFixture("MAAS_IPC_SOCKET_PATH", path) | 55 | EnvironmentVariableFixture("MAAS_IPC_SOCKET_PATH", path) |
3776 | 56 | ) | 56 | ) |
3778 | 57 | self.assertEquals(path, get_ipc_socket_path()) | 57 | self.assertEqual(path, get_ipc_socket_path()) |
3779 | 58 | 58 | ||
3780 | 59 | def test_returns_ipc_from_maas_data(self): | 59 | def test_returns_ipc_from_maas_data(self): |
3781 | 60 | path = factory.make_name("path") | 60 | path = factory.make_name("path") |
3782 | 61 | self.useFixture(EnvironmentVariableFixture("MAAS_DATA", path)) | 61 | self.useFixture(EnvironmentVariableFixture("MAAS_DATA", path)) |
3784 | 62 | self.assertEquals( | 62 | self.assertEqual( |
3785 | 63 | os.path.join(path, "maas-regiond.sock"), get_ipc_socket_path() | 63 | os.path.join(path, "maas-regiond.sock"), get_ipc_socket_path() |
3786 | 64 | ) | 64 | ) |
3787 | 65 | 65 | ||
3788 | 66 | def test_returns_ipc_at_default_location(self): | 66 | def test_returns_ipc_at_default_location(self): |
3789 | 67 | self.useFixture(EnvironmentVariableFixture("MAAS_DATA", None)) | 67 | self.useFixture(EnvironmentVariableFixture("MAAS_DATA", None)) |
3791 | 68 | self.assertEquals( | 68 | self.assertEqual( |
3792 | 69 | "/var/lib/maas/maas-regiond.sock", get_ipc_socket_path() | 69 | "/var/lib/maas/maas-regiond.sock", get_ipc_socket_path() |
3793 | 70 | ) | 70 | ) |
3794 | 71 | 71 | ||
3795 | @@ -142,15 +142,15 @@ class TestIPCCommunication(MAASTransactionServerTestCase): | |||
3796 | 142 | return RegionControllerProcess.objects.get(region=region, pid=pid) | 142 | return RegionControllerProcess.objects.get(region=region, pid=pid) |
3797 | 143 | 143 | ||
3798 | 144 | process = yield deferToDatabase(getProcessFromDB) | 144 | process = yield deferToDatabase(getProcessFromDB) |
3800 | 145 | self.assertEquals(process.id, master.connections[pid]["process_id"]) | 145 | self.assertEqual(process.id, master.connections[pid]["process_id"]) |
3801 | 146 | 146 | ||
3802 | 147 | worker_procId = yield worker.processId.get(timeout=2) | 147 | worker_procId = yield worker.processId.get(timeout=2) |
3804 | 148 | self.assertEquals(process.id, worker_procId) | 148 | self.assertEqual(process.id, worker_procId) |
3805 | 149 | 149 | ||
3806 | 150 | yield worker.stopService() | 150 | yield worker.stopService() |
3807 | 151 | 151 | ||
3808 | 152 | yield disconnected.get(timeout=2) | 152 | yield disconnected.get(timeout=2) |
3810 | 153 | self.assertEquals({}, master.connections) | 153 | self.assertEqual({}, master.connections) |
3811 | 154 | 154 | ||
3812 | 155 | process = yield deferToDatabase(reload_object, process) | 155 | process = yield deferToDatabase(reload_object, process) |
3813 | 156 | self.assertIsNone(process) | 156 | self.assertIsNone(process) |
3814 | @@ -217,7 +217,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase): | |||
3815 | 217 | ) | 217 | ) |
3816 | 218 | 218 | ||
3817 | 219 | endpoints = yield deferToDatabase(getEndpoints) | 219 | endpoints = yield deferToDatabase(getEndpoints) |
3819 | 220 | self.assertEquals( | 220 | self.assertEqual( |
3820 | 221 | master._getListenAddresses(master.connections[pid]["rpc"]["port"]), | 221 | master._getListenAddresses(master.connections[pid]["rpc"]["port"]), |
3821 | 222 | endpoints, | 222 | endpoints, |
3822 | 223 | ) | 223 | ) |
3823 | @@ -294,7 +294,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase): | |||
3824 | 294 | 294 | ||
3825 | 295 | connection = yield deferToDatabase(getConnection) | 295 | connection = yield deferToDatabase(getConnection) |
3826 | 296 | self.assertIsNotNone(connection) | 296 | self.assertIsNotNone(connection) |
3828 | 297 | self.assertEquals( | 297 | self.assertEqual( |
3829 | 298 | {connid: (rackd.system_id, address, port)}, | 298 | {connid: (rackd.system_id, address, port)}, |
3830 | 299 | master.connections[pid]["rpc"]["connections"], | 299 | master.connections[pid]["rpc"]["connections"], |
3831 | 300 | ) | 300 | ) |
3832 | @@ -331,7 +331,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase): | |||
3833 | 331 | process = yield deferToDatabase( | 331 | process = yield deferToDatabase( |
3834 | 332 | RegionControllerProcess.objects.get, id=data["process_id"] | 332 | RegionControllerProcess.objects.get, id=data["process_id"] |
3835 | 333 | ) | 333 | ) |
3837 | 334 | self.assertEquals(pid, process.pid) | 334 | self.assertEqual(pid, process.pid) |
3838 | 335 | 335 | ||
3839 | 336 | yield master.stopService() | 336 | yield master.stopService() |
3840 | 337 | 337 | ||
3841 | @@ -404,7 +404,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase): | |||
3842 | 404 | yield master.update() | 404 | yield master.update() |
3843 | 405 | 405 | ||
3844 | 406 | region_process = yield deferToDatabase(reload_object, region_process) | 406 | region_process = yield deferToDatabase(reload_object, region_process) |
3846 | 407 | self.assertEquals(current_time, region_process.updated) | 407 | self.assertEqual(current_time, region_process.updated) |
3847 | 408 | 408 | ||
3848 | 409 | yield master.stopService() | 409 | yield master.stopService() |
3849 | 410 | 410 | ||
3850 | diff --git a/src/maasserver/tests/test_listener.py b/src/maasserver/tests/test_listener.py | |||
3851 | index 0e12135..8699b02 100644 | |||
3852 | --- a/src/maasserver/tests/test_listener.py | |||
3853 | +++ b/src/maasserver/tests/test_listener.py | |||
3854 | @@ -573,9 +573,9 @@ class TestPostgresListenerService(MAASServerTestCase): | |||
3855 | 573 | listener = PostgresListenerService() | 573 | listener = PostgresListenerService() |
3856 | 574 | channel = factory.make_name("channel", sep="_").lower() | 574 | channel = factory.make_name("channel", sep="_").lower() |
3857 | 575 | listener.register(channel, sentinel.handler) | 575 | listener.register(channel, sentinel.handler) |
3859 | 576 | self.assertEquals({channel: [sentinel.handler]}, listener.listeners) | 576 | self.assertEqual({channel: [sentinel.handler]}, listener.listeners) |
3860 | 577 | listener.unregister(channel, sentinel.handler) | 577 | listener.unregister(channel, sentinel.handler) |
3862 | 578 | self.assertEquals({}, listener.listeners) | 578 | self.assertEqual({}, listener.listeners) |
3863 | 579 | 579 | ||
3864 | 580 | def test_unregister_removes_handler_others(self): | 580 | def test_unregister_removes_handler_others(self): |
3865 | 581 | listener = PostgresListenerService() | 581 | listener = PostgresListenerService() |
3866 | @@ -583,7 +583,7 @@ class TestPostgresListenerService(MAASServerTestCase): | |||
3867 | 583 | listener.register(channel, sentinel.handler1) | 583 | listener.register(channel, sentinel.handler1) |
3868 | 584 | listener.register(channel, sentinel.handler2) | 584 | listener.register(channel, sentinel.handler2) |
3869 | 585 | listener.unregister(channel, sentinel.handler2) | 585 | listener.unregister(channel, sentinel.handler2) |
3871 | 586 | self.assertEquals({channel: [sentinel.handler1]}, listener.listeners) | 586 | self.assertEqual({channel: [sentinel.handler1]}, listener.listeners) |
3872 | 587 | 587 | ||
3873 | 588 | @wait_for_reactor | 588 | @wait_for_reactor |
3874 | 589 | @inlineCallbacks | 589 | @inlineCallbacks |
3875 | diff --git a/src/maasserver/tests/test_node_action.py b/src/maasserver/tests/test_node_action.py | |||
3876 | index add7166..6ec7c70 100644 | |||
3877 | --- a/src/maasserver/tests/test_node_action.py | |||
3878 | +++ b/src/maasserver/tests/test_node_action.py | |||
3879 | @@ -370,13 +370,11 @@ class TestCommissionAction(MAASServerTestCase): | |||
3880 | 370 | ) | 370 | ) |
3881 | 371 | script_sets = ScriptSet.objects.all() | 371 | script_sets = ScriptSet.objects.all() |
3882 | 372 | node = reload_object(node) | 372 | node = reload_object(node) |
3885 | 373 | self.assertEquals(2, len(script_sets)) | 373 | self.assertEqual(2, len(script_sets)) |
3886 | 374 | self.assertEquals( | 374 | self.assertEqual( |
3887 | 375 | node.current_commissioning_script_set_id, script_sets[0].id | 375 | node.current_commissioning_script_set_id, script_sets[0].id |
3888 | 376 | ) | 376 | ) |
3892 | 377 | self.assertEquals( | 377 | self.assertEqual(node.current_testing_script_set_id, script_sets[1].id) |
3890 | 378 | node.current_testing_script_set_id, script_sets[1].id | ||
3891 | 379 | ) | ||
3893 | 380 | self.assertEqual(NODE_STATUS.COMMISSIONING, node.status) | 378 | self.assertEqual(NODE_STATUS.COMMISSIONING, node.status) |
3894 | 381 | self.assertThat( | 379 | self.assertThat( |
3895 | 382 | node_start, | 380 | node_start, |
3896 | diff --git a/src/maasserver/tests/test_node_constraint_filter_forms.py b/src/maasserver/tests/test_node_constraint_filter_forms.py | |||
3897 | index 96dd0a6..9c0a514 100644 | |||
3898 | --- a/src/maasserver/tests/test_node_constraint_filter_forms.py | |||
3899 | +++ b/src/maasserver/tests/test_node_constraint_filter_forms.py | |||
3900 | @@ -872,7 +872,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin): | |||
3901 | 872 | _, storage, _ = self.assertConstrainedNodes( | 872 | _, storage, _ = self.assertConstrainedNodes( |
3902 | 873 | [node1], {"storage": "part:0(partition)"} | 873 | [node1], {"storage": "part:0(partition)"} |
3903 | 874 | ) | 874 | ) |
3905 | 875 | self.assertEquals( | 875 | self.assertEqual( |
3906 | 876 | {node1.id: {"partition:%d" % partition.id: "part"}}, storage | 876 | {node1.id: {"partition:%d" % partition.id: "part"}}, storage |
3907 | 877 | ) | 877 | ) |
3908 | 878 | 878 | ||
3909 | @@ -928,7 +928,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin): | |||
3910 | 928 | _, storage, _ = self.assertConstrainedNodes( | 928 | _, storage, _ = self.assertConstrainedNodes( |
3911 | 929 | [node1], {"storage": "part:0(partition,ssd-part)"} | 929 | [node1], {"storage": "part:0(partition,ssd-part)"} |
3912 | 930 | ) | 930 | ) |
3914 | 931 | self.assertEquals( | 931 | self.assertEqual( |
3915 | 932 | {node1.id: {"partition:%d" % partition.id: "part"}}, storage | 932 | {node1.id: {"partition:%d" % partition.id: "part"}}, storage |
3916 | 933 | ) | 933 | ) |
3917 | 934 | 934 | ||
3918 | @@ -1090,7 +1090,7 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin): | |||
3919 | 1090 | _, storage, _ = self.assertConstrainedNodes( | 1090 | _, storage, _ = self.assertConstrainedNodes( |
3920 | 1091 | [node3], {"storage": "0,4,4,4,part:0(partition)"} | 1091 | [node3], {"storage": "0,4,4,4,part:0(partition)"} |
3921 | 1092 | ) | 1092 | ) |
3923 | 1093 | self.assertEquals( | 1093 | self.assertEqual( |
3924 | 1094 | {node3.id: {"partition:%d" % partition.id: "part"}}, storage | 1094 | {node3.id: {"partition:%d" % partition.id: "part"}}, storage |
3925 | 1095 | ) | 1095 | ) |
3926 | 1096 | 1096 | ||
3927 | @@ -1203,11 +1203,11 @@ class TestFilterNodeForm(MAASServerTestCase, FilterConstraintsMixin): | |||
3928 | 1203 | value: key for key, value in constraint_map[node.id].items() | 1203 | value: key for key, value in constraint_map[node.id].items() |
3929 | 1204 | } | 1204 | } |
3930 | 1205 | disk0 = node.blockdevice_set.get(id=constraints["root"]) | 1205 | disk0 = node.blockdevice_set.get(id=constraints["root"]) |
3932 | 1206 | self.assertEquals(virtual.id, disk0.id) | 1206 | self.assertEqual(virtual.id, disk0.id) |
3933 | 1207 | disk1 = node.blockdevice_set.get(id=constraints["physical"]) | 1207 | disk1 = node.blockdevice_set.get(id=constraints["physical"]) |
3935 | 1208 | self.assertEquals(physical.id, disk1.id) | 1208 | self.assertEqual(physical.id, disk1.id) |
3936 | 1209 | disk2 = node.blockdevice_set.get(id=constraints["iscsi"]) | 1209 | disk2 = node.blockdevice_set.get(id=constraints["iscsi"]) |
3938 | 1210 | self.assertEquals(iscsi.id, disk2.id) | 1210 | self.assertEqual(iscsi.id, disk2.id) |
3939 | 1211 | 1211 | ||
3940 | 1212 | def test_fabrics_constraint(self): | 1212 | def test_fabrics_constraint(self): |
3941 | 1213 | fabric1 = factory.make_Fabric(name="fabric1") | 1213 | fabric1 = factory.make_Fabric(name="fabric1") |
3942 | diff --git a/src/maasserver/tests/test_preseed.py b/src/maasserver/tests/test_preseed.py | |||
3943 | index dce8a02..8aacc00 100644 | |||
3944 | --- a/src/maasserver/tests/test_preseed.py | |||
3945 | +++ b/src/maasserver/tests/test_preseed.py | |||
3946 | @@ -472,7 +472,7 @@ class TestPreseedContext(MAASServerTestCase): | |||
3947 | 472 | remote_syslog = "192.168.1.1:514" | 472 | remote_syslog = "192.168.1.1:514" |
3948 | 473 | Config.objects.set_config("remote_syslog", remote_syslog) | 473 | Config.objects.set_config("remote_syslog", remote_syslog) |
3949 | 474 | context = get_preseed_context(make_HttpRequest()) | 474 | context = get_preseed_context(make_HttpRequest()) |
3951 | 475 | self.assertEquals(remote_syslog, context["syslog_host_port"]) | 475 | self.assertEqual(remote_syslog, context["syslog_host_port"]) |
3952 | 476 | 476 | ||
3953 | 477 | def test_get_preseed_context_uses_maas_syslog_port(self): | 477 | def test_get_preseed_context_uses_maas_syslog_port(self): |
3954 | 478 | syslog_port = factory.pick_port() | 478 | syslog_port = factory.pick_port() |
3955 | diff --git a/src/maasserver/tests/test_rack_controller.py b/src/maasserver/tests/test_rack_controller.py | |||
3956 | index ef255f9..01dda0c 100644 | |||
3957 | --- a/src/maasserver/tests/test_rack_controller.py | |||
3958 | +++ b/src/maasserver/tests/test_rack_controller.py | |||
3959 | @@ -212,8 +212,8 @@ class TestRackControllerService( | |||
3960 | 212 | listener.register(f"sys_dhcp_{rack_id}", service.dhcpHandler) | 212 | listener.register(f"sys_dhcp_{rack_id}", service.dhcpHandler) |
3961 | 213 | service.coreHandler("sys_core_%d" % processId, "unwatch_%d" % rack_id) | 213 | service.coreHandler("sys_core_%d" % processId, "unwatch_%d" % rack_id) |
3962 | 214 | self.assertNotIn(f"sys_dhcp_{rack_id}", listener.listeners) | 214 | self.assertNotIn(f"sys_dhcp_{rack_id}", listener.listeners) |
3965 | 215 | self.assertEquals(set(), service.watching) | 215 | self.assertEqual(set(), service.watching) |
3966 | 216 | self.assertEquals(set(), service.needsDHCPUpdate) | 216 | self.assertEqual(set(), service.needsDHCPUpdate) |
3967 | 217 | 217 | ||
3968 | 218 | def test_coreHandler_unwatch_doesnt_call_unregister(self): | 218 | def test_coreHandler_unwatch_doesnt_call_unregister(self): |
3969 | 219 | processId = random.randint(0, 100) | 219 | processId = random.randint(0, 100) |
3970 | @@ -240,8 +240,8 @@ class TestRackControllerService( | |||
3971 | 240 | dhcp_channel = f"sys_dhcp_{rack_id}" | 240 | dhcp_channel = f"sys_dhcp_{rack_id}" |
3972 | 241 | self.assertIn(dhcp_channel, listener.listeners) | 241 | self.assertIn(dhcp_channel, listener.listeners) |
3973 | 242 | self.assertIn(service.dhcpHandler, listener.listeners[dhcp_channel]) | 242 | self.assertIn(service.dhcpHandler, listener.listeners[dhcp_channel]) |
3976 | 243 | self.assertEquals(set([rack_id]), service.watching) | 243 | self.assertEqual(set([rack_id]), service.watching) |
3977 | 244 | self.assertEquals(set([rack_id]), service.needsDHCPUpdate) | 244 | self.assertEqual(set([rack_id]), service.needsDHCPUpdate) |
3978 | 245 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) | 245 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) |
3979 | 246 | 246 | ||
3980 | 247 | def test_coreHandler_watch_doesnt_call_register(self): | 247 | def test_coreHandler_watch_doesnt_call_register(self): |
3981 | @@ -256,8 +256,8 @@ class TestRackControllerService( | |||
3982 | 256 | service.coreHandler(sys_channel, "watch_%d" % rack_id) | 256 | service.coreHandler(sys_channel, "watch_%d" % rack_id) |
3983 | 257 | self.assertNotIn(sys_channel, listener.listeners) | 257 | self.assertNotIn(sys_channel, listener.listeners) |
3984 | 258 | self.assertNotIn(sys_channel, listener.registeredChannels) | 258 | self.assertNotIn(sys_channel, listener.registeredChannels) |
3987 | 259 | self.assertEquals(set([rack_id]), service.watching) | 259 | self.assertEqual(set([rack_id]), service.watching) |
3988 | 260 | self.assertEquals(set([rack_id]), service.needsDHCPUpdate) | 260 | self.assertEqual(set([rack_id]), service.needsDHCPUpdate) |
3989 | 261 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) | 261 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) |
3990 | 262 | 262 | ||
3991 | 263 | def test_coreHandler_raises_ValueError_for_unknown_action(self): | 263 | def test_coreHandler_raises_ValueError_for_unknown_action(self): |
3992 | @@ -278,7 +278,7 @@ class TestRackControllerService( | |||
3993 | 278 | service.watching = set([rack_id]) | 278 | service.watching = set([rack_id]) |
3994 | 279 | mock_startProcessing = self.patch(service, "startProcessing") | 279 | mock_startProcessing = self.patch(service, "startProcessing") |
3995 | 280 | service.dhcpHandler("sys_dhcp_%d" % rack_id, "") | 280 | service.dhcpHandler("sys_dhcp_%d" % rack_id, "") |
3997 | 281 | self.assertEquals(set([rack_id]), service.needsDHCPUpdate) | 281 | self.assertEqual(set([rack_id]), service.needsDHCPUpdate) |
3998 | 282 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) | 282 | self.assertThat(mock_startProcessing, MockCalledOnceWith()) |
3999 | 283 | 283 | ||
4000 | 284 | def test_dhcpHandler_doesnt_add_to_needsDHCPUpdate(self): | 284 | def test_dhcpHandler_doesnt_add_to_needsDHCPUpdate(self): |
4001 | @@ -287,7 +287,7 @@ class TestRackControllerService( | |||
4002 | 287 | service = RackControllerService(sentinel.ipcWorker, listener) | 287 | service = RackControllerService(sentinel.ipcWorker, listener) |
4003 | 288 | mock_startProcessing = self.patch(service, "startProcessing") | 288 | mock_startProcessing = self.patch(service, "startProcessing") |
4004 | 289 | service.dhcpHandler("sys_dhcp_%d" % rack_id, "") | 289 | service.dhcpHandler("sys_dhcp_%d" % rack_id, "") |
4006 | 290 | self.assertEquals(set(), service.needsDHCPUpdate) | 290 | self.assertEqual(set(), service.needsDHCPUpdate) |
4007 | 291 | self.assertThat(mock_startProcessing, MockNotCalled()) | 291 | self.assertThat(mock_startProcessing, MockNotCalled()) |
4008 | 292 | 292 | ||
4009 | 293 | def test_startProcessing_doesnt_call_start_when_looping_call_running(self): | 293 | def test_startProcessing_doesnt_call_start_when_looping_call_running(self): |
4010 | diff --git a/src/maasserver/tests/test_region_controller.py b/src/maasserver/tests/test_region_controller.py | |||
4011 | index 625314f..aad8dc5 100644 | |||
4012 | --- a/src/maasserver/tests/test_region_controller.py | |||
4013 | +++ b/src/maasserver/tests/test_region_controller.py | |||
4014 | @@ -554,7 +554,7 @@ class TestRegionControllerService(MAASServerTestCase): | |||
4015 | 554 | action=RBAC_ACTION.REMOVE, resource_id=4, resource_name="r-4" | 554 | action=RBAC_ACTION.REMOVE, resource_id=4, resource_name="r-4" |
4016 | 555 | ), | 555 | ), |
4017 | 556 | ] | 556 | ] |
4019 | 557 | self.assertEquals( | 557 | self.assertEqual( |
4020 | 558 | ( | 558 | ( |
4021 | 559 | [ | 559 | [ |
4022 | 560 | Resource(identifier=2, name="r-2"), | 560 | Resource(identifier=2, name="r-2"), |
4023 | @@ -704,7 +704,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase): | |||
4024 | 704 | service = RegionControllerService(sentinel.listener) | 704 | service = RegionControllerService(sentinel.listener) |
4025 | 705 | self.patch(service, "_getRBACClient").return_value = rbac_client | 705 | self.patch(service, "_getRBACClient").return_value = rbac_client |
4026 | 706 | 706 | ||
4028 | 707 | self.assertEquals([], service._rbacSync()) | 707 | self.assertEqual([], service._rbacSync()) |
4029 | 708 | self.assertThat( | 708 | self.assertThat( |
4030 | 709 | rbac_client.update_resources, | 709 | rbac_client.update_resources, |
4031 | 710 | MockCalledOnceWith("resource-pool", updates=resources), | 710 | MockCalledOnceWith("resource-pool", updates=resources), |
4032 | @@ -730,7 +730,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase): | |||
4033 | 730 | self.patch(service, "_getRBACClient").return_value = rbac_client | 730 | self.patch(service, "_getRBACClient").return_value = rbac_client |
4034 | 731 | service.rbacInit = True | 731 | service.rbacInit = True |
4035 | 732 | 732 | ||
4037 | 733 | self.assertEquals(reasons, service._rbacSync()) | 733 | self.assertEqual(reasons, service._rbacSync()) |
4038 | 734 | self.assertThat( | 734 | self.assertThat( |
4039 | 735 | rbac_client.update_resources, | 735 | rbac_client.update_resources, |
4040 | 736 | MockCalledOnceWith( | 736 | MockCalledOnceWith( |
4041 | @@ -764,7 +764,7 @@ class TestRegionControllerServiceTransactional(MAASTransactionServerTestCase): | |||
4042 | 764 | self.patch(service, "_getRBACClient").return_value = rbac_client | 764 | self.patch(service, "_getRBACClient").return_value = rbac_client |
4043 | 765 | service.rbacInit = True | 765 | service.rbacInit = True |
4044 | 766 | 766 | ||
4046 | 767 | self.assertEquals(reasons, service._rbacSync()) | 767 | self.assertEqual(reasons, service._rbacSync()) |
4047 | 768 | self.assertThat( | 768 | self.assertThat( |
4048 | 769 | rbac_client.update_resources, | 769 | rbac_client.update_resources, |
4049 | 770 | MockCallsMatch( | 770 | MockCallsMatch( |
4050 | diff --git a/src/maasserver/tests/test_start_up.py b/src/maasserver/tests/test_start_up.py | |||
4051 | index 0ef1397..30b267c 100644 | |||
4052 | --- a/src/maasserver/tests/test_start_up.py | |||
4053 | +++ b/src/maasserver/tests/test_start_up.py | |||
4054 | @@ -127,7 +127,7 @@ class TestInnerStartUp(MAASServerTestCase): | |||
4055 | 127 | with post_commit_hooks: | 127 | with post_commit_hooks: |
4056 | 128 | start_up.inner_start_up(master=True) | 128 | start_up.inner_start_up(master=True) |
4057 | 129 | ubuntu = UbuntuOS() | 129 | ubuntu = UbuntuOS() |
4059 | 130 | self.assertEquals( | 130 | self.assertEqual( |
4060 | 131 | Config.objects.get_config("commissioning_distro_series"), | 131 | Config.objects.get_config("commissioning_distro_series"), |
4061 | 132 | ubuntu.get_default_commissioning_release(), | 132 | ubuntu.get_default_commissioning_release(), |
4062 | 133 | ) | 133 | ) |
4063 | @@ -142,7 +142,7 @@ class TestInnerStartUp(MAASServerTestCase): | |||
4064 | 142 | Config.objects.set_config("commissioning_distro_series", release) | 142 | Config.objects.set_config("commissioning_distro_series", release) |
4065 | 143 | with post_commit_hooks: | 143 | with post_commit_hooks: |
4066 | 144 | start_up.inner_start_up(master=False) | 144 | start_up.inner_start_up(master=False) |
4068 | 145 | self.assertEquals( | 145 | self.assertEqual( |
4069 | 146 | Config.objects.get_config("commissioning_distro_series"), release | 146 | Config.objects.get_config("commissioning_distro_series"), release |
4070 | 147 | ) | 147 | ) |
4071 | 148 | self.assertFalse( | 148 | self.assertFalse( |
4072 | diff --git a/src/maasserver/tests/test_stats.py b/src/maasserver/tests/test_stats.py | |||
4073 | index 3a74a20..7c5f886 100644 | |||
4074 | --- a/src/maasserver/tests/test_stats.py | |||
4075 | +++ b/src/maasserver/tests/test_stats.py | |||
4076 | @@ -67,7 +67,7 @@ class TestMAASStats(MAASServerTestCase): | |||
4077 | 67 | factory.make_Machine(architecture=arch) | 67 | factory.make_Machine(architecture=arch) |
4078 | 68 | stats = get_machines_by_architecture() | 68 | stats = get_machines_by_architecture() |
4079 | 69 | compare = {"amd64": 1, "i386": 1, "arm64": 1, "ppc64el": 1, "s390x": 1} | 69 | compare = {"amd64": 1, "i386": 1, "arm64": 1, "ppc64el": 1, "s390x": 1} |
4081 | 70 | self.assertEquals(stats, compare) | 70 | self.assertEqual(stats, compare) |
4082 | 71 | 71 | ||
4083 | 72 | def test_get_kvm_pods_stats(self): | 72 | def test_get_kvm_pods_stats(self): |
4084 | 73 | pod1 = self.make_pod( | 73 | pod1 = self.make_pod( |
4085 | @@ -101,7 +101,7 @@ class TestMAASStats(MAASServerTestCase): | |||
4086 | 101 | }, | 101 | }, |
4087 | 102 | "kvm_utilized_resources": {"cores": 0, "memory": 0, "storage": 0}, | 102 | "kvm_utilized_resources": {"cores": 0, "memory": 0, "storage": 0}, |
4088 | 103 | } | 103 | } |
4090 | 104 | self.assertEquals(compare, stats) | 104 | self.assertEqual(compare, stats) |
4091 | 105 | 105 | ||
4092 | 106 | def test_get_kvm_pods_stats_no_pod(self): | 106 | def test_get_kvm_pods_stats_no_pod(self): |
4093 | 107 | self.assertEqual( | 107 | self.assertEqual( |
4094 | @@ -183,7 +183,7 @@ class TestMAASStats(MAASServerTestCase): | |||
4095 | 183 | "subnets_v6": len(v6), | 183 | "subnets_v6": len(v6), |
4096 | 184 | }, | 184 | }, |
4097 | 185 | } | 185 | } |
4099 | 186 | self.assertEquals(json.loads(stats), expected) | 186 | self.assertEqual(json.loads(stats), expected) |
4100 | 187 | 187 | ||
4101 | 188 | def test_get_maas_stats_no_machines(self): | 188 | def test_get_maas_stats_no_machines(self): |
4102 | 189 | expected = { | 189 | expected = { |
4103 | @@ -224,7 +224,7 @@ class TestMAASStats(MAASServerTestCase): | |||
4104 | 224 | json.dumps(get_maas_stats()).encode() | 224 | json.dumps(get_maas_stats()).encode() |
4105 | 225 | ).decode() | 225 | ).decode() |
4106 | 226 | } | 226 | } |
4108 | 227 | self.assertEquals(params, get_request_params()) | 227 | self.assertEqual(params, get_request_params()) |
4109 | 228 | 228 | ||
4110 | 229 | def test_make_user_agent_request(self): | 229 | def test_make_user_agent_request(self): |
4111 | 230 | factory.make_RegionRackController() | 230 | factory.make_RegionRackController() |
4112 | diff --git a/src/maasserver/tests/test_status_monitor.py b/src/maasserver/tests/test_status_monitor.py | |||
4113 | index c89342c..09b3ad5 100644 | |||
4114 | --- a/src/maasserver/tests/test_status_monitor.py | |||
4115 | +++ b/src/maasserver/tests/test_status_monitor.py | |||
4116 | @@ -55,7 +55,7 @@ class TestMarkNodesFailedAfterExpiring(MAASServerTestCase): | |||
4117 | 55 | ) | 55 | ) |
4118 | 56 | # MAAS logs in the status_monitor that the timeout was detected. It | 56 | # MAAS logs in the status_monitor that the timeout was detected. It |
4119 | 57 | # then logs the transisition in the node signal handler. | 57 | # then logs the transisition in the node signal handler. |
4121 | 58 | self.assertEquals( | 58 | self.assertEqual( |
4122 | 59 | len(NODE_FAILURE_MONITORED_STATUS_TRANSITIONS), | 59 | len(NODE_FAILURE_MONITORED_STATUS_TRANSITIONS), |
4123 | 60 | len(maaslog.call_args_list) / 2, | 60 | len(maaslog.call_args_list) / 2, |
4124 | 61 | ) | 61 | ) |
4125 | @@ -128,7 +128,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4126 | 128 | # No exception should be raised. | 128 | # No exception should be raised. |
4127 | 129 | mark_nodes_failed_after_missing_script_timeout(now(), 20) | 129 | mark_nodes_failed_after_missing_script_timeout(now(), 20) |
4128 | 130 | node = reload_object(node) | 130 | node = reload_object(node) |
4130 | 131 | self.assertEquals(self.status, node.status) | 131 | self.assertEqual(self.status, node.status) |
4131 | 132 | self.assertThat(self.maaslog, MockNotCalled()) | 132 | self.assertThat(self.maaslog, MockNotCalled()) |
4132 | 133 | 133 | ||
4133 | 134 | def test_mark_nodes_failed_after_missing_timeout_heartbeat(self): | 134 | def test_mark_nodes_failed_after_missing_timeout_heartbeat(self): |
4134 | @@ -151,8 +151,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4135 | 151 | ) | 151 | ) |
4136 | 152 | node = reload_object(node) | 152 | node = reload_object(node) |
4137 | 153 | 153 | ||
4140 | 154 | self.assertEquals(self.failed_status, node.status) | 154 | self.assertEqual(self.failed_status, node.status) |
4141 | 155 | self.assertEquals( | 155 | self.assertEqual( |
4142 | 156 | "Node has not been heard from for the last %s minutes" | 156 | "Node has not been heard from for the last %s minutes" |
4143 | 157 | % node_timeout, | 157 | % node_timeout, |
4144 | 158 | node.error_description, | 158 | node.error_description, |
4145 | @@ -173,7 +173,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4146 | 173 | self.maaslog.call_args_list, | 173 | self.maaslog.call_args_list, |
4147 | 174 | ) | 174 | ) |
4148 | 175 | for script_result in script_results: | 175 | for script_result in script_results: |
4150 | 176 | self.assertEquals( | 176 | self.assertEqual( |
4151 | 177 | SCRIPT_STATUS.TIMEDOUT, reload_object(script_result).status | 177 | SCRIPT_STATUS.TIMEDOUT, reload_object(script_result).status |
4152 | 178 | ) | 178 | ) |
4153 | 179 | 179 | ||
4154 | @@ -194,7 +194,7 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4155 | 194 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) | 194 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) |
4156 | 195 | node = reload_object(node) | 195 | node = reload_object(node) |
4157 | 196 | 196 | ||
4159 | 197 | self.assertEquals( | 197 | self.assertEqual( |
4160 | 198 | current_time | 198 | current_time |
4161 | 199 | - (current_time - script_set.last_ping) | 199 | - (current_time - script_set.last_ping) |
4162 | 200 | + timedelta(minutes=get_node_timeout(self.status, 20)), | 200 | + timedelta(minutes=get_node_timeout(self.status, 20)), |
4163 | @@ -226,8 +226,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4164 | 226 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) | 226 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) |
4165 | 227 | node = reload_object(node) | 227 | node = reload_object(node) |
4166 | 228 | 228 | ||
4169 | 229 | self.assertEquals(self.failed_status, node.status) | 229 | self.assertEqual(self.failed_status, node.status) |
4170 | 230 | self.assertEquals( | 230 | self.assertEqual( |
4171 | 231 | "%s has run past it's timeout(%s)" | 231 | "%s has run past it's timeout(%s)" |
4172 | 232 | % ( | 232 | % ( |
4173 | 233 | running_script_result.name, | 233 | running_script_result.name, |
4174 | @@ -254,16 +254,16 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4175 | 254 | call("%s: Stopped because SSH is disabled" % node.hostname), | 254 | call("%s: Stopped because SSH is disabled" % node.hostname), |
4176 | 255 | self.maaslog.call_args_list, | 255 | self.maaslog.call_args_list, |
4177 | 256 | ) | 256 | ) |
4179 | 257 | self.assertEquals( | 257 | self.assertEqual( |
4180 | 258 | SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status | 258 | SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status |
4181 | 259 | ) | 259 | ) |
4183 | 260 | self.assertEquals( | 260 | self.assertEqual( |
4184 | 261 | SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status | 261 | SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status |
4185 | 262 | ) | 262 | ) |
4187 | 263 | self.assertEquals( | 263 | self.assertEqual( |
4188 | 264 | SCRIPT_STATUS.ABORTED, reload_object(pending_script_result).status | 264 | SCRIPT_STATUS.ABORTED, reload_object(pending_script_result).status |
4189 | 265 | ) | 265 | ) |
4191 | 266 | self.assertEquals( | 266 | self.assertEqual( |
4192 | 267 | SCRIPT_STATUS.TIMEDOUT, reload_object(running_script_result).status | 267 | SCRIPT_STATUS.TIMEDOUT, reload_object(running_script_result).status |
4193 | 268 | ) | 268 | ) |
4194 | 269 | 269 | ||
4195 | @@ -293,18 +293,18 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4196 | 293 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) | 293 | mark_nodes_failed_after_missing_script_timeout(current_time, 20) |
4197 | 294 | node = reload_object(node) | 294 | node = reload_object(node) |
4198 | 295 | 295 | ||
4200 | 296 | self.assertEquals(self.status, node.status) | 296 | self.assertEqual(self.status, node.status) |
4201 | 297 | self.assertThat(self.mock_stop, MockNotCalled()) | 297 | self.assertThat(self.mock_stop, MockNotCalled()) |
4203 | 298 | self.assertEquals( | 298 | self.assertEqual( |
4204 | 299 | SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status | 299 | SCRIPT_STATUS.PASSED, reload_object(passed_script_result).status |
4205 | 300 | ) | 300 | ) |
4207 | 301 | self.assertEquals( | 301 | self.assertEqual( |
4208 | 302 | SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status | 302 | SCRIPT_STATUS.FAILED, reload_object(failed_script_result).status |
4209 | 303 | ) | 303 | ) |
4211 | 304 | self.assertEquals( | 304 | self.assertEqual( |
4212 | 305 | SCRIPT_STATUS.PENDING, reload_object(pending_script_result).status | 305 | SCRIPT_STATUS.PENDING, reload_object(pending_script_result).status |
4213 | 306 | ) | 306 | ) |
4215 | 307 | self.assertEquals( | 307 | self.assertEqual( |
4216 | 308 | SCRIPT_STATUS.RUNNING, reload_object(running_script_result).status | 308 | SCRIPT_STATUS.RUNNING, reload_object(running_script_result).status |
4217 | 309 | ) | 309 | ) |
4218 | 310 | 310 | ||
4219 | @@ -352,8 +352,8 @@ class TestMarkNodesFailedAfterMissingScriptTimeout(MAASServerTestCase): | |||
4220 | 352 | # 5. Get all testing ScriptResults | 352 | # 5. Get all testing ScriptResults |
4221 | 353 | # 6. Get all commissioning Scripts | 353 | # 6. Get all commissioning Scripts |
4222 | 354 | # 7. Get all testing Scripts | 354 | # 7. Get all testing Scripts |
4225 | 355 | self.assertEquals(7, counter_one.num_queries) | 355 | self.assertEqual(7, counter_one.num_queries) |
4226 | 356 | self.assertEquals(7, counter_many.num_queries) | 356 | self.assertEqual(7, counter_many.num_queries) |
4227 | 357 | 357 | ||
4228 | 358 | 358 | ||
4229 | 359 | class TestStatusMonitorService(MAASServerTestCase): | 359 | class TestStatusMonitorService(MAASServerTestCase): |
4230 | diff --git a/src/maasserver/tests/test_storage_layouts.py b/src/maasserver/tests/test_storage_layouts.py | |||
4231 | index a15d202..29dcffa 100644 | |||
4232 | --- a/src/maasserver/tests/test_storage_layouts.py | |||
4233 | +++ b/src/maasserver/tests/test_storage_layouts.py | |||
4234 | @@ -120,13 +120,13 @@ class TestGetAppliedStorageLayoutForNode(MAASServerTestCase): | |||
4235 | 120 | ) | 120 | ) |
4236 | 121 | layout = self.layout_class(node) | 121 | layout = self.layout_class(node) |
4237 | 122 | layout.configure() | 122 | layout.configure() |
4239 | 123 | self.assertEquals( | 123 | self.assertEqual( |
4240 | 124 | (bd, self.layout_name), get_applied_storage_layout_for_node(node) | 124 | (bd, self.layout_name), get_applied_storage_layout_for_node(node) |
4241 | 125 | ) | 125 | ) |
4242 | 126 | 126 | ||
4243 | 127 | def test_returns_unknown(self): | 127 | def test_returns_unknown(self): |
4244 | 128 | node = factory.make_Node() | 128 | node = factory.make_Node() |
4246 | 129 | self.assertEquals( | 129 | self.assertEqual( |
4247 | 130 | (None, "unknown"), get_applied_storage_layout_for_node(node) | 130 | (None, "unknown"), get_applied_storage_layout_for_node(node) |
4248 | 131 | ) | 131 | ) |
4249 | 132 | 132 | ||
4250 | @@ -418,7 +418,7 @@ class TestStorageLayoutBase(MAASServerTestCase): | |||
4251 | 418 | factory.make_PhysicalBlockDevice(node=node, size=LARGE_BLOCK_DEVICE) | 418 | factory.make_PhysicalBlockDevice(node=node, size=LARGE_BLOCK_DEVICE) |
4252 | 419 | layout = StorageLayoutBase(node, {}) | 419 | layout = StorageLayoutBase(node, {}) |
4253 | 420 | self.assertTrue(layout.is_valid(), layout.errors) | 420 | self.assertTrue(layout.is_valid(), layout.errors) |
4255 | 421 | self.assertEquals(node.get_boot_disk(), layout.get_root_device()) | 421 | self.assertEqual(node.get_boot_disk(), layout.get_root_device()) |
4256 | 422 | 422 | ||
4257 | 423 | def test_get_root_device_returns_root_device_if_set(self): | 423 | def test_get_root_device_returns_root_device_if_set(self): |
4258 | 424 | node = make_Node_with_uefi_boot_method() | 424 | node = make_Node_with_uefi_boot_method() |
4259 | @@ -959,7 +959,7 @@ class TestFlatStorageLayout(MAASServerTestCase, LayoutHelpersMixin): | |||
4260 | 959 | ) | 959 | ) |
4261 | 960 | layout = FlatStorageLayout(node) | 960 | layout = FlatStorageLayout(node) |
4262 | 961 | layout.configure() | 961 | layout.configure() |
4264 | 962 | self.assertEquals(bd, layout.is_layout()) | 962 | self.assertEqual(bd, layout.is_layout()) |
4265 | 963 | 963 | ||
4266 | 964 | def test_is_layout_without_uefi(self): | 964 | def test_is_layout_without_uefi(self): |
4267 | 965 | node = make_arm64_Node_without_uefi_boot_method() | 965 | node = make_arm64_Node_without_uefi_boot_method() |
4268 | @@ -968,7 +968,7 @@ class TestFlatStorageLayout(MAASServerTestCase, LayoutHelpersMixin): | |||
4269 | 968 | ) | 968 | ) |
4270 | 969 | layout = FlatStorageLayout(node) | 969 | layout = FlatStorageLayout(node) |
4271 | 970 | layout.configure() | 970 | layout.configure() |
4273 | 971 | self.assertEquals(bd, layout.is_layout()) | 971 | self.assertEqual(bd, layout.is_layout()) |
4274 | 972 | 972 | ||
4275 | 973 | def test_is_layout_returns_none_when_not_found(self): | 973 | def test_is_layout_returns_none_when_not_found(self): |
4276 | 974 | node = make_Node_with_uefi_boot_method() | 974 | node = make_Node_with_uefi_boot_method() |
4277 | @@ -1275,7 +1275,7 @@ class TestLVMStorageLayout(MAASServerTestCase, LayoutHelpersMixin): | |||
4278 | 1275 | ) | 1275 | ) |
4279 | 1276 | layout = LVMStorageLayout(node) | 1276 | layout = LVMStorageLayout(node) |
4280 | 1277 | layout.configure() | 1277 | layout.configure() |
4282 | 1278 | self.assertEquals(bd, layout.is_layout()) | 1278 | self.assertEqual(bd, layout.is_layout()) |
4283 | 1279 | 1279 | ||
4284 | 1280 | def test_is_layout_without_uefi(self): | 1280 | def test_is_layout_without_uefi(self): |
4285 | 1281 | node = make_arm64_Node_without_uefi_boot_method() | 1281 | node = make_arm64_Node_without_uefi_boot_method() |
4286 | @@ -1284,7 +1284,7 @@ class TestLVMStorageLayout(MAASServerTestCase, LayoutHelpersMixin): | |||
4287 | 1284 | ) | 1284 | ) |
4288 | 1285 | layout = LVMStorageLayout(node) | 1285 | layout = LVMStorageLayout(node) |
4289 | 1286 | layout.configure() | 1286 | layout.configure() |
4291 | 1287 | self.assertEquals(bd, layout.is_layout()) | 1287 | self.assertEqual(bd, layout.is_layout()) |
4292 | 1288 | 1288 | ||
4293 | 1289 | def test_is_layout_returns_none_when_not_found(self): | 1289 | def test_is_layout_returns_none_when_not_found(self): |
4294 | 1290 | node = make_Node_with_uefi_boot_method() | 1290 | node = make_Node_with_uefi_boot_method() |
4295 | @@ -1805,7 +1805,7 @@ class TestBcacheStorageLayout(MAASServerTestCase): | |||
4296 | 1805 | ) | 1805 | ) |
4297 | 1806 | layout = BcacheStorageLayout(node) | 1806 | layout = BcacheStorageLayout(node) |
4298 | 1807 | layout.configure() | 1807 | layout.configure() |
4300 | 1808 | self.assertEquals(bd, layout.is_layout()) | 1808 | self.assertEqual(bd, layout.is_layout()) |
4301 | 1809 | 1809 | ||
4302 | 1810 | def test_is_layout_without_uefi(self): | 1810 | def test_is_layout_without_uefi(self): |
4303 | 1811 | node = make_arm64_Node_without_uefi_boot_method() | 1811 | node = make_arm64_Node_without_uefi_boot_method() |
4304 | @@ -1817,7 +1817,7 @@ class TestBcacheStorageLayout(MAASServerTestCase): | |||
4305 | 1817 | ) | 1817 | ) |
4306 | 1818 | layout = BcacheStorageLayout(node, {"cache_no_part": True}) | 1818 | layout = BcacheStorageLayout(node, {"cache_no_part": True}) |
4307 | 1819 | layout.configure() | 1819 | layout.configure() |
4309 | 1820 | self.assertEquals(bd, layout.is_layout()) | 1820 | self.assertEqual(bd, layout.is_layout()) |
4310 | 1821 | 1821 | ||
4311 | 1822 | def test_is_layout_returns_none_when_not_found(self): | 1822 | def test_is_layout_returns_none_when_not_found(self): |
4312 | 1823 | node = make_Node_with_uefi_boot_method() | 1823 | node = make_Node_with_uefi_boot_method() |
4313 | @@ -1953,7 +1953,7 @@ class TestVMFS6StorageLayout(MAASServerTestCase): | |||
4314 | 1953 | ) | 1953 | ) |
4315 | 1954 | layout = VMFS6StorageLayout(node) | 1954 | layout = VMFS6StorageLayout(node) |
4316 | 1955 | layout.configure() | 1955 | layout.configure() |
4318 | 1956 | self.assertEquals(bd, layout.is_layout()) | 1956 | self.assertEqual(bd, layout.is_layout()) |
4319 | 1957 | 1957 | ||
4320 | 1958 | def test_is_layout_without_datastore(self): | 1958 | def test_is_layout_without_datastore(self): |
4321 | 1959 | node = make_Node_with_uefi_boot_method() | 1959 | node = make_Node_with_uefi_boot_method() |
4322 | @@ -1965,7 +1965,7 @@ class TestVMFS6StorageLayout(MAASServerTestCase): | |||
4323 | 1965 | # A user can delete the VMFS Datastore but the layout should still | 1965 | # A user can delete the VMFS Datastore but the layout should still |
4324 | 1966 | # be detected for the UI. | 1966 | # be detected for the UI. |
4325 | 1967 | node.virtualblockdevice_set.delete() | 1967 | node.virtualblockdevice_set.delete() |
4327 | 1968 | self.assertEquals(bd, layout.is_layout()) | 1968 | self.assertEqual(bd, layout.is_layout()) |
4328 | 1969 | 1969 | ||
4329 | 1970 | def test_is_layout_returns_none_when_not_found(self): | 1970 | def test_is_layout_returns_none_when_not_found(self): |
4330 | 1971 | node = make_Node_with_uefi_boot_method() | 1971 | node = make_Node_with_uefi_boot_method() |
4331 | @@ -2007,8 +2007,8 @@ class TestBlankStorageLayout(MAASServerTestCase): | |||
4332 | 2007 | layout = BlankStorageLayout(node) | 2007 | layout = BlankStorageLayout(node) |
4333 | 2008 | if self.layout_class != BlankStorageLayout: | 2008 | if self.layout_class != BlankStorageLayout: |
4334 | 2009 | self.assertIsNone(layout.is_layout()) | 2009 | self.assertIsNone(layout.is_layout()) |
4337 | 2010 | self.assertEquals("blank", layout.configure()) | 2010 | self.assertEqual("blank", layout.configure()) |
4338 | 2011 | self.assertEquals(bd, layout.is_layout()) | 2011 | self.assertEqual(bd, layout.is_layout()) |
4339 | 2012 | self.assertFalse(node.virtualblockdevice_set.exists()) | 2012 | self.assertFalse(node.virtualblockdevice_set.exists()) |
4340 | 2013 | for bd in node.blockdevice_set.all(): | 2013 | for bd in node.blockdevice_set.all(): |
4341 | 2014 | self.assertFalse(bd.filesystem_set.exists()) | 2014 | self.assertFalse(bd.filesystem_set.exists()) |
4342 | diff --git a/src/maasserver/tests/test_workers.py b/src/maasserver/tests/test_workers.py | |||
4343 | index d9cfe0c..e0575ff 100644 | |||
4344 | --- a/src/maasserver/tests/test_workers.py | |||
4345 | +++ b/src/maasserver/tests/test_workers.py | |||
4346 | @@ -29,14 +29,14 @@ class TestWorkersCount(MAASTestCase): | |||
4347 | 29 | def test_MAX_WORKERS_COUNT_default_cpucount(self): | 29 | def test_MAX_WORKERS_COUNT_default_cpucount(self): |
4348 | 30 | from maasserver.workers import MAX_WORKERS_COUNT | 30 | from maasserver.workers import MAX_WORKERS_COUNT |
4349 | 31 | 31 | ||
4351 | 32 | self.assertEquals(os.cpu_count(), MAX_WORKERS_COUNT) | 32 | self.assertEqual(os.cpu_count(), MAX_WORKERS_COUNT) |
4352 | 33 | 33 | ||
4353 | 34 | def test_set_max_workers_count(self): | 34 | def test_set_max_workers_count(self): |
4354 | 35 | worker_count = random.randint(1, 8) | 35 | worker_count = random.randint(1, 8) |
4355 | 36 | set_max_workers_count(worker_count) | 36 | set_max_workers_count(worker_count) |
4356 | 37 | from maasserver.workers import MAX_WORKERS_COUNT | 37 | from maasserver.workers import MAX_WORKERS_COUNT |
4357 | 38 | 38 | ||
4359 | 39 | self.assertEquals(worker_count, MAX_WORKERS_COUNT) | 39 | self.assertEqual(worker_count, MAX_WORKERS_COUNT) |
4360 | 40 | 40 | ||
4361 | 41 | 41 | ||
4362 | 42 | class TestWorkersService(MAASTestCase): | 42 | class TestWorkersService(MAASTestCase): |
4363 | @@ -47,8 +47,8 @@ class TestWorkersService(MAASTestCase): | |||
4364 | 47 | 47 | ||
4365 | 48 | from maasserver.workers import MAX_WORKERS_COUNT | 48 | from maasserver.workers import MAX_WORKERS_COUNT |
4366 | 49 | 49 | ||
4369 | 50 | self.assertEquals(MAX_WORKERS_COUNT, service.worker_count) | 50 | self.assertEqual(MAX_WORKERS_COUNT, service.worker_count) |
4370 | 51 | self.assertEquals(sys.argv[0], service.worker_cmd) | 51 | self.assertEqual(sys.argv[0], service.worker_cmd) |
4371 | 52 | 52 | ||
4372 | 53 | def test_calls_spawnWorkers_on_start(self): | 53 | def test_calls_spawnWorkers_on_start(self): |
4373 | 54 | service = WorkersService(reactor) | 54 | service = WorkersService(reactor) |
4374 | @@ -87,12 +87,12 @@ class TestWorkersService(MAASTestCase): | |||
4375 | 87 | try: | 87 | try: |
4376 | 88 | service.startService() | 88 | service.startService() |
4377 | 89 | 89 | ||
4379 | 90 | self.assertEquals(1, len(service.workers)) | 90 | self.assertEqual(1, len(service.workers)) |
4380 | 91 | pid = list(service.workers.keys())[0] | 91 | pid = list(service.workers.keys())[0] |
4381 | 92 | service.killWorker(pid) | 92 | service.killWorker(pid) |
4382 | 93 | yield dv.get(timeout=2) | 93 | yield dv.get(timeout=2) |
4383 | 94 | self.assertNotIn(pid, service.workers) | 94 | self.assertNotIn(pid, service.workers) |
4385 | 95 | self.assertEquals(1, len(service.workers)) | 95 | self.assertEqual(1, len(service.workers)) |
4386 | 96 | finally: | 96 | finally: |
4387 | 97 | service.stopService() | 97 | service.stopService() |
4388 | 98 | 98 | ||
4389 | @@ -115,12 +115,12 @@ class TestWorkersService(MAASTestCase): | |||
4390 | 115 | try: | 115 | try: |
4391 | 116 | service.startService() | 116 | service.startService() |
4392 | 117 | 117 | ||
4394 | 118 | self.assertEquals(1, len(service.workers)) | 118 | self.assertEqual(1, len(service.workers)) |
4395 | 119 | pid = list(service.workers.keys())[0] | 119 | pid = list(service.workers.keys())[0] |
4396 | 120 | service.termWorker(pid) | 120 | service.termWorker(pid) |
4397 | 121 | yield dv.get(timeout=2) | 121 | yield dv.get(timeout=2) |
4398 | 122 | self.assertNotIn(pid, service.workers) | 122 | self.assertNotIn(pid, service.workers) |
4400 | 123 | self.assertEquals(1, len(service.workers)) | 123 | self.assertEqual(1, len(service.workers)) |
4401 | 124 | finally: | 124 | finally: |
4402 | 125 | service.stopService() | 125 | service.stopService() |
4403 | 126 | 126 | ||
4404 | @@ -142,7 +142,7 @@ class TestWorkersService(MAASTestCase): | |||
4405 | 142 | 142 | ||
4406 | 143 | try: | 143 | try: |
4407 | 144 | service.startService() | 144 | service.startService() |
4409 | 145 | self.assertEquals(1, len(service.workers)) | 145 | self.assertEqual(1, len(service.workers)) |
4410 | 146 | finally: | 146 | finally: |
4411 | 147 | service.stopService() | 147 | service.stopService() |
4412 | 148 | 148 | ||
4413 | diff --git a/src/maasserver/triggers/tests/test_system_listener.py b/src/maasserver/triggers/tests/test_system_listener.py | |||
4414 | index 1573f02..6189c4c 100644 | |||
4415 | --- a/src/maasserver/triggers/tests/test_system_listener.py | |||
4416 | +++ b/src/maasserver/triggers/tests/test_system_listener.py | |||
4417 | @@ -4104,7 +4104,7 @@ class TestDNSDNSResourceListener( | |||
4418 | 4104 | for pub in DNSPublication.objects.order_by("-id")[:2] | 4104 | for pub in DNSPublication.objects.order_by("-id")[:2] |
4419 | 4105 | ] | 4105 | ] |
4420 | 4106 | ) | 4106 | ) |
4422 | 4107 | self.assertEquals( | 4107 | self.assertEqual( |
4423 | 4108 | list(sources), | 4108 | list(sources), |
4424 | 4109 | [ | 4109 | [ |
4425 | 4110 | "zone %s removed resource %s" | 4110 | "zone %s removed resource %s" |
4426 | @@ -4683,7 +4683,7 @@ class TestDNSInterfaceListener( | |||
4427 | 4683 | for pub in DNSPublication.objects.order_by("-id")[:2] | 4683 | for pub in DNSPublication.objects.order_by("-id")[:2] |
4428 | 4684 | ] | 4684 | ] |
4429 | 4685 | ) | 4685 | ) |
4431 | 4686 | self.assertEquals( | 4686 | self.assertEqual( |
4432 | 4687 | list(sources), | 4687 | list(sources), |
4433 | 4688 | [ | 4688 | [ |
4434 | 4689 | "node %s removed interface %s" % (old_hostname, nic_name), | 4689 | "node %s removed interface %s" % (old_hostname, nic_name), |
4435 | diff --git a/src/maasserver/utils/tests/test_osystems.py b/src/maasserver/utils/tests/test_osystems.py | |||
4436 | index ef11c9f..541ee16 100644 | |||
4437 | --- a/src/maasserver/utils/tests/test_osystems.py | |||
4438 | +++ b/src/maasserver/utils/tests/test_osystems.py | |||
4439 | @@ -590,7 +590,7 @@ class TestGetReleaseVersionFromString(MAASServerTestCase): | |||
4440 | 590 | ) | 590 | ) |
4441 | 591 | 591 | ||
4442 | 592 | def test_get_release_version_from_string(self): | 592 | def test_get_release_version_from_string(self): |
4444 | 593 | self.assertEquals( | 593 | self.assertEqual( |
4445 | 594 | self.expected, get_release_version_from_string(self.string) | 594 | self.expected, get_release_version_from_string(self.string) |
4446 | 595 | ) | 595 | ) |
4447 | 596 | 596 | ||
4448 | @@ -786,7 +786,7 @@ class TestValidateHweKernel(MAASServerTestCase): | |||
4449 | 786 | None, "hwe-16.04-edge", "%s/generic" % arch, "ubuntu", "xenial" | 786 | None, "hwe-16.04-edge", "%s/generic" % arch, "ubuntu", "xenial" |
4450 | 787 | ) | 787 | ) |
4451 | 788 | 788 | ||
4453 | 789 | self.assertEquals("hwe-16.04-edge", kernel) | 789 | self.assertEqual("hwe-16.04-edge", kernel) |
4454 | 790 | self.assertThat( | 790 | self.assertThat( |
4455 | 791 | mock_get_usable_hwe_kernels, | 791 | mock_get_usable_hwe_kernels, |
4456 | 792 | MockCalledOnceWith("ubuntu/xenial", arch, "generic"), | 792 | MockCalledOnceWith("ubuntu/xenial", arch, "generic"), |
4457 | @@ -799,10 +799,10 @@ class TestValidateMinHweKernel(MAASServerTestCase): | |||
4458 | 799 | self.patch( | 799 | self.patch( |
4459 | 800 | BootResource.objects, "get_supported_hwe_kernels" | 800 | BootResource.objects, "get_supported_hwe_kernels" |
4460 | 801 | ).return_value = (kernel,) | 801 | ).return_value = (kernel,) |
4462 | 802 | self.assertEquals(kernel, validate_min_hwe_kernel(kernel)) | 802 | self.assertEqual(kernel, validate_min_hwe_kernel(kernel)) |
4463 | 803 | 803 | ||
4464 | 804 | def test_returns_empty_string_when_none(self): | 804 | def test_returns_empty_string_when_none(self): |
4466 | 805 | self.assertEquals("", validate_min_hwe_kernel(None)) | 805 | self.assertEqual("", validate_min_hwe_kernel(None)) |
4467 | 806 | 806 | ||
4468 | 807 | def test_raises_exception_when_not_found(self): | 807 | def test_raises_exception_when_not_found(self): |
4469 | 808 | self.assertRaises( | 808 | self.assertRaises( |
4470 | @@ -886,21 +886,21 @@ class TestGetReleaseFromDB(MAASServerTestCase): | |||
4471 | 886 | 886 | ||
4472 | 887 | def test_finds_by_subarch(self): | 887 | def test_finds_by_subarch(self): |
4473 | 888 | release = self.make_boot_source_cache() | 888 | release = self.make_boot_source_cache() |
4475 | 889 | self.assertEquals( | 889 | self.assertEqual( |
4476 | 890 | release["series"], | 890 | release["series"], |
4477 | 891 | get_release_from_db(release["version"].split(" ")[0])["series"], | 891 | get_release_from_db(release["version"].split(" ")[0])["series"], |
4478 | 892 | ) | 892 | ) |
4479 | 893 | 893 | ||
4480 | 894 | def test_finds_by_release(self): | 894 | def test_finds_by_release(self): |
4481 | 895 | release = self.make_boot_source_cache() | 895 | release = self.make_boot_source_cache() |
4483 | 896 | self.assertEquals( | 896 | self.assertEqual( |
4484 | 897 | release["version"], | 897 | release["version"], |
4485 | 898 | get_release_from_db(release["series"])["version"], | 898 | get_release_from_db(release["series"])["version"], |
4486 | 899 | ) | 899 | ) |
4487 | 900 | 900 | ||
4488 | 901 | def test_finds_by_release_first_letter(self): | 901 | def test_finds_by_release_first_letter(self): |
4489 | 902 | release = self.make_boot_source_cache() | 902 | release = self.make_boot_source_cache() |
4491 | 903 | self.assertEquals( | 903 | self.assertEqual( |
4492 | 904 | release["version"], | 904 | release["version"], |
4493 | 905 | get_release_from_db(release["series"][0])["version"], | 905 | get_release_from_db(release["series"][0])["version"], |
4494 | 906 | ) | 906 | ) |
4495 | diff --git a/src/maasserver/utils/tests/test_storage.py b/src/maasserver/utils/tests/test_storage.py | |||
4496 | index 695aed0..88761c9 100644 | |||
4497 | --- a/src/maasserver/utils/tests/test_storage.py | |||
4498 | +++ b/src/maasserver/utils/tests/test_storage.py | |||
4499 | @@ -174,4 +174,4 @@ class TestUsedFor(MAASServerTestCase): | |||
4500 | 174 | def test_vmfs(self): | 174 | def test_vmfs(self): |
4501 | 175 | vmfs = factory.make_VMFS() | 175 | vmfs = factory.make_VMFS() |
4502 | 176 | part = vmfs.filesystems.first().partition | 176 | part = vmfs.filesystems.first().partition |
4504 | 177 | self.assertEquals("VMFS extent for %s" % vmfs.name, used_for(part)) | 177 | self.assertEqual("VMFS extent for %s" % vmfs.name, used_for(part)) |
4505 | diff --git a/src/maasserver/utils/tests/test_utils.py b/src/maasserver/utils/tests/test_utils.py | |||
4506 | index 34c6311..5fd47f4 100644 | |||
4507 | --- a/src/maasserver/utils/tests/test_utils.py | |||
4508 | +++ b/src/maasserver/utils/tests/test_utils.py | |||
4509 | @@ -223,7 +223,7 @@ class TestFindRackController(MAASServerTestCase): | |||
4510 | 223 | subnet.vlan.dhcp_on = True | 223 | subnet.vlan.dhcp_on = True |
4511 | 224 | subnet.vlan.primary_rack = rack_controller | 224 | subnet.vlan.primary_rack = rack_controller |
4512 | 225 | subnet.vlan.save() | 225 | subnet.vlan.save() |
4514 | 226 | self.assertEquals( | 226 | self.assertEqual( |
4515 | 227 | rack_controller.system_id, | 227 | rack_controller.system_id, |
4516 | 228 | find_rack_controller( | 228 | find_rack_controller( |
4517 | 229 | make_request(factory.pick_ip_in_Subnet(subnet)) | 229 | make_request(factory.pick_ip_in_Subnet(subnet)) |
4518 | @@ -305,13 +305,13 @@ class GetRemoteIPTest(MAASTestCase): | |||
4519 | 305 | ip_address = factory.make_ipv4_address() | 305 | ip_address = factory.make_ipv4_address() |
4520 | 306 | request = HttpRequest() | 306 | request = HttpRequest() |
4521 | 307 | request.META = {"HTTP_X_FORWARDED_FOR": ip_address} | 307 | request.META = {"HTTP_X_FORWARDED_FOR": ip_address} |
4523 | 308 | self.assertEquals(ip_address, get_remote_ip(request)) | 308 | self.assertEqual(ip_address, get_remote_ip(request)) |
4524 | 309 | 309 | ||
4525 | 310 | def test_gets_client_ipv6_for_HTTP_X_FORWARDED_FOR(self): | 310 | def test_gets_client_ipv6_for_HTTP_X_FORWARDED_FOR(self): |
4526 | 311 | ip_address = factory.make_ipv6_address() | 311 | ip_address = factory.make_ipv6_address() |
4527 | 312 | request = HttpRequest() | 312 | request = HttpRequest() |
4528 | 313 | request.META = {"HTTP_X_FORWARDED_FOR": ip_address} | 313 | request.META = {"HTTP_X_FORWARDED_FOR": ip_address} |
4530 | 314 | self.assertEquals(ip_address, get_remote_ip(request)) | 314 | self.assertEqual(ip_address, get_remote_ip(request)) |
4531 | 315 | 315 | ||
4532 | 316 | def test_gets_client_ip_for_X_FORWARDED_FOR_with_proxies(self): | 316 | def test_gets_client_ip_for_X_FORWARDED_FOR_with_proxies(self): |
4533 | 317 | ip_address = factory.make_ipv4_address() | 317 | ip_address = factory.make_ipv4_address() |
4534 | @@ -321,19 +321,19 @@ class GetRemoteIPTest(MAASTestCase): | |||
4535 | 321 | request.META = { | 321 | request.META = { |
4536 | 322 | "HTTP_X_FORWARDED_FOR": "%s, %s, %s" % (ip_address, proxy1, proxy2) | 322 | "HTTP_X_FORWARDED_FOR": "%s, %s, %s" % (ip_address, proxy1, proxy2) |
4537 | 323 | } | 323 | } |
4539 | 324 | self.assertEquals(ip_address, get_remote_ip(request)) | 324 | self.assertEqual(ip_address, get_remote_ip(request)) |
4540 | 325 | 325 | ||
4541 | 326 | def test_gets_client_ipv4_for_REMOTE_ADDR(self): | 326 | def test_gets_client_ipv4_for_REMOTE_ADDR(self): |
4542 | 327 | ip_address = factory.make_ipv4_address() | 327 | ip_address = factory.make_ipv4_address() |
4543 | 328 | request = HttpRequest() | 328 | request = HttpRequest() |
4544 | 329 | request.META = {"REMOTE_ADDR": ip_address} | 329 | request.META = {"REMOTE_ADDR": ip_address} |
4546 | 330 | self.assertEquals(ip_address, get_remote_ip(request)) | 330 | self.assertEqual(ip_address, get_remote_ip(request)) |
4547 | 331 | 331 | ||
4548 | 332 | def test_gets_client_ipv6_for_REMOTE_ADDR(self): | 332 | def test_gets_client_ipv6_for_REMOTE_ADDR(self): |
4549 | 333 | ip_address = factory.make_ipv6_address() | 333 | ip_address = factory.make_ipv6_address() |
4550 | 334 | request = HttpRequest() | 334 | request = HttpRequest() |
4551 | 335 | request.META = {"REMOTE_ADDR": ip_address} | 335 | request.META = {"REMOTE_ADDR": ip_address} |
4553 | 336 | self.assertEquals(ip_address, get_remote_ip(request)) | 336 | self.assertEqual(ip_address, get_remote_ip(request)) |
4554 | 337 | 337 | ||
4555 | 338 | def test_fallsback_to_REMOTE_ADDR_for_invalid_X_FORWARDED_FOR(self): | 338 | def test_fallsback_to_REMOTE_ADDR_for_invalid_X_FORWARDED_FOR(self): |
4556 | 339 | ip_address = factory.make_ipv4_address() | 339 | ip_address = factory.make_ipv4_address() |
4557 | @@ -342,7 +342,7 @@ class GetRemoteIPTest(MAASTestCase): | |||
4558 | 342 | "HTTP_X_FORWARDED_FOR": factory.make_name("garbage ip"), | 342 | "HTTP_X_FORWARDED_FOR": factory.make_name("garbage ip"), |
4559 | 343 | "REMOTE_ADDR": ip_address, | 343 | "REMOTE_ADDR": ip_address, |
4560 | 344 | } | 344 | } |
4562 | 345 | self.assertEquals(ip_address, get_remote_ip(request)) | 345 | self.assertEqual(ip_address, get_remote_ip(request)) |
4563 | 346 | 346 | ||
4564 | 347 | def test_returns_None_for_invalid_ip(self): | 347 | def test_returns_None_for_invalid_ip(self): |
4565 | 348 | ip_address = factory.make_name("garbage ip") | 348 | ip_address = factory.make_name("garbage ip") |
4566 | diff --git a/src/maasserver/views/tests/test_account.py b/src/maasserver/views/tests/test_account.py | |||
4567 | index ce954da..092c23f 100644 | |||
4568 | --- a/src/maasserver/views/tests/test_account.py | |||
4569 | +++ b/src/maasserver/views/tests/test_account.py | |||
4570 | @@ -130,7 +130,7 @@ class TestLogin(MAASServerTestCase): | |||
4571 | 130 | ) | 130 | ) |
4572 | 131 | event = Event.objects.get(type__level=AUDIT) | 131 | event = Event.objects.get(type__level=AUDIT) |
4573 | 132 | self.assertIsNotNone(event) | 132 | self.assertIsNotNone(event) |
4575 | 133 | self.assertEquals(event.description, "Logged in user.") | 133 | self.assertEqual(event.description, "Logged in user.") |
4576 | 134 | 134 | ||
4577 | 135 | 135 | ||
4578 | 136 | class TestLogout(MAASServerTestCase): | 136 | class TestLogout(MAASServerTestCase): |
4579 | @@ -164,7 +164,7 @@ class TestLogout(MAASServerTestCase): | |||
4580 | 164 | self.client.post(reverse("logout")) | 164 | self.client.post(reverse("logout")) |
4581 | 165 | event = Event.objects.get(type__level=AUDIT) | 165 | event = Event.objects.get(type__level=AUDIT) |
4582 | 166 | self.assertIsNotNone(event) | 166 | self.assertIsNotNone(event) |
4584 | 167 | self.assertEquals(event.description, "Logged out user.") | 167 | self.assertEqual(event.description, "Logged out user.") |
4585 | 168 | 168 | ||
4586 | 169 | 169 | ||
4587 | 170 | def token_to_dict(token): | 170 | def token_to_dict(token): |
4588 | @@ -329,7 +329,7 @@ class TestAuthenticate(MAASServerTestCase): | |||
4589 | 329 | ) | 329 | ) |
4590 | 330 | event = Event.objects.get(type__level=AUDIT) | 330 | event = Event.objects.get(type__level=AUDIT) |
4591 | 331 | self.assertIsNotNone(event) | 331 | self.assertIsNotNone(event) |
4593 | 332 | self.assertEquals(event.description, "Retrieved API (OAuth) token.") | 332 | self.assertEqual(event.description, "Retrieved API (OAuth) token.") |
4594 | 333 | 333 | ||
4595 | 334 | def test_authenticate_creates_audit_event_without_tokens(self): | 334 | def test_authenticate_creates_audit_event_without_tokens(self): |
4596 | 335 | username = factory.make_name("username") | 335 | username = factory.make_name("username") |
4597 | @@ -347,7 +347,7 @@ class TestAuthenticate(MAASServerTestCase): | |||
4598 | 347 | ) | 347 | ) |
4599 | 348 | event = Event.objects.get(type__level=AUDIT) | 348 | event = Event.objects.get(type__level=AUDIT) |
4600 | 349 | self.assertIsNotNone(event) | 349 | self.assertIsNotNone(event) |
4602 | 350 | self.assertEquals(event.description, "Created API (OAuth) token.") | 350 | self.assertEqual(event.description, "Created API (OAuth) token.") |
4603 | 351 | 351 | ||
4604 | 352 | 352 | ||
4605 | 353 | class TestCSRF(MAASServerTestCase): | 353 | class TestCSRF(MAASServerTestCase): |
4606 | diff --git a/src/maasserver/websockets/handlers/tests/test_bootresource.py b/src/maasserver/websockets/handlers/tests/test_bootresource.py | |||
4607 | index e8c889f..7b55a11 100644 | |||
4608 | --- a/src/maasserver/websockets/handlers/tests/test_bootresource.py | |||
4609 | +++ b/src/maasserver/websockets/handlers/tests/test_bootresource.py | |||
4610 | @@ -284,7 +284,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4611 | 284 | handler = BootResourceHandler(owner, {}, None) | 284 | handler = BootResourceHandler(owner, {}, None) |
4612 | 285 | response = handler.poll({}) | 285 | response = handler.poll({}) |
4613 | 286 | json_obj = json.loads(response) | 286 | json_obj = json.loads(response) |
4615 | 287 | self.assertEquals( | 287 | self.assertEqual( |
4616 | 288 | commissioning_series.value, | 288 | commissioning_series.value, |
4617 | 289 | json_obj["ubuntu"]["commissioning_series"], | 289 | json_obj["ubuntu"]["commissioning_series"], |
4618 | 290 | ) | 290 | ) |
4619 | @@ -704,7 +704,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4620 | 704 | response = handler.poll({}) | 704 | response = handler.poll({}) |
4621 | 705 | json_obj = json.loads(response) | 705 | json_obj = json.loads(response) |
4622 | 706 | ubuntu_core_images = json_obj["ubuntu_core_images"] | 706 | ubuntu_core_images = json_obj["ubuntu_core_images"] |
4624 | 707 | self.assertEquals( | 707 | self.assertEqual( |
4625 | 708 | [ | 708 | [ |
4626 | 709 | { | 709 | { |
4627 | 710 | "name": "%s/%s/%s/%s" | 710 | "name": "%s/%s/%s/%s" |
4628 | @@ -730,7 +730,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4629 | 730 | response = handler.poll({}) | 730 | response = handler.poll({}) |
4630 | 731 | json_obj = json.loads(response) | 731 | json_obj = json.loads(response) |
4631 | 732 | ubuntu_core_images = json_obj["ubuntu_core_images"] | 732 | ubuntu_core_images = json_obj["ubuntu_core_images"] |
4633 | 733 | self.assertEquals( | 733 | self.assertEqual( |
4634 | 734 | [ | 734 | [ |
4635 | 735 | { | 735 | { |
4636 | 736 | "name": "%s/%s/%s/%s" | 736 | "name": "%s/%s/%s/%s" |
4637 | @@ -750,7 +750,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4638 | 750 | response = handler.poll({}) | 750 | response = handler.poll({}) |
4639 | 751 | json_obj = json.loads(response) | 751 | json_obj = json.loads(response) |
4640 | 752 | other_images = json_obj["other_images"] | 752 | other_images = json_obj["other_images"] |
4642 | 753 | self.assertEquals( | 753 | self.assertEqual( |
4643 | 754 | [ | 754 | [ |
4644 | 755 | { | 755 | { |
4645 | 756 | "name": "%s/%s/%s/%s" | 756 | "name": "%s/%s/%s/%s" |
4646 | @@ -776,7 +776,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4647 | 776 | response = handler.poll({}) | 776 | response = handler.poll({}) |
4648 | 777 | json_obj = json.loads(response) | 777 | json_obj = json.loads(response) |
4649 | 778 | other_images = json_obj["other_images"] | 778 | other_images = json_obj["other_images"] |
4651 | 779 | self.assertEquals( | 779 | self.assertEqual( |
4652 | 780 | [ | 780 | [ |
4653 | 781 | { | 781 | { |
4654 | 782 | "name": "%s/%s/%s/%s" | 782 | "name": "%s/%s/%s/%s" |
4655 | @@ -796,7 +796,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4656 | 796 | factory.make_BootSourceCache(os="ubuntu-core") | 796 | factory.make_BootSourceCache(os="ubuntu-core") |
4657 | 797 | response = handler.poll({}) | 797 | response = handler.poll({}) |
4658 | 798 | json_obj = json.loads(response) | 798 | json_obj = json.loads(response) |
4660 | 799 | self.assertEquals([], json_obj["other_images"]) | 799 | self.assertEqual([], json_obj["other_images"]) |
4661 | 800 | 800 | ||
4662 | 801 | def test_other_images_filters_out_bootloaders(self): | 801 | def test_other_images_filters_out_bootloaders(self): |
4663 | 802 | owner = factory.make_admin() | 802 | owner = factory.make_admin() |
4664 | @@ -806,7 +806,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4665 | 806 | ) | 806 | ) |
4666 | 807 | response = handler.poll({}) | 807 | response = handler.poll({}) |
4667 | 808 | json_obj = json.loads(response) | 808 | json_obj = json.loads(response) |
4669 | 809 | self.assertEquals([], json_obj["other_images"]) | 809 | self.assertEqual([], json_obj["other_images"]) |
4670 | 810 | 810 | ||
4671 | 811 | def test_prefers_title_from_boot_resource_extra(self): | 811 | def test_prefers_title_from_boot_resource_extra(self): |
4672 | 812 | owner = factory.make_admin() | 812 | owner = factory.make_admin() |
4673 | @@ -815,7 +815,7 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin): | |||
4674 | 815 | self.make_other_resource(extra={"title": title}) | 815 | self.make_other_resource(extra={"title": title}) |
4675 | 816 | response = handler.poll({}) | 816 | response = handler.poll({}) |
4676 | 817 | json_obj = json.loads(response) | 817 | json_obj = json.loads(response) |
4678 | 818 | self.assertEquals(title, json_obj["resources"][0]["title"]) | 818 | self.assertEqual(title, json_obj["resources"][0]["title"]) |
4679 | 819 | 819 | ||
4680 | 820 | 820 | ||
4681 | 821 | class TestBootResourceStopImport(MAASTransactionServerTestCase): | 821 | class TestBootResourceStopImport(MAASTransactionServerTestCase): |
4682 | @@ -830,7 +830,7 @@ class TestBootResourceStopImport(MAASTransactionServerTestCase): | |||
4683 | 830 | mock_stop_import = self.patch_stop_import_resources() | 830 | mock_stop_import = self.patch_stop_import_resources() |
4684 | 831 | result = handler.stop_import({}) | 831 | result = handler.stop_import({}) |
4685 | 832 | self.assertThat(mock_stop_import, MockCalledOnceWith()) | 832 | self.assertThat(mock_stop_import, MockCalledOnceWith()) |
4687 | 833 | self.assertEquals(handler.poll({}), result) | 833 | self.assertEqual(handler.poll({}), result) |
4688 | 834 | 834 | ||
4689 | 835 | 835 | ||
4690 | 836 | class TestBootResourceSaveUbuntu( | 836 | class TestBootResourceSaveUbuntu( |
4691 | diff --git a/src/maasserver/websockets/handlers/tests/test_config.py b/src/maasserver/websockets/handlers/tests/test_config.py | |||
4692 | index eccae08..2774982 100644 | |||
4693 | --- a/src/maasserver/websockets/handlers/tests/test_config.py | |||
4694 | +++ b/src/maasserver/websockets/handlers/tests/test_config.py | |||
4695 | @@ -52,7 +52,7 @@ class TestConfigHandler(MAASServerTestCase): | |||
4696 | 52 | user = factory.make_User() | 52 | user = factory.make_User() |
4697 | 53 | handler = ConfigHandler(user, {}, None) | 53 | handler = ConfigHandler(user, {}, None) |
4698 | 54 | Config.objects.set_config("curtin_verbose", True) | 54 | Config.objects.set_config("curtin_verbose", True) |
4700 | 55 | self.assertEquals( | 55 | self.assertEqual( |
4701 | 56 | {"name": "curtin_verbose", "value": True}, | 56 | {"name": "curtin_verbose", "value": True}, |
4702 | 57 | handler.get({"name": "curtin_verbose"}), | 57 | handler.get({"name": "curtin_verbose"}), |
4703 | 58 | ) | 58 | ) |
4704 | @@ -62,7 +62,7 @@ class TestConfigHandler(MAASServerTestCase): | |||
4705 | 62 | handler = ConfigHandler(user, {}, None) | 62 | handler = ConfigHandler(user, {}, None) |
4706 | 63 | Config.objects.set_config("curtin_verbose", True) | 63 | Config.objects.set_config("curtin_verbose", True) |
4707 | 64 | handler.get({"name": "curtin_verbose"}) | 64 | handler.get({"name": "curtin_verbose"}) |
4709 | 65 | self.assertEquals({"curtin_verbose"}, handler.cache["loaded_pks"]) | 65 | self.assertEqual({"curtin_verbose"}, handler.cache["loaded_pks"]) |
4710 | 66 | 66 | ||
4711 | 67 | def test_get_requires_name(self): | 67 | def test_get_requires_name(self): |
4712 | 68 | user = factory.make_User() | 68 | user = factory.make_User() |
4713 | @@ -121,7 +121,7 @@ class TestConfigHandler(MAASServerTestCase): | |||
4714 | 121 | user = factory.make_admin() | 121 | user = factory.make_admin() |
4715 | 122 | handler = ConfigHandler(user, {}, None) | 122 | handler = ConfigHandler(user, {}, None) |
4716 | 123 | updated = handler.update({"name": "curtin_verbose", "value": True}) | 123 | updated = handler.update({"name": "curtin_verbose", "value": True}) |
4718 | 124 | self.assertEquals({"name": "curtin_verbose", "value": True}, updated) | 124 | self.assertEqual({"name": "curtin_verbose", "value": True}, updated) |
4719 | 125 | self.assertTrue(Config.objects.get_config("curtin_verbose")) | 125 | self.assertTrue(Config.objects.get_config("curtin_verbose")) |
4720 | 126 | 126 | ||
4721 | 127 | def test_update_cannot_update_uuid(self): | 127 | def test_update_cannot_update_uuid(self): |
4722 | @@ -159,9 +159,7 @@ class TestConfigHandler(MAASServerTestCase): | |||
4723 | 159 | handler.update, | 159 | handler.update, |
4724 | 160 | {"name": "http_proxy", "value": factory.make_name("invalid")}, | 160 | {"name": "http_proxy", "value": factory.make_name("invalid")}, |
4725 | 161 | ) | 161 | ) |
4729 | 162 | self.assertEquals( | 162 | self.assertEqual({"value": ["Enter a valid URL."]}, error.message_dict) |
4727 | 163 | {"value": ["Enter a valid URL."]}, error.message_dict | ||
4728 | 164 | ) | ||
4730 | 165 | 163 | ||
4731 | 166 | def test_on_listen_returns_None_if_excluded(self): | 164 | def test_on_listen_returns_None_if_excluded(self): |
4732 | 167 | user = factory.make_User() | 165 | user = factory.make_User() |
4733 | diff --git a/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py b/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py | |||
4734 | index 92a3989..c1f7b34 100644 | |||
4735 | --- a/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py | |||
4736 | +++ b/src/maasserver/websockets/handlers/tests/test_dhcpsnippet.py | |||
4737 | @@ -124,7 +124,7 @@ class TestDHCPSnippetHandler(MAASServerTestCase): | |||
4738 | 124 | node = factory.make_Node() | 124 | node = factory.make_Node() |
4739 | 125 | handler.update({"id": dhcp_snippet.id, "node": node.system_id}) | 125 | handler.update({"id": dhcp_snippet.id, "node": node.system_id}) |
4740 | 126 | dhcp_snippet = reload_object(dhcp_snippet) | 126 | dhcp_snippet = reload_object(dhcp_snippet) |
4742 | 127 | self.assertEquals(node, dhcp_snippet.node) | 127 | self.assertEqual(node, dhcp_snippet.node) |
4743 | 128 | event = Event.objects.get(type__level=AUDIT) | 128 | event = Event.objects.get(type__level=AUDIT) |
4744 | 129 | self.assertIsNotNone(event) | 129 | self.assertIsNotNone(event) |
4745 | 130 | self.assertEqual( | 130 | self.assertEqual( |
4746 | @@ -168,7 +168,7 @@ class TestDHCPSnippetHandler(MAASServerTestCase): | |||
4747 | 168 | remaining_ids = textfile_ids[:revert_to] | 168 | remaining_ids = textfile_ids[:revert_to] |
4748 | 169 | handler.revert({"id": dhcp_snippet.id, "to": revert_to}) | 169 | handler.revert({"id": dhcp_snippet.id, "to": revert_to}) |
4749 | 170 | dhcp_snippet = reload_object(dhcp_snippet) | 170 | dhcp_snippet = reload_object(dhcp_snippet) |
4751 | 171 | self.assertEquals( | 171 | self.assertEqual( |
4752 | 172 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, | 172 | VersionedTextFile.objects.get(id=textfile_ids[revert_to - 1]).data, |
4753 | 173 | dhcp_snippet.value.data, | 173 | dhcp_snippet.value.data, |
4754 | 174 | ) | 174 | ) |
4755 | diff --git a/src/maasserver/websockets/handlers/tests/test_discovery.py b/src/maasserver/websockets/handlers/tests/test_discovery.py | |||
4756 | index 1597dea..de6e98f 100644 | |||
4757 | --- a/src/maasserver/websockets/handlers/tests/test_discovery.py | |||
4758 | +++ b/src/maasserver/websockets/handlers/tests/test_discovery.py | |||
4759 | @@ -87,7 +87,7 @@ class TestDiscoveryHandler(MAASServerTestCase): | |||
4760 | 87 | self.dehydrate_discovery(discovery, for_list=True) | 87 | self.dehydrate_discovery(discovery, for_list=True) |
4761 | 88 | for discovery in [d0, d1, d2, d3, d4] | 88 | for discovery in [d0, d1, d2, d3, d4] |
4762 | 89 | ] | 89 | ] |
4764 | 90 | self.assertEquals(expected_discoveries, handler.list({})) | 90 | self.assertEqual(expected_discoveries, handler.list({})) |
4765 | 91 | 91 | ||
4766 | 92 | def test_list_starts_after_first_seen(self): | 92 | def test_list_starts_after_first_seen(self): |
4767 | 93 | user = factory.make_User() | 93 | user = factory.make_User() |
4768 | @@ -108,7 +108,7 @@ class TestDiscoveryHandler(MAASServerTestCase): | |||
4769 | 108 | self.dehydrate_discovery(discovery, for_list=True) | 108 | self.dehydrate_discovery(discovery, for_list=True) |
4770 | 109 | for discovery in [d3, d4] | 109 | for discovery in [d3, d4] |
4771 | 110 | ] | 110 | ] |
4773 | 111 | self.assertEquals( | 111 | self.assertEqual( |
4774 | 112 | expected_discoveries, handler.list({"start": first_seen}) | 112 | expected_discoveries, handler.list({"start": first_seen}) |
4775 | 113 | ) | 113 | ) |
4776 | 114 | 114 | ||
4777 | diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py | |||
4778 | index 3f700b0..8f46f16 100644 | |||
4779 | --- a/src/maasserver/websockets/handlers/tests/test_machine.py | |||
4780 | +++ b/src/maasserver/websockets/handlers/tests/test_machine.py | |||
4781 | @@ -501,7 +501,7 @@ class TestMachineHandler(MAASServerTestCase): | |||
4782 | 501 | handler._script_results[cached_node.id] = cached_content | 501 | handler._script_results[cached_node.id] = cached_content |
4783 | 502 | handler._cache_pks([node]) | 502 | handler._cache_pks([node]) |
4784 | 503 | 503 | ||
4786 | 504 | self.assertEquals( | 504 | self.assertEqual( |
4787 | 505 | script_result.id, | 505 | script_result.id, |
4788 | 506 | handler._script_results[node.id][ | 506 | handler._script_results[node.id][ |
4789 | 507 | script_result.script.hardware_type | 507 | script_result.script.hardware_type |
4790 | @@ -515,7 +515,7 @@ class TestMachineHandler(MAASServerTestCase): | |||
4791 | 515 | for result in results | 515 | for result in results |
4792 | 516 | ], | 516 | ], |
4793 | 517 | ) | 517 | ) |
4795 | 518 | self.assertEquals( | 518 | self.assertEqual( |
4796 | 519 | cached_content, handler._script_results[cached_node.id] | 519 | cached_content, handler._script_results[cached_node.id] |
4797 | 520 | ) | 520 | ) |
4798 | 521 | 521 | ||
4799 | @@ -704,8 +704,8 @@ class TestMachineHandler(MAASServerTestCase): | |||
4800 | 704 | _, _, ret = handler.on_listen_for_active_pk( | 704 | _, _, ret = handler.on_listen_for_active_pk( |
4801 | 705 | "update", node.system_id, node | 705 | "update", node.system_id, node |
4802 | 706 | ) | 706 | ) |
4805 | 707 | self.assertEquals(ret["commissioning_status"]["passed"], 10) | 707 | self.assertEqual(ret["commissioning_status"]["passed"], 10) |
4806 | 708 | self.assertEquals(ret["testing_status"]["passed"], 10) | 708 | self.assertEqual(ret["testing_status"]["passed"], 10) |
4807 | 709 | 709 | ||
4808 | 710 | def test_cache_clears_on_reload(self): | 710 | def test_cache_clears_on_reload(self): |
4809 | 711 | owner = factory.make_User() | 711 | owner = factory.make_User() |
4810 | @@ -799,11 +799,11 @@ class TestMachineHandler(MAASServerTestCase): | |||
4811 | 799 | if disk["id"] == node.boot_disk.id: | 799 | if disk["id"] == node.boot_disk.id: |
4812 | 800 | for partition in disk["partitions"]: | 800 | for partition in disk["partitions"]: |
4813 | 801 | if partition["name"].endswith("-part3"): | 801 | if partition["name"].endswith("-part3"): |
4815 | 802 | self.assertEquals( | 802 | self.assertEqual( |
4816 | 803 | "VMFS extent for datastore1", partition["used_for"] | 803 | "VMFS extent for datastore1", partition["used_for"] |
4817 | 804 | ) | 804 | ) |
4818 | 805 | else: | 805 | else: |
4820 | 806 | self.assertEquals( | 806 | self.assertEqual( |
4821 | 807 | "VMware ESXi OS partition", partition["used_for"] | 807 | "VMware ESXi OS partition", partition["used_for"] |
4822 | 808 | ) | 808 | ) |
4823 | 809 | self.assertDictEqual( | 809 | self.assertDictEqual( |
4824 | @@ -1694,7 +1694,7 @@ class TestMachineHandler(MAASServerTestCase): | |||
4825 | 1694 | node = factory.make_Node(owner=owner) | 1694 | node = factory.make_Node(owner=owner) |
4826 | 1695 | handler = MachineHandler(owner, {}, None) | 1695 | handler = MachineHandler(owner, {}, None) |
4827 | 1696 | observed = handler.get_summary_xml({"system_id": node.system_id}) | 1696 | observed = handler.get_summary_xml({"system_id": node.system_id}) |
4829 | 1697 | self.assertEquals("", observed) | 1697 | self.assertEqual("", observed) |
4830 | 1698 | 1698 | ||
4831 | 1699 | def test_dehydrate_summary_xml_returns_data(self): | 1699 | def test_dehydrate_summary_xml_returns_data(self): |
4832 | 1700 | owner = factory.make_User() | 1700 | owner = factory.make_User() |
4833 | @@ -1708,7 +1708,7 @@ class TestMachineHandler(MAASServerTestCase): | |||
4834 | 1708 | script_result.store_result(exit_status=0, stdout=lldp_data) | 1708 | script_result.store_result(exit_status=0, stdout=lldp_data) |
4835 | 1709 | observed = handler.get_summary_xml({"system_id": node.system_id}) | 1709 | observed = handler.get_summary_xml({"system_id": node.system_id}) |
4836 | 1710 | probed_details = merge_details_cleanly(get_single_probed_details(node)) | 1710 | probed_details = merge_details_cleanly(get_single_probed_details(node)) |
4838 | 1711 | self.assertEquals( | 1711 | self.assertEqual( |
4839 | 1712 | etree.tostring(probed_details, encoding=str, pretty_print=True), | 1712 | etree.tostring(probed_details, encoding=str, pretty_print=True), |
4840 | 1713 | observed, | 1713 | observed, |
4841 | 1714 | ) | 1714 | ) |
4842 | @@ -1718,7 +1718,7 @@ class TestMachineHandler(MAASServerTestCase): | |||
4843 | 1718 | node = factory.make_Node(owner=owner) | 1718 | node = factory.make_Node(owner=owner) |
4844 | 1719 | handler = MachineHandler(owner, {}, None) | 1719 | handler = MachineHandler(owner, {}, None) |
4845 | 1720 | observed = handler.get_summary_yaml({"system_id": node.system_id}) | 1720 | observed = handler.get_summary_yaml({"system_id": node.system_id}) |
4847 | 1721 | self.assertEquals("", observed) | 1721 | self.assertEqual("", observed) |
4848 | 1722 | 1722 | ||
4849 | 1723 | def test_dehydrate_summary_yaml_returns_data(self): | 1723 | def test_dehydrate_summary_yaml_returns_data(self): |
4850 | 1724 | owner = factory.make_User() | 1724 | owner = factory.make_User() |
4851 | @@ -4326,7 +4326,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase): | |||
4852 | 4326 | power_state = yield machine_handler.check_power( | 4326 | power_state = yield machine_handler.check_power( |
4853 | 4327 | {"system_id": node.system_id} | 4327 | {"system_id": node.system_id} |
4854 | 4328 | ) | 4328 | ) |
4856 | 4329 | self.assertEquals(power_state, POWER_STATE.UNKNOWN) | 4329 | self.assertEqual(power_state, POWER_STATE.UNKNOWN) |
4857 | 4330 | 4330 | ||
4858 | 4331 | @wait_for_reactor | 4331 | @wait_for_reactor |
4859 | 4332 | @inlineCallbacks | 4332 | @inlineCallbacks |
4860 | @@ -4339,7 +4339,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase): | |||
4861 | 4339 | power_state = yield machine_handler.check_power( | 4339 | power_state = yield machine_handler.check_power( |
4862 | 4340 | {"system_id": node.system_id} | 4340 | {"system_id": node.system_id} |
4863 | 4341 | ) | 4341 | ) |
4865 | 4342 | self.assertEquals(power_state, POWER_STATE.UNKNOWN) | 4342 | self.assertEqual(power_state, POWER_STATE.UNKNOWN) |
4866 | 4343 | 4343 | ||
4867 | 4344 | @wait_for_reactor | 4344 | @wait_for_reactor |
4868 | 4345 | @inlineCallbacks | 4345 | @inlineCallbacks |
4869 | @@ -4353,7 +4353,7 @@ class TestMachineHandlerCheckPower(MAASTransactionServerTestCase): | |||
4870 | 4353 | power_state = yield machine_handler.check_power( | 4353 | power_state = yield machine_handler.check_power( |
4871 | 4354 | {"system_id": node.system_id} | 4354 | {"system_id": node.system_id} |
4872 | 4355 | ) | 4355 | ) |
4874 | 4356 | self.assertEquals(power_state, POWER_STATE.ERROR) | 4356 | self.assertEqual(power_state, POWER_STATE.ERROR) |
4875 | 4357 | self.assertThat( | 4357 | self.assertThat( |
4876 | 4358 | mock_log_err, | 4358 | mock_log_err, |
4877 | 4359 | MockCalledOnceWith( | 4359 | MockCalledOnceWith( |
4878 | diff --git a/src/maasserver/websockets/handlers/tests/test_node_result.py b/src/maasserver/websockets/handlers/tests/test_node_result.py | |||
4879 | index 5f6b35c..3899f83 100644 | |||
4880 | --- a/src/maasserver/websockets/handlers/tests/test_node_result.py | |||
4881 | +++ b/src/maasserver/websockets/handlers/tests/test_node_result.py | |||
4882 | @@ -75,9 +75,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4883 | 75 | user = factory.make_User() | 75 | user = factory.make_User() |
4884 | 76 | handler = NodeResultHandler(user, {}, None) | 76 | handler = NodeResultHandler(user, {}, None) |
4885 | 77 | node = factory.make_Node() | 77 | node = factory.make_Node() |
4889 | 78 | self.assertEquals( | 78 | self.assertEqual(node, handler.get_node({"system_id": node.system_id})) |
4887 | 79 | node, handler.get_node({"system_id": node.system_id}) | ||
4888 | 80 | ) | ||
4890 | 81 | self.assertDictEqual( | 79 | self.assertDictEqual( |
4891 | 82 | {node.system_id: node}, handler.cache["system_ids"] | 80 | {node.system_id: node}, handler.cache["system_ids"] |
4892 | 83 | ) | 81 | ) |
4893 | @@ -88,7 +86,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4894 | 88 | fake_system_id = factory.make_name("system_id") | 86 | fake_system_id = factory.make_name("system_id") |
4895 | 89 | fake_node = factory.make_name("node") | 87 | fake_node = factory.make_name("node") |
4896 | 90 | handler.cache["system_ids"][fake_system_id] = fake_node | 88 | handler.cache["system_ids"][fake_system_id] = fake_node |
4898 | 91 | self.assertEquals( | 89 | self.assertEqual( |
4899 | 92 | fake_node, handler.get_node({"system_id": fake_system_id}) | 90 | fake_node, handler.get_node({"system_id": fake_system_id}) |
4900 | 93 | ) | 91 | ) |
4901 | 94 | 92 | ||
4902 | @@ -294,7 +292,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4903 | 294 | for _ in range(6): | 292 | for _ in range(6): |
4904 | 295 | factory.make_ScriptResult(script_set=script_set) | 293 | factory.make_ScriptResult(script_set=script_set) |
4905 | 296 | start = random.randint(0, 5) | 294 | start = random.randint(0, 5) |
4907 | 297 | self.assertEquals( | 295 | self.assertEqual( |
4908 | 298 | 6 - start, | 296 | 6 - start, |
4909 | 299 | len(handler.list({"system_id": node.system_id, "start": start})), | 297 | len(handler.list({"system_id": node.system_id, "start": start})), |
4910 | 300 | ) | 298 | ) |
4911 | @@ -307,7 +305,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4912 | 307 | for _ in range(6): | 305 | for _ in range(6): |
4913 | 308 | factory.make_ScriptResult(script_set=script_set) | 306 | factory.make_ScriptResult(script_set=script_set) |
4914 | 309 | limit = random.randint(0, 6) | 307 | limit = random.randint(0, 6) |
4916 | 310 | self.assertEquals( | 308 | self.assertEqual( |
4917 | 311 | limit, | 309 | limit, |
4918 | 312 | len(handler.list({"system_id": node.system_id, "limit": limit})), | 310 | len(handler.list({"system_id": node.system_id, "limit": limit})), |
4919 | 313 | ) | 311 | ) |
4920 | @@ -382,7 +380,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4921 | 382 | output=combined, | 380 | output=combined, |
4922 | 383 | script_set=factory.make_ScriptSet(node=node), | 381 | script_set=factory.make_ScriptSet(node=node), |
4923 | 384 | ) | 382 | ) |
4925 | 385 | self.assertEquals( | 383 | self.assertEqual( |
4926 | 386 | combined.decode(), | 384 | combined.decode(), |
4927 | 387 | handler.get_result_data( | 385 | handler.get_result_data( |
4928 | 388 | {"id": script_result.id, "data_type": "combined"} | 386 | {"id": script_result.id, "data_type": "combined"} |
4929 | @@ -399,7 +397,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4930 | 399 | stdout=stdout, | 397 | stdout=stdout, |
4931 | 400 | script_set=factory.make_ScriptSet(node=node), | 398 | script_set=factory.make_ScriptSet(node=node), |
4932 | 401 | ) | 399 | ) |
4934 | 402 | self.assertEquals( | 400 | self.assertEqual( |
4935 | 403 | stdout.decode(), | 401 | stdout.decode(), |
4936 | 404 | handler.get_result_data( | 402 | handler.get_result_data( |
4937 | 405 | {"id": script_result.id, "data_type": "stdout"} | 403 | {"id": script_result.id, "data_type": "stdout"} |
4938 | @@ -416,7 +414,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4939 | 416 | stderr=stderr, | 414 | stderr=stderr, |
4940 | 417 | script_set=factory.make_ScriptSet(node=node), | 415 | script_set=factory.make_ScriptSet(node=node), |
4941 | 418 | ) | 416 | ) |
4943 | 419 | self.assertEquals( | 417 | self.assertEqual( |
4944 | 420 | stderr.decode(), | 418 | stderr.decode(), |
4945 | 421 | handler.get_result_data( | 419 | handler.get_result_data( |
4946 | 422 | {"id": script_result.id, "data_type": "stderr"} | 420 | {"id": script_result.id, "data_type": "stderr"} |
4947 | @@ -433,7 +431,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4948 | 433 | result=result, | 431 | result=result, |
4949 | 434 | script_set=factory.make_ScriptSet(node=node), | 432 | script_set=factory.make_ScriptSet(node=node), |
4950 | 435 | ) | 433 | ) |
4952 | 436 | self.assertEquals( | 434 | self.assertEqual( |
4953 | 437 | result.decode(), | 435 | result.decode(), |
4954 | 438 | handler.get_result_data( | 436 | handler.get_result_data( |
4955 | 439 | {"id": script_result.id, "data_type": "result"} | 437 | {"id": script_result.id, "data_type": "result"} |
4956 | @@ -444,7 +442,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4957 | 444 | user = factory.make_User() | 442 | user = factory.make_User() |
4958 | 445 | handler = NodeResultHandler(user, {}, None) | 443 | handler = NodeResultHandler(user, {}, None) |
4959 | 446 | id = random.randint(0, 100) | 444 | id = random.randint(0, 100) |
4961 | 447 | self.assertEquals( | 445 | self.assertEqual( |
4962 | 448 | "Unknown ScriptResult id %s" % id, | 446 | "Unknown ScriptResult id %s" % id, |
4963 | 449 | handler.get_result_data({"id": id}), | 447 | handler.get_result_data({"id": id}), |
4964 | 450 | ) | 448 | ) |
4965 | @@ -460,7 +458,7 @@ class TestNodeResultHandler(MAASServerTestCase): | |||
4966 | 460 | script_set=factory.make_ScriptSet(node=node), | 458 | script_set=factory.make_ScriptSet(node=node), |
4967 | 461 | ) | 459 | ) |
4968 | 462 | unknown_data_type = factory.make_name("data_type") | 460 | unknown_data_type = factory.make_name("data_type") |
4970 | 463 | self.assertEquals( | 461 | self.assertEqual( |
4971 | 464 | "Unknown data_type %s" % unknown_data_type, | 462 | "Unknown data_type %s" % unknown_data_type, |
4972 | 465 | handler.get_result_data( | 463 | handler.get_result_data( |
4973 | 466 | {"id": script_result.id, "data_type": unknown_data_type} | 464 | {"id": script_result.id, "data_type": unknown_data_type} |
4974 | diff --git a/src/maasserver/websockets/handlers/tests/test_packagerepository.py b/src/maasserver/websockets/handlers/tests/test_packagerepository.py | |||
4975 | index 35fb13c..e297d88 100644 | |||
4976 | --- a/src/maasserver/websockets/handlers/tests/test_packagerepository.py | |||
4977 | +++ b/src/maasserver/websockets/handlers/tests/test_packagerepository.py | |||
4978 | @@ -90,7 +90,7 @@ class TestPackageRepositoryHandler(MAASServerTestCase): | |||
4979 | 90 | url = factory.make_url(scheme="http") | 90 | url = factory.make_url(scheme="http") |
4980 | 91 | handler.update({"id": package_repository.id, "url": url}) | 91 | handler.update({"id": package_repository.id, "url": url}) |
4981 | 92 | package_repository = reload_object(package_repository) | 92 | package_repository = reload_object(package_repository) |
4983 | 93 | self.assertEquals(url, package_repository.url) | 93 | self.assertEqual(url, package_repository.url) |
4984 | 94 | event = Event.objects.get(type__level=AUDIT) | 94 | event = Event.objects.get(type__level=AUDIT) |
4985 | 95 | self.assertIsNotNone(event) | 95 | self.assertIsNotNone(event) |
4986 | 96 | self.assertEqual( | 96 | self.assertEqual( |
4987 | diff --git a/src/maasserver/websockets/handlers/tests/test_subnet.py b/src/maasserver/websockets/handlers/tests/test_subnet.py | |||
4988 | index b77fd2a..6ea887b 100644 | |||
4989 | --- a/src/maasserver/websockets/handlers/tests/test_subnet.py | |||
4990 | +++ b/src/maasserver/websockets/handlers/tests/test_subnet.py | |||
4991 | @@ -84,7 +84,7 @@ class TestSubnetHandler(MAASServerTestCase): | |||
4992 | 84 | subnet = factory.make_Subnet() | 84 | subnet = factory.make_Subnet() |
4993 | 85 | self.assertIsNone(handler.cache.get("staticroutes")) | 85 | self.assertIsNone(handler.cache.get("staticroutes")) |
4994 | 86 | queries, _ = count_queries(handler.get, {"id": subnet.id}) | 86 | queries, _ = count_queries(handler.get, {"id": subnet.id}) |
4996 | 87 | self.assertEquals(5, queries) | 87 | self.assertEqual(5, queries) |
4997 | 88 | self.assertIsNotNone(handler.cache["staticroutes"]) | 88 | self.assertIsNotNone(handler.cache["staticroutes"]) |
4998 | 89 | 89 | ||
4999 | 90 | def test_list(self): | 90 | def test_list(self): |
5000 | @@ -121,9 +121,9 @@ class TestSubnetHandler(MAASServerTestCase): |
UNIT TESTS
-b no-assert-equals lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas
STATUS: FAILED maas-ci. internal: 8080/job/ maas/job/ branch- tester/ 8756/console 0efb8cd3b2e300d 97c9a685ad
LOG: http://
COMMIT: 81aab4f30dacb59