Merge lp:~ad-simplypeachy/widelands/ai-hints into lp:widelands

[_aD]

Improved AI hints for shipyard and toolsmithy/metalwork shops.

The AI was building shipyards with no water in range and the toolsmithys/metalworks were not marked as basic, and were not being built early enough. The latter seemed to be crippling the AI's progress quite often. AI hints sections now fixed.

[Nasenbaer (nasenbaer)]

I am a bit split towards this change - I have not checked the effect of this patch, however the idea I had when implementing the "is_basic" feature was, to force the defaultAI to build some build resource producing buildings faster than al the others - so e.g. wood hardener, as blackwood is very important for building up other buildings.

Therefor I am almost against this fix - the right way imho would be to fix/improve the "decission function" of the defaultAI where it is decided what buildings should be build next.

Maybe the positive effect of this branch could be achieved with carlis AI fixes... but I haven't tested it, yet.

review: Needs Information

[_aD (ad-simplypeachy)]

While carli was looking at the AI I also set a game of AIs against each other and saw that three of them had no toolsmithy which had prevented further expansion - it was most pronounced with the Empire. I'm not sure about others but I always build a toolsmithy early on and thought this would solve the problem. If it's better fixed in the AI logic then so be it. Thanks for the feedback.

[Nicolai Hähnle (nha)]

What's the status of this? It seems to me that at least the shipyard part should be merged.

review: Needs Fixing

[SirVer (sirver)]

ping?

[SirVer (sirver)]

Peter, could you have another look over this. I think Nicolai is correct that at least the Shipyard part should get merged?

[SirVer (sirver)]

I now define: A toolsmithy is basic. So I merge this. Should the decision in the default AI get better we might get rid of all the hints, but for now, they seem to improve things.

=== modified file 'tribes/atlanteans/shipyard/conf'
--- tribes/atlanteans/shipyard/conf	2012-02-20 15:54:26 +0000
+++ tribes/atlanteans/shipyard/conf	2013-01-06 16:42:22 +0000
@@ -2,6 +2,7 @@
 
 [aihints]
 build_material=false
+needs_water=true
 
 [buildcost]
 trunk=3
 
=== modified file 'tribes/atlanteans/toolsmithy/conf'
--- tribes/atlanteans/toolsmithy/conf	2012-02-15 21:25:34 +0000
+++ tribes/atlanteans/toolsmithy/conf	2013-01-06 16:42:22 +0000
@@ -20,6 +20,7 @@
 
 [aihints]
 build_material=false
+is_basic=true
 
 [working positions]
 toolsmith=1
 
=== modified file 'tribes/barbarians/metalworks/conf'
--- tribes/barbarians/metalworks/conf	2012-02-15 21:25:34 +0000
+++ tribes/barbarians/metalworks/conf	2013-01-06 16:42:22 +0000
@@ -28,6 +28,7 @@
 
 [aihints]
 build_material=false
+is_basic=true
 
 [programs]
 produce_felling_axe=_Produce felling axe
 
=== modified file 'tribes/barbarians/shipyard/conf'
--- tribes/barbarians/shipyard/conf	2012-03-01 16:15:56 +0000
+++ tribes/barbarians/shipyard/conf	2013-01-06 16:42:22 +0000
@@ -2,6 +2,7 @@
 
 [aihints]
 build_material=false
+needs_water=true
 
 [buildcost]
 trunk=3
 
=== modified file 'tribes/empire/shipyard/conf'
--- tribes/empire/shipyard/conf	2012-03-01 22:35:05 +0000
+++ tribes/empire/shipyard/conf	2013-01-06 16:42:22 +0000
@@ -2,6 +2,7 @@
 
 [aihints]
 build_material=false
+needs_water=true
 
 [buildcost]
 trunk=3
 
=== modified file 'tribes/empire/toolsmithy/conf'
--- tribes/empire/toolsmithy/conf	2012-02-15 21:25:34 +0000
+++ tribes/empire/toolsmithy/conf	2013-01-06 16:42:22 +0000
@@ -21,6 +21,7 @@
 
 [aihints]
 build_material=false
+is_basic=true
 
 [working positions]
 toolsmith=1