Merge ~ack/maas:deb-to-snap-migration-fix-db-access into maas:master

[Alberto Donato]

LP: #1927340 - mas-deb-migrate: fix db patching process

This ensures bootsource entries are corretly updated when the migrating node is
a region controller, and uses Django rather than direct psql access to work
even if the database is not local

[Björn Tillenius (bjornt)]

+1

review: Approve

diff --git a/snap/local/tree/bin/maas-deb-migrate b/snap/local/tree/bin/maas-deb-migrate
index febca85..f646f0f 100755
--- a/snap/local/tree/bin/maas-deb-migrate
+++ b/snap/local/tree/bin/maas-deb-migrate
@@ -65,17 +65,21 @@ cleanup_data() {
 }
 
 apply_db_patches() {
-    if maas_snap_mode | grep -q "region"; then
-        snap_run "maas-region migrate"
+    if ! maas_snap_mode | grep -q "region"; then
+        return
     fi
 
+    snap_run "maas-region migrate"
     # patch the value of the default cloud images keyring to point to the one
     # in the snap
-    local keyring="/usr/share/keyrings/ubuntu-cloudimage-keyring.gpg"
-    cat <<EOF | pg_do psql maasdb
-UPDATE maasserver_bootsource
-SET keyring_filename = '${MAAS_SNAP}${keyring}'
-WHERE keyring_filename = '${keyring}'
+    cat <<EOF | snap_run "maas-region shell"
+from maasserver.models import BootSource
+keyring = "/usr/share/keyrings/ubuntu-cloudimage-keyring.gpg"
+(
+ BootSource.objects
+ .filter(keyring_filename=keyring)
+ .update(keyring_filename=f"/snap/maas/current{keyring}")
+)
 EOF
 }