Merge lp:~abreu-alexandre/webbrowser-app/better-control-webengine-lib-loaded into lp:webbrowser-app
Proposed by
Alexandre Abreu
Status: | Merged |
---|---|
Merged at revision: | 491 |
Proposed branch: | lp:~abreu-alexandre/webbrowser-app/better-control-webengine-lib-loaded |
Merge into: | lp:webbrowser-app |
Diff against target: |
41 lines (+7/-24) 1 file modified
src/app/webcontainer/WebappContainerWebview.qml (+7/-24) |
To merge this branch: | bzr merge lp:~abreu-alexandre/webbrowser-app/better-control-webengine-lib-loaded |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Ubuntu Phablet Team | Pending | ||
Review via email: mp+215280@code.launchpad.net |
Commit message
Make sure that we dont load unecessary libs (oxide or qtwebkit) correspnding to the webengine that we dont use.
Description of the change
Make sure that we dont load unecessary libs (oxide or qtwebkit) correspnding to the webengine that we dont use.
To post a comment you must log in.
I would rather call setSource() on Component. onCompleted, in order to set all the properties at construction time.