Code review comment for lp:~abreu-alexandre/webbrowser-app/better-control-webengine-lib-loaded

Revision history for this message
Olivier Tilloy (osomon) wrote :

> Delaying a bit the creation of the webview backend will hand off the value
> null (since
> it has not been created at qml property eval time) to the Webapps element and
> prevent
> the webapp from doing anything (even navigating).

How about, in src/app/webcontainer/WebApp.qml, lazy loading the UnityWebApps.UnityWebApps component when webview.currentWebview becomes not null? Then you could do what Alberto suggests.

Other than that the change looks sound, although I haven’t functionally tested it.

One minor suggestion: in the onLoaded slot, you don’t need to prefix 'item' with 'webappContainerWebViewLoader.', that would make the code easier to read.

« Back to merge proposal