Code review comment for lp:~abentley/launchpad/js-translation

Hi, Aaron.

This looks very good as a first branch in this work. Thanks!

Beyond the things I mentioned on IRC, I noticed you have several variables in the JavaScript test that are not bound locally with the var keyword. I'm assuming this is oversight and would ask you to fix this, unless you have a good reason to do so. While there is no negative consequence of this in the test that I see, I still think it's good practice unless you really mean the variables to be global. Especially since the behavior of js is opposite of Python in this regard.

Cheers,
deryck