Merge lp:~abentley/launchpad/js-translation into lp:launchpad

[Aaron Bentley]

= Summary =
Start implementing ajax support for sharing details page.

== Proposed fix ==

== Pre-implementation notes ==
Discussed with deryck

== Implementation details ==
Implemented TranslationSharingConfig, CheckItem and LinkCheckItem to represent
the state of the sharing config checklist. Updated the template so that the
branch-related text is always present in the DOM, with inactive text marked
with the "unseen" class.

Added pickers to select the branch, for the productseries. Implemented
TranslationSharingController to update the checklist in the model and the UI.

Setting the branch requires multiple steps of async IO, so I provided each step
a nested function. These were then chained together through their config
parameters so that each triggers the next.

Not yet implemented:
 - marking items disabled when they cannot be used
 - initializing the TranslationSharingController to the correct state

This is the first of a planned sequence of branches.

== Tests ==
Load lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html in your browser.

bin/test sharing_details
bin/test --layer=WindmillLayer sharing_details

== Demo and Q/A ==
enable the feature flag
ensure you control a productseries that is linked to by a sourcepackage
go to the +sharing-details page.
Click the branch edit link. You should get an inline branch picker.
When you select a branch, the page should be updated correctly. You should be
able to confirm the branch link on the productseries page.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/translations/templates/sourcepackage-sharing-details.pt
  lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js
  lib/lp/translations/templates/translation_sharing_config.pt
  lib/lp/translations/browser/tests/test_sharing_details.py
  lib/lp/translations/windmill/tests/test_sourcepackage_sharing_details.py
  lib/lp/translations/javascript/sourcepackage_sharing_details.js
  lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html
  lib/lp/translations/browser/sourcepackage.py

./lib/lp/translations/browser/tests/test_sharing_details.py
     331: Line exceeds 78 characters.

[Deryck Hodge (deryck)]

Hi, Aaron.

This looks very good as a first branch in this work. Thanks!

Beyond the things I mentioned on IRC, I noticed you have several variables in the JavaScript test that are not bound locally with the var keyword. I'm assuming this is oversight and would ask you to fix this, unless you have a good reason to do so. While there is no negative consequence of this in the test that I see, I still think it's good practice unless you really mean the variables to be global. Especially since the behavior of js is opposite of Python in this regard.

Cheers,
deryck

review: Approve (code)

=== modified file 'lib/lp/translations/browser/sourcepackage.py'
--- lib/lp/translations/browser/sourcepackage.py	2011-03-16 14:33:28 +0000
+++ lib/lp/translations/browser/sourcepackage.py	2011-03-21 18:13:21 +0000
@@ -11,6 +11,8 @@
     'SourcePackageTranslationSharingStatus',
     ]
 
+import cgi
+
 from zope.publisher.interfaces import NotFound
 
 from canonical.launchpad.webapp import (
@@ -148,6 +150,34 @@
                 'shared with the upstream project.')
 
     @property
+    def branch_link(self):
+        if self.has_upstream_branch:
+            # Normally should use BranchFormatterAPI(branch).link(None), but
+            # on this page, that information is redundant.
+            title = cgi.escape(self.upstream_branch.unique_name)
+            url = canonical_url(self.upstream_branch)
+        else:
+            title = ''
+            url = '#'
+        return '<a class="sprite branch link" href="%s">%s</a>' % (url, title)
+
+    @property
+    def branch_incomplete_class(self):
+        classes = ['sprite', 'no']
+        if self.has_upstream_branch:
+            classes.append('unseen')
+        if not self.is_packaging_configured:
+            classes.append("lowlight")
+        return ' '.join(classes)
+
+    @property
+    def branch_complete_class(self):
+        classes = ['sprite', 'yes']
+        if not self.has_upstream_branch:
+            classes.append('unseen')
+        return ' '.join(classes)
+
+    @property
     def is_packaging_configured(self):
         """Is a packaging link defined for this branch?"""
         return self.context.direct_packaging is not None
@@ -162,11 +192,15 @@
             return css_class + " lowlight"
 
     @property
+    def upstream_branch(self):
+        if not self.is_packaging_configured:
+            return None
+        return self.context.direct_packaging.productseries.branch
+
+    @property
     def has_upstream_branch(self):
         """Does the upstream series have a source code branch?"""
-        if not self.is_packaging_configured:
-            return False
-        return self.context.direct_packaging.productseries.branch is not None
+        return self.upstream_branch is not None
 
     @property
     def is_upstream_translations_enabled(self):

=== modified file 'lib/lp/translations/browser/tests/test_sharing_details.py'
--- lib/lp/translations/browser/tests/test_sharing_details.py	2011-03-16 16:04:38 +0000
+++ lib/lp/translations/browser/tests/test_sharing_details.py	2011-03-21 18:13:21 +0000
@@ -3,6 +3,12 @@
 
 __metaclass__ = type
 
+
+from soupmatchers import (
+    HTMLContains,
+    Tag,
+)
+
 from canonical.launchpad.testing.pages import (
     extract_text,
     find_tag_by_id,
@@ -333,16 +339,22 @@
             sourcepackage, no_login=True, rootsite="translations",
             view_name="+sharing-details")
 
+    def assertUnseen(self, browser, html_id):
+        branch_complete_unseen = Tag(html_id, 'li', attrs={
+            'id': html_id,
+            'class': lambda v: v and 'unseen' in v.split(' ')})
+        self.assertThat(browser.contents, HTMLContains(branch_complete_unseen))
+
     def test_checklist_unconfigured(self):
         # Without a packaging link, sharing is completely unconfigured
         sourcepackage = self._makeSourcePackage()
         browser = self._getSharingDetailsViewBrowser(sourcepackage)
         checklist = find_tag_by_id(browser.contents, 'sharing-checklist')
         self.assertIsNot(None, checklist)
+        self.assertUnseen(browser, 'branch-complete')
         self.assertTextMatchesExpressionIgnoreWhitespace("""
             Translation sharing configuration is incomplete.
-            No upstream project series has been linked. Change upstream link
-            No source branch exists for the upstream series.
+            .*
             Translations are not enabled on the upstream series.
             Automatic synchronization of translations is not enabled.""",
             extract_text(checklist))
@@ -353,11 +365,12 @@
         browser = self._getSharingDetailsViewBrowser(packaging.sourcepackage)
         checklist = find_tag_by_id(browser.contents, 'sharing-checklist')
         self.assertIsNot(None, checklist)
+        self.assertUnseen(browser, 'branch-complete')
         self.assertTextMatchesExpressionIgnoreWhitespace("""
             Translation sharing configuration is incomplete.
             Linked upstream series is .+ trunk series.
                 Change upstream link Remove upstream link
-            No source branch exists for the upstream series.
+            .*
             Translations are not enabled on the upstream series.
             Automatic synchronization of translations is not enabled.""",
             extract_text(checklist))
@@ -368,11 +381,12 @@
         browser = self._getSharingDetailsViewBrowser(sourcepackage)
         checklist = find_tag_by_id(browser.contents, 'sharing-checklist')
         self.assertIsNot(None, checklist)
+        self.assertUnseen(browser, 'branch-incomplete')
         self.assertTextMatchesExpressionIgnoreWhitespace("""
             Translation sharing with upstream is active.
             Linked upstream series is .+ trunk series.
                 Change upstream link Remove upstream link
-            Upstream source branch is .+[.]
+            .*
             Translations are enabled on the upstream project.
             Automatic synchronization of translations is enabled.""",
             extract_text(checklist))

=== added file 'lib/lp/translations/javascript/sourcepackage_sharing_details.js'
--- lib/lp/translations/javascript/sourcepackage_sharing_details.js	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/javascript/sourcepackage_sharing_details.js	2011-03-21 18:13:21 +0000
@@ -0,0 +1,233 @@
+/* Copyright 2011 Canonical Ltd.  This software is licensed under the
+ * GNU Affero General Public License version 3 (see the file LICENSE).
+ */
+
+YUI.add('lp.translations.sourcepackage_sharing_details', function(Y) {
+var namespace = Y.namespace('lp.translations.sourcepackage_sharing_details');
+
+/**
+ * This class represents the state of a checklist item.
+ */
+function CheckItem(config){
+    CheckItem.superclass.constructor.apply(this, arguments);
+}
+CheckItem.ATTRS = {
+    // Optional reference to an item that must be completed before setting
+    // this.
+    dependency: {value: null},
+    // True if this item is enabled.
+    enabled: {
+        getter: function(){
+            if (Y.Lang.isNull(this.get('dependency'))){
+                return true;
+            }
+            return this.get('dependency').get('complete');
+        }
+    },
+    // The HTML identifier of the item.
+    identifier: null
+}
+Y.extend(CheckItem, Y.Base, {
+})
+
+namespace.CheckItem = CheckItem;
+
+/**
+ * This class reflects the state of a Checklist item that holds a link.
+ */
+function LinkCheckItem(){
+    LinkCheckItem.superclass.constructor.apply(this, arguments)
+}
+LinkCheckItem.ATTRS = {
+    // This item is complete if _text is set.
+    complete: {getter:
+        function() {
+            return !Y.Lang.isNull(this.get('_text'))
+        }
+    },
+    // _text is unset by default.
+    _text: {value: null},
+    // text is read-only.
+    text: {getter:
+        function(){
+            return this.get('_text');
+        }
+    },
+    // _url is unset by default.
+    _url: {value: null},
+    // text is read-only.
+    url: { getter:
+        function(){
+            return this.get('_url');
+        }
+    },
+}
+Y.extend(LinkCheckItem, CheckItem, {
+    /**
+     * Set the text and URL of the link for this LinkCheckItem.
+     */
+    set_link: function(text, url){
+        this.set('_text', text);
+        this.set('_url', url);
+    }
+});
+
+namespace.LinkCheckItem = LinkCheckItem;
+
+/**
+ * This class represents the state of the translation sharing config
+ * checklist.
+ */
+function TranslationSharingConfig (config){
+    TranslationSharingConfig.superclass.constructor.apply(this, arguments)
+}
+Y.extend(TranslationSharingConfig, Y.Base, {
+    initializer: function(){
+        var product_series = new LinkCheckItem(
+            {identifier: 'product-series'});
+        this.set('product_series', product_series);
+        var usage = new CheckItem(
+            {identifier: 'usage', dependency: product_series});
+        this.set('translation_usage', usage);
+        var branch = new LinkCheckItem(
+            {identifier: 'branch', dependency: this.get('product_series')});
+        this.set('branch', branch);
+        var autoimport = new CheckItem(
+            {identifier: 'autoimport', dependency: branch});
+        this.set('autoimport', autoimport);
+        this.set('all_items', [product_series, usage, branch, autoimport]);
+    }
+});
+namespace.TranslationSharingConfig = TranslationSharingConfig;
+
+/**
+ * This class is the controller for updating the TranslationSharingConfig.
+ * It handles updating the HTML and the DB model.
+ */
+function TranslationSharingController (config){
+    TranslationSharingController.superclass.constructor.apply(
+        this, arguments);
+}
+Y.extend(TranslationSharingController, Y.Base, {
+    initializer: function(source_package){
+        this.set('source_package', source_package);
+        this.set('productseries_link', source_package['productseries_link']);
+        this.set('tsconfig', new TranslationSharingConfig());
+    },
+    /*
+     * Select the specified branch as the translation branch.
+     *
+     * @param branch_summary {Object} An object containing api_url, css,
+     * description, value, title
+     */
+    select_branch: function(branch_summary){
+        var that = this;
+        var lp_client = new Y.lp.client.Launchpad();
+        var error_handler = new Y.lp.client.ErrorHandler();
+        error_handler.showError = function(error_msg) {
+            Y.lp.app.errors.display_error(Y.one('#branch'), error_msg);
+        }
+        /**
+         * Return an LP client config using error_handler.
+         *
+         * @param next {Object} A callback to call on success.
+         */
+        function get_config(next){
+            var config = {
+                on:{
+                    success: next,
+                    failure: error_handler.getFailureHandler()
+                }
+            };
+            return config;
+        }
+        /**
+         * Return an LP client config that will call the specified callbacks
+         * in sequence, using error_handler.
+         *
+         * @param next {Object} A callback to call on success.
+         */
+        function chain_config(){
+            var last_config;
+            // Each callback is bound to the next, so we use reverse order.
+            for(var i = arguments.length-1; i >= 0; i--){
+                if (i == arguments.length - 1)
+                    callback = arguments[i];
+                else
+                    callback = Y.bind(arguments[i], this, last_config);
+                last_config = get_config(callback);
+            }
+            return last_config;
+        }
+
+        /* Here begin a series of methods which each represent a step in
+         * setting the branch.  They each take a config to use in an lp_client
+         * call, except the last one.  This allows them to be chained
+         * together.
+         *
+         * They take full advantage of their access to variables in the
+         * closure, such as "that" and "branch_summary".
+         */
+        function get_productseries(config){
+            lp_client.get(that.get('productseries_link'), config);
+        }
+        function save_branch(config, productseries){
+            productseries.set('branch_link', branch_summary['api_uri']);
+            productseries.lp_save(config);
+        }
+        function get_branch(config){
+            lp_client.get(branch_summary['api_uri'], config);
+        }
+        function set_link(branch){
+            that.get('tsconfig').get('branch').set_link(
+                branch.get('unique_name'), branch.get('web_link'));
+            that.update();
+        }
+        get_productseries(chain_config(save_branch, get_branch, set_link));
+    },
+    /**
+     * Update the display of all checklist items.
+     */
+    update: function(){
+        var branch = this.get('tsconfig').get('branch');
+        this.update_check(branch);
+    },
+    /**
+     * Update the display of a single checklist item.
+     */
+    update_check: function(check){
+        var complete = Y.one('#' + check.get('identifier') + '-complete');
+        var link = complete.one('a.link');
+        link.set('href', check.get('url'));
+        link.set('text', check.get('text'));
+        complete.toggleClass('unseen', !check.get('complete'));
+        var incomplete = Y.one('#' + check.get('identifier') + '-incomplete');
+        incomplete.toggleClass('unseen', check.get('complete'));
+    },
+});
+namespace.TranslationSharingController = TranslationSharingController;
+
+
+/**
+ * Method to prepare the AJAX translation sharing config functionality.
+ */
+namespace.prepare = function(source_package){
+    var sharing_controller = new namespace.TranslationSharingController(
+        source_package);
+    sharing_controller.update();
+    var config = {
+        picker_activator: '#branch-incomplete-picker a',
+        header : 'Select translation branch',
+        step_title: 'Search',
+        save: Y.bind('select_branch', sharing_controller)
+    };
+    var picker = Y.lp.app.picker.create('Branch', config);
+    var config = {
+        picker_activator: '#branch-complete-picker a',
+        header : 'Select translation branch',
+        step_title: 'Search',
+        save: Y.bind('select_branch', sharing_controller)
+    };
+    var picker2 = Y.lp.app.picker.create('Branch', config);
+};
+}, "0.1", {"requires": ['lp.app.errors', 'lp.app.picker', 'oop']})

=== added directory 'lib/lp/translations/javascript/tests'
=== added file 'lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html'
--- lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html	2011-03-21 18:13:21 +0000
@@ -0,0 +1,34 @@
+<html>
+  <head>
+    <title>Launchpad translationsharingconfig</title>
+    <!-- YUI 3.0 Setup -->
+    <script type="text/javascript" src="../../../../canonical/launchpad/icing/yui/yui/yui.js"></script>
+    <script type="text/javascript"
+      src="../../../../canonical/launchpad/icing/lazr/build/lazr.js"></script>
+    <link rel="stylesheet"
+      href="../../../../canonical/launchpad/icing/yui/cssreset/reset.css"/>
+    <link rel="stylesheet"
+      href="../../../../canonical/launchpad/icing/yui/cssfonts/fonts.css"/>
+    <link rel="stylesheet"
+      href="../../../../canonical/launchpad/icing/yui/cssbase/base.css"/>
+    <link rel="stylesheet"
+      href="../../../../canonical/launchpad/javascript/test.css" />
+
+    <!-- The module under test -->
+    <script type="text/javascript" src="../sourcepackage_sharing_details.js"></script>
+
+    <!-- The test suite -->
+    <script type="text/javascript" src="test_sourcepackage_sharing_details.js"></script>
+  </head>
+  <body class="yui3-skin-sam">
+
+    <!-- The example markup required by the script to run -->
+    <div id="expected-id">
+      <div id="branch-complete">Branch selected: <a href="#" class="link"></a>
+      </div>
+      <div id="branch-incomplete">No branch selected.</div>
+    </div>
+    <!-- The test output -->
+    <div id="log"></div>
+  </body>
+</html>

=== added file 'lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js'
--- lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js	2011-03-21 18:13:21 +0000
@@ -0,0 +1,105 @@
+/* Copyright 2011 Canonical Ltd.  This software is licensed under the
+ * GNU Affero General Public License version 3 (see the file LICENSE).
+ */
+
+YUI({
+    base: '../../../../canonical/launchpad/icing/yui/',
+    filter: 'raw', combine: false,
+    fetchCSS: false
+    }).use('test', 'console', 'lp.translations.sourcepackage_sharing_details',
+    function(Y) {
+    var suite = new Y.Test.Suite("sourcepackage_sharing_details Tests");
+    var namespace = Y.lp.translations.sourcepackage_sharing_details
+    var TranslationSharingConfig = namespace.TranslationSharingConfig
+    var TranslationSharingController = namespace.TranslationSharingController
+    var CheckItem = (
+      Y.lp.translations.sourcepackage_sharing_details.CheckItem)
+    var LinkCheckItem = (
+      Y.lp.translations.sourcepackage_sharing_details.LinkCheckItem)
+
+    suite.add(new Y.Test.Case({
+        // Test the setup method.
+        name: 'setup',
+
+        test_translation_usage_enabled: function() {
+            var sharing_config = new TranslationSharingConfig();
+            var usage = sharing_config.get('translation_usage')
+            Y.Assert.isFalse(usage.get('enabled'));
+            sharing_config.get('product_series').set_link('ps', 'http://')
+            Y.Assert.isTrue(usage.get('enabled'));
+        },
+        test_branch: function() {
+            var sharing_config = new TranslationSharingConfig();
+            var product_series = sharing_config.get('product_series')
+            Y.Assert.isFalse(product_series.get('complete'));
+            Y.Assert.isFalse(sharing_config.get('branch').get('enabled'));
+            product_series.set_link('ps', 'http://')
+            Y.Assert.isTrue(sharing_config.get('branch').get('enabled'));
+        },
+        test_autoimport: function() {
+            var sharing_config = new TranslationSharingConfig();
+            Y.Assert.isFalse(sharing_config.get('autoimport').get('enabled'));
+            sharing_config.get('branch').set_link('br', 'http://foo')
+            Y.Assert.isTrue(sharing_config.get('autoimport').get('enabled'));
+        },
+        test_LinkCheckItem_contents: function() {
+            var lci = new LinkCheckItem()
+            Y.Assert.isNull(lci.get('text'));
+            Y.Assert.isNull(lci.get('url'));
+            lci.set_link('mytext', 'http://example.com');
+            Y.Assert.areEqual('mytext', lci.get('text'));
+            Y.Assert.areEqual('http://example.com', lci.get('url'));
+        },
+        test_LinkCheckItem_complete: function() {
+            var lci = new LinkCheckItem()
+            Y.Assert.isFalse(lci.get('complete'));
+            lci.set_link('text', 'http://example.com');
+            Y.Assert.isTrue(lci.get('complete'));
+        },
+        test_CheckItem_enabled: function() {
+            var ci = new CheckItem();
+            Y.Assert.isTrue(ci.get('enabled'));
+        },
+        test_CheckItem_enabled_dependency: function(){
+            var lci = new LinkCheckItem()
+            var ci = new CheckItem({dependency: lci})
+            Y.Assert.isFalse(ci.get('enabled'))
+            lci.set_link('text', 'http://example.com');
+            Y.Assert.isTrue(ci.get('enabled'))
+        },
+        test_CheckItem_identifier: function(){
+            var ci = new CheckItem({identifier: 'id1'});
+            Y.Assert.areEqual('id1', ci.get('identifier'))
+        },
+        test_update_branch: function(){
+            var complete = Y.one('#branch-complete')
+            var incomplete = Y.one('#branch-incomplete')
+            var link = Y.one('#branch-complete a')
+            Y.Assert.areEqual('', link.get('text'))
+            Y.Assert.areNotEqual('http:///', link.get('href'))
+            Y.Assert.isFalse(complete.hasClass('unseen'))
+            Y.Assert.isFalse(incomplete.hasClass('unseen'))
+            var ctrl = new TranslationSharingController({})
+            ctrl.update()
+            Y.Assert.isTrue(complete.hasClass('unseen'))
+            Y.Assert.isFalse(incomplete.hasClass('unseen'))
+            ctrl.get('tsconfig').get('branch').set_link('a', 'http:///')
+            ctrl.update()
+            Y.Assert.isFalse(complete.hasClass('unseen'))
+            Y.Assert.isTrue(incomplete.hasClass('unseen'))
+            var link = Y.one('#branch-complete a')
+            Y.Assert.areEqual('a', link.get('text'))
+            Y.Assert.areEqual('http:///', link.get('href'))
+        }
+    }));
+
+    // Lock, stock, and two smoking barrels.
+    Y.Test.Runner.add(suite);
+
+    var console = new Y.Console({newestOnTop: false});
+    console.render('#log');
+
+    Y.on('domready', function() {
+        Y.Test.Runner.run();
+        });
+});

=== modified file 'lib/lp/translations/templates/sourcepackage-sharing-details.pt'
--- lib/lp/translations/templates/sourcepackage-sharing-details.pt	2011-03-15 19:15:18 +0000
+++ lib/lp/translations/templates/sourcepackage-sharing-details.pt	2011-03-21 18:13:21 +0000
@@ -7,6 +7,16 @@
   i18n:domain="launchpad"
 >
   <body>
+    <metal:block fill-slot="head_epilogue">
+      <script type="text/javascript">
+        LPS.use('lp.translations.sourcepackage_sharing_details', function(Y) {
+          Y.on('domready', function() {
+              Y.lp.translations.sourcepackage_sharing_details.prepare(
+                LP.cache['context']);
+          });
+        });
+      </script>
+    </metal:block>
     <div metal:fill-slot="heading">
       <h1>Translation sharing details</h1>
     </div>
@@ -34,19 +44,22 @@
               <a tal:replace="structure context/menu:overview/edit_packaging/fmt:icon" />
               <a tal:replace="structure context/menu:overview/remove_packaging/fmt:icon" />
             </li>
-            <li tal:attributes="class view/no_item_class"
-                tal:condition="not:view/has_upstream_branch">
+            <li tal:attributes="class view/branch_incomplete_class"
+                id="branch-incomplete">
               No source branch exists for the upstream series.
+              <span id="branch-incomplete-picker">
               <a tal:condition="view/is_packaging_configured"
-                 tal:replace="structure context/productseries/menu:overview/set_branch/fmt:icon" />
+                tal:replace="structure context/productseries/menu:overview/set_branch/fmt:icon" />
+              </span>
             </li>
-            <li class="sprite yes"
-                tal:condition="view/has_upstream_branch">
-              Upstream source branch is
-              <a tal:replace="structure context/productseries/branch/fmt:link">
-                lp:gimp</a>.
+            <li tal:attributes="class view/branch_complete_class"
+                id="branch-complete">
+            Upstream source branch is
+              <a tal:replace="structure view/branch_link">lp:gimp</a>.
+              <span id="branch-complete-picker">
               <a tal:condition="view/is_packaging_configured"
-                 tal:replace="structure context/productseries/menu:overview/set_branch/fmt:icon" />
+                tal:replace="structure context/productseries/menu:overview/set_branch/fmt:icon" />
+              </span>
             </li>
             <li tal:attributes="class view/no_item_class"
                 tal:condition="not:view/is_upstream_translations_enabled">

=== added file 'lib/lp/translations/windmill/tests/test_sourcepackage_sharing_details.py'
--- lib/lp/translations/windmill/tests/test_sourcepackage_sharing_details.py	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/windmill/tests/test_sourcepackage_sharing_details.py	2011-03-21 18:13:21 +0000
@@ -0,0 +1,57 @@
+# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Tests for sharing details page."""
+
+
+__metaclass__ = type
+
+
+import transaction
+
+from canonical.launchpad.webapp import canonical_url
+from lp.testing import (
+    feature_flags,
+    set_feature_flag,
+    WindmillTestCase,
+)
+from lp.testing.windmill import (
+    lpuser,
+)
+from lp.testing.windmill.constants import (
+    FOR_ELEMENT,
+    PAGE_LOAD,
+)
+from lp.testing.windmill.widgets import (
+    search_and_select_picker_widget,
+)
+from lp.translations.windmill.testing import (
+    TranslationsWindmillLayer,
+)
+
+
+class TestSharingDetails(WindmillTestCase):
+
+    layer = TranslationsWindmillLayer
+
+    def test_set_branch(self):
+        packaging = self.factory.makePackagingLink()
+        self.useContext(feature_flags())
+        set_feature_flag(u'translations.sharing_information.enabled', u'on')
+        transaction.commit()
+        url = canonical_url(
+            packaging.sourcepackage, rootsite='translations',
+            view_name='+sharing-details')
+        self.client.open(url=url)
+        self.client.waits.forPageLoad(timeout=PAGE_LOAD)
+        lpuser.TRANSLATIONS_ADMIN.ensure_login(self.client)
+        self.client.waits.forElement(
+            id='branch-incomplete', timeout=FOR_ELEMENT)
+        self.client.click(xpath='//*[@id="branch-incomplete-picker"]/a')
+        search_and_select_picker_widget(self.client, 'firefox', 1)
+        self.client.waits.forElementProperty(
+            classname="unseen", option='id|branch-incomplete',
+            timeout=FOR_ELEMENT)
+        transaction.commit()
+        branch = packaging.productseries.branch
+        self.assertEqual('~name12/firefox/main', branch.unique_name)