Code review comment for lp:~aacid/unity8/search_history_pointer_correct_pointer_position
Revision history for this message
| Andrea Cimitan (cimi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> It is both a workaround and not a workaround at the same time.
>
> It is a workaround because by reading the documentation it seems that it
> should work without this patch.
>
> It is not a workaround because by reading the documentation there's nothing
> that says that our previous code is better than the new code.
>
> So I am not convinced adding a FIXME makes sense because the code is correct
> too with this patch in.
I'd still add a comment with a link to the bug...