Merge lp:~aacid/unity8/search_history_pointer_correct_pointer_position into lp:unity8

[Albert Astals Cid]

Position correctly the pointer of the search history box

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:568
http://jenkins.qa.ubuntu.com/job/unity8-ci/1803/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1358
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1331
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/530
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/326
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/327
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/327/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/326
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1208
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1358
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1358/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1331
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1331/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3870
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1993

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1803/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Cimitan (cimi)]

Is this a workaround? If that's the case, I'd add a comment // FIXME workaround with a link to https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1208833

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:568
http://jenkins.qa.ubuntu.com/job/unity8-ci/1805/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1376
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1349
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/535
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/328
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/329
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/328
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1223
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1376
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1376/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1349
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1349/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3887
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2011

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1805/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

It is both a workaround and not a workaround at the same time.

It is a workaround because by reading the documentation it seems that it should work without this patch.

It is not a workaround because by reading the documentation there's nothing that says that our previous code is better than the new code.

So I am not convinced adding a FIXME makes sense because the code is correct too with this patch in.

[Andrea Cimitan (cimi)]

> It is both a workaround and not a workaround at the same time.
>
> It is a workaround because by reading the documentation it seems that it
> should work without this patch.
>
> It is not a workaround because by reading the documentation there's nothing
> that says that our previous code is better than the new code.
>
> So I am not convinced adding a FIXME makes sense because the code is correct
> too with this patch in.

I'd still add a comment with a link to the bug...

[Andrea Cimitan (cimi)]

just to remember *why* we do things ad issues related "still opened"

[Albert Astals Cid (aacid)]

As i said, the new code is fine by itself, so i don't see why it should point to a bug that has nothing to do with the new code.

[Michał Sawicz (saviq)]

No comment needed, if the code is correct regardless.

[Michał Sawicz (saviq)]

BTW, where it *should* be commented, if anywhere - is the SDK docs. As in - they need fixing, if what we were doing before was incorrect (which, again, the docs say it is).

[Michał Sawicz (saviq)]

Cimi?

[Andrea Cimitan (cimi)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/898/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3747
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1957
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1871
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/772
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/284
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/284
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/284/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/284
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1726
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1957
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1957/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1871
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1871/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4348
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2657

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/899/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1958
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1872/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/773
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/285
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/285
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/285/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/285
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1727
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1958
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1958/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1872
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1872/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4349/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2659

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'Components/PageHeader.qml'
--- Components/PageHeader.qml	2013-11-19 14:33:40 +0000
+++ Components/PageHeader.qml	2013-12-02 17:50:35 +0000
@@ -141,9 +141,8 @@
 
                 function openPopover() {
                     if (searchHistory.count > 0) {
-                        searchContainer.popover = PopupUtils.open(popoverComponent, searchField,
+                        searchContainer.popover = PopupUtils.open(popoverComponent, pointerPositioner,
                                                                   {
-                                                                      "pointerTarget": pointerPositioner,
                                                                       "contentWidth": searchField.width,
                                                                       "edgeMargins": units.gu(1)
                                                                   }