Unity 8

Code review comment for lp:~aacid/unity8/search_history_pointer_correct_pointer_position

  1. search_history_pointer_correct_pointer_position
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

It is both a workaround and not a workaround at the same time.

It is a workaround because by reading the documentation it seems that it should work without this patch.

It is not a workaround because by reading the documentation there's nothing that says that our previous code is better than the new code.

So I am not convinced adding a FIXME makes sense because the code is correct too with this patch in.

« Back to merge proposal