Code review comment for lp:~aacid/unity8/halveUpdateCardDataCalls

Revision history for this message
Albert Astals Cid (aacid) wrote :

Branch is wrong :/

Even if we're not using template in updateCardData we need to regenerate the card data when the template changes since potentially the sourceComponent has changed and thus the new item needs new contents.

Now one could remove this line and put a call to updateCardData on onSourceComponentChanged or put a call to updateCardData in onLoaded but both result in more updateCardData than the current scheme.

Numbers when running make xvfbtestCard
without this branch: 352 calls
with this branch [broken]: 211 calls
with this branch + onSourceComponentChanged: 428 calls
with this branch + onLoaded: 428 calls

review: Disapprove

« Back to merge proposal