Merge lp:~aacid/unity8/halveUpdateCardDataCalls into lp:unity8
| Status: | Rejected |
|---|---|
| Rejected by: | Albert Astals Cid on 2016-06-15 |
| Proposed branch: | lp:~aacid/unity8/halveUpdateCardDataCalls |
| Merge into: | lp:unity8 |
| Diff against target: |
11 lines (+0/-1) 1 file modified
qml/Dash/CardTool.qml (+0/-1) |
| To merge this branch: | bzr merge lp:~aacid/unity8/halveUpdateCardDataCalls |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | Disapprove on 2016-06-15 | ||
| Andrea Cimitan (community) | 2016-06-08 | Approve on 2016-06-09 | |
| Unity8 CI Bot | continuous-integration | Approve on 2016-06-08 | |
|
Review via email:
|
|||
Commit Message
Halve number of calls to updateCardData
We're not using template in the function anymore so no need to call it when it changes.
It doesn't really make things much faster since the second call is not recreating anything but saves us a bit of time
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Albert Astals Cid (aacid) wrote : | # |
Branch is wrong :/
Even if we're not using template in updateCardData we need to regenerate the card data when the template changes since potentially the sourceComponent has changed and thus the new item needs new contents.
Now one could remove this line and put a call to updateCardData on onSourceCompone
Numbers when running make xvfbtestCard
without this branch: 352 calls
with this branch [broken]: 211 calls
with this branch + onSourceCompone
with this branch + onLoaded: 428 calls
Unmerged revisions
- 2442. By Albert Astals Cid on 2016-06-08
-
Halve number of calls to updateCardData
It doesn't really make things much faster since the second call is not recreating anything but saves us a bit of time
- 2441. By Launchpad Translations on behalf of unity-team on 2016-06-02
-
Launchpad automatic translations update.
PASSED: Continuous integration, rev:2442
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/