Merge lp:~aacid/unity8/halveUpdateCardDataCalls into lp:unity8

[Albert Astals Cid]

Halve number of calls to updateCardData

We're not using template in the function anymore so no need to call it when it changes.

It doesn't really make things much faster since the second call is not recreating anything but saves us a bit of time

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2442
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1445/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1922
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/984
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/984
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/984
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1948
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1884
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1884
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1884
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1875/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1875
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1875/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1445/rebuild

review: Approve (continuous-integration)

[Andrea Cimitan (cimi)]

even CI likes it

review: Approve

[Albert Astals Cid (aacid)]

Branch is wrong :/

Even if we're not using template in updateCardData we need to regenerate the card data when the template changes since potentially the sourceComponent has changed and thus the new item needs new contents.

Now one could remove this line and put a call to updateCardData on onSourceComponentChanged or put a call to updateCardData in onLoaded but both result in more updateCardData than the current scheme.

Numbers when running make xvfbtestCard
without this branch: 352 calls
with this branch [broken]: 211 calls
with this branch + onSourceComponentChanged: 428 calls
with this branch + onLoaded: 428 calls

review: Disapprove

Unmerged revisions

2442. By Albert Astals Cid on 2016-06-08

Halve number of calls to updateCardData

It doesn't really make things much faster since the second call is not recreating anything but saves us a bit of time

2441. By Launchpad Translations on behalf of unity-team on 2016-06-02

Launchpad automatic translations update.

=== modified file 'qml/Dash/CardTool.qml'
--- qml/Dash/CardTool.qml	2016-05-09 08:34:38 +0000
+++ qml/Dash/CardTool.qml	2016-06-08 18:04:17 +0000
@@ -220,7 +220,6 @@
         }
         Connections {
             target: cardTool
-            onTemplateChanged: cardLoader.updateCardData();
             onComponentsChanged: cardLoader.updateCardData();
         }
         function updateCardData() {