Code review comment for lp:~aacid/unity8/fix_indicators_update_state

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> > The change to the tests doesn't test the issue. If succeeds whether the
> change
> > in IndicatorsMenu exists or not. You can test by updating unitProgress
> without
> > having an active bar.
>
> You are right, the change in the test is not to test the change, is to make it
> so that the test still works, did not feel the need to add a qmltest to check
> this is working since the autopilot test was already failing sometimes without
> this so we actually already have something that makes sure this is needed.

ok, fine.

review: Approve

« Back to merge proposal