Merge lp:~aacid/unity8/fix_indicators_update_state into lp:unity8
Status: | Merged |
---|---|
Approved by: | Nick Dedekind |
Approved revision: | 1797 |
Merged at revision: | 1871 |
Proposed branch: | lp:~aacid/unity8/fix_indicators_update_state |
Merge into: | lp:unity8 |
Prerequisite: | lp:~aacid/unity8/oxide_regression_workaround |
Diff against target: |
46 lines (+8/-1) 3 files modified
qml/Panel/IndicatorsMenu.qml (+1/-1) tests/autopilot/unity8/indicators/__init__.py (+1/-0) tests/qmltests/Panel/tst_IndicatorsMenu.qml (+6/-0) |
To merge this branch: | bzr merge lp:~aacid/unity8/fix_indicators_update_state |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Nick Dedekind (community) | Approve | ||
Unity Team | Pending | ||
Review via email: mp+260291@code.launchpad.net |
This proposal supersedes a proposal from 2015-05-26.
Commit message
Update state of indicators bar only when the user is actively dragging himself
Fixes race with timer causing bug 1457044
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
* Did you have a look at the warnings when running tests? Can they be reduced?
Yes, not introducing any new warning
FAILED: Continuous integration, rev:1793 jenkins. qa.ubuntu. com/job/ unity8- ci/5765/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 44 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- wily/28/ console jenkins. qa.ubuntu. com/job/ unity8- wily-amd64- ci/43 jenkins. qa.ubuntu. com/job/ unity8- wily-i386- ci/43 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- wily-mako/ 34 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 44 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 44/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 20734
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5765/ rebuild
http://