Code review comment for lp:~aacid/unity-2d/unity-2d_test_alt_f2_pops_dash

Revision history for this message
Albert Astals Cid (aacid) wrote :

@Lohith:
 1) Well, my idea was starting a file that would hold various places tests, as you can see it does not only old "alt-f2" test but also "click-bfb-to-show" test, so "places-alt-f2-tests.rb" wouldn't be a good name either. If you guys think that having a broad naming so it can hold more tests in the future is not a good idea i can rename it to something like places-showing-tests.rb
 2) Fixed!
 3) Well the idea of the test is making sure the dash is opened by both alt+f2 and clicking in the bfb, the fact that it opens one thing or another is not what we wanted to check here (What we wanted to check is that moving from dbus activation to in-process activation (in the -shell) the affected code paths work)

« Back to merge proposal