Merge lp:~aacid/unity-2d/unity-2d_test_alt_f2_pops_dash into lp:unity-2d

[Albert Astals Cid]

[test] Test that Alt+F2 and that clicking the bfb show the Dash

[lp:~aacid/unity-2d/unity-2d_test_alt_f2_pops_dash]

864. By Albert Astals Cid on 2012-01-24

merge

865. By Albert Astals Cid on 2012-01-24

port to the target/host split

[Gerry Boland (gerboland)]

Rogue comments:
+ # check width before proceeding
in two places.

But is great aside from that.

review: Needs Fixing

[Lohith D Shivamurthy (dyams)]

Three points I noticed:
1) Isn't the places-tests.rb is very generic, something like places-alt-f2-tests.rb is more suitable.
2) 'context "Launcher Autohide and Show Tests"' Needs to changed to suitable string like 'Dash Alt-F2 Tests'?
3) Verifying only dash is visible is not sufficient to confirm that it is 'Run a command' prompt. Should you also verify the text in search_entry? Or Do i miss something here?

review: Needs Fixing

[lp:~aacid/unity-2d/unity-2d_test_alt_f2_pops_dash]

866. By Albert Astals Cid on 2012-01-25

merge

867. By Albert Astals Cid on 2012-01-25

Remove two out-of-place comments spotted by Gerry

868. By Albert Astals Cid on 2012-01-25

Fix context name

[Albert Astals Cid (aacid)]

@Gerry: Removed the wrong comments

[Albert Astals Cid (aacid)]

@Lohith:
 1) Well, my idea was starting a file that would hold various places tests, as you can see it does not only old "alt-f2" test but also "click-bfb-to-show" test, so "places-alt-f2-tests.rb" wouldn't be a good name either. If you guys think that having a broad naming so it can hold more tests in the future is not a good idea i can rename it to something like places-showing-tests.rb
 2) Fixed!
 3) Well the idea of the test is making sure the dash is opened by both alt+f2 and clicking in the bfb, the fact that it opens one thing or another is not what we wanted to check here (What we wanted to check is that moving from dbus activation to in-process activation (in the -shell) the affected code paths work)

[Lohith D Shivamurthy (dyams)]

@Albert:
Agreed!
1) No, its not the question of avoiding the generic names. Ideally speaking places-tests.rb can include every test case involving places, but we won't put all tests involving places into in a single file. no?
2) Thanks
3) Ok, then its fine.

[Albert Astals Cid (aacid)]

As discussed on IRC 1) is fine for the moment, we'll move it later if needed

[Gerry Boland (gerboland)]

Ok, I think we're in agreement, merging!
Thanks Albert.

review: Approve

=== added file 'tests/places/places-tests.rb'
--- tests/places/places-tests.rb	1970-01-01 00:00:00 +0000
+++ tests/places/places-tests.rb	2012-01-25 08:54:24 +0000
@@ -0,0 +1,122 @@
+#!/usr/bin/env ruby1.8
+=begin
+/*
+ * This file is part of unity-2d
+ *
+ * Copyright 2012 Canonical Ltd.
+ *
+ * Authors:
+ * - Albert Astals Cid <[e-mail]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+=end
+
+require '../run-tests.rb' unless $INIT_COMPLETED
+require 'xdo/xwindow'
+require 'xdo/keyboard'
+require 'xdo/mouse'
+require 'tmpwindow'
+
+############################# Test Suite #############################
+context "Dash Tests" do
+  # Run once at the beginning of this test suite
+  startup do
+    $SUT.execute_shell_command 'killall unity-2d-places'
+    $SUT.execute_shell_command 'killall unity-2d-places'
+
+    $SUT.execute_shell_command 'killall unity-2d-launcher'
+    $SUT.execute_shell_command 'killall unity-2d-launcher'
+
+    # Minimize all windows
+    XDo::XWindow.toggle_minimize_all
+  end
+
+  # Run once at the end of this test suite
+  shutdown do
+  end
+
+  # Run before each test case begins
+  setup do
+    # Execute the application 
+    @app_launcher = $SUT.run( :name => UNITY_2D_LAUNCHER, 
+                              :arguments => "-testability", 
+                              :sleeptime => 2 )
+
+    @app_places = $SUT.run( :name => UNITY_2D_PLACES, 
+                              :arguments => "-testability", 
+                              :sleeptime => 2 )
+
+  end
+
+  # Run after each test case completes
+  teardown do
+    TmpWindow.close_all_windows
+    #Need to kill Launcher as it does not shutdown when politely asked
+    $SUT.execute_shell_command 'pkill -nf unity-2d-launcher'
+    $SUT.execute_shell_command 'pkill -nf unity-2d-places'
+  end
+
+  #####################################################################################
+  # Test casess
+
+  # Test case objectives:
+  #   * Check that Alt+F2 shows dash
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Verify dash is not showing
+  #   * Press Alt+F2
+  #   * Verify dash is showing
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Alt+F2 shows the Dash" do
+    verify_not(0, 'There should not be a Dash declarative view on startup') {
+      @app_places.DashDeclarativeView()
+    }
+    XDo::Keyboard.alt_F2 #Must use uppercase F to indicate function keys
+    verify(TIMEOUT, 'There should be a Dash declarative view after pressing Alt+F2') {
+      @app_places.DashDeclarativeView()
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that pressing the bfb shows the dash
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Verify dash is not showing
+  #   * Click on the bfb
+  #   * Verify dash is showing
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Pressing the bfb shows the Dash" do
+    verify_not(0, 'There should not be a Dash declarative view on startup') {
+      @app_places.DashDeclarativeView()
+    }
+    bfb = @app_launcher.LauncherList( :name => 'main' ).LauncherList( :isBfb => true );
+    XDo::Mouse.move(0, 200, 0, true)
+    verify_equal( 0, TIMEOUT, 'Launcher hiding when mouse at left edge of screen' ) {
+      @app_launcher.Unity2dPanel()['x_absolute'].to_i
+    }
+    bfb.move_mouse()
+    bfb.tap()
+    verify(TIMEOUT, 'There should be a Dash declarative view after activating the bfb') {
+        @app_places.DashDeclarativeView()
+    }
+  end
+end