Code review comment for lp:~aacid/unity-2d/unity-2d_test_alt_f2_pops_dash

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Three points I noticed:
1) Isn't the places-tests.rb is very generic, something like places-alt-f2-tests.rb is more suitable.
2) 'context "Launcher Autohide and Show Tests"' Needs to changed to suitable string like 'Dash Alt-F2 Tests'?
3) Verifying only dash is visible is not sufficient to confirm that it is 'Run a command' prompt. Should you also verify the text in search_entry? Or Do i miss something here?

review: Needs Fixing

« Back to merge proposal