Code review comment for lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint

Revision history for this message
Loïc Molinari (loic.molinari) wrote :

The metrics library is now ready to be reviewed here [1]. Maybe we can discuss the naming there, the main reason being that it contains all kind of metrics (to be either logged to various devices and rendered as an overlay on top of QtQuick windows).

In light of this new library, I think it makes it's more consistent to integrate the feature proposed in this MR directly with the new library. So, Albert, I basically ported and integrated your nice work to the new lib in these 3 MRs [2][3][4].

[1] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics/+merge/302362
[2] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-lttng/+merge/302363
[3] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-generic-events/+merge/302364
[4] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-module/+merge/302365

« Back to merge proposal