Ubuntu UI Toolkit

Merge lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint into lp:ubuntu-ui-toolkit/staging

lttng_ui_ready_tracepoint
Merge into staging

Proposed by Albert Astals Cid on 2016-06-29

Status:	Rejected
Rejected by:	Albert Astals Cid on 2016-08-09
Proposed branch:	lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint
Merge into:	lp:ubuntu-ui-toolkit/staging
Diff against target:	342 lines (+235/-3) 11 files modified components.api (+2/-0) debian/control (+1/-0) debian/qml-module-ubuntu-components.install (+1/-0) src/Ubuntu/Components/Components.pro (+2/-1) src/Ubuntu/Components/lttng/lttng.pro (+9/-0) src/Ubuntu/Components/lttng/tracepoints.c (+21/-0) src/Ubuntu/Components/lttng/uclttng_tp.h (+37/-0) src/Ubuntu/Components/plugin/plugin.cpp (+11/-0) src/Ubuntu/Components/plugin/plugin.pri (+9/-2) src/Ubuntu/Components/plugin/uclttng.cpp (+104/-0) src/Ubuntu/Components/plugin/uclttng.h (+38/-0)
To merge this branch:	bzr merge lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
ubuntu-sdk-build-bot	continuous-integration		Approve on 2016-06-30
Cris Dywan		2016-06-29	Needs Fixing on 2016-06-30
Loïc Molinari		2016-07-01	Pending
Review via email: mp+298618@code.launchpad.net

Commit message

Add LTTNG.userInterfaceReady

With it developers can signal to lttng that their UI is ready

Description of the change

Can be tested with http://paste.ubuntu.com/18089961/

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-29

2023. By Albert Astals Cid on 2016-06-29: Update components.api

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2022
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/971/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4117/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/971/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2022
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/781/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4118/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/781/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2022
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1000/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4119/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1000/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2022
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/755/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4120/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/755/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/500/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2023
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1002/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4128/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1002/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2023
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/973/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4129/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/973/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2023
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/783/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4130/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/783/rebuild

review: Needs Fixing (continuous-integration)

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-29

2024. By Albert Astals Cid on 2016-06-29: install the .so and only create one .so

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2023
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/757/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4132/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/757/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/501/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2024
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/977/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4136/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/977/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2024
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1005/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4140/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1005/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2024
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/786/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4141/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/786/rebuild

review: Needs Fixing (continuous-integration)

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-29

2025. By Albert Astals Cid on 2016-06-29: the world is too pedantic and makes me waste time

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2024
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/760/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4142/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/760/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/502/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2025
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1006/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4145/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1006/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2025
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/787/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4146/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/787/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2025
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/978/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4147/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/978/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2025
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/761/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4148/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/761/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/503/rebuild

review: Needs Fixing (continuous-integration)

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-29

2026. By Albert Astals Cid on 2016-06-29: soname without version

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1008/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4154/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1008/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/789/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4155/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/789/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

FAILED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/980/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4156/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/980/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/763/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4157/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/763/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-29:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/504/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1010/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4162/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1010/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/791/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4163/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/791/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/765/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4164/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/765/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2026
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/982/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4165/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/982/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/505/rebuild

review: Approve (continuous-integration)

Revision history for this message

Florian Boucault (fboucault) wrote on 2016-06-30:

#ifndef UPM_RENDERING_TIMES_LTTNG_H seems incorrect

Revision history for this message

Florian Boucault (fboucault) wrote on 2016-06-30:

Needs documentation: 1 example + a short explanation of where it is typically used

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-06-30:

Me thinks this could live in PerformanceMetrics since it's another aspect of "how to measure performance".

Examples would be nice, for instance "If used in a messaging application, ready could mean that all visible messages are rendered on screen. In a camera use case, once the view finder shows a picture it's ready to use."
Maybe once this lands we can have a blog post with some code patterns to answer those questions, some of which might not be trivial.

Should lttng be in Recommends? To ensure it's available on a developer machine, albeit not required. And I'll assume it's seeded on phone images?

review: Needs Fixing

Revision history for this message

Florian Boucault (fboucault) wrote on 2016-06-30:

Loic is thinking that we might have a Ubuntu.Metrics module in the future. Maybe it belongs there rather than in Ubuntu.Components

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-30

2027. By Albert Astals Cid on 2016-06-30: fix the ifdef/define
2028. By Albert Astals Cid on 2016-06-30: Add code/documentation

Revision history for this message

Albert Astals Cid (aacid) wrote on 2016-06-30:

> #ifndef UPM_RENDERING_TIMES_LTTNG_H seems incorrect

Fixed

Revision history for this message

Albert Astals Cid (aacid) wrote on 2016-06-30:

> Needs documentation: 1 example + a short explanation of where it is typically
> used

Added some documentation, please review

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2027
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1013/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4175/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1013/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2027
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/794/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4176/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/794/rebuild

review: Approve (continuous-integration)

lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint updated on 2016-06-30

2029. By Albert Astals Cid on 2016-06-30: Add Recommends as per kalikiana's suggestion

Revision history for this message

Albert Astals Cid (aacid) wrote on 2016-06-30:

> Me thinks this could live in PerformanceMetrics since it's another aspect of
> "how to measure performance".

I'm going to need someone else to make the decision:
A) leave it here
B) Move it to PerformanceMetrics
C) Create a new Metrics module that Loic will later extend

Who can make a call on this?

> Examples would be nice, for instance "If used in a messaging application,
> ready could mean that all visible messages are rendered on screen. In a camera
> use case, once the view finder shows a picture it's ready to use."
> Maybe once this lands we can have a blog post with some code patterns to
> answer those questions, some of which might not be trivial.

I think the "That is the program has loaded enough buttons, labels, etc. so that the user can now start using it." should be enough for people to understand it, but if you have a better wording/suggestion i'm open to adding that instead.

>
> Should lttng be in Recommends? To ensure it's available on a developer
> machine, albeit not required. And I'll assume it's seeded on phone images?

Added as Recommends, liblttng-ust0 is required by lots of stuff on the phone, so yes it's already in the image.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2027
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/985/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4177/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/985/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2027
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/768/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4178/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/768/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/506/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2029
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1014/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4180/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1014/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2029
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/795/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4181/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/795/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2029
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/986/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4182/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/986/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

PASSED: Continuous integration, rev:2029
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/769/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4183/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/769/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-06-30:

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/507/rebuild

review: Approve (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-06-30:

> > Me thinks this could live in PerformanceMetrics since it's another aspect of
> > "how to measure performance".
>
> I'm going to need someone else to make the decision:
> A) leave it here
> B) Move it to PerformanceMetrics
> C) Create a new Metrics module that Loic will later extend
>
> Who can make a call on this?

A new module should have good reason to be added. Right now it's a single function.

Is there an argument warranting a new module? Florian didn't seem to have a strong opinion when I asked him.
How would "Metrics" differ from "PerformanceMetrics"? That'd be a very bad and confusing name to be honest.

Revision history for this message

Albert Astals Cid (aacid) wrote on 2016-07-01:

Loic can you comment on why we would need a new module?

Revision history for this message

Loïc Molinari (loic.molinari) wrote on 2016-08-09:

The metrics library is now ready to be reviewed here [1]. Maybe we can discuss the naming there, the main reason being that it contains all kind of metrics (to be either logged to various devices and rendered as an overlay on top of QtQuick windows).

In light of this new library, I think it makes it's more consistent to integrate the feature proposed in this MR directly with the new library. So, Albert, I basically ported and integrated your nice work to the new lib in these 3 MRs [2][3][4].

[1] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics/+merge/302362
[2] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-lttng/+merge/302363
[3] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-generic-events/+merge/302364
[4] https://code.launchpad.net/~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-module/+merge/302365

Revision history for this message

Albert Astals Cid (aacid) wrote on 2016-08-09:

Ok, abandoned this MR

Unmerged revisions

2029. By Albert Astals Cid on 2016-06-30

Add Recommends as per kalikiana's suggestion

2028. By Albert Astals Cid on 2016-06-30

Add code/documentation

2027. By Albert Astals Cid on 2016-06-30

fix the ifdef/define

2026. By Albert Astals Cid on 2016-06-29

soname without version

2025. By Albert Astals Cid on 2016-06-29

the world is too pedantic and makes me waste time

2024. By Albert Astals Cid on 2016-06-29

install the .so and only create one .so

2023. By Albert Astals Cid on 2016-06-29

Update components.api

2022. By Albert Astals Cid on 2016-06-29

Add LTTNG.userInterfaceReady

With it developers can signal to lttng that their UI is ready

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Albert Astals Cid

Dan Chapman 

Tom Mirmar

Ubuntu SDK team

 === modified file 'components.api'
 --- components.api	2016-06-27 10:03:01 +0000
 +++ components.api	2016-06-30 12:40:45 +0000
@@ -489,6 +489,8 @@
      property var model
      property bool multiSelection
      property int selectedIndex
++Ubuntu.Components.LTTNG 1.3: QtObject singleton
++    function userInterfaceReady()
  Ubuntu.Components.Label 1.0 0.1: Text
      property string fontSize
  Ubuntu.Components.Label 1.3 UbuntuToolkit::UCLabel: Text
 === modified file 'debian/control'
 --- debian/control	2016-06-24 13:10:20 +0000
 +++ debian/control	2016-06-30 12:40:45 +0000
@@ -83,6 +83,7 @@
           ubuntu-ui-toolkit-theme (= ${binary:Version}),
           ${misc:Depends},
           ${shlibs:Depends},
++Recommends: liblttng-ust0,
  Conflicts: qt-components-ubuntu,
  Breaks: qtdeclarative5-ubuntu-ui-toolkit-plugin (<< ${source:Version}),
  Replaces: qt-components-ubuntu,
 === modified file 'debian/qml-module-ubuntu-components.install'
 --- debian/qml-module-ubuntu-components.install	2016-06-23 09:13:51 +0000
 +++ debian/qml-module-ubuntu-components.install	2016-06-30 12:40:45 +0000
@@ -22,6 +22,7 @@
  usr/lib/*/qt5/qml/Ubuntu/Components/Styles/qmldir
  usr/lib/*/qt5/qml/Ubuntu/Components/artwork
  usr/lib/*/qt5/qml/Ubuntu/Components/libUbuntuComponents.so
++usr/lib/*/qt5/qml/Ubuntu/Components/libUbuntuComponentsLTTNG.so
  usr/lib/*/qt5/qml/Ubuntu/Components/plugins.qmltypes
  usr/lib/*/qt5/qml/Ubuntu/Components/qmldir
  usr/share/locale/*/LC_MESSAGES/ubuntu-ui-toolkit.mo
 === modified file 'src/Ubuntu/Components/Components.pro'
 --- src/Ubuntu/Components/Components.pro	2016-06-23 13:37:24 +0000
 +++ src/Ubuntu/Components/Components.pro	2016-06-30 12:40:45 +0000
@@ -6,4 +6,5 @@
             Popups    \
             Styles    \
             Themes    \
--           Labs
++           Labs      \
++           lttng
 === added directory 'src/Ubuntu/Components/lttng'
 === added file 'src/Ubuntu/Components/lttng/lttng.pro'
 --- src/Ubuntu/Components/lttng/lttng.pro	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/lttng/lttng.pro	2016-06-30 12:40:45 +0000
@@ -0,0 +1,9 @@
++TEMPLATE = lib
++TARGET  = UbuntuComponentsLTTNG
++SOURCES = tracepoints.c
++LIBS += -llttng-ust
++CONFIG -= create_prl
++CONFIG += unversioned_libname
++
++target.path = $$[QT_INSTALL_QML]/Ubuntu/Components
++INSTALLS += target
 === added file 'src/Ubuntu/Components/lttng/tracepoints.c'
 --- src/Ubuntu/Components/lttng/tracepoints.c	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/lttng/tracepoints.c	2016-06-30 12:40:45 +0000
@@ -0,0 +1,21 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ *
++ */
++
++/* The probes need to be compiled in a C file (not C++) */
++#define TRACEPOINT_CREATE_PROBES
++
++#include "uclttng_tp.h"
 === added file 'src/Ubuntu/Components/lttng/uclttng_tp.h'
 --- src/Ubuntu/Components/lttng/uclttng_tp.h	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/lttng/uclttng_tp.h	2016-06-30 12:40:45 +0000
@@ -0,0 +1,37 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ *
++ */
++
++#undef TRACEPOINT_PROVIDER
++#define TRACEPOINT_PROVIDER uc_lttng
++
++#if !defined(UC_LTTNG_TP_H_) || defined(TRACEPOINT_HEADER_MULTI_READ)
++#define UC_LTTNG_TP_H_
++
++#include <lttng/tracepoint.h>
++
++TRACEPOINT_EVENT(uc_lttng, user_interface_ready,
++	TP_ARGS(),
++	TP_FIELDS()
++)
++
++#endif
++
++#undef TRACEPOINT_INCLUDE
++#define TRACEPOINT_INCLUDE "./uclttng_tp.h"
++
++/* This part must be outside ifdef protection */
++#include <lttng/tracepoint-event.h>
 === modified file 'src/Ubuntu/Components/plugin/plugin.cpp'
 --- src/Ubuntu/Components/plugin/plugin.cpp	2016-06-21 14:21:46 +0000
 +++ src/Ubuntu/Components/plugin/plugin.cpp	2016-06-30 12:40:45 +0000
@@ -17,10 +17,19 @@
  #include <QtQml/QQmlEngine>
  #include "plugin.h"
++#include "uclttng.h"
  #include "ucnamespace.h"
  #include <ubuntutoolkitmodule.h>
  #include <ubuntugesturesmodule.h>
++static QObject *lttng_singleton_provider(QQmlEngine *engine, QJSEngine *scriptEngine)
++{
++    Q_UNUSED(engine)
++    Q_UNUSED(scriptEngine)
++
++    return new UbuntuComponentsLTTNG();
++}
++
  UbuntuComponentsPlugin::~UbuntuComponentsPlugin()
+ {
      UT_PREPEND_NAMESPACE(UbuntuToolkitModule)::undefineModule();
@@ -34,6 +43,8 @@
      qmlRegisterSimpleSingletonType<UbuntuToolkit::UCNamespace>(uri, 1, 2, "Ubuntu");
      qmlRegisterSimpleSingletonType<UbuntuToolkit::UCNamespaceV13>(uri, 1, 3, "Ubuntu");
++    qmlRegisterSingletonType<UbuntuComponentsLTTNG>(uri, 1, 3, "LTTNG", lttng_singleton_provider);
++
      UG_PREPEND_NAMESPACE(UbuntuGesturesModule)::defineModule(uri);
      UT_PREPEND_NAMESPACE(UbuntuToolkitModule)::defineModule();
 === modified file 'src/Ubuntu/Components/plugin/plugin.pri'
 --- src/Ubuntu/Components/plugin/plugin.pri	2016-06-17 15:55:58 +0000
 +++ src/Ubuntu/Components/plugin/plugin.pri	2016-06-30 12:40:45 +0000
@@ -5,12 +5,19 @@
      QT += v8-private
+ }
++DEFINES += LTTNG_INSTALL_LIB_PATH=\\\"$$[QT_INSTALL_QML]/$$TARGETPATH/libUbuntuComponentsLTTNG.so\\\"
++DEFINES += LTTNG_BUILD_LIB_PATH=\\\"$$OUT_PWD/lttng/libUbuntuComponentsLTTNG.so\\\"
++
  CONFIG += no_keywords c++11
  INCLUDEPATH+=$$PWD
  HEADERS += $$PWD/plugin.h \
--    $$PWD/ucnamespace.h
++    $$PWD/ucnamespace.h \
++    $$PWD/uclttng.h
  SOURCES += $$PWD/plugin.cpp \
--    $$PWD/ucnamespace.cpp
++    $$PWD/ucnamespace.cpp \
++    $$PWD/uclttng.cpp
++
++LIBS += -ldl
 \ No newline at end of file
 === added file 'src/Ubuntu/Components/plugin/uclttng.cpp'
 --- src/Ubuntu/Components/plugin/uclttng.cpp	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/plugin/uclttng.cpp	2016-06-30 12:40:45 +0000
@@ -0,0 +1,104 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ *
++ */
++
++#include "uclttng.h"
++
++#include <QDebug>
++#include <QtCore/qmath.h>
++
++#include <dlfcn.h>
++
++#define TRACEPOINT_DEFINE
++#define TRACEPOINT_PROBE_DYNAMIC_LINKAGE
++#include "../lttng/uclttng_tp.h"
++
++/*!
++ * \qmltype LTTNG
++ * \instantiates UbuntuComponentsLTTNG
++ * \inqmlmodule Ubuntu.Components
++ * \ingroup ubuntu
++ * \brief Singleton to emit LTTNG tracepoints.
++ *
++ * Logging to LTTNG can be useful for posterior analysis. This class
++ * provides a singleton that can be used to emit LTTNG tracepoints (at
++ * this point only the userInterfaceReady one).
++ *
++ * Example:
++ * \qml
++ * import QtQuick 2.4
++ * import Ubuntu.Components 1.3
++ *
++ * MainView {
++ *     width: units.gu(48)
++ *     height: units.gu(60)
++ *     Page {
++ *         header: PageHeader {
++ *             id: pageHeader
++ *             title: "Simple page"
++ *         }
++ *         Button {
++ *             anchors {
++ *                 horizontalCenter: parent.horizontalCenter
++ *                 top: pageHeader.bottom
++ *                 topMargin: units.gu(5)
++ *             }
++ *             width: units.gu(15)
++ *             text: "Push me"
++ *         }
++ *     }
++ *     Component.onCompleted: LTTNG.userInterfaceReady();
++ * }
++ * \endqml
++ */
++UbuntuComponentsLTTNG::UbuntuComponentsLTTNG(QObject* parent) :
++    QObject(parent),
++    m_lttngLib(nullptr),
++    m_lttngLibLoadTried(false)
++{
++}
++
++UbuntuComponentsLTTNG::~UbuntuComponentsLTTNG()
++{
++    dlclose(m_lttngLib);
++}
++
++/*!
++ * \qmlmethod void LTTNG::userInterfaceReady()
++ * Logs an LTTNG tracepoint about the user interface being ready. That is
++ * the program has loaded enough buttons, labels, etc. so that
++ * the user can now start using it.
++ */
++void UbuntuComponentsLTTNG::userInterfaceReady()
++{
++    if (!m_lttngLib && !m_lttngLibLoadTried) {
++        m_lttngLibLoadTried = true;
++
++        m_lttngLib = dlopen(LTTNG_INSTALL_LIB_PATH, RTLD_NOW);
++        if (!m_lttngLib) {
++            qWarning() << "Failed to load installed tracepoint provider: " << dlerror();
++            qWarning() << "Trying with build time one";
++
++            m_lttngLib = dlopen(LTTNG_BUILD_LIB_PATH, RTLD_NOW);
++            if (!m_lttngLib) {
++                qWarning() << "Failed to load build time tracepoint provider: " << dlerror();
++            }
++        }
++    }
++    if (m_lttngLib) {
++        tracepoint(uc_lttng, user_interface_ready);
++    }
++}
 === added file 'src/Ubuntu/Components/plugin/uclttng.h'
 --- src/Ubuntu/Components/plugin/uclttng.h	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/plugin/uclttng.h	2016-06-30 12:40:45 +0000
@@ -0,0 +1,38 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ *
++ */
++
++#ifndef UCLTTNG_H
++#define UCLTTNG_H
++
++#include <QObject>
++
++class UbuntuComponentsLTTNG : public QObject
++{
++    Q_OBJECT
++
++public:
++    explicit UbuntuComponentsLTTNG(QObject* parent = 0);
++    ~UbuntuComponentsLTTNG();
++
++    Q_INVOKABLE void userInterfaceReady();
++
++private:
++    void* m_lttngLib;
++    bool m_lttngLibLoadTried;
++};
++
++#endif