Code review comment for lp:~aacid/ubuntu-ui-toolkit/lttng_ui_ready_tracepoint

Revision history for this message
Albert Astals Cid (aacid) wrote :

> Me thinks this could live in PerformanceMetrics since it's another aspect of
> "how to measure performance".

I'm going to need someone else to make the decision:
 A) leave it here
 B) Move it to PerformanceMetrics
 C) Create a new Metrics module that Loic will later extend

Who can make a call on this?

> Examples would be nice, for instance "If used in a messaging application,
> ready could mean that all visible messages are rendered on screen. In a camera
> use case, once the view finder shows a picture it's ready to use."
> Maybe once this lands we can have a blog post with some code patterns to
> answer those questions, some of which might not be trivial.

I think the "That is the program has loaded enough buttons, labels, etc. so that the user can now start using it." should be enough for people to understand it, but if you have a better wording/suggestion i'm open to adding that instead.

>
> Should lttng be in Recommends? To ensure it's available on a developer
> machine, albeit not required. And I'll assume it's seeded on phone images?

Added as Recommends, liblttng-ust0 is required by lots of stuff on the phone, so yes it's already in the image.

« Back to merge proposal