Code review comment for lp:~3v1n0/unity/fix-load-icon-crash-926658

Revision history for this message
Michal Hruby (mhr3) wrote :

Discussed on IRC, but so make sure it doesn't get lost:

1) the model can change, you need to listen to changed signal
2) in the weak notify callback you're basically iterating over the model, which you can't since the model is already dead

review: Needs Fixing

« Back to merge proposal