Code review comment for lp:~3v1n0/unity/fix-load-icon-crash-926658

Revision history for this message
Michal Hruby (mhr3) wrote :

> I've reffed the model in ModelRowAdaptor... As you said it's not the full
> solution, but it's something we can safely do anyway. Let me know if this is
> better for you.

As mentioned on IRC, I'd rather see a *single* weak ref on the model in LensView? than this. (since adding a reference for each model row isn't a good idea)

review: Needs Fixing

« Back to merge proposal