Code review comment for lp:~3v1n0/unity/fix-load-icon-crash-926658

Revision history for this message
Michal Hruby (mhr3) wrote :

Sorry, but I don't like this one bit, dee_model_get_tag can crash if the passed model is not valid (already unreferenced). IMO guarding against null is not going to help, you'll just push the crash to a different place (in the better case, in worse you'll mask the underlying problem completely and there'll be even more random crashes).

review: Needs Fixing

« Back to merge proposal