Compiz Core

Menu shadow clipping flickers while switching menubar items/indicators

Bug #978900 reported by Andrea Cimitan
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Low
Sam Spilsbury
Compiz 0.9.8.0
Compiz Core
Status tracked in 0.9.7
0.9.7
Fix Released
Low
Sam Spilsbury
Compiz Core 0.9.7.8 "SRU-0"
Arch Linux
New
Undecided
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Low quality look and feel - While scrubbing between panel menu items, the menu shadow seems unclipped for fractions of a second.

[Development Fix]
Revision 3094 of lp:compiz-core (both 0.9.7 and 0.9.8 series). smspillaz: It was possible that the requested paint region would never intersect the allowed region for shadows so windows would always be painted with full shadows. (eg, shadowRegion is a region with a big hole in the middle, and requested paints fell within that hole). Solution: Intersect against the full output region when checking whether to use the offset region provided.

[Stable Fix]
As above.

[Test Case]
1. Scrub through panel menus and watch carefully where the top menu shadow would overdraw the Unity panel.
2. Verify that no top shadow appears over the panel, even for a fraction of a second.

[Regression Potential]
Low/Unknown. The fix has been tested and appears to work. Worst possible case would be that parts of window/menu shadows are not drawn.

ORIGINAL DESCRIPTION:
While switching menuitems, the shadow seems unclipped for fractions of a second. The video will highlight the bug clearly.

See original description

Related branches

lp:~smspillaz/compiz-core/compiz-core.fix_978900
Daniel van Vugt: Approve
Alan Griffiths: Approve
Diff: 89 lines (+27/-24)
1 file modified
plugins/decor/src/decor.cpp (+27/-24)
lp:compiz-core
lp:~compiz/compiz/ubuntu
lp:ubuntu/precise-proposed/compiz
Revision history for this message
Andrea Cimitan (cimi) wrote :
Revision history for this message
Andrea Cimitan (cimi) wrote :

https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.fix_978900 branch fixes the bug for me

Daniel van Vugt (vanvugt)
Changed in compiz-core:
assignee: nobody → Sam Spilsbury (smspillaz)
status: New → In Progress
milestone: none → 0.9.7.8
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed into lp:compiz-core at revision 3094

Changed in compiz-core:
importance: Undecided → Low
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix released in Compiz Core 0.9.7.8.

Daniel van Vugt (vanvugt)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted compiz into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in compiz (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
jhfhlkjlj (fdsuufijjejejejej-deactivatedaccount) wrote :

fixed!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.7.8-0ubuntu1

---------------
compiz (1:0.9.7.8-0ubuntu1) precise-proposed; urgency=low

  [ Didier Roche ]
  * New upstream bug fix release:
    - [fglrx] Title bar does not update on non-maximized windows (LP: #770283)
    - Some apps (like Remmina) can't full-screen under Compiz (or Unity)
      (LP: #946388)
    - Compiz-core fails to compile with gcc-4.7 - 'cc1plus: all warnings
      being treated as errors' (LP: #972519)
    - Menu shadow clipping flickers while switching menubar items/indicators
      (LP: #978900)
    - Compiz should not move windows to workspace 0,0 when restarted
      (LP: #980026)
    - regression / unable to interact with window-titlebar (window decoration)
      after minimizing/unminimizing gnome-terminal (LP: #981703)
  * debian/patches/workaround_770283.patch,
    debian/patches/fix_976467.patch:
    - removed, upstreamed

  [ Oliver Grawert ]
  * update the GLES2 patch for the new upstream release.

compiz (1:0.9.7.6-0ubuntu2) precise-proposed; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * debian/patches/workaround_770283.patch:
    - Workaround a problem with fglrx not refreshing window decoration textures
      on pixmap modification (LP: #770283)

  [ Oliver Grawert ]
  * update GLES patch for new quilt patch, fix issue with GLES patch that
    forcefully unapplied other quilt patches and resulted in
    gtk-window-decorator to not be started.
 -- Didier Roche <email address hidden> Thu, 26 Apr 2012 09:19:51 +0200

Changed in compiz (Ubuntu):
status: New → Fix Released
Changed in compiz (Ubuntu Precise):
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in compiz:
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → Sam Spilsbury (smspillaz)
milestone: none → 0.9.8.0
no longer affects: compiz-core/0.9.8
Daniel van Vugt (vanvugt)
Changed in compiz-core:
milestone: 0.9.8.0 → none
Revision history for this message
MC Return (mc-return) wrote :

For me (using Emerald) and vanvugt compiz ppa this fix does not work.
For a short period of time the shadow/glow gets rendered on top of the panel before it disappears...
Switching panel menu makes the shadow/glow reappear for 0.5 secs before it disappears...

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

My PPA is out of date and not being maintained so please don't use it as a comparison for anything right now.

Also, this bug is Fix Released. If you have any on-going issues then please log them as new bugs.

Daniel van Vugt (vanvugt)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.